GNU bug report logs - #20908
25.0.50; gnutls-negotiate error "Invalid format operation %u"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20908 in the body.
You can then email your comments to 20908 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: lo2net <fangtao0901 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; gnutls-negotiate error "Invalid format operation %u"
Date: Sat, 27 Jun 2015 11:55:43 +0800

[Message part 1 (text/plain, inline)]

Hi all,
I've got a problem: when using (gnutls-negotiate :verify-error t) to initialize a SSL/TLS
connection , server has an expired certificate cause gnutls-boot signal
an error "Invalid format operation %u", apparently it's not related to
gnutls-error. So digging into the source
code, here is the error signal:

src/gnutls.c:1511

      if (verify_error_all
          || !NILP (Fmember (QCgnutls_bootprop_trustfiles, verify_error)))
        {
	  emacs_gnutls_deinit (proc);
	  error ("Certificate validation failed %s, verification code %u",
		 c_hostname, peer_verification);
        }

After checking elisp manual and source code, function Fformat(error call
it to format string) does not
support '%u', here should using '%d' instead.

I made a simple patch for this:

[0001-gnutls-boot-fix-error-Invalid-format-operation-u-whe.patch (text/plain, attachment)]

Message #10 received at 20908-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: lo2net <fangtao0901 <at> gmail.com>
Cc: 20908-done <at> debbugs.gnu.org
Subject: Re: bug#20908: 25.0.50;
 gnutls-negotiate error "Invalid format operation %u"
Date: Sat, 27 Jun 2015 11:05:19 +0300

> From: lo2net <fangtao0901 <at> gmail.com>
> Date: Sat, 27 Jun 2015 11:55:43 +0800
> 
> I've got a problem: when using (gnutls-negotiate :verify-error t) to initialize a SSL/TLS
> connection , server has an expired certificate cause gnutls-boot signal
> an error "Invalid format operation %u", apparently it's not related to
> gnutls-error. So digging into the source
> code, here is the error signal:
> 
> src/gnutls.c:1511
> 
>       if (verify_error_all
>           || !NILP (Fmember (QCgnutls_bootprop_trustfiles, verify_error)))
>         {
> 	  emacs_gnutls_deinit (proc);
> 	  error ("Certificate validation failed %s, verification code %u",
> 		 c_hostname, peer_verification);
>         }
> 
> After checking elisp manual and source code, function Fformat(error call
> it to format string) does not
> support '%u', here should using '%d' instead.
> 
> I made a simple patch for this:

Thanks.  I used %x instead of %d in the change I just pushed, because
the peer_verification value is actually a bitwise OR of the various
bits, so displaying it in hex will make its interpretation easier.

With that, I'm marking this bug done.

Message #13 received at 20908-done <at> debbugs.gnu.org (full text, mbox):

From: tao fang <fangtao0901 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 20908-done <at> debbugs.gnu.org
Subject: Re: bug#20908: 25.0.50; gnutls-negotiate error "Invalid format
 operation %u"
Date: Sat, 27 Jun 2015 20:39:06 +0800

[Message part 1 (text/plain, inline)]

Okay, thanks!

On Sat, Jun 27, 2015 at 4:05 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: lo2net <fangtao0901 <at> gmail.com>
> > Date: Sat, 27 Jun 2015 11:55:43 +0800
> >
> > I've got a problem: when using (gnutls-negotiate :verify-error t) to
> initialize a SSL/TLS
> > connection , server has an expired certificate cause gnutls-boot signal
> > an error "Invalid format operation %u", apparently it's not related to
> > gnutls-error. So digging into the source
> > code, here is the error signal:
> >
> > src/gnutls.c:1511
> >
> >       if (verify_error_all
> >           || !NILP (Fmember (QCgnutls_bootprop_trustfiles,
> verify_error)))
> >         {
> >         emacs_gnutls_deinit (proc);
> >         error ("Certificate validation failed %s, verification code %u",
> >                c_hostname, peer_verification);
> >         }
> >
> > After checking elisp manual and source code, function Fformat(error call
> > it to format string) does not
> > support '%u', here should using '%d' instead.
> >
> > I made a simple patch for this:
>
> Thanks.  I used %x instead of %d in the change I just pushed, because
> the peer_verification value is actually a bitwise OR of the various
> bits, so displaying it in hex will make its interpretation easier.
>
> With that, I'm marking this bug done.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.