GNU bug report logs - #20896
25.0.50; [js-mode][FR] support chain syntax indentation

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Tom Tromey <tom <at> tromey.com>, 20896 <at> debbugs.gnu.org
Cc: Daniel Colascione <dan.colascione <at> gmail.com>
Subject: bug#20896: patch to add chained indentation
Date: Thu, 12 Jan 2017 04:57:49 +0300

On 10.01.2017 09:29, Tom Tromey wrote:
> This patch adds chained indentation, as requested in the bug.

Thanks.

> It comes
> with some tests

I'd just like to point out that it's much better to write indentation 
tests in the format used by test/manual/indent/js*.

> (added to a file that first appears in patch in another
> bug

Not sure which patch you mean. This file seems new.

As for review: js--skip-term-backward seems to be doing something 
similar to the loop in js--multi-line-declaration-indentation.

Maybe a extraction and unification is in order.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.