From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 11:38:19 2015 Received: (at submit) by debbugs.gnu.org; 25 Jun 2015 15:38:20 +0000 Received: from localhost ([127.0.0.1]:57382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z89EI-0006As-RP for submit@debbugs.gnu.org; Thu, 25 Jun 2015 11:38:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39779) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z89EG-0006Ae-MC for submit@debbugs.gnu.org; Thu, 25 Jun 2015 11:38:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z89EA-00008Z-Iw for submit@debbugs.gnu.org; Thu, 25 Jun 2015 11:38:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z89EA-00008V-Fw for submit@debbugs.gnu.org; Thu, 25 Jun 2015 11:38:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z89E9-0007T0-Dv for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 11:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z89E4-00005y-9k for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 11:38:09 -0400 Received: from mout.gmx.net ([212.227.15.18]:55136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z89E3-00005h-Ve for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 11:38:04 -0400 Received: from x200s ([90.163.164.75]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MQyxa-1ZVqUA1Mju-00UIn4 for ; Thu, 25 Jun 2015 17:38:03 +0200 From: Rasmus To: bug-gnu-emacs@gnu.org Subject: 25.0.50; [js-mode][FR] support chain syntax indentation Date: Thu, 25 Jun 2015 17:37:51 +0200 Message-ID: <87a8vnlrxs.fsf@gmx.us> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:bI5S21QY1xhL3x8pDq/s/RekZTzUI8E1v4mSFgoLmbEncxNAMDR 6CMoD+Xj5SB4LqtWc/5EKN2MDeFaEOaWCp4TeKu85+EJrogWc8v3bng3wld8wEfcNGi5sHJ 1FCEHb9goLKTArIUiMZvL0Ja/1QvntmGw9qrgx9mpXu6kYJRdRwHcfGjqLP/KImU3otCK1u iBsqkiJMtsTRdzdPNNZEg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VppCmx4bW0M=:7vDzFCATl0qfoEiUX4T53E c0ucLAt71KiaGmD3jLAkmUzmbtjmSiDsx219Eg0wqgKpvK7kBJ+FQ4qDA/ttkv4tHD6XCRqpY 7/UKayCwl2sJyoapbVjDoYCTAWFL/ETfc9ck9lzEMBRFON7DDGREgjhrTAUgWL1Db1cjH+ozx qXpf9vP72NO7g4y+kEyUUTUHRM5Ygab/nfnflxxBj4/VcraUCoZ6TBCrxsjKG5xzm8W74Nudb QsvIL/SdWiHZ/gAt8neKrDC40D/YFWDlmaDRtbsb0X1e5Dj0xDktDNxa4q74uIbv94Yrgqq1l dGebC04ikkQ4/ypGKfDelTqfxedk0oSvLyNPhC178VAySkdgkcVq09w5j0R0p96tD+Uf7x7n1 XClKQFzDRroj8pDRFAEmM7mSQxn/0lieFX32mIWDVatS1tAi3NwAU7Qwa4iROgy0YEhweXLkE cc7zpwfbBHbT1w9KOHPyIFovrXBcQjK1cwdDkwkuLR191vGUrMCps/FRd4RkZLNMP91qRGuYk y2+gc4cRueCF+k6jyvtMUUGFanVw8uaeSZT9znDg7NA3uMe0czPFQkTbyq13aDIw5alM7hJ0n wvXk0VMlXPWXBaRT7eo5+aY0V80lJoc6C9jzqrc9ANExkpnMk6ZndPjn8Fah8rFRpg2zx2PHS nIG/J7rS9KYcoABB2uLSAz91caC2cICgvhcsh+EcAPV+CCRVIdvcQRYmNjRPfPvtF6Kk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hi, I would be lovely if js-mode would support the chain-syntax used by the d3.js library. d3.js is used to making svg graphics. The syntax is very readable if indentation is right: var points = svg.selectAll(".scatter-dots") .data(data) .enter().append("path") .more_funs(); var an_axis = axes.append("g") .call(d3.svg.axis() .scale(Scale) .orient("bottom")); Usually calls are factored out so the latter example is not so important to be able to match. Just aligning on the first dot on the previous line would be a big step forward. I don't know if this is useful for other JS libraries than d3. Some d3 documentation mentioned this selector-mechanism was inspired by jQuery, but I don't know this library well enough to say whether it would be useful with that. Thanks, Rasmus -- Not everything that goes around comes back around, you know From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 20:30:24 2015 Received: (at submit) by debbugs.gnu.org; 26 Jun 2015 00:30:25 +0000 Received: from localhost ([127.0.0.1]:57624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8HXD-00057b-AO for submit@debbugs.gnu.org; Thu, 25 Jun 2015 20:30:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57010) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8HX9-00056V-Hg for submit@debbugs.gnu.org; Thu, 25 Jun 2015 20:30:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8HX3-0006na-9w for submit@debbugs.gnu.org; Thu, 25 Jun 2015 20:30:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: *** X-Spam-Status: No, score=3.5 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FSL_HELO_BARE_IP_2,RCVD_NUMERIC_HELO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8HX3-0006nP-6d for submit@debbugs.gnu.org; Thu, 25 Jun 2015 20:30:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8HX2-0002XK-B9 for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 20:30:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8HWz-0006gt-5O for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 20:30:12 -0400 Received: from plane.gmane.org ([80.91.229.3]:36661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8HWy-0006ey-V3 for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 20:30:09 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Z8HIL-0000cC-3T for bug-gnu-emacs@gnu.org; Fri, 26 Jun 2015 02:15:01 +0200 Received: from 90.163.164.75 ([90.163.164.75]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 26 Jun 2015 02:15:01 +0200 Received: from rasmus by 90.163.164.75 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 26 Jun 2015 02:15:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Rasmus Subject: Re: bug#20896: 25.0.50; [js-mode][FR] support chain syntax indentation Date: Fri, 26 Jun 2015 02:14:51 +0200 Lines: 32 Message-ID: <87zj3niav8.fsf@gmx.us> References: <87a8vnlrxs.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 90.163.164.75 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:vOj9KKP7hCRA6AL222XxoF3bBE4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) Hi, Rasmus writes: > var an_axis = axes.append("g") > .call(d3.svg.axis() > .scale(Scale) > .orient("bottom")); Actually, this case is not as crazy as first assumed and should ideally be supported. Here's a pretty reasonable example (except for names being too long): plot.axes.yScale = d3.scale.ordinal() .domain(d3.range(bar.ybins).map(function(d){return d*10;})) .range(d3.range(bar.ybins) .map(function(d,i) { return plot.height-plot.height/bar.ybins * i;})); Also, notice there's another, potential, indentation typo in this code. The last "return" should be one character to the right IMO, i.e. .map(function(d,i) { return plot.height-plot.height/bar.ybins * i;})); Thanks, Rasmus -- Dung makes an excellent fertilizer From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 10 01:29:39 2017 Received: (at 20896) by debbugs.gnu.org; 10 Jan 2017 06:29:39 +0000 Received: from localhost ([127.0.0.1]:48344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQpwB-0005yf-1b for submit@debbugs.gnu.org; Tue, 10 Jan 2017 01:29:39 -0500 Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55]:36133) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cQpw8-0005yP-HC for 20896@debbugs.gnu.org; Tue, 10 Jan 2017 01:29:37 -0500 Received: (qmail 13688 invoked by uid 0); 10 Jan 2017 06:29:27 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy5.mail.unifiedlayer.com with SMTP; 10 Jan 2017 06:29:27 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id WWVQ1u0042f2jeq01WVT2H; Mon, 09 Jan 2017 23:29:27 -0700 X-Authority-Analysis: v=2.1 cv=SY5kKJhu c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=2JzSmF5pz1Lc-0lVTIoA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:CC:Subject:To:From; bh=LGti+ZQvxbD38hjwV0APJkcm3Ba9ch6dO4bZ1TQYlX8=; b=Nq4XaN4P0FnXlvZmcA1gOYwzo vpzEj/T+mQsasIhbsmyPLt/qveXR8fdrDRYRmJpijk3qomIlM80JRgmHt1W3zlIvqbdqsFnmrMKgt zP5ln+0T+I2WyLmSGzB2G7kx07; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:55852 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cQpvw-0001ix-3I; Mon, 09 Jan 2017 23:29:24 -0700 From: Tom Tromey To: 20896@debbugs.gnu.org Subject: patch to add chained indentation X-Attribution: Tom Date: Mon, 09 Jan 2017 23:29:20 -0700 Message-ID: <87tw97zav3.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cQpvw-0001ix-3I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:55852 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 20896 Cc: Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) This patch adds chained indentation, as requested in the bug. It comes with some tests (added to a file that first appears in patch in another bug -- I can commit these when the time comes, mostly I'm interested in review). Tom diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 0551f2a..1211631 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -552,6 +552,20 @@ js-indent-first-init :safe 'symbolp :group 'js) +(defcustom js-chain-indent nil + "Use \"chained\" indentation. +Chained indentation applies when the current line starts with \".\". +If the previous expression also contains a \".\" at the same level, +then the \".\"s will be lined up: + + let x = svg.mumble() + .chained; +" + :version "26.1" + :type 'boolean + :safe 'booleanp + :group 'js) + ;;; KeyMap (defvar js-mode-map @@ -1808,6 +1822,62 @@ js--continued-expression-p (and (progn (backward-char) (not (looking-at "+\\+\\|--\\|/[/*]")))))))))) +(defun js--skip-term-backward () + "Skip a term before point; return t if a term was skipped." + (let ((term-skipped nil)) + ;; Skip backward over balanced parens. + (let ((progress t)) + (while progress + (setq progress nil) + ;; First skip whitespace. + (skip-syntax-backward " ") + ;; Now if we're looking at closing paren, skip to the opener. + ;; This doesn't strictly follow JS syntax, in that we might + ;; skip something nonsensical like "()[]{}", but it is enough + ;; if it works ok for valid input. + (when (memq (char-before) '(?\] ?\) ?\})) + (setq progress t term-skipped t) + (backward-list)))) + ;; Maybe skip over a symbol. + (let ((save-point (point))) + (if (and (< (skip-syntax-backward "w_") 0) + (looking-at js--name-re)) + ;; Skipped. + (progn + (setq term-skipped t) + (skip-syntax-backward " ")) + ;; Did not skip, so restore point. + (goto-char save-point))) + (when (and term-skipped (> (point) (point-min))) + (backward-char) + (eq (char-after) ?.)))) + +(defun js--skip-terms-backward () + "Skip any number of terms backward. +Move point to the earliest \".\" without changing paren levels. +Returns t if successful, nil if no term was found." + (when (js--skip-term-backward) + ;; Found at least one. + (let ((last-point (point))) + (while (js--skip-term-backward) + (setq last-point (point))) + (goto-char last-point) + t))) + +(defun js--chained-expression-p () + "A helper for js--proper-indentation that handles chained expressions. +A chained expression is when the current line starts with '.' and the +previous line also has a '.' expression. +This function returns the indentation for the current line if it is +a chained expression line; otherwise nil. +This should only be called while point is at the start of the line." + (when js-chain-indent + (save-excursion + (when (and (eq (char-after) ?.) + (js--continued-expression-p) + (js--find-newline-backward) + (js--skip-terms-backward)) + (current-column))))) (defun js--end-of-do-while-loop-p () "Return non-nil if point is on the \"while\" of a do-while statement. @@ -1984,6 +2054,7 @@ js--proper-indentation ;; At or after the first loop? (>= (point) beg) (js--array-comp-indentation bracket beg)))) + ((js--chained-expression-p)) ((js--ctrl-statement-indentation)) ((js--multi-line-declaration-indentation)) ((nth 1 parse-status) diff --git a/test/lisp/progmodes/js-tests.el b/test/lisp/progmodes/js-tests.el index de322f2..effd58c 100644 --- a/test/lisp/progmodes/js-tests.el +++ b/test/lisp/progmodes/js-tests.el @@ -69,6 +69,77 @@ (should (equal (buffer-substring (point-at-bol) (point-at-eol)) "\tdo_something();")))) +(ert-deftest js-mode-indent-bug-20896-chain () + (with-temp-buffer + (js-mode) + (setq-local js-chain-indent t) + (setq-local indent-tabs-mode nil) + (insert "let x = svg.mumble()\n.zzz") + (js-indent-line) + (should (equal (buffer-substring (point-at-bol) (point-at-eol)) + " .zzz")))) + +(ert-deftest js-mode-indent-bug-20896-chain-comment () + (with-temp-buffer + (js-mode) + (setq-local js-chain-indent t) + (setq-local indent-tabs-mode nil) + (insert "let x = svg.mumble() // line comment\n.zzz") + (js-indent-line) + (should (equal (buffer-substring (point-at-bol) (point-at-eol)) + " .zzz")))) + +(ert-deftest js-mode-indent-bug-20896-chain-multi () + (with-temp-buffer + (js-mode) + (setq-local js-chain-indent t) + (setq-local indent-tabs-mode nil) + ;; Must line up to the first "." at the same level. + (insert "let x = svg.selectAll().something()\n.zzz") + (js-indent-line) + (should (equal (buffer-substring (point-at-bol) (point-at-eol)) + " .zzz")))) + +(ert-deftest js-mode-indent-bug-20896-chain-nested () + (with-temp-buffer + (js-mode) + (setq-local js-chain-indent t) + (setq-local indent-tabs-mode nil) + ;; Must line up to the first "." at the same level. + (insert "let x = svg.selectAll(d3.svg.something()\n.zzz") + (js-indent-line) + (should (equal (buffer-substring (point-at-bol) (point-at-eol)) + " .zzz")))) + +(ert-deftest js-mode-indent-bug-20896-no-chain-1 () + (with-temp-buffer + (js-mode) + ;; Don't set js-chain-indent. + (insert "let x = svg.mumble()\n.zzz") + (js-indent-line) + (should (equal (buffer-substring (point-at-bol) (point-at-eol)) + " .zzz")))) + +(ert-deftest js-mode-indent-bug-20896-no-chain-2 () + (with-temp-buffer + (js-mode) + (setq-local js-chain-indent t) + ;; Nothing to chain to. + (insert "let x = svg()\n.zzz") + (js-indent-line) + (should (equal (buffer-substring (point-at-bol) (point-at-eol)) + " .zzz")))) + +(ert-deftest js-mode-indent-bug-20896-no-chain-2 () + (with-temp-buffer + (js-mode) + (setq-local js-chain-indent t) + ;; Nothing to chain to. + (insert "let x = svg().mumble.x() + 73\n.zzz") + (js-indent-line) + (should (equal (buffer-substring (point-at-bol) (point-at-eol)) + " .zzz")))) + (provide 'js-tests) ;;; js-tests.el ends here From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 20:57:59 2017 Received: (at 20896) by debbugs.gnu.org; 12 Jan 2017 01:57:59 +0000 Received: from localhost ([127.0.0.1]:50576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRUeN-0001K5-JH for submit@debbugs.gnu.org; Wed, 11 Jan 2017 20:57:59 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRUeM-0001Js-7O for 20896@debbugs.gnu.org; Wed, 11 Jan 2017 20:57:58 -0500 Received: by mail-lf0-f66.google.com with SMTP id q89so450870lfi.1 for <20896@debbugs.gnu.org>; Wed, 11 Jan 2017 17:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bYDPNbcu/0jJQ5/io7IFtGo2sD6n5MOkvknlhIwMnkk=; b=EhuEQ9G4ESPev5OrIdvUtS5Hx0963GBbNjUqPbedROxVrrktit/wHH7PS2uGhEZYMq 9ML6m5/DDhQAFJ3rBBpSZSrED2Wez5HXFIJi/xGIzYS/D8gyEdPQBIU+4/QbrIj067m6 lPItr0s1SEUlkg02/ahh4Lg0y7OjHyg8R89DEGtqrn/ELsIZkE75fNzkMEenXgYkmzE2 Vs66fsb80eHn8Zr1yqHp9K1VODNVzHRmRVF6BeeOrvJ6CsweJ64Envycwjgmd/LI7DLz ywbVx6RIEt1ffAyeI0SwqYYG0vsrdV9mB4HWeV+cLwlPpVRNoAp+r5CNSKhKOLmyGH4I nkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bYDPNbcu/0jJQ5/io7IFtGo2sD6n5MOkvknlhIwMnkk=; b=TWxCx3O79K0ZmrO2pWWHzCXqHSZIF0/+G6UsTaw++DQWUSc55oNOcUD+MRc+roDNxl 4zbxXFdS31kbVa6UfExersXK6vBPAbN0Xt8xjgP0yA7eYsZAEgE5In1FU2kEvqyyGJZI EQTCmD2+QBIUSQPAuJrVUVw1k8GhLcS/ndyxyFxrMzMugGDtxUzBwUp8T8RevdRBFBs2 MHkyyszNXiOwLaZjQbW8APmfdTCHyOFKGHfgvJENGOgjFPY/pnUp2cdXe3Yc/y08ajcP e1cpzBqMwXMa8VbggqrkgGJhymKbAho5p3Ak0QBZYaLwXbYOp37H9mAVyobML0jmXlA/ k+vw== X-Gm-Message-State: AIkVDXLwvWpPKCXONuFQwE8xl5+MI7LXe2XGKAd9Yyn9wOAPauUSlYOZZzDzK2ovba45hw== X-Received: by 10.25.219.131 with SMTP id t3mr4533825lfi.163.1484186271807; Wed, 11 Jan 2017 17:57:51 -0800 (PST) Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id d79sm1830121lfd.46.2017.01.11.17.57.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jan 2017 17:57:51 -0800 (PST) Subject: Re: bug#20896: patch to add chained indentation To: Tom Tromey , 20896@debbugs.gnu.org References: <87a8vnlrxs.fsf@gmx.us> <87tw97zav3.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Thu, 12 Jan 2017 04:57:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <87tw97zav3.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 4.1 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 10.01.2017 09:29, Tom Tromey wrote: > This patch adds chained indentation, as requested in the bug. Thanks. > It comes > with some tests [...] Content analysis details: (4.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.66 listed in dnsbl.sorbs.net] 3.6 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.66 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.66 listed in wl.mailspike.net] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 20896 Cc: Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 4.1 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 10.01.2017 09:29, Tom Tromey wrote: > This patch adds chained indentation, as requested in the bug. Thanks. > It comes > with some tests [...] Content analysis details: (4.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.66 listed in dnsbl.sorbs.net] 3.6 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.66 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.66 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid On 10.01.2017 09:29, Tom Tromey wrote: > This patch adds chained indentation, as requested in the bug. Thanks. > It comes > with some tests I'd just like to point out that it's much better to write indentation tests in the format used by test/manual/indent/js*. > (added to a file that first appears in patch in another > bug Not sure which patch you mean. This file seems new. As for review: js--skip-term-backward seems to be doing something similar to the loop in js--multi-line-declaration-indentation. Maybe a extraction and unification is in order. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 23:02:14 2017 Received: (at 20896) by debbugs.gnu.org; 12 Jan 2017 04:02:14 +0000 Received: from localhost ([127.0.0.1]:50601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRWac-0004Sx-8f for submit@debbugs.gnu.org; Wed, 11 Jan 2017 23:02:14 -0500 Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:40552 helo=gproxy9.mail.unifiedlayer.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRWaa-0004Sj-62 for 20896@debbugs.gnu.org; Wed, 11 Jan 2017 23:02:12 -0500 Received: from cmgw3 (unknown [10.0.90.84]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id C38B51E10D4 for <20896@debbugs.gnu.org>; Wed, 11 Jan 2017 21:02:03 -0700 (MST) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id XG1y1u01p2f2jeq01G21dp; Wed, 11 Jan 2017 21:02:03 -0700 X-Authority-Analysis: v=2.1 cv=YpOcGeoX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=VjoE-u9KLxnY0IisJmQA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=b82M3hi/+xcHWiWad9Zeg5EOATNitp3FOS0dehNlxFM=; b=jxYPWia419dzlmwmvi9ArIlfws 0JJKGcedmZt/OFzYDhKDLu1zDybLz7aQRy+7xb2+tGt6hPJiO2KPj8UrHfl3KuvwmBvWlibYG4jnA K8y8zfEIuAVdoqKjq2Jhup2br; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:43548 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cRWaM-0005on-Kd; Wed, 11 Jan 2017 21:01:58 -0700 From: Tom Tromey To: Dmitry Gutov Subject: Re: bug#20896: patch to add chained indentation References: <87a8vnlrxs.fsf@gmx.us> <87tw97zav3.fsf@tromey.com> X-Attribution: Tom Date: Wed, 11 Jan 2017 21:01:53 -0700 In-Reply-To: (Dmitry Gutov's message of "Thu, 12 Jan 2017 04:57:49 +0300") Message-ID: <8760llylhq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cRWaM-0005on-Kd X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:43548 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 20896 Cc: Daniel Colascione , Tom Tromey , 20896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) >> It comes with some tests Dmitry> I'd just like to point out that it's much better to write indentation Dmitry> tests in the format used by test/manual/indent/js*. Thanks, I wasn't aware of this. I'll redo the test this way. >> (added to a file that first appears in patch in another >> bug Dmitry> Not sure which patch you mean. This file seems new. I added js-tests.el in the bug#19399/bug#22431 patch, then further amended it in bug#15582. None of these have landed yet. (There's also bug#25389, which is related, but doesn't touch the test file.) Dmitry> As for review: js--skip-term-backward seems to be doing something Dmitry> similar to the loop in js--multi-line-declaration-indentation. Dmitry> Maybe a extraction and unification is in order. I don't really see it. Could you explain more? Tom From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 20:09:28 2017 Received: (at 20896) by debbugs.gnu.org; 13 Jan 2017 01:09:28 +0000 Received: from localhost ([127.0.0.1]:51893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRqMy-0001hV-Gs for submit@debbugs.gnu.org; Thu, 12 Jan 2017 20:09:28 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cRqMw-0001hJ-ND for 20896@debbugs.gnu.org; Thu, 12 Jan 2017 20:09:27 -0500 Received: by mail-lf0-f67.google.com with SMTP id h65so3853312lfi.3 for <20896@debbugs.gnu.org>; Thu, 12 Jan 2017 17:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MlivI4KJXLr9M6wYvyFWR5XNLf4VQGn4TuUgMrK/9wI=; b=HyUel8aA1EWKO3DI1DPaBrtTHkCh9Ryld2vMr4PwILCveyrh722RNm6RkX1m5U1rer K51AMlkNVZl0SXUA+Lz6cptWnEpS/IaiAfj39Fjx9TenG/MBJAkz9SuY9KsVu+fpJ9LH qhTcTcXUYTPfgMnTxyDFQjSHInwjKiNvAOFQopHmKgZshwVxomFTpqS+rmzMUdbR361+ 5qK0jY+KKjo/5S0KrdfC3YFUCh8DRUPcnLpPWvxpBdkivy3I2WtPNOG0dqBQT5ieMwLV 5jQzgytnEjqW0DK/LoBe3nqticG/tCZKE06C3sPXM2vemcn6p155fx4xuxryrOiVGigp 4weQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MlivI4KJXLr9M6wYvyFWR5XNLf4VQGn4TuUgMrK/9wI=; b=YS3ZTF5IK1UCALsYHAPSsNuKuAujP+8aSOI9vsXLE5iSGO5MCC13Z9HQrST+AU1pUf bLR+G4P4j17txBBhqCq6lhfNxh8t/Eyjq4RYBSs1bjYRXyB9d6WdYPCgHsX5oN9Fmfc/ 3yEo+y/OOLcr7+z9y5+Vol2RexjG4qGAX+RI4gMXqx7RW5G/bK0uiuazUu6nvnK8m753 sazqMt+rlLOd6VsZLXu0IKJshMiFlRyVbcVLOBXF46ppg6+6/cV6LIWi97M/cpkq9OXu INdIxGWKuPwRUoNbqrGvHDjWOe4CgOGjcozy0PfL09jqwLwNHrFKr1C5g8ueTwzE/1dP 4psQ== X-Gm-Message-State: AIkVDXIT7I5kwukL6Nqg6V6LpcWSgzNP4OOYbwi4B2MCow9cF2G0TwTNC3XneP2ofW/XFA== X-Received: by 10.25.22.201 with SMTP id 70mr6764418lfw.97.1484269760666; Thu, 12 Jan 2017 17:09:20 -0800 (PST) Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id c66sm3087745ljd.44.2017.01.12.17.09.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jan 2017 17:09:19 -0800 (PST) Subject: Re: bug#20896: patch to add chained indentation To: Tom Tromey References: <87a8vnlrxs.fsf@gmx.us> <87tw97zav3.fsf@tromey.com> <8760llylhq.fsf@tromey.com> From: Dmitry Gutov Message-ID: Date: Fri, 13 Jan 2017 04:09:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <8760llylhq.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 4.1 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 12.01.2017 07:01, Tom Tromey wrote: > I'll redo the test this way. Thanks. [...] Content analysis details: (4.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (raaahh[at]gmail.com) 3.6 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.67 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.67 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.67 listed in wl.mailspike.net] 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 20896 Cc: Daniel Colascione , 20896@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 4.1 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 12.01.2017 07:01, Tom Tromey wrote: > I'll redo the test this way. Thanks. [...] Content analysis details: (4.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.215.67 listed in dnsbl.sorbs.net] 3.6 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [178.252.127.239 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.67 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.215.67 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dgutov[at]yandex.ru) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid On 12.01.2017 07:01, Tom Tromey wrote: > I'll redo the test this way. Thanks. > Dmitry> As for review: js--skip-term-backward seems to be doing something > Dmitry> similar to the loop in js--multi-line-declaration-indentation. > Dmitry> Maybe a extraction and unification is in order. > > I don't really see it. Could you explain more? The `while' loop jumps to the beginning of the current "assignment expression". `js--skip-terms-backward' is similar because it skips to the beginning of the call chain. It's more narrow, though (the other function also jumps over binary operators). Anyway, I'm not so sure there's much value in unifying the implementations anymore. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 12:45:41 2017 Received: (at 20896-done) by debbugs.gnu.org; 14 Jan 2017 17:45:41 +0000 Received: from localhost ([127.0.0.1]:54098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cSSOb-0000bW-1n for submit@debbugs.gnu.org; Sat, 14 Jan 2017 12:45:41 -0500 Received: from gproxy2-pub.mail.unifiedlayer.com ([69.89.18.3]:36390) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cSSOZ-0000bG-Dh for 20896-done@debbugs.gnu.org; Sat, 14 Jan 2017 12:45:40 -0500 Received: (qmail 7019 invoked by uid 0); 14 Jan 2017 17:45:28 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy2.mail.unifiedlayer.com with SMTP; 14 Jan 2017 17:45:28 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id YHlP1u00Z2f2jeq01HlSgK; Sat, 14 Jan 2017 10:45:28 -0700 X-Authority-Analysis: v=2.1 cv=JsBi8qIC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=CfUWqcwYFqYZv6Aprm8A:9 a=AOBNIhKZbwsA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y1WT3cuwgVOtqK3JGRCpJDOxlKp85vz9PlksgG6H5a0=; b=Rb9uhrOA80eo1iaFUNrYa7yCAe mgANS1eDteMjanzmrVfkevGTZQPFDQt9WWImeF6uMVElxDZNvS4sYHC0edSROPSLNN9P/V5+M8KlW jIBNA50dMqhWVdjzzgXOa5YDp; Received: from 174-16-146-181.hlrn.qwest.net ([174.16.146.181]:54000 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cSSOJ-0004GP-D1; Sat, 14 Jan 2017 10:45:23 -0700 From: Tom Tromey To: 20896-done@debbugs.gnu.org Subject: done X-Attribution: Tom Date: Sat, 14 Jan 2017 10:45:19 -0700 Message-ID: <87bmv94jtc.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.146.181 X-Exim-ID: 1cSSOJ-0004GP-D1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-146-181.hlrn.qwest.net (bapiya) [174.16.146.181]:54000 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 20896-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) This was fixed by 502390822f9c0068898ae41285b37568bf0e4d1c. Tom From unknown Wed Aug 20 03:38:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 12 Feb 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator