From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 06:43:03 2015 Received: (at submit) by debbugs.gnu.org; 25 Jun 2015 10:43:03 +0000 Received: from localhost ([127.0.0.1]:56964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z84cX-0005Rj-PQ for submit@debbugs.gnu.org; Thu, 25 Jun 2015 06:43:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41679) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z84cV-0005RM-9o for submit@debbugs.gnu.org; Thu, 25 Jun 2015 06:42:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z84cP-0001Pi-2R for submit@debbugs.gnu.org; Thu, 25 Jun 2015 06:42:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z84cO-0001Pd-VO for submit@debbugs.gnu.org; Thu, 25 Jun 2015 06:42:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z84cN-0001bB-PF for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 06:42:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z84cJ-0001On-KI for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 06:42:51 -0400 Received: from plane.gmane.org ([80.91.229.3]:39679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z84cJ-0001Oj-D9 for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 06:42:47 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Z84cH-0007uc-F9 for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 12:42:45 +0200 Received: from i59f55771.versanet.de ([89.245.87.113]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 25 Jun 2015 12:42:45 +0200 Received: from stephen.berman by i59f55771.versanet.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 25 Jun 2015 12:42:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Stephen Berman Subject: [patch] lexical binding broke part of sgml-mode.el Date: Thu, 25 Jun 2015 12:42:35 +0200 Lines: 54 Message-ID: <87mvzoax2c.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: i59f55771.versanet.de User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) The following change broke some functionality in sgml-mode.el: commit 84e0b7dad6f1a8e53261f9b96f5a9080fea681a4 Author: Stefan Monnier Date: Mon Apr 13 15:51:15 2015 -0400 [...] * lisp/textmodes/sgml-mode.el: Use lexical-binding. To see the bug, visit an (X)HTML file and insert a tag (`C-c C-t') that takes an attribute, such `p' or `a'. The following patch fixes the problems I have encountered, but I'm not sure if further adjustments are needed, so I'll defer to whoever knows the code better about whether to commit it as is. 2015-06-25 Stephen Berman * sgml-mode.el (sgml-attributes, sgml-value): Make them work with lexical binding. diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el index 2ffe9c1..dbb9662 100644 --- a/lisp/textmodes/sgml-mode.el +++ b/lisp/textmodes/sgml-mode.el @@ -759,9 +759,9 @@ If QUIET, do not print a message when there are no attributes for TAG." (insert ?\s) (insert (funcall skeleton-transformation-function (setq attribute - (skeleton-read '(completing-read + (skeleton-read `(completing-read "Attribute: " - alist))))) + ',alist))))) (if (string= "" attribute) (setq i 0) (sgml-value (assoc (downcase attribute) alist)) @@ -1177,13 +1177,13 @@ See `sgml-tag-alist' for info about attribute rules." (if (and (eq (car alist) t) (not sgml-xml-mode)) (when (cdr alist) (insert "=\"") - (setq alist (skeleton-read '(completing-read "Value: " (cdr alist)))) + (setq alist (skeleton-read `(completing-read "Value: " (cdr ',alist)))) (if (string< "" alist) (insert alist ?\") (delete-char -2))) (insert "=\"") (if (cdr alist) - (insert (skeleton-read '(completing-read "Value: " alist))) + (insert (skeleton-read `(completing-read "Value: " ',alist))) (when (null alist) (insert (skeleton-read '(read-string "Value: "))))) (insert ?\")))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 09:03:22 2015 Received: (at 20895) by debbugs.gnu.org; 25 Jun 2015 13:03:22 +0000 Received: from localhost ([127.0.0.1]:56999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z86oI-0001m3-3R for submit@debbugs.gnu.org; Thu, 25 Jun 2015 09:03:22 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33662) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z86oB-0001lj-PW for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 09:03:16 -0400 Received: by wiwl6 with SMTP id l6so17400438wiw.0 for <20895@debbugs.gnu.org>; Thu, 25 Jun 2015 06:03:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=iJft1JrgQvjt4EF7IDgZMqMWiG1DN0Cjn1vWwwMT8Mo=; b=Y0/dtuOizDeZgK+olrZAW+qJr4CbnTPsrIx3XhRgSetY11HhIXVqqoI9VFsIu0AXxe jyO2Ziq2/Kh5Yp/41TbR4q8QCluJL2IzUyKqEzsWCvpvZnWH5mXjEG3St2AHtJOxs4rY 4OXHdRoC80JJxeI1Emxr60MNkbVn+TlPhzdJ8vXOo8yTTuZdweLm/j1jvDsxXUHGCW1x oakC/UpCgyPLWJafRRUZXPoEUA/RuhIOywYKY6aLtrcxwfB2qMoKqLUrJlaKhCtQKwyt /STfCT56rIF4zfLJJz063lm9rbmCTzKr037Mz1ZY740Hioonj91jAKPYRwXV4s60HgJz 06uA== X-Received: by 10.181.11.193 with SMTP id ek1mr5576016wid.15.1435237386025; Thu, 25 Jun 2015 06:03:06 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id kc4sm45588659wjc.2.2015.06.25.06.03.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jun 2015 06:03:05 -0700 (PDT) Subject: Re: bug#20895: [patch] lexical binding broke part of sgml-mode.el To: Stephen Berman , 20895@debbugs.gnu.org References: <87mvzoax2c.fsf@gmx.net> From: Dmitry Gutov Message-ID: <558BFC08.9010000@yandex.ru> Date: Thu, 25 Jun 2015 16:03:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87mvzoax2c.fsf@gmx.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20895 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi! On 06/25/2015 01:42 PM, Stephen Berman wrote: > The following patch fixes the problems I have encountered, but I'm not > sure if further adjustments are needed, so I'll defer to whoever knows > the code better about whether to commit it as is. Thanks for the patch, but please check out the discussion at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20386. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 09:27:17 2015 Received: (at 20895) by debbugs.gnu.org; 25 Jun 2015 13:27:17 +0000 Received: from localhost ([127.0.0.1]:57005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z87BT-0002Kp-W3 for submit@debbugs.gnu.org; Thu, 25 Jun 2015 09:27:16 -0400 Received: from mout.gmx.net ([212.227.15.18]:51840) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z87BQ-0002KY-Uv for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 09:27:13 -0400 Received: from rosalinde ([89.245.87.113]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LZiLk-1YebJO3Zwi-00lZAc; Thu, 25 Jun 2015 15:27:06 +0200 From: Stephen Berman To: Dmitry Gutov Subject: Re: bug#20895: [patch] lexical binding broke part of sgml-mode.el References: <87mvzoax2c.fsf@gmx.net> <558BFC08.9010000@yandex.ru> Date: Thu, 25 Jun 2015 15:27:06 +0200 In-Reply-To: <558BFC08.9010000@yandex.ru> (Dmitry Gutov's message of "Thu, 25 Jun 2015 16:03:04 +0300") Message-ID: <87egkzc40l.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:GUMs4WFDdD8B0U7YY/lN8N0Jx14Tjan9ACNTRY4tlIK304xdFAy 93+GkZ1oDHmTF6IWytAWqYbrxvlbtTQbSXIN4LXbq+qlwBpDgdo52n50zIJI7Xh1Ic2adOV oOVgeLVf6yvuot8nZXWVDCEGIhrtXPydxUAswtu6Wz9BzX1b+W0nUMirCjrtu0IY9ZOZxk2 WyhgxKsDk5U6ebzkt1UWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Z8+Xq07OpN8=:VKXBqivRbPM7O4zwQMoO5a CPjJzY2s11Mzr2iTKlbGBY10n3Sfs8ry/D6L0teJSadieeCYKoe15+XBENRIfpSQLezbL9D+p s559A5xlmh+uZdpBtIJtYApnwtNhMmwcuu+oHsCY4wA3FKOv7pgb6cBnwyoQIlThEeYvONqvl 40BlHjvbJrz4IVzrQlke4pDov+YHyc7wkkuRelB84CLbxb+rphCmN7wvUtS6z/nxeL8FWlNYJ FX14I2sriNS675SNDhC/5T3+HNTgAxWoII0F1lGxjArgMRchk8P2l+cQuoRIuhseq9Ek/fVYD ATVqENeqJCOA5QKOAMnf7auBhcT7cUPMvDnAzj5IKxBgzUv2USpmd67AWTYcOL7c2RkBzqEkL 5MYczmk2UJEBjmFDO3vA2V8Wcb6bnxgqVRSdmydQrvfoI6F0YPmb5ojpK++J7i/CCxY6XfC3j 8zEPymtT+dRvnIquvLg3Tjy82B8X7KxCDjDXHvn56D2kd6CCKy5Guqay4DYRrVutOsaQd507/ X+o2WwAbdMvTF11xAvL9vb5H8lKRiuz75EeQYO1c/tPdhHQEI9VP3OXHBgohvCrEDsai1Z9ni hK5HzoKK0RWlaqUdQmN83Gujuh8C2GT7x38L0KIy25WCwlvEphixaIgE4y1PoQ+FTdeuDMEdG Ei0khmtIc7EQP+tG/vPF4a5TPCnol47iW6fOEW4P2XDdGAi60EAUSbAvphUr4hB0+KK4= X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 20895 Cc: 20895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Thu, 25 Jun 2015 16:03:04 +0300 Dmitry Gutov wrote: > Hi! > > On 06/25/2015 01:42 PM, Stephen Berman wrote: > >> The following patch fixes the problems I have encountered, but I'm not >> sure if further adjustments are needed, so I'll defer to whoever knows >> the code better about whether to commit it as is. > > Thanks for the patch, but please check out the discussion at > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20386. Oh, I missed (or forgot about) that (I've been a bit out of the Emacs development loop lately, and only recently updated my build and hit this bug). Do you disagree with Stefan's suggestion or just haven't gotten around to implementing it? I can understand if the latter is the reason, as I have little time myself to come up with a more involved fix; still, it would be nice to have it fixed soon. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 10:34:56 2015 Received: (at 20895) by debbugs.gnu.org; 25 Jun 2015 14:34:56 +0000 Received: from localhost ([127.0.0.1]:57343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z88Ex-0003z0-IS for submit@debbugs.gnu.org; Thu, 25 Jun 2015 10:34:56 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:52082) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z88Ev-0003yk-6e for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 10:34:54 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NQI001007VASY00@mtaout24.012.net.il> for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 17:26:02 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQI000CH83EC520@mtaout24.012.net.il>; Thu, 25 Jun 2015 17:26:02 +0300 (IDT) Date: Thu, 25 Jun 2015 17:34:31 +0300 From: Eli Zaretskii Subject: Re: bug#20895: [patch] lexical binding broke part of sgml-mode.el In-reply-to: <87mvzoax2c.fsf@gmx.net> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <83egkzeu14.fsf@gnu.org> References: <87mvzoax2c.fsf@gmx.net> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20895 Cc: 20895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stephen Berman > Date: Thu, 25 Jun 2015 12:42:35 +0200 > > The following change broke some functionality in sgml-mode.el: > > commit 84e0b7dad6f1a8e53261f9b96f5a9080fea681a4 > Author: Stefan Monnier > Date: Mon Apr 13 15:51:15 2015 -0400 > [...] > * lisp/textmodes/sgml-mode.el: Use lexical-binding. > > To see the bug, visit an (X)HTML file and insert a tag (`C-c C-t') that > takes an attribute, such `p' or `a'. > > The following patch fixes the problems I have encountered, but I'm not > sure if further adjustments are needed, so I'll defer to whoever knows > the code better about whether to commit it as is. Whatever comes out of this discussion, would you please consider adding a suitable test to sgml-mode-tests.el? TIA. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 10:47:12 2015 Received: (at 20895) by debbugs.gnu.org; 25 Jun 2015 14:47:12 +0000 Received: from localhost ([127.0.0.1]:57352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z88Qq-0004Ha-2u for submit@debbugs.gnu.org; Thu, 25 Jun 2015 10:47:12 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37964) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z88Qo-0004HM-10 for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 10:47:10 -0400 Received: by wibdq8 with SMTP id dq8so78318105wib.1 for <20895@debbugs.gnu.org>; Thu, 25 Jun 2015 07:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=9AoOYOT8ra2Cx4NkAY2fz6Uvjsg0yX+nU0cPYDuRD9A=; b=vupJ0dkEVh0quyznBdxZTJ9GVbsW0dWy+55pH8HVOoSeJzS1Cn6ovWj6C+/DfoXWVk 052SI74LI2Grdh5TISvT6IPOvDbNtT8ZiF5/MykHyYNsltaQLAGA3DSADCoeUZLBU6cw 0x4TNXLyuX6kOG6tbGk9cnTcWGt/bIRjx+ldCzpQvY1/HQ3U5EaXhXzTYFzTIv2+QYqz V7Ed8Cmyg72fc8BMZeY+Sn9FVDBS5QY6LKGj2U4l6KCBdh9mevelVji5J5bA1VH5969F qv7Ykeb21tJdSP6Tb708QIB+eQOUGcHqhT7xs0IQdkijcwzwcC5QY2Ed7NwRdanCpPbQ +7Dg== X-Received: by 10.194.52.37 with SMTP id q5mr82257867wjo.122.1435243624091; Thu, 25 Jun 2015 07:47:04 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id q3sm46190628wjr.38.2015.06.25.07.47.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jun 2015 07:47:03 -0700 (PDT) Subject: Re: bug#20895: [patch] lexical binding broke part of sgml-mode.el To: Stephen Berman References: <87mvzoax2c.fsf@gmx.net> <558BFC08.9010000@yandex.ru> <87egkzc40l.fsf@rub.de> From: Dmitry Gutov Message-ID: <558C1465.2090801@yandex.ru> Date: Thu, 25 Jun 2015 17:47:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87egkzc40l.fsf@rub.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20895 Cc: 20895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/25/2015 04:27 PM, Stephen Berman wrote: > or just haven't gotten around to implementing it? That, more or less. And sgml-mode is not a priority for me personally, so if someone else takes that up, it would be welcome. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 11:42:06 2015 Received: (at control) by debbugs.gnu.org; 25 Jun 2015 15:42:06 +0000 Received: from localhost ([127.0.0.1]:57387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z89Hx-0006H1-M9 for submit@debbugs.gnu.org; Thu, 25 Jun 2015 11:42:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40935) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z89Hw-0006GX-8i for control@debbugs.gnu.org; Thu, 25 Jun 2015 11:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z89Hq-0002Mi-JZ for control@debbugs.gnu.org; Thu, 25 Jun 2015 11:41:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z89Hq-0002Md-G8 for control@debbugs.gnu.org; Thu, 25 Jun 2015 11:41:58 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Z89Hq-0004fd-5u for control@debbugs.gnu.org; Thu, 25 Jun 2015 11:41:58 -0400 Subject: control message for bug 20386 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 25 Jun 2015 11:41:58 -0400 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) merge 20895 20386 From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 15:28:24 2015 Received: (at 20895) by debbugs.gnu.org; 25 Jun 2015 19:28:24 +0000 Received: from localhost ([127.0.0.1]:57502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8Cox-0004db-Oe for submit@debbugs.gnu.org; Thu, 25 Jun 2015 15:28:24 -0400 Received: from mout.gmx.net ([212.227.17.22]:60111) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8Cow-0004dN-IU for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 15:28:23 -0400 Received: from rosalinde ([89.245.87.113]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LdpZX-1Yintu0dOt-00j0PH; Thu, 25 Jun 2015 21:28:13 +0200 From: Stephen Berman To: Dmitry Gutov Subject: Re: bug#20895: [patch] lexical binding broke part of sgml-mode.el References: <87mvzoax2c.fsf@gmx.net> <558BFC08.9010000@yandex.ru> <87egkzc40l.fsf@rub.de> <558C1465.2090801@yandex.ru> Date: Thu, 25 Jun 2015 21:28:12 +0200 In-Reply-To: <558C1465.2090801@yandex.ru> (Dmitry Gutov's message of "Thu, 25 Jun 2015 17:47:01 +0300") Message-ID: <87y4j7a8qb.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:Tpi+FJ5nBOsucby6lyFdfsYfBXbKPm6c3v7IJSMks5E6QeWI3CN KESk6gcSHciUvv95o5RnwVZ9Z7D8ojh7jGRgM7jW8GtECwJuJiPYZp1ZS9IXX+OKhsYoyl2 jXU83WhwQ6v7I+qgHcEpqbNe+dyzuiJ+LvqlFC7m9LVNVyLnC9rm7QD0WZ4Srz93ZTIcASU 6jC/xjhkJBFfp38Ll6bYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:jtoFI/d6eIM=:RILKwD47upyA9fr1+4FpaR j30zMhvdz2wyfsuJ/T9zIvzThhWt8mZHu/631T3PfKVGFuD9rxfAy2YjlRNz7KYJCW2yhEreV 4Wj3pKllvCzxtSTw703kyzB2LX6JGCQ11ns789UTrJ2MlJr/WPZw9+KZ9o9qeP4oiwlmsshwE 0BqOdyXr8lY6tm4wzTKdv0PylD1BMMqvi8hWODsjiImi4iVGufgN3Li01bdXDg9C29MZ+Xlvl eC92+Ezu3tsbxhzlqcAjka6kAqxSJPj2Lm9jp93J6HKPX4Go9BcVcps4CBC1uo+VhTqrtf4+D VAOBK2E0YpDjx1Z6JniPjfvyaeTAWO7DCSfx4xydY12m8+jIRfNtUTbaoW6rIx7rAfdgWxOyI wwgLDDuakrFAk+LJqiK4gv4D32iNOH9nXDy2JsIF886/8r5v6eFmx/mWMzm4PHtgXKAkzO++A ZR2mtorBT42Trpc9clRddvAxG8HsWsfwN/g9btZJ6jlJc3Rl4PiPXTLAM5939/VmgB+seJjL2 3+4hhes2+WGRIu0PJ8xDIl8mNqvaUnul9Xy7elh4ePROvrxhxtMZPpu25GCF9emCCpqkguAZS Mq9eFf4uqXLjOsMl2yFq7UjGvny3ZDEC2/NfdLLYqPDIs2/n1mF4+8kSd5ApL4f7NTCL0ROQg ei6pjLqVxsNVgpFUMPqcauhVZH5rSKLlAVsvb8YP4oOHYKExTVkBDzj0CzOXv8B/+jnM= X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 20895 Cc: Eli Zaretskii , 20895@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Thu, 25 Jun 2015 17:47:01 +0300 Dmitry Gutov wrote: > On 06/25/2015 04:27 PM, Stephen Berman wrote: >> or just haven't gotten around to implementing it? > > That, more or less. And sgml-mode is not a priority for me personally, so if > someone else takes that up, it would be welcome. A usable sgml-mode is a priority for me, that's why I tried to fix it, and for the time being it's good enough for me. I probably won't be able to try and implement the better fix in the near future, but will take a look when I can, INOBMTI (if no one beats me to it). On Thu, 25 Jun 2015 17:34:31 +0300 Eli Zaretskii wrote: > Whatever comes out of this discussion, would you please consider > adding a suitable test to sgml-mode-tests.el? TIA. I'll try to do this too INOBMTI, though it may take even longer (it will mean having to learn how to use ERT first). Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 15:44:45 2015 Received: (at 20895) by debbugs.gnu.org; 25 Jun 2015 19:44:45 +0000 Received: from localhost ([127.0.0.1]:57522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8D4m-000549-ST for submit@debbugs.gnu.org; Thu, 25 Jun 2015 15:44:45 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:49895) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8D4k-00053w-Kw for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 15:44:43 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NQI00N00M6CR800@mtaout25.012.net.il> for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 22:40:18 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQI00IUMMN59470@mtaout25.012.net.il>; Thu, 25 Jun 2015 22:40:18 +0300 (IDT) Date: Thu, 25 Jun 2015 22:44:27 +0300 From: Eli Zaretskii Subject: Re: bug#20895: [patch] lexical binding broke part of sgml-mode.el In-reply-to: <87y4j7a8qb.fsf@rub.de> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <831tgzefok.fsf@gnu.org> References: <87mvzoax2c.fsf@gmx.net> <558BFC08.9010000@yandex.ru> <87egkzc40l.fsf@rub.de> <558C1465.2090801@yandex.ru> <87y4j7a8qb.fsf@rub.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20895 Cc: 20895@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stephen Berman > Cc: Eli Zaretskii , 20895@debbugs.gnu.org > Date: Thu, 25 Jun 2015 21:28:12 +0200 > > > Whatever comes out of this discussion, would you please consider > > adding a suitable test to sgml-mode-tests.el? TIA. > > I'll try to do this too INOBMTI, though it may take even longer (it will > mean having to learn how to use ERT first). Thanks. The tests already in sgml-mode-tests are pretty good examples, and I'm sure you will find a way of mimicking them in no time. From unknown Wed Jun 25 05:43:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Aug 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator