From unknown Sat Jun 21 12:11:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20873: 24.5; shell command completion faulty Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2015 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20873@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14349795233834 (code B ref -1); Mon, 22 Jun 2015 13:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jun 2015 13:25:23 +0000 Received: from localhost ([127.0.0.1]:53951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z71j0-0000zj-28 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44212) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z71iw-0000zS-A3 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z71il-0008DD-Ob for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71il-0008Cu-Lu for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71ik-0001kq-I6 for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 09:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z71ig-0007xK-1M for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 09:25:05 -0400 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]:34328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71if-0007u4-Ly for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 09:25:01 -0400 Received: by pdbki1 with SMTP id ki1so138962694pdb.1 for ; Mon, 22 Jun 2015 06:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=7EG74p/3+De2BxFwwiJvlZFPEJrEj8LutK/umll7l5E=; b=IGnFFjp/ralDTVgv84MeU6MmZ7xVUd+wQ7WzlCVcG1PQl125DTJyIGhf0SrpcPHfte GQ1T46a3UkDpQoHGSX43FcWhhnwD0gpm3GDxkuQDPsrDQDcx74ncbmj70kRKtuLYsUNv AtXWqMSkoPcGWkJvH1YBz36xJPizyyBncqdZ9Ao1VOZlgDCyvMspNdps1dmnYQSh2u8I 82e1YIq/N4rp9wdlVqk+oxOAbqG+kEduUwsWuAK1ViHNXtkZb/1p0UPLWE7535IYJ9q2 Ec1J1pnH+5EOYpOPKEPwtxXkPHLZAWKt6SXwGEEMEGPgbfIQ8JJ1sjhoRvQJxsEJkl2o Kb5Q== X-Received: by 10.70.133.230 with SMTP id pf6mr46646698pdb.56.1434979498049; Mon, 22 Jun 2015 06:24:58 -0700 (PDT) Received: from zeuss-MBP.lan ([128.199.230.246]) by mx.google.com with ESMTPSA id bf5sm5057016pad.43.2015.06.22.06.24.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 06:24:57 -0700 (PDT) From: Leo Liu Date: Mon, 22 Jun 2015 21:24:50 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. M-x shell 2. Put a few spaces before entering `c' followed by TAB No completion. I wonder if the following is the right fix? diff --git a/lisp/shell.el b/lisp/shell.el index 6d69ca63..788b8169 100644 --- a/lisp/shell.el +++ b/lisp/shell.el @@ -1134,7 +1134,9 @@ (defun shell-command-completion () (if (and filename (save-match-data (not (string-match "[~/]" filename))) (eq (match-beginning 0) - (save-excursion (shell-backward-command 1) (point)))) + (save-excursion (shell-backward-command 1) + (skip-syntax-forward " ") + (point)))) (shell--command-completion-data)))) (defun shell--command-completion-data () From unknown Sat Jun 21 12:11:36 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20873: 24.5; shell command completion faulty Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2015 22:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Liu Cc: 20873@debbugs.gnu.org Received: via spool by 20873-submit@debbugs.gnu.org id=B20873.14350112001195 (code B ref 20873); Mon, 22 Jun 2015 22:14:02 +0000 Received: (at 20873) by debbugs.gnu.org; 22 Jun 2015 22:13:20 +0000 Received: from localhost ([127.0.0.1]:54745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z79xv-0000JC-KT for submit@debbugs.gnu.org; Mon, 22 Jun 2015 18:13:19 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:20196) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z79xs-0000Iy-V6 for 20873@debbugs.gnu.org; Mon, 22 Jun 2015 18:13:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AsEwA731xV/zDyd0tcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBbM/gUUjhBQigngBAQE X-IPAS-Result: A0AsEwA731xV/zDyd0tcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAQEBAR6LOoUFB4QtBbM/gUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="128009603" Received: from 75-119-242-48.dsl.teksavvy.com (HELO ceviche.home) ([75.119.242.48]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 22 Jun 2015 18:13:11 -0400 Received: by ceviche.home (Postfix, from userid 20848) id ADC2C6610A; Mon, 22 Jun 2015 18:13:10 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Mon, 22 Jun 2015 18:13:10 -0400 In-Reply-To: (Leo Liu's message of "Mon, 22 Jun 2015 21:24:50 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I wonder if the following is the right fix? [...] > - (save-excursion (shell-backward-command 1) (point)))) > + (save-excursion (shell-backward-command 1) > + (skip-syntax-forward " ") > + (point)))) Could be. I don't have time to dig into it right now, but another option might be to change shell-backward-command instead. Stefan From unknown Sat Jun 21 12:11:36 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Liu Subject: bug#20873: closed (Re: bug#20873: 24.5; shell command completion faulty) Message-ID: References: X-Gnu-PR-Message: they-closed 20873 X-Gnu-PR-Package: emacs Reply-To: 20873@debbugs.gnu.org Date: Tue, 23 Jun 2015 01:27:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1435022823-18522-1" This is a multi-part message in MIME format... ------------=_1435022823-18522-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20873: 24.5; shell command completion faulty which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20873@debbugs.gnu.org. --=20 20873: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20873 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1435022823-18522-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20873-done) by debbugs.gnu.org; 23 Jun 2015 01:26:44 +0000 Received: from localhost ([127.0.0.1]:54783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7Cz6-0004oI-Ey for submit@debbugs.gnu.org; Mon, 22 Jun 2015 21:26:44 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34330) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7Cz5-0004o3-1M for 20873-done@debbugs.gnu.org; Mon, 22 Jun 2015 21:26:43 -0400 Received: by pabvl15 with SMTP id vl15so99061056pab.1 for <20873-done@debbugs.gnu.org>; Mon, 22 Jun 2015 18:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=UC4vRIVYnX3aj7RYJ/sIEr29K2DMYJ05wKokYIdtC0Y=; b=l+706UIC0f+p+ZuZeezvCczWvBxWR4IwWnJm573kcACjdKn9gf2Be7wfvbhI6tg+QX BYr8K9HuvqcfgDeEwYda8bXrg5Rzm6uyfHjL9rFMmQnT7zJCWlfE7eY/brEk9AK0JEBG hNII2qq8ZWmpEeOZZPRc5gV310GnBqAwPC7VlTb/z/rLNAneIVoDYvcH32WOap/pPwNB FF7WLGRmITAHLsik75AWKARbYdJ80NMunSlF8lBSnIwNRSG/QWBtwDy1080fcwFE+AV4 xuXxleGnjrwQ27bb0HdsOh8YYnjkeVyEzaGIqf+LWiLBCLVQNmqd0TsdYWME3VmuWSXv iQKg== X-Received: by 10.70.44.138 with SMTP id e10mr63127580pdm.121.1435022797228; Mon, 22 Jun 2015 18:26:37 -0700 (PDT) Received: from Shidais-iMac.local ([128.199.230.246]) by mx.google.com with ESMTPSA id wp5sm14642404pab.22.2015.06.22.18.26.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 18:26:36 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#20873: 24.5; shell command completion faulty References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Tue, 23 Jun 2015 09:26:35 +0800 In-Reply-To: (Stefan Monnier's message of "Mon, 22 Jun 2015 18:13:10 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (OS X 10.10.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20873-done Cc: 20873-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) version: 25.1 On 2015-06-23 06:13 +0800, Stefan Monnier wrote: > Could be. I don't have time to dig into it right now, but another > option might be to change shell-backward-command instead. OK. I put in a fix there. Thanks. Leo ------------=_1435022823-18522-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jun 2015 13:25:23 +0000 Received: from localhost ([127.0.0.1]:53951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z71j0-0000zj-28 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44212) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z71iw-0000zS-A3 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z71il-0008DD-Ob for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71il-0008Cu-Lu for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:25:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71ik-0001kq-I6 for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 09:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z71ig-0007xK-1M for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 09:25:05 -0400 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]:34328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z71if-0007u4-Ly for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 09:25:01 -0400 Received: by pdbki1 with SMTP id ki1so138962694pdb.1 for ; Mon, 22 Jun 2015 06:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=7EG74p/3+De2BxFwwiJvlZFPEJrEj8LutK/umll7l5E=; b=IGnFFjp/ralDTVgv84MeU6MmZ7xVUd+wQ7WzlCVcG1PQl125DTJyIGhf0SrpcPHfte GQ1T46a3UkDpQoHGSX43FcWhhnwD0gpm3GDxkuQDPsrDQDcx74ncbmj70kRKtuLYsUNv AtXWqMSkoPcGWkJvH1YBz36xJPizyyBncqdZ9Ao1VOZlgDCyvMspNdps1dmnYQSh2u8I 82e1YIq/N4rp9wdlVqk+oxOAbqG+kEduUwsWuAK1ViHNXtkZb/1p0UPLWE7535IYJ9q2 Ec1J1pnH+5EOYpOPKEPwtxXkPHLZAWKt6SXwGEEMEGPgbfIQ8JJ1sjhoRvQJxsEJkl2o Kb5Q== X-Received: by 10.70.133.230 with SMTP id pf6mr46646698pdb.56.1434979498049; Mon, 22 Jun 2015 06:24:58 -0700 (PDT) Received: from zeuss-MBP.lan ([128.199.230.246]) by mx.google.com with ESMTPSA id bf5sm5057016pad.43.2015.06.22.06.24.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 06:24:57 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.5; shell command completion faulty Date: Mon, 22 Jun 2015 21:24:50 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. M-x shell 2. Put a few spaces before entering `c' followed by TAB No completion. I wonder if the following is the right fix? diff --git a/lisp/shell.el b/lisp/shell.el index 6d69ca63..788b8169 100644 --- a/lisp/shell.el +++ b/lisp/shell.el @@ -1134,7 +1134,9 @@ (defun shell-command-completion () (if (and filename (save-match-data (not (string-match "[~/]" filename))) (eq (match-beginning 0) - (save-excursion (shell-backward-command 1) (point)))) + (save-excursion (shell-backward-command 1) + (skip-syntax-forward " ") + (point)))) (shell--command-completion-data)))) (defun shell--command-completion-data () ------------=_1435022823-18522-1--