GNU bug report logs - #20872
24.5; add-face-text-property doesn't work for :height

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20872 in the body.
You can then email your comments to 20872 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleh Krehel <ohwoeowho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; add-face-text-property doesn't work for :height
Date: Mon, 22 Jun 2015 13:02:45 +0200

Here's a code that works for setting a string foreground:

    (defface test-face
      '((t (:height 1.2 :foreground "green")))
      "doc.")
    (setq asdf (propertize "asdf" 'face 'test-face))
    (add-face-text-property 0 (length asdf) '(:foreground "red") nil asdf)

`asdf' will still have the height 1.2 through `test-face' while gaining
a red foreground, instead of green.

But this doesn't work:

    (add-face-text-property 0 (length asdf) '(:height 1.0) nil asdf)

While the text properties will change, when inserting `asdf' into a
`fundamental-mode' buffer, it will still have the height 1.2. How can I
set the height to 1.0, while preserving the face?

The actual use case is to offer propertized strings a choices in the
minibuffer. In that case, I want to keep all face properties, except the
height. Since extra height messes up the trimming of strings to
`window-width'.

Message #8 received at 20872 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Oleh Krehel <ohwoeowho <at> gmail.com>
Cc: 20872 <at> debbugs.gnu.org
Subject: Re: bug#20872: 24.5; add-face-text-property doesn't work for :height
Date: Mon, 22 Jun 2015 18:10:06 +0300

> From: Oleh Krehel <ohwoeowho <at> gmail.com>
> Date: Mon, 22 Jun 2015 13:02:45 +0200
> 
>     (defface test-face
>       '((t (:height 1.2 :foreground "green")))
>       "doc.")
>     (setq asdf (propertize "asdf" 'face 'test-face))
>     (add-face-text-property 0 (length asdf) '(:foreground "red") nil asdf)
> 
> `asdf' will still have the height 1.2 through `test-face' while gaining
> a red foreground, instead of green.
> 
> But this doesn't work:
> 
>     (add-face-text-property 0 (length asdf) '(:height 1.0) nil asdf)
> 
> While the text properties will change, when inserting `asdf' into a
> `fundamental-mode' buffer, it will still have the height 1.2. How can I
> set the height to 1.0, while preserving the face?

Untested: copy the face using copy-face, then change ':height'
attribute of the copied face using set-face-attribute, and finally
apply the modified face to the string.

Message #11 received at 20872 <at> debbugs.gnu.org (full text, mbox):

From: Wolfgang Jenkner <wjenkner <at> inode.at>
To: Oleh Krehel <ohwoeowho <at> gmail.com>
Cc: 20872 <at> debbugs.gnu.org
Subject: Re: bug#20872: 24.5; add-face-text-property doesn't work for :height
Date: Mon, 22 Jun 2015 17:31:11 +0200

On Mon, Jun 22 2015, Oleh Krehel wrote:

> But this doesn't work:
>
>     (add-face-text-property 0 (length asdf) '(:height 1.0) nil asdf)
>
> While the text properties will change, when inserting `asdf' into a
> `fundamental-mode' buffer, it will still have the height 1.2. How can I
> set the height to 1.0, while preserving the face?

A float as value of the :height attribute works as a scaling factor, see
`set-face-attribute'.  So, IIUC, the following would work

(add-face-text-property 0 (length asdf) `(:height ,(/ 1 1.2)) nil asdf)

Message #14 received at 20872 <at> debbugs.gnu.org (full text, mbox):

From: Oleh Krehel <ohwoeowho <at> gmail.com>
To: Wolfgang Jenkner <wjenkner <at> inode.at>
Cc: 20872 <at> debbugs.gnu.org
Subject: Re: bug#20872: 24.5; add-face-text-property doesn't work for :height
Date: Mon, 22 Jun 2015 17:30:11 +0200

Wolfgang Jenkner <wjenkner <at> inode.at> writes:

> A float as value of the :height attribute works as a scaling factor, see
> `set-face-attribute'.  So, IIUC, the following would work
>
> (add-face-text-property 0 (length asdf) `(:height ,(/ 1 1.2)) nil asdf)

Genius! This actually works. Thanks a lot.

Message #17 received at 20872 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Oleh Krehel <ohwoeowho <at> gmail.com>
Cc: 20872 <at> debbugs.gnu.org
Subject: Re: bug#20872: 24.5; add-face-text-property doesn't work for :height
Date: Mon, 22 Jun 2015 12:06:35 -0400

>     (add-face-text-property 0 (length asdf) '(:height 1.0) nil asdf)

":height 1.0" means "multiply the height by 1", i.e. it's a no-op.

> minibuffer. In that case, I want to keep all face properties, except the
> height. Since extra height messes up the trimming of strings to
> `window-width'.

You can try to set :height to the *integer* pixel height of the
minibuffer lines.


        Stefan

Message #20 received at 20872 <at> debbugs.gnu.org (full text, mbox):

From: Oleh Krehel <ohwoeowho <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 20872 <at> debbugs.gnu.org
Subject: Re: bug#20872: 24.5; add-face-text-property doesn't work for :height
Date: Tue, 23 Jun 2015 11:20:40 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>     (add-face-text-property 0 (length asdf) '(:height 1.0) nil asdf)
>
> ":height 1.0" means "multiply the height by 1", i.e. it's a no-op.
>
>> minibuffer. In that case, I want to keep all face properties, except the
>> height. Since extra height messes up the trimming of strings to
>> `window-width'.
>
> You can try to set :height to the *integer* pixel height of the
> minibuffer lines.

Thanks, that's even better. Should I use this:

(add-face-text-property
 0 (length asdf)
 `(:height ,(face-attribute 'default :height)) nil asdf)

Message #23 received at 20872 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Oleh Krehel <ohwoeowho <at> gmail.com>
Cc: 20872 <at> debbugs.gnu.org
Subject: Re: bug#20872: 24.5; add-face-text-property doesn't work for :height
Date: Tue, 23 Jun 2015 09:38:57 -0400

> Thanks, that's even better. Should I use this:

> (add-face-text-property
>  0 (length asdf)
>  `(:height ,(face-attribute 'default :height)) nil asdf)

Looks OK,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.