From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 06:20:27 2015 Received: (at submit) by debbugs.gnu.org; 22 Jun 2015 10:20:27 +0000 Received: from localhost ([127.0.0.1]:53884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6yq2-0003hw-JQ for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:20:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52915) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6yq0-0003hj-6X for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:20:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6ypt-0004Fr-S0 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:20:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:56131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6ypt-0004Fn-O8 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:20:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6yps-0001oq-LZ for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 06:20:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6ypn-0004Dy-Ju for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 06:20:16 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:50725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6ypn-0004DE-Du for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 06:20:11 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id E3EFA5F2043 for ; Mon, 22 Jun 2015 12:20:06 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HOMaS4Bpz4Wg for ; Mon, 22 Jun 2015 12:20:04 +0200 (CEST) Received: from localhost (ipz217.internetdsl.tpnet.pl [79.190.154.217]) by mail.mojserwer.eu (Postfix) with ESMTPSA id EDEC05F2041 for ; Mon, 22 Jun 2015 12:20:03 +0200 (CEST) From: Marcin Borkowski To: bug-gnu-emacs@gnu.org Subject: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Date: Mon, 22 Jun 2015 12:19:59 +0200 Message-ID: <87y4jchwog.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, today I found that fill-single-char-nobreak-p is just a bit too simplistic. When point is after e.g. the string " (a", it returns nil instead of t. I am not sure which characters should be added to the regex, but at least the opening paren (and maybe bracket) should be there, so I'd change the regex into [[:space:]][[(]*[[:alpha:]]. (Two or more opening parens/brackets are unlikely, but when in doubt, I guess it's better to return t than nil than the other way round.) Best regards, -- Marcin Borkowski This email was proudly sent http://mbork.pl from my Emacs. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 06:29:03 2015 Received: (at submit) by debbugs.gnu.org; 22 Jun 2015 10:29:03 +0000 Received: from localhost ([127.0.0.1]:53889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6yyN-0003x2-Ei for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:29:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54969) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6yyK-0003wY-NT for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:29:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6yyE-0007Yu-D8 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:28:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33451) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6yyE-0007Yo-0H for submit@debbugs.gnu.org; Mon, 22 Jun 2015 06:28:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6yyD-0003lC-39 for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 06:28:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6yy8-0007Wo-Vr for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 06:28:53 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:50996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6yy8-0007Wi-PG for bug-gnu-emacs@gnu.org; Mon, 22 Jun 2015 06:28:48 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 693635F2043 for ; Mon, 22 Jun 2015 12:28:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZU2PE+MKKSbe for ; Mon, 22 Jun 2015 12:28:41 +0200 (CEST) Received: from localhost (ipz217.internetdsl.tpnet.pl [79.190.154.217]) by mail.mojserwer.eu (Postfix) with ESMTPSA id D87EA5F2041 for ; Mon, 22 Jun 2015 12:28:40 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> From: Marcin Borkowski To: bug-gnu-emacs@gnu.org Subject: Re: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <87y4jchwog.fsf@mbork.pl> Date: Mon, 22 Jun 2015 12:28:31 +0200 Message-ID: <87wpywhwa8.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 2015-06-22, at 12:19, Marcin Borkowski wrote: > Hello, > > today I found that fill-single-char-nobreak-p is just a bit too > simplistic. When point is after e.g. the string " (a", it returns nil > instead of t. I am not sure which characters should be added to the > regex, but at least the opening paren (and maybe bracket) should be > there, so I'd change the regex into [[:space:]][[(]*[[:alpha:]]. (Two > or more opening parens/brackets are unlikely, but when in doubt, I guess > it's better to return t than nil than the other way round.) > > Best regards, Just noticed that there is a hardcoded (backward-char 2), so it seems that adding a few characters to the regex is not enough. Maybe looking-back is the way to go (though it might slow filling down)? I don't know. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 02:34:41 2016 Received: (at 20871) by debbugs.gnu.org; 17 Apr 2016 06:34:42 +0000 Received: from localhost ([127.0.0.1]:37751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1argI5-0002nZ-N0 for submit@debbugs.gnu.org; Sun, 17 Apr 2016 02:34:41 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:37893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1argI3-0002nQ-9u for 20871@debbugs.gnu.org; Sun, 17 Apr 2016 02:34:39 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 2D63FACFCF4 for <20871@debbugs.gnu.org>; Sun, 17 Apr 2016 08:34:37 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KrLDdgQx-piN for <20871@debbugs.gnu.org>; Sun, 17 Apr 2016 08:34:34 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 01946ACFCF0 for <20871@debbugs.gnu.org>; Sun, 17 Apr 2016 08:34:33 +0200 (CEST) From: Marcin Borkowski To: 20871@debbugs.gnu.org Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> Date: Sun, 17 Apr 2016 08:34:30 +0200 In-Reply-To: <87wpywhwa8.fsf@mbork.pl> (Marcin Borkowski's message of "Mon, 22 Jun 2015 12:28:31 +0200") Message-ID: <87shyku4jt.fsf@mbork.pl> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain On 2015-06-22, at 12:28, Marcin Borkowski wrote: > On 2015-06-22, at 12:19, Marcin Borkowski wrote: > >> Hello, >> >> today I found that fill-single-char-nobreak-p is just a bit too >> simplistic. When point is after e.g. the string " (a", it returns nil >> instead of t. I am not sure which characters should be added to the >> regex, but at least the opening paren (and maybe bracket) should be >> there, so I'd change the regex into [[:space:]][[(]*[[:alpha:]]. (Two >> or more opening parens/brackets are unlikely, but when in doubt, I guess >> it's better to return t than nil than the other way round.) >> >> Best regards, > > Just noticed that there is a hardcoded (backward-char 2), so it > seems that adding a few characters to the regex is not enough. Maybe > looking-back is the way to go (though it might slow filling down)? > I don't know. Hi there, so here's a patch for the bug I reported some time ago. Please review both the patch and the commit message (I'm still learning to write them...). Best, -- Marcin --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-fill-single-char-nobreak-p.patch >From de6c196235ef8abfff52c9cfc3d97a6350e8a5a7 Mon Sep 17 00:00:00 2001 From: Marcin Borkowski Date: Sun, 17 Apr 2016 08:30:49 +0200 Subject: [PATCH] Fix `fill-single-char-nobreak-p' * lisp/textmodes/fill.el (fill-single-char-nobreak-p): make space after opening paren and a single-letter word unbreakable (Bug#20871) --- lisp/textmodes/fill.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/fill.el b/lisp/textmodes/fill.el index 173d1c9..bade8fa 100644 --- a/lisp/textmodes/fill.el +++ b/lisp/textmodes/fill.el @@ -337,7 +337,10 @@ fill-single-char-nobreak-p (save-excursion (skip-chars-backward " \t") (backward-char 2) - (looking-at "[[:space:]][[:alpha:]]"))) + (or (looking-at "[[:space:]][[:alpha:]]") + (progn + (backward-char 1) + (looking-at "[[:space:]]([[:alpha:]]"))))) (defcustom fill-nobreak-predicate nil "List of predicates for recognizing places not to break a line. -- 2.4.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 10:58:16 2016 Received: (at 20871) by debbugs.gnu.org; 17 Apr 2016 14:58:16 +0000 Received: from localhost ([127.0.0.1]:38567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aro9Q-0008AE-IO for submit@debbugs.gnu.org; Sun, 17 Apr 2016 10:58:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aro9P-00089z-Ay for 20871@debbugs.gnu.org; Sun, 17 Apr 2016 10:58:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aro9E-0005mY-Ns for 20871@debbugs.gnu.org; Sun, 17 Apr 2016 10:58:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aro9E-0005mU-KI; Sun, 17 Apr 2016 10:58:04 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4608 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aro9D-0006Pm-Vp; Sun, 17 Apr 2016 10:58:04 -0400 Date: Sun, 17 Apr 2016 17:57:48 +0300 Message-Id: <8337qkb7v7.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87shyku4jt.fsf@mbork.pl> (message from Marcin Borkowski on Sun, 17 Apr 2016 08:34:30 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Marcin Borkowski > Date: Sun, 17 Apr 2016 08:34:30 +0200 > > >> today I found that fill-single-char-nobreak-p is just a bit too > >> simplistic. When point is after e.g. the string " (a", it returns nil > >> instead of t. I am not sure which characters should be added to the > >> regex, but at least the opening paren (and maybe bracket) should be > >> there, so I'd change the regex into [[:space:]][[(]*[[:alpha:]]. (Two > >> or more opening parens/brackets are unlikely, but when in doubt, I guess > >> it's better to return t than nil than the other way round.) > >> > >> Best regards, > > > > Just noticed that there is a hardcoded (backward-char 2), so it > > seems that adding a few characters to the regex is not enough. Maybe > > looking-back is the way to go (though it might slow filling down)? > > I don't know. > > Hi there, > > so here's a patch for the bug I reported some time ago. Could you please elaborate on the bug itself? See, the function in question, fill-single-char-nobreak-p, is documented as a possible value to use in the fill hook, for a very specific purpose. If you are saying that it doesn't fulfill that purpose well enough, please show a use case where it fails to do that. At least the situation you described, with " (a", doesn't seem to fit the use cases which this function is supposed to cover, since the parenthesis makes a 2-character sequence, whereas fill-single-char-nobreak-p aims to support isolated one-character words. I also am not sure I understand what is so special about '(' that it has to be hard-coded here. What about '[' or '{' or '<' (or any other punctuation character, for that matter)? > Please review both the patch and the commit message (I'm still > learning to write them...). The commit message should begin with a capital letter. Also, I think this variant is more clear: Don't break after a single-character word that follows an opening parenthesis. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 11:34:16 2016 Received: (at 20871) by debbugs.gnu.org; 17 Apr 2016 15:34:16 +0000 Received: from localhost ([127.0.0.1]:38580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aroiG-0000a4-Dz for submit@debbugs.gnu.org; Sun, 17 Apr 2016 11:34:16 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:48424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aroiE-0000Zw-Sx for 20871@debbugs.gnu.org; Sun, 17 Apr 2016 11:34:15 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id AA80DAD1E50; Sun, 17 Apr 2016 17:34:12 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WOuJtbZEKcQh; Sun, 17 Apr 2016 17:34:08 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 8A41FAD1E4F; Sun, 17 Apr 2016 17:34:07 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> User-agent: mu4e 0.9.13; emacs 25.1.50.8 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <8337qkb7v7.fsf@gnu.org> Date: Sun, 17 Apr 2016 17:34:04 +0200 Message-ID: <87k2jwtfkj.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-04-17, at 14:57, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Date: Sun, 17 Apr 2016 08:34:30 +0200 >> >> >> today I found that fill-single-char-nobreak-p is just a bit too >> >> simplistic. When point is after e.g. the string " (a", it returns nil >> >> instead of t. I am not sure which characters should be added to the >> >> regex, but at least the opening paren (and maybe bracket) should be >> >> there, so I'd change the regex into [[:space:]][[(]*[[:alpha:]]. (Two >> >> or more opening parens/brackets are unlikely, but when in doubt, I guess >> >> it's better to return t than nil than the other way round.) >> >> >> >> Best regards, >> > >> > Just noticed that there is a hardcoded (backward-char 2), so it >> > seems that adding a few characters to the regex is not enough. Maybe >> > looking-back is the way to go (though it might slow filling down)? >> > I don't know. >> >> Hi there, >> >> so here's a patch for the bug I reported some time ago. > > Could you please elaborate on the bug itself? In Polish typography, it is customary to foribid line breaks after one-letter words (and we have quite a few of them: a, i, o, w, z - they are conjunctions or prepositions). And it is not uncommon to have a combination of them with a parenthesized remark or something like that. That's why allowing a linebreak after, say "(a" when writing something in Polish (like an email, for instance) is a bug IMO. > See, the function in question, fill-single-char-nobreak-p, is > documented as a possible value to use in the fill hook, for a very > specific purpose. If you are saying that it doesn't fulfill that > purpose well enough, please show a use case where it fails to do that. > At least the situation you described, with " (a", doesn't seem to fit > the use cases which this function is supposed to cover, since the > parenthesis makes a 2-character sequence, whereas > fill-single-char-nobreak-p aims to support isolated one-character > words. I see. So you suggest that instead of patching `fill-single-char-nobreak-p' I should have provided another function, customized for Polish? In fact, I'm not so sure about it. The whole point of such functions (as I see it) is help write texts in natural langauges. It seems unnatural to treat words preceded by a space and by a parenthesis *in a natural language* differently, no? > I also am not sure I understand what is so special about '(' that it > has to be hard-coded here. What about '[' or '{' or '<' (or any other > punctuation character, for that matter)? The special thing about `(' is that (unlike other characters you mentioned) is that it is actually used in a text in a natural language (though one could make a case for `[', too). >> Please review both the patch and the commit message (I'm still >> learning to write them...). > > The commit message should begin with a capital letter. Also, I think > this variant is more clear: > > Don't break after a single-character word that follows an opening > parenthesis. > > Thanks. Thanks and best regards, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 12:50:03 2016 Received: (at 20871) by debbugs.gnu.org; 17 Apr 2016 16:50:03 +0000 Received: from localhost ([127.0.0.1]:38605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arpta-0002Kp-QL for submit@debbugs.gnu.org; Sun, 17 Apr 2016 12:50:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arptZ-0002KF-Ch for 20871@debbugs.gnu.org; Sun, 17 Apr 2016 12:50:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arptP-0003h0-7h for 20871@debbugs.gnu.org; Sun, 17 Apr 2016 12:49:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arptP-0003gw-4N; Sun, 17 Apr 2016 12:49:51 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4707 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1arptO-0001Va-Du; Sun, 17 Apr 2016 12:49:50 -0400 Date: Sun, 17 Apr 2016 19:49:35 +0300 Message-Id: <83r3e49o4g.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87k2jwtfkj.fsf@mbork.pl> (message from Marcin Borkowski on Sun, 17 Apr 2016 17:34:04 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Sun, 17 Apr 2016 17:34:04 +0200 > > In Polish typography, it is customary to foribid line breaks after > one-letter words (and we have quite a few of them: a, i, o, w, z - they > are conjunctions or prepositions). And it is not uncommon to have > a combination of them with a parenthesized remark or something like > that. That's why allowing a linebreak after, say "(a" when writing > something in Polish (like an email, for instance) is a bug IMO. > > > See, the function in question, fill-single-char-nobreak-p, is > > documented as a possible value to use in the fill hook, for a very > > specific purpose. If you are saying that it doesn't fulfill that > > purpose well enough, please show a use case where it fails to do that. > > At least the situation you described, with " (a", doesn't seem to fit > > the use cases which this function is supposed to cover, since the > > parenthesis makes a 2-character sequence, whereas > > fill-single-char-nobreak-p aims to support isolated one-character > > words. > > I see. So you suggest that instead of patching > `fill-single-char-nobreak-p' I should have provided another function, > customized for Polish? Yes, I think so. There's already fill-french-nobreak-p, why shouldn't there be a Polish predicate? > In fact, I'm not so sure about it. The whole point of such functions > (as I see it) is help write texts in natural langauges. It seems > unnatural to treat words preceded by a space and by a parenthesis *in > a natural language* differently, no? Not necessarily: that space that precedes the word is by itself a line-breaking opportunity. IOW, Emacs will break before 'a' in " a", and the penalty will be only 1 character. By contrast, breaking before the parenthesis in your case will yield a penalty of 2 characters, which is a different tradeoff, worthy of asking the user explicitly to agree to. The default value of fill-nobreak-predicate is nil for a reason. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 13:41:37 2016 Received: (at 20871) by debbugs.gnu.org; 17 Apr 2016 17:41:37 +0000 Received: from localhost ([127.0.0.1]:38632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arqhU-0005CF-S0 for submit@debbugs.gnu.org; Sun, 17 Apr 2016 13:41:37 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:51546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arqhT-0005C7-GT for 20871@debbugs.gnu.org; Sun, 17 Apr 2016 13:41:35 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 91AFFAD26D8; Sun, 17 Apr 2016 19:41:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wZEBpEOgR11l; Sun, 17 Apr 2016 19:41:30 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 04BCCAD26D5; Sun, 17 Apr 2016 19:41:29 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> User-agent: mu4e 0.9.13; emacs 25.1.50.8 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83r3e49o4g.fsf@gnu.org> Date: Sun, 17 Apr 2016 19:41:29 +0200 Message-ID: <87fuukt9o6.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-04-17, at 16:49, Eli Zaretskii wrote: >> I see. So you suggest that instead of patching >> `fill-single-char-nobreak-p' I should have provided another function, >> customized for Polish? > > Yes, I think so. There's already fill-french-nobreak-p, why shouldn't > there be a Polish predicate? > >> [...] > > Not necessarily: that space that precedes the word is by itself a > line-breaking opportunity. IOW, Emacs will break before 'a' in " a", > and the penalty will be only 1 character. By contrast, breaking > before the parenthesis in your case will yield a penalty of 2 > characters, which is a different tradeoff, worthy of asking the user > explicitly to agree to. > > The default value of fill-nobreak-predicate is nil for a reason. I see. So I'm going to prepare a patch where a new function is introduced for Polish typography, and once it is accepted (which I hope will happen:-)) I'm going to close this bug. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 03:02:48 2016 Received: (at 20871) by debbugs.gnu.org; 27 Apr 2016 07:02:48 +0000 Received: from localhost ([127.0.0.1]:49336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avJUm-0004MA-3r for submit@debbugs.gnu.org; Wed, 27 Apr 2016 03:02:48 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:56839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avJUk-0004M2-1A for 20871@debbugs.gnu.org; Wed, 27 Apr 2016 03:02:46 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 1B7D4B0D0D2; Wed, 27 Apr 2016 09:02:44 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dl-h6XbRG8jk; Wed, 27 Apr 2016 09:02:41 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 078D4B0D0CE; Wed, 27 Apr 2016 09:02:41 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> User-agent: mu4e 0.9.13; emacs 25.1.50.8 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Message-ID: <87vb33h6ux.fsf@mbork.pl> In-reply-to: <83r3e49o4g.fsf@gnu.org> Date: Wed, 27 Apr 2016 09:02:36 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain On 2016-04-17, at 16:49, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Sun, 17 Apr 2016 17:34:04 +0200 >> >> In Polish typography, it is customary to foribid line breaks after >> one-letter words (and we have quite a few of them: a, i, o, w, z - they >> are conjunctions or prepositions). And it is not uncommon to have >> a combination of them with a parenthesized remark or something like >> that. That's why allowing a linebreak after, say "(a" when writing >> something in Polish (like an email, for instance) is a bug IMO. >> >> > See, the function in question, fill-single-char-nobreak-p, is >> > documented as a possible value to use in the fill hook, for a very >> > specific purpose. If you are saying that it doesn't fulfill that >> > purpose well enough, please show a use case where it fails to do that. >> > At least the situation you described, with " (a", doesn't seem to fit >> > the use cases which this function is supposed to cover, since the >> > parenthesis makes a 2-character sequence, whereas >> > fill-single-char-nobreak-p aims to support isolated one-character >> > words. >> >> I see. So you suggest that instead of patching >> `fill-single-char-nobreak-p' I should have provided another function, >> customized for Polish? > > Yes, I think so. There's already fill-french-nobreak-p, why shouldn't > there be a Polish predicate? I attach a new patch. Is it better now? Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-Add-the-function-fill-polish-nobreak-p.patch >From 6356c46bf6d5c90057b1a756f05c69791c9ff3db Mon Sep 17 00:00:00 2001 From: Marcin Borkowski Date: Wed, 27 Apr 2016 08:59:15 +0200 Subject: [PATCH] Add the function `fill-polish-nobreak-p' * lisp/textmodes/fill.el (fill-polish-nobreak-p): Prevent line-breaking after a single-letter word even if this word is not preceded by a space. (Bug #20871) --- lisp/textmodes/fill.el | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lisp/textmodes/fill.el b/lisp/textmodes/fill.el index 173d1c9..0a95290 100644 --- a/lisp/textmodes/fill.el +++ b/lisp/textmodes/fill.el @@ -329,6 +329,18 @@ fill-french-nobreak-p (and (memq (preceding-char) '(?\t ?\s)) (eq (char-syntax (following-char)) ?w))))))) +(defun fill-polish-nobreak-p () + "Return nil if Polish style allows breaking the line at point. +This function may be used in the `fill-nobreak-predicate' hook. +It is almost the same as `fill-single-char-nobreak-p', with the +exception that it does not require the one-letter word to be +preceded by a space. This blocks line-breaking in cases like +\"(a jednak)\"." + (save-excursion + (skip-chars-backward " \t") + (backward-char 2) + (looking-at "[^[:alpha:]][[:alpha:]]"))) + (defun fill-single-char-nobreak-p () "Return non-nil if a one-letter word is before point. This function is suitable for adding to the hook `fill-nobreak-predicate', -- 2.4.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 03:20:38 2016 Received: (at 20871) by debbugs.gnu.org; 27 Apr 2016 07:20:39 +0000 Received: from localhost ([127.0.0.1]:49341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avJm2-0004lE-OI for submit@debbugs.gnu.org; Wed, 27 Apr 2016 03:20:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avJm1-0004l2-HV for 20871@debbugs.gnu.org; Wed, 27 Apr 2016 03:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avJls-0002P5-LZ for 20871@debbugs.gnu.org; Wed, 27 Apr 2016 03:20:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avJls-0002P1-Iw; Wed, 27 Apr 2016 03:20:28 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1avJlr-0004iz-SZ; Wed, 27 Apr 2016 03:20:28 -0400 Date: Wed, 27 Apr 2016 10:20:12 +0300 Message-Id: <83a8kfzff7.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87vb33h6ux.fsf@mbork.pl> (message from Marcin Borkowski on Wed, 27 Apr 2016 09:02:36 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Wed, 27 Apr 2016 09:02:36 +0200 > > >> I see. So you suggest that instead of patching > >> `fill-single-char-nobreak-p' I should have provided another function, > >> customized for Polish? > > > > Yes, I think so. There's already fill-french-nobreak-p, why shouldn't > > there be a Polish predicate? > > I attach a new patch. Is it better now? Yes, thanks. Just one comment, for your consideration: > + (looking-at "[^[:alpha:]][[:alpha:]]"))) You should be aware that starting with Emacs 25.1 [:alpha:] matches a very large class of characters, some of them having nothing in common with those used in Polish. So perhaps it is better to use '\cl' instead, which will only capture Latin characters? Just a thought -- your call. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 29 08:18:44 2016 Received: (at 20871) by debbugs.gnu.org; 29 Apr 2016 12:18:44 +0000 Received: from localhost ([127.0.0.1]:54020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw7Nc-0005Xo-71 for submit@debbugs.gnu.org; Fri, 29 Apr 2016 08:18:44 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:32775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw7Na-0005Xg-B7 for 20871@debbugs.gnu.org; Fri, 29 Apr 2016 08:18:43 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 3B536B19D72; Fri, 29 Apr 2016 14:18:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lFt2qJU6QP0h; Fri, 29 Apr 2016 14:18:37 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 645DDB19D6F; Fri, 29 Apr 2016 14:18:37 +0200 (CEST) From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> Date: Fri, 29 Apr 2016 14:18:34 +0200 In-Reply-To: <83a8kfzff7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Apr 2016 10:20:12 +0300") Message-ID: <87shy4vc9x.fsf@mbork.pl> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-04-27, at 10:20, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Wed, 27 Apr 2016 09:02:36 +0200 >>=20 >> >> I see. So you suggest that instead of patching >> >> `fill-single-char-nobreak-p' I should have provided another function, >> >> customized for Polish? >> > >> > Yes, I think so. There's already fill-french-nobreak-p, why shouldn't >> > there be a Polish predicate? >>=20 >> I attach a new patch. Is it better now? > > Yes, thanks. > > Just one comment, for your consideration: > >> + (looking-at "[^[:alpha:]][[:alpha:]]"))) > > You should be aware that starting with Emacs 25.1 [:alpha:] matches a > very large class of characters, some of them having nothing in common > with those used in Polish. So perhaps it is better to use '\cl' > instead, which will only capture Latin characters? Just a thought -- > your call. I guess you are right, Eli - in fact, all one-letter words in Polish are matched by [aiouwz]. I decided to go with \cl, as you suggested, though - this way, the function could be (probably) useful also for Slovaks, for instance. I attach the corrected patch. Just to be sure: in my Emacs, \cl matches also =C4=85, =C4=99, =C5=BC, =C5= =BA, =C3=A1, =C3=B6 etc. Is it intentional? Is it documented somewhere? Thanks and best regards, --=20 Marcin --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-Add-the-function-fill-polish-nobreak-p.patch >From a3b46e0e260f011e9c5257bece8f2fdb123214e5 Mon Sep 17 00:00:00 2001 From: Marcin Borkowski Date: Wed, 27 Apr 2016 08:59:15 +0200 Subject: [PATCH] Add the function `fill-polish-nobreak-p' * lisp/textmodes/fill.el (fill-polish-nobreak-p): Prevent line-breaking after a single-letter word even if this word is not preceded by a space. (Bug #20871) --- lisp/textmodes/fill.el | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lisp/textmodes/fill.el b/lisp/textmodes/fill.el index 173d1c9..80f7e96 100644 --- a/lisp/textmodes/fill.el +++ b/lisp/textmodes/fill.el @@ -329,6 +329,18 @@ fill-french-nobreak-p (and (memq (preceding-char) '(?\t ?\s)) (eq (char-syntax (following-char)) ?w))))))) +(defun fill-polish-nobreak-p () + "Return nil if Polish style allows breaking the line at point. +This function may be used in the `fill-nobreak-predicate' hook. +It is almost the same as `fill-single-char-nobreak-p', with the +exception that it does not require the one-letter word to be +preceded by a space. This blocks line-breaking in cases like +\"(a jednak)\"." + (save-excursion + (skip-chars-backward " \t") + (backward-char 2) + (looking-at "[^[:alpha:]]\\cl"))) + (defun fill-single-char-nobreak-p () "Return non-nil if a one-letter word is before point. This function is suitable for adding to the hook `fill-nobreak-predicate', -- 2.4.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 07:22:08 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 11:22:08 +0000 Received: from localhost ([127.0.0.1]:56413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awSyO-0000Y8-Il for submit@debbugs.gnu.org; Sat, 30 Apr 2016 07:22:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awSyN-0000Xh-4k for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 07:22:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awSy8-00055U-M6 for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 07:21:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awSy8-00054i-Jc; Sat, 30 Apr 2016 07:21:52 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1458 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1awSy2-0007jw-JG; Sat, 30 Apr 2016 07:21:47 -0400 Date: Sat, 30 Apr 2016 14:21:44 +0300 Message-Id: <838tzvpcjb.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87shy4vc9x.fsf@mbork.pl> (message from Marcin Borkowski on Fri, 29 Apr 2016 14:18:34 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Fri, 29 Apr 2016 14:18:34 +0200 > > >> + (looking-at "[^[:alpha:]][[:alpha:]]"))) > > > > You should be aware that starting with Emacs 25.1 [:alpha:] matches a > > very large class of characters, some of them having nothing in common > > with those used in Polish. So perhaps it is better to use '\cl' > > instead, which will only capture Latin characters? Just a thought -- > > your call. > > I guess you are right, Eli - in fact, all one-letter words in Polish are > matched by [aiouwz]. I decided to go with \cl, as you suggested, > though - this way, the function could be (probably) useful also for > Slovaks, for instance. I attach the corrected patch. LGTM, thanks. > Just to be sure: in my Emacs, \cl matches also ą, ę, ż, ź, á, ö etc. Is > it intentional? Yes. \cl matches any character that belongs to any of the Latin blocks. > Is it documented somewhere? Not sure what needs to be documented, please elaborate. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 08:26:40 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 12:26:40 +0000 Received: from localhost ([127.0.0.1]:56452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awTyq-0003yC-Kt for submit@debbugs.gnu.org; Sat, 30 Apr 2016 08:26:40 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:55742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awTyo-0003y4-FJ for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 08:26:39 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 0E0C8B1E89E; Sat, 30 Apr 2016 14:26:37 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lWsZHTX+XZv9; Sat, 30 Apr 2016 14:26:32 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 9F3BDB1E89D; Sat, 30 Apr 2016 14:26:31 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> User-agent: mu4e 0.9.13; emacs 25.1.50.9 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <838tzvpcjb.fsf@gnu.org> Date: Sat, 30 Apr 2016 14:26:28 +0200 Message-ID: <87vb2zth8r.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-04-30, at 13:21, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Fri, 29 Apr 2016 14:18:34 +0200 >> >> >> + (looking-at "[^[:alpha:]][[:alpha:]]"))) >> > >> > You should be aware that starting with Emacs 25.1 [:alpha:] matches a >> > very large class of characters, some of them having nothing in common >> > with those used in Polish. So perhaps it is better to use '\cl' >> > instead, which will only capture Latin characters? Just a thought -- >> > your call. >> >> I guess you are right, Eli - in fact, all one-letter words in Polish are >> matched by [aiouwz]. I decided to go with \cl, as you suggested, >> though - this way, the function could be (probably) useful also for >> Slovaks, for instance. I attach the corrected patch. > > LGTM, thanks. Thanks! >> Just to be sure: in my Emacs, \cl matches also ą, ę, ż, ź, á, ö etc. Is >> it intentional? > > Yes. \cl matches any character that belongs to any of the Latin > blocks. > >> Is it documented somewhere? > > Not sure what needs to be documented, please elaborate. Well, at first I thought that "Latin" means "matching [a-z]". Finding out that accented letter qualify, too, was a (pleasant) surprise. Finding that out using `describe-categories' is a bit tricky, since its output contains ranges, and I don't know which of them does e.g. "ą" belong to. The output of `describe-categories' says "Legend of category mnemonics (see the tail for the longer description)"; I guess the "longer" description might say something more. For instance, this line: (define-category ?l "Latin") in characters.el could be replaced by (define-category ?l "Latin Latin letters (including those with diacritics)") This way, there would be at least a hint at the bottom of the *Help* buffer displayed by `describe-categories'. WDYT? Would you like me to prepare a patch? Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 08:38:44 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 12:38:44 +0000 Received: from localhost ([127.0.0.1]:56456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awUAV-0004Fr-QE for submit@debbugs.gnu.org; Sat, 30 Apr 2016 08:38:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awUAP-0004FZ-Kv for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 08:38:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awUAA-0007o5-W1 for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 08:38:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awUAA-0007nK-So; Sat, 30 Apr 2016 08:38:22 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1492 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1awUA4-0003Tc-RX; Sat, 30 Apr 2016 08:38:17 -0400 Date: Sat, 30 Apr 2016 15:38:14 +0300 Message-Id: <837fffp8zt.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87vb2zth8r.fsf@mbork.pl> (message from Marcin Borkowski on Sat, 30 Apr 2016 14:26:28 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Sat, 30 Apr 2016 14:26:28 +0200 > > (define-category ?l "Latin") > > in characters.el > > could be replaced by > > (define-category ?l "Latin > Latin letters (including those with diacritics)") That doesn't sound right: why single out diacritics? And why only for Latin? If we want to enhance those doc strings, each one of them should state what Unicode blocks are covered. (It would be okay to say something like "all Latin blocks", instead of enumerating them all, and similarly for the other categories.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 12:41:43 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 16:41:43 +0000 Received: from localhost ([127.0.0.1]:58134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awXxf-0005kz-1U for submit@debbugs.gnu.org; Sat, 30 Apr 2016 12:41:43 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:60395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awXxd-0005kq-4D for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 12:41:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 30ED2B1FB59; Sat, 30 Apr 2016 18:41:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X8LyUMk5Zifd; Sat, 30 Apr 2016 18:41:36 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 8A243B1FB56; Sat, 30 Apr 2016 18:41:36 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> User-agent: mu4e 0.9.13; emacs 25.1.50.9 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <837fffp8zt.fsf@gnu.org> Date: Sat, 30 Apr 2016 18:41:32 +0200 Message-ID: <877fff3v7n.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-04-30, at 14:38, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Sat, 30 Apr 2016 14:26:28 +0200 >> >> (define-category ?l "Latin") >> >> in characters.el >> >> could be replaced by >> >> (define-category ?l "Latin >> Latin letters (including those with diacritics)") > > That doesn't sound right: why single out diacritics? And why only for > Latin? Because I don't really know what this category is about? I think that my confusion is a sufficient proof that more precise documentation is needed. > If we want to enhance those doc strings, each one of them should state > what Unicode blocks are covered. (It would be okay to say something > like "all Latin blocks", instead of enumerating them all, and > similarly for the other categories.) A user might not know what exactly a "Unicode block" is. (I don't.) I think a pointer to some sources or a few words of explanation are really needed. (I won't make a patch, though, since I clearly know too little about it to do it correctly.) > Thanks. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 13:01:35 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 17:01:35 +0000 Received: from localhost ([127.0.0.1]:58173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYGt-0000go-4J for submit@debbugs.gnu.org; Sat, 30 Apr 2016 13:01:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYGs-0000cQ-8W for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 13:01:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awYGd-0001Ek-Nw for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 13:01:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awYGd-0001Dr-Km; Sat, 30 Apr 2016 13:01:19 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1924 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1awYGX-0007iq-JZ; Sat, 30 Apr 2016 13:01:14 -0400 Date: Sat, 30 Apr 2016 20:01:11 +0300 Message-Id: <83mvobni94.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <877fff3v7n.fsf@mbork.pl> (message from Marcin Borkowski on Sat, 30 Apr 2016 18:41:32 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Sat, 30 Apr 2016 18:41:32 +0200 > > >> (define-category ?l "Latin > >> Latin letters (including those with diacritics)") > > > > That doesn't sound right: why single out diacritics? And why only for > > Latin? > > Because I don't really know what this category is about? > > I think that my confusion is a sufficient proof that more precise > documentation is needed. I didn't object to expanding the doc string, I only suggested that we do it right. > > If we want to enhance those doc strings, each one of them should state > > what Unicode blocks are covered. (It would be okay to say something > > like "all Latin blocks", instead of enumerating them all, and > > similarly for the other categories.) > > A user might not know what exactly a "Unicode block" is. (I don't.) > I think a pointer to some sources or a few words of explanation are > really needed. A reference to the ELisp manual should do (the explanation should be added to the manual first, of course). > (I won't make a patch, though, since I clearly know too little about > it to do it correctly.) An opportunity to learn, I'd say. You could start with admin/unidata/Blocks.txt, for example. We use it to generate charscript.el (and categories are a semi-obsolete facility that predates char-script-table). From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 13:42:38 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 17:42:38 +0000 Received: from localhost ([127.0.0.1]:58253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYuc-0005SN-Cl for submit@debbugs.gnu.org; Sat, 30 Apr 2016 13:42:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awYub-0005SA-9F for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 13:42:37 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3UHgU1A013939 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Apr 2016 17:42:31 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u3UHgUI7010028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Apr 2016 17:42:30 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u3UHgTI8014352; Sat, 30 Apr 2016 17:42:29 GMT MIME-Version: 1.0 Message-ID: <7985af2e-fb1d-40ad-bb37-bca783e58044@default> Date: Sat, 30 Apr 2016 09:42:28 -0800 (GMT-08:00) From: Drew Adams To: Marcin Borkowski , Eli Zaretskii Subject: RE: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> In-Reply-To: <877fff3v7n.fsf@mbork.pl> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I think that my confusion is a sufficient proof that more precise > documentation is needed. +1. Maybe not "more precise" (I cannot judge whether what is there is precise), but more user-friendly. It is fine (great) to use the precise Unicode terminology and to point to the Unicode standard for more information. But it also helpful to provide a little coaching in the Emacs doc, for us users who are not Unicode pros. It probably would not take much additional explanation. > > If we want to enhance those doc strings, each one of them should state > > what Unicode blocks are covered. (It would be okay to say something > > like "all Latin blocks", instead of enumerating them all, and > > similarly for the other categories.) >=20 > A user might not know what exactly a "Unicode block" is. (I don't.) > I think a pointer to some sources or a few words of explanation are > really needed. (I won't make a patch, though, since I clearly know too > little about it to do it correctly.) +1 This kind of user feedback is helpful. It should not be ignored, IMO, especially if the reason for ignoring is just that the doc is accurate and precise. It's also about being amenable (dare I say even "inviting") to an average Emacs user. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:24:47 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 18:24:47 +0000 Received: from localhost ([127.0.0.1]:58333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZZO-0008A1-R9 for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:24:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZZN-00089o-1W for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 14:24:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awZZ8-00032Q-KV for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 14:24:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awZZ7-00030u-I5; Sat, 30 Apr 2016 14:24:30 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1awZZ1-0006XJ-CN; Sat, 30 Apr 2016 14:24:23 -0400 Date: Sat, 30 Apr 2016 21:24:21 +0300 Message-Id: <83fuu3neei.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: <7985af2e-fb1d-40ad-bb37-bca783e58044@default> (message from Drew Adams on Sat, 30 Apr 2016 09:42:28 -0800 (GMT-08:00)) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <7985af2e-fb1d-40ad-bb37-bca783e58044@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: mbork@mbork.pl, 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sat, 30 Apr 2016 09:42:28 -0800 (GMT-08:00) > From: Drew Adams > Cc: 20871@debbugs.gnu.org > > This kind of user feedback is helpful. It should not be > ignored Did I ignore it? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:41:20 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 18:41:20 +0000 Received: from localhost ([127.0.0.1]:58381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZpQ-0001o1-Ir for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:41:20 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:34488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZpP-0001nr-4T for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 14:41:19 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 0316BB20032; Sat, 30 Apr 2016 20:41:16 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZbiXfcn6CLMl; Sat, 30 Apr 2016 20:41:13 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 48A7DB20031; Sat, 30 Apr 2016 20:41:13 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <7985af2e-fb1d-40ad-bb37-bca783e58044@default> <83fuu3neei.fsf@gnu.org> User-agent: mu4e 0.9.13; emacs 25.1.50.9 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83fuu3neei.fsf@gnu.org> Date: Sat, 30 Apr 2016 20:41:12 +0200 Message-ID: <8760uz3po7.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-04-30, at 20:24, Eli Zaretskii wrote: >> Date: Sat, 30 Apr 2016 09:42:28 -0800 (GMT-08:00) >> From: Drew Adams >> Cc: 20871@debbugs.gnu.org >> >> This kind of user feedback is helpful. It should not be >> ignored > > Did I ignore it? I don't think so. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 14:42:51 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 18:42:51 +0000 Received: from localhost ([127.0.0.1]:58385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZqs-0001q5-U1 for submit@debbugs.gnu.org; Sat, 30 Apr 2016 14:42:51 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:34546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awZqq-0001pw-Pm for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 14:42:49 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 1E6ECB2004A; Sat, 30 Apr 2016 20:42:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JxNIIHGjJ82t; Sat, 30 Apr 2016 20:42:44 +0200 (CEST) Received: from localhost (98-171.echostar.pl [213.156.98.171]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 18C64B20043; Sat, 30 Apr 2016 20:42:44 +0200 (CEST) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> User-agent: mu4e 0.9.13; emacs 25.1.50.9 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83mvobni94.fsf@gnu.org> Date: Sat, 30 Apr 2016 20:42:43 +0200 Message-ID: <874maj3plo.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2016-04-30, at 19:01, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Sat, 30 Apr 2016 18:41:32 +0200 >> >> >> (define-category ?l "Latin >> >> Latin letters (including those with diacritics)") >> > >> > That doesn't sound right: why single out diacritics? And why only for >> > Latin? >> >> Because I don't really know what this category is about? >> >> I think that my confusion is a sufficient proof that more precise >> documentation is needed. > > I didn't object to expanding the doc string, I only suggested that we > do it right. I didn't claim you objected. >> > If we want to enhance those doc strings, each one of them should state >> > what Unicode blocks are covered. (It would be okay to say something >> > like "all Latin blocks", instead of enumerating them all, and >> > similarly for the other categories.) >> >> A user might not know what exactly a "Unicode block" is. (I don't.) >> I think a pointer to some sources or a few words of explanation are >> really needed. > > A reference to the ELisp manual should do (the explanation should be > added to the manual first, of course). > >> (I won't make a patch, though, since I clearly know too little about >> it to do it correctly.) > > An opportunity to learn, I'd say. You could start with > admin/unidata/Blocks.txt, for example. We use it to generate > charscript.el (and categories are a semi-obsolete facility that > predates char-script-table). You got me here. The problem is, I'm not going to have a lot of free time in the next few weeks/months. (I'll also probably have to stop any work on Emacs bugs for some time, for instance.) But I'll try to look into this one. Best, -- Marcin Borkowski http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski Faculty of Mathematics and Computer Science Adam Mickiewicz University From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 15:01:58 2016 Received: (at 20871) by debbugs.gnu.org; 30 Apr 2016 19:01:59 +0000 Received: from localhost ([127.0.0.1]:58409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awa9O-0005VF-LK for submit@debbugs.gnu.org; Sat, 30 Apr 2016 15:01:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awa9N-0005Q0-7R for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 15:01:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awa8z-0006he-Kv for 20871@debbugs.gnu.org; Sat, 30 Apr 2016 15:01:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awa8z-0006fa-Hn; Sat, 30 Apr 2016 15:01:33 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1990 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1awa8t-0001qJ-FD; Sat, 30 Apr 2016 15:01:27 -0400 Date: Sat, 30 Apr 2016 22:01:25 +0300 Message-Id: <83bn4qor96.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <874maj3plo.fsf@mbork.pl> (message from Marcin Borkowski on Sat, 30 Apr 2016 20:42:43 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Sat, 30 Apr 2016 20:42:43 +0200 > > > An opportunity to learn, I'd say. You could start with > > admin/unidata/Blocks.txt, for example. We use it to generate > > charscript.el (and categories are a semi-obsolete facility that > > predates char-script-table). > > You got me here. The problem is, I'm not going to have a lot of free > time in the next few weeks/months. There's no rush. You shouldn't feel hard-pressed for a quick job. > But I'll try to look into this one. Great, thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 07 08:28:26 2017 Received: (at 20871) by debbugs.gnu.org; 7 Dec 2017 13:28:26 +0000 Received: from localhost ([127.0.0.1]:50023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMwDx-0002FI-Qm for submit@debbugs.gnu.org; Thu, 07 Dec 2017 08:28:26 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:49062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eMwDv-0002F8-Tv for 20871@debbugs.gnu.org; Thu, 07 Dec 2017 08:28:24 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 7175FE6BAD; Thu, 7 Dec 2017 14:28:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZJWwUXshRGv8; Thu, 7 Dec 2017 14:28:18 +0100 (CET) Received: from localhost (unknown [83.13.149.242]) by mail.mojserwer.eu (Postfix) with ESMTPSA id ED718E6008; Thu, 7 Dec 2017 14:28:17 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83bn4qor96.fsf@gnu.org> Date: Thu, 07 Dec 2017 14:28:20 +0100 Message-ID: <87zi6u7jm3.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.8 (/) On 2016-04-30, at 21:01, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Sat, 30 Apr 2016 20:42:43 +0200 >> >> > An opportunity to learn, I'd say. You could start with >> > admin/unidata/Blocks.txt, for example. We use it to generate >> > charscript.el (and categories are a semi-obsolete facility that >> > predates char-script-table). >> >> You got me here. The problem is, I'm not going to have a lot of free >> time in the next few weeks/months. > > There's no rush. You shouldn't feel hard-pressed for a quick job. > >> But I'll try to look into this one. > > Great, thanks. OK, so let me revive this old thread. I decided to spend some (not too much...) time on Emacs bugs again. First things first: I think I fixed this one. (This is a bit embarassing: I did it many months ago, pushed a branch and forgot to mention it here.) Here it is: http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871 - can anyone look at it? In the next few days I'm going to look at the documentation problem we discussed here. Best, -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 06:52:34 2017 Received: (at 20871) by debbugs.gnu.org; 9 Dec 2017 11:52:35 +0000 Received: from localhost ([127.0.0.1]:53172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNdgI-00041S-Lf for submit@debbugs.gnu.org; Sat, 09 Dec 2017 06:52:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNdgH-00041H-62 for 20871@debbugs.gnu.org; Sat, 09 Dec 2017 06:52:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNdg8-0007NC-Vn for 20871@debbugs.gnu.org; Sat, 09 Dec 2017 06:52:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNdg8-0007Mp-S4; Sat, 09 Dec 2017 06:52:24 -0500 Received: from [176.228.60.248] (port=4335 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eNdg8-0004iE-3d; Sat, 09 Dec 2017 06:52:24 -0500 Date: Sat, 09 Dec 2017 13:52:06 +0200 Message-Id: <831sk4unix.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87zi6u7jm3.fsf@mbork.pl> (message from Marcin Borkowski on Thu, 07 Dec 2017 14:28:20 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Thu, 07 Dec 2017 14:28:20 +0100 > > OK, so let me revive this old thread. I decided to spend some (not too > much...) time on Emacs bugs again. First things first: I think I fixed > this one. (This is a bit embarassing: I did it many months ago, pushed > a branch and forgot to mention it here.) Here it is: > http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871 - can > anyone look at it? I took a look. It looks reasonable, but I think it will also need to be mentioned in the Emacs User manual, node "Fill Commands". In addition, could you write a couple of tests for this feature? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 09 10:48:48 2017 Received: (at 20871) by debbugs.gnu.org; 9 Dec 2017 15:48:48 +0000 Received: from localhost ([127.0.0.1]:54011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNhMu-00031C-HI for submit@debbugs.gnu.org; Sat, 09 Dec 2017 10:48:48 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:53097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNhMs-000313-Vf for 20871@debbugs.gnu.org; Sat, 09 Dec 2017 10:48:47 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 49CF6E6BE1; Sat, 9 Dec 2017 16:48:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OFYPDehDDh0Z; Sat, 9 Dec 2017 16:48:37 +0100 (CET) Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 11B2EE626F; Sat, 9 Dec 2017 16:48:37 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Message-ID: <87vahf7vnx.fsf@mbork.pl> In-reply-to: <831sk4unix.fsf@gnu.org> Date: Sat, 09 Dec 2017 16:45:50 +0100 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2017-12-09, at 12:52, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Thu, 07 Dec 2017 14:28:20 +0100 >> >> OK, so let me revive this old thread. I decided to spend some (not too >> much...) time on Emacs bugs again. First things first: I think I fixed >> this one. (This is a bit embarassing: I did it many months ago, pushed >> a branch and forgot to mention it here.) Here it is: >> http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871 - can >> anyone look at it? > > I took a look. It looks reasonable, but I think it will also need to > be mentioned in the Emacs User manual, node "Fill Commands". In > addition, could you write a couple of tests for this feature? OK, I'll look into it and get back here. Best, -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 06:44:35 2017 Received: (at 20871) by debbugs.gnu.org; 19 Dec 2017 11:44:35 +0000 Received: from localhost ([127.0.0.1]:41305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRGK2-0004dM-NM for submit@debbugs.gnu.org; Tue, 19 Dec 2017 06:44:34 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:33429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRGK0-0004dB-FN for 20871@debbugs.gnu.org; Tue, 19 Dec 2017 06:44:33 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id A4B31E6717; Tue, 19 Dec 2017 12:44:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BWVHSjMvLBzv; Tue, 19 Dec 2017 12:44:24 +0100 (CET) Received: from localhost (unknown [62.3.163.158]) by mail.mojserwer.eu (Postfix) with ESMTPSA id B9B4CE6628; Tue, 19 Dec 2017 12:44:24 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <87vahf7vnx.fsf@mbork.pl> Date: Tue, 19 Dec 2017 12:44:21 +0100 Message-ID: <87r2rr7xii.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2017-12-09, at 16:45, Marcin Borkowski wrote: > On 2017-12-09, at 12:52, Eli Zaretskii wrote: > >>> From: Marcin Borkowski >>> Cc: 20871@debbugs.gnu.org >>> Date: Thu, 07 Dec 2017 14:28:20 +0100 >>> >>> OK, so let me revive this old thread. I decided to spend some (not too >>> much...) time on Emacs bugs again. First things first: I think I fixed >>> this one. (This is a bit embarassing: I did it many months ago, pushed >>> a branch and forgot to mention it here.) Here it is: >>> http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871 - can >>> anyone look at it? >> >> I took a look. It looks reasonable, but I think it will also need to >> be mentioned in the Emacs User manual, node "Fill Commands". In >> addition, could you write a couple of tests for this feature? > > OK, I'll look into it and get back here. So I did take a look. The mention in the manual is already there, I forgot I did that back then. Where should I put the tests? I expected something in e.g. test/lisp/textmodes/fill.el, but there's nothing like that there. Also, should I test only my function, or filling with it, or both? Best, -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 19 11:15:45 2017 Received: (at 20871) by debbugs.gnu.org; 19 Dec 2017 16:15:45 +0000 Received: from localhost ([127.0.0.1]:42496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRKYT-0006nL-AZ for submit@debbugs.gnu.org; Tue, 19 Dec 2017 11:15:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRKYS-0006nA-5V for 20871@debbugs.gnu.org; Tue, 19 Dec 2017 11:15:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRKYJ-00029F-CY for 20871@debbugs.gnu.org; Tue, 19 Dec 2017 11:15:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRKYJ-000298-77; Tue, 19 Dec 2017 11:15:35 -0500 Received: from [176.228.60.248] (port=2201 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eRKYI-0000eD-Ka; Tue, 19 Dec 2017 11:15:35 -0500 Date: Tue, 19 Dec 2017 18:15:45 +0200 Message-Id: <83a7yepuby.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87r2rr7xii.fsf@mbork.pl> (message from Marcin Borkowski on Tue, 19 Dec 2017 12:44:21 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Tue, 19 Dec 2017 12:44:21 +0100 > > >> I took a look. It looks reasonable, but I think it will also need to > >> be mentioned in the Emacs User manual, node "Fill Commands". In > >> addition, could you write a couple of tests for this feature? > > > > OK, I'll look into it and get back here. > > So I did take a look. The mention in the manual is already there, > I forgot I did that back then. Right, sorry I missed that somehow. > Where should I put the tests? > I expected something in e.g. test/lisp/textmodes/fill.el, but there's > nothing like that there. If the file doesn't exist, create it. > Also, should I test only my function, or filling with it, or both? I think filling with your function is the most important thing to test. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 02 03:55:55 2018 Received: (at 20871) by debbugs.gnu.org; 2 Jan 2018 08:55:55 +0000 Received: from localhost ([127.0.0.1]:60424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWIMV-0005d8-Kj for submit@debbugs.gnu.org; Tue, 02 Jan 2018 03:55:55 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:32827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eWIMR-0005cx-Hq for 20871@debbugs.gnu.org; Tue, 02 Jan 2018 03:55:52 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id D2686E6691; Tue, 2 Jan 2018 09:55:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id smZGM4FV-s5Z; Tue, 2 Jan 2018 09:55:46 +0100 (CET) Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 7347BE6034; Tue, 2 Jan 2018 09:55:46 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83a7yepuby.fsf@gnu.org> Date: Tue, 02 Jan 2018 09:55:47 +0100 Message-ID: <87o9mchc6k.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2017-12-19, at 17:15, Eli Zaretskii wrote: >> So I did take a look. The mention in the manual is already there, >> I forgot I did that back then. > > Right, sorry I missed that somehow. No problem. >> Where should I put the tests? >> I expected something in e.g. test/lisp/textmodes/fill.el, but there's >> nothing like that there. > > If the file doesn't exist, create it. > >> Also, should I test only my function, or filling with it, or both? > > I think filling with your function is the most important thing to > test. > > Thanks. So that's what I did (see commit 1ad94a126b on branch fix/bug-20871, http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871). Is that ok? I admit that these tests are rather simplistic, and I'm still not sure about my commit message. Best, -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 03:46:57 2018 Received: (at 20871) by debbugs.gnu.org; 13 Jan 2018 08:46:58 +0000 Received: from localhost ([127.0.0.1]:54359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaHSr-0004jy-Lb for submit@debbugs.gnu.org; Sat, 13 Jan 2018 03:46:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaHSq-0004jj-Ed for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 03:46:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaHSg-0000ZZ-S0 for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 03:46:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaHSg-0000ZN-Nx; Sat, 13 Jan 2018 03:46:46 -0500 Received: from [176.228.60.248] (port=4832 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eaHSg-0001Me-6X; Sat, 13 Jan 2018 03:46:46 -0500 Date: Sat, 13 Jan 2018 10:46:27 +0200 Message-Id: <83o9ly16zg.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87o9mchc6k.fsf@mbork.pl> (message from Marcin Borkowski on Tue, 02 Jan 2018 09:55:47 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Tue, 02 Jan 2018 09:55:47 +0100 > > >> Where should I put the tests? > >> I expected something in e.g. test/lisp/textmodes/fill.el, but there's > >> nothing like that there. > > > > If the file doesn't exist, create it. > > > >> Also, should I test only my function, or filling with it, or both? > > > > I think filling with your function is the most important thing to > > test. > > > > Thanks. > > So that's what I did (see commit 1ad94a126b on branch fix/bug-20871, > http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871). Is > that ok? Yes. > I admit that these tests are rather simplistic, and I'm still > not sure about my commit message. I think this is ready to be installed, and if there are issues with commit messages, we will deal with them when installing. So please post the full patch for this issue, and let's take it from there. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 11:01:27 2018 Received: (at 20871) by debbugs.gnu.org; 13 Jan 2018 16:01:27 +0000 Received: from localhost ([127.0.0.1]:55049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaOFK-0000Ei-Rh for submit@debbugs.gnu.org; Sat, 13 Jan 2018 11:01:26 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:33549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaOFJ-0000Ea-09 for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 11:01:25 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 59662E6CDC; Sat, 13 Jan 2018 17:01:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B8drTxeh6QrS; Sat, 13 Jan 2018 17:01:19 +0100 (CET) Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id B54DCE6CD7; Sat, 13 Jan 2018 17:01:18 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83o9ly16zg.fsf@gnu.org> Date: Sat, 13 Jan 2018 17:01:14 +0100 Message-ID: <87shb9d9yt.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2018-01-13, at 09:46, Eli Zaretskii wrote: >> So that's what I did (see commit 1ad94a126b on branch fix/bug-20871, >> http://git.savannah.gnu.org/cgit/emacs.git/log/?h=fix/bug-20871). Is >> that ok? > > Yes. > >> I admit that these tests are rather simplistic, and I'm still >> not sure about my commit message. > > I think this is ready to be installed, and if there are issues with > commit messages, we will deal with them when installing. > > So please post the full patch for this issue, and let's take it from > there. Thanks. Why not just merge my branch into master? Best, -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 11:54:26 2018 Received: (at 20871) by debbugs.gnu.org; 13 Jan 2018 16:54:26 +0000 Received: from localhost ([127.0.0.1]:55059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaP4c-0001R3-4h for submit@debbugs.gnu.org; Sat, 13 Jan 2018 11:54:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaP4b-0001Qq-0o for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 11:54:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaP4U-0005ss-MO for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 11:54:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaP4U-0005sl-IS; Sat, 13 Jan 2018 11:54:18 -0500 Received: from [176.228.60.248] (port=1619 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eaP4S-0003eM-PS; Sat, 13 Jan 2018 11:54:18 -0500 Date: Sat, 13 Jan 2018 18:53:52 +0200 Message-Id: <83h8rp1yzj.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87shb9d9yt.fsf@mbork.pl> (message from Marcin Borkowski on Sat, 13 Jan 2018 17:01:14 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Sat, 13 Jan 2018 17:01:14 +0100 > > > So please post the full patch for this issue, and let's take it from > > there. > > Thanks. Why not just merge my branch into master? Because that would not have the patch recorded by the tracker, and because I'd like to have the patch reviewed by others if they want. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 13 12:03:23 2018 Received: (at 20871) by debbugs.gnu.org; 13 Jan 2018 17:03:23 +0000 Received: from localhost ([127.0.0.1]:55063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaPDF-0001eY-2M for submit@debbugs.gnu.org; Sat, 13 Jan 2018 12:03:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:55688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaPDD-0001eM-Kg for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 12:03:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eaPD5-0004yO-6n for 20871@debbugs.gnu.org; Sat, 13 Jan 2018 12:03:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eaPD5-0004yE-3L; Sat, 13 Jan 2018 12:03:11 -0500 Received: from [176.228.60.248] (port=1637 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eaPD3-0004AU-Fp; Sat, 13 Jan 2018 12:03:10 -0500 Date: Sat, 13 Jan 2018 19:02:44 +0200 Message-Id: <83fu791ykr.fsf@gnu.org> From: Eli Zaretskii To: mbork@mbork.pl In-reply-to: <83h8rp1yzj.fsf@gnu.org> (message from Eli Zaretskii on Sat, 13 Jan 2018 18:53:52 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> <87k2jwtfkj.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> <83h8rp1yzj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 13 Jan 2018 18:53:52 +0200 > From: Eli Zaretskii > Cc: 20871@debbugs.gnu.org > > > Thanks. Why not just merge my branch into master? > > Because that would not have the patch recorded by the tracker, and > because I'd like to have the patch reviewed by others if they want. Maybe I misunderstood you: if you were asking whether you can merge you're branch onto master, then please go ahead. That would not let you fix your commit messages easily, though (if that's what you wanted to do). From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 00:13:18 2018 Received: (at 20871) by debbugs.gnu.org; 15 Jan 2018 05:13:18 +0000 Received: from localhost ([127.0.0.1]:56577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eax5C-0007n9-3v for submit@debbugs.gnu.org; Mon, 15 Jan 2018 00:13:18 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:50106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eax5A-0007n0-Mc for 20871@debbugs.gnu.org; Mon, 15 Jan 2018 00:13:17 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 5A679E673B; Mon, 15 Jan 2018 06:13:14 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xNBCH4DKsIoo; Mon, 15 Jan 2018 06:13:07 +0100 (CET) Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 896AAE6034; Mon, 15 Jan 2018 06:13:07 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <83r3e49o4g.fsf@gnu.org> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> <83h8rp1yzj.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83h8rp1yzj.fsf@gnu.org> Date: Mon, 15 Jan 2018 06:13:07 +0100 Message-ID: <874lnnaen0.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2018-01-13, at 17:53, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Sat, 13 Jan 2018 17:01:14 +0100 >> >> > So please post the full patch for this issue, and let's take it from >> > there. >> >> Thanks. Why not just merge my branch into master? > > Because that would not have the patch recorded by the tracker, and > because I'd like to have the patch reviewed by others if they want. I see, I'll do it in a minute. Best, -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 00:13:30 2018 Received: (at 20871) by debbugs.gnu.org; 15 Jan 2018 05:13:30 +0000 Received: from localhost ([127.0.0.1]:56580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eax5O-0007nY-Ds for submit@debbugs.gnu.org; Mon, 15 Jan 2018 00:13:30 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:50116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eax5N-0007nR-FE for 20871@debbugs.gnu.org; Mon, 15 Jan 2018 00:13:29 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id CA37FE673B; Mon, 15 Jan 2018 06:13:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H1J9klT8XOLJ; Mon, 15 Jan 2018 06:13:25 +0100 (CET) Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 30967E6034; Mon, 15 Jan 2018 06:13:25 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> <83h8rp1yzj.fsf@gnu.org> <83fu791ykr.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83fu791ykr.fsf@gnu.org> Date: Mon, 15 Jan 2018 06:13:25 +0100 Message-ID: <873737aemi.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2018-01-13, at 18:02, Eli Zaretskii wrote: >> Date: Sat, 13 Jan 2018 18:53:52 +0200 >> From: Eli Zaretskii >> Cc: 20871@debbugs.gnu.org >> >> > Thanks. Why not just merge my branch into master? >> >> Because that would not have the patch recorded by the tracker, and >> because I'd like to have the patch reviewed by others if they want. > > Maybe I misunderstood you: if you were asking whether you can merge > you're branch onto master, then please go ahead. That would not let > you fix your commit messages easily, though (if that's what you wanted > to do). Good point, I didn't think about it! -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 00:30:37 2018 Received: (at 20871) by debbugs.gnu.org; 15 Jan 2018 05:30:37 +0000 Received: from localhost ([127.0.0.1]:56610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaxLv-0008Dj-K0 for submit@debbugs.gnu.org; Mon, 15 Jan 2018 00:30:37 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:50410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eaxLt-0008Db-9g for 20871@debbugs.gnu.org; Mon, 15 Jan 2018 00:30:33 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 2D78CE673B; Mon, 15 Jan 2018 06:30:31 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N9NKNoKkrai1; Mon, 15 Jan 2018 06:30:24 +0100 (CET) Received: from localhost (static-dwadziewiec-jedenpiec7.echostar.pl [109.232.29.157]) by mail.mojserwer.eu (Postfix) with ESMTPSA id CD322E6034; Mon, 15 Jan 2018 06:30:23 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> <83h8rp1yzj.fsf@gnu.org> <874lnnaen0.fsf@mbork.pl> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <874lnnaen0.fsf@mbork.pl> Date: Mon, 15 Jan 2018 06:30:20 +0100 Message-ID: <871siradub.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain On 2018-01-15, at 06:13, Marcin Borkowski wrote: > On 2018-01-13, at 17:53, Eli Zaretskii wrote: > >>> > So please post the full patch for this issue, and let's take it from >>> > there. > > I see, I'll do it in a minute. I attach the patch (which is made by squashing both the commits I made). Best, -- Marcin Borkowski --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-the-function-fill-polish-nobreak-p-with-tests.patch >From 96b4bd4cef5008561f336d8d1de47548d738c1ff Mon Sep 17 00:00:00 2001 From: Marcin Borkowski Date: Wed, 27 Apr 2016 08:59:15 +0200 Subject: [PATCH] Add the function `fill-polish-nobreak-p' with tests * lisp/textmodes/fill.el (fill-polish-nobreak-p): Prevent line-breaking after a single-letter word even if this word is not preceded by a space. Fixes bug #20871. --- doc/emacs/text.texi | 7 ++++-- etc/NEWS | 5 ++++ lisp/textmodes/fill.el | 12 ++++++++++ test/lisp/textmodes/fill-tests.el | 50 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 72 insertions(+), 2 deletions(-) create mode 100644 test/lisp/textmodes/fill-tests.el diff --git a/doc/emacs/text.texi b/doc/emacs/text.texi index 846d9fe8c6..2f180f82ca 100644 --- a/doc/emacs/text.texi +++ b/doc/emacs/text.texi @@ -636,8 +636,11 @@ Fill Commands break the line there. Functions you can use there include: @code{fill-single-word-nobreak-p} (don't break after the first word of a sentence or before the last); @code{fill-single-char-nobreak-p} -(don't break after a one-letter word); and @code{fill-french-nobreak-p} -(don't break after @samp{(} or before @samp{)}, @samp{:} or @samp{?}). +(don't break after a one-letter word preceded by a whitespace +character); @code{fill-french-nobreak-p} (don't break after @samp{(} +or before @samp{)}, @samp{:} or @samp{?}); and +@code{fill-polish-nobreak-p} (don't break after a one letter word, +even if preceded by a non-whitespace character). @node Fill Prefix @subsection The Fill Prefix diff --git a/etc/NEWS b/etc/NEWS index 1d546c4ec1..ed1f931547 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -69,6 +69,11 @@ detect built-in libxml support, instead of testing for that indirectly, e.g., by checking that functions like 'libxml-parse-html-region' return nil. ++++ +** New function 'fill-polish-nobreak-p', to be used in 'fill-nobreak-predicate'. +It blocks line breaking after a one-letter word, also in the case when +this word is preceded by a non-space, but non-alphanumeric character. + * Editing Changes in Emacs 27.1 diff --git a/lisp/textmodes/fill.el b/lisp/textmodes/fill.el index a46f0b2a4c..6d37be870b 100644 --- a/lisp/textmodes/fill.el +++ b/lisp/textmodes/fill.el @@ -339,6 +339,18 @@ fill-french-nobreak-p (and (memq (preceding-char) '(?\t ?\s)) (eq (char-syntax (following-char)) ?w))))))) +(defun fill-polish-nobreak-p () + "Return nil if Polish style allows breaking the line at point. +This function may be used in the `fill-nobreak-predicate' hook. +It is almost the same as `fill-single-char-nobreak-p', with the +exception that it does not require the one-letter word to be +preceded by a space. This blocks line-breaking in cases like +\"(a jednak)\"." + (save-excursion + (skip-chars-backward " \t") + (backward-char 2) + (looking-at "[^[:alpha:]]\\cl"))) + (defun fill-single-char-nobreak-p () "Return non-nil if a one-letter word is before point. This function is suitable for adding to the hook `fill-nobreak-predicate', diff --git a/test/lisp/textmodes/fill-tests.el b/test/lisp/textmodes/fill-tests.el new file mode 100644 index 0000000000..03323090f9 --- /dev/null +++ b/test/lisp/textmodes/fill-tests.el @@ -0,0 +1,50 @@ +;;; fill-test.el --- ERT tests for fill.el -*- lexical-binding: t -*- + +;; Copyright (C) 2017 Free Software Foundation, Inc. + +;; Author: Marcin Borkowski +;; Keywords: text, wp + +;; This file is part of GNU Emacs. + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; This package defines tests for the filling feature, specifically +;; the `fill-polish-nobreak-p' function. + +;;; Code: + +(require 'ert) + +(ert-deftest fill-test-no-fill-polish-nobreak-p nil + "Tests of the `fill-polish-nobreak-p' function." + (with-temp-buffer + (insert "Abc d efg (h ijk).") + (setq fill-column 8) + (setq-local fill-nobreak-predicate '()) + (fill-paragraph) + (should (string= (buffer-string) "Abc d\nefg (h\nijk)."))) + (with-temp-buffer + (insert "Abc d efg (h ijk).") + (setq fill-column 8) + (setq-local fill-nobreak-predicate '(fill-polish-nobreak-p)) + (fill-paragraph) + (should (string= (buffer-string) "Abc\nd efg\n(h ijk).")))) + + +(provide 'fill-tests) + +;;; fill-tests.el ends here -- 2.15.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 15 08:07:30 2018 Received: (at 20871) by debbugs.gnu.org; 15 Jan 2018 13:07:30 +0000 Received: from localhost ([127.0.0.1]:56752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb4U6-0004ED-8L for submit@debbugs.gnu.org; Mon, 15 Jan 2018 08:07:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb4U4-0004E1-Ey for 20871@debbugs.gnu.org; Mon, 15 Jan 2018 08:07:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eb4Tv-00049k-9t for 20871@debbugs.gnu.org; Mon, 15 Jan 2018 08:07:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eb4Tv-00049d-6s; Mon, 15 Jan 2018 08:07:19 -0500 Received: from [176.228.60.248] (port=4058 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eb4Tu-00043R-LX; Mon, 15 Jan 2018 08:07:19 -0500 Date: Mon, 15 Jan 2018 15:07:06 +0200 Message-Id: <834lnnz2x1.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <871siradub.fsf@mbork.pl> (message from Marcin Borkowski on Mon, 15 Jan 2018 06:30:20 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87vb33h6ux.fsf@mbork.pl> <83a8kfzff7.fsf@gnu.org> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> <83h8rp1yzj.fsf@gnu.org> <874lnnaen0.fsf@mbork.pl> <871siradub.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Mon, 15 Jan 2018 06:30:20 +0100 > > I attach the patch (which is made by squashing both the commits I made). Thanks, this LGTM. Please push to master. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 04:34:55 2018 Received: (at 20871) by debbugs.gnu.org; 24 Jan 2018 09:34:55 +0000 Received: from localhost ([127.0.0.1]:40371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeHSJ-0003IU-35 for submit@debbugs.gnu.org; Wed, 24 Jan 2018 04:34:55 -0500 Received: from mail.mojserwer.eu ([195.110.48.8]:46992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeHSF-0003IJ-1U for 20871@debbugs.gnu.org; Wed, 24 Jan 2018 04:34:51 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id 3BBE2E6C40; Wed, 24 Jan 2018 10:34:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bvcSjM23LCiu; Wed, 24 Jan 2018 10:34:41 +0100 (CET) Received: from localhost (unknown [150.254.127.43]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 2EA12E68C2; Wed, 24 Jan 2018 10:34:41 +0100 (CET) References: <87y4jchwog.fsf@mbork.pl> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> <83h8rp1yzj.fsf@gnu.org> <874lnnaen0.fsf@mbork.pl> <871siradub.fsf@mbork.pl> <834lnnz2x1.fsf@gnu.org> User-agent: mu4e 0.9.19; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <834lnnz2x1.fsf@gnu.org> Date: Wed, 24 Jan 2018 10:34:38 +0100 Message-ID: <87mv13ppld.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2018-01-15, at 14:07, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: 20871@debbugs.gnu.org >> Date: Mon, 15 Jan 2018 06:30:20 +0100 >> >> I attach the patch (which is made by squashing both the commits I made). > > Thanks, this LGTM. Please push to master. Done, thanks. (I'm afraid that I messed up the commit message, which included another branch name I used locally - sorry for that. Also, after the merge it occured to me that I could have used rebase instead. Would it be a better idea in the future?) Best, -- Marcin Borkowski From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 14:16:26 2018 Received: (at 20871) by debbugs.gnu.org; 24 Jan 2018 19:16:26 +0000 Received: from localhost ([127.0.0.1]:41284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeQX3-0006S4-H9 for submit@debbugs.gnu.org; Wed, 24 Jan 2018 14:16:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeQX2-0006Rt-FO for 20871@debbugs.gnu.org; Wed, 24 Jan 2018 14:16:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeQWs-0002vb-Da for 20871@debbugs.gnu.org; Wed, 24 Jan 2018 14:16:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeQWs-0002vT-AZ; Wed, 24 Jan 2018 14:16:14 -0500 Received: from [176.228.60.248] (port=3027 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eeQWq-0000iy-Tx; Wed, 24 Jan 2018 14:16:14 -0500 Date: Wed, 24 Jan 2018 21:16:03 +0200 Message-Id: <83shavm5jg.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <87mv13ppld.fsf@mbork.pl> (message from Marcin Borkowski on Wed, 24 Jan 2018 10:34:38 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <87y4jchwog.fsf@mbork.pl> <87shy4vc9x.fsf@mbork.pl> <838tzvpcjb.fsf@gnu.org> <87vb2zth8r.fsf@mbork.pl> <837fffp8zt.fsf@gnu.org> <877fff3v7n.fsf@mbork.pl> <83mvobni94.fsf@gnu.org> <874maj3plo.fsf@mbork.pl> <83bn4qor96.fsf@gnu.org> <87zi6u7jm3.fsf@mbork.pl> <831sk4unix.fsf@gnu.org> <87vahf7vnx.fsf@mbork.pl> <87r2rr7xii.fsf@mbork.pl> <83a7yepuby.fsf@gnu.org> <87o9mchc6k.fsf@mbork.pl> <83o9ly16zg.fsf@gnu.org> <87shb9d9yt.fsf@mbork.pl> <83h8rp1yzj.fsf@gnu.org> <874lnnaen0.fsf@mbork.pl> <871siradub.fsf@mbork.pl> <834lnnz2x1.fsf@gnu.org> <87mv13ppld.fsf@mbork.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Marcin Borkowski > Cc: 20871@debbugs.gnu.org > Date: Wed, 24 Jan 2018 10:34:38 +0100 > > Also, after the merge it occured to me that I could have used rebase > instead. Would it be a better idea in the future?) No, we don't recommend using rebase between public branches, especially if there were merges from master to the feature branch. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 24 14:18:10 2018 Received: (at control) by debbugs.gnu.org; 24 Jan 2018 19:18:10 +0000 Received: from localhost ([127.0.0.1]:41288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeQYk-0006Uo-LQ for submit@debbugs.gnu.org; Wed, 24 Jan 2018 14:18:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eeQYj-0006Ua-BM for control@debbugs.gnu.org; Wed, 24 Jan 2018 14:18:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeQYd-000431-LJ for control@debbugs.gnu.org; Wed, 24 Jan 2018 14:18:04 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeQYd-00042v-Hp for control@debbugs.gnu.org; Wed, 24 Jan 2018 14:18:03 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eeQYc-0000sv-Pi for control@debbugs.gnu.org; Wed, 24 Jan 2018 14:18:03 -0500 Subject: control message for bug 20871 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 24 Jan 2018 14:18:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) # 96de050 close 20871 27.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 02 04:18:49 2018 Received: (at 20871) by debbugs.gnu.org; 2 Feb 2018 09:18:49 +0000 Received: from localhost ([127.0.0.1]:53344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehXUf-0003Hr-41 for submit@debbugs.gnu.org; Fri, 02 Feb 2018 04:18:49 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:36831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehXUd-0003Hb-EH for 20871@debbugs.gnu.org; Fri, 02 Feb 2018 04:18:47 -0500 Received: by mail-wm0-f50.google.com with SMTP id f3so10890505wmc.1 for <20871@debbugs.gnu.org>; Fri, 02 Feb 2018 01:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:organization:references:face :openpgp:date:message-id:mime-version:content-transfer-encoding; bh=4AokbJYTKaUjaDXmg2fHlPvtHyZwR/4okVqwWwI1c3c=; b=IwFBYsctH/6cmCyC2/dwSKRHIKdoR6Q3pMkiAzsgp5qRVnAJxuz/IgLpVFzC9wsKnO Oq5NsLizj3bbLfJ+zkoOQb46zq/HtGzGrBMq2jZoGVfQtJ/IZy9ebFz9XvR89ucZiUxL q2OMjNVGbxtGiJBpabRlZNcv8mXysVLm9gRk/z/Bxy33kCeAz9HE7Afl7pOswZB41wxE q6zyAmKocLbYioMI5cmLNz/m8oHitChXzKLUWoDbEXqcCsBO0H6wkKn0EPwBEZLmtfHw Daii798IL9TDl+gYU+0quj4skVYS3/fj/rg1+21aE8CAqGPda1e4U7pCDZqBaHcpmBXw aZww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to :organization:references:face:openpgp:date:message-id:mime-version :content-transfer-encoding; bh=4AokbJYTKaUjaDXmg2fHlPvtHyZwR/4okVqwWwI1c3c=; b=NLI8owmYyagrZorQ90jiSt3sXm2muasu2WT6jbBbnQr1ZIsRQpAZPEk23suC5Dk9Iz mdQWEmm8Ud3CL5MMesuOoWJkWqnCZ0k70a9sVWfWc/vUKjFM6ZUb9HQwd3vHxcuXngUk 1utKUiNBH6Y07Y5fHhkOB+XbCtSJtRqLe24Gj5/O656yl6URzXy3tyXN9LCMyCLNmDw2 Xx+yvLA/+Ue38KjVYB4ahX5wdcZyxGia8fnhMJvc806Pd18VjCSCY/YOJpnd9aJfK29Q 5kR9Qt5AaUfzUZY7rr5XIT1pQlI33Rq/YE27zAiEztp9U90XO7R3bmyulEDu8bnBdOkv zG0Q== X-Gm-Message-State: AKwxytdDcqHTTmc20rTOE0iA+jLqLrTvt48kZjBlAwgnWYFq1yKsMDhx w9zgsFnCbV+7Zxcy5R4D8zlyyJzSaUA= X-Google-Smtp-Source: AH8x227x5M7Krglwov1Xl21kG6pBFp7qieMx82XSKqiPsX6GP+rawVUEzndvplQR7PqnrydE0ZCh7w== X-Received: by 10.80.213.94 with SMTP id f30mr10964798edj.38.1517563121121; Fri, 02 Feb 2018 01:18:41 -0800 (PST) Received: from mpn-glaptop ([2620:0:105f:315:8b11:dc5e:ed21:14cc]) by smtp.gmail.com with ESMTPSA id r7sm1196631edc.23.2018.02.02.01.18.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Feb 2018 01:18:39 -0800 (PST) From: Michal Nazarewicz To: Eli Zaretskii , Marcin Borkowski Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-Reply-To: <8337qkb7v7.fsf@gnu.org> Organization: https://mina86.com/ References: <87y4jchwog.fsf@mbork.pl> <87wpywhwa8.fsf@mbork.pl> <87shyku4jt.fsf@mbork.pl> <8337qkb7v7.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWjgIPUupJ7V0jLrom4gmjPs42bY0MdFRLHgE5UPDCbfGm9mH6qmkAJAAACNUlEQVQ4y23SMW/aQBQHcKtb2Zx0abZeIxuTCSELJVmiinboRpGHJktloROQzUQcB2vUXFe35XBYUicRAiYUVSjfru/d+QwlnDz5p/97z+dnVcw5WVQ2zxpcdrQTTiIin3bB6lcaTnaBO5c8eoJG2yBl5El+Ob3fglMW3RUIkQ9xxQ8UBEFQafiVZ/5wZqWExM+LvwEegAY856xZO7MgQkq3jxpO56GXxO5VDQAjpVmWqPLYoSGvIahIuvAVHLeEEDd9DRYAkUcKzscAUgCQ0hwSKBOExuh7kvQQUskY4yjsHqeaCfFjLK6x1AzeeyiRD/C1JW5aGqw5IS5mZre+FVz0RVtoUGPJmBCP/4QPJGKUA1oEMJwAHIv+JljYZYCJi1FRQS2DaUw6sgsQTMfb0Fz9RvjyP3iR01x9RGj0N6HgcefS819CSjidDwIFPSFEDgRg1tUw2oBXAB33T2DV63XbM6AqhZzysm3ZcKZrKBAn5O7Q1rAqGoBKNGRsmUG1n0NKaJtd2RnscTWvnom6fGngDaNrCNl728A+c2gLQP8PFpkEjNWjlGqQfPEhWRqoInSyi2p+drsGDjhAeAeSQI8kfjSwbwCn8gblvIftInzT30HdQT2HlU4gwCbLSQ7VFqVEA0RCtjTwtnjdLlkasNjQwF7x02F2iQSL8XIGB8VQ71WBKHHf5XCIgLUUtIcGSBPhdZIQorpEBrxsqT3GYgRpmicIqrsEgSZm3FG+iJbHYid0/wGj+iTGCXRsqQAAAABJRU5ErkJggg== OpenPGP: id=AC1F5F5CD41888F8CC8458582060401250751FF4; url=https://mina86.com/mina86.pub X-Hashcash: 1:20:180202:20871@debbugs.gnu.org::8+57/yWRgQrnVxTP:000000000000000000000000000000000000000005hO X-Hashcash: 1:20:180202:mbork@mbork.pl::kKUSblz7oIJelKjH:0005ZZZ X-Hashcash: 1:20:180202:eliz@gnu.org::g7pAReooNIgACr2Q:000001CUu Date: Fri, 02 Feb 2018 10:18:37 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 20871 Cc: 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On Sun, Apr 17 2016, Eli Zaretskii wrote: > Could you please elaborate on the bug itself? > > See, the function in question, fill-single-char-nobreak-p, is > documented as a possible value to use in the fill hook, for a very > specific purpose. If you are saying that it doesn't fulfill that > purpose well enough, please show a use case where it fails to do that. > At least the situation you described, with " (a", doesn't seem to fit > the use cases which this function is supposed to cover, since the > parenthesis makes a 2-character sequence, whereas > fill-single-char-nobreak-p aims to support isolated one-character > words. As person who wrote =E2=80=98fill-single-char-nobreak-p=E2=80=99 I can say = that its intention was to work for Polish and Czech typography. In other words, what Marcin reported is a genuine defect in the function. In particular, function=E2=80=99s documentation mentions *one-letter* seque= nces, not *one-character* sequences: Return non-nil if a one-letter word is before point. (Admittedly, the name of the function is misleading). As such, I would suggest applying the fix to =E2=80=98fill-single-char-nobreak-p=E2=80=99 rather than introducing a new = function. (And perhaps adding an alias and deprecating the old name if misleading name is too big of a problem). As another point of context, ideally, =E2=80=98tildify-mode=E2=80=99 and =E2=80=98fill-single-char-nobreak-p=E2=80=99 would use the exact same logic= since they both work to address the same underlying typographic conventions. --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From unknown Sun Jun 22 03:58:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Mar 2018 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 02:48:28 2019 Received: (at control) by debbugs.gnu.org; 17 Aug 2019 06:48:28 +0000 Received: from localhost ([127.0.0.1]:55289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hysVn-0004dY-Re for submit@debbugs.gnu.org; Sat, 17 Aug 2019 02:48:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hysVm-0004dJ-48 for control@debbugs.gnu.org; Sat, 17 Aug 2019 02:48:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hysVf-0004KR-2F for control@debbugs.gnu.org; Sat, 17 Aug 2019 02:48:20 -0400 Received: from [176.228.60.248] (port=2236 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hysVc-0005HW-OG for control@debbugs.gnu.org; Sat, 17 Aug 2019 02:48:17 -0400 Date: Sat, 17 Aug 2019 09:48:14 +0300 Message-Id: <83o90onv81.fsf@gnu.org> From: Eli Zaretskii To: control@debbugs.gnu.org In-reply-to: (message from =?utf-8?Q?Micha=C5=82?= Nazarewicz on Fri, 16 Aug 2019 16:30:55 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) unarchive 20871 thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 02:57:31 2019 Received: (at 20871) by debbugs.gnu.org; 17 Aug 2019 06:57:31 +0000 Received: from localhost ([127.0.0.1]:55293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyseY-0004pm-Pr for submit@debbugs.gnu.org; Sat, 17 Aug 2019 02:57:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyseW-0004pY-GG for 20871@debbugs.gnu.org; Sat, 17 Aug 2019 02:57:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hyseQ-0001xo-9X; Sat, 17 Aug 2019 02:57:22 -0400 Received: from [176.228.60.248] (port=2780 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hyseL-0006w1-QW; Sat, 17 Aug 2019 02:57:18 -0400 Date: Sat, 17 Aug 2019 09:57:13 +0300 Message-Id: <83mug8nut2.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Micha=C5=82?= Nazarewicz In-reply-to: (message from =?utf-8?Q?Micha=C5=82?= Nazarewicz on Fri, 16 Aug 2019 16:30:55 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20871 Cc: mattiase@acm.org, mbork@mbork.pl, 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michał Nazarewicz > Date: Fri, 16 Aug 2019 16:30:55 +0100 > Cc: Mattias Engdegård , mbork@mbork.pl, > 20871@debbugs.gnu.org > > On Fri, 16 Aug 2019 at 13:53, Eli Zaretskii wrote: > > Michal says that the original fill-single-char-nobreak-p function > > was supposed to handle the Polish case as well. If that's true, > > perhaps we should deprecate fill-polish-nobreak-p. > > I’m in favour of deprecating one of the functions, yes. OK, but see below. > > However, I do wonder how can a general function handle these cases, > > since in general there's no problem in breaking a line after > > single-letter words. > > We could try and look at `tildify-mode’ for inspiration and especially > ‘tildify-space-pattern’¹ which is: > > "[,:;(][ \t]*[a]\\|\\<[AIKOSUVWZikosuvwz]" My problem is conceptual rather than practical. Since in , e.g., English it is okay to break a line after single-letter words, whereas in Polish it is not, I wonder how can we have a single function satisfy both requirements. We would need some option, and then we would need to decide what is the trigger for changing the value of that option -- it could be the user, or the language environment, or maybe something else. tildify.el explicitly says that its defaults are for a specific language, so I don't think it solves the problem that bothers me, as described above. This is why I originally suggested a separate function -- having that is equivalent to having an option which determines a behavior that depends on the language. I'm also okay with extending tildify.el to support more than just Czech rules, but that's a separate issue. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 10:17:27 2019 Received: (at 20871) by debbugs.gnu.org; 17 Aug 2019 14:17:27 +0000 Received: from localhost ([127.0.0.1]:56679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyzWI-0004wj-SR for submit@debbugs.gnu.org; Sat, 17 Aug 2019 10:17:27 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:41596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyzWG-0004wX-R8 for 20871@debbugs.gnu.org; Sat, 17 Aug 2019 10:17:25 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id C64FBE68EB; Sat, 17 Aug 2019 16:17:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RtHVcTjt19a7; Sat, 17 Aug 2019 16:17:14 +0200 (CEST) Received: from localhost (apn-31-0-23-12.dynamic.gprs.plus.pl [31.0.23.12]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 6DE86E650F; Sat, 17 Aug 2019 16:17:14 +0200 (CEST) References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> <83mug8nut2.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83mug8nut2.fsf@gnu.org> Date: Sat, 17 Aug 2019 16:17:04 +0200 Message-ID: <878srrop0f.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: mattiase@acm.org, 20871@debbugs.gnu.org, =?utf-8?Q?Micha=C5=82?= Nazarewicz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) AFAIR, I was the submitter of this bug report a few years ago. Thanks for working on this. On 2019-08-17, at 08:57, Eli Zaretskii wrote: > My problem is conceptual rather than practical. Since in , e.g., > English it is okay to break a line after single-letter words, whereas > in Polish it is not [...] FWIW, I remember some English native speaker (from the UK, I guess) saying that he likes the rule about not breaking the line after e.g. "a" and would like English to have a similar one. Best, -- Marcin Borkowski http://mbork.pl From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 11:04:50 2019 Received: (at 20871) by debbugs.gnu.org; 17 Aug 2019 15:04:50 +0000 Received: from localhost ([127.0.0.1]:56727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz0GA-000672-Jh for submit@debbugs.gnu.org; Sat, 17 Aug 2019 11:04:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz0G8-00066m-NA for 20871@debbugs.gnu.org; Sat, 17 Aug 2019 11:04:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hz0G2-00043f-1S; Sat, 17 Aug 2019 11:04:42 -0400 Received: from [176.228.60.248] (port=1734 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hz0G0-000517-R2; Sat, 17 Aug 2019 11:04:41 -0400 Date: Sat, 17 Aug 2019 18:04:38 +0300 Message-Id: <83zhk7n88p.fsf@gnu.org> From: Eli Zaretskii To: Marcin Borkowski In-reply-to: <878srrop0f.fsf@mbork.pl> (message from Marcin Borkowski on Sat, 17 Aug 2019 16:17:04 +0200) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> <83mug8nut2.fsf@gnu.org> <878srrop0f.fsf@mbork.pl> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20871 Cc: mattiase@acm.org, 20871@debbugs.gnu.org, mina86@mina86.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Marcin Borkowski > Cc: Michał Nazarewicz , > mattiase@acm.org, 20871@debbugs.gnu.org > Date: Sat, 17 Aug 2019 16:17:04 +0200 > > > My problem is conceptual rather than practical. Since in , e.g., > > English it is okay to break a line after single-letter words, whereas > > in Polish it is not [...] > > FWIW, I remember some English native speaker (from the UK, I guess) > saying that he likes the rule about not breaking the line after e.g. "a" > and would like English to have a similar one. I could understand that, but someone's personal preferences are not necessarily good for the rest of us. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 17 11:58:31 2019 Received: (at 20871) by debbugs.gnu.org; 17 Aug 2019 15:58:31 +0000 Received: from localhost ([127.0.0.1]:56769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz166-0007VA-LC for submit@debbugs.gnu.org; Sat, 17 Aug 2019 11:58:31 -0400 Received: from mail.mojserwer.eu ([195.110.48.8]:42876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hz162-0007Uv-FU for 20871@debbugs.gnu.org; Sat, 17 Aug 2019 11:58:29 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.mojserwer.eu (Postfix) with ESMTP id BAE7CE68EB; Sat, 17 Aug 2019 17:58:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.mojserwer.eu Received: from mail.mojserwer.eu ([127.0.0.1]) by localhost (mail.mojserwer.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id byBmp2NYXEBR; Sat, 17 Aug 2019 17:58:19 +0200 (CEST) Received: from localhost (apn-31-0-23-12.dynamic.gprs.plus.pl [31.0.23.12]) by mail.mojserwer.eu (Postfix) with ESMTPSA id 4A87AE650F; Sat, 17 Aug 2019 17:58:19 +0200 (CEST) References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> <83mug8nut2.fsf@gnu.org> <878srrop0f.fsf@mbork.pl> <83zhk7n88p.fsf@gnu.org> User-agent: mu4e 1.1.0; emacs 27.0.50 From: Marcin Borkowski To: Eli Zaretskii Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren In-reply-to: <83zhk7n88p.fsf@gnu.org> Date: Sat, 17 Aug 2019 17:58:18 +0200 Message-ID: <871rxjokbp.fsf@mbork.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20871 Cc: mattiase@acm.org, 20871@debbugs.gnu.org, mina86@mina86.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-08-17, at 17:04, Eli Zaretskii wrote: >> From: Marcin Borkowski >> Cc: Micha=C5=82 Nazarewicz , >> mattiase@acm.org, 20871@debbugs.gnu.org >> Date: Sat, 17 Aug 2019 16:17:04 +0200 >> >> > My problem is conceptual rather than practical. Since in , e.g., >> > English it is okay to break a line after single-letter words, whereas >> > in Polish it is not [...] >> >> FWIW, I remember some English native speaker (from the UK, I guess) >> saying that he likes the rule about not breaking the line after e.g. "a" >> and would like English to have a similar one. > > I could understand that, but someone's personal preferences are not > necessarily good for the rest of us. Agreed, this is not enough to actually implement anything, but I think it's interesting to know. (Actually, I never break a line after an "a" when I write in English, and I think this is consistent with the general rule that linebreaks should not come between things constituing some kind of one entity - but this is just me.) Best, -- Marcin Borkowski http://mbork.pl From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 10:08:15 2019 Received: (at 20871) by debbugs.gnu.org; 19 Aug 2019 14:08:15 +0000 Received: from localhost ([127.0.0.1]:60309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hziKV-0008HE-8Y for submit@debbugs.gnu.org; Mon, 19 Aug 2019 10:08:15 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:55479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hziKT-0008H0-1X for 20871@debbugs.gnu.org; Mon, 19 Aug 2019 10:08:13 -0400 Received: by mail-wm1-f52.google.com with SMTP id f72so1752247wmf.5 for <20871@debbugs.gnu.org>; Mon, 19 Aug 2019 07:08:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5ohUhnTddAcdVnGV6QxXxdN+unihNJYkYNhtPHRptKw=; b=C72TmLEf6tCzgH/y3iYxG7X5lHyKyIAiZI/z7Cp7v6bawI7tp7lLL/MJrgVMZ03azt k2DM0ODK+pZUTN67+3+Zt0mxLj8lsPTv1v6GsDsPp64GTnozxOOWP8/N2Z+ub3+D28q4 95WY50gUIypgxGAwH6Fukh0pq3RBdW+8aIgOFM4GrPH8zCWm+dyQlnV6fCBGchsAxeDp bbI7IEafKTtqQIqkTpU1DxQ++orBvfqlZsn1xce3CNUQWbpgOiBWiAPEp2H+Ge0oksuj cZBfKaVDhcxfvFg7e/JRwqiNdcPaaT3NxRlod266swn1vZnnFSOsYkCnyshFvHsrx38K hw4g== X-Gm-Message-State: APjAAAXCkTrP9JYhBDwT1l7ad4nprHZANtOZ+eqoDlxyd/7J87o8b9Br XVxXxk+U18tADnZJdRnSDVzHMP+Zmp5CBVvHb1o= X-Google-Smtp-Source: APXvYqxBWOqdmcCGRfQgCdepNUG2tpxzw07MP+aG3UD8IKmAMvv1Zk77kmLJPecKZ6OdxapryRcIbxET8I31l2qYSBQ= X-Received: by 2002:a05:600c:2102:: with SMTP id u2mr21367640wml.105.1566223687285; Mon, 19 Aug 2019 07:08:07 -0700 (PDT) MIME-Version: 1.0 References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> <83mug8nut2.fsf@gnu.org> In-Reply-To: <83mug8nut2.fsf@gnu.org> From: =?UTF-8?Q?Micha=C5=82_Nazarewicz?= Date: Mon, 19 Aug 2019 15:07:56 +0100 Message-ID: Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 20871 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , mbork@mbork.pl, 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sat, 17 Aug 2019 at 07:57, Eli Zaretskii wrote: > My problem is conceptual rather than practical. Since in , e.g., > English it is okay to break a line after single-letter words, whereas > in Polish it is not, I wonder how can we have a single function > satisfy both requirements. We would need some option, and then we > would need to decide what is the trigger for changing the value of > that option -- it could be the user, or the language environment, or > maybe something else. This sounds related to what we=E2=80=99ve discussed when I was working on t= he Unicode casing rules. There also some rules need to be enabled only if the text is in a certain language. Having buffer-local variable or a text-property defining language of the buffer sounds to me like the only possible solution if we want this fully automatic. > tildify.el explicitly says that its defaults are for a specific > language, so I don't think it solves the problem that bothers me, as > described above. This is why I originally suggested a separate > function -- having that is equivalent to having an option which > determines a behavior that depends on the language. To be honest, I don=E2=80=99t understand the issue. If having separate functions is equivalent to having an option than users already have an option: either add the function to =E2=80=98fill-nobreak-predicate=E2=80=99= or not. As discussed previously, =E2=80=98fill-single-char-nobreak-p=E2=80=99 and =E2=80=98fill-polish-nobreak-p=E2=80=99 and serve pretty much the same purp= ose. When I wrote the former I had Polish typography in mind and obviously the latter is meant to handle the same case. As such, having those two functions don=E2=80=99t provide much option to the user. > I'm also okay with extending tildify.el to support more than just > Czech rules, but that's a separate issue. The differences between Czech and Polish can largely be ignored. The regex in tildify.el will work for Polish just fine. The character group simply lists all existing one-letter Czech words which is superset of one-letter Polish words. At the same time, those two languages are, to my knowledge, the only which observe this typography rule, so there=E2=80=99s no need to add suppo= rt for more. =E2=80=98fill-single-char-nobreak-p=E2=80=99 matches any single-letter word= s just for the sake of simplicity plus it then works with other languages, which may have different one-letter words, if someone wishes to use it with them. --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 11:01:25 2019 Received: (at 20871) by debbugs.gnu.org; 19 Aug 2019 15:01:25 +0000 Received: from localhost ([127.0.0.1]:60328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzj9w-00016Y-Lt for submit@debbugs.gnu.org; Mon, 19 Aug 2019 11:01:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzj9t-00016H-Dm for 20871@debbugs.gnu.org; Mon, 19 Aug 2019 11:01:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzj9m-000779-2D; Mon, 19 Aug 2019 11:01:14 -0400 Received: from [176.228.60.248] (port=2680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hzj9l-0005jc-B8; Mon, 19 Aug 2019 11:01:13 -0400 Date: Mon, 19 Aug 2019 18:01:14 +0300 Message-Id: <83y2zpkxmt.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Micha=C5=82?= Nazarewicz In-reply-to: (message from =?utf-8?Q?Micha=C5=82?= Nazarewicz on Mon, 19 Aug 2019 15:07:56 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> <83mug8nut2.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20871 Cc: mattiase@acm.org, mbork@mbork.pl, 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michał Nazarewicz > Date: Mon, 19 Aug 2019 15:07:56 +0100 > Cc: Mattias Engdegård , mbork@mbork.pl, > 20871@debbugs.gnu.org > > > tildify.el explicitly says that its defaults are for a specific > > language, so I don't think it solves the problem that bothers me, as > > described above. This is why I originally suggested a separate > > function -- having that is equivalent to having an option which > > determines a behavior that depends on the language. > > To be honest, I don’t understand the issue. If having separate > functions is equivalent to having an option than users already have an > option: either add the function to ‘fill-nobreak-predicate’ or not. Yes, of course. I wrote the above in response to your suggestion to leave just one function. > As discussed previously, ‘fill-single-char-nobreak-p’ and > ‘fill-polish-nobreak-p’ and serve pretty much the same purpose. When > I wrote the former I had Polish typography in mind and obviously the > latter is meant to handle the same case. As such, having those two > functions don’t provide much option to the user. If both functions attempt to produce the same behavior, then yes, we need only one. But then wouldn't we need a second one, to produce the behavior expected, say, in US English? > > > I'm also okay with extending tildify.el to support more than just > > Czech rules, but that's a separate issue. > > The differences between Czech and Polish can largely be ignored. I didn't mean Polish, I meant in general languages where the conventions are different. Surely, there are some, and tildify explicitly assumes that. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 11:36:34 2019 Received: (at 20871) by debbugs.gnu.org; 19 Aug 2019 15:36:34 +0000 Received: from localhost ([127.0.0.1]:60445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzjhy-00021X-Dg for submit@debbugs.gnu.org; Mon, 19 Aug 2019 11:36:34 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:46738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzjhw-00021E-OW for 20871@debbugs.gnu.org; Mon, 19 Aug 2019 11:36:33 -0400 Received: by mail-wr1-f42.google.com with SMTP id z1so9175858wru.13 for <20871@debbugs.gnu.org>; Mon, 19 Aug 2019 08:36:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6kN50EJ3AET88Uj0VYm7IGtDjYhOBDGhG9qTb3M0cwI=; b=neyfn0mmw2LZdT4LOAqFBXOP/rFWvYiJUyISHXyf20+y1XuN7aB6SoMk4JW9vk3gCb rmbzAJht+cqmbcAwbNfJ1Whw9e8gWFB4lY+x+thKpPQrz3uciV6Im6EVajBZvhXrByH2 O2fU2219WRrUFQ1LOPRffFM9gEKMnf74eTcAHiAT++Ff4/Qutjcb8+HQaVCqbzIZZujz CWfpE/UsW2uFCkrouPEXNENUw5zlxbF/3pTwuuIUyXjfPmDsJkV46BkEgKg1cTeJrSkY tcqi4CNVut76q74lruwx8KLxs8+vjz7ilvsC4On0BGQGHiiwzk6P7zRq7xGakh4UI8Y4 jWjA== X-Gm-Message-State: APjAAAXSOpvgALz1OWc9zkJZ3wrLMcAy3NQkxDHucH9ZobsVWM5sD54z GG0uKtVSodUFnEeYfpKpYL075sKfYDHcu1JMHqDYH29R X-Google-Smtp-Source: APXvYqw0p2zoH93DUOsqVXmhNNaoWa5BEXo1FjbhcPwPKgFyYA+gyS5AUAr+HF1MWIJ2gLozcB93q2YwdtHU6u0Ze5A= X-Received: by 2002:a05:6000:104c:: with SMTP id c12mr25211377wrx.328.1566228987066; Mon, 19 Aug 2019 08:36:27 -0700 (PDT) MIME-Version: 1.0 References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> <83mug8nut2.fsf@gnu.org> <83y2zpkxmt.fsf@gnu.org> In-Reply-To: <83y2zpkxmt.fsf@gnu.org> From: =?UTF-8?Q?Micha=C5=82_Nazarewicz?= Date: Mon, 19 Aug 2019 16:36:15 +0100 Message-ID: Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 20871 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , mbork@mbork.pl, 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) > > From: Micha=C5=82 Nazarewicz > > Date: Mon, 19 Aug 2019 15:07:56 +0100 > > As discussed previously, =E2=80=98fill-single-char-nobreak-p=E2=80=99 a= nd > > =E2=80=98fill-polish-nobreak-p=E2=80=99 and serve pretty much the same = purpose. When > > I wrote the former I had Polish typography in mind and obviously the > > latter is meant to handle the same case. As such, having those two > > functions don=E2=80=99t provide much option to the user. On Mon, 19 Aug 2019 at 16:01, Eli Zaretskii wrote: > If both functions attempt to produce the same behavior, then yes, we > need only one. But then wouldn't we need a second one, to produce the > behavior expected, say, in US English? The expected behaviour for US English is achieved by not using the function at all. Unless you mean that someone want to follow the rule in English even though it=E2=80=99s not an established thing in that language. In that cas= e they can just use the existing functions and they will work for English. In that case I could see a potential reason to have multiple functions: - =E2=80=98fill-polish-nobreak-p=E2=80=99 =E2=80=93 don=E2=80=99t break aft= er a, e, i, o, u, w or z; - =E2=80=98fill-czech-nobreak-p=E2=80=99 =E2=80=93 don=E2=80=99t break afte= r a, i, k, o, s, u, v or z; and =E2=80=93 =E2=80=98fill-single-char-nobreak-p=E2=80=99 =E2=80=93 don=E2=80= =99t break after any single letter word. This can also be achieved by a single function and a variable listing all the characters. Note also that there is a different rule which applies to all languages which deals with breaking line between number and a unit, e.g. =E2=80=9860 s=E2=80=99, =E2=80=98100 m=E2=80=99 etc. I=E2=80= =99m not sure how this fits with current discussion since neither tildify nor the *-nobreak-p functions deal with that case. > > > I'm also okay with extending tildify.el to support more than just > > > Czech rules, but that's a separate issue. > > > > The differences between Czech and Polish can largely be ignored. > > I didn't mean Polish, I meant in general languages where the > conventions are different. Surely, there are some, and tildify > explicitly assumes that. I don=E2=80=99t think there are. It is possible that I=E2=80=99m incorrect= but all the materials I=E2=80=99ve found talked about Polish and Czech only. Polis= h Wikipedia entry=C2=B9 explicitly states that this rule is only for those tw= o languages. =C2=B9 https://pl.wikipedia.org/wiki/Sierotka_(typografia) (note that =E2=80=98sierotka=E2=80=99 literally translates to =E2=80=98orphan=E2=80= =99 but is a different thing than =E2=80=98orphan=E2=80=99 in English typography). -- Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 19 12:16:32 2019 Received: (at 20871) by debbugs.gnu.org; 19 Aug 2019 16:16:32 +0000 Received: from localhost ([127.0.0.1]:60460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzkKd-00030p-Nv for submit@debbugs.gnu.org; Mon, 19 Aug 2019 12:16:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzkKa-00030b-F1 for 20871@debbugs.gnu.org; Mon, 19 Aug 2019 12:16:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hzkKU-0005fW-UA; Mon, 19 Aug 2019 12:16:22 -0400 Received: from [176.228.60.248] (port=3290 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hzkKT-0004me-EE; Mon, 19 Aug 2019 12:16:21 -0400 Date: Mon, 19 Aug 2019 19:16:22 +0300 Message-Id: <83r25hku5l.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Micha=C5=82?= Nazarewicz In-reply-to: (message from =?utf-8?Q?Micha=C5=82?= Nazarewicz on Mon, 19 Aug 2019 16:36:15 +0100) Subject: Re: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren References: <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org> <8336i1p8zd.fsf@gnu.org> <83mug8nut2.fsf@gnu.org> <83y2zpkxmt.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20871 Cc: mattiase@acm.org, mbork@mbork.pl, 20871@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michał Nazarewicz > Date: Mon, 19 Aug 2019 16:36:15 +0100 > Cc: Mattias Engdegård , mbork@mbork.pl, > 20871@debbugs.gnu.org > > > If both functions attempt to produce the same behavior, then yes, we > > need only one. But then wouldn't we need a second one, to produce the > > behavior expected, say, in US English? > > The expected behaviour for US English is achieved by not using the > function at all. If that's true (and I'm not an expert to say it is), then all we need is a suitable change to the doc string of fill-nobreak-predicate, since currently it says nothing about what should be done for English. > In that case I could see a potential reason to have multiple > functions: > - ‘fill-polish-nobreak-p’ – don’t break after a, e, i, o, u, w or z; > - ‘fill-czech-nobreak-p’ – don’t break after a, i, k, o, s, u, v or z; > and > – ‘fill-single-char-nobreak-p’ – don’t break after any single letter > word. Don't forget fill-french-nobreak-p. From unknown Sun Jun 22 03:58:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Sep 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator