From unknown Sun Jun 22 04:30:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20796: [PATCH] Document behavior of sed -i - Resent-From: Stanislav Brabec Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Fri, 12 Jun 2015 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20796 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: 20796@debbugs.gnu.org X-Debbugs-Original-To: bug-sed@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.143412318416804 (code B ref -1); Fri, 12 Jun 2015 15:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jun 2015 15:33:04 +0000 Received: from localhost ([127.0.0.1]:51968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Qx6-0004My-Ac for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:33:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57296) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Qx4-0004MS-Ev for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:33:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Qwy-0005Ym-Et for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:32:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Qwy-0005Yh-Cg for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:32:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Qwx-0004AG-GT for bug-sed@gnu.org; Fri, 12 Jun 2015 11:32:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Qwt-0005Y5-FY for bug-sed@gnu.org; Fri, 12 Jun 2015 11:32:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54114 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Qwt-0005Xp-9N for bug-sed@gnu.org; Fri, 12 Jun 2015 11:32:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AB920AC27 for ; Fri, 12 Jun 2015 15:32:50 +0000 (UTC) Message-ID: <557AFBA2.2080603@suse.com> Date: Fri, 12 Jun 2015 17:32:50 +0200 From: Stanislav Brabec Organization: SUSE Linux, s. r. o. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) "sed -i -" does not fail, but it also does not do what one would expect. Document it, as it could have security implications: Example: The sed command below looks broken, but it is executed and succeeds: ln -s /etc/passwd -- - echo root | sed -i --follow-symlinks s/root/parrot/ - Signed-off-by: Stanislav Brabec --- doc/sed-in.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/sed-in.texi b/doc/sed-in.texi index 0e10cde..c8f1289 100644 --- a/doc/sed-in.texi +++ b/doc/sed-in.texi @@ -180,6 +180,7 @@ sed OPTIONS... [SCRIPT] [INPUTFILE...] @end example =20 If you do not specify @var{INPUTFILE}, or if @var{INPUTFILE} is @file{-}= , +and @option{-i} is not used, @command{sed} filters the contents of the standard input. The @var{scri= pt} is actually the first non-option parameter, which @command{sed} speciall= y considers a script and not an input file if (and only if) none of the --=20 2.4.2 --=20 Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com Lihovarsk=E1 1060/12 tel: +49 911 7405384547 190 00 Praha 9 fax: +420 284 084 001 Czech Republic http://www.suse.cz/ PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76 From unknown Sun Jun 22 04:30:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20796: [PATCH] Document behavior of sed -i - Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Sun, 21 Jun 2015 03:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20796 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: Stanislav Brabec Cc: 20796@debbugs.gnu.org Received: via spool by 20796-submit@debbugs.gnu.org id=B20796.143485570828806 (code B ref 20796); Sun, 21 Jun 2015 03:02:02 +0000 Received: (at 20796) by debbugs.gnu.org; 21 Jun 2015 03:01:48 +0000 Received: from localhost ([127.0.0.1]:53006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6VW0-0007UX-2l for submit@debbugs.gnu.org; Sat, 20 Jun 2015 23:01:48 -0400 Received: from mail-yk0-f171.google.com ([209.85.160.171]:35040) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6VVx-0007UJ-BS for 20796@debbugs.gnu.org; Sat, 20 Jun 2015 23:01:45 -0400 Received: by ykdy1 with SMTP id y1so5387215ykd.2 for <20796@debbugs.gnu.org>; Sat, 20 Jun 2015 20:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=k9gInWuxevlnhFSQuxOCil2bpk87pMDnEbVQ8SNooxg=; b=xhGEWBDs6tUx6+gr7cCGaIYnkTr1NEh4BGHAMMB0zc1ouPUOxxOPnOVOqjYlbwnYDl 1ToER2RwDkLIKEOxLntzd/3T7aWSxMNFpyAEil8SQibPy81DyKq+jJr05itl9+22IScN u/F4JnFN8mZ4GuiMwRNp/6nrnZFjASn0dBEVcOLrK8uV6tYJ3SrOM2MmaPJdNzyvmdAI 7aWa69vrU44dmqZ/SCiqNfy1m6m7GvwcOedEcBLdMFJ7VVgVNyrb1xrgEmfDN0rGqMUf INcTnEXPlU4NY6uA5CzZnWSj3pB8spZkXBeBbo+6n+NyULgj1I8uuuhv9G0CyW637jQi xR7w== X-Received: by 10.13.226.145 with SMTP id l139mr27083420ywe.67.1434855699721; Sat, 20 Jun 2015 20:01:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Sat, 20 Jun 2015 20:01:20 -0700 (PDT) In-Reply-To: <557AFBA2.2080603@suse.com> References: <557AFBA2.2080603@suse.com> From: Jim Meyering Date: Sat, 20 Jun 2015 20:01:20 -0700 X-Google-Sender-Auth: CpRFoJzVnj28we4PwkARy_T9lpM Message-ID: Content-Type: multipart/mixed; boundary=001a114fc2b4499dd00518fe601e X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a114fc2b4499dd00518fe601e Content-Type: text/plain; charset=UTF-8 On Fri, Jun 12, 2015 at 8:32 AM, Stanislav Brabec wrote: > "sed -i -" does not fail, but it also does not do what one would expect. > Document it, as it could have security implications: > > Example: > The sed command below looks broken, but it is executed and succeeds: > > ln -s /etc/passwd -- - > echo root | sed -i --follow-symlinks s/root/parrot/ - > > Signed-off-by: Stanislav Brabec > --- > doc/sed-in.texi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/sed-in.texi b/doc/sed-in.texi > index 0e10cde..c8f1289 100644 > --- a/doc/sed-in.texi > +++ b/doc/sed-in.texi > @@ -180,6 +180,7 @@ sed OPTIONS... [SCRIPT] [INPUTFILE...] > @end example > > If you do not specify @var{INPUTFILE}, or if @var{INPUTFILE} is @file{-}, > +and @option{-i} is not used, > @command{sed} filters the contents of the standard input. The @var{script} > is actually the first non-option parameter, which @command{sed} specially > considers a script and not an input file if (and only if) none of the Thank you for the patch. However, rather than documenting this surprising behavior, I propose to remove the anomaly altogether with the attached patch. Does anyone see a reason to retain the behavior of treating "-" like "./-"? --001a114fc2b4499dd00518fe601e Content-Type: application/octet-stream; name="0001-sed-i-do-not-treat-as-a-file-name.patch" Content-Disposition: attachment; filename="0001-sed-i-do-not-treat-as-a-file-name.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ib5vzyd10 RnJvbSBjMDMzYmRlZTQxMTEyOGRmZWJmZWExOTc0ZDFlZTNjMWQ5ZWFjNTcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCAyMCBKdW4gMjAxNSAwNzozODo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIHNlZCAtaTog ZG8gbm90IHRyZWF0ICItIiBhcyBhIGZpbGUgbmFtZQoKTW9zdCBHTlUgdXRpbGl0aWVzIHRyZWF0 ICItIiBhcyBzdGFuZGFyZCBpbnB1dCwgc2VkIGl0c2VsZiBkb2VzIHRoYXQgLS0KaW4gbW9zdCBj b250ZXh0cy4gIEhvd2V2ZXIsIHNpbmNlIHRoZSBhZGRpdGlvbiBvZiBzdXBwb3J0IGZvcgotLWlu LXBsYWNlICgtaSkgaW4gc2VkLTQuMCwgc2VkIC1pIGhhcyB0cmVhdGVkIGEgIi0iIGFyZ3VtZW50 IGFzIGEKZmlsZSBuYW1lLCBpLmUuLCBsaWtlIC4vLS4gIE5vdywgdGhhdCB1c2FnZSBldm9rZXMg YSBkaWFnbm9zdGljOgoKICAkIHNlZCAtaSBzL2EvYi8gLQogIHNlZDogY291bGRuJ3QgZWRpdCAt OiBpcyBhIHRlcm1pbmFsCgpJZiB5b3UgcmVxdWlyZSB0aGUgb2xkIGJlaGF2aW9yLCBzcGVjaWZ5 IHRoZSBmaWxlIG5hbWUgYXMgIi4vLSIuClByb21wdGVkIGJ5IHRoZSByZXBvcnQvcGF0Y2ggZnJv bSBTdGFuaXNsYXYgQnJhYmVjIGluCmh0dHA6Ly9idWdzLmdudS5vcmcvMjA3OTYgdG8gZG9jdW1l bnQgdGhlIHN0cmFuZ2VseQppbmNvbnNpc3RlbnQgbGVnYWN5IGJlaGF2aW9yLgoKKiBzZWQvZXhl Y3V0ZS5jIChvcGVuX25leHRfZmlsZSk6IENhbGwgcGFuaWMgYmVmb3JlCmV2ZW4gYXR0ZW1wdGlu ZyB0byBvcGVyYXRlIG9uIHRoZSBmaWxlIGRlc2NyaXB0b3IuCiogdGVzdHN1aXRlL2luLXBsYWNl LWh5cGhlbi5zaDogTmV3IGZpbGUuICBUZXN0IGZvciB0aGlzLgoqIHRlc3RzdWl0ZS9NYWtlZmls ZS5hbSAoVCk6IEFkZCBpdC4KKiBORVdTIChGZWF0dXJlIHJlbW92YWwpOiBNZW50aW9uIGl0LiBB ZG1pdHRlZGx5LCB0aGUgb2xkIGJlaGF2aW9yCmZlZWxzIG1vcmUgbGlrZSBhIG1pc2ZlYXR1cmUu Ci0tLQogTkVXUyAgICAgICAgICAgICAgICAgICAgICAgICB8ICAzICsrKwogc2VkL2V4ZWN1dGUu YyAgICAgICAgICAgICAgICB8ICA1ICsrKystCiB0ZXN0c3VpdGUvTWFrZWZpbGUuYW0gICAgICAg IHwgIDEgKwogdGVzdHN1aXRlL2luLXBsYWNlLWh5cGhlbi5zaCB8IDI5ICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrCiA0IGZpbGVzIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKIGNyZWF0ZSBtb2RlIDEwMDc1NSB0ZXN0c3VpdGUvaW4tcGxhY2UtaHlwaGVuLnNo CgpkaWZmIC0tZ2l0IGEvTkVXUyBiL05FV1MKaW5kZXggMDY0MjczYi4uNjFiOGFhMiAxMDA2NDQK LS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC00Myw2ICs0Myw5IEBAIEdOVSBzZWQgTkVXUyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0qLSBvdXRsaW5lIC0qLQogICBoYXMgYmVl biBsaXN0ZWQgaW4gdGhlIGRvY3VtZW50YXRpb24gYXMgYSBmYWlsZWQgZXhwZXJpbWVudCBmb3Ig YXQKICAgbGVhc3QgMTAgeWVhcnMuICBUaGF0IGNvbW1hbmQgaXMgbm93IHJlbW92ZWQuCgorICBz ZWQgLWkgcy9hL2IvIC0gbm93IGV2b2tlcyBhbiBlcnJvciwgcmF0aGVyIHRoYW4gYXR0ZW1wdGlu ZyB0byBvcGVyYXRlCisgIG9uIHRoZSBmaWxlIG5hbWVkIC4vLQorCiAqKiBCdWlsZC1yZWxhdGVk CgogICAibWFrZSBkaXN0IiBub3cgYnVpbGRzIC50YXIueHogZmlsZXMsIHJhdGhlciB0aGFuIC50 YXIuZ3ogb25lcy4KZGlmZiAtLWdpdCBhL3NlZC9leGVjdXRlLmMgYi9zZWQvZXhlY3V0ZS5jCmlu ZGV4IDRkZGJmNTUuLjQ5Y2ZiNDUgMTAwNjQ0Ci0tLSBhL3NlZC9leGVjdXRlLmMKKysrIGIvc2Vk L2V4ZWN1dGUuYwpAQCAtNTQ5LDggKzU0OSwxMSBAQCBvcGVuX25leHRfZmlsZShjb25zdCBjaGFy ICpuYW1lLCBzdHJ1Y3QgaW5wdXQgKmlucHV0KQogewogICBidWZmZXIubGVuZ3RoID0gMDsKCi0g IGlmIChuYW1lWzBdID09ICctJyAmJiBuYW1lWzFdID09ICdcMCcgJiYgIWluX3BsYWNlX2V4dGVu c2lvbikKKyAgaWYgKG5hbWVbMF0gPT0gJy0nICYmIG5hbWVbMV0gPT0gJ1wwJykKICAgICB7Cisg ICAgICBpZiAoaW5fcGxhY2VfZXh0ZW5zaW9uKQorICAgICAgICBwYW5pYyhfKCJjb3VsZG4ndCBl ZGl0ICVzOiBpcyBhIHRlcm1pbmFsIiksIG5hbWUpOworCiAgICAgICBjbGVhcmVycihzdGRpbik7 CS8qIGNsZWFyIGFueSBzdGFsZSBFT0YgaW5kaWNhdGlvbiAqLwogI2lmIGRlZmluZWQgV0lOMzIg fHwgZGVmaW5lZCBfV0lOMzIgfHwgZGVmaW5lZCBfX0NZR1dJTl9fIFwKICAgfHwgZGVmaW5lZCBN U0RPUyB8fCBkZWZpbmVkIF9fRU1YX18KZGlmZiAtLWdpdCBhL3Rlc3RzdWl0ZS9NYWtlZmlsZS5h bSBiL3Rlc3RzdWl0ZS9NYWtlZmlsZS5hbQppbmRleCBiYzM1YWRkLi5iZmZmZGEwIDEwMDY0NAot LS0gYS90ZXN0c3VpdGUvTWFrZWZpbGUuYW0KKysrIGIvdGVzdHN1aXRlL01ha2VmaWxlLmFtCkBA IC03LDYgKzcsNyBAQCBTSF9MT0dfQ09NUElMRVIgPSAkKFNIRUxMKQogIyBpcyBsaXN0ZWQgaW4g b25seSBvbmUgcGxhY2UuCiBUID0JCQlcCiAgIGhlbHAtdmVyc2lvbi5zaAlcCisgIGluLXBsYWNl LWh5cGhlbi5zaAlcCiAgIGludmFsaWQtbWItc2VxLVVNUi5zaAlcCiAgIHJhbmdlLW92ZXJsYXAu c2gJXAogICB0ZW1wLWZpbGUtY2xlYW51cC5zaApkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL2luLXBs YWNlLWh5cGhlbi5zaCBiL3Rlc3RzdWl0ZS9pbi1wbGFjZS1oeXBoZW4uc2gKbmV3IGZpbGUgbW9k ZSAxMDA3NTUKaW5kZXggMDAwMDAwMC4uMGUwZWVkYQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3Rz dWl0ZS9pbi1wbGFjZS1oeXBoZW4uc2gKQEAgLTAsMCArMSwyOSBAQAorIyEvYmluL3NoCisjIFZl cmlmeSB0aGF0ICItIiBpcyBubyBsb25nZXIgdHJlYXRlZCBhcyBhIGZpbGUgbmFtZSB3aXRoIC0t aW4tcGxhY2UuCisKKyMgQ29weXJpZ2h0IChDKSAyMDE1IEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLgorCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlz dHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChh dCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyMgVGhpcyBwcm9ncmFtIGlzIGRp c3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRI T1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisj IE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNl ZSB0aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKwor IyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJs aWMgTGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2VlIDxodHRw Oi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKy4gIiR7c3JjZGlyPS59L2luaXQuc2giOyBwYXRo X3ByZXBlbmRfIC4uL3NlZAorcHJpbnRfdmVyXyBzZWQKKworZWNobyAic2VkOiBjb3VsZG4ndCBl ZGl0IC06IGlzIGEgdGVybWluYWwiID4gZXhwLWVyciB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KKwor ZmFpbD0wCitzZWQgLWkgJ3MvYS9iLycgLSA+IG91dCAyPiBlcnIgJiYgZmFpbD0xCisKK2NvbXBh cmUgL2Rldi9udWxsIG91dCB8fCBmYWlsPTEKK2NvbXBhcmUgZXhwLWVyciBlcnIgfHwgZmFpbD0x CisKK0V4aXQgJGZhaWwKLS0gCjIuMy43Cgo= --001a114fc2b4499dd00518fe601e-- From unknown Sun Jun 22 04:30:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20796: [PATCH] Document behavior of sed -i - Resent-From: Stanislav Brabec Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Mon, 22 Jun 2015 13:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20796 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: Jim Meyering Cc: 20796@debbugs.gnu.org Received: via spool by 20796-submit@debbugs.gnu.org id=B20796.14349806145596 (code B ref 20796); Mon, 22 Jun 2015 13:44:02 +0000 Received: (at 20796) by debbugs.gnu.org; 22 Jun 2015 13:43:34 +0000 Received: from localhost ([127.0.0.1]:53972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z720a-0001S6-Mr for submit@debbugs.gnu.org; Mon, 22 Jun 2015 09:43:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54498 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z720W-0001Rs-78 for 20796@debbugs.gnu.org; Mon, 22 Jun 2015 09:43:29 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D66B5AC20; Mon, 22 Jun 2015 13:43:26 +0000 (UTC) Message-ID: <558810FE.9070000@suse.com> Date: Mon, 22 Jun 2015 15:43:26 +0200 From: Stanislav Brabec Organization: SUSE Linux, s. r. o. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 References: <557AFBA2.2080603@suse.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Jim Meyering wrote: > However, rather than documenting this surprising behavior, > I propose to remove the anomaly altogether with the attached patch. > Does anyone see a reason to retain the behavior of treating "-" > like "./-"? > The reason is simple: "sed -i" makes no sense on stdin, so the special handling od "-" is disabled. We can either ignore "-i" for stdin, or report error: "Editing standard input in place is an undefined operation." -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com Lihovarská 1060/12 tel: +49 911 7405384547 190 00 Praha 9 fax: +420 284 084 001 Czech Republic http://www.suse.cz/ PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76 From unknown Sun Jun 22 04:30:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20796: [PATCH] Document behavior of sed -i - Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Mon, 22 Jun 2015 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20796 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: Stanislav Brabec Cc: 20796 <20796@debbugs.gnu.org> Received: via spool by 20796-submit@debbugs.gnu.org id=B20796.14349820348147 (code B ref 20796); Mon, 22 Jun 2015 14:08:02 +0000 Received: (at 20796) by debbugs.gnu.org; 22 Jun 2015 14:07:14 +0000 Received: from localhost ([127.0.0.1]:54506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z72NV-00027L-F3 for submit@debbugs.gnu.org; Mon, 22 Jun 2015 10:07:13 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:35047) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z72NT-000271-4H for 20796@debbugs.gnu.org; Mon, 22 Jun 2015 10:07:11 -0400 Received: by ykdy1 with SMTP id y1so22995388ykd.2 for <20796@debbugs.gnu.org>; Mon, 22 Jun 2015 07:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=CsQDlCQjvQ3yu2I03LloidxJG7Qp2e38Pm2hbTb38fo=; b=iiv1VYAQSEvrJzbJ+Paywfa1FT9ZUVpZUKrqSADNrFIvGxA90onTm8lDB6Id8wRaCs GYiPC7OT4+MxhMnLMmOWEzgrL8XsgZ+Mmq1CwV2yBgsSD01i+HVIDZXKR1ZI6pXTjInY TrhQeeqsezTIeA7alRZW8qHGLKsGnP8yCB4Qs8FayL0ph4sWuO27acqiicXTlvR3HBE+ fG5uIWmI0krt302sgnP/5wEDvaoQl/0txCIe5ZyGl9d5LeKtt5JRs9qIWbnBDX7U1Qlw /D8VqoAUOBu+9IGi9LLl8Y5pG8JKIsUQVcWScuf9y2pGX4aVEzc1+xDKCSvVS9NPbBNF u5Cg== X-Received: by 10.170.35.196 with SMTP id 187mr24781680ykd.121.1434982025683; Mon, 22 Jun 2015 07:07:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Mon, 22 Jun 2015 07:06:46 -0700 (PDT) In-Reply-To: <558810FE.9070000@suse.com> References: <557AFBA2.2080603@suse.com> <558810FE.9070000@suse.com> From: Jim Meyering Date: Mon, 22 Jun 2015 07:06:46 -0700 X-Google-Sender-Auth: GW4QnMjaRJT8Y0i2-y6sb02ZK2A Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Jun 22, 2015 at 6:43 AM, Stanislav Brabec wrote: > Jim Meyering wrote: > >> However, rather than documenting this surprising behavior, >> I propose to remove the anomaly altogether with the attached patch. >> Does anyone see a reason to retain the behavior of treating "-" >> like "./-"? >> > The reason is simple: "sed -i" makes no sense on stdin, so the special > handling od "-" is disabled. > > We can either ignore "-i" for stdin, or report error: > "Editing standard input in place is an undefined operation." Ignoring a fundamental user-specified option like -i is not an option, so I chose the latter: to make this nonsensical usage evoke a diagnostic: $ sed -i s/a/b/ - sed: couldn't edit -: is a terminal I chose to use the same diagnostic that was already printed for a case like "sed -i s/a/b/ /dev/stdin". It feels slightly better to include the name of the offending device. From unknown Sun Jun 22 04:30:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20796: [PATCH] Keep special meaning of "-" even for "sed -i" Resent-From: Stanislav Brabec Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Mon, 22 Jun 2015 14:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20796 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: Jim Meyering , sbrabec@suse.cz Cc: 20796 <20796@debbugs.gnu.org> Received: via spool by 20796-submit@debbugs.gnu.org id=B20796.143498403611171 (code B ref 20796); Mon, 22 Jun 2015 14:41:03 +0000 Received: (at 20796) by debbugs.gnu.org; 22 Jun 2015 14:40:36 +0000 Received: from localhost ([127.0.0.1]:54585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z72tn-0002u6-IY for submit@debbugs.gnu.org; Mon, 22 Jun 2015 10:40:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58948 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z72tk-0002tx-Ne for 20796@debbugs.gnu.org; Mon, 22 Jun 2015 10:40:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8B53FAC86; Mon, 22 Jun 2015 14:40:31 +0000 (UTC) Message-ID: <55881E5F.8000102@suse.com> Date: Mon, 22 Jun 2015 16:40:31 +0200 From: Stanislav Brabec Organization: SUSE Linux, s. r. o. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 References: <557AFBA2.2080603@suse.com> <558810FE.9070000@suse.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) "sed -i -" does not fail, but it also does not do what one would expect. It attempts to access file "./-" and edit it in place. Keep special meaning of "-" even for "sed -i". It will cause failure, which is what most people would expect: sed: couldn't edit /dev/stdin: is a terminal Note that the previous behavior could have security implications: ln -s /etc/passwd -- - echo root | sed -i --follow-symlinks s/root/parrot/ - Signed-off-by: Stanislav Brabec --- sed/execute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sed/execute.c b/sed/execute.c index bfde525..2cba844 100644 --- a/sed/execute.c +++ b/sed/execute.c @@ -550,7 +550,7 @@ open_next_file(const char *name, struct input *input) buffer.length = 0; input->in_file_name = name; - if (name[0] == '-' && name[1] == '\0' && !in_place_extension) + if (name[0] == '-' && name[1] == '\0') { clearerr(stdin); /* clear any stale EOF indication */ #if defined WIN32 || defined _WIN32 || defined __CYGWIN__ \ -- 2.4.3 -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com Lihovarská 1060/12 tel: +49 911 7405384547 190 00 Praha 9 fax: +420 284 084 001 Czech Republic http://www.suse.cz/ PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76 From unknown Sun Jun 22 04:30:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20796: [PATCH] Keep special meaning of "-" even for "sed -i" Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Mon, 22 Jun 2015 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20796 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: Stanislav Brabec Cc: sbrabec@suse.cz, 20796 <20796@debbugs.gnu.org> Received: via spool by 20796-submit@debbugs.gnu.org id=B20796.143498546013293 (code B ref 20796); Mon, 22 Jun 2015 15:05:02 +0000 Received: (at 20796) by debbugs.gnu.org; 22 Jun 2015 15:04:20 +0000 Received: from localhost ([127.0.0.1]:54606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z73Gl-0003SL-Gd for submit@debbugs.gnu.org; Mon, 22 Jun 2015 11:04:19 -0400 Received: from mail-yh0-f46.google.com ([209.85.213.46]:34148) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z73Gj-0003S8-Ml for 20796@debbugs.gnu.org; Mon, 22 Jun 2015 11:04:18 -0400 Received: by yhnv31 with SMTP id v31so77276675yhn.1 for <20796@debbugs.gnu.org>; Mon, 22 Jun 2015 08:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=a0YltX3kp5+d8g4HchOFut8x27KLyC2AZ1Vb5kv6e2A=; b=CH2KHZoGgC8thH04mUqlNZrU4VI3++AiTaiKcmO13rip7JyRpcgMDRbafQZbQlRIqZ gN19ohS2ijEbc+cVoX/Sfy2iOzfkvRc2D8ONkQaelVYYmuDvD5kQhlqxnzdM1OI4YeIs xeKTxgB4RIkZQu82TPELSNlbmsJzvsu1cY89VRm3FneRtuTzzJB9C5MAGdsYrs9YTaBn 7H45jQ6KnxA6SMtwYjmfulJmFYS6vqS+Jt0LSY/fPkfZjHRS48x5i1GwRBMfL6J4bPNb wPz2ZGzlBXR4rN8VdicWCYhxvbiBrA3hhfOAihwCjlRg7YBNin3oO1JTGfKtKbwfEJFG lF0g== X-Received: by 10.170.50.19 with SMTP id 19mr22030816yks.61.1434985452061; Mon, 22 Jun 2015 08:04:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Mon, 22 Jun 2015 08:03:52 -0700 (PDT) In-Reply-To: <55881E5F.8000102@suse.com> References: <557AFBA2.2080603@suse.com> <558810FE.9070000@suse.com> <55881E5F.8000102@suse.com> From: Jim Meyering Date: Mon, 22 Jun 2015 08:03:52 -0700 X-Google-Sender-Auth: J7pK7JXRru8SuQdg9eIpfNocVqA Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Jun 22, 2015 at 7:40 AM, Stanislav Brabec wrote: > "sed -i -" does not fail, but it also does not do what one would expect. > It attempts to access file "./-" and edit it in place. > > Keep special meaning of "-" even for "sed -i". It will cause failure, > which is what most people would expect: > > sed: couldn't edit /dev/stdin: is a terminal > > Note that the previous behavior could have security implications: > ln -s /etc/passwd -- - > echo root | sed -i --follow-symlinks s/root/parrot/ - > > Signed-off-by: Stanislav Brabec > --- > sed/execute.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sed/execute.c b/sed/execute.c Thanks for the patch. I guess you didn't see that I posted one yesterday? http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20796#8 From unknown Sun Jun 22 04:30:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stanislav Brabec Subject: bug#20796: closed (Re: bug#20796: [PATCH] Document behavior of sed -i -) Message-ID: References: <557AFBA2.2080603@suse.com> X-Gnu-PR-Message: they-closed 20796 X-Gnu-PR-Package: sed X-Gnu-PR-Keywords: patch Reply-To: 20796@debbugs.gnu.org Date: Tue, 23 Jun 2015 16:12:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1435075923-19998-1" This is a multi-part message in MIME format... ------------=_1435075923-19998-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20796: [PATCH] Document behavior of sed -i - which was filed against the sed package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20796@debbugs.gnu.org. --=20 20796: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20796 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1435075923-19998-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20796-done) by debbugs.gnu.org; 23 Jun 2015 16:11:37 +0000 Received: from localhost ([127.0.0.1]:55510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7QnQ-0005Bu-TW for submit@debbugs.gnu.org; Tue, 23 Jun 2015 12:11:37 -0400 Received: from mail-yk0-f181.google.com ([209.85.160.181]:36257) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7QnP-0005Bg-3V for 20796-done@debbugs.gnu.org; Tue, 23 Jun 2015 12:11:35 -0400 Received: by ykdr198 with SMTP id r198so8157267ykd.3 for <20796-done@debbugs.gnu.org>; Tue, 23 Jun 2015 09:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=lKqHTnRaj6kYaNhdghVXOJ4wngPrjDkbxIClaM2H42o=; b=tpAe1Jx/AHcwIyuZEcXI2Yl8XEab5UQ6+2DXebYePtNoZPqiKUZKYGBcWB0ZkELoqS Q8yZKdcT37J7GJDKkdYc0YFt0FWxdRXqTQlW3GCpgYYPcYZJ21Zn/BSWHZIUZboONS5b B8KsYkJF6xgfmP4qJkscekWa/hnC78J2BFX6MemxOArRBtyNgP1r+RcRtqfw/40F/foa dh1ffNuIZYbRALLk/g738b2KPvvaKeeXP6ntLkWqhgBf+dtjmMRBuBAiQrt1fMVlhz+K TxFH8x/UovHVcTRvldpJjEMQSJibrlXF/AhiunjFAjIfKttstLXqCr52+cq76QRzh1t2 NlYw== X-Received: by 10.170.35.196 with SMTP id 187mr31323276ykd.121.1435075889737; Tue, 23 Jun 2015 09:11:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.201.66 with HTTP; Tue, 23 Jun 2015 09:11:10 -0700 (PDT) In-Reply-To: References: <557AFBA2.2080603@suse.com> <558810FE.9070000@suse.com> From: Jim Meyering Date: Tue, 23 Jun 2015 09:11:10 -0700 X-Google-Sender-Auth: X8DyA8-oB46KEu4AmaFPUMUFzBo Message-ID: Subject: Re: bug#20796: [PATCH] Document behavior of sed -i - To: Stanislav Brabec Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20796-done Cc: 20796-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Jun 22, 2015 at 7:06 AM, Jim Meyering wrote: > On Mon, Jun 22, 2015 at 6:43 AM, Stanislav Brabec wrote: >> Jim Meyering wrote: >> >>> However, rather than documenting this surprising behavior, >>> I propose to remove the anomaly altogether with the attached patch. >>> Does anyone see a reason to retain the behavior of treating "-" >>> like "./-"? >>> >> The reason is simple: "sed -i" makes no sense on stdin, so the special >> handling od "-" is disabled. >> >> We can either ignore "-i" for stdin, or report error: >> "Editing standard input in place is an undefined operation." > > Ignoring a fundamental user-specified option like -i is not an option, > so I chose the latter: to make this nonsensical usage evoke > a diagnostic: > > $ sed -i s/a/b/ - > sed: couldn't edit -: is a terminal > > I chose to use the same diagnostic that was already printed for > a case like "sed -i s/a/b/ /dev/stdin". It feels slightly better to > include the name of the offending device. I've pushed that change. ------------=_1435075923-19998-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Jun 2015 15:33:04 +0000 Received: from localhost ([127.0.0.1]:51968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Qx6-0004My-Ac for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:33:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57296) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Qx4-0004MS-Ev for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:33:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Qwy-0005Ym-Et for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:32:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Qwy-0005Yh-Cg for submit@debbugs.gnu.org; Fri, 12 Jun 2015 11:32:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Qwx-0004AG-GT for bug-sed@gnu.org; Fri, 12 Jun 2015 11:32:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Qwt-0005Y5-FY for bug-sed@gnu.org; Fri, 12 Jun 2015 11:32:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54114 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Qwt-0005Xp-9N for bug-sed@gnu.org; Fri, 12 Jun 2015 11:32:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AB920AC27 for ; Fri, 12 Jun 2015 15:32:50 +0000 (UTC) Message-ID: <557AFBA2.2080603@suse.com> Date: Fri, 12 Jun 2015 17:32:50 +0200 From: Stanislav Brabec Organization: SUSE Linux, s. r. o. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: bug-sed@gnu.org Subject: [PATCH] Document behavior of sed -i - Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) "sed -i -" does not fail, but it also does not do what one would expect. Document it, as it could have security implications: Example: The sed command below looks broken, but it is executed and succeeds: ln -s /etc/passwd -- - echo root | sed -i --follow-symlinks s/root/parrot/ - Signed-off-by: Stanislav Brabec --- doc/sed-in.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/sed-in.texi b/doc/sed-in.texi index 0e10cde..c8f1289 100644 --- a/doc/sed-in.texi +++ b/doc/sed-in.texi @@ -180,6 +180,7 @@ sed OPTIONS... [SCRIPT] [INPUTFILE...] @end example =20 If you do not specify @var{INPUTFILE}, or if @var{INPUTFILE} is @file{-}= , +and @option{-i} is not used, @command{sed} filters the contents of the standard input. The @var{scri= pt} is actually the first non-option parameter, which @command{sed} speciall= y considers a script and not an input file if (and only if) none of the --=20 2.4.2 --=20 Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec@suse.com Lihovarsk=E1 1060/12 tel: +49 911 7405384547 190 00 Praha 9 fax: +420 284 084 001 Czech Republic http://www.suse.cz/ PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76 ------------=_1435075923-19998-1--