GNU bug report logs - #20787
24.3; make-mode doesn't hightlight macro assignments preceeded by a TAB

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 20787 <at> debbugs.gnu.org, JFTrudeau <at> aetna.com
Subject: bug#20787: 24.3; make-mode doesn't hightlight macro assignments preceeded by a TAB
Date: Tue, 23 Feb 2016 18:16:45 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Tue, 23 Feb 2016 21:07:19 +1100
> Cc: 20787 <at> debbugs.gnu.org
> 
> "John F. Trudeau" <JFTrudeau <at> aetna.com> writes:
> 
> > The constant makefile-macroassign-regex (used for highlighting), in
> > make-mode.el, does not find an assignment that is preceded by a TAB
> > character.  The attached patch corrects the regular expression to allow
> > TAB as well as SPACE before an assignment, which corrects highlighting.
> >
> >  -rw-r--r-- trudeajo/users       158 ChangeLog
> >  -rw-r--r-- trudeajo/users      2101 make-mode.el.patch
> >
> > This bug has endured through many emacs releases.
> 
> I've detarred the patch and included it below, but I can't really say
> whether it makes sense or not.  Anybody?

LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.