From unknown Mon Jun 23 02:23:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#20785 <20785@debbugs.gnu.org> To: bug#20785 <20785@debbugs.gnu.org> Subject: Status: user-error for mark-inactive Reply-To: bug#20785 <20785@debbugs.gnu.org> Date: Mon, 23 Jun 2025 09:23:38 +0000 retitle 20785 user-error for mark-inactive reassign 20785 emacs submitter 20785 Juri Linkov severity 20785 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 19:36:11 2015 Received: (at submit) by debbugs.gnu.org; 10 Jun 2015 23:36:12 +0000 Received: from localhost ([127.0.0.1]:49929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2pXX-00065h-Ar for submit@debbugs.gnu.org; Wed, 10 Jun 2015 19:36:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38905) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2pXU-00065U-HT for submit@debbugs.gnu.org; Wed, 10 Jun 2015 19:36:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2pXO-0006mn-23 for submit@debbugs.gnu.org; Wed, 10 Jun 2015 19:36:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2pXN-0006mh-Vk for submit@debbugs.gnu.org; Wed, 10 Jun 2015 19:36:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2pXM-0005SD-UO for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2015 19:36:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2pXH-0006jf-NR for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2015 19:36:00 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:57694 helo=homiemail-a20.g.dreamhost.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2pXH-0006jS-2G for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2015 19:35:55 -0400 Received: from homiemail-a20.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTP id 790157EC07D for ; Wed, 10 Jun 2015 16:35:52 -0700 (PDT) Received: from localhost.linkov.net (m213-102-136-198.cust.tele2.ee [213.102.136.198]) (Authenticated sender: jurta@jurta.org) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTPA id A54F17EC078 for ; Wed, 10 Jun 2015 16:35:51 -0700 (PDT) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: user-error for mark-inactive Organization: LINKOV.NET Date: Thu, 11 Jun 2015 02:34:06 +0300 Message-ID: <87oakncf4h.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) A single remaining case that is too annoying is when the debugger is called due to a user error while accidentally typing `C-w' (kill-region) when there is no active mark in the buffer: Debugger entered--Lisp error: (mark-inactive) signal(mark-inactive nil) mark() byte-code("\300 `\301E\207" [mark region] 3) call-interactively(kill-region nil nil) command-execute(kill-region) The following patch avoids this in both cases: 1. when mark-even-if-inactive is non-nil, displays the message: "user-error: The mark is not set now, so there is no region" 2. when mark-even-if-inactive is nil, displays the message: "mark: The mark is not active now" diff --git a/lisp/simple.el b/lisp/simple.el index 1eb0643..31810a4 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -4017,7 +4021,7 @@ (defun kill-region (beg end &optional region) ;; calling `kill-append'. (interactive (list (mark) (point) 'region)) (unless (and beg end) - (error "The mark is not set now, so there is no region")) + (user-error "The mark is not set now, so there is no region")) (condition-case nil (let ((string (if region (funcall region-extract-function 'delete) diff --git a/lisp/bindings.el b/lisp/bindings.el index b658914..3672812 100644 --- a/lisp/bindings.el +++ b/lisp/bindings.el @@ -633,7 +633,7 @@ (setq debug-ignored-errors ;; file-supersession should all be user-errors! `(beginning-of-line beginning-of-buffer end-of-line end-of-buffer end-of-file buffer-read-only - file-supersession + file-supersession mark-inactive user-error ;; That's the main one! )) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 23:11:12 2015 Received: (at 20785) by debbugs.gnu.org; 11 Jun 2015 03:11:12 +0000 Received: from localhost ([127.0.0.1]:50027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2stb-0004ZO-EA for submit@debbugs.gnu.org; Wed, 10 Jun 2015 23:11:12 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:53517) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2stY-0004ZF-Bv for 20785@debbugs.gnu.org; Wed, 10 Jun 2015 23:11:08 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t5B3B6ZG009993; Wed, 10 Jun 2015 23:11:07 -0400 Received: by ceviche.home (Postfix, from userid 20848) id B1A556614A; Wed, 10 Jun 2015 23:11:06 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#20785: user-error for mark-inactive Message-ID: References: <87oakncf4h.fsf@mail.linkov.net> Date: Wed, 10 Jun 2015 23:11:06 -0400 In-Reply-To: <87oakncf4h.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 11 Jun 2015 02:34:06 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV5333=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5333> : inlines <3181> : streams <1453443> : uri <1955537> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20785 Cc: 20785@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > A single remaining case that is too annoying is when the debugger is > called due to a user error while accidentally typing `C-w' (kill-region) > when there is no active mark in the buffer: Looks OK to me (maybe we could also just signal `mark-inactive' instead of calling user-error, but either way is OK for me), Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 11 19:19:24 2015 Received: (at 20785-done) by debbugs.gnu.org; 11 Jun 2015 23:19:24 +0000 Received: from localhost ([127.0.0.1]:51107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Bkq-0002Io-7z for submit@debbugs.gnu.org; Thu, 11 Jun 2015 19:19:24 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:42075 helo=homiemail-a11.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Bko-0002If-Bd for 20785-done@debbugs.gnu.org; Thu, 11 Jun 2015 19:19:22 -0400 Received: from homiemail-a11.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a11.g.dreamhost.com (Postfix) with ESMTP id 8BCE76E07E; Thu, 11 Jun 2015 16:19:21 -0700 (PDT) Received: from localhost.linkov.net (m83-187-196-182.cust.tele2.ee [83.187.196.182]) (Authenticated sender: jurta@jurta.org) by homiemail-a11.g.dreamhost.com (Postfix) with ESMTPA id 701B56E07C; Thu, 11 Jun 2015 16:19:20 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#20785: user-error for mark-inactive Organization: LINKOV.NET References: <87oakncf4h.fsf@mail.linkov.net> Date: Fri, 12 Jun 2015 02:17:56 +0300 In-Reply-To: (Stefan Monnier's message of "Wed, 10 Jun 2015 23:11:06 -0400") Message-ID: <87d2113kd7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20785-done Cc: 20785-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> A single remaining case that is too annoying is when the debugger is >> called due to a user error while accidentally typing `C-w' (kill-region) >> when there is no active mark in the buffer: > > Looks OK to me Installed. > (maybe we could also just signal `mark-inactive' instead > of calling user-error, but either way is OK for me), I see that `mark-inactive' and user-error in `kill-region' have different messages: `mark-inactive' signaled in the function `mark' has the message only about the mark: "The mark is not active now" whereas the user-error message in `kill-region' is specific about the region: "The mark is not set now, so there is no region" and I don't see how to merge these messages. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 12 01:40:19 2015 Received: (at 20785-done) by debbugs.gnu.org; 12 Jun 2015 05:40:19 +0000 Received: from localhost ([127.0.0.1]:51184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3HhS-0004c6-0q for submit@debbugs.gnu.org; Fri, 12 Jun 2015 01:40:18 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45331) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3HhO-0004bw-32 for 20785-done@debbugs.gnu.org; Fri, 12 Jun 2015 01:40:16 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t5C5eBX5017826; Fri, 12 Jun 2015 01:40:11 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 687C266166; Fri, 12 Jun 2015 01:40:11 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#20785: user-error for mark-inactive Message-ID: References: <87oakncf4h.fsf@mail.linkov.net> <87d2113kd7.fsf@mail.linkov.net> Date: Fri, 12 Jun 2015 01:40:11 -0400 In-Reply-To: <87d2113kd7.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 12 Jun 2015 02:17:56 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5334=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5334> : inlines <3189> : streams <1454038> : uri <1956693> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 20785-done Cc: 20785-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > `mark-inactive' signaled in the function `mark' > has the message only about the mark: > "The mark is not active now" > whereas the user-error message in `kill-region' > is specific about the region: > "The mark is not set now, so there is no region" I'm not sure how important is this difference (or even if it's intentional). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 18:47:03 2015 Received: (at 20785) by debbugs.gnu.org; 22 Jun 2015 22:47:03 +0000 Received: from localhost ([127.0.0.1]:54758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7AUY-000173-OQ for submit@debbugs.gnu.org; Mon, 22 Jun 2015 18:47:02 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:34965 helo=homiemail-a22.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7AUX-00016j-I8 for 20785@debbugs.gnu.org; Mon, 22 Jun 2015 18:47:01 -0400 Received: from homiemail-a22.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTP id AF17A1A8069; Mon, 22 Jun 2015 15:47:00 -0700 (PDT) Received: from localhost.linkov.net (m213-102-70-120.cust.tele2.ee [213.102.70.120]) (Authenticated sender: jurta@jurta.org) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTPA id C125D1A8063; Mon, 22 Jun 2015 15:46:59 -0700 (PDT) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#20785: user-error for mark-inactive Organization: LINKOV.NET References: <87oakncf4h.fsf@mail.linkov.net> <87d2113kd7.fsf@mail.linkov.net> Date: Tue, 23 Jun 2015 01:46:17 +0300 In-Reply-To: (Stefan Monnier's message of "Fri, 12 Jun 2015 01:40:11 -0400") Message-ID: <87zj3ruzt2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20785 Cc: 20785@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> `mark-inactive' signaled in the function `mark' >> has the message only about the mark: > >> "The mark is not active now" > >> whereas the user-error message in `kill-region' >> is specific about the region: > >> "The mark is not set now, so there is no region" > > I'm not sure how important is this difference (or even if it's intentio= nal). I noticed another occurrence in =E2=80=98shell-command-on-region=E2=80=99= , so maybe better to leave the mention of the region in all region-related commands. From unknown Mon Jun 23 02:23:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Jul 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator