From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 11:05:49 2015 Received: (at submit) by debbugs.gnu.org; 9 Jun 2015 15:05:49 +0000 Received: from localhost ([127.0.0.1]:46353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2L64-0006vt-I4 for submit@debbugs.gnu.org; Tue, 09 Jun 2015 11:05:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36309) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2L61-0006vd-GY for submit@debbugs.gnu.org; Tue, 09 Jun 2015 11:05:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2L5q-0003Ct-Mv for submit@debbugs.gnu.org; Tue, 09 Jun 2015 11:05:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2L5q-0003Cp-Kk for submit@debbugs.gnu.org; Tue, 09 Jun 2015 11:05:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2L5p-00023c-NV for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2015 11:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2L5j-00031R-9Z for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2015 11:05:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2L5j-00030R-4D for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2015 11:05:27 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t59F5PGh007089 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Jun 2015 15:05:26 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t59F5P0E012030 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Tue, 9 Jun 2015 15:05:25 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t59F5Pap006644 for ; Tue, 9 Jun 2015 15:05:25 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 9 Jun 2015 08:05:24 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; [PATCH] ls-lisp fix for wrong-type-arg error X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: multipart/mixed; boundary="__143386232488385542abhmp0016.oracle.com" X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --__143386232488385542abhmp0016.oracle.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable This bug was described as part of bug #20739, and the fix was mentioned there. A patch for the fix is attached. The bug is that when `dired' is called with a cons DIRNAME argument and with switch -B you get a wrong-type-argument error. For example: (dired-other-window '("foo" "toto.el" "foo.el") "-B") The problem is at the beginning of `ls-lisp-insert-directory. There we see this code on the first line: (if (or wildcard-regexp full-directory-p) But that is incorrect, because when switch `B' is used the code does this (ugly hack) in `ls-lisp--insert-directory': (if (memq ?B switches) (setq wildcard-regexp "[^~]\\'")) and this, similarly: (setq wildcard-regexp (if (memq ?B switches) "[^~]\\'") file (file-relative-name orig-file)) IOW, we use a pseudo wildcard-regexp, "[^~]\\'", to handle the case of backup files. And that doesn't work with this call: (directory-files-and-attributes dir nil wildcard-regexp t (if (memq ?n switches) 'integer 'string)) Debugger entered--Lisp error: (file-error "Opening directory" "No such file or directory" "d:/the/path/to/foo.el/foo.el/") directory-files-and-attributes("foo.el/" nil "[^~]\\'" t string) ls-lisp-insert-directory("foo.el" (66) nil "[^~]\\'" nil) ls-lisp--insert-directory(... The attached patch changes the (if (or wildcard-regexp full-directory-p) to this, which fixes the problem of raising an error: (if (or (and wildcard-regexp (not (string=3D "[^~]\\'" wildcard-regexp))) full-directory-p) (Note that this does not fix bug #20739, which requires that when DIRNAME is a cons the switches actually do what they are supposed to do. This patch merely allows Dired to list the files normally without raising an error, but ignoring the still unsupported -B switch.) In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' --__143386232488385542abhmp0016.oracle.com Content-Type: application/octet-stream; name="ls-lisp-2015-06-09.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="ls-lisp-2015-06-09.patch" ZGlmZiAtdSBscy1saXNwLmVsIGxzLWxpc3AtcGF0Y2hlZC0yMDE1LTA2LTA5LmVsCi0tLSBscy1s aXNwLmVsCTIwMTUtMDYtMDkgMDc6NDE6MzUuNjAzNTg5MzAwIC0wNzAwCisrKyBscy1saXNwLXBh dGNoZWQtMjAxNS0wNi0wOS5lbAkyMDE1LTA2LTA5IDA3OjQ4OjIyLjMwNjMzMzUwMCAtMDcwMApA QCAtMzQ4LDcgKzM0OCw5IEBACiBmaWxlLWF0dHJpYnV0ZXMgYWNjb3JkaW5nIHRvIFNXSVRDSEVT LiAgV0lMRENBUkQtUkVHRVhQIGlzIG5pbCBvciBhbiAqRW1hY3MKIHJlZ2V4cCouICBGVUxMLURJ UkVDVE9SWS1QIG1lYW5zIGZpbGUgaXMgYSBkaXJlY3RvcnkgYW5kIFNXSVRDSEVTIGRvZXMKIG5v dCBjb250YWluIGBkJywgc28gdGhhdCBhIGZ1bGwgbGlzdGluZyBpcyBleHBlY3RlZC4iCi0gIChp ZiAob3Igd2lsZGNhcmQtcmVnZXhwIGZ1bGwtZGlyZWN0b3J5LXApCisgIChpZiAob3IgKGFuZCB3 aWxkY2FyZC1yZWdleHAKKyAgICAgICAgICAgICAgIChub3QgKHN0cmluZz0gIltefl1cXCciIHdp bGRjYXJkLXJlZ2V4cCkpKSA7IFN3aXRjaCAtQiBwc2V1ZG8td2lsZGNhcmQgcmVnZXhwCisgICAg ICAgICAgZnVsbC1kaXJlY3RvcnktcCkKICAgICAgIChsZXQqICgoZGlyIChmaWxlLW5hbWUtYXMt ZGlyZWN0b3J5IGZpbGUpKQogCSAgICAgKGRlZmF1bHQtZGlyZWN0b3J5IGRpcikJOyBzbyB0aGF0 IGZpbGUtYXR0cmlidXRlcyB3b3JrcwogCSAgICAgKGZpbGUtYWxpc3QK --__143386232488385542abhmp0016.oracle.com-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 01 21:04:01 2016 Received: (at control) by debbugs.gnu.org; 2 Jan 2016 02:04:01 +0000 Received: from localhost ([127.0.0.1]:34180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFBY1-0001jo-Hz for submit@debbugs.gnu.org; Fri, 01 Jan 2016 21:04:01 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:33387) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFBY0-0001jd-MM for control@debbugs.gnu.org; Fri, 01 Jan 2016 21:04:00 -0500 Received: by mail-ob0-f173.google.com with SMTP id bx1so189711292obb.0 for ; Fri, 01 Jan 2016 18:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; bh=j/G6Pt7U9G1sIMG23C7alyWtZIz0UXYLZFS+TGH6f2Y=; b=D2CwW6KUCwPpz3U7fwZ5bpeYrlahP0/6X1GLSg68UoEEOqq4mOINlreTbC6jBk6+g9 cCUbOSfgda+W6+qg6WSX1c39ilZagQiiv0UY7y7AFm5FLVTZVevDZcCgJlM7XI+ghBW7 wWDX9ENT3hYnBLlfQvwcnlFtJOaCul69Hl/nFLMksnAW6rmdLWG1w2tsKykwz3qWfked nR1Pc9RFxvYWL1Mcup84xNg7m/eXUwNwA9UDgRickNk893hzOwhqaCgTHNtayuGy5hEU wZRLaut90mXFj2MdGgLRjrBl6sV4uDuOPzwhNX/UMK5oueGj+RJfn6OXTezghuF2+UP4 s+VA== X-Received: by 10.60.93.170 with SMTP id cv10mr46257182oeb.38.1451595131092; Thu, 31 Dec 2015 12:52:11 -0800 (PST) Received: from [192.168.0.3] (174-23-112-137.slkc.qwest.net. [174.23.112.137]) by smtp.gmail.com with ESMTPSA id p64sm25953125oia.20.2015.12.31.12.52.10 for (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Dec 2015 12:52:10 -0800 (PST) From: Ivan Andrus Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: control message for bugs 20774, 20776, 20606, 20414 Message-Id: <3AF9BF2D-B954-4430-9A89-E98C0CB9246B@gmail.com> Date: Thu, 31 Dec 2015 13:52:10 -0700 To: control@debbugs.gnu.org Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\)) X-Mailer: Apple Mail (2.3096.5) X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) tags 20774 patch tags 20776 patch merge 20606 20414 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 05:13:37 2016 Received: (at 20776) by debbugs.gnu.org; 23 Feb 2016 10:13:37 +0000 Received: from localhost ([127.0.0.1]:39208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY9yL-0001pz-6g for submit@debbugs.gnu.org; Tue, 23 Feb 2016 05:13:37 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:59985) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY9yJ-0001pr-PM for 20776@debbugs.gnu.org; Tue, 23 Feb 2016 05:13:36 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aY9xu-0002Lu-CF; Tue, 23 Feb 2016 11:13:11 +0100 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#20776: 25.0.50; [PATCH] ls-lisp fix for wrong-type-arg error References: Date: Tue, 23 Feb 2016 21:13:05 +1100 In-Reply-To: (Drew Adams's message of "Tue, 9 Jun 2015 08:05:24 -0700 (PDT)") Message-ID: <87fuwju43y.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aY9xu-0002Lu-CF X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456827191.6228@EFmV40nAH6IxXE7BNzBFUg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20776 Cc: 20776@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > This bug was described as part of bug #20739, and the fix was mentioned > there. A patch for the fix is attached. Thanks; applied to emacs-25. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 23 05:14:26 2016 Received: (at control) by debbugs.gnu.org; 23 Feb 2016 10:14:26 +0000 Received: from localhost ([127.0.0.1]:39212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY9z8-0001rV-En for submit@debbugs.gnu.org; Tue, 23 Feb 2016 05:14:26 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:60002) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY9z6-0001rN-LX for control@debbugs.gnu.org; Tue, 23 Feb 2016 05:14:24 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aY9yi-0002NH-G9 for control@debbugs.gnu.org; Tue, 23 Feb 2016 11:14:01 +0100 Date: Tue, 23 Feb 2016 21:13:56 +1100 Message-Id: <87egc3u42j.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #20776 X-MailScanner-ID: 1aY9yi-0002NH-G9 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456827242.23873@grVCDDSj6R7VJqmt1LPUJg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 20776 fixed close 20776 25.1 From unknown Wed Jun 25 09:12:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 22 Mar 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator