GNU bug report logs - #20754
checkdoc-current-buffer prints to stdout?!

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Oleh Krehel <ohwoeowho <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20754: closed (checkdoc-current-buffer prints to stdout?!)
Date: Mon, 08 Jun 2015 09:40:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 08 Jun 2015 11:33:00 +0200
with message-id <87oakq5yur.fsf <at> gmail.com>
and subject line Re: bug#20754: checkdoc-current-buffer prints to stdout?!
has caused the debbugs.gnu.org bug report #20754,
regarding checkdoc-current-buffer prints to stdout?!
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20754: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20754
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emacs bug reports and feature requests <bug-gnu-emacs <at> gnu.org>
Cc: Sebastian Wiesner <swiesner <at> lunaryorn.com>,
 Oleh Krehel <ohwoeowho <at> gmail.com>
Subject: checkdoc-current-buffer prints to stdout?!
Date: Sat, 06 Jun 2015 11:50:57 -0700

[The following bug report was sent by Sebastian Wiesner to emacs-devel 
<http://lists.gnu.org/archive/html/emacs-devel/2015-06/msg00095.html>.]

Hello,

while debugging unit test failures in Flycheck, I accidentally discovered
checkdoc-current-buffer apparently prints messages to standard output in
Emacs 25.1 in noninteractive mode.

Would you please revert this change?

I can understand the motivation for this “feature”, but it's generally a
bad idea for an interactive function to print text to standard output
depending on an opaque global environment.  It also makes backwards
compatibility harder than it needs to be:  As things stand I have no choice
but to check the Emacs version to print Checkdoc Errors in a consistent way
across Emacs major versions, and that is somewhat ugly.

The purpose of this feature would also be served by a different entry
point—we have `ert-run-tests-interactively` and `ert-run-tests-batch`,
too.  If that is impossible please at least expose an option to turn this
feature off.

On a related topic, I'd have fixed this issue much faster, had this change
been mentioned in the NEWS.  Would you please be more strict about updating
NEWS for breaking changes such as this?

Sincerely,
Sebastian Wiesner

[Message part 3 (message/rfc822, inline)]

From: Oleh Krehel <ohwoeowho <at> gmail.com>
To: Sebastian Wiesner <swiesner <at> lunaryorn.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 20754-done <at> debbugs.gnu.org
Subject: Re: bug#20754: checkdoc-current-buffer prints to stdout?!
Date: Mon, 08 Jun 2015 11:33:00 +0200

Sebastian Wiesner <swiesner <at> lunaryorn.com> writes:

> 2015-06-08 8:35 GMT+02:00 Oleh Krehel <ohwoeowho <at> gmail.com>:
>
>     Sebastian Wiesner <swiesner <at> lunaryorn.com> writes:
>     
>     > Why can't you just leave checkdoc-current-buffer as is, and
>     introduce
>     > a new entry point?
>     
>     Done. Also added a NEWS entry.
>     
>
> Thank you very much! That's a nice change which benefits Flycheck, and
> will make checkdoc easier as soon as Flycheck drops Emacs 24
> compatibility.

You're welcome, marking as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.