From unknown Sun Jun 22 15:25:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20753: coreutils failed to compile Resent-From: Masanari Iida Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 06 Jun 2015 17:12:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: 20753@debbugs.gnu.org, bug-gnulib@gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org, bug-gnulib@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.143361071210928 (code B ref -1); Sat, 06 Jun 2015 17:12:05 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jun 2015 17:11:52 +0000 Received: from localhost ([127.0.0.1]:43408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1HdP-0002q6-Uo for submit@debbugs.gnu.org; Sat, 06 Jun 2015 13:11:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50857) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1EQH-0006Tm-Jh for submit@debbugs.gnu.org; Sat, 06 Jun 2015 09:46:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1EQB-0007ZD-32 for submit@debbugs.gnu.org; Sat, 06 Jun 2015 09:46:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1EQB-0007Z9-0e for submit@debbugs.gnu.org; Sat, 06 Jun 2015 09:45:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1EQ9-0000BW-VD for bug-coreutils@gnu.org; Sat, 06 Jun 2015 09:45:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1EQ9-0007YV-3K for bug-coreutils@gnu.org; Sat, 06 Jun 2015 09:45:57 -0400 Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:34841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1EQ6-0007XM-4Q; Sat, 06 Jun 2015 09:45:54 -0400 Received: by oiax69 with SMTP id x69so414628oia.2; Sat, 06 Jun 2015 06:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=D6zH+LtPoxK/NEsJaPPRRDGYX82VPRVgjO1enBOUPCs=; b=O01Oa6/eo/l4Cijx84+gHazzWzIwHkccKPU/zcGf3nDnXq0k+zTgG/FqScucJFKE4+ xbJYd5Qc28F5n88so96/EMPwaMVfMt60E6b4MvIiF9SFTdYyIuz/LCMAhdAmR+6MaQyr P5AdZkM7J48XSr8no9Ns9R2kcFccAN9TVMY82sI7lodu0/0omXEmeyHahq1omd/O+v/y 3kAQaas42inO1jZv8KOq9cvzJi8fOGmBp87ueOS0Piq3JesxxEBqZXRj8uPwtUHS7IGe d3jC93dCjqdxOpDuUpqYn7R8wB616S8lE0mRn2caEbod667f2bCnCJR/kyI3520k44L7 8ZEw== MIME-Version: 1.0 X-Received: by 10.60.92.198 with SMTP id co6mr7196331oeb.3.1433598351646; Sat, 06 Jun 2015 06:45:51 -0700 (PDT) Received: by 10.76.116.2 with HTTP; Sat, 6 Jun 2015 06:45:51 -0700 (PDT) Date: Sat, 6 Jun 2015 22:45:51 +0900 Message-ID: From: Masanari Iida Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Mailman-Approved-At: Sat, 06 Jun 2015 13:11:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Current head of coreutil git tree ( 079652ee6b5d3) faile to compile. My environment Fedora 20 (x86_64) GEN src/version.h make all-recursive make[1]: Entering directory `/home/iida/Repo/coreutils' Making all in po make[2]: Entering directory `/home/iida/Repo/coreutils/po' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/iida/Repo/coreutils/po' Making all in . make[2]: Entering directory `/home/iida/Repo/coreutils' test -f doc/.dirstamp || make doc/.dirstamp Updating ./doc/version.texi CC lib/copy-acl.o CC lib/set-acl.o CC lib/acl-errno-valid.o CC lib/acl-internal.o lib/acl-internal.c: In function 'free_permission_context': lib/acl-internal.c:472:1: error: function might be candidate for attribute 'const' [-Werror=3Dsuggest-attribute=3Dconst] free_permission_context (struct permission_context *ctx) ^ Bisect shows following commit is the first bad. [iida@localhsot coreutils ((d796a29...)|BISECTING)]$ git bisect good 44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd is the first bad commit commit 44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd Author: P=C3=A1draig Brady Date: Tue Jun 2 01:25:05 2015 +0100 build: update to latest gnulib Mainly with build fixes for Mac OS X. :160000 160000 2aea2c723359d9459fd01e7b428f47656c9ce1e9 98aa8776dd2b510b7f777870fb76b17fd88abbef M gnulib [iida@localhost coreutils ((d796a29...)|BISECTING)]$ git bisect log git bisect start # bad: [079652ee6b5d3987525ce225518a15253fc9d319] build: port to AIX git bisect bad 079652ee6b5d3987525ce225518a15253fc9d319 # good: [1aa71d96332ec210a8c954cc924d43655f2b369f] tests: ln/hard-to-sym FAIL rather than ERROR when ln fails git bisect good 1aa71d96332ec210a8c954cc924d43655f2b369f # bad: [44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd] build: update to latest g= nulib git bisect bad 44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd # good: [b9842a615366b47cbd0739d97f2dd2679dfbb3a8] maint: avoid new coverity warnings git bisect good b9842a615366b47cbd0739d97f2dd2679dfbb3a8 # good: [d796a29f2fb92f74d73d0aa27c86caf58d753f46] tests: fix race in tail test without inotify git bisect good d796a29f2fb92f74d73d0aa27c86caf58d753f46 # first bad commit: [44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd] build: update to latest gnulib Regards, Masanari iida From unknown Sun Jun 22 15:25:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20753: coreutils failed to compile Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 06 Jun 2015 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: standby24x7@gmail.com, 20753@debbugs.gnu.org, bug-gnulib@gnu.org X-Debbugs-Original-To: Masanari Iida , bug-coreutils@gnu.org, bug-gnulib@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.143361615322867 (code B ref -1); Sat, 06 Jun 2015 18:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jun 2015 18:42:33 +0000 Received: from localhost ([127.0.0.1]:43463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1J3A-0005wl-VP for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:42:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56188) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1J38-0005wX-NQ for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:42:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1J32-0005vk-TH for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:42:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1J32-0005va-QO for submit@debbugs.gnu.org; Sat, 06 Jun 2015 14:42:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1J31-0000yi-T0 for bug-coreutils@gnu.org; Sat, 06 Jun 2015 14:42:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1J2y-0005tq-Mv for bug-coreutils@gnu.org; Sat, 06 Jun 2015 14:42:23 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1J2y-0005ta-HJ; Sat, 06 Jun 2015 14:42:20 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 87E171606CF; Sat, 6 Jun 2015 11:42:19 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id u4CiRWzRd_Rk; Sat, 6 Jun 2015 11:42:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CAC681606DC; Sat, 6 Jun 2015 11:42:18 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pLo5LHNHRmEZ; Sat, 6 Jun 2015 11:42:18 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A17F21606CF; Sat, 6 Jun 2015 11:42:18 -0700 (PDT) Message-ID: <55733F0A.2000704@cs.ucla.edu> Date: Sat, 06 Jun 2015 11:42:18 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------060906060803020309050001" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------060906060803020309050001 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks, does the attached (untested) patch fix things for you? --------------060906060803020309050001 Content-Type: text/x-patch; name="acl.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="acl.patch" diff --git a/lib/acl-internal.h b/lib/acl-internal.h index 11fdea1..d592a75 100644 --- a/lib/acl-internal.h +++ b/lib/acl-internal.h @@ -289,6 +289,10 @@ struct permission_context { int get_permissions (const char *, int, mode_t, struct permission_context *); int set_permissions (struct permission_context *, const char *, int); -void free_permission_context (struct permission_context *); +void free_permission_context (struct permission_context *) +#if ! (defined USE_ACL && (HAVE_ACL_GET_FILE || defined GETACL)) + _GL_ATTRIBUTE_CONST +#endif + ; _GL_INLINE_HEADER_END --------------060906060803020309050001-- From unknown Sun Jun 22 15:25:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20753: coreutils failed to compile Resent-From: Masanari Iida Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 07 Jun 2015 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20753 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: To: Paul Eggert Cc: bug-gnulib@gnu.org, 20753@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnulib@gnu.org, bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.143363529325190 (code B ref -1); Sun, 07 Jun 2015 00:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jun 2015 00:01:33 +0000 Received: from localhost ([127.0.0.1]:43563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1O1t-0006YE-0n for submit@debbugs.gnu.org; Sat, 06 Jun 2015 20:01:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46501) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1O1r-0006Y1-8J for submit@debbugs.gnu.org; Sat, 06 Jun 2015 20:01:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1O1l-0007o3-4t for submit@debbugs.gnu.org; Sat, 06 Jun 2015 20:01:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_20, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52300) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1O1l-0007nz-1S for submit@debbugs.gnu.org; Sat, 06 Jun 2015 20:01:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1O1k-0001uO-CW for bug-coreutils@gnu.org; Sat, 06 Jun 2015 20:01:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1O1j-0007nP-Dr for bug-coreutils@gnu.org; Sat, 06 Jun 2015 20:01:24 -0400 Received: from mail-ig0-x22e.google.com ([2607:f8b0:4001:c05::22e]:36694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1O1h-0007hw-G9; Sat, 06 Jun 2015 20:01:21 -0400 Received: by igbpi8 with SMTP id pi8so39130661igb.1; Sat, 06 Jun 2015 17:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MFmeEsq3dWs8aXNyiZWxAMJWVAkBPyuPeAeisBpu+xw=; b=nVWAqYlvi9YFcMV1KX/PgKxkivEzSwoV+y2V0d8MxHV5eeXT4n6PPgi23W5WChevx9 lvrJAzINDbER+GMoGxUdFxhV5IDaAEThCDGeaN0YtbwFJRAo3Xiyid+rtyVEXt4S6TJR o4WHn/vKrkv05mblof8qXCuY4xqdtF4NZEltrDCv/X2nLm1ppYDTgLRWdN9VykVTOo8B 5GXkK+mHr/czKm5KiNSvAJNTcG2ErLKgx0lz6NTmOqEuljnyFo0jX6cvnFuedcYm7EiH 07od33l0GMyI+2PPTeKCNnc4ho3MBifWI9lpOq3JnwioabreNpxFn4LdIO2VmKW2OIwQ p88Q== MIME-Version: 1.0 X-Received: by 10.43.116.196 with SMTP id fj4mr16948950icc.38.1433635280967; Sat, 06 Jun 2015 17:01:20 -0700 (PDT) Received: by 10.36.113.6 with HTTP; Sat, 6 Jun 2015 17:01:20 -0700 (PDT) In-Reply-To: <55733F0A.2000704@cs.ucla.edu> References: <55733F0A.2000704@cs.ucla.edu> Date: Sun, 7 Jun 2015 09:01:20 +0900 Message-ID: From: Masanari Iida Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Hello. Your patch fix my build problem. Before apply the patch, i have confirmed current head (3150ec900c4b8f84978ca4fb80eb109ae0df875c) didn't fix the symptom. Then make a branch and apply your path on top of it. Then compile it again. I have confirmed it worked. Regards, Masanari Iida On Sun, Jun 7, 2015 at 3:42 AM, Paul Eggert wrote: > Thanks, does the attached (untested) patch fix things for you? From unknown Sun Jun 22 15:25:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Masanari Iida Subject: bug#20753: closed (Re: coreutils failed to compile) Message-ID: References: <55739D0A.4010606@cs.ucla.edu> X-Gnu-PR-Message: they-closed 20753 X-Gnu-PR-Package: coreutils Reply-To: 20753@debbugs.gnu.org Date: Sun, 07 Jun 2015 01:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1433640242-32484-1" This is a multi-part message in MIME format... ------------=_1433640242-32484-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20753: coreutils failed to compile which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20753@debbugs.gnu.org. --=20 20753: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20753 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1433640242-32484-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20753-done) by debbugs.gnu.org; 7 Jun 2015 01:23:30 +0000 Received: from localhost ([127.0.0.1]:43617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1PJC-0008RC-9F for submit@debbugs.gnu.org; Sat, 06 Jun 2015 21:23:30 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52887) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1PJB-0008Qy-5L for 20753-done@debbugs.gnu.org; Sat, 06 Jun 2015 21:23:29 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 944CA1606D4; Sat, 6 Jun 2015 18:23:23 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QcsqY6-AQvHQ; Sat, 6 Jun 2015 18:23:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 941651606C6; Sat, 6 Jun 2015 18:23:22 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HR0_q3LiObdL; Sat, 6 Jun 2015 18:23:22 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 723AC160672; Sat, 6 Jun 2015 18:23:22 -0700 (PDT) Message-ID: <55739D0A.4010606@cs.ucla.edu> Date: Sat, 06 Jun 2015 18:23:22 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Masanari Iida Subject: Re: coreutils failed to compile References: <55733F0A.2000704@cs.ucla.edu> In-Reply-To: Content-Type: multipart/mixed; boundary="------------090900000804000304040503" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20753-done Cc: 20753-done@debbugs.gnu.org, bug-gnulib@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------090900000804000304040503 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit OK, thanks, I installed the attached patch into gnulib and am marking the bug as fixed. --------------090900000804000304040503 Content-Type: text/x-patch; name="0001-acl-permissions-pacify-Wsuggest-attribute-const.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-acl-permissions-pacify-Wsuggest-attribute-const.patch" >From 64910190567221ed14fc0c7c6739b2802aeac613 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 6 Jun 2015 18:20:40 -0700 Subject: [PATCH] acl-permissions: pacify -Wsuggest-attribute=const Problem reported by Masanari Iida in: http://bugs.gnu.org/20753 * lib/acl-internal.h (free_permission_context): Declare with attribute const if ! (defined USE_ACL && (HAVE_ACL_GET_FILE || defined GETACL)). --- ChangeLog | 6 ++++++ lib/acl-internal.h | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index a215c03..64b9de1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2015-06-06 Paul Eggert + acl-permissions: pacify -Wsuggest-attribute=const + Problem reported by Masanari Iida in: http://bugs.gnu.org/20753 + * lib/acl-internal.h (free_permission_context): + Declare with attribute const if ! (defined USE_ACL && + (HAVE_ACL_GET_FILE || defined GETACL)). + fsync: document AIX misbehavior * doc/posix-functions/fsync.texi (fsync): Document failure on AIX with read-only file descriptor. diff --git a/lib/acl-internal.h b/lib/acl-internal.h index 11fdea1..d592a75 100644 --- a/lib/acl-internal.h +++ b/lib/acl-internal.h @@ -289,6 +289,10 @@ struct permission_context { int get_permissions (const char *, int, mode_t, struct permission_context *); int set_permissions (struct permission_context *, const char *, int); -void free_permission_context (struct permission_context *); +void free_permission_context (struct permission_context *) +#if ! (defined USE_ACL && (HAVE_ACL_GET_FILE || defined GETACL)) + _GL_ATTRIBUTE_CONST +#endif + ; _GL_INLINE_HEADER_END -- 2.1.0 --------------090900000804000304040503-- ------------=_1433640242-32484-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Jun 2015 17:11:52 +0000 Received: from localhost ([127.0.0.1]:43408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1HdP-0002q6-Uo for submit@debbugs.gnu.org; Sat, 06 Jun 2015 13:11:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50857) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1EQH-0006Tm-Jh for submit@debbugs.gnu.org; Sat, 06 Jun 2015 09:46:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1EQB-0007ZD-32 for submit@debbugs.gnu.org; Sat, 06 Jun 2015 09:46:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1EQB-0007Z9-0e for submit@debbugs.gnu.org; Sat, 06 Jun 2015 09:45:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1EQ9-0000BW-VD for bug-coreutils@gnu.org; Sat, 06 Jun 2015 09:45:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1EQ9-0007YV-3K for bug-coreutils@gnu.org; Sat, 06 Jun 2015 09:45:57 -0400 Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:34841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1EQ6-0007XM-4Q; Sat, 06 Jun 2015 09:45:54 -0400 Received: by oiax69 with SMTP id x69so414628oia.2; Sat, 06 Jun 2015 06:45:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=D6zH+LtPoxK/NEsJaPPRRDGYX82VPRVgjO1enBOUPCs=; b=O01Oa6/eo/l4Cijx84+gHazzWzIwHkccKPU/zcGf3nDnXq0k+zTgG/FqScucJFKE4+ xbJYd5Qc28F5n88so96/EMPwaMVfMt60E6b4MvIiF9SFTdYyIuz/LCMAhdAmR+6MaQyr P5AdZkM7J48XSr8no9Ns9R2kcFccAN9TVMY82sI7lodu0/0omXEmeyHahq1omd/O+v/y 3kAQaas42inO1jZv8KOq9cvzJi8fOGmBp87ueOS0Piq3JesxxEBqZXRj8uPwtUHS7IGe d3jC93dCjqdxOpDuUpqYn7R8wB616S8lE0mRn2caEbod667f2bCnCJR/kyI3520k44L7 8ZEw== MIME-Version: 1.0 X-Received: by 10.60.92.198 with SMTP id co6mr7196331oeb.3.1433598351646; Sat, 06 Jun 2015 06:45:51 -0700 (PDT) Received: by 10.76.116.2 with HTTP; Sat, 6 Jun 2015 06:45:51 -0700 (PDT) Date: Sat, 6 Jun 2015 22:45:51 +0900 Message-ID: Subject: coreutils failed to compile From: Masanari Iida To: bug-coreutils@gnu.org, bug-gnulib@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 06 Jun 2015 13:11:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Current head of coreutil git tree ( 079652ee6b5d3) faile to compile. My environment Fedora 20 (x86_64) GEN src/version.h make all-recursive make[1]: Entering directory `/home/iida/Repo/coreutils' Making all in po make[2]: Entering directory `/home/iida/Repo/coreutils/po' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/iida/Repo/coreutils/po' Making all in . make[2]: Entering directory `/home/iida/Repo/coreutils' test -f doc/.dirstamp || make doc/.dirstamp Updating ./doc/version.texi CC lib/copy-acl.o CC lib/set-acl.o CC lib/acl-errno-valid.o CC lib/acl-internal.o lib/acl-internal.c: In function 'free_permission_context': lib/acl-internal.c:472:1: error: function might be candidate for attribute 'const' [-Werror=3Dsuggest-attribute=3Dconst] free_permission_context (struct permission_context *ctx) ^ Bisect shows following commit is the first bad. [iida@localhsot coreutils ((d796a29...)|BISECTING)]$ git bisect good 44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd is the first bad commit commit 44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd Author: P=C3=A1draig Brady Date: Tue Jun 2 01:25:05 2015 +0100 build: update to latest gnulib Mainly with build fixes for Mac OS X. :160000 160000 2aea2c723359d9459fd01e7b428f47656c9ce1e9 98aa8776dd2b510b7f777870fb76b17fd88abbef M gnulib [iida@localhost coreutils ((d796a29...)|BISECTING)]$ git bisect log git bisect start # bad: [079652ee6b5d3987525ce225518a15253fc9d319] build: port to AIX git bisect bad 079652ee6b5d3987525ce225518a15253fc9d319 # good: [1aa71d96332ec210a8c954cc924d43655f2b369f] tests: ln/hard-to-sym FAIL rather than ERROR when ln fails git bisect good 1aa71d96332ec210a8c954cc924d43655f2b369f # bad: [44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd] build: update to latest g= nulib git bisect bad 44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd # good: [b9842a615366b47cbd0739d97f2dd2679dfbb3a8] maint: avoid new coverity warnings git bisect good b9842a615366b47cbd0739d97f2dd2679dfbb3a8 # good: [d796a29f2fb92f74d73d0aa27c86caf58d753f46] tests: fix race in tail test without inotify git bisect good d796a29f2fb92f74d73d0aa27c86caf58d753f46 # first bad commit: [44f08f240e69e062fd8f0ac33f2a2e0e07a2a3cd] build: update to latest gnulib Regards, Masanari iida ------------=_1433640242-32484-1--