From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 05 11:21:52 2015 Received: (at submit) by debbugs.gnu.org; 5 Jun 2015 15:21:52 +0000 Received: from localhost ([127.0.0.1]:41979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0tRP-00064b-JK for submit@debbugs.gnu.org; Fri, 05 Jun 2015 11:21:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34425) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0mWX-0002Nl-MC for submit@debbugs.gnu.org; Fri, 05 Jun 2015 03:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0mWR-0005o3-3j for submit@debbugs.gnu.org; Fri, 05 Jun 2015 03:58:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0mWR-0005ny-0A for submit@debbugs.gnu.org; Fri, 05 Jun 2015 03:58:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0mWP-0007Ak-OO for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 03:58:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0mWO-0005mN-AQ for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 03:58:33 -0400 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:34276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0mWO-0005lf-2L for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2015 03:58:32 -0400 Received: by laew7 with SMTP id w7so48419595lae.1 for ; Fri, 05 Jun 2015 00:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=zxnRxnTg6ubI0BnBcS7YiYHT+IDADdZ8zxk09ZeMpCQ=; b=n+Br4Zq7wexgKpwBQH+SxxD1CPYj6E/pLtkUODqQrqKAoaru17TCFPD+DlmH0HI2fq 9+FsCeoB+b7njypKkXfisPpvJaxNK7i+tubJH5dkkW7/4sIisdpV7sTzKlgsHjqMPOA7 c/rlNeZdPdT90tnbTLcVAFeyqMvdxEPXhLlOHed+Kb61xrBm99u4SnaGyQQRccCCqfSA a33xKRJBzHh1WtdlfkD5RTyrXXUMNTwm5tXKNRWC87v1ESUi5tfTQ3dDEEti8DmIZvQw MCydGHVAGGLaNo7G+f3UhBa6f1bPgbj+pPuvvbfL4PJp5cWaPwIPmFqHTNF//Nyjbd9y WyRQ== MIME-Version: 1.0 X-Received: by 10.152.3.97 with SMTP id b1mr2155572lab.54.1433491110107; Fri, 05 Jun 2015 00:58:30 -0700 (PDT) Received: by 10.112.113.165 with HTTP; Fri, 5 Jun 2015 00:58:30 -0700 (PDT) Date: Fri, 5 Jun 2015 09:58:30 +0200 X-Google-Sender-Auth: A86WvD0L7TocG6pA9S_IekCsKv4 Message-ID: Subject: 24.5; python mode indentation fails pep8 From: Tommi Komulainen To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 05 Jun 2015 11:21:50 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The automatic indentation and manual reindenting with indent-according-to-mode puts the closing bracket in wrong place that makes pep8/flake8 flycheck complain: print("hello", "world", ) E124 closing bracket does not match visual indentation The bracket needs to align with the first thing after the opening bracket if it's on the same line i.e.: print("hello", "world", ) The automatic indentation doesn't cause any errors if there's a newline after the opening bracket though: print( "hello", "world", ) In GNU Emacs 24.5.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.16.2) of 2015-04-22 on buildhw-10.phx2.fedoraproject.org Windowing system distributor `Fedora Project', version 11.0.11701000 System Description: Fedora release 22 (Twenty Two) Configured using: `configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-dbus --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=gtk3 --with-gpm=no build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' LDFLAGS=-Wl,-z,relro' Important settings: value of $LANG: en_US.utf8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Python Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. (New file) Can't guess python-indent-offset, using defaults: 4 python-indent--calculate-indentation: Wrong type argument: number-or-marker-p, nil [2 times] Making completion list... python-indent--calculate-indentation: Wrong type argument: number-or-marker-p, nil [2 times] Making completion list... user-error: End of history; no default available [2 times] Making completion list... Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils help-mode python easymenu json comint ring cl-loaddefs cl-lib ansi-color time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) Memory information: ((conses 16 81480 5832) (symbols 48 18574 0) (miscs 40 39 124) (strings 32 12163 4670) (string-bytes 1 364259) (vectors 16 10283) (vector-slots 8 394463 9319) (floats 8 66 386) (intervals 56 243 1) (buffers 960 13) (heap 1024 32872 1101)) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 05 16:16:46 2015 Received: (at 20742) by debbugs.gnu.org; 5 Jun 2015 20:16:47 +0000 Received: from localhost ([127.0.0.1]:42187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0y2o-000681-G7 for submit@debbugs.gnu.org; Fri, 05 Jun 2015 16:16:46 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:36622 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0y2m-00067t-Fu for 20742@debbugs.gnu.org; Fri, 05 Jun 2015 16:16:44 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1Z0y2j-0003lg-Ux; Fri, 05 Jun 2015 16:16:42 -0400 From: Glenn Morris To: Tommi Komulainen Subject: Re: bug#20742: 24.5; python mode indentation fails pep8 References: X-Spook: weapons of mass destruction Lexis-Nexis Kidnap San Diego X-Ran: &n2iW`"E/owkjBkrx7*)Ri]gsK!;v=G5J%6f/B*o}Z$>v,hbYM~W(_Ih#skyVQ4g@W:&np X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 05 Jun 2015 16:16:41 -0400 In-Reply-To: (Tommi Komulainen's message of "Fri, 5 Jun 2015 09:58:30 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 20742 Cc: 20742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Tommi Komulainen wrote: > python-indent--calculate-indentation: Wrong type argument: > number-or-marker-p, nil [2 times] Perhaps the behaviour is not intended. (Related to bug#20560?) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 05 16:26:15 2015 Received: (at 20742) by debbugs.gnu.org; 5 Jun 2015 20:26:15 +0000 Received: from localhost ([127.0.0.1]:42204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0yBx-0006MR-Ob for submit@debbugs.gnu.org; Fri, 05 Jun 2015 16:26:14 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:33770) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0yBu-0006Lv-Lx for 20742@debbugs.gnu.org; Fri, 05 Jun 2015 16:26:11 -0400 Received: by lbcue7 with SMTP id ue7so52572162lbc.0 for <20742@debbugs.gnu.org>; Fri, 05 Jun 2015 13:26:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=dSKMIFzuvPW2S9vrJoEx3Cgj0aB8BITLvG9HQpRDtak=; b=ZF71wKmuA69Lw8IxBztw9i3wGTL/xWsftoLETR53WLotOW0vxGOEnlB+qylvGELKh7 /qNcwfRVjo5uvveDkR+VXpOFeqyLkMwD3ykEeamI+Ad822l4/d6sgee86rQl/uEliwX7 xu/ijZEybJOtzAQ2t7O1vwHjttc7w/xZLzDMj66FMZeeiFJofMvzKzyCsT1LOPbubiJN cuhEnYMzI6lw5of2N86zJTFD0jfndWum5C0ZopDh1jQuD2Z6dVKPG+jsru9qckkKVEE4 JQFE3Qxf3hz4vz07VPOW3HWs9SwwtBz2fCfivZ5FC/UE+jU1MUOYdJmPz8W5Tsob9l6+ 93Sg== X-Received: by 10.152.198.135 with SMTP id jc7mr4948367lac.48.1433535964691; Fri, 05 Jun 2015 13:26:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tommi Komulainen Date: Fri, 05 Jun 2015 20:25:54 +0000 Message-ID: Subject: Re: bug#20742: 24.5; python mode indentation fails pep8 To: Glenn Morris Content-Type: multipart/alternative; boundary=001a113481e8f2c6f70517cb192c X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20742 Cc: 20742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a113481e8f2c6f70517cb192c Content-Type: text/plain; charset=UTF-8 That's almost certainly me having the cursor after the closing bracket rather than on top of it while double-checking the indentation on each line. Best I can tell it made no difference to the indentation. The other bug is closely related when the opening bracket is *not* followed by newline, though I can't immediately say if either of the possible indentations is preferred or an error according to pep8. On Fri, 5 Jun 2015 at 22:16 Glenn Morris wrote: > Tommi Komulainen wrote: > > > python-indent--calculate-indentation: Wrong type argument: > > number-or-marker-p, nil [2 times] > > Perhaps the behaviour is not intended. > (Related to bug#20560?) > --001a113481e8f2c6f70517cb192c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
That's almost certainly me having the cursor after the= closing bracket rather than on top of it while double-checking the indenta= tion on each line. Best I can tell it made no difference to the indentation= .

The other bug is closely related when the opening = bracket is *not* followed by newline, though I can't immediately say if= either of the possible indentations is preferred or an error according to = pep8.

On Fri, 5 = Jun 2015 at 22:16 Glenn Morris <rgm@gnu.o= rg> wrote:
Tommi Komulainen = wrote:

> python-indent--calculate-indentation: Wrong type argument:
> number-or-marker-p, nil [2 times]

Perhaps the behaviour is not intended.
(Related to bug#20560?)
--001a113481e8f2c6f70517cb192c-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 12:31:36 2015 Received: (at submit) by debbugs.gnu.org; 8 Jun 2015 16:31:36 +0000 Received: from localhost ([127.0.0.1]:45400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1zxX-0001Js-PV for submit@debbugs.gnu.org; Mon, 08 Jun 2015 12:31:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36548) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1zxV-0001Jf-W4 for submit@debbugs.gnu.org; Mon, 08 Jun 2015 12:31:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1zxK-0006dT-4R for submit@debbugs.gnu.org; Mon, 08 Jun 2015 12:31:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1zxK-0006bE-2K for submit@debbugs.gnu.org; Mon, 08 Jun 2015 12:31:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1zuu-0000Po-LH for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2015 12:28:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1zuq-0003Cd-Ga for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2015 12:28:52 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:64632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1zup-0003A1-PH for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2015 12:28:48 -0400 Received: from [192.168.178.31] ([95.119.46.238]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0MUxEy-1YYIMr2y6e-00Y7yj for ; Mon, 08 Jun 2015 18:28:45 +0200 Message-ID: <5575C2B1.1090609@easy-emacs.de> Date: Mon, 08 Jun 2015 18:28:33 +0200 From: =?UTF-8?B?QW5kcmVhcyBSw7ZobGVy?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Re: bug#20742: 24.5; python mode indentation fails pep8 References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:iWoYM9hmUI45zh+Vir3tEKceSIEfb1rEU5YEX05ocTkFEeH/4Pi C3sm2XicWRLOelGeEhq1ugm9/CRqm6YRhydE/j/Y4Sr9diCiUMxEAHAJZtUK1AnIL2Zdl57 FsMH9C6c6W/DFqnw2NmsY6KOrC2y64M5ian1RxtVpTs6vaFxpxO19Jh+mceyIRnUYJHSw/Q 21otpoCtDXNC8PtAvhhZw== X-UI-Out-Filterresults: notjunk:1;V01:K0:N7Yu8Ayi8NA=:IEfks/1m7XwN3LT6im1bBa jV3/23GzhG3llXWe8Fav0mgDNutnNIWdOGuPRNImktcqCIrsNwL1zuZ/Dv0GTIj/7TX80qaQg vnvR4dj29zRtYoyrK+5eeBrMsKhQOSdE7yUxHVwvi3EqQIV/MDninTMSxiWeWG65IXePiDE90 iOzg+u4KaIjRMsL1eEd92XQcDX32Yy1qDsg6Md8GuQDIUZCfjnnPtG/xq1CERlqGJt19dLr8C H9leoXgEKnk/0EdvfwWpzE9rdQVNMgMl5jYH42yoQaStm3vdpEt46ikRS6kntS5Tu8Iv4Tv6a c56C6yjuvFH/F2YS4aVP83fLpgCCsk1r2f+B4g2ej4vazPOMuG5JFAK2XS0CumRsliVpjMOqy FiGHHpcRXNaeb6vk1s1auoR/qEBtFwvSHsDydBZR99z71y3zeOHe6un4mQIcdmMHcOQKAxFTe wDF4Z3484Rio2f/1D0HWtvVu+t5zUVdEqoYj9r73laP1mepkId6vvARksZvwtNp++3VB8rffs eVtgzDURDhVZSfCleFZAyZwNrUGJK7x2KuKPxK20v6H2JAT+eM16TG32o1+Sjez6H62N9cNSB 2lJoOAdLBge+NT3bL7HO4NcjCm5dRqVeVQXH2e7zUxa5sQO2UE6b85o1fn0KfT1yY5B0uIJvS wJ6KZlllLUHuRtND4/fMR6kwGIk9W4ktUm3jVLTnv+1yWe4imgEKfJJ9S9/UM5Ew5ERQmBBzj 28ZX/JcQezRf22gogaKSzjJIxPfbEMlw5686fgTWN4+tcByie7WysHCRz1E= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Am 05.06.2015 um 09:58 schrieb Tommi Komulainen: May confirm that bug GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.23) of 2015-06-07 From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 19 13:04:27 2015 Received: (at 20742) by debbugs.gnu.org; 19 Jun 2015 17:04:27 +0000 Received: from localhost ([127.0.0.1]:52165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5ziM-0003Ef-49 for submit@debbugs.gnu.org; Fri, 19 Jun 2015 13:04:26 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:35283) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5ziK-0003ER-30 for 20742@debbugs.gnu.org; Fri, 19 Jun 2015 13:04:24 -0400 Received: by lbbwc1 with SMTP id wc1so76027213lbb.2 for <20742@debbugs.gnu.org>; Fri, 19 Jun 2015 10:04:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:from:date:message-id:subject:to:content-type; bh=IhlK2K6k7fOFEAJHnXxg6WKBe2OUk2mhbRN/xt+H8J0=; b=V9Ho5eA98AIz/r08jX6n89vcADGyIYRfukrfepAoIbR234818lONIP9f7kEsBFYs8C G/Eof7RrLvuR6QPl8VPn8NE7YizzSONdclRiEVt556WEVOpPWdmZIRGIpZNnp8csgj5w m2QUJvkiWQyvfLMx+GDdHSurGhKxTl8KVpIy7hkQWFjvS3DxiyZ5wtNTSUGJSZtpn9xj dB0Hy15v6IoyxV3LCoHaxIIZgBZANatjF+ocf5keGp757jU+BZbok5n7t6422EKHlC/1 BzDdrNJMG52fD0hMimU4t0npt5FQCllmauymef9hA7mHKY2VPtBSn/zLIJfPsKKWdLSd 3l7g== X-Received: by 10.152.121.42 with SMTP id lh10mr2611863lab.0.1434733458212; Fri, 19 Jun 2015 10:04:18 -0700 (PDT) MIME-Version: 1.0 From: Tommi Komulainen Date: Fri, 19 Jun 2015 17:04:07 +0000 Message-ID: Subject: Testcase for #20742 To: "20742@debbugs.gnu.org" <20742@debbugs.gnu.org> Content-Type: multipart/mixed; boundary=089e011774851fea620518e1eacf X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20742 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e011774851fea620518e1eacf Content-Type: multipart/alternative; boundary=089e011774851fea5a0518e1eacd --089e011774851fea5a0518e1eacd Content-Type: text/plain; charset=UTF-8 Patch against emacs-24.5 branch to update the tests to check the closing paren indentation as well. --089e011774851fea5a0518e1eacd Content-Type: text/html; charset=UTF-8
Patch against emacs-24.5 branch to update the tests to check the closing paren indentation as well.
--089e011774851fea5a0518e1eacd-- --089e011774851fea620518e1eacf Content-Type: application/octet-stream; name="0001-update-python-tests.el-for-pep8-indentation.patch" Content-Disposition: attachment; filename="0001-update-python-tests.el-for-pep8-indentation.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 14e0cc3f3687abb84371 RnJvbSAzN2Y1NmRkNDhiYTZjMjE0NTU2ODEwODU1NzlhODcyYWViMjY3MDM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21taSBLb211bGFpbmVuIDx0b21taS5rb211bGFpbmVuQGlr aS5maT4KRGF0ZTogRnJpLCAxOSBKdW4gMjAxNSAxODo1Mzo1MiArMDIwMApTdWJqZWN0OiBbUEFU Q0hdIHVwZGF0ZSBweXRob24tdGVzdHMuZWwgZm9yIHBlcDggaW5kZW50YXRpb24KCkFkZCAoZmFp bGluZykgdGVzdCBmb3IgY2xvc2luZyBwYXJlbiBpbmRlbnRhdGlvbiB3aGVuIG9wZW5pbmcgcGFy ZW4gaXMgbm90CmZvbGxvd2VkIGJ5IG5ld2xpbmUuICAjMjA3NDIKLS0tCiB0ZXN0L2F1dG9tYXRl ZC9weXRob24tdGVzdHMuZWwgfCAxOCArKysrKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Rlc3QvYXV0 b21hdGVkL3B5dGhvbi10ZXN0cy5lbCBiL3Rlc3QvYXV0b21hdGVkL3B5dGhvbi10ZXN0cy5lbApp bmRleCA0MmMyNmZjLi5iMjYzMWM0IDEwMDY0NAotLS0gYS90ZXN0L2F1dG9tYXRlZC9weXRob24t dGVzdHMuZWwKKysrIGIvdGVzdC9hdXRvbWF0ZWQvcHl0aG9uLXRlc3RzLmVsCkBAIC0xNzIsMTUg KzE3MiwxOSBAQCBhbGlxdWEuIgogICAocHl0aG9uLXRlc3RzLXdpdGgtdGVtcC1idWZmZXIKICAg ICIjIEFsaWduZWQgd2l0aCBvcGVuaW5nIGRlbGltaXRlcgogZm9vID0gbG9uZ19mdW5jdGlvbl9u YW1lKHZhcl9vbmUsIHZhcl90d28sCi0gICAgICAgICAgICAgICAgICAgICAgICAgdmFyX3RocmVl LCB2YXJfZm91cikKKyAgICAgICAgICAgICAgICAgICAgICAgICB2YXJfdGhyZWUsIHZhcl9mb3Vy LAorICAgICAgICAgICAgICAgICAgICAgICAgICkKICIKICAgIChzaG91bGQgKGVxIChjYXIgKHB5 dGhvbi1pbmRlbnQtY29udGV4dCkpIDpuby1pbmRlbnQpKQogICAgKHNob3VsZCAoPSAocHl0aG9u LWluZGVudC1jYWxjdWxhdGUtaW5kZW50YXRpb24pIDApKQogICAgKHB5dGhvbi10ZXN0cy1sb29r LWF0ICJmb28gPSBsb25nX2Z1bmN0aW9uX25hbWUodmFyX29uZSwgdmFyX3R3bywiKQogICAgKHNo b3VsZCAoZXEgKGNhciAocHl0aG9uLWluZGVudC1jb250ZXh0KSkgOmFmdGVyLWNvbW1lbnQpKQog ICAgKHNob3VsZCAoPSAocHl0aG9uLWluZGVudC1jYWxjdWxhdGUtaW5kZW50YXRpb24pIDApKQot ICAgKHB5dGhvbi10ZXN0cy1sb29rLWF0ICJ2YXJfdGhyZWUsIHZhcl9mb3VyKSIpCisgICAocHl0 aG9uLXRlc3RzLWxvb2stYXQgInZhcl90aHJlZSwgdmFyX2ZvdXIiKQogICAgKHNob3VsZCAoZXEg KGNhciAocHl0aG9uLWluZGVudC1jb250ZXh0KSkgOmluc2lkZS1wYXJlbikpCisgICAoc2hvdWxk ICg9IChweXRob24taW5kZW50LWNhbGN1bGF0ZS1pbmRlbnRhdGlvbikgMjUpKQorICAgKHB5dGhv bi10ZXN0cy1sb29rLWF0ICIpIikKKyAgIChzaG91bGQgKGVxIChjYXIgKHB5dGhvbi1pbmRlbnQt Y29udGV4dCkpIDppbnNpZGUtcGFyZW4tYXQtY2xvc2luZy1wYXJlbikpCiAgICAoc2hvdWxkICg9 IChweXRob24taW5kZW50LWNhbGN1bGF0ZS1pbmRlbnRhdGlvbikgMjUpKSkpCiAKIChlcnQtZGVm dGVzdCBweXRob24taW5kZW50LXBlcDgtMiAoKQpAQCAtMjE2LDcgKzIyMCw4IEBAIGRlZiBsb25n X2Z1bmN0aW9uX25hbWUoCiAgICAiIyBFeHRyYSBpbmRlbnRhdGlvbiBpcyBub3QgbmVjZXNzYXJ5 LgogZm9vID0gbG9uZ19mdW5jdGlvbl9uYW1lKAogICB2YXJfb25lLCB2YXJfdHdvLAotICB2YXJf dGhyZWUsIHZhcl9mb3VyKQorICB2YXJfdGhyZWUsIHZhcl9mb3VyLAorKQogIgogICAgKHNob3Vs ZCAoZXEgKGNhciAocHl0aG9uLWluZGVudC1jb250ZXh0KSkgOm5vLWluZGVudCkpCiAgICAoc2hv dWxkICg9IChweXRob24taW5kZW50LWNhbGN1bGF0ZS1pbmRlbnRhdGlvbikgMCkpCkBAIC0yMjYs OSArMjMxLDEyIEBAIGZvbyA9IGxvbmdfZnVuY3Rpb25fbmFtZSgKICAgIChweXRob24tdGVzdHMt bG9vay1hdCAidmFyX29uZSwgdmFyX3R3bywiKQogICAgKHNob3VsZCAoZXEgKGNhciAocHl0aG9u LWluZGVudC1jb250ZXh0KSkgOmluc2lkZS1wYXJlbi1uZXdsaW5lLXN0YXJ0KSkKICAgIChzaG91 bGQgKD0gKHB5dGhvbi1pbmRlbnQtY2FsY3VsYXRlLWluZGVudGF0aW9uKSA0KSkKLSAgIChweXRo b24tdGVzdHMtbG9vay1hdCAidmFyX3RocmVlLCB2YXJfZm91cikiKQorICAgKHB5dGhvbi10ZXN0 cy1sb29rLWF0ICJ2YXJfdGhyZWUsIHZhcl9mb3VyIikKICAgIChzaG91bGQgKGVxIChjYXIgKHB5 dGhvbi1pbmRlbnQtY29udGV4dCkpIDppbnNpZGUtcGFyZW4tbmV3bGluZS1zdGFydCkpCi0gICAo c2hvdWxkICg9IChweXRob24taW5kZW50LWNhbGN1bGF0ZS1pbmRlbnRhdGlvbikgNCkpKSkKKyAg IChzaG91bGQgKD0gKHB5dGhvbi1pbmRlbnQtY2FsY3VsYXRlLWluZGVudGF0aW9uKSA0KSkKKyAg IChweXRob24tdGVzdHMtbG9vay1hdCAiKSIpCisgICAoc2hvdWxkIChlcSAoY2FyIChweXRob24t aW5kZW50LWNvbnRleHQpKSA6aW5zaWRlLXBhcmVuLWF0LWNsb3NpbmctcGFyZW4pKQorICAgKHNo b3VsZCAoPSAocHl0aG9uLWluZGVudC1jYWxjdWxhdGUtaW5kZW50YXRpb24pIDApKSkpCiAKIChl cnQtZGVmdGVzdCBweXRob24taW5kZW50LWJhc2UtY2FzZSAoKQogICAiQ2hlY2sgYmFzZSBjYXNl IGRvZXMgbm90IHRyaWdnZXIgZXJyb3JzLiIKLS0gCjIuNC40Cgo= --089e011774851fea620518e1eacf-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 20 06:56:49 2015 Received: (at 20742) by debbugs.gnu.org; 20 Jun 2015 10:56:49 +0000 Received: from localhost ([127.0.0.1]:52472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6GS8-0004fC-Kd for submit@debbugs.gnu.org; Sat, 20 Jun 2015 06:56:49 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:35775) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6GS6-0004ey-7Z for 20742@debbugs.gnu.org; Sat, 20 Jun 2015 06:56:47 -0400 Received: by labko7 with SMTP id ko7so87140407lab.2 for <20742@debbugs.gnu.org>; Sat, 20 Jun 2015 03:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=5PoBF1ZKH/eFUcALa16hXmpY+fEwMIMi0/NdURKEKsI=; b=C3R9hChuk8KrXvbXzDHwSk8AGIzRwL9AKq5GtiYqcbXMVHvPJBWw6lf6z3uabtHXNZ mXKRheu+qIeu0om4X+3XKCbDmo0kAVMXoyFoHmia3tEhTZVhgOxmGhOK2UlB8z4abBvG nZwi4Wg1jhQ0wrGdlFKXWjGhQdvorLtZFq+Nfxt7tuHigaCZ8OGc/RhtlkGJsTSRtiy9 MaRvQhU4uHX6B0mtZAmoYDBX1lU3cLYXMRDx8vpW84de/0D+N1FaTMYrfLddiiYA9xv1 36IejAk/aSoDbYoKGiW6y/PUo34KdSQw513wehRHlLEd/LHvgnd6/ZQnFyKRmlxDOS1F AVSg== MIME-Version: 1.0 X-Received: by 10.152.204.40 with SMTP id kv8mr21475293lac.113.1434797800218; Sat, 20 Jun 2015 03:56:40 -0700 (PDT) Received: by 10.112.113.165 with HTTP; Sat, 20 Jun 2015 03:56:40 -0700 (PDT) Date: Sat, 20 Jun 2015 12:56:40 +0200 X-Google-Sender-Auth: beh1WtPXl1kGBtoRBi787ksWwXg Message-ID: Subject: 24.5; [PATCH] python.el: fix close paren indentation to match pep8 From: Tommi Komulainen To: 20742@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20742 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >From da684af7265bf40e4140328c36011fea6b040373 Mon Sep 17 00:00:00 2001 From: Tommi Komulainen Date: Fri, 19 Jun 2015 18:53:52 +0200 Subject: [PATCH] python.el: fix close paren indentation to match pep8 When opening paren is followed by newline the closing paren should follow the current indentation. Otherwise the closing paren should be aligned with the opening paren. This fixes the latter case. #20742 --- lisp/progmodes/python.el | 12 +++++++++--- test/automated/python-tests.el | 42 +++++++++++++++++++++++++++++++++--------- 2 files changed, 42 insertions(+), 12 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index de2d2d1..013a565 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -952,12 +952,18 @@ possibilities can be narrowed to specific indentation points." (`(,(or :after-line :after-comment :inside-string - :after-backslash - :inside-paren-at-closing-paren - :inside-paren-at-closing-nested-paren) . ,start) + :after-backslash) . ,start) ;; Copy previous indentation. (goto-char start) (current-indentation)) + (`(,(or :inside-paren-at-closing-paren + :inside-paren-at-closing-nested-paren) . ,start) + (goto-char (+ 1 start)) + (if (looking-at "[ \t]*\\(?:#\\|$\\)") + ;; Copy previous indentation. + (current-indentation) + ;; Align with opening paren. + (current-column))) (`(,(or :after-block-start :after-backslash-first-line :inside-paren-newline-start) . ,start) diff --git a/test/automated/python-tests.el b/test/automated/python-tests.el index 42c26fc..f35f188 100644 --- a/test/automated/python-tests.el +++ b/test/automated/python-tests.el @@ -171,16 +171,28 @@ aliqua." "First pep8 case." (python-tests-with-temp-buffer "# Aligned with opening delimiter -foo = long_function_name(var_one, var_two, - var_three, var_four) +foo = long_function_name(var_one=[var_two, # comment + var_three + ], + var_four=0, + ) " (should (eq (car (python-indent-context)) :no-indent)) (should (= (python-indent-calculate-indentation) 0)) - (python-tests-look-at "foo = long_function_name(var_one, var_two,") + (python-tests-look-at "foo = long_function_name(var_one") (should (eq (car (python-indent-context)) :after-comment)) (should (= (python-indent-calculate-indentation) 0)) - (python-tests-look-at "var_three, var_four)") + (python-tests-look-at "var_three") (should (eq (car (python-indent-context)) :inside-paren)) + (should (= (python-indent-calculate-indentation) 34)) + (python-tests-look-at "]") + (should (eq (car (python-indent-context)) :inside-paren-at-closing-nested-paren)) + (should (= (python-indent-calculate-indentation) 34)) + (python-tests-look-at "var_four") + (should (eq (car (python-indent-context)) :inside-paren)) + (should (= (python-indent-calculate-indentation) 25)) + (python-tests-look-at ")") + (should (eq (car (python-indent-context)) :inside-paren-at-closing-paren)) (should (= (python-indent-calculate-indentation) 25)))) (ert-deftest python-indent-pep8-2 () @@ -215,20 +227,32 @@ def long_function_name( (python-tests-with-temp-buffer "# Extra indentation is not necessary. foo = long_function_name( - var_one, var_two, - var_three, var_four) + var_one, var_two=[ # comment + var_three, + ], + var_four=0, +) " (should (eq (car (python-indent-context)) :no-indent)) (should (= (python-indent-calculate-indentation) 0)) (python-tests-look-at "foo = long_function_name(") (should (eq (car (python-indent-context)) :after-comment)) (should (= (python-indent-calculate-indentation) 0)) - (python-tests-look-at "var_one, var_two,") + (python-tests-look-at "var_one") (should (eq (car (python-indent-context)) :inside-paren-newline-start)) (should (= (python-indent-calculate-indentation) 4)) - (python-tests-look-at "var_three, var_four)") + (python-tests-look-at "var_three") (should (eq (car (python-indent-context)) :inside-paren-newline-start)) - (should (= (python-indent-calculate-indentation) 4)))) + (should (= (python-indent-calculate-indentation) 8)) + (python-tests-look-at "]") + (should (eq (car (python-indent-context)) :inside-paren-at-closing-nested-paren)) + (should (= (python-indent-calculate-indentation) 4)) + (python-tests-look-at "var_four") + (should (eq (car (python-indent-context)) :inside-paren-newline-start)) + (should (= (python-indent-calculate-indentation) 4)) + (python-tests-look-at ")") + (should (eq (car (python-indent-context)) :inside-paren-at-closing-paren)) + (should (= (python-indent-calculate-indentation) 0)))) (ert-deftest python-indent-base-case () "Check base case does not trigger errors." -- 2.4.4 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 05 22:16:04 2015 Received: (at control) by debbugs.gnu.org; 6 Jul 2015 02:16:04 +0000 Received: from localhost ([127.0.0.1]:41237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBvwx-0005id-ES for submit@debbugs.gnu.org; Sun, 05 Jul 2015 22:16:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54533) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBvwv-0005i7-Hg for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:16:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBvwk-0003lF-SZ for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:15:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBvwk-0003lA-D3 for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:15:50 -0400 Received: from [190.246.172.180] (port=50837 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZBvwj-0002gl-M2 for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:15:50 -0400 From: fgallina@gnu.org (=?utf-8?Q?Fabi=C3=A1n?= Ezequiel Gallina) To: control@debbugs.gnu.org Subject: 25.0.50; python.el and IPython Date: Sun, 05 Jul 2015 23:15:46 -0300 Message-ID: <87mvzarpyl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) merge 20708 20580 merge 19906 20742 From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 05 22:24:49 2015 Received: (at control) by debbugs.gnu.org; 6 Jul 2015 02:24:49 +0000 Received: from localhost ([127.0.0.1]:41247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBw5Q-0005zZ-Mw for submit@debbugs.gnu.org; Sun, 05 Jul 2015 22:24:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58321) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZBw5O-0005zC-UU for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:24:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZBw5F-0007nN-TT for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:24:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZBw5F-0007nB-Pw for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:24:37 -0400 Received: from [190.246.172.180] (port=50941 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZBw5F-0003jP-4Y for control@debbugs.gnu.org; Sun, 05 Jul 2015 22:24:37 -0400 From: fgallina@gnu.org (=?utf-8?Q?Fabi=C3=A1n?= Ezequiel Gallina) To: control@debbugs.gnu.org Subject: Date: Sun, 05 Jul 2015 23:24:33 -0300 Message-ID: <87io9ykopq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) merge 20560 19906 From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 01 21:46:06 2017 Received: (at 20742) by debbugs.gnu.org; 2 Mar 2017 02:46:06 +0000 Received: from localhost ([127.0.0.1]:35164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjGko-0000yk-17 for submit@debbugs.gnu.org; Wed, 01 Mar 2017 21:46:06 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:36474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjGkl-0000rj-O4 for 20742@debbugs.gnu.org; Wed, 01 Mar 2017 21:46:04 -0500 Received: by mail-it0-f53.google.com with SMTP id h10so109601675ith.1 for <20742@debbugs.gnu.org>; Wed, 01 Mar 2017 18:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CDc0nv2t1vci7kw/XeRAqGY+ObKdcBcoSc+8lNGGmto=; b=QRDP4An1R3Rlb3pVeKpvXW2ESVTwNGNuclCSNIoOEnZV+NJu+0/mpv7l68u0KlaSip gNZdM4aywSmQJsH4PnCv1raQsH/0M8JcT3N/bDtZUJvRtmpexz5LUq7HTt8NjnfzWoQx h7RkUmsiPlhA7bf3tZCKgJhxk7ppzeC+8u68N3oI53fG55WSTkxwpUYRhYss7xYCh9LX Spi1AueRGy4kJG+yjAsY0DuKxU3kWIEtHWtS2UN52YA4nJyx7rSoR3Kp/FZo90Anme1M FddFhcni46uLs44x6PIZI5HioK/yhIje07HeWhVzbC1qOjuLMPr6G15aAnXxmeUYJOSR /azA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=CDc0nv2t1vci7kw/XeRAqGY+ObKdcBcoSc+8lNGGmto=; b=qdbn1bOqR6ckOvIrQk5ekoy7e8H5zG4KRisBksFzFxc84ehF/5cLN2NDvISw8h1NQN nas9pZp2aZepblmI4LsT6N3GY2+Damj8KU6+9GWAfTcVt1MBKcy5jwfeFyE0I3sxuCrc 3sKFiL18frkeUV/1re2aNKjH/VvkhBapRZyhWC0dCsy7rAk3NpLaibBiiTrijD76A8Gd pl95Vih+0SVgdXiyMl2xJZ5NzrQnbRnsbKtSnEkgSbrAQTe5kNThWv8tvDcEg8nXqqK1 ExbYqBke4FPSzgGasdUzQFARVI5Mf1EQ/ukxQlgRh8PPfhe/2FXbZqLVQ5RTyM/FKpi8 aitg== X-Gm-Message-State: AMke39lNyCx9QDFp0R8RGUKkkgAzx2cOpei7YGsw+kDjMwhH5xQwooVxWT0J2G7vTcpZDg== X-Received: by 10.36.61.143 with SMTP id n137mr7671156itn.82.1488422758166; Wed, 01 Mar 2017 18:45:58 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id v197sm22104ita.2.2017.03.01.18.45.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Mar 2017 18:45:57 -0800 (PST) From: npostavs@users.sourceforge.net To: Tommi Komulainen Subject: Re: bug#20742: 24.5; [PATCH] python.el: fix close paren indentation to match pep8 References: Date: Wed, 01 Mar 2017 21:47:11 -0500 In-Reply-To: (Tommi Komulainen's message of "Sat, 20 Jun 2015 12:56:40 +0200") Message-ID: <87wpc8bdjk.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20742 Cc: 20742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Tommi Komulainen writes: >>>From da684af7265bf40e4140328c36011fea6b040373 Mon Sep 17 00:00:00 2001 > From: Tommi Komulainen > Date: Fri, 19 Jun 2015 18:53:52 +0200 > Subject: [PATCH] python.el: fix close paren indentation to match pep8 > > When opening paren is followed by newline the closing paren should follow > the current indentation. Otherwise the closing paren should be aligned > with the opening paren. This fixes the latter case. #20742 I'm having trouble applying this. error: corrupt patch at line 11 Applying: python.el: fix close paren indentation to match pep8 Patch failed at 0001 python.el: fix close paren indentation to match pep8 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 16:51:33 2019 Received: (at 20742) by debbugs.gnu.org; 20 Apr 2019 20:51:34 +0000 Received: from localhost ([127.0.0.1]:46858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHwxR-0006V2-89 for submit@debbugs.gnu.org; Sat, 20 Apr 2019 16:51:33 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:44653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHwxP-0006Uj-O9; Sat, 20 Apr 2019 16:51:32 -0400 Received: by mail-qk1-f173.google.com with SMTP id y5so4561015qkc.11; Sat, 20 Apr 2019 13:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OWPGKqseuGKI2TrEqkcsmcFLeJiwtP9CCN3CE6/efX0=; b=iRwUlt6BtpAdxbye7fJGRo/QqniHscPQS7oEt4V7InB3Bhd9jE/4xxq5R8chWgY+Z4 YlsofRVl2xFP9SMXV7x28Eq/geDHHO07MY4G5MjowTpJX47adZm4lAghXeVmojg7etNM LB92JXW1Z32fWfEAldzM5lkFV6TaABTouWoRU2+TRcn4Izqhr9niKN1uxIwpPIihyFPa 7S0MoIyXt6hk6VFPCPCc7pB6fb23Jdl3H3O5hne89ql0vW5buNAo8Kiblhp1gY4zHiBI vpGUwiOoBA/wmNCu48z1tY6Ny1zxt2aArq1CjvcQ7Yfi7+S3pSobqu/FFk1KP+npLgmG 7COA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OWPGKqseuGKI2TrEqkcsmcFLeJiwtP9CCN3CE6/efX0=; b=Zj+4/rXfoYxvnMzzJKB+QiLu6pdTpJIdxnXUKwYBEp9ko2rk0HADWRzATT+hg3ZLzf wVOgw/ASviIs/Jj6eNrVuIY3Q6po1UQJMACzAA2gACIlVsWYiSKkq8ydiJ+SrTmkx793 9hkeIIswns4fR0a/9LiodOQOnJLYJ9cK6V5KbhGccNaTvB8JjTXaJ2+DJyMblc5x4oEN xiIIwYaABfHrNOfNn7uVftfOfPcqI0QsxvVvzzNQByHbCtsBRfgp9mBIrWL9L+C4fQF+ ngzdlkHNTZwxi8JQdcuc+rB41v3WHzhFCAA4x/8St6BbSkpgSjMOb7uDVneKwM8aZ3Qn zP6g== X-Gm-Message-State: APjAAAW20znpyX2e2XAY5RSBoUvFCd+IcAVge7LHu7cOWTyoRK/pKhV7 wEVpiZLwDNUt1DiQS6fLZMBqM2xF X-Google-Smtp-Source: APXvYqw/lNisXOMu82hbCvoNeasYz82/L//ZoVQGqM03ZycIvQjEXG1PaALfuQabtuPZM9gYmqwdeQ== X-Received: by 2002:a37:614e:: with SMTP id v75mr8890422qkb.27.1555793486143; Sat, 20 Apr 2019 13:51:26 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e4sm4131236qkg.6.2019.04.20.13.51.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 Apr 2019 13:51:24 -0700 (PDT) From: Noam Postavsky To: 20742@debbugs.gnu.org Subject: Re: bug#20742: 24.5; [PATCH] python.el: fix close paren indentation to match pep8 References: <87wpc8bdjk.fsf@users.sourceforge.net> Date: Sat, 20 Apr 2019 16:51:23 -0400 In-Reply-To: <87wpc8bdjk.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Wed, 01 Mar 2017 21:47:11 -0500") Message-ID: <87sguctn78.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20742 Cc: Tommi Komulainen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 20742 + patch quit >> When opening paren is followed by newline the closing paren should follow >> the current indentation. Otherwise the closing paren should be aligned >> with the opening paren. This fixes the latter case. #20742 > > I'm having trouble applying this. > > error: corrupt patch at line 11 > Applying: python.el: fix close paren indentation to match pep8 > Patch failed at 0001 python.el: fix close paren indentation to match pep8 I managed to get this applied; I've replaced the python-test.el modifications, partly because they're written as updates to the existing tests which makes them a bit harder to follow, and partly to make more clear that the patch is below the 15 line copyright limit. I'll push to master in a week or so if there are no further comments. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-python.el-Fix-close-paren-indentation-to-match-pep8-.patch Content-Description: patch >From e0acfb7254f97f623286e65483535c1b6312f4ba Mon Sep 17 00:00:00 2001 From: Tommi Komulainen Date: Fri, 19 Jun 2015 18:53:52 +0200 Subject: [PATCH 1/2] python.el: Fix close paren indentation to match pep8 (Bug#20742) * lisp/progmodes/python.el (python-indent--calculate-indentation): When opening paren is followed by newline the closing paren should follow the current indentation. Otherwise the closing paren should be aligned with the opening paren. This fixes the latter case. Copyright-paperwork-exempt: yes --- lisp/progmodes/python.el | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index eb3e31c4b7..188bc973d9 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -1070,12 +1070,18 @@ (defun python-indent--calculate-indentation () (`(,(or :after-line :after-comment :inside-string - :after-backslash - :inside-paren-at-closing-paren - :inside-paren-at-closing-nested-paren) . ,start) + :after-backslash) . ,start) ;; Copy previous indentation. (goto-char start) (current-indentation)) + (`(,(or :inside-paren-at-closing-paren + :inside-paren-at-closing-nested-paren) . ,start) + (goto-char (+ 1 start)) + (if (looking-at "[ \t]*\\(?:#\\|$\\)") + ;; Copy previous indentation. + (current-indentation) + ;; Align with opening paren. + (current-column))) (`(:inside-docstring . ,start) (let* ((line-indentation (current-indentation)) (base-indent (progn -- 2.11.0 --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0002-Add-test-for-previous-change.patch Content-Description: patch >From 8649d874d5158d91b0b6056bc66b9a99f4c1c31a Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 20 Apr 2019 15:31:51 -0400 Subject: [PATCH 2/2] ; Add test for previous change * test/lisp/progmodes/python-tests.el (python-indent-hanging-close-paren): New test. --- test/lisp/progmodes/python-tests.el | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index b940f45bb9..a517909717 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -260,6 +260,19 @@ (ert-deftest python-indent-pep8-3 () (should (eq (car (python-indent-context)) :inside-paren-newline-start)) (should (= (python-indent-calculate-indentation) 4)))) +(ert-deftest python-indent-hanging-close-paren () + "Like first pep8 case, but with hanging close paren." ;; See Bug#20742. + (python-tests-with-temp-buffer + "\ +foo = long_function_name(var_one, var_two, + var_three, var_four + ) +" + (should (= (python-indent-calculate-indentation) 0)) + (python-tests-look-at ")") + (should (eq (car (python-indent-context)) :inside-paren-at-closing-paren)) + (should (= (python-indent-calculate-indentation) 25)))) + (ert-deftest python-indent-base-case () "Check base case does not trigger errors." (python-tests-with-temp-buffer -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 16:58:47 2019 Received: (at control) by debbugs.gnu.org; 20 Apr 2019 20:58:47 +0000 Received: from localhost ([127.0.0.1]:46865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHx4Q-0006gf-Dz for submit@debbugs.gnu.org; Sat, 20 Apr 2019 16:58:47 -0400 Received: from mail-qk1-f170.google.com ([209.85.222.170]:46432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHx4O-0006gM-DK; Sat, 20 Apr 2019 16:58:45 -0400 Received: by mail-qk1-f170.google.com with SMTP id w73so2418018qkb.13; Sat, 20 Apr 2019 13:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rOkax71soJsVa/zbc4JmCRuFVirc1U2iiw7j1dk2FF4=; b=mHdtPEeBoNqRU32hSx3xV0xKXIFrbF+4HPRm1Bf31Zrv4y54fl976gpLe7nCUTMuqF 4GKSGuiHq4QVXzy126ty2Rs4SM2ovaMA1DYto+mAi9Ma4IkPv5bodzJQZ9hNg4OWCqiZ fFvmxqoC2AtquKMYgpRVCnV65UXTEI7iQcRuQ3T42WbvyQKqNvQOsedwzNHXESlqhCqY FWtMEED+PcNn9vsCWeUy/KORGiLsKh7rPW+BH0kHCw87OIYJqjsOUy3dOxUkAEuk3/XK /bv7zloID+igVd5GMAqVODiUb3VPf2b73fOoPPsjlTKr2QnQkxgSuCubeomqZl94C7EJ 4eag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rOkax71soJsVa/zbc4JmCRuFVirc1U2iiw7j1dk2FF4=; b=Jap9lGm38A3nMjhmRshwkW9t7euwo0xPyiiFifxahHw/KkmojW+8ZV5udOQOYlplqx C3wnNIB8mlu9xMviQraQTsDmD7Tr1S7ficWqwswbZEkgwZBsGwWQ2EtkVEKJGcG3r8xu qN5upi4959lnK5GTxYO6Auhkn4DLj/xXxdFyIMflK9OmDt73IRtCpxtwwoe57/vWhDvA M3TWnmmXU+/bx2Qx8i85Hqnqa4gDPT838IagT3lpqR7n5zJwu/neN7fzWug3AdBv6Wlb DlMh+s9ZQanz0qGWZ9LmJ2hew/Lcy6zU8ODxcEk5r0/A0X0m0YxX+4nAZ1oDUKt1CHGO T04Q== X-Gm-Message-State: APjAAAUjmbWoLp8+e+FLoW2YZNhPGXixEbSnSEAj2npIIaEStw4kSdlc y8zmoKATSrJ6BNgre/YAV6j+GTn/ X-Google-Smtp-Source: APXvYqwTZgTTKL/DmvhvK7xNOrfzSj8euKp/XNFk2rjerusp3sfDCqqO5nRt8xN1kEAIIti8vwMl2A== X-Received: by 2002:a05:620a:1438:: with SMTP id k24mr8369372qkj.165.1555793918747; Sat, 20 Apr 2019 13:58:38 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id s30sm4027832qkm.43.2019.04.20.13.58.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 20 Apr 2019 13:58:38 -0700 (PDT) From: Noam Postavsky To: Glenn Morris Subject: Re: bug#20560: 24.5; I am not happy with the new Python mode indentation behaviour References: <5551D233.1090202@orange.fr> Date: Sat, 20 Apr 2019 16:58:37 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 12 May 2015 12:06:38 -0400") Message-ID: <87pnpgtmv6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: Fabrice Salvaire , 20560@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # patch for 20742 doesn't help for 20560 unmerge 20560 forcemerge 33979 20560 quit Glenn Morris writes: > Fabrice Salvaire wrote: > >> my_list = [ >> ____1, 2, 3, >> ____4, 5, 6, >> ] > > When I type that, I get an error, so perhaps it is not intended: > > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil) > =(nil 5) > python-syntax-closing-paren-p() > (and (python-syntax-closing-paren-p) (progn (forward-char 1) (not (nth 1 (or nil (syntax-ppss)))))) > (if (and (python-syntax-closing-paren-p) (progn (forward-char 1) (not (nth 1 (or nil (syntax-ppss)))))) (progn (cons :inside-paren-at-closing-paren start))) > (save-excursion (skip-syntax-forward " ") (if (and (python-syntax-closing-paren-p) (progn (forward-char 1) (not (nth 1 (or nil (syntax-ppss)))))) (progn (cons :inside-paren-at-closing-paren start)))) I'm not getting this anymore, perhaps it's been fixed in the meantime (I've tested only in 25.3 and 26.2, I don't have 24.5 building at the moment). At any rate, the OP seems to be the same as 33979 (though different from 20742 which it was previously merged to). From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 28 16:47:26 2019 Received: (at 20742) by debbugs.gnu.org; 28 Apr 2019 20:47:26 +0000 Received: from localhost ([127.0.0.1]:37897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKqhq-0003js-IK for submit@debbugs.gnu.org; Sun, 28 Apr 2019 16:47:26 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:38486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKqhn-0003ja-Ab; Sun, 28 Apr 2019 16:47:24 -0400 Received: by mail-qk1-f172.google.com with SMTP id g141so531115qke.5; Sun, 28 Apr 2019 13:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=unvm6er+j8St6NBQO9TIs/BO00anTS2sBFjQ/4zTv1s=; b=i2O/sZWAJIvQFTE/rAFhnxUqnTnYUmz2jsgu/DRbPYz7RfA9MkEFoneqVqlFloUg94 Sc/jAWZSo2akg88NpuhnbKcGUJaVu32YXfHRUGsH/dCR1yWtbgreBm0KsXTUzvCb59aP 0ISOq9dCbxKkqE5w7cSZEV6w8Bz3wPjjVP7nk4Pu+CTbqroqI1UGdK6EI45DL2mHkD6i 0R88YfTkEWNcmJbP4nSgjbiFuLzGj2TKwMYQ4ubNNya2xx+dj0mYKtQff3NcKqQKP2jn 1D/+8QRSlSDjzLSB7q9HE1QvMqBrF4gmAw842IgRZUqhQOeJUr9RjPYNkEqldrBBb9Xr stPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=unvm6er+j8St6NBQO9TIs/BO00anTS2sBFjQ/4zTv1s=; b=ZHNciQijg2m8IJvp4nnW/Q4K4dj9HWv1DHGTeX+YYyq9/6nUKs+yXbys5+TZ5BcYOV OPm15y2qZEwr05Mr12bJ8bHEzCHZ01UdOLB5NyBj6Usa7AK9NjOd5a+XUFi1IErxLPbP e8mBttInEygfKIp4hEnx+yUG85pLvjcMI8mEDoC9ocstQZEKIm6neNBJUcrfnhk+Enko uJIqcP3cda42t2sYWf9XljR3Iy7tuzEwXHhQJcPReY4MuOCMpv0XNc/wVg+FvxCodez0 iBiUN/gTj11H9gnbKVeh0kjNNbzP3VgA1/8aYWe8m+b+B18pECkdt/uNLEJqcN9SN+CR tAXw== X-Gm-Message-State: APjAAAUPXscZ1r8CqjkMT2sCfe2gEFNuHE034TUMrYzp1WFlCHEO3Gtb /Uw+Y3o5x9wN/oOPquZQ8Uv9RYQr X-Google-Smtp-Source: APXvYqytv+296bGKXMHvRj9Hr1ErvdsYc8vS2geS5R47QsAXAwqLyOuDIbm+DA77DFBivxV07SfiSA== X-Received: by 2002:a37:6897:: with SMTP id d145mr33417359qkc.185.1556484437500; Sun, 28 Apr 2019 13:47:17 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d55sm1900485qtb.59.2019.04.28.13.47.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Apr 2019 13:47:16 -0700 (PDT) From: Noam Postavsky To: 20742@debbugs.gnu.org Subject: Re: bug#20742: 24.5; [PATCH] python.el: fix close paren indentation to match pep8 References: <87wpc8bdjk.fsf@users.sourceforge.net> <87sguctn78.fsf@gmail.com> Date: Sun, 28 Apr 2019 16:47:15 -0400 In-Reply-To: <87sguctn78.fsf@gmail.com> (Noam Postavsky's message of "Sat, 20 Apr 2019 16:51:23 -0400") Message-ID: <877ebdq2lo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20742 Cc: Tommi Komulainen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 20742 fixed close 20742 27.1 quit > I'll push to master in a week or so if there are no further comments. Done. 3fc1d77a43 2019-04-28T16:45:13-04:00 "python.el: Fix close paren indentation to match pep8 (Bug#20742)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3fc1d77a43818666542740fc34167c1faee30d5f From unknown Tue Jun 17 01:50:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 May 2019 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator