GNU bug report logs - #20728
25.0.50; grep and grep-find templates should have a place holder for the --color argument

Previous Next

Full log

Message #53 received at 20728 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 20728 <at> debbugs.gnu.org
Subject: Re: bug#20728: 25.0.50;
 grep and grep-find templates should have a place holder for the
 --color argument
Date: Fri, 05 Jun 2015 11:59:39 +0300

> Cc: 20728 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Fri, 5 Jun 2015 11:29:23 +0300
> 
> On 06/05/2015 09:58 AM, Eli Zaretskii wrote:
> 
> > Please try to be less cryptic: what should I look for, and how?
> 
> There are no occurrences of '%s' in grep.el outside of 
> grep-compute-defaults.

I'm suggesting to add one.

> >> Have you looked at the values of grep-template and grep-find-template?
> >
> > Yes.
> 
> That is the way we construct variable-form commands in grep.el.

I'm suggesting to change that, for this specific issue.  We do that in
any number of other packages where a shell command needs to be
dynamically calculated guided by options.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.