GNU bug report logs - #20728
25.0.50; grep and grep-find templates should have a place holder for the --color argument

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 20728 <at> debbugs.gnu.org
Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument
Date: Mon, 29 Jun 2015 19:24:08 +0300

> Cc: 20728 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Mon, 29 Jun 2015 19:11:19 +0300
> 
> On 06/29/2015 06:26 PM, Eli Zaretskii wrote:
> 
> >> On the other hand, we might want to choose to set
> >> `grep-highlight-matches' to `always' in grep-compute-defaults,
> >> irrespective of the OS.
> >
> > Won't that bring back the problem in symref/grep.el again?
> 
> Why would it?
> 
> The replace (replace-regexp-in-string "--color=always" ...) call is 
> still there.

Ah, OK.  I thought you intended to remove it as part of this.

> - Try M-x xref-find-regexp on a Windows machine (in an Elisp buffer, 
> enter something like "xref-find-").
> - Probably see it fail for the same reason as symref/grep.el did previously.
> - Apply the patch below.
> - Hopefully see it succeed and write back about that.

Will do, thanks.

>  > Assuming we can count on commands that live far away, like
>  > symref/grep.el, to make a point of doing this, it will work, of
>  > course.
> 
> The idea is to force their authors to do it (because the commands won't 
> work otherwise).

Assuming those commands will be used on platforms that reveal the
failures...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.