GNU bug report logs - #20728
25.0.50; grep and grep-find templates should have a place holder for the --color argument

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 20728 <at> debbugs.gnu.org
Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument
Date: Thu, 4 Jun 2015 18:18:55 +0300

On 06/04/2015 06:01 PM, Eli Zaretskii wrote:

> Why not allow users of grep.el bind grep-highlight-matches to
> whatever, including nil, and make grep.el obey that?

That would be the effect. rgrep (and zrgrep) call grep-expand-template 
to create the command to invoke.

> Using a template
> for such a simple job sounds like over-engineering to me.  I can
> understand why the template is used in find-grep and related commands:
> the 'find' or 'xargs' command line is somewhat tricky.

find-grep is what this issue is about.

> But there's no
> such problem with 'grep', so I'm unsure why we want to use a template
> there, let alone have a placeholder for that switch in the template.

The behavior of M-x grep is beyond my concern. But how would you 
implement automatic support for that variable in it, if not using a 
template?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.