GNU bug report logs - #20728
25.0.50; grep and grep-find templates should have a place holder for the --color argument

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Wed, 3 Jun 2015 23:44:01 UTC

Severity: normal

Found in version 25.0.50

Fixed in version 25.1

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 20728 <at> debbugs.gnu.org
Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument
Date: Mon, 29 Jun 2015 13:08:48 +0300
On 06/29/2015 05:36 AM, Eli Zaretskii wrote:

>>> See cedet/semantic/symref/grep.el for when we don't want 'always'.
>>
>> We don't want `auto' there either, do we?
>
> I think 'auto' does TRT there.

In any case, we have to explicitly get rid of `always' in this command.

>> But now we can simply bind it to nil.
>
> We could, if we want to test Grep's output ourselves.  That is, we
> will have to decide when to bind it to nil and when to non-nil,

What do you mean by "test"?

My point is, we have to decide whether to highlight matches or not, if 
only to be compatible with Windows. And by "we", I mean in the 
implementation of each given command.

> depending on the device/file used as Grep's output (which is
> system-dependent).

Whether we want a given command to use a colorized Grep output, is not 
dependent on the OS, is it?




This bug report was last modified 10 years and 4 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.