From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jun 2015 23:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20728@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14333750072587 (code B ref -1); Wed, 03 Jun 2015 23:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jun 2015 23:43:27 +0000 Received: from localhost ([127.0.0.1]:39569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0IJi-0000ff-FQ for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35300) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0IJf-0000fR-Vg for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0IJZ-0006UK-Lk for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0IJZ-0006UG-JA for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0IJY-0005ma-GA for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 19:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0IJU-0006QI-Dj for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 19:43:16 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:34308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0IJU-0006Ge-7H for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 19:43:12 -0400 Received: by wibut5 with SMTP id ut5so4012700wib.1 for ; Wed, 03 Jun 2015 16:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=ckubaX3ZY1p5a2dkpEjbzjHD/bygrP2u5KQA2FsK6t8=; b=LEU1mOOc/YbobI6qTLG2TLd6V1rG9HPAzaxfvmkEkVTkS4+qpD2DdMfGcC5Xe2R2qI YeT0Oqkp5AdPG8/fRxaDR5il7FMF5Uh5DNSWfEgGn+x//2Cz1uBiakVF8C9deHbMmmr+ 5odKy3cR6QSOObJGM0rAEHUt2cGwFpd1f1zJpQbbC2D349kXBhlFFg4D9F2zQNZjqojh dBYAo8C5URTsdBI1YvPGJjchED4tIgFqP5wQROg9/djiqTH6tzoMLJj2ZewCllkIhM5A gxNcHqWRIYM4+DPkE15bWVFewyc8lSWcO3dx3yQFmIGACuE38VWVs66+ObYNAY+Jc74o sbUA== X-Received: by 10.194.205.101 with SMTP id lf5mr66380603wjc.42.1433374981194; Wed, 03 Jun 2015 16:43:01 -0700 (PDT) Received: from axl ([82.102.93.54]) by mx.google.com with ESMTPSA id q4sm3168226wja.24.2015.06.03.16.43.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 16:43:00 -0700 (PDT) From: Dmitry Gutov Date: Thu, 04 Jun 2015 02:42:58 +0300 Message-ID: <86bngws6il.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) And fill it in dynamically during expansion. This way, the caller can set grep-highlight-matches dynamically, without recomputing grep defaults (which is expensive). This is particularly relevant on MS-Windows, in semantic-symref-grep-use-template and xref-collect-matches. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 02:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143338584619075 (code B ref 20728); Thu, 04 Jun 2015 02:45:03 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 02:44:06 +0000 Received: from localhost ([127.0.0.1]:39620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0L8X-0004xa-Pi for submit@debbugs.gnu.org; Wed, 03 Jun 2015 22:44:06 -0400 Received: from mtaout29.012.net.il ([80.179.55.185]:42056) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0L8V-0004wv-0Y for 20728@debbugs.gnu.org; Wed, 03 Jun 2015 22:44:04 -0400 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NPE00600FJHJT00@mtaout29.012.net.il> for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 05:43:16 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPE0000YFK4VK60@mtaout29.012.net.il>; Thu, 04 Jun 2015 05:43:16 +0300 (IDT) Date: Thu, 04 Jun 2015 05:43:48 +0300 From: Eli Zaretskii In-reply-to: <86bngws6il.fsf@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83eglsqjkr.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Dmitry Gutov > Date: Thu, 04 Jun 2015 02:42:58 +0300 > > And fill it in dynamically during expansion. > > This way, the caller can set grep-highlight-matches dynamically, without > recomputing grep defaults (which is expensive). This is particularly > relevant on MS-Windows, in semantic-symref-grep-use-template and > xref-collect-matches. I don't understand what you perceive as a problem with the current code, and why. Could you elaborate, and perhaps provide an example? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 08:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143340831028343 (code B ref 20728); Thu, 04 Jun 2015 08:59:01 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 08:58:30 +0000 Received: from localhost ([127.0.0.1]:39860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Qyr-0007N5-Lg for submit@debbugs.gnu.org; Thu, 04 Jun 2015 04:58:30 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34588) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Qyo-0007Ms-TP for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 04:58:27 -0400 Received: by wibut5 with SMTP id ut5so14152329wib.1 for <20728@debbugs.gnu.org>; Thu, 04 Jun 2015 01:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=myed1tuXnj+KXygh5Crd1HEhYf5qfI73e6MypRkxr4I=; b=Dr6OPHU6pTGWObuod+hy7Enjld7RJOibtDBy71iRw33OqfN4P+lK1Joj7PMxSQ+XfQ jbi81Il3HuArduqII9uu3EmIXX/sHrnrujvR/BkUkdvFl5+JVtDW2cxwlwRznOmXrX6K JCvroevyhSjxxKPcK6qAvFFhGSAscdXuw6fH1S3rP3coLIirNpQdOAo8xHFpim/0XUy+ fGxBoPqx+K9/i1aXOjfV/FH0MCN3l3kzop1LLZ9uQWKmuP+rxkzEV+8UYNIq1vpQBvJL Ve+b892m0UXMpAdKXyZXsi6P3J89zWsVVs53ArkKiAFZDURGRvzTIHK4gq+C9WlsMg/Q eoHw== X-Received: by 10.180.99.166 with SMTP id er6mr5688035wib.58.1433408301155; Thu, 04 Jun 2015 01:58:21 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id n1sm5337502wix.0.2015.06.04.01.58.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 01:58:21 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> From: Dmitry Gutov Message-ID: <5570132A.9060109@yandex.ru> Date: Thu, 4 Jun 2015 11:58:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83eglsqjkr.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/04/2015 05:43 AM, Eli Zaretskii wrote: > I don't understand what you perceive as a problem with the current > code, and why. The fact that we have to do a replace-regexp-in-string in xref-collect-matches, as well as in semantic-symref-grep-use-template. Whereas we should be able to simply bind grep-highlight-matches to nil before calling grep-expand-template. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14334301272061 (code B ref 20728); Thu, 04 Jun 2015 15:03:02 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 15:02:07 +0000 Received: from localhost ([127.0.0.1]:40663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Wek-0000X9-7s for submit@debbugs.gnu.org; Thu, 04 Jun 2015 11:02:06 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:60564) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Weg-0000Wc-Kb for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 11:02:03 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NPF00L00DOV6E00@a-mtaout20.012.net.il> for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 18:01:55 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPF00KSHDR7X6A0@a-mtaout20.012.net.il>; Thu, 04 Jun 2015 18:01:55 +0300 (IDT) Date: Thu, 04 Jun 2015 18:01:50 +0300 From: Eli Zaretskii In-reply-to: <5570132A.9060109@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <838ubzqzz5.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Jun 2015 11:58:18 +0300 > > On 06/04/2015 05:43 AM, Eli Zaretskii wrote: > > > I don't understand what you perceive as a problem with the current > > code, and why. > > The fact that we have to do a replace-regexp-in-string in > xref-collect-matches, as well as in semantic-symref-grep-use-template. > > Whereas we should be able to simply bind grep-highlight-matches to nil > before calling grep-expand-template. Why not allow users of grep.el bind grep-highlight-matches to whatever, including nil, and make grep.el obey that? Using a template for such a simple job sounds like over-engineering to me. I can understand why the template is used in find-grep and related commands: the 'find' or 'xargs' command line is somewhat tricky. But there's no such problem with 'grep', so I'm unsure why we want to use a template there, let alone have a placeholder for that switch in the template. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 15:20:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14334311453584 (code B ref 20728); Thu, 04 Jun 2015 15:20:04 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 15:19:05 +0000 Received: from localhost ([127.0.0.1]:40682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0WvB-0000vk-DG for submit@debbugs.gnu.org; Thu, 04 Jun 2015 11:19:05 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:35998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Wv8-0000v8-VJ for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 11:19:03 -0400 Received: by wibdq8 with SMTP id dq8so128451322wib.1 for <20728@debbugs.gnu.org>; Thu, 04 Jun 2015 08:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=9k4FhgPecO5xPCWMFzk8Df/uUa53y+0tI6aOIWCKLnw=; b=pbtlYuLy0yAmaXMUXYz3SdBRytQrbb9mOceBNP2Is9G9d+mJuZYUyTpWR0lEWj2JHE tmsJY+XiX/I1BNljjpfEKkrHOiIuKxwtw43A4MXfSIT0SOTiSmGTwSeQokXRUkpjF94Z 3Wk4HuDUihRXV4gPxDWs3WBisk2v+smu5zFvxLo2l5C/ZtrRLJGv2ISaFA7y2u2vdvcI wYyWHuO0D1tFp+Lr8O/hsPzksimNbmyXmYtA8lCXdHqbJAF8CUhwaHuUSkW+iaB9Fnwl aIHLyBIW7mG5nSp/jpqTDUgoSZc6RwCl59bvsoptdqzPLYUqz5B1rfPB093tVa6DSGLp VO1w== X-Received: by 10.194.133.73 with SMTP id pa9mr73033625wjb.148.1433431137360; Thu, 04 Jun 2015 08:18:57 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id ew10sm31700390wic.22.2015.06.04.08.18.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 08:18:57 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55706C5F.6070903@yandex.ru> Date: Thu, 4 Jun 2015 18:18:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <838ubzqzz5.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/04/2015 06:01 PM, Eli Zaretskii wrote: > Why not allow users of grep.el bind grep-highlight-matches to > whatever, including nil, and make grep.el obey that? That would be the effect. rgrep (and zrgrep) call grep-expand-template to create the command to invoke. > Using a template > for such a simple job sounds like over-engineering to me. I can > understand why the template is used in find-grep and related commands: > the 'find' or 'xargs' command line is somewhat tricky. find-grep is what this issue is about. > But there's no > such problem with 'grep', so I'm unsure why we want to use a template > there, let alone have a placeholder for that switch in the template. The behavior of M-x grep is beyond my concern. But how would you implement automatic support for that variable in it, if not using a template? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14334321085073 (code B ref 20728); Thu, 04 Jun 2015 15:36:02 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 15:35:08 +0000 Received: from localhost ([127.0.0.1]:40687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0XAh-0001Jj-2l for submit@debbugs.gnu.org; Thu, 04 Jun 2015 11:35:07 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:50361) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0XAd-0001JA-4E for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 11:35:04 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NPF00100EO5J600@mtaout24.012.net.il> for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 18:26:36 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPF00H5JEWB1VC0@mtaout24.012.net.il>; Thu, 04 Jun 2015 18:26:36 +0300 (IDT) Date: Thu, 04 Jun 2015 18:34:50 +0300 From: Eli Zaretskii In-reply-to: <55706C5F.6070903@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <833827qyg5.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Jun 2015 18:18:55 +0300 > > how would you implement automatic support for that variable in it, > if not using a template? (cond ((eq grep-highlight-matches 'never) "--color=never") ((eq grep-highlight-matches 'auto) "--color=auto" etc., you get the idea. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14334321905248 (code B ref 20728); Thu, 04 Jun 2015 15:37:02 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 15:36:30 +0000 Received: from localhost ([127.0.0.1]:40691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0XC2-0001MZ-8M for submit@debbugs.gnu.org; Thu, 04 Jun 2015 11:36:30 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:35707) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0XBz-0001MH-Ix for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 11:36:27 -0400 Received: by wgme6 with SMTP id e6so36659342wgm.2 for <20728@debbugs.gnu.org>; Thu, 04 Jun 2015 08:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Ew9qh8XEdupaz3pCxIUxaNeDBwluzzKqBNUhGOX3+Pk=; b=eZJx2+wpip3uspNnCdfrL3Rl7bh+aGgAeXGFrSVO2Ot0VwhRqhiJITdwEdCXSRCKAJ V+sZjvaGf+2G7ScYuZu3ukec6YfUyvt8tVPA9LqvhppLgiJp6pj+EhuVayKo7pOH6+AU Fk8r8tru+yp7v+UofilWSiEL5irnau0nHk30UAsSdPmTcCz4Y1DqbG4ktz2pO5VS77mw iR9HiV0BoqywBdRqFAMngWOKb3E5rYl/Vj2A4cBRFSK2HhhRndVOFu+6sUL2xa0XbVXa zDUsyKh+FqyKt7BgnA07FCdDsm5nOYbNnX3zFs5FU2Ye1UDXlFVtdfYhn4I73UwpoWnX AG4Q== X-Received: by 10.180.94.168 with SMTP id dd8mr52019788wib.76.1433432181872; Thu, 04 Jun 2015 08:36:21 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id lu5sm3011861wjb.9.2015.06.04.08.36.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 08:36:21 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55707074.8010607@yandex.ru> Date: Thu, 4 Jun 2015 18:36:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <833827qyg5.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/04/2015 06:34 PM, Eli Zaretskii wrote: > (cond > ((eq grep-highlight-matches 'never) > "--color=never") > ((eq grep-highlight-matches 'auto) > "--color=auto" > > etc., you get the idea. And how would the resulting value be used, without a template? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 15:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14334323685565 (code B ref 20728); Thu, 04 Jun 2015 15:40:03 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 15:39:28 +0000 Received: from localhost ([127.0.0.1]:40699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0XEu-0001Rf-1g for submit@debbugs.gnu.org; Thu, 04 Jun 2015 11:39:28 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:39466) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0XEr-0001RQ-JC for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 11:39:26 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NPF00200F6X3X00@mtaout28.012.net.il> for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 18:38:42 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPF00NCTFGI8Q50@mtaout28.012.net.il>; Thu, 04 Jun 2015 18:38:42 +0300 (IDT) Date: Thu, 04 Jun 2015 18:39:12 +0300 From: Eli Zaretskii In-reply-to: <55707074.8010607@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83zj4fpjof.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Jun 2015 18:36:20 +0300 > > On 06/04/2015 06:34 PM, Eli Zaretskii wrote: > > > (cond > > ((eq grep-highlight-matches 'never) > > "--color=never") > > ((eq grep-highlight-matches 'auto) > > "--color=auto" > > > > etc., you get the idea. > > And how would the resulting value be used, without a template? By plugging it directly into the command. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143343693012305 (code B ref 20728); Thu, 04 Jun 2015 16:56:02 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 16:55:30 +0000 Received: from localhost ([127.0.0.1]:40719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0YQT-0003CP-LC for submit@debbugs.gnu.org; Thu, 04 Jun 2015 12:55:29 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33856) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0YQQ-0003CA-RL for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 12:55:27 -0400 Received: by wibut5 with SMTP id ut5so27748368wib.1 for <20728@debbugs.gnu.org>; Thu, 04 Jun 2015 09:55:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Z9S8sNq3YU6BQGC7ePWLT/9csnKoD/ZLc5hBVY50luY=; b=Swc33pvBFvCbAlbxq1IgO9sv6FLXa5U51AJ5P0Go5QB1mbFOecwxRnK6cEIOuGtmWW lj3yCfW9bmqHB3iTuOizP1kHS2XX0Y7BCcTpprIYnZNTq0+pBv7tOwveYr3u7OVOaAx1 jLM+iyvR1NmZinh/S3oLInypCIoDKO/SGCz+KYRF/stvmqnVxwE5XvrbqX8emJY9mL02 C35F6FEr7rUQqmfNCrmh8l9Un2z4kb1TTYFWzcoIXvFzThglWnWQVR+az5BotXwd3wH2 aZBxyjx4IOZCGNQDZan4rQuKLr5CJMYGpHO8l193njBwc4jtyuIXcgQFUXweo3159u2i 9VJw== X-Received: by 10.194.173.40 with SMTP id bh8mr69472477wjc.99.1433436921146; Thu, 04 Jun 2015 09:55:21 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id o6sm32051752wiz.24.2015.06.04.09.55.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 09:55:20 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> From: Dmitry Gutov Message-ID: <557082F7.8020400@yandex.ru> Date: Thu, 4 Jun 2015 19:55:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83zj4fpjof.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/04/2015 06:39 PM, Eli Zaretskii wrote: > By plugging it directly into the command. Without a placeholder? How? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143343819014228 (code B ref 20728); Thu, 04 Jun 2015 17:17:02 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 17:16:30 +0000 Received: from localhost ([127.0.0.1]:40723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Ykn-0003hQ-J0 for submit@debbugs.gnu.org; Thu, 04 Jun 2015 13:16:29 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:40762) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0Ykl-0003hB-HR for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 13:16:28 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NPF00700JM3Y800@a-mtaout22.012.net.il> for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 20:16:21 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPF007KEJZ8FJA0@a-mtaout22.012.net.il>; Thu, 04 Jun 2015 20:16:21 +0300 (IDT) Date: Thu, 04 Jun 2015 20:16:15 +0300 From: Eli Zaretskii In-reply-to: <557082F7.8020400@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83wpzjpf6o.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Jun 2015 19:55:19 +0300 > > On 06/04/2015 06:39 PM, Eli Zaretskii wrote: > > > By plugging it directly into the command. > > Without a placeholder? How? With a placeholder that is %s, like we do with all the rest when we format a string. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143343998916889 (code B ref 20728); Thu, 04 Jun 2015 17:47:02 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 17:46:29 +0000 Received: from localhost ([127.0.0.1]:40728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0ZDp-0004OL-CR for submit@debbugs.gnu.org; Thu, 04 Jun 2015 13:46:29 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34564) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0ZDm-0004O3-Sv for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 13:46:27 -0400 Received: by wibut5 with SMTP id ut5so29033409wib.1 for <20728@debbugs.gnu.org>; Thu, 04 Jun 2015 10:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=2OgYltw/0KpHCEoYxqvvyxl9/3goc2XT/2a42m9jqTs=; b=rbIMn7ltm4G0NLzJfuYu5eyGoFZwHDbwV5iPx3XQpW5o/yr5dTiwAbjeLZQ/2IxLv6 bdrgvUxJAACW311FzNNicXh8E7Nj7jq4XdRgKl83DVy9mjFjWAg/EobTnE4Ev+k57QyR Vy8HneYfx26X73i9ii6eyjbeGsYOO277YZmiCdqHj3tVky0Z8DglvLnsPFuRk903Quc1 BNWGIRzQHEuOgN/V/HEUZAsE4+pIyAc9k0pz5klcbXrszbXopjglzuLF4JrMBRKdNmtd n6n4w1dI2ljRB0ou98N77tcMyrCwNUTc6MdXFIy+WtoQApJHTtJNAOLm8uDtDt1jSST4 WBsQ== X-Received: by 10.180.73.10 with SMTP id h10mr10166934wiv.3.1433439981041; Thu, 04 Jun 2015 10:46:21 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id hn7sm6731500wjc.16.2015.06.04.10.46.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 10:46:20 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55708EEA.6020400@yandex.ru> Date: Thu, 4 Jun 2015 20:46:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83wpzjpf6o.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/04/2015 08:16 PM, Eli Zaretskii wrote: > With a placeholder that is %s, like we do with all the rest when we > format a string. Then it'll also be a template. With a downside of using different placeholder than the other templates in grep.el. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143344579525704 (code B ref 20728); Thu, 04 Jun 2015 19:24:02 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 19:23:15 +0000 Received: from localhost ([127.0.0.1]:40782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0ajS-0006gV-Mk for submit@debbugs.gnu.org; Thu, 04 Jun 2015 15:23:15 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:50703) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0ajP-0006gE-VG for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 15:23:13 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NPF00900PI1D800@mtaout27.012.net.il> for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 22:18:15 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPF00OHPPMFVZB0@mtaout27.012.net.il>; Thu, 04 Jun 2015 22:18:15 +0300 (IDT) Date: Thu, 04 Jun 2015 22:23:00 +0300 From: Eli Zaretskii In-reply-to: <55708EEA.6020400@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83twunp9bf.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Jun 2015 20:46:18 +0300 > > On 06/04/2015 08:16 PM, Eli Zaretskii wrote: > > > With a placeholder that is %s, like we do with all the rest when we > > format a string. > > Then it'll also be a template. With a downside of using different > placeholder than the other templates in grep.el. I see a lot of %s in grep.el, so it's not like this is a precedent that we didn't have before. That's the usual way we construct variable-form commands in Emacs. Why should this one be different? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 20:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143344924210001 (code B ref 20728); Thu, 04 Jun 2015 20:21:03 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 20:20:42 +0000 Received: from localhost ([127.0.0.1]:40837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0bd3-0002bD-L5 for submit@debbugs.gnu.org; Thu, 04 Jun 2015 16:20:41 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:38682) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0bd0-0002az-C0 for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 16:20:38 -0400 Received: by wibdt2 with SMTP id dt2so18665wib.1 for <20728@debbugs.gnu.org>; Thu, 04 Jun 2015 13:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=EE3dogCY0ccOTMLXFMgI7TPIHwnbWQsZXMhcKpiTLOs=; b=IslFuIbB9wEhxOqtQAXu2rYNOXR/Sk5wigVclUJ/4c0RkXQucrlo/y+thK2Hfypzad kxhIxYUQh7O51Tfalh5bbp96ANnb/DcDHYg0YJsjNcEoXs4JaPQtSpgXOpthffOVZZ9I pfDGHWR/YbBTBzdm7tgKSuvMILtr/4OSdslGMWBxOWBWC++t+jFi2WfIjKbXEzWOSpvy N8zTTS31BZQJeBuzHOOwVwsnrl/G9bi8Cf88iWhDZOOednOP7934Fza1LRrLlEG420eV oPrAWl2xA+RJw+of6LgUDiRgQH/cK5ltJg7McTZ6uhLOtWzYpdk3+hE1u2FxGHPwCI/X 0zKw== X-Received: by 10.180.218.137 with SMTP id pg9mr10881393wic.79.1433449232780; Thu, 04 Jun 2015 13:20:32 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id wr6sm7273171wjb.21.2015.06.04.13.20.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2015 13:20:32 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> From: Dmitry Gutov Message-ID: <5570B30F.4090503@yandex.ru> Date: Thu, 4 Jun 2015 23:20:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83twunp9bf.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/04/2015 10:23 PM, Eli Zaretskii wrote: > I see a lot of %s in grep.el, so it's not like this is a precedent > that we didn't have before. Try to look for them outside of grep-compute-defaults definition. > That's the usual way we construct > variable-form commands in Emacs. Why should this one be different? Have you looked at the values of grep-template and grep-find-template? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2015 22:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143345838124143 (code B ref 20728); Thu, 04 Jun 2015 22:53:03 +0000 Received: (at 20728) by debbugs.gnu.org; 4 Jun 2015 22:53:01 +0000 Received: from localhost ([127.0.0.1]:40913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0e0S-0006HI-4w for submit@debbugs.gnu.org; Thu, 04 Jun 2015 18:53:00 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:45196 helo=homiemail-a12.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0e0O-0006H7-Cx for 20728@debbugs.gnu.org; Thu, 04 Jun 2015 18:52:57 -0400 Received: from homiemail-a12.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a12.g.dreamhost.com (Postfix) with ESMTP id 0B673103006C; Thu, 4 Jun 2015 15:52:55 -0700 (PDT) Received: from localhost.linkov.net (m91-129-112-87.cust.tele2.ee [91.129.112.87]) (Authenticated sender: jurta@jurta.org) by homiemail-a12.g.dreamhost.com (Postfix) with ESMTPA id ED8AC1030063; Thu, 4 Jun 2015 15:52:53 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> Date: Fri, 05 Jun 2015 01:50:34 +0300 In-Reply-To: <86bngws6il.fsf@yandex.ru> (Dmitry Gutov's message of "Thu, 04 Jun 2015 02:42:58 +0300") Message-ID: <87d21bxf45.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > And fill it in dynamically during expansion. > > This way, the caller can set grep-highlight-matches dynamically, without > recomputing grep defaults (which is expensive). This is particularly > relevant on MS-Windows, in semantic-symref-grep-use-template and > xref-collect-matches. I guess you need reusing the grep command line for purposes other than highlighting its matches in the output buffer, right? Then indeed since on Windows grep fails `isatty' detection we had to use "--color=always" instead of "--color=auto". Some time ago additional grep options (including "--color=auto") were set in env GREP_OPTIONS were they could be easily changed, but not anymore after 2e4c2fe2787785a421f256541de642976e9bd90b. So maybe now we should add a place holder for grep options in the template and use it the same way as we used GREP_OPTIONS. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 06:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14334874983414 (code B ref 20728); Fri, 05 Jun 2015 06:59:02 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 06:58:18 +0000 Received: from localhost ([127.0.0.1]:41016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0la5-0000sx-9K for submit@debbugs.gnu.org; Fri, 05 Jun 2015 02:58:17 -0400 Received: from mtaout28.012.net.il ([80.179.55.184]:45289) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0la3-0000sk-4y for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 02:58:16 -0400 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NPG00800LQBN200@mtaout28.012.net.il> for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 09:57:34 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPG005SNLZYRD40@mtaout28.012.net.il>; Fri, 05 Jun 2015 09:57:34 +0300 (IDT) Date: Fri, 05 Jun 2015 09:58:04 +0300 From: Eli Zaretskii In-reply-to: <5570B30F.4090503@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83oakuprpf.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Thu, 4 Jun 2015 23:20:31 +0300 > > On 06/04/2015 10:23 PM, Eli Zaretskii wrote: > > > I see a lot of %s in grep.el, so it's not like this is a precedent > > that we didn't have before. > > Try to look for them outside of grep-compute-defaults definition. Please try to be less cryptic: what should I look for, and how? > > That's the usual way we construct > > variable-form commands in Emacs. Why should this one be different? > > Have you looked at the values of grep-template and grep-find-template? Yes. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 08:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143349297312021 (code B ref 20728); Fri, 05 Jun 2015 08:30:05 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 08:29:33 +0000 Received: from localhost ([127.0.0.1]:41076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0n0P-00037o-D6 for submit@debbugs.gnu.org; Fri, 05 Jun 2015 04:29:33 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33131) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0n0N-00037Z-CB for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 04:29:31 -0400 Received: by wiwd19 with SMTP id d19so13341032wiw.0 for <20728@debbugs.gnu.org>; Fri, 05 Jun 2015 01:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=x9Ouuc5xrpzJOpparodJNFTiWDw0WAFuDURgE6AZL18=; b=OLsdIJQ065HG0MSribGa+uZi5DVpxkCHSD8QwdMP0ioI7ZvZRW9n6cjUvgU//Fa47g aKa+YNqiV2tAx6jU+/mRzEmC3E37UBuiOAw9J27AJaEqkpPF7udUZZd5ltMa9Kp6QsLv B3MGPFVdrTi20POIKlZyhnqBBYSK1g4jkA2IA26hf2vnlO+9az9Bw2ysXX56aUTPIkoc vJh39O+Sx3OMmDUwdTMMhpfV389fPvohbVNmC4O/KzIK0vq8ppk1dVm1jv4YwTdK0n68 jcBLIiS8YzBJq3xQXkFsELoGIQJeWf1nA7jBimtTzZgKitlfdl7WcY9JvvmTC37IYbUG IlfQ== X-Received: by 10.180.189.16 with SMTP id ge16mr15576378wic.47.1433492965687; Fri, 05 Jun 2015 01:29:25 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id hn7sm2157176wib.5.2015.06.05.01.29.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 01:29:25 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55715DE3.6000405@yandex.ru> Date: Fri, 5 Jun 2015 11:29:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83oakuprpf.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/05/2015 09:58 AM, Eli Zaretskii wrote: > Please try to be less cryptic: what should I look for, and how? There are no occurrences of '%s' in grep.el outside of grep-compute-defaults. >> Have you looked at the values of grep-template and grep-find-template? > > Yes. That is the way we construct variable-form commands in grep.el. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 09:00:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143349479314831 (code B ref 20728); Fri, 05 Jun 2015 09:00:05 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 08:59:53 +0000 Received: from localhost ([127.0.0.1]:41101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0nTl-0003r8-8u for submit@debbugs.gnu.org; Fri, 05 Jun 2015 04:59:53 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:52020) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0nTi-0003qp-Mc for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 04:59:52 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NPG00700R3F2G00@mtaout24.012.net.il> for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 11:51:23 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPG00F6AR9N3UD0@mtaout24.012.net.il>; Fri, 05 Jun 2015 11:51:23 +0300 (IDT) Date: Fri, 05 Jun 2015 11:59:39 +0300 From: Eli Zaretskii In-reply-to: <55715DE3.6000405@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83h9qmpm2s.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 5 Jun 2015 11:29:23 +0300 > > On 06/05/2015 09:58 AM, Eli Zaretskii wrote: > > > Please try to be less cryptic: what should I look for, and how? > > There are no occurrences of '%s' in grep.el outside of > grep-compute-defaults. I'm suggesting to add one. > >> Have you looked at the values of grep-template and grep-find-template? > > > > Yes. > > That is the way we construct variable-form commands in grep.el. I'm suggesting to change that, for this specific issue. We do that in any number of other packages where a shell command needs to be dynamically calculated guided by options. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 09:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143349525615601 (code B ref 20728); Fri, 05 Jun 2015 09:08:02 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 09:07:36 +0000 Received: from localhost ([127.0.0.1]:41108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0nbE-00043Z-0M for submit@debbugs.gnu.org; Fri, 05 Jun 2015 05:07:36 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:36830) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0nbB-00043M-Tm for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 05:07:34 -0400 Received: by wgbgq6 with SMTP id gq6so51725374wgb.3 for <20728@debbugs.gnu.org>; Fri, 05 Jun 2015 02:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=9GqX5Ld1s9fNX75puL8fe1DJ+Y8MIodsRhFYpLam+Cc=; b=pYjrdlNUjX9HjvnEPG3dOLrl4xbPIjOktZ+me0CrkAusVfyjsOr0E+51kDvJjXp+o5 rkgTL1TJA7m1wQva7R8sgu7nj4A040tR5Q8VHrb5xmM8XBqvoRY2ZZ7f6BLGtVucI94a 2NdQj00sTg56/yfCC7rUukEphduHE4MhHRfM58+/Hj6VVyEAgIiiX69lAMflHlLGQ66T zW1/AbLHQh9rft4To8VN6EgjbYwXX5zehQGdE9Skbwxv05DzJbcGMcwhu6XVALHig0Zx m/+kLilWWgknWS/tZEZdbOx1IyyOSQHEAHkGqSN6i/WMidydih6Q/u1sgS/SkJHrTIZp ndyA== X-Received: by 10.180.80.197 with SMTP id t5mr60043401wix.63.1433495248436; Fri, 05 Jun 2015 02:07:28 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id gw7sm2420058wib.15.2015.06.05.02.07.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 02:07:28 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> From: Dmitry Gutov Message-ID: <557166CE.4050906@yandex.ru> Date: Fri, 5 Jun 2015 12:07:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83h9qmpm2s.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/05/2015 11:59 AM, Eli Zaretskii wrote: > I'm suggesting to change that, for this specific issue. We do that in > any number of other packages where a shell command needs to be > dynamically calculated guided by options. I fail to understand what would be the benefit of that. We already have templates anyway. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 09:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143349624517080 (code B ref 20728); Fri, 05 Jun 2015 09:25:02 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 09:24:05 +0000 Received: from localhost ([127.0.0.1]:41114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0nrB-0004RP-58 for submit@debbugs.gnu.org; Fri, 05 Jun 2015 05:24:05 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:35295) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0nr7-0004Qt-SI for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 05:24:03 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NPG00400SLYNO00@a-mtaout20.012.net.il> for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 12:23:55 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NPG004BESRVMY10@a-mtaout20.012.net.il>; Fri, 05 Jun 2015 12:23:55 +0300 (IDT) Date: Fri, 05 Jun 2015 12:23:51 +0300 From: Eli Zaretskii In-reply-to: <557166CE.4050906@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83d21apkyg.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 5 Jun 2015 12:07:26 +0300 > > On 06/05/2015 11:59 AM, Eli Zaretskii wrote: > > > I'm suggesting to change that, for this specific issue. We do that in > > any number of other packages where a shell command needs to be > > dynamically calculated guided by options. > > I fail to understand what would be the benefit of that. IMO, it's much simpler, and doesn't require to invent a new placeholder for such a simple job. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 09:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143349765919251 (code B ref 20728); Fri, 05 Jun 2015 09:48:01 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 09:47:39 +0000 Received: from localhost ([127.0.0.1]:41133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0oDy-00050Q-FW for submit@debbugs.gnu.org; Fri, 05 Jun 2015 05:47:38 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38438) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0oDw-00050C-Q7 for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 05:47:37 -0400 Received: by wibdq8 with SMTP id dq8so13091899wib.1 for <20728@debbugs.gnu.org>; Fri, 05 Jun 2015 02:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=8L5rRvDNxFWxr0bPNr5FYn/OJibxRyaZBi3cdacEbHE=; b=XihaLgj8J1rI01d97hokxTqeJFgWUEyzU3MPpHh0WO+O/eR+FRElRwsYiYShFB9NZA QFK5i7oq1M2uAD17MLsnPSG/2q00QYSqc4A70lNfWHGWyMssg/sfq9zxA/8iSrJF8nI3 0EolZrs0s4gCirLDado+YtFAoKliVlp8Gd+N3qoXSJS8yXrUF0F0UtrncJY1ABeikRUu sEyDAzlKXk2313XC14cxrsFBRn7ZjPiAnROiG16QcxfTSqU6LdqijBzVmK4GvM2QQQor juGiC5Rg0TtylGDYVKc7A8BBUk5AI19hgDAsLDmR6ERCXsYmPxf95Q4HORe6uI3SA+1m hdFQ== X-Received: by 10.194.97.196 with SMTP id ec4mr4969019wjb.3.1433497650891; Fri, 05 Jun 2015 02:47:30 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id hn7sm9740579wjc.16.2015.06.05.02.47.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 02:47:30 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55717030.6010005@yandex.ru> Date: Fri, 5 Jun 2015 12:47:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83d21apkyg.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/05/2015 12:23 PM, Eli Zaretskii wrote: > IMO, it's much simpler, and doesn't require to invent a new > placeholder for such a simple job. We'll still need that placeholder in grep-find-template (and probably in grep-template, for consistency). Regarding M-x grep, I would rather leave it alone for now, because otherwise, %s or not, that would call for renaming the variable grep-command, and grep-template is already taken. Another option would be to perform the substitution with regexp in grep-default-command, and it's pretty hairy already. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 09:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143349779519462 (code B ref 20728); Fri, 05 Jun 2015 09:50:03 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 09:49:55 +0000 Received: from localhost ([127.0.0.1]:41137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0oGB-00053q-4V for submit@debbugs.gnu.org; Fri, 05 Jun 2015 05:49:55 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:38801) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0oG9-00053b-0g for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 05:49:53 -0400 Received: by wibdq8 with SMTP id dq8so13153670wib.1 for <20728@debbugs.gnu.org>; Fri, 05 Jun 2015 02:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=uoT0xoW3qim/RBGxKATLarJYE6uTcDX04/iJ7jLG9aM=; b=wdmN8v/pPvaUcp3jTHlP2PnUS+OuPQNWitOnyrEHt3Vi9+pTwGiWd8eWMExlq//ibK dGYObprJCJeI3v09zTmL4zpcR4DUk2f+t+BBXnvniJ641QPZ+JDRQ/xncdG1xK4GCLAu VFvTykHcXTRgmcKA+Np8KcVrPIaD6izWYt9lHwONjyuWww8+W6+oCYPYCKUdfZ1FdPR8 B622wAPH+Jb7t3FHWI+X3og/S6Pj1fp1FYG2VAgAFLbHKZ58ouBNHBgqrSn0/ufAfyxo v1kz2VK9vlSdvyWpBae9nH/yoitMLlf4QyJsCsJ7RFRBUthJz62Ll08acq2yNBZparuT PZ0w== X-Received: by 10.180.36.170 with SMTP id r10mr16758061wij.10.1433497787425; Fri, 05 Jun 2015 02:49:47 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id lu5sm6491713wjb.9.2015.06.05.02.49.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 02:49:47 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <87d21bxf45.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <557170B9.7050408@yandex.ru> Date: Fri, 5 Jun 2015 12:49:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87d21bxf45.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/05/2015 01:50 AM, Juri Linkov wrote: > I guess you need reusing the grep command line for purposes > other than highlighting its matches in the output buffer, right? Yep, to run it and parse the output programmatically. > Some time ago additional grep options (including "--color=auto") > were set in env GREP_OPTIONS were they could be easily changed, > but not anymore after 2e4c2fe2787785a421f256541de642976e9bd90b. Thanks for the background. > So maybe now we should add a place holder for grep options > in the template and use it the same way as we used GREP_OPTIONS. Indeed. I'm inclined toward , for "additional Options". From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2015 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org, Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14335427192083 (code B ref 20728); Fri, 05 Jun 2015 22:19:02 +0000 Received: (at 20728) by debbugs.gnu.org; 5 Jun 2015 22:18:39 +0000 Received: from localhost ([127.0.0.1]:42269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0zwk-0000XW-Vf for submit@debbugs.gnu.org; Fri, 05 Jun 2015 18:18:39 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:37703 helo=homiemail-a75.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0zwi-0000XN-3d for 20728@debbugs.gnu.org; Fri, 05 Jun 2015 18:18:37 -0400 Received: from homiemail-a75.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTP id 386355EC084; Fri, 5 Jun 2015 15:18:35 -0700 (PDT) Received: from localhost.linkov.net (m213-102-136-198.cust.tele2.ee [213.102.136.198]) (Authenticated sender: jurta@jurta.org) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTPA id DCD9F5EC082; Fri, 5 Jun 2015 15:18:33 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> Date: Sat, 06 Jun 2015 01:17:52 +0300 In-Reply-To: <55717030.6010005@yandex.ru> (Dmitry Gutov's message of "Fri, 5 Jun 2015 12:47:28 +0300") Message-ID: <87a8wdhka7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > We'll still need that placeholder in grep-find-template (and probably in > grep-template, for consistency). > > Regarding M-x grep, I would rather leave it alone for now, because > otherwise, %s or not, that would call for renaming the variable > grep-command, and grep-template is already taken. There is also grep-find-command used by grep-find. > Another option would be to perform the substitution with regexp in > grep-default-command, and it's pretty hairy already. Since there is a lot of %s-substitutions in grep-compute-defaults that produce command lines depending on many customizations, yet another option is to let-bind the variables grep-command, grep-find-command, grep-template, grep-find-template in your function, then call grep-compute-defaults with a new value of grep-highlight-matches, and then get new command lines without the --color option from these local bindings to run them and parse the output programmatically. In case when users customize grep-highlight-matches interactively, its defcustom should compute new command lines using grep-compute-defaults. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jun 2015 10:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org, Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14335859871014 (code B ref 20728); Sat, 06 Jun 2015 10:20:03 +0000 Received: (at 20728) by debbugs.gnu.org; 6 Jun 2015 10:19:47 +0000 Received: from localhost ([127.0.0.1]:42609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1BCc-0000GH-IE for submit@debbugs.gnu.org; Sat, 06 Jun 2015 06:19:47 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35894) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1BCX-0000G0-Ec for 20728@debbugs.gnu.org; Sat, 06 Jun 2015 06:19:45 -0400 Received: by wigg3 with SMTP id g3so8442968wig.1 for <20728@debbugs.gnu.org>; Sat, 06 Jun 2015 03:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=OfKFsDWtMOLLF2teZSjMJkQ1o+P501ZDbKN/0meMmyI=; b=aYOE0I3wboVUaJvd8bZniOCuXhT4BIPzC8Xb6WRxwSisqLNaj62aJMf14J1/axywJp 1FPQlob/my3dQbT6gpZQZZFAp0DNpDcbySW5ZHt2KvlNRF1VPOVarOtIj8hNDrGfN5fB Slw3jYm0aCvaRMxjkP+zbybMch0KF7RCS7XyNE5xeQiNmXfbQ++Mzg6Wd0T3tgXt66MI qRTHULSnsYTCgGVxEhD5yp9IxN49gwPYtwBGl3g77CWAu5B/bYguqxeQ+XtGY3MFoEHD 8+P0yA+dmlvfX9vVXThVnyr796djP9KTfCTlhKre5xTD6l9PPTENqAY1XfRs2j9rnFOU OSIw== X-Received: by 10.180.9.6 with SMTP id v6mr4589614wia.83.1433585975959; Sat, 06 Jun 2015 03:19:35 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id bg4sm14470685wjc.10.2015.06.06.03.19.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Jun 2015 03:19:35 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <5572C936.6070505@yandex.ru> Date: Sat, 6 Jun 2015 13:19:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87a8wdhka7.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/06/2015 01:17 AM, Juri Linkov wrote: > There is also grep-find-command used by grep-find. Indeed. That one I'd rather leave alone too. > Since there is a lot of %s-substitutions in grep-compute-defaults > that produce command lines depending on many customizations, Not that many. grep-program and grep-highlight-matches seem to be the only ones a user might want to change. Or rather, a user might change the former, and some function might want to change either. > yet another option is to let-bind the variables grep-command, > grep-find-command, grep-template, grep-find-template in your function, > then call grep-compute-defaults with a new value of grep-highlight-matches, > and then get new command lines without the --color option from > these local bindings to run them and parse the output programmatically. That's what zrgrep does, and its quite clunky. And if we have code to pre-compute commands and templates (which takes several external program calls), it's kind of silly to redo that again each time certain commands are called. Do you know if zrgrep has a good reason for it? Like, it there are platforms where we have to use different calling conventions for grep and zgrep? Otherwise, we could simply substitute grep-program value in the commands. > In case when users customize grep-highlight-matches interactively, > its defcustom should compute new command lines using grep-compute-defaults. Do you think, overall, it will be the better approach? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jun 2015 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org, Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143362836115148 (code B ref 20728); Sat, 06 Jun 2015 22:06:02 +0000 Received: (at 20728) by debbugs.gnu.org; 6 Jun 2015 22:06:01 +0000 Received: from localhost ([127.0.0.1]:43541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1ME4-0003wB-SW for submit@debbugs.gnu.org; Sat, 06 Jun 2015 18:06:01 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:34672 helo=homiemail-a19.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1ME3-0003w3-01 for 20728@debbugs.gnu.org; Sat, 06 Jun 2015 18:06:00 -0400 Received: from homiemail-a19.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a19.g.dreamhost.com (Postfix) with ESMTP id ED4B4604089; Sat, 6 Jun 2015 15:05:57 -0700 (PDT) Received: from localhost.linkov.net (m213-102-136-198.cust.tele2.ee [213.102.136.198]) (Authenticated sender: jurta@jurta.org) by homiemail-a19.g.dreamhost.com (Postfix) with ESMTPA id D0AE5604084; Sat, 6 Jun 2015 15:05:56 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> Date: Sun, 07 Jun 2015 01:04:57 +0300 In-Reply-To: <5572C936.6070505@yandex.ru> (Dmitry Gutov's message of "Sat, 6 Jun 2015 13:19:34 +0300") Message-ID: <874mmkfq7q.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > That's what zrgrep does, and its quite clunky. And if we have code to > pre-compute commands and templates (which takes several external program > calls), it's kind of silly to redo that again each time certain commands > are called. Thanks for mentioning zrgrep! I noticed that it's broken now and fixed with the patch that let-binds grep-highlight-matches before calling grep-compute-defaults since now it's computed here. > Do you know if zrgrep has a good reason for it? Like, it there are > platforms where we have to use different calling conventions for grep and > zgrep? Otherwise, we could simply substitute grep-program value in > the commands. String replacement is too unreliable approach. But I see no problem with both zrgrep and the code where you want to parse the output programmatically, to remember the computed command lines in defvar variables such as zgrep-find-command, zgrep-find-template, etc. to not compute them every time the command is called. >> In case when users customize grep-highlight-matches interactively, >> its defcustom should compute new command lines using grep-compute-defaults. > > Do you think, overall, it will be the better approach? Well, there are two levels of parametrization in grep.el: 1. grep-compute-defaults uses %s-substitutions to prepare command line templates with placeholders. 2. templates are expanded on every command call with regexps and files. When parameters don't vary between command calls (as regexps and files do) then I think it's better to prepare them in the command line templates. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jun 2015 22:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org, Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143371576311475 (code B ref 20728); Sun, 07 Jun 2015 22:23:01 +0000 Received: (at 20728) by debbugs.gnu.org; 7 Jun 2015 22:22:43 +0000 Received: from localhost ([127.0.0.1]:44370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1ixm-0002z0-DO for submit@debbugs.gnu.org; Sun, 07 Jun 2015 18:22:42 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37756) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z1ixk-0002ym-HB for 20728@debbugs.gnu.org; Sun, 07 Jun 2015 18:22:41 -0400 Received: by wifx6 with SMTP id x6so68023394wif.0 for <20728@debbugs.gnu.org>; Sun, 07 Jun 2015 15:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Ei34jdXqN3kJP0fNH/Xsw3+KK5CuiW3TY7VH+9S5s1Y=; b=P/FXAg0EgBCnTuXtsjJzfCNNxLIs4+rFqIpugKnERZAUfnAQY8Eyh/CUfAp2Np9ewM ROek5QYnEdxPDkLEKAGP1n06LfJlTobLgOPoH9lbaUYMYF0OaGSgoSyhEGGPqj/K2krO xkqMDrbR5L9v7vbsd1E2lJZOu9nqFcLYc8NUcfACXItIuJY8mif910WoR8+UV45bv4Hb edKOqex/Vx9DdN9aeLUBWjpf7wKpQNzNdJKGI2U0JqHwrl3vifoNK3mArZOPDYvdrWoD iw76NcOTJSsKdxEb5W2t3tsXHKAvAplWmil8VoEUMxzYZBRfJZp32SB6dke3qI7sVUP+ pkrg== X-Received: by 10.180.106.137 with SMTP id gu9mr16677118wib.54.1433715755034; Sun, 07 Jun 2015 15:22:35 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id r6sm8578918wiy.13.2015.06.07.15.22.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Jun 2015 15:22:34 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83eglsqjkr.fsf@gnu.org> <5570132A.9060109@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <5574C427.3070007@yandex.ru> Date: Mon, 8 Jun 2015 01:22:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <874mmkfq7q.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/07/2015 01:04 AM, Juri Linkov wrote: > Thanks for mentioning zrgrep! I noticed that it's broken now and fixed > with the patch that let-binds grep-highlight-matches before calling > grep-compute-defaults since now it's computed here. No problem. Could you explain what those filters are, the ones the comment says zgrep puts into output? > String replacement is too unreliable approach. I meant template substitution, like in grep-expand-template. Not sure what to do about grep-default-command, but if leaving it as-is is not an option, we can reasonably decide that the grep-command was the symbol at the beginning of the previous command. > But I see no problem with > both zrgrep and the code where you want to parse the output programmatically, > to remember the computed command lines in defvar variables such as > zgrep-find-command, zgrep-find-template, etc. to not compute them every > time the command is called. Again, why have zgrep-find-template, when grep-find-template could have a (new) placeholder for grep-command? Do zgrep and grep take different options? > When parameters don't vary between command calls (as regexps and files do) > then I think it's better to prepare them in the command line templates. Since grep-command and grep-highlight-matches can vary between calls, should we make a template placeholder for them? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jun 2015 23:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org, Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143389287013569 (code B ref 20728); Tue, 09 Jun 2015 23:35:02 +0000 Received: (at 20728) by debbugs.gnu.org; 9 Jun 2015 23:34:30 +0000 Received: from localhost ([127.0.0.1]:46499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2T2L-0003Wm-Kt for submit@debbugs.gnu.org; Tue, 09 Jun 2015 19:34:30 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:33322 helo=homiemail-a15.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2T2I-0003Wa-PF for 20728@debbugs.gnu.org; Tue, 09 Jun 2015 19:34:27 -0400 Received: from homiemail-a15.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTP id 46ACC76C079; Tue, 9 Jun 2015 16:34:25 -0700 (PDT) Received: from localhost.linkov.net (m213-102-136-198.cust.tele2.ee [213.102.136.198]) (Authenticated sender: jurta@jurta.org) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTPA id 0D80176C073; Tue, 9 Jun 2015 16:34:23 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> Date: Wed, 10 Jun 2015 02:32:35 +0300 In-Reply-To: <5574C427.3070007@yandex.ru> (Dmitry Gutov's message of "Mon, 8 Jun 2015 01:22:31 +0300") Message-ID: <87fv608nl8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > No problem. Could you explain what those filters are, the ones the comment > says zgrep puts into output? These are pipe filters. You can see how complex is the command line constructed in /bin/zgrep > I meant template substitution, like in grep-expand-template. > > Not sure what to do about grep-default-command, but if leaving it as-is is > not an option, we can reasonably decide that the grep-command was the > symbol at the beginning of the previous command. Then you want two additional placeholders: for the command name and options? >> But I see no problem with >> both zrgrep and the code where you want to parse the output programmatically, >> to remember the computed command lines in defvar variables such as >> zgrep-find-command, zgrep-find-template, etc. to not compute them every >> time the command is called. > > Again, why have zgrep-find-template, when grep-find-template could have > a (new) placeholder for grep-command? Do zgrep and grep take > different options? In an older version of /bin/zgrep I see the text "OPTIONs are the same as for 'grep'." I don't know about other versions. >> When parameters don't vary between command calls (as regexps and files do) >> then I think it's better to prepare them in the command line templates. > > Since grep-command and grep-highlight-matches can vary between calls, > should we make a template placeholder for them? There are only two possible values for grep-highlight-matches whereas the number of possible values of the current placeholders for regexps and filenames is infinite. I think the rule should be the following: placeholders are needed only for parameters provided by users, but for internal implementation parameters it's enough to pre-compute command lines (and cache them). PS: Somehow reminds me of endless discussions about distinctions between `error' and `user-error' :) From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2015 17:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143395894710804 (code B ref 20728); Wed, 10 Jun 2015 17:56:02 +0000 Received: (at 20728) by debbugs.gnu.org; 10 Jun 2015 17:55:47 +0000 Received: from localhost ([127.0.0.1]:47439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2kE6-0002oB-Ap for submit@debbugs.gnu.org; Wed, 10 Jun 2015 13:55:46 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37054) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2kE3-0002ny-H6 for 20728@debbugs.gnu.org; Wed, 10 Jun 2015 13:55:44 -0400 Received: by wifx6 with SMTP id x6so55281955wif.0 for <20728@debbugs.gnu.org>; Wed, 10 Jun 2015 10:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=3ZMoBkR1MyQ30CV5vRNiAd6stnQbQBx4zD8HJk7qIgI=; b=P4p5BOUWsrHBtn9SekGR5jQU/FeTYbgAu5bW66IqKbnteMxbq8WNgJtblUNARKlmW0 6LChhteI/VTSki+8cReH9Y8QHtSLBFxKs6t5Gfa3GzHNla20MkzFaVEIz3PWOj6eknnv 1iAphleqM0W5oYGlOsBOV9AYNggJeEEWWhRs6WhERKXYJS30FDQBpFTostLj4bpg0VeI cqDOFf39fmxCbmup4eX89pVZ87n0ytIQa7uggvzshZrLOJh88D9KwX4IANOp1F56MJvo Jw1CB5WvciLNkyYphZNmoy5S47Xeg0bk9hU8P3EJMy5wR8kmWdzMyJhNyeVQBHcg6fBM bApQ== X-Received: by 10.180.102.227 with SMTP id fr3mr20944980wib.19.1433958942815; Wed, 10 Jun 2015 10:55:42 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id hn7sm15596919wjc.16.2015.06.10.10.55.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jun 2015 10:55:42 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <838ubzqzz5.fsf@gnu.org> <55706C5F.6070903@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <55787A1D.9080601@yandex.ru> Date: Wed, 10 Jun 2015 20:55:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87fv608nl8.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/10/2015 02:32 AM, Juri Linkov wrote: > These are pipe filters. You can see how complex is the command line > constructed in /bin/zgrep I see, thanks. Apparently, the upshot is that --color=auto doesn't work. The nil value of grep-highlight-matches should still work, though. > Then you want two additional placeholders: for the command name and options? Yep! By the way, is already used to conditionally pass '-i'. We can reuse it to pass one more option. So, minus one new placeholder. > In an older version of /bin/zgrep I see the text "OPTIONs are the same as for 'grep'." > I don't know about other versions. Let's try it, then. > There are only two possible values for grep-highlight-matches > whereas the number of possible values of the current placeholders > for regexps and filenames is infinite. Right. That means that you can't precompute regexps and filenames, at all. That does not, however, mean that you *have to* precompute everything else. > I think the rule should be the following: placeholders are needed only for > parameters provided by users, but for internal implementation parameters > it's enough to pre-compute command lines (and cache them). Even if "internal" parameters vary between commands that use the same template? I disagree. If we can expand those parameters dynamically, we should. By the way, `grep-highlight-matches' is an option that the user can change via Customize, but the setter only calls `grep-apply-setting'. > PS: Somehow reminds me of endless discussions about distinctions > between `error' and `user-error' :) I don't remember, but `user-error' won, hasn't it? The main question now regarding it, is find and change all applicable uses of `error'. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2015 23:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143398024024772 (code B ref 20728); Wed, 10 Jun 2015 23:51:03 +0000 Received: (at 20728) by debbugs.gnu.org; 10 Jun 2015 23:50:40 +0000 Received: from localhost ([127.0.0.1]:49934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2plX-0006RU-Bt for submit@debbugs.gnu.org; Wed, 10 Jun 2015 19:50:39 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:40523 helo=homiemail-a75.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2plV-0006RL-IP for 20728@debbugs.gnu.org; Wed, 10 Jun 2015 19:50:38 -0400 Received: from homiemail-a75.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTP id A01005EC082; Wed, 10 Jun 2015 16:50:36 -0700 (PDT) Received: from localhost.linkov.net (m213-102-136-198.cust.tele2.ee [213.102.136.198]) (Authenticated sender: jurta@jurta.org) by homiemail-a75.g.dreamhost.com (Postfix) with ESMTPA id 9C8595EC081; Wed, 10 Jun 2015 16:50:35 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> Date: Thu, 11 Jun 2015 02:49:59 +0300 In-Reply-To: <55787A1D.9080601@yandex.ru> (Dmitry Gutov's message of "Wed, 10 Jun 2015 20:55:41 +0300") Message-ID: <87wpzbaztk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > By the way, is already used to conditionally pass '-i'. We can reuse it > to pass one more option. So, minus one new placeholder. With the mnemonics = :) OTOH, null-device has a separate placeholder . >> PS: Somehow reminds me of endless discussions about distinctions >> between `error' and `user-error' :) > > I don't remember, but `user-error' won, hasn't it? The main question now > regarding it, is find and change all applicable uses of `error'. I don't care about formal criteria of changing `error' to `user-error', my approach is driven by practical needs like in bug#20785. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jun 2015 07:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14340073949267 (code B ref 20728); Thu, 11 Jun 2015 07:24:02 +0000 Received: (at 20728) by debbugs.gnu.org; 11 Jun 2015 07:23:14 +0000 Received: from localhost ([127.0.0.1]:50079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2wpV-0002PN-0T for submit@debbugs.gnu.org; Thu, 11 Jun 2015 03:23:13 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:35195) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z2wpS-0002P7-En for 20728@debbugs.gnu.org; Thu, 11 Jun 2015 03:23:10 -0400 Received: by wiga1 with SMTP id a1so67080596wig.0 for <20728@debbugs.gnu.org>; Thu, 11 Jun 2015 00:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=5HMUSCVh5UQ0fmM+HoMLlwxh2BYFehVFlaA0eot+kU8=; b=wUxKLYSXU76tsbYgZMJmeM0LtzUuxZhwPxXprW6uwsMK/ooE7+oEgPIDJWWAFkT0vu 6MhKZpRiT+wJqPhRI+sPuPLWokqcl8wOZKx/+UBwKbMav/n8KaKlyVUCE8oXATolMn6A 7e+Z0O3a8RFynxoRc99F5nglLkYsiA7PaHxReMxRLWFPJa9JkSGS0alzBC4PBA5gV5I2 ZK7WUu52NQM+a+2WiFtcNn18hsaSmcorwnoacZHP+fsAT4Bk15OD3BQ94r/Y4NVDOvUj /fsPsqeRD14jmh0nZlylXanIOa0FuU3xCDVZzrww4jbPR8TbF0XKp2h0C8KTuFGbnTe1 wspQ== X-Received: by 10.194.192.166 with SMTP id hh6mr13478068wjc.127.1434007384867; Thu, 11 Jun 2015 00:23:04 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id ul1sm17985827wjc.30.2015.06.11.00.23.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jun 2015 00:23:04 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <833827qyg5.fsf@gnu.org> <55707074.8010607@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <55793756.9070505@yandex.ru> Date: Thu, 11 Jun 2015 10:23:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87wpzbaztk.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/11/2015 02:49 AM, Juri Linkov wrote: > With the mnemonics = :) Rename it, then? But I'd be fine with keeping the "wrong" letter for compatibility with templates set by third-party code, if there's any. > OTOH, null-device has a separate placeholder . And it seems to never be used anywhere. Again, grep-compute-defaults inlines the appropriate value in the templates. Maybe we should remove the mentions of it from the docstrings. > I don't care about formal criteria of changing `error' to `user-error', > my approach is driven by practical needs I think those are one and the same. :) From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jun 2015 23:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14340648779071 (code B ref 20728); Thu, 11 Jun 2015 23:22:02 +0000 Received: (at 20728) by debbugs.gnu.org; 11 Jun 2015 23:21:17 +0000 Received: from localhost ([127.0.0.1]:51114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Bmd-0002ME-Vc for submit@debbugs.gnu.org; Thu, 11 Jun 2015 19:21:16 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:42115 helo=homiemail-a11.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z3Bmc-0002M7-Mf for 20728@debbugs.gnu.org; Thu, 11 Jun 2015 19:21:15 -0400 Received: from homiemail-a11.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a11.g.dreamhost.com (Postfix) with ESMTP id 39EFA6E07E; Thu, 11 Jun 2015 16:21:14 -0700 (PDT) Received: from localhost.linkov.net (m83-187-196-182.cust.tele2.ee [83.187.196.182]) (Authenticated sender: jurta@jurta.org) by homiemail-a11.g.dreamhost.com (Postfix) with ESMTPA id 4D36C6E07C; Thu, 11 Jun 2015 16:21:13 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> Date: Fri, 12 Jun 2015 02:20:28 +0300 In-Reply-To: <55793756.9070505@yandex.ru> (Dmitry Gutov's message of "Thu, 11 Jun 2015 10:23:02 +0300") Message-ID: <87a8w53k8z.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> With the mnemonics = :) > > Rename it, then? But I'd be fine with keeping the "wrong" letter for > compatibility with templates set by third-party code, if there's any. Yes, it's out of the question that we should keep the original letters. >> OTOH, null-device has a separate placeholder . > > And it seems to never be used anywhere. Again, grep-compute-defaults > inlines the appropriate value in the templates. Here again the same question: how different is null-device from grep-highlight-matches that null-device should be inlined in the templates by grep-compute-defaults while grep-highlight-matches shouldn't? > Maybe we should remove the mentions of it from the docstrings. I wonder how many third-party code uses the templates with that it needs to be documented. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2015 00:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143493417528301 (code B ref 20728); Mon, 22 Jun 2015 00:50:03 +0000 Received: (at 20728) by debbugs.gnu.org; 22 Jun 2015 00:49:35 +0000 Received: from localhost ([127.0.0.1]:53700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6pvb-0007MP-BX for submit@debbugs.gnu.org; Sun, 21 Jun 2015 20:49:35 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:35576) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z6pvZ-0007MB-JE for 20728@debbugs.gnu.org; Sun, 21 Jun 2015 20:49:34 -0400 Received: by wgbhy7 with SMTP id hy7so128334874wgb.2 for <20728@debbugs.gnu.org>; Sun, 21 Jun 2015 17:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=IPrS5i0bu7PkhLJWLizTWzv47X9M4OLvV2eg+5jSQxw=; b=MEL/BfO+tBQaFMQQJsPsZ/z1S4ui1piub2/WDohy+CVKztHCf0ABcuHzL28htA8As/ Rh6iTDCvmaW+7/tAACHicIDV2oS3FSv8/JS8HrwVBvIevdGMaHZgnbac40I0l07nMu3H WUGG+bGz1ult23xYqVr1/+e4+NSHXOckjcu4LYTJQI+Bao8AdljJIori7LsFek7bboUP R+DOeChbITQNQDQy9nqAVjqGccA5xAMlNAt0g2Nj/NqUSps5l1ZQdOpL37eX7/y8kPvO gjMsKkEa4+8Ig9wZLu1sRBoF4U6TJ74kXymY6E460E9zzOz3Y3dVXAuVLmHcgH55Tz2b UxDg== X-Received: by 10.194.94.101 with SMTP id db5mr17645709wjb.91.1434934167623; Sun, 21 Jun 2015 17:49:27 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id fx7sm27877605wjb.10.2015.06.21.17.49.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Jun 2015 17:49:27 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <55875B92.7030506@yandex.ru> Date: Mon, 22 Jun 2015 03:49:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87a8w53k8z.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/12/2015 02:20 AM, Juri Linkov wrote: > Here again the same question: how different is null-device from > grep-highlight-matches that null-device should be inlined in the > templates by grep-compute-defaults while grep-highlight-matches shouldn't? I wouldn't say "should", just that so far we haven't seen the need to substitute it in (no function in the core binds that value dynamically). > I wonder how many third-party code uses the templates with > that it needs to be documented. Doing a quick search on GitHub, I couldn't find any of those. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jun 2015 22:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14350127983546 (code B ref 20728); Mon, 22 Jun 2015 22:40:03 +0000 Received: (at 20728) by debbugs.gnu.org; 22 Jun 2015 22:39:58 +0000 Received: from localhost ([127.0.0.1]:54751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7ANi-0000v7-7Y for submit@debbugs.gnu.org; Mon, 22 Jun 2015 18:39:58 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:38552 helo=homiemail-a22.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7ANf-0000us-0d for 20728@debbugs.gnu.org; Mon, 22 Jun 2015 18:39:55 -0400 Received: from homiemail-a22.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTP id D05861A8069; Mon, 22 Jun 2015 15:39:53 -0700 (PDT) Received: from localhost.linkov.net (m213-102-70-120.cust.tele2.ee [213.102.70.120]) (Authenticated sender: jurta@jurta.org) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTPA id DFEB41A8076; Mon, 22 Jun 2015 15:39:52 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <55875B92.7030506@yandex.ru> Date: Tue, 23 Jun 2015 01:33:03 +0300 In-Reply-To: <55875B92.7030506@yandex.ru> (Dmitry Gutov's message of "Mon, 22 Jun 2015 03:49:22 +0300") Message-ID: <877fqvwesw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> I wonder how many third-party code uses the templates with >> that it needs to be documented. > > Doing a quick search on GitHub, I couldn't find any of those. Is there a search on ELPA and other package repositories like listed in (info "(efaq) Packages that do not come with Emacs")? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jun 2015 00:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143501964113935 (code B ref 20728); Tue, 23 Jun 2015 00:34:02 +0000 Received: (at 20728) by debbugs.gnu.org; 23 Jun 2015 00:34:01 +0000 Received: from localhost ([127.0.0.1]:54777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7CA4-0003ch-HQ for submit@debbugs.gnu.org; Mon, 22 Jun 2015 20:34:00 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:36348) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z7CA1-0003cQ-FD for 20728@debbugs.gnu.org; Mon, 22 Jun 2015 20:33:58 -0400 Received: by wguu7 with SMTP id u7so82529115wgu.3 for <20728@debbugs.gnu.org>; Mon, 22 Jun 2015 17:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=1aAZl9Ht7m8KPw79+0tGimqiBqhnSH1PI4vQxbTHExQ=; b=z3FX6wGTQAasNEaItF6CNYPfVYyvCKK19WpMTaG8ZsJCkV3zF3G6SUwo1zpt38Tq+/ cc1/pW+JUK55Pgz8t0Er2JyoLDWnVEq+dJ0S0b+aVvXj0WrZ6YsQHWrG04CfINEbZA++ BW4yEfeA1WBzVWUhw5BXs+6WQm4jUvBbyUo5Ttmj9lnB41LHWKbxxqRmneg87as+DwQz L6LZH3C/EF8pTelHtp6wvX4sjfVI6fFOA/Dk9J+ZSY3pIOWq6LGp/hMXq5/saoivYx9J sUPg8//Zi7A5TqLQzIvgxzniyEIxPmtFC84xXy8AINw1IIh8StcEcJN3DmOeZvGfFRuz 5lkQ== X-Received: by 10.180.106.137 with SMTP id gu9mr37488223wib.54.1435019626755; Mon, 22 Jun 2015 17:33:46 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id dz4sm19668860wib.17.2015.06.22.17.33.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 17:33:46 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <55875B92.7030506@yandex.ru> <877fqvwesw.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <5588A969.1090907@yandex.ru> Date: Tue, 23 Jun 2015 03:33:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <877fqvwesw.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/23/2015 01:33 AM, Juri Linkov wrote: > Is there a search on ELPA and other package repositories like > listed in (info "(efaq) Packages that do not come with Emacs")? You can clone the GNU ELPA repo and rgrep for grep-template or grep-find-template (there are no matches). Regarding the other repositories, there's probably nothing better we can do aside from doing a search on GitHub or a web search engine. From unknown Tue Aug 12 08:33:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Dmitry Gutov Subject: bug#20728: closed (Re: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument) Message-ID: References: <558F1186.50303@yandex.ru> <86bngws6il.fsf@yandex.ru> X-Gnu-PR-Message: they-closed 20728 X-Gnu-PR-Package: emacs Reply-To: 20728@debbugs.gnu.org Date: Sat, 27 Jun 2015 21:12:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1435439522-481-1" This is a multi-part message in MIME format... ------------=_1435439522-481-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20728: 25.0.50; grep and grep-find templates should have a place holder fo= r the --color argument which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20728@debbugs.gnu.org. --=20 20728: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20728 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1435439522-481-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20728-done) by debbugs.gnu.org; 27 Jun 2015 21:11:47 +0000 Received: from localhost ([127.0.0.1]:59508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8xO6-00007J-DZ for submit@debbugs.gnu.org; Sat, 27 Jun 2015 17:11:46 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37835) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8xO3-000073-Oj for 20728-done@debbugs.gnu.org; Sat, 27 Jun 2015 17:11:44 -0400 Received: by wicgi11 with SMTP id gi11so43165745wic.0 for <20728-done@debbugs.gnu.org>; Sat, 27 Jun 2015 14:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=SRqg+bduf2tzqO70XR5UCvhCYl6rKA00PNjZadLhEqE=; b=STJerTtv0ss0k7TZxHaA+y9p0yybIl7qdPNgke+RIc0D7tR1CRN5VQbZsvmgr1hb9M At1ibSThi3YLohqHtUNQp2R8rF/HTG8VOXO0AmfAzw7UD1zU+DHj4WBsCUg2eKjMNNxQ RidWgUiXKWbnWst6Z70Mv5YDGRTmXfgMtyU+GE3FdvFMP4wNIk3j0OjHIWYC6Ny4o7Yi gRAbUFctnCxwcCN/TyAhP+0lVAoMUBDZwXtkNdLy/Gf5HezxjanE+8Sv+mop75rlSehb D1fYaoR01tuhi0n+v2UftCTx1yh1QHyPBuwhDNGkekrG3NeZSvZcW+SzW1gh2SPr+t3B hpPw== X-Received: by 10.180.73.236 with SMTP id o12mr8791980wiv.56.1435439498143; Sat, 27 Jun 2015 14:11:38 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id lk5sm4488658wic.24.2015.06.27.14.11.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jun 2015 14:11:37 -0700 (PDT) Subject: Re: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument To: Juri Linkov References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <558F1186.50303@yandex.ru> Date: Sun, 28 Jun 2015 00:11:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87a8w53k8z.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20728-done Cc: 20728-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 25.1 On 06/12/2015 02:20 AM, Juri Linkov wrote: > Yes, it's out of the question that we should keep the original letters. I've just pushed a commit that reuses for both -i and --color (ase and olor, we can still pretend it's mnemonical), simply because there are templates out there with in them, which do not include "--color". If anyone really wants to change it to , be my guest. > I wonder how many third-party code uses the templates with > that it needs to be documented. I haven't found any. OTOH, it doesn't hurt anyone either. Maybe the right change would be to make the code use it, actually. Are there use cases for changing the value of null-decide dynamically? And speaking of needs, what is the use case for "--color" without "always"? Instead of special-casing Windows and DOS, why don't we always use `always' for coloring? ------------=_1435439522-481-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Jun 2015 23:43:27 +0000 Received: from localhost ([127.0.0.1]:39569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0IJi-0000ff-FQ for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35300) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z0IJf-0000fR-Vg for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0IJZ-0006UK-Lk for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0IJZ-0006UG-JA for submit@debbugs.gnu.org; Wed, 03 Jun 2015 19:43:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0IJY-0005ma-GA for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 19:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z0IJU-0006QI-Dj for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 19:43:16 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:34308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z0IJU-0006Ge-7H for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2015 19:43:12 -0400 Received: by wibut5 with SMTP id ut5so4012700wib.1 for ; Wed, 03 Jun 2015 16:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=ckubaX3ZY1p5a2dkpEjbzjHD/bygrP2u5KQA2FsK6t8=; b=LEU1mOOc/YbobI6qTLG2TLd6V1rG9HPAzaxfvmkEkVTkS4+qpD2DdMfGcC5Xe2R2qI YeT0Oqkp5AdPG8/fRxaDR5il7FMF5Uh5DNSWfEgGn+x//2Cz1uBiakVF8C9deHbMmmr+ 5odKy3cR6QSOObJGM0rAEHUt2cGwFpd1f1zJpQbbC2D349kXBhlFFg4D9F2zQNZjqojh dBYAo8C5URTsdBI1YvPGJjchED4tIgFqP5wQROg9/djiqTH6tzoMLJj2ZewCllkIhM5A gxNcHqWRIYM4+DPkE15bWVFewyc8lSWcO3dx3yQFmIGACuE38VWVs66+ObYNAY+Jc74o sbUA== X-Received: by 10.194.205.101 with SMTP id lf5mr66380603wjc.42.1433374981194; Wed, 03 Jun 2015 16:43:01 -0700 (PDT) Received: from axl ([82.102.93.54]) by mx.google.com with ESMTPSA id q4sm3168226wja.24.2015.06.03.16.43.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jun 2015 16:43:00 -0700 (PDT) From: Dmitry Gutov To: bug-gnu-emacs@gnu.org Subject: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Date: Thu, 04 Jun 2015 02:42:58 +0300 Message-ID: <86bngws6il.fsf@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) And fill it in dynamically during expansion. This way, the caller can set grep-highlight-matches dynamically, without recomputing grep defaults (which is expensive). This is particularly relevant on MS-Windows, in semantic-symref-grep-use-template and xref-collect-matches. ------------=_1435439522-481-1-- From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jun 2015 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14354454779189 (code B ref 20728); Sat, 27 Jun 2015 22:52:01 +0000 Received: (at 20728) by debbugs.gnu.org; 27 Jun 2015 22:51:17 +0000 Received: from localhost ([127.0.0.1]:59545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8ywO-0002O8-JM for submit@debbugs.gnu.org; Sat, 27 Jun 2015 18:51:16 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:56233 helo=homiemail-a20.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z8ywN-0002O1-9R for 20728@debbugs.gnu.org; Sat, 27 Jun 2015 18:51:15 -0400 Received: from homiemail-a20.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTP id 213867EC064; Sat, 27 Jun 2015 15:51:14 -0700 (PDT) Received: from localhost.linkov.net (m83-191-200-217.cust.tele2.ee [83.191.200.217]) (Authenticated sender: jurta@jurta.org) by homiemail-a20.g.dreamhost.com (Postfix) with ESMTPA id 2786B7EC063; Sat, 27 Jun 2015 15:51:12 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET References: <86bngws6il.fsf@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> Date: Sun, 28 Jun 2015 01:49:36 +0300 In-Reply-To: <558F1186.50303@yandex.ru> (Dmitry Gutov's message of "Sun, 28 Jun 2015 00:11:34 +0300") Message-ID: <87y4j4ydfj.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > I've just pushed a commit that reuses for both -i and --color (ase > and olor, we can still pretend it's mnemonical), simply because there > are templates out there with in them, which do not include "--color". Does zgrep still work after your changes? > I haven't found any. OTOH, it doesn't hurt anyone either. Maybe the right > change would be to make the code use it, actually. Are there use cases for > changing the value of null-decide dynamically? This is only a hypothetical case. > And speaking of needs, what is the use case for "--color" without "always"? > Instead of special-casing Windows and DOS, why don't we always use `always' > for coloring? Maybe some users don't want highlighting? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 01:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143545455422236 (code B ref 20728); Sun, 28 Jun 2015 01:23:02 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 01:22:34 +0000 Received: from localhost ([127.0.0.1]:59577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z91In-0005mZ-IK for submit@debbugs.gnu.org; Sat, 27 Jun 2015 21:22:33 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36128) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z91Ik-0005mM-Lh for 20728@debbugs.gnu.org; Sat, 27 Jun 2015 21:22:31 -0400 Received: by wicnd19 with SMTP id nd19so44402951wic.1 for <20728@debbugs.gnu.org>; Sat, 27 Jun 2015 18:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Hy/Jp3uy1lFXPR9w4MEJz11IsDSYOcdU+5AbJW5mpsw=; b=eXTIn1IXILuuYI6pU87LvXGFkGbI4EwnesRsKBmEEammcAdovjMGov+liLMj2jvNmu VgB1aUosyACWOTElg9ZbNSmuU1EkbykzS79/a4XEFt536G2Gbf9d7jtKmpimqBydmevC hdQ7Om25tGWmes2YFGuAblYzFtSSQq8nmtaYUy49NahgY4uLSwHhli10o7fjGdgSBAaU 7ZVxynUdgkiuTh+M9HYjYT6i4HoeJve5fxqcA+3RqgOttjjrcd6OIT+HEvu0rE3fk+Ny V17MLB8aWQV0D04hhBLPjhGi0KBZBYeANIry8K6HYmpkJTvzf3zlhQC2ME0Wyi6zdnEw SX7w== X-Received: by 10.180.101.233 with SMTP id fj9mr9655309wib.45.1435454545007; Sat, 27 Jun 2015 18:22:25 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id x10sm57220314wjf.45.2015.06.27.18.22.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jun 2015 18:22:24 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <87y4j4ydfj.fsf@mail.linkov.net> From: Dmitry Gutov Message-ID: <558F4C4D.8090408@yandex.ru> Date: Sun, 28 Jun 2015 04:22:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <87y4j4ydfj.fsf@mail.linkov.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/28/2015 01:49 AM, Juri Linkov wrote: > Does zgrep still work after your changes? It does. > This is only a hypothetical case. Sure. > Maybe some users don't want highlighting? Then they'll set grep-highlight-matches to nil, and there won't be a --color option in the constructed command at all. What I'm asking is, on the other hand, why do we sometimes pass --color, but not --color=always? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 01:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143545556623864 (code B ref 20728); Sun, 28 Jun 2015 01:40:03 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 01:39:26 +0000 Received: from localhost ([127.0.0.1]:59590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z91Z8-0006Cq-Hq for submit@debbugs.gnu.org; Sat, 27 Jun 2015 21:39:26 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:36694) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z91Z6-0006Cd-ET for 20728@debbugs.gnu.org; Sat, 27 Jun 2015 21:39:25 -0400 Received: by wguu7 with SMTP id u7so115006977wgu.3 for <20728@debbugs.gnu.org>; Sat, 27 Jun 2015 18:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Ujr+9DeUxWakHJ0FZOD42AbrOoyTwRNyfw1AEgnhn8o=; b=ZXApmb2xRqRV3ZjWdz7lNvMuBih5bHse9FCoYNJUcYiy8iM3n391AUP2MwP3xWPj99 s/ee0gayzi4Uc7gGjLZuK6LxERhoQ5Gn9ec3zpPAI1Rbt06LVoG/GjFo23Fb0FRtgTZ5 UyJzFUIOVY9/cJY4np4TIqFNR/1FW5RUbtLTtXA+Bvs6eeS2v0Lnx69SJ4cHtDS5ppWx lHEqOek4ZKLkQ6PgPFq/rmUUv1Uunuz9MQ5XqGcPbmkTKY8znP2foBCGCS3pKZyttP2B fJYno+rZLPlb5aw+XckmYlgtVjt9kNxedtI0J2hciEJSaw8706YvbX3/wtDECc4swrlI 3NkQ== X-Received: by 10.180.11.174 with SMTP id r14mr10175123wib.72.1435455558687; Sat, 27 Jun 2015 18:39:18 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id z9sm5299970wiv.9.2015.06.27.18.39.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 27 Jun 2015 18:39:18 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <87y4j4ydfj.fsf@mail.linkov.net> <558F4C4D.8090408@yandex.ru> From: Dmitry Gutov Message-ID: <558F5043.6040300@yandex.ru> Date: Sun, 28 Jun 2015 04:39:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <558F4C4D.8090408@yandex.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/28/2015 04:22 AM, Dmitry Gutov wrote: >> Does zgrep still work after your changes? > > It does. Sorry, spoke too soon. The highlighting is fixed now. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 02:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143545933229228 (code B ref 20728); Sun, 28 Jun 2015 02:43:02 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 02:42:12 +0000 Received: from localhost ([127.0.0.1]:59594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z92Xr-0007bL-AC for submit@debbugs.gnu.org; Sat, 27 Jun 2015 22:42:11 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:45654) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z92Xo-0007ay-DH for 20728@debbugs.gnu.org; Sat, 27 Jun 2015 22:42:09 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NQM00500V4W6U00@mtaout25.012.net.il> for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 05:37:47 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQM00KSIVAZMIC0@mtaout25.012.net.il>; Sun, 28 Jun 2015 05:37:47 +0300 (IDT) Date: Sun, 28 Jun 2015 05:42:00 +0300 From: Eli Zaretskii In-reply-to: <558F1186.50303@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <834mls7dvr.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Dmitry Gutov > Date: Sun, 28 Jun 2015 00:11:34 +0300 > Cc: 20728-done@debbugs.gnu.org > > And speaking of needs, what is the use case for "--color" without > "always"? Instead of special-casing Windows and DOS, why don't we always > use `always' for coloring? Isn't it the other way around: Windows wants 'always' (except when it doesn't, see below), while others want 'auto'? As to when you won't want 'always': it's when Grep is invoked as part pf a pipeline, where it's not the last part, or when the Lisp program that invokes it wants to interpret the results, as opposed to showing them to the user. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 08:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143547876926345 (code B ref 20728); Sun, 28 Jun 2015 08:07:02 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 08:06:09 +0000 Received: from localhost ([127.0.0.1]:59632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z97bM-0006qq-1d for submit@debbugs.gnu.org; Sun, 28 Jun 2015 04:06:08 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:34403) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z97bG-0006qG-Jv for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 04:06:04 -0400 Received: by wicnd19 with SMTP id nd19so74922530wic.1 for <20728@debbugs.gnu.org>; Sun, 28 Jun 2015 01:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=jPaT+mm/VdelUxnWANfsg2Gdh7RHBCjqryRzIudVSug=; b=QyocE1lYmuoj3LaLXHB+XiH4gR+xCQNxRdcDF2V8JGiQBrfm5jhQ72S08AsoVS+Pgz BAat3ORcslw+Cwxn0J9deHcS7OBM+Lf006dBoTP6KODkiOcwMGh9unPtaR2Z/qdW0/vO uKuv4lwN5mbrJITBBJG41eAQggGwoBjcnNfuAXMuAbJDUAgS1xhxnTgr1WEcQ0ixAW6F 0Mygi0rL1NRNGITfZ6Di2KSThSJ771a8yICLCruD9r/txT+FW2uhMNbErzRatyD0JPZE FZ5MKqJH1E5ouiNyO4HaPA9epKSqUf6eVkdq052vBRc9EtQhIX+LcNg5670a0S/XtgIN xpGA== X-Received: by 10.180.90.241 with SMTP id bz17mr10981142wib.95.1435478756687; Sun, 28 Jun 2015 01:05:56 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id d3sm58152994wjs.21.2015.06.28.01.05.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jun 2015 01:05:56 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> From: Dmitry Gutov Message-ID: <558FAAE0.6020805@yandex.ru> Date: Sun, 28 Jun 2015 11:05:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <834mls7dvr.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/28/2015 05:42 AM, Eli Zaretskii wrote: > Isn't it the other way around: Windows wants 'always' (except when it > doesn't, see below), while others want 'auto'? When will `always' not work for the others? > As to when you won't want 'always': it's when Grep is invoked as part > pf a pipeline, where it's not the last part, or when the Lisp program > that invokes it wants to interpret the results, as opposed to showing > them to the user. I'd want `nil' in that case, right? And I'd have to specify it explicitly anyway, if I want compatibility with Windows. So, why do we use `auto'? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14355021432486 (code B ref 20728); Sun, 28 Jun 2015 14:36:02 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 14:35:43 +0000 Received: from localhost ([127.0.0.1]:60498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9DgM-0000e1-64 for submit@debbugs.gnu.org; Sun, 28 Jun 2015 10:35:42 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:47911) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9DgI-0000dj-SL for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 10:35:40 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NQN00A00RY4ZR00@mtaout24.012.net.il> for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 17:26:57 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQN00P9CS4W1HC0@mtaout24.012.net.il>; Sun, 28 Jun 2015 17:26:57 +0300 (IDT) Date: Sun, 28 Jun 2015 17:35:32 +0300 From: Eli Zaretskii In-reply-to: <558FAAE0.6020805@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83381b7vez.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Sun, 28 Jun 2015 11:05:52 +0300 > > On 06/28/2015 05:42 AM, Eli Zaretskii wrote: > > > Isn't it the other way around: Windows wants 'always' (except when it > > doesn't, see below), while others want 'auto'? > > When will `always' not work for the others? I answered that below: > > As to when you won't want 'always': it's when Grep is invoked as part > > pf a pipeline, where it's not the last part, or when the Lisp program > > that invokes it wants to interpret the results, as opposed to showing > > them to the user. > I'd want `nil' in that case, right? In which case? And what do you mean by 'nil' in this context? We are talking about the value of the --color= Grep option, don't we? > And I'd have to specify it explicitly anyway, if I want > compatibility with Windows. You lost me. > So, why do we use `auto'? My guess would be: because it mostly does what we want, AUTOmatically: it produces SGR color sequences when Grep is run as a subprocess via a pty, and does not produce them when Grep's output is a pipe. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143551815426579 (code B ref 20728); Sun, 28 Jun 2015 19:03:01 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 19:02:34 +0000 Received: from localhost ([127.0.0.1]:60609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Hqb-0006ub-OC for submit@debbugs.gnu.org; Sun, 28 Jun 2015 15:02:34 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:34830) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9HqZ-0006uP-V0 for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 15:02:32 -0400 Received: by wiga1 with SMTP id a1so54252284wig.0 for <20728@debbugs.gnu.org>; Sun, 28 Jun 2015 12:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=tqTw+PclgCn8ba4sjU5z+J+TJZkliYhkPHZqWEEmONQ=; b=HH7g8LTtNj/9qIKGGAt1FiPdXF8sZn1M3+fNjP6BtAmgjrMeMZvAf19CxcBsJ3mwQ1 oAmwKXVqnMfRNZjILAFJ5Mp9QevRrBGNk+70erSgxkV/ABHMFJKr21iyvKmNNQkvbqPP 5z//FwCg72DfRHzs4fANoH9LpLWJLjSeXxOOvZJuSVO0kRO9NJnHFFPl057qzclRraw1 onL77+rCHIHVEBBKHFLYFZe3GKyf2RshQGraFgynoBsdRmVhMersvqo+InI5OTxDSfah apeE+FAcIkCRdq9W+qF7HXBBDqQ2tiURq4FS2FOyx3AGP6gymNUX5Ap/F1VzAQCO5V/x /6EA== X-Received: by 10.194.201.71 with SMTP id jy7mr22676312wjc.93.1435518146346; Sun, 28 Jun 2015 12:02:26 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id sc16sm22555052wjb.28.2015.06.28.12.02.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jun 2015 12:02:26 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> From: Dmitry Gutov Message-ID: <559044BD.4030703@yandex.ru> Date: Sun, 28 Jun 2015 22:02:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83381b7vez.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/28/2015 05:35 PM, Eli Zaretskii wrote: >>> Isn't it the other way around: Windows wants 'always' (except when it >>> doesn't, see below), while others want 'auto'? >> >> When will `always' not work for the others? > > I answered that below: No: when will a given command's behavior on other operating systems be wrong if it was just written to work on Windows (and thus uses either `always' or nil, not `auto')? >>> As to when you won't want 'always': it's when Grep is invoked as part >>> pf a pipeline, where it's not the last part, Do we have any such commands? If so, would it hurt them to have to bind `grep-highlight-matches' to nil? >>> or when the Lisp program >>> that invokes it wants to interpret the results, as opposed to showing >>> them to the user. Again, any such command will need to bind `grep-highlight-matches' to nil, to work on Windows. Or neutralize some other way the value `always' that it gets set to automatically, on Windows and DOS. >> I'd want `nil' in that case, right? > > In which case? And what do you mean by 'nil' in this context? We are > talking about the value of the --color= Grep option, don't we? In either case: when the pipeline ends with something other than Grep, or when we'll process the output programmatically, and don't need the ANSI codes. I'm talking about the value of `grep-highlight-matches'. >> And I'd have to specify it explicitly anyway, if I want >> compatibility with Windows. > > You lost me. See above. >> So, why do we use `auto'? > > My guess would be: because it mostly does what we want, AUTOmatically: > it produces SGR color sequences when Grep is run as a subprocess via a > pty, and does not produce them when Grep's output is a pipe. Do we even have Grep-related commands that use a pipeline that doesn't end with Grep? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14355232932075 (code B ref 20728); Sun, 28 Jun 2015 20:29:02 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 20:28:13 +0000 Received: from localhost ([127.0.0.1]:60623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9JBU-0000XO-93 for submit@debbugs.gnu.org; Sun, 28 Jun 2015 16:28:12 -0400 Received: from mtaout26.012.net.il ([80.179.55.182]:56397) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9JBQ-0000Wx-Uo for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 16:28:09 -0400 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0NQO00C008G3NF00@mtaout26.012.net.il> for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 23:30:44 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQO007YR8Z8NT70@mtaout26.012.net.il>; Sun, 28 Jun 2015 23:30:44 +0300 (IDT) Date: Sun, 28 Jun 2015 23:28:03 +0300 From: Eli Zaretskii In-reply-to: <559044BD.4030703@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83fv5b60j0.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Sun, 28 Jun 2015 22:02:21 +0300 > > On 06/28/2015 05:35 PM, Eli Zaretskii wrote: > > >>> Isn't it the other way around: Windows wants 'always' (except when it > >>> doesn't, see below), while others want 'auto'? > >> > >> When will `always' not work for the others? > > > > I answered that below: > > No: when will a given command's behavior on other operating systems be > wrong if it was just written to work on Windows (and thus uses either > `always' or nil, not `auto')? See cedet/semantic/symref/grep.el for when we don't want 'always'. > Do we even have Grep-related commands that use a pipeline that doesn't > end with Grep? I don't know. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jun 2015 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14355235032613 (code B ref 20728); Sun, 28 Jun 2015 20:32:02 +0000 Received: (at 20728) by debbugs.gnu.org; 28 Jun 2015 20:31:43 +0000 Received: from localhost ([127.0.0.1]:60627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9JEs-0000g5-SO for submit@debbugs.gnu.org; Sun, 28 Jun 2015 16:31:43 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:34372) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9JEr-0000fo-0k for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 16:31:41 -0400 Received: by wgqq4 with SMTP id q4so125816168wgq.1 for <20728@debbugs.gnu.org>; Sun, 28 Jun 2015 13:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=PjN38d0XPb3NjlMrv7A1LIvQDmB3HtcF0An/z1b/cog=; b=RlGwxQywjtmBcGiNo4jyeYN/HaFAlUmu/jGv/DpZryPx7JzRyXsJqDVgQYRVnEVcfZ 9yZ1npuyIWTIOKkUz9xVmA7hhnjA5TWVBvovrXpjgWZzZVs4nqUJOYiU9WqG4wb+yb6M Bs2LG4bj1tEaF4hsW3gWnIHe5WgfQy2F6J2z8snsocKK51TkUMX437a9OzyZA6V/xpAT nNWzQkTNXInn6mHVl2HLlENYjPQ7vQoV3KFZ7fqFCQL39kNoknlloJMElN5LCJRRryC0 eoXwwdEKBfJnv3EEDcQeaO6wGlprWtLLLic9amfln30DiLKAPi2YUX86do7iBjSOIANG AJxQ== X-Received: by 10.180.75.78 with SMTP id a14mr16883924wiw.68.1435523495377; Sun, 28 Jun 2015 13:31:35 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id ei8sm60764672wjd.32.2015.06.28.13.31.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jun 2015 13:31:35 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> From: Dmitry Gutov Message-ID: <559059A2.2050209@yandex.ru> Date: Sun, 28 Jun 2015 23:31:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83fv5b60j0.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/28/2015 11:28 PM, Eli Zaretskii wrote: > See cedet/semantic/symref/grep.el for when we don't want 'always'. We don't want `auto' there either, do we? >> Do we even have Grep-related commands that use a pipeline that doesn't >> end with Grep? > > I don't know. So I propose to eliminate the value `auto'. It seems we only had it as a maybe-solution for third-party code not to have to recompute the Grep defaults with grep-highlight-matches set to nil. But now we can simply bind it to nil. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 02:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143554537415066 (code B ref 20728); Mon, 29 Jun 2015 02:37:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 02:36:14 +0000 Received: from localhost ([127.0.0.1]:60699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Ovd-0003uw-HB for submit@debbugs.gnu.org; Sun, 28 Jun 2015 22:36:13 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:58260) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Ovb-0003uh-35 for 20728@debbugs.gnu.org; Sun, 28 Jun 2015 22:36:12 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NQO00M00PCQHG00@mtaout25.012.net.il> for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 05:31:51 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQO00JD1PP34J60@mtaout25.012.net.il>; Mon, 29 Jun 2015 05:31:51 +0300 (IDT) Date: Mon, 29 Jun 2015 05:36:06 +0300 From: Eli Zaretskii In-reply-to: <559059A2.2050209@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83egkv5jhl.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Sun, 28 Jun 2015 23:31:30 +0300 > > On 06/28/2015 11:28 PM, Eli Zaretskii wrote: > > > See cedet/semantic/symref/grep.el for when we don't want 'always'. > > We don't want `auto' there either, do we? I think 'auto' does TRT there. > >> Do we even have Grep-related commands that use a pipeline that doesn't > >> end with Grep? > > > > I don't know. > > So I propose to eliminate the value `auto'. It seems we only had it as a > maybe-solution for third-party code not to have to recompute the Grep > defaults with grep-highlight-matches set to nil. > > But now we can simply bind it to nil. We could, if we want to test Grep's output ourselves. That is, we will have to decide when to bind it to nil and when to non-nil, depending on the device/file used as Grep's output (which is system-dependent). From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 10:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143557235529780 (code B ref 20728); Mon, 29 Jun 2015 10:06:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 10:05:55 +0000 Received: from localhost ([127.0.0.1]:60915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Vwo-0007kF-M8 for submit@debbugs.gnu.org; Mon, 29 Jun 2015 06:05:55 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:35535) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Vwl-0007k1-AX for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 06:05:52 -0400 Received: by wgjx7 with SMTP id x7so63497595wgj.2 for <20728@debbugs.gnu.org>; Mon, 29 Jun 2015 03:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=bg4rbxhaf7umqbHl+I1PfxqAuS7LfUnOvsynI38WZMc=; b=CE2DshcA898IdTCokXRjPOv2Bp5N2DxvcPBxGY7nP2ydaMvAFQiigsF1hAALrIGE5A oc9RHOk/5HHMUHHUuh+H847pzICzHUaozkgNR7xmXIgK/wXKTEaXYtUiQ5LLJ2305PAN NtMYWeNNOTRCl/7Hgux/Gdz+9wCkOESOUjWTgoEAVxOusvEk2+0f6RzyuCnZs1ANiz6a a7xCl62VLjOp77UyIs4Yaz1nSs8dWAsIbvDmoGuGWgBsGwUhQD6eHhccJSkvF8/YWLty HfyrQbAftfZX5v8nD7yOTYk6YvAAULWqcWXdwSKnL+WcP/s6Jq1ChQfI64vvI/fpK8lm 78mQ== X-Received: by 10.180.188.109 with SMTP id fz13mr21275941wic.74.1435572345515; Mon, 29 Jun 2015 03:05:45 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id ho10sm7561503wjb.39.2015.06.29.03.05.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 03:05:45 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55911873.2050403@yandex.ru> Date: Mon, 29 Jun 2015 13:05:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83fv5b60j0.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/28/2015 11:28 PM, Eli Zaretskii wrote: >> No: when will a given command's behavior on other operating systems be >> wrong if it was just written to work on Windows (and thus uses either >> `always' or nil, not `auto')? > > See cedet/semantic/symref/grep.el for when we don't want 'always'. This doesn't answer my question, by the way. Would you like me to try to rephrase it? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 10:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143557254130057 (code B ref 20728); Mon, 29 Jun 2015 10:09:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 10:09:01 +0000 Received: from localhost ([127.0.0.1]:60919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Vzo-0007oj-PQ for submit@debbugs.gnu.org; Mon, 29 Jun 2015 06:09:01 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:35326) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9Vzm-0007oW-Th for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 06:08:59 -0400 Received: by wgjx7 with SMTP id x7so63570829wgj.2 for <20728@debbugs.gnu.org>; Mon, 29 Jun 2015 03:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=qtqyYEmBLIv6kw/nBuIG4UuyB1BYvbIUjtuC6elrqAw=; b=xEKbjRXq0Uec5Id01rmHqVTma76feEZFsNLpSrN1l/00n8CXp6Qoj0vcGmbD5VyXLl M2SVuir5mOQoK37XKZoDSIxD4nhIRPH1DV0iOJAGT5y1UG75G/DYCIk0/srpeBQeSOid PsBnSFknm7aMaYHacBscmQ6ciGS043EljT4yxtg7IAb1P71/XDDnPNqiuj3FgJvINbJC LOFm/sB5eJ3QpmLGPG+Og2xNmb71RaONEW+GhHcIxroerIKRVxqAOfwX5q35E4ijbede 4e0acCa9AmP31y7yHNVUeqwJrGfIfqrT1XKnR7xD6aFBo8oJrJqhTgPauvYZftRJ1jbw quRA== X-Received: by 10.180.160.210 with SMTP id xm18mr20457194wib.93.1435572533453; Mon, 29 Jun 2015 03:08:53 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id fm8sm11357544wib.9.2015.06.29.03.08.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 03:08:53 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55911930.4020203@yandex.ru> Date: Mon, 29 Jun 2015 13:08:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83egkv5jhl.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/29/2015 05:36 AM, Eli Zaretskii wrote: >>> See cedet/semantic/symref/grep.el for when we don't want 'always'. >> >> We don't want `auto' there either, do we? > > I think 'auto' does TRT there. In any case, we have to explicitly get rid of `always' in this command. >> But now we can simply bind it to nil. > > We could, if we want to test Grep's output ourselves. That is, we > will have to decide when to bind it to nil and when to non-nil, What do you mean by "test"? My point is, we have to decide whether to highlight matches or not, if only to be compatible with Windows. And by "we", I mean in the implementation of each given command. > depending on the device/file used as Grep's output (which is > system-dependent). Whether we want a given command to use a colorized Grep output, is not dependent on the OS, is it? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 14:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143558909628162 (code B ref 20728); Mon, 29 Jun 2015 14:45:04 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 14:44:56 +0000 Received: from localhost ([127.0.0.1]:33056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aIq-0007KA-5y for submit@debbugs.gnu.org; Mon, 29 Jun 2015 10:44:56 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:57231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aIo-0007Jw-2l for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 10:44:55 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NQP00000NIUK500@a-mtaout23.012.net.il> for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 17:44:47 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQP000XANMNGQ50@a-mtaout23.012.net.il>; Mon, 29 Jun 2015 17:44:47 +0300 (IDT) Date: Mon, 29 Jun 2015 17:44:50 +0300 From: Eli Zaretskii In-reply-to: <55911873.2050403@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <837fqm60bh.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <55911873.2050403@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Mon, 29 Jun 2015 13:05:39 +0300 > > On 06/28/2015 11:28 PM, Eli Zaretskii wrote: > > >> No: when will a given command's behavior on other operating systems be > >> wrong if it was just written to work on Windows (and thus uses either > >> `always' or nil, not `auto')? > > > > See cedet/semantic/symref/grep.el for when we don't want 'always'. > > This doesn't answer my question, by the way. Would you like me to try to > rephrase it? Do you still want to see it answered? From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 14:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143558944728689 (code B ref 20728); Mon, 29 Jun 2015 14:51:03 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 14:50:47 +0000 Received: from localhost ([127.0.0.1]:33060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aOS-0007Sb-J2 for submit@debbugs.gnu.org; Mon, 29 Jun 2015 10:50:45 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34020) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aOQ-0007SO-F5 for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 10:50:43 -0400 Received: by wiar9 with SMTP id r9so6690559wia.1 for <20728@debbugs.gnu.org>; Mon, 29 Jun 2015 07:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=WYn/lr7pMO6+FkT2W6AtlUfpc/w0wwtaBKAeLr8vw14=; b=FEBt8RdxhYR3dKtiTKMaOLltAPzABbFn6+hG2HeWnawZUO5D31TjVbJFQH3UTYpUj7 t08I6jNA/q5k9QvRB/Gtc1PWWIJX5I51RkKtqTVJuK6upyrtMOVgIP47S7euxqciyN3a yQOYMGUtOXASK7J7tECUoL259AmafrXzMHpLKlJfM+j8EgTekwN35qr6FS0fxgLXGDLW wrdPyxJ5l7wW1/QqzX/XfPa/MburRTAalG76fXW5F8u+4daMMuLTXI7nTYQi8n6UKf+8 R0qb77Gds1f0nWvHsBlPGGs0QM8/4sTij5E1K1sWXqgCRPz+AksgiGh/S80II/IUQViO FQgg== X-Received: by 10.194.23.36 with SMTP id j4mr28093321wjf.105.1435589436781; Mon, 29 Jun 2015 07:50:36 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id y19sm12468571wia.15.2015.06.29.07.50.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 07:50:36 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <55911873.2050403@yandex.ru> <837fqm60bh.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55915B3A.5070406@yandex.ru> Date: Mon, 29 Jun 2015 17:50:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <837fqm60bh.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/29/2015 05:44 PM, Eli Zaretskii wrote: >> This doesn't answer my question, by the way. Would you like me to try to >> rephrase it? > > Do you still want to see it answered? I'm assuming this is a rhetoric question. So: the value `auto' behaves as `nil' on Windows, so it's unreliable if a given command supports highlighting of the matches. Why don't we write each command's implementation as if we're targeting Windows? That would mean never using the value `auto', and yes, explicitly binding grep-highlight-matches to nil in every command that doesn't want `always'. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143558952028818 (code B ref 20728); Mon, 29 Jun 2015 14:52:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 14:52:00 +0000 Received: from localhost ([127.0.0.1]:33067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aPf-0007Uk-EC for submit@debbugs.gnu.org; Mon, 29 Jun 2015 10:51:59 -0400 Received: from mtaout25.012.net.il ([80.179.55.181]:37121) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aPb-0007US-Ky for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 10:51:56 -0400 Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NQP00N00NCTFR00@mtaout25.012.net.il> for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 17:45:34 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQP00DBANNYMLE0@mtaout25.012.net.il>; Mon, 29 Jun 2015 17:45:34 +0300 (IDT) Date: Mon, 29 Jun 2015 17:49:50 +0300 From: Eli Zaretskii In-reply-to: <55911930.4020203@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <8361666035.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Mon, 29 Jun 2015 13:08:48 +0300 > > On 06/29/2015 05:36 AM, Eli Zaretskii wrote: > > >>> See cedet/semantic/symref/grep.el for when we don't want 'always'. > >> > >> We don't want `auto' there either, do we? > > > > I think 'auto' does TRT there. > > In any case, we have to explicitly get rid of `always' in this command. Obviously. Not sure what is the significance of this conclusion, though. But then I don't understand where does this discussion go anyway. > >> But now we can simply bind it to nil. > > > > We could, if we want to test Grep's output ourselves. That is, we > > will have to decide when to bind it to nil and when to non-nil, > > What do you mean by "test"? "Examine". The behavior with pipes, files, consoles, and ptys is different. > My point is, we have to decide whether to highlight matches or not, if > only to be compatible with Windows. And by "we", I mean in the > implementation of each given command. Yes, the alternative is to do everything in Lisp, and then use only "--color=no" or "--color=always", as appropriate. > > depending on the device/file used as Grep's output (which is > > system-dependent). > > Whether we want a given command to use a colorized Grep output, is not > dependent on the OS, is it? I don't think so. But it might depend on the values of grep-program etc., i.e. on user customizations. Users might want to put shell scripts or pipelines there. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143559012829831 (code B ref 20728); Mon, 29 Jun 2015 15:03:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 15:02:08 +0000 Received: from localhost ([127.0.0.1]:33076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aZU-0007l4-2U for submit@debbugs.gnu.org; Mon, 29 Jun 2015 11:02:08 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38874) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9aZR-0007ka-TH for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 11:02:06 -0400 Received: by wibdq8 with SMTP id dq8so74999377wib.1 for <20728@debbugs.gnu.org>; Mon, 29 Jun 2015 08:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=DBGiclsoz3ec3vZBkSK8TiXL5d4b908ngxUfaztw7/o=; b=c87etTENU50LsT0eTjlopaeDzWwA76VtUy2cL6aq8G/i8juXWrbooUL5RqkUK7r9Lt JM4+2/bW6Ba78FXr2/SycbvSY3KCfnr66dkIYRzusXlzKVDQWEa0DF5rPuiQMlhwt9oh Q5iRUPnJ9+RvESYqByUy02MAUgYSasfPjcIH41mKKTPY3288Ymb83/7BB/egFRlKoiID sEJGv5rOI6g0yQ1wm9pO4kBqO9270f8GGjUu/aKHQ/Vum4oI1KBng9d9c2WNMw3WIZ1P nYAF4Du3FulvsUZEGiDvBvVRzVGurqAjNRNxMiTtjOwzShQUegtbRcGKLh42M/Ongu4c qZSQ== X-Received: by 10.194.175.65 with SMTP id by1mr31974117wjc.152.1435590120209; Mon, 29 Jun 2015 08:02:00 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id q4sm64409929wja.24.2015.06.29.08.01.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 08:02:00 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55915DE6.3030108@yandex.ru> Date: Mon, 29 Jun 2015 18:01:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <8361666035.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/29/2015 05:49 PM, Eli Zaretskii wrote: >>> We could, if we want to test Grep's output ourselves. That is, we >>> will have to decide when to bind it to nil and when to non-nil, >> >> What do you mean by "test"? > > "Examine". The behavior with pipes, files, consoles, and ptys is > different. I don't understand this. Grep's output happens after we bind, or not bind, this variable. So we can't test in beforehand (or do you mean in `grep-compute-defaults'?). >> My point is, we have to decide whether to highlight matches or not, if >> only to be compatible with Windows. And by "we", I mean in the >> implementation of each given command. > > Yes, the alternative is to do everything in Lisp, and then use only > "--color=no" or "--color=always", as appropriate. That's what I'm proposing. This seems simpler and less error-prone. So this discussion is about the possible downsides. >> Whether we want a given command to use a colorized Grep output, is not >> dependent on the OS, is it? > > I don't think so. But it might depend on the values of grep-program > etc., i.e. on user customizations. Users might want to put shell > scripts or pipelines there. Well, okay. If it's a significant use case, we might want to continue supporting it. On the other hand, we might want to choose to set `grep-highlight-matches' to `always' in grep-compute-defaults, irrespective of the OS. So that every command that knows it does not need the ANSI codes, will bind this variable to nil without relying on auto-detection thanks to calling Grep via a pipe. Then we won't have to test on Windows to find bugs like that. And if a user customized grep-program, etc, to unexpectedly postprocess Grep ouput using a pipe, they can customize `grep-highlight-matches' to `auto' as well. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143559095831177 (code B ref 20728); Mon, 29 Jun 2015 15:16:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 15:15:58 +0000 Received: from localhost ([127.0.0.1]:33110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9amr-00086m-QE for submit@debbugs.gnu.org; Mon, 29 Jun 2015 11:15:58 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:63607) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9amo-00086X-IA for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 11:15:55 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NQP00300OV4DF00@a-mtaout22.012.net.il> for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 18:15:17 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQP003QXP1G2I70@a-mtaout22.012.net.il>; Mon, 29 Jun 2015 18:15:17 +0300 (IDT) Date: Mon, 29 Jun 2015 18:15:19 +0300 From: Eli Zaretskii In-reply-to: <55915B3A.5070406@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83wpym4kc8.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <55911873.2050403@yandex.ru> <837fqm60bh.fsf@gnu.org> <55915B3A.5070406@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Mon, 29 Jun 2015 17:50:34 +0300 > > On 06/29/2015 05:44 PM, Eli Zaretskii wrote: > > >> This doesn't answer my question, by the way. Would you like me to try to > >> rephrase it? > > > > Do you still want to see it answered? > > I'm assuming this is a rhetoric question. I assumed so was yours. > So: the value `auto' behaves as `nil' on Windows, so it's unreliable if > a given command supports highlighting of the matches. No, 'auto' does NOT behave as 'nil' on Windows, not in general. It only behaves as 'nil' when Grep is invoked as an async subprocess, because Windows uses pipes, not ptys, to do that. Any system where 'process-connection-type' is 'nil' will exhibit this behavior. Moreover, even on systems that do support ptys, Emacs will use pipes if "all ptys are busy" (citing the ELisp manual). > Why don't we write each command's implementation as if we're targeting > Windows? That would mean never using the value `auto', and yes, > explicitly binding grep-highlight-matches to nil in every command that > doesn't want `always'. We could, I just don't know if we want to. But I don't object to such a change. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143559160632198 (code B ref 20728); Mon, 29 Jun 2015 15:27:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 15:26:46 +0000 Received: from localhost ([127.0.0.1]:33122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9axJ-0008NF-4z for submit@debbugs.gnu.org; Mon, 29 Jun 2015 11:26:46 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:36951) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9axG-0008N2-Gl for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 11:26:43 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NQP00B00P11ZR00@mtaout27.012.net.il> for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 18:22:49 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQP009DHPE1Q240@mtaout27.012.net.il>; Mon, 29 Jun 2015 18:22:49 +0300 (IDT) Date: Mon, 29 Jun 2015 18:26:38 +0300 From: Eli Zaretskii In-reply-to: <55915DE6.3030108@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83twtq4jtd.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> <55915DE6.3030108@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Mon, 29 Jun 2015 18:01:58 +0300 > > >> Whether we want a given command to use a colorized Grep output, is not > >> dependent on the OS, is it? > > > > I don't think so. But it might depend on the values of grep-program > > etc., i.e. on user customizations. Users might want to put shell > > scripts or pipelines there. > > Well, okay. If it's a significant use case, we might want to continue > supporting it. I don't know if it's a significant use case. Maybe it isn't, and we should just go ahead and do what you suggest. > On the other hand, we might want to choose to set > `grep-highlight-matches' to `always' in grep-compute-defaults, > irrespective of the OS. Won't that bring back the problem in symref/grep.el again? > So that every command that knows it does not need the ANSI codes, will > bind this variable to nil without relying on auto-detection thanks to > calling Grep via a pipe. Then we won't have to test on Windows to find > bugs like that. Assuming we can count on commands that live far away, like symref/grep.el, to make a point of doing this, it will work, of course. > And if a user customized grep-program, etc, to unexpectedly postprocess > Grep ouput using a pipe, they can customize `grep-highlight-matches' to > `auto' as well. Yes, given enough documentation that mentions this. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.14355942899869 (code B ref 20728); Mon, 29 Jun 2015 16:12:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 16:11:29 +0000 Received: from localhost ([127.0.0.1]:33185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9bea-0002Z6-Fd for submit@debbugs.gnu.org; Mon, 29 Jun 2015 12:11:28 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:34106) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9beY-0002Yu-To for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 12:11:27 -0400 Received: by wiar9 with SMTP id r9so9095089wia.1 for <20728@debbugs.gnu.org>; Mon, 29 Jun 2015 09:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=fqxkYnjcSNUhubRxcyemp9i5WR1GebWqtcU4gKpEymg=; b=DBC6xBXokHOBgEaj3VrgWaR8Xe8h1bLqnp32mFGfb/6f6UbpxDKq0vB6KhahLUZyZ6 VH4egkEDwAWDs51UGh9Ji2pR5PCBjuy4FQa0YGGAOV9jURtFZp+1Yj7KC834v7oGkNyr hioRxKzmKdO+rISQXJAyp/hV6TA4aB07vlB81fXd8bHG749Nbtf/1wVrSbtFnwv+pck3 jZfhV9iGYBCknEgcu2atYW2wjtm/mgv+p0kAkv/JAdavur++hPQhRYohFihNvZwzW1Cy AyzZEZvOd2eiM/sI8COl2AEc8RT/Ukd7mupV/LuiuTiTpRoKSixdJz7TYunu8FRnOlca qliw== X-Received: by 10.194.23.225 with SMTP id p1mr31841224wjf.155.1435594281447; Mon, 29 Jun 2015 09:11:21 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id v3sm13297425wiy.1.2015.06.29.09.11.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 09:11:21 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> <55915DE6.3030108@yandex.ru> <83twtq4jtd.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55916E27.3010200@yandex.ru> Date: Mon, 29 Jun 2015 19:11:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83twtq4jtd.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/29/2015 06:26 PM, Eli Zaretskii wrote: >> On the other hand, we might want to choose to set >> `grep-highlight-matches' to `always' in grep-compute-defaults, >> irrespective of the OS. > > Won't that bring back the problem in symref/grep.el again? Why would it? The replace (replace-regexp-in-string "--color=always" ...) call is still there. I didn't change that because CEDET supposedly needs to retain compatibility with previous Emacs versions. But there is a similar function: xref-collect-matches. Looking at it now, I forgot to apply a relevant fix to it (and this is an example of a Lisp code author doing the wrong thing because `auto' happened to make things right anyway, on my machine). So could you: - Try M-x xref-find-regexp on a Windows machine (in an Elisp buffer, enter something like "xref-find-"). - Probably see it fail for the same reason as symref/grep.el did previously. - Apply the patch below. - Hopefully see it succeed and write back about that. > Assuming we can count on commands that live far away, like > symref/grep.el, to make a point of doing this, it will work, of > course. The idea is to force their authors to do it (because the commands won't work otherwise). Patch: diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 50d52d0..bb2546f 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -749,8 +749,10 @@ tools are used, and when." (require 'semantic/fw) (grep-compute-defaults) (defvar grep-find-template) + (defvar grep-highlight-matches) (let* ((grep-find-template (replace-regexp-in-string "-e " "-E " grep-find-template t t)) + (grep-highlight-matches nil) (command (rgrep-default-command (xref--regexp-to-extended regexp) "*.*" dir)) (orig-buffers (buffer-list)) From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 16:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 20728@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143559505411109 (code B ref 20728); Mon, 29 Jun 2015 16:25:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 16:24:14 +0000 Received: from localhost ([127.0.0.1]:33201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9bqv-0002t7-Im for submit@debbugs.gnu.org; Mon, 29 Jun 2015 12:24:13 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:38056) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9bqt-0002so-Pq for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 12:24:12 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NQP00B00RQB4Y00@mtaout24.012.net.il> for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 19:15:31 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQP00B28RTVKB00@mtaout24.012.net.il>; Mon, 29 Jun 2015 19:15:31 +0300 (IDT) Date: Mon, 29 Jun 2015 19:24:08 +0300 From: Eli Zaretskii In-reply-to: <55916E27.3010200@yandex.ru> X-012-Sender: halo1@inter.net.il Message-id: <83oajy4h5j.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> <55915DE6.3030108@yandex.ru> <83twtq4jtd.fsf@gnu.org> <55916E27.3010200@yandex.ru> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: 20728@debbugs.gnu.org > From: Dmitry Gutov > Date: Mon, 29 Jun 2015 19:11:19 +0300 > > On 06/29/2015 06:26 PM, Eli Zaretskii wrote: > > >> On the other hand, we might want to choose to set > >> `grep-highlight-matches' to `always' in grep-compute-defaults, > >> irrespective of the OS. > > > > Won't that bring back the problem in symref/grep.el again? > > Why would it? > > The replace (replace-regexp-in-string "--color=always" ...) call is > still there. Ah, OK. I thought you intended to remove it as part of this. > - Try M-x xref-find-regexp on a Windows machine (in an Elisp buffer, > enter something like "xref-find-"). > - Probably see it fail for the same reason as symref/grep.el did previously. > - Apply the patch below. > - Hopefully see it succeed and write back about that. Will do, thanks. > > Assuming we can count on commands that live far away, like > > symref/grep.el, to make a point of doing this, it will work, of > > course. > > The idea is to force their authors to do it (because the commands won't > work otherwise). Assuming those commands will be used on platforms that reveal the failures... From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jun 2015 16:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143559520211357 (code B ref 20728); Mon, 29 Jun 2015 16:27:02 +0000 Received: (at 20728) by debbugs.gnu.org; 29 Jun 2015 16:26:42 +0000 Received: from localhost ([127.0.0.1]:33209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9btJ-0002x6-Vv for submit@debbugs.gnu.org; Mon, 29 Jun 2015 12:26:42 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:33140) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9btH-0002ws-7c for 20728@debbugs.gnu.org; Mon, 29 Jun 2015 12:26:39 -0400 Received: by wiwl6 with SMTP id l6so105252384wiw.0 for <20728@debbugs.gnu.org>; Mon, 29 Jun 2015 09:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=y6UaeWJQKnDFDNZrbaznAXSGCWUAy2HWBafHHcpA1o0=; b=D/dR/8x0n1NzIEWaSkyLQk3O7UMrfT0AnZEzyq9frKFZbYnm/uPyAp3mVwH7IP9U3Z 1tHk2wGnRXnOe94MFliKbJgKqE9hJFXNmOylBW16svXoP31eDpEw4522AX2CUsmAGKji C89MmikTMbDyzV0VwLHH87qEoeXs8iGf7AAQ606k2F08JiKlsKxXezjiaUcQLdcvej18 /VPx1nLiDXNeohRvcjUZWSa28d/0+13PkUX8UPrTp/OIHGmdfsXtKlVl7efOZPw2XL/7 UHRHXwXjqfeMw/PvkP43wnUavGtKdUE8Z9Ccmoz3VPeG8KuBBz/N7AgIzVjyAgqmuX0T 92fg== X-Received: by 10.180.107.138 with SMTP id hc10mr24123830wib.2.1435595193691; Mon, 29 Jun 2015 09:26:33 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by mx.google.com with ESMTPSA id xa9sm60222284wjc.43.2015.06.29.09.26.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 09:26:33 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> <55915DE6.3030108@yandex.ru> <83twtq4jtd.fsf@gnu.org> <55916E27.3010200@yandex.ru> <83oajy4h5j.fsf@gnu.org> From: Dmitry Gutov Message-ID: <559171B8.5000108@yandex.ru> Date: Mon, 29 Jun 2015 19:26:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83oajy4h5j.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/29/2015 07:24 PM, Eli Zaretskii wrote: >> The replace (replace-regexp-in-string "--color=always" ...) call is >> still there. > > Ah, OK. I thought you intended to remove it as part of this. I hope to be able to do that at some point in the future. > Assuming those commands will be used on platforms that reveal the > failures... With --color=always? IIUC, that will be most of the platforms we support. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jul 2015 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org, dgutov@yandex.ru Reply-To: Eli Zaretskii Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143662310120713 (code B ref 20728); Sat, 11 Jul 2015 13:59:01 +0000 Received: (at 20728) by debbugs.gnu.org; 11 Jul 2015 13:58:21 +0000 Received: from localhost ([127.0.0.1]:46906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDvIL-0005O0-2K for submit@debbugs.gnu.org; Sat, 11 Jul 2015 09:58:21 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:49510) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDvII-0005Nk-L2 for 20728@debbugs.gnu.org; Sat, 11 Jul 2015 09:58:19 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NRB00800T4BZF00@a-mtaout21.012.net.il> for 20728@debbugs.gnu.org; Sat, 11 Jul 2015 16:58:11 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NRB00897TGYYU20@a-mtaout21.012.net.il>; Sat, 11 Jul 2015 16:58:11 +0300 (IDT) Date: Sat, 11 Jul 2015 16:58:12 +0300 From: Eli Zaretskii In-reply-to: <83oajy4h5j.fsf@gnu.org> X-012-Sender: halo1@inter.net.il Message-id: <83si8uaj9n.fsf@gnu.org> References: <86bngws6il.fsf@yandex.ru> <83zj4fpjof.fsf@gnu.org> <557082F7.8020400@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> <55915DE6.3030108@yandex.ru> <83twtq4jtd.fsf@gnu.org> <55916E27.3010200@yandex.ru> <83oajy4h5j.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 29 Jun 2015 19:24:08 +0300 > From: Eli Zaretskii > Cc: 20728@debbugs.gnu.org > > > - Try M-x xref-find-regexp on a Windows machine (in an Elisp buffer, > > enter something like "xref-find-"). > > - Probably see it fail for the same reason as symref/grep.el did previously. > > - Apply the patch below. > > - Hopefully see it succeed and write back about that. > > Will do, thanks. Sorry for such a long delay: life intervened, and then I simply forgot. Yes, indeed, that patch is needed to make it work on MS-Windows. From unknown Tue Aug 12 08:33:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jul 2015 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20728 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 20728@debbugs.gnu.org Received: via spool by 20728-submit@debbugs.gnu.org id=B20728.143663025530962 (code B ref 20728); Sat, 11 Jul 2015 15:58:02 +0000 Received: (at 20728) by debbugs.gnu.org; 11 Jul 2015 15:57:35 +0000 Received: from localhost ([127.0.0.1]:46926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDx9j-00083J-AA for submit@debbugs.gnu.org; Sat, 11 Jul 2015 11:57:35 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36860) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDx9h-000836-GI for 20728@debbugs.gnu.org; Sat, 11 Jul 2015 11:57:34 -0400 Received: by widjy10 with SMTP id jy10so36800589wid.1 for <20728@debbugs.gnu.org>; Sat, 11 Jul 2015 08:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=v7jRjzK6OAcr2un+TrVZcB91mallFW1jar7TRmkJON4=; b=DOoOHBuZEE+/Y+9YmOzeIH4m7U/HltLgSB26GfpqNSw8M70grMezLJOzQ2EtvrD+/W UerU0PzGEeqMYPOGgR+OC1I7RUat8ezrtsxckNGmpRKdjBlpEES5nyHOyAJYYYeAzGo1 TVN+n3bJNvvV3BsV27mmtkVnG4CXVUFZ3CUNfNfAfY+lwk/Z4igU+Q2mARiqRDBgXASm 8fI121uvXNG/oBt/zdt4J6kcjYE4Asu0h/HgCGmmc+ydM8vg2MUPHumwYEJ+/zIniln5 CyDlhgEN7VdrNkHW3PmDXdOH1JqL900morsF1jceWoO5dA8PT2gyC3XfiWa3LpkDRyYl 7yPA== X-Received: by 10.180.10.200 with SMTP id k8mr7697606wib.14.1436630247781; Sat, 11 Jul 2015 08:57:27 -0700 (PDT) Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id j7sm18669687wjz.11.2015.07.11.08.57.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Jul 2015 08:57:27 -0700 (PDT) References: <86bngws6il.fsf@yandex.ru> <83wpzjpf6o.fsf@gnu.org> <55708EEA.6020400@yandex.ru> <83twunp9bf.fsf@gnu.org> <5570B30F.4090503@yandex.ru> <83oakuprpf.fsf@gnu.org> <55715DE3.6000405@yandex.ru> <83h9qmpm2s.fsf@gnu.org> <557166CE.4050906@yandex.ru> <83d21apkyg.fsf@gnu.org> <55717030.6010005@yandex.ru> <87a8wdhka7.fsf@mail.linkov.net> <5572C936.6070505@yandex.ru> <874mmkfq7q.fsf@mail.linkov.net> <5574C427.3070007@yandex.ru> <87fv608nl8.fsf@mail.linkov.net> <55787A1D.9080601@yandex.ru> <87wpzbaztk.fsf@mail.linkov.net> <55793756.9070505@yandex.ru> <87a8w53k8z.fsf@mail.linkov.net> <558F1186.50303@yandex.ru> <834mls7dvr.fsf@gnu.org> <558FAAE0.6020805@yandex.ru> <83381b7vez.fsf@gnu.org> <559044BD.4030703@yandex.ru> <83fv5b60j0.fsf@gnu.org> <559059A2.2050209@yandex.ru> <83egkv5jhl.fsf@gnu.org> <55911930.4020203@yandex.ru> <8361666035.fsf@gnu.org> <55915DE6.3030108@yandex.ru> <83twtq4jtd.fsf@gnu.org> <55916E27.3010200@yandex.ru> <83oajy4h5j.fsf@gnu.org> <83si8uaj9n.fsf@gnu.org> From: Dmitry Gutov Message-ID: <55A13CE0.7030504@yandex.ru> Date: Sat, 11 Jul 2015 18:57:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 MIME-Version: 1.0 In-Reply-To: <83si8uaj9n.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 07/11/2015 04:58 PM, Eli Zaretskii wrote: > Yes, indeed, that patch is needed to make it work on MS-Windows. Thanks for checking, installed.