GNU bug report logs - #20718
25.0.50; find-function fails on advised subrs (again)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20718: closed (25.0.50; find-function fails on advised subrs
 (again))
Date: Thu, 04 Jun 2015 22:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 5 Jun 2015 01:36:52 +0300
with message-id <5570D304.8020103 <at> yandex.ru>
and subject line Re: bug#20718: 25.0.50; find-function fails on advised subrs (again)
has caused the debbugs.gnu.org bug report #20718,
regarding 25.0.50; find-function fails on advised subrs (again)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20718: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20718
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; find-function fails on advised subrs (again)
Date: Tue, 02 Jun 2015 14:49:05 +0200

Hello,

just as a random example:

  (advice-add 'handle-switch-frame :after #'prin1)

and M-x find-function 'handle-switch-frame RET

==> find-function-search-for-symbol: Don't know where
    `handle-switch-frame' is defined

Works without advicing.  I included the word "again" in the subject
because this had been fixed once in #789 in 2008.

It doesn't work because `find-function-library' performs the subrp test
just on the symbol function of the given function name, which is the
advice, not the original subr.


Thanks,

Michael.



In GNU Emacs 25.0.50.4 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5)
 of 2015-05-30 on drachen
Windowing system distributor `The X.Org Foundation', version 11.0.11701000
System Description:	Debian GNU/Linux testing (stretch)

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: michael_heerdegen <at> web.de, 20718-done <at> debbugs.gnu.org
Subject: Re: bug#20718: 25.0.50; find-function fails on advised subrs (again)
Date: Fri, 5 Jun 2015 01:36:52 +0300

Version: 25.1

On 06/04/2015 06:55 PM, Stefan Monnier wrote:

> So the callers will need to be adjusted.

Ok, done. I seems to work now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.