From drew.adams@oracle.com Mon Jan 26 09:45:50 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 26 Jan 2009 17:45:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0QHjlVq008488 for ; Mon, 26 Jan 2009 09:45:48 -0800 Received: from mx10.gnu.org ([199.232.76.166]:57321) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LRVVK-0002z2-GJ for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 12:44:10 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LRVWr-0001nZ-Ia for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 12:45:46 -0500 Received: from mx20.gnu.org ([199.232.41.8]:52725) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRVM3-0007bN-Ha for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 12:34:35 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LRLMV-0001xb-Ea for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 01:54:23 -0500 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0Q6rEM4024995 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Jan 2009 06:53:15 GMT Received: from acsmt704.oracle.com (acsmt704.oracle.com [141.146.40.82]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0Q6rn1X016309 for ; Mon, 26 Jan 2009 06:53:50 GMT Received: from dradamslap1 (/24.5.128.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Jan 2009 06:53:47 +0000 From: "Drew Adams" To: Subject: 23.0.60; dired-get-filename includes `*' for executable in name Date: Sun, 25 Jan 2009 22:54:12 -0800 Message-ID: <007601c97f82$e5b0b910$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acl/guUhqbi56Ot4SP6/Pfz3TI85vg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt704.oracle.com [141.146.40.82] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010206.497D5DFD.0063:SCFSTAT928724,ss=1,fgs=0 X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. emacs -Q Create a file named `grep.exe' in some directory. The file content is unimportant. Use `C-u C-x d' to visit the directory, and specify `-alF' as the listing switches. Put the cursor on the line of the file named `grep.exe', which is displayed as `grep.exe*' to show that it is executable. M-: (dired-get-filename) returns "/the/dir/to/grep.exe*" That is, the display artifact `*' is included as part of the file name. This is also a bug in Emacs 22.3. It is a regression from Emacs 21.3.1. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2009-01-04 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' From cyd@stupidchicken.com Tue Jan 27 12:20:31 2009 Received: (at 2068) by emacsbugs.donarmstrong.com; 27 Jan 2009 20:20:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RKKTAT030053 for <2068@emacsbugs.donarmstrong.com>; Tue, 27 Jan 2009 12:20:30 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id C23D457E205; Tue, 27 Jan 2009 15:20:59 -0500 (EST) From: Chong Yidong To: 2068@debbugs.gnu.org Cc: "Drew Adams" Subject: Re: 23.0.60; dired-get-filename includes `*' for executable in name Date: Tue, 27 Jan 2009 15:20:59 -0500 Message-ID: <87r62owlec.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > emacs -Q > > Create a file named `grep.exe' in some directory. > > Use `C-u C-x d' to visit the directory, and specify `-alF' as the > listing switches. > > Put the cursor on the line of the file named `grep.exe', which is > displayed as `grep.exe*' to show that it is executable. > M-: (dired-get-filename) returns "/the/dir/to/grep.exe*" Can't reproduce this. If this bug exists, it's probably Windows-only. From cyd@stupidchicken.com Tue Jan 27 12:21:12 2009 Received: (at control) by emacsbugs.donarmstrong.com; 27 Jan 2009 20:21:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RKL9tb030073 for ; Tue, 27 Jan 2009 12:21:10 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 7EBFA57E205; Tue, 27 Jan 2009 15:21:40 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: reassign 2068 Date: Tue, 27 Jan 2009 15:21:40 -0500 Message-ID: <87mydcwld7.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii reassign 2068 emacs,w32 thanks From drew.adams@oracle.com Tue Jan 27 12:43:37 2009 Received: (at 2068) by emacsbugs.donarmstrong.com; 27 Jan 2009 20:43:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from acsinet11.oracle.com (acsinet11.oracle.com [141.146.126.233]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RKhZ04002533 for <2068@emacsbugs.donarmstrong.com>; Tue, 27 Jan 2009 12:43:36 -0800 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0RKjLb9028992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Jan 2009 20:45:22 GMT Received: from acsmt706.oracle.com (acsmt706.oracle.com [141.146.40.84]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0RKhOlZ024539; Tue, 27 Jan 2009 20:43:26 GMT Received: from dradamslap1 (/141.144.161.13) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 27 Jan 2009 20:43:24 +0000 From: "Drew Adams" To: "'Chong Yidong'" , <2068@debbugs.gnu.org> References: <87r62owlec.fsf@cyd.mit.edu> Subject: RE: 23.0.60; dired-get-filename includes `*' for executable in name Date: Tue, 27 Jan 2009 12:43:25 -0800 Message-ID: <004601c980bf$e78bfdb0$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcmAvLg9SAoo/GKjR4qU7vMMlKXNfQAAwwCA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 In-Reply-To: <87r62owlec.fsf@cyd.mit.edu> X-Source-IP: acsmt706.oracle.com [141.146.40.84] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.497F71EE.0068:SCFSTAT928724,ss=1,fgs=0 > > emacs -Q > > > > Create a file named `grep.exe' in some directory. > > > > Use `C-u C-x d' to visit the directory, and specify `-alF' as the > > listing switches. > > > > Put the cursor on the line of the file named `grep.exe', which is > > displayed as `grep.exe*' to show that it is executable. > > > M-: (dired-get-filename) returns "/the/dir/to/grep.exe*" > > Can't reproduce this. If this bug exists, it's probably Windows-only. Yes, I pretty much figured it was Windows-only. From jasonrumney@gmail.com Wed Jan 28 05:58:15 2009 Received: (at 2068) by emacsbugs.donarmstrong.com; 28 Jan 2009 13:58:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-qy0-f20.google.com (mail-qy0-f20.google.com [209.85.221.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0SDwCfN004223 for <2068@emacsbugs.donarmstrong.com>; Wed, 28 Jan 2009 05:58:13 -0800 Received: by qyk13 with SMTP id 13so25508657qyk.1 for <2068@emacsbugs.donarmstrong.com>; Wed, 28 Jan 2009 05:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=9NsSrOyQeOuaR7Y4DYspYxzf9R5z5s8P3e76Wum4Dgk=; b=l8LSSGVLcJwK6bx8u1JV2XJb501ZakSXFOyE5AZ+oKO2hekbo+sMULJi5pBYh9vKe9 Cs0m4Vnba8f1uuLkpgkz7Gj1NweYyXy9A0AHCDoHGK84gEE0ET+wrMNLMNy6n1pfqIMt Fglch3t0VZTYdgEJS5BzRRTvn0Ug4pXJy7ct8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=NgejXsslXBCP/odG+0CqMtJ/HWVlFCF3ld8Bb3L1ReEts0KFpo8pMfQ72kCZToGvgy EhI/7thzqJYvwYM5iO+DTYGKSO7MbaYPgEhitKNhVXipSBup0lswH6Un48FPqRKFaNN9 FOao1J6Po/uRa/n6DHje1y+z/Tf9hTNFEZCKw= Received: by 10.214.25.9 with SMTP id 9mr6320571qay.85.1233151087141; Wed, 28 Jan 2009 05:58:07 -0800 (PST) Received: from ?192.168.249.26? ([118.101.26.137]) by mx.google.com with ESMTPS id 5sm1509458qwh.56.2009.01.28.05.58.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 28 Jan 2009 05:58:06 -0800 (PST) Sender: Jason Rumney Message-ID: <4980644C.6070905@gnu.org> Date: Wed, 28 Jan 2009 21:57:32 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Chong Yidong , 2068@debbugs.gnu.org Subject: Re: bug#2068: 23.0.60; dired-get-filename includes `*' for executable in name References: <87r62owlec.fsf@cyd.mit.edu> In-Reply-To: <87r62owlec.fsf@cyd.mit.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Chong Yidong wrote: >> emacs -Q >> >> Create a file named `grep.exe' in some directory. >> >> Use `C-u C-x d' to visit the directory, and specify `-alF' as the >> listing switches. >> >> Put the cursor on the line of the file named `grep.exe', which is >> displayed as `grep.exe*' to show that it is executable. >> > > >> M-: (dired-get-filename) returns "/the/dir/to/grep.exe*" >> > > Can't reproduce this. If this bug exists, it's probably Windows-only. > It seems to be another bug in ls-lisp. emacs -Q (require 'ls-lisp) (setq ls-lisp-use-insert-directory-program nil) then C-u C-x d as above to visit a directory with executable files in it. From eliz@gnu.org Wed Jan 28 11:07:52 2009 Received: (at 2068-done) by emacsbugs.donarmstrong.com; 28 Jan 2009 19:07:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout2.012.net.il (mtaout2.012.net.il [84.95.2.4]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0SJ7it1018648 for <2068-done@emacsbugs.donarmstrong.com>; Wed, 28 Jan 2009 11:07:46 -0800 Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KE700E003IB5900@i_mtaout2.012.net.il> for 2068-done@emacsbugs.donarmstrong.com; Wed, 28 Jan 2009 21:07:56 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.70.255.234]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KE70044X3T7WN30@i_mtaout2.012.net.il>; Wed, 28 Jan 2009 21:07:56 +0200 (IST) Date: Wed, 28 Jan 2009 21:07:35 +0200 From: Eli Zaretskii Subject: Re: bug#2068: 23.0.60; dired-get-filename includes `*' for executable in name In-reply-to: <4980644C.6070905@gnu.org> X-012-Sender: halo1@inter.net.il To: Jason Rumney , 2068-done@debbugs.gnu.org Cc: cyd@stupidchicken.com, Drew Adams Reply-to: Eli Zaretskii Message-id: References: <87r62owlec.fsf@cyd.mit.edu> <4980644C.6070905@gnu.org> > From: "Drew Adams" > Date: Tue, 27 Jan 2009 12:43:25 -0800 > Cc: > > > > emacs -Q > > > > > > Create a file named `grep.exe' in some directory. > > > > > > Use `C-u C-x d' to visit the directory, and specify `-alF' as the > > > listing switches. > > > > > > Put the cursor on the line of the file named `grep.exe', which is > > > displayed as `grep.exe*' to show that it is executable. > > > > > M-: (dired-get-filename) returns "/the/dir/to/grep.exe*" > > > > Can't reproduce this. If this bug exists, it's probably Windows-only. > > Yes, I pretty much figured it was Windows-only. ls-lisp.el was putting the `dired-filename' property incorrectly when the "-F" switch was used. Fixed as below. If you want to try this without rebuilding Emacs, you will need to issue 2 commands, after byte-compiling the patched ls-lisp.el: M-x load-library RET files RET M-x load-library RET ls-lisp RET IOW, files.elc needs to be loaded before ls-lisp, because the latter redefines some functions in the former, and redefining them again will give you trouble. 2009-01-28 Eli Zaretskii * ls-lisp.el (ls-lisp-classify): Propertize file name before concatenating the type indicating character. (ls-lisp-format): Don't propertize file-name only if ls-lisp-classify already did. Index: lisp/ls-lisp.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/ls-lisp.el,v retrieving revision 1.80 retrieving revision 1.81 diff -u -r1.80 -r1.81 --- lisp/ls-lisp.el 5 Jan 2009 03:19:31 -0000 1.80 +++ lisp/ls-lisp.el 28 Jan 2009 19:01:42 -0000 1.81 @@ -531,13 +531,17 @@ (type (cadr filedata))) (cond (type (cons - (concat file-name (if (eq type t) "/" "@")) + (concat (propertize file-name 'dired-filename t) + (if (eq type t) "/" "@")) (cdr filedata))) ((string-match "x" (nth 9 filedata)) (cons - (concat file-name "*") + (concat (propertize file-name 'dired-filename t) "*") (cdr filedata))) - (t filedata)))) + (t + (cons + (propertize file-name 'dired-filename t) + (cdr filedata)))))) (defun ls-lisp-extension (filename) "Return extension of FILENAME (ignoring any version extension) @@ -632,7 +636,9 @@ " " (ls-lisp-format-time file-attr time-index now) " " - (propertize file-name 'dired-filename t) + (if (not (memq ?F switches)) ; ls-lisp-classify already did that + (propertize file-name 'dired-filename t) + file-name) (if (stringp file-type) ; is a symbolic link (concat " -> " file-type)) "\n" From drew.adams@oracle.com Wed Jan 28 11:15:34 2009 Received: (at 2068-done) by emacsbugs.donarmstrong.com; 28 Jan 2009 19:15:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet11.oracle.com (rcsinet11.oracle.com [148.87.113.123]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0SJFWZh021016 for <2068-done@emacsbugs.donarmstrong.com>; Wed, 28 Jan 2009 11:15:33 -0800 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0SJHFD1022971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Jan 2009 19:17:19 GMT Received: from acsmt702.oracle.com (acsmt702.oracle.com [141.146.40.80]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0SJFEM9025317; Wed, 28 Jan 2009 19:15:15 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Jan 2009 19:15:12 +0000 From: "Drew Adams" To: "'Eli Zaretskii'" , "'Jason Rumney'" , <2068-done@debbugs.gnu.org> Cc: References: <87r62owlec.fsf@cyd.mit.edu> <4980644C.6070905@gnu.org> Subject: RE: bug#2068: 23.0.60; dired-get-filename includes `*' for executable in name Date: Wed, 28 Jan 2009 11:15:10 -0800 Message-ID: <008d01c9817c$beaebbe0$c2b22382@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcmBe8OjUT8JvkWqQze+API4Jt3EjAAAM+aQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt702.oracle.com [141.146.40.80] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4980AEC2.0118:SCFSTAT928724,ss=1,fgs=0 > ls-lisp.el was putting the `dired-filename' property incorrectly when > the "-F" switch was used. Fixed as below. > > If you want to try this without rebuilding Emacs, you will need to No, I don't need to try it; I'm OK with your statement that it was fixed. Thanks - Drew From unknown Sun Sep 07 13:55:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 26 Feb 2009 15:24:06 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator