GNU bug report logs - #20670
[PATCH] nnimap: enable additional expunge options

Previous Next

Full log

Message #14 received at 20670 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 20670 <at> debbugs.gnu.org
Cc: ding <at> gnus.org
Subject: Re: bug#20670: [PATCH] nnimap: enable additional expunge options (v3)
Date: Tue, 24 Jan 2017 20:35:28 +0100

Nikolaus Rath <Nikolaus <at> rath.org> writes:

> If the IMAP server supports the UID EXPUNGE command, the nnimap backend
> currently always expunges deleted articles.
>
> If the IMAP server does not support this command, articles are either
> not expunged at all (nnimap-expunge is nil), or ALL articles that are
> currently flagged as deleted will be expunged when any one article is
> deleted in Gnus.
>
> This patch introduces three new settings for nnimap-expunge:

Looks good.  Two minor comments:

+               (nnheader-message 3 (concat "nnimap-expunge set to 'immediately, but "
+                                           "server doesn't support UIDPLUS"))))
+

You've probably done this to make the lines short enough, but the first
one is still more than 80 chars wide.

+             (nnheader-message 7 "Article marked for deletion, but not expunged.")))))

And so is this.  It's probably better to just reflow by breaking the
line after `nnheader-message'.

This change should also be documented in the "Customizing the IMAP
Connection" node in the Gnus manual, and get an entry in the NEWS file.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.