GNU bug report logs - #20664
25.0.50; Customize: Link option or face name to the source definition

Previous Next

Full log

View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Oleh Krehel <ohwoeowho <at> gmail.com>, Drew Adams <drew.adams <at> oracle.com>, 20664 <at> debbugs.gnu.org
Subject: bug#20664: 25.0.50; Customize: Link option or face name to the source definition
Date: Thu, 17 Sep 2020 17:16:09 -0300

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Oleh Krehel <ohwoeowho <at> gmail.com> writes:
>
>> * lisp/cus-edit.el (custom-face-value-create): Make the face name into
>>   a button that calls `find-face-definition'.
>
> [...]
>
>> +        (setq opoint (point))
>> +        ;; Face name (tag).
>> +        (insert " " tag)
>> +        (make-button opoint (point)
>> +                     'follow-link t
>> + 'action (lambda (&rest _x) (find-face-definition symbol))))
>
> Makes sense to me.  I tweaked it a bit before applying, though -- used
> insert-text-button for convenience.
>

Why a button.el button, and not a link widget? Using a button.el button
makes it look like TAB is inconsistent, because it skips the button, so
you can't get to the button by just pressing TAB.

And given there are links to which you can get to by pressing TAB, not
being able to reach this one makes it feel like something is wrong.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.