From unknown Tue Aug 19 05:10:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#20664 <20664@debbugs.gnu.org> To: bug#20664 <20664@debbugs.gnu.org> Subject: Status: 25.0.50; Customize: Link option or face name to the source definition Reply-To: bug#20664 <20664@debbugs.gnu.org> Date: Tue, 19 Aug 2025 12:10:03 +0000 retitle 20664 25.0.50; Customize: Link option or face name to the source de= finition reassign 20664 emacs submitter 20664 Drew Adams severity 20664 wishlist tag 20664 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 26 16:41:19 2015 Received: (at submit) by debbugs.gnu.org; 26 May 2015 20:41:19 +0000 Received: from localhost ([127.0.0.1]:57439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxLf4-0002ds-1Q for submit@debbugs.gnu.org; Tue, 26 May 2015 16:41:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34018) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxLf1-0002de-6D for submit@debbugs.gnu.org; Tue, 26 May 2015 16:41:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxLev-0003Xa-8i for submit@debbugs.gnu.org; Tue, 26 May 2015 16:41:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxLev-0003XU-6W for submit@debbugs.gnu.org; Tue, 26 May 2015 16:41:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxLeu-0004Dw-8J for bug-gnu-emacs@gnu.org; Tue, 26 May 2015 16:41:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxLeq-0003Vl-VJ for bug-gnu-emacs@gnu.org; Tue, 26 May 2015 16:41:08 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxLeq-0003VT-NR for bug-gnu-emacs@gnu.org; Tue, 26 May 2015 16:41:04 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t4QKf3Jg006659 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 May 2015 20:41:04 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t4QKf3eD015451 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Tue, 26 May 2015 20:41:03 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t4QKf3BE019053 for ; Tue, 26 May 2015 20:41:03 GMT MIME-Version: 1.0 Message-ID: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> Date: Tue, 26 May 2015 13:41:03 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; Customize: Link option or face name to the source definition X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Feature request. In Customize, for options and faces. Put a link on the option/face name, so that following the link takes you to the source code (defcustom or defface). In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 09:26:26 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 13:26:26 +0000 Received: from localhost ([127.0.0.1]:58038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxbLl-0008Ch-54 for submit@debbugs.gnu.org; Wed, 27 May 2015 09:26:26 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37914) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxbLh-0008CO-Ar for 20664@debbugs.gnu.org; Wed, 27 May 2015 09:26:22 -0400 Received: by wizo1 with SMTP id o1so22368295wiz.1 for <20664@debbugs.gnu.org>; Wed, 27 May 2015 06:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=WfbODxIzMpxMxk8ye2OLEhLp3+1cX2MzGnujWxxHqL0=; b=RGB6FaX7AShSfpKSeA09mzPh/84Fiqi7WuNZfTfU/qvAYiA12wR9RmI+K/PUnOc0xT x8rpxSIYC3lA17eemO5TV1tLkDGMdi29vJjUC97LchmJjL1Rdu4Y2kVPjEYY9u8SVHIx c48dn+qYKYcfO+qDM9QXYmECKeMcDMQa3Wns66f9ihKjmnXx4yvO3bkONTxja/ybTxP3 rhbqmmRaZAnLIMMAARuAEz99jCVOwYV1Q4XxAv0dpNg1vXkXzOa4vYHAgFaRKq/tIYOL lITAdW5Zc9FVrA6BsFR1Nppl7/wbYcV3aJi8Pd+26sbOyxIULip2GbxwLY5sZzTgMu62 7XaQ== X-Received: by 10.194.95.2 with SMTP id dg2mr59712778wjb.53.1432733175647; Wed, 27 May 2015 06:26:15 -0700 (PDT) Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id eu10sm3698343wib.8.2015.05.27.06.26.14 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 May 2015 06:26:14 -0700 (PDT) From: Oleh Krehel To: Drew Adams Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> Date: Wed, 27 May 2015 15:19:52 +0200 In-Reply-To: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> (Drew Adams's message of "Tue, 26 May 2015 13:41:03 -0700 (PDT)") Message-ID: <877frup37r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20664 Cc: 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Drew Adams writes: > Feature request. In Customize, for options and faces. Put a link on > the option/face name, so that following the link takes you to the source > code (defcustom or defface). Please check the patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Allow-to-follow-to-face-definition-in-Customize.patch >From bea177aff8de195d428106003fab8b8498e7aae8 Mon Sep 17 00:00:00 2001 From: Oleh Krehel Date: Wed, 27 May 2015 15:06:42 +0200 Subject: [PATCH] Allow to follow to face definition in Customize * lisp/cus-edit.el (custom-face-value-create): Make the face name into a button that calls `find-face-definition'. (Bug#20664) --- lisp/cus-edit.el | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index 1d9a9d6..246f08e 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -3483,19 +3483,22 @@ the present value is saved to its :shown-value property instead." (widget-put widget :buttons buttons)) ;; Draw an ordinary `custom-face' widget - (let ((opoint (point))) - ;; Visibility indicator. - (push (widget-create-child-and-convert - widget 'custom-visibility - :help-echo "Hide or show this face." - :on "Hide" :off "Show" - :on-glyph "down" :off-glyph "right" - :action 'custom-toggle-hide-face - (not hiddenp)) - buttons) - ;; Face name (tag). - (insert " " tag) - (widget-specify-sample widget opoint (point))) + (let (opoint) + ;; Visibility indicator. + (push (widget-create-child-and-convert + widget 'custom-visibility + :help-echo "Hide or show this face." + :on "Hide" :off "Show" + :on-glyph "down" :off-glyph "right" + :action 'custom-toggle-hide-face + (not hiddenp)) + buttons) + (setq opoint (point)) + ;; Face name (tag). + (insert " " tag) + (make-button opoint (point) + 'follow-link t + 'action (lambda (&rest _x) (find-face-definition symbol)))) (insert (cond ((eq custom-buffer-style 'face) " ") ((string-match-p "face\\'" tag) ":") -- 1.8.4 --=-=-= Content-Type: text/plain With this patch, "RET" works as expected, while "" is giving an error for a reason I don't understand. In order to make it work for the mouse, I have to do something contorted instead of a plain `make-button': (define-key (overlay-get (make-button opoint (point) 'follow-link t 'action (lambda (&rest _x) (find-face-definition symbol))) 'keymap) [down-mouse-1] (lambda () (interactive) (let ((button (button-at (point)))) (when button (button-activate button) t)))) Maybe someone can suggest a better way. Oleh --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 10:10:02 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 14:10:03 +0000 Received: from localhost ([127.0.0.1]:58463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxc1t-0000sS-BN for submit@debbugs.gnu.org; Wed, 27 May 2015 10:10:02 -0400 Received: from mout.gmx.net ([212.227.15.15]:63475) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxc1m-0000sA-I9 for 20664@debbugs.gnu.org; Wed, 27 May 2015 10:09:55 -0400 Received: from [188.23.120.231] ([188.23.120.231]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MAhWl-1YrKkt1nlD-00BuNB; Wed, 27 May 2015 16:09:44 +0200 Message-ID: <5565D022.9020503@gmx.at> Date: Wed, 27 May 2015 16:09:38 +0200 From: martin rudalics MIME-Version: 1.0 To: Oleh Krehel , Drew Adams Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> In-Reply-To: <877frup37r.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:1kJ7gknD7a7rUTqe/xS9dkKIsUejCwfUgE7r96bYPtQOH6/gCz1 m0wF4gdYHZWfYGxqbyS1BS4QUlzdPUA1Gyu+RqBkCUQVt9BuI/idDARaq1fMSJ/cjETJpzw +sNUyAp6KpTLcCeHXT1ajzZqFnVcNmt2GoL979Sv63NUpLEmTcVXiedBvad3qmBB0NZ9Itg ku1coYsVgHCHox1JIgLDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:35xLPPdGS2Q=:cRET1vi7J+Aq8OJmcShxEy uWBgrMrz8xklY83z4HBw+R9Hvvu0zvztE8tlrvmYLq7F0eddyA6hxTqoN3c6GBiHHHtCeJjLG Gl9TyNvuFya9xqfn1EB7AQq5WTtO31jN5FpuNskEfrujevduAfx8j7MfMoRpcgSsirVO4XxY1 PwOFZ7LaDiDd28iIeM0nTn2rl0Xmevn65OWUOT7NkQryZ0XL8O++2QguF3ZkglfMBv+h26jji ZN+zPLWdVqRgi4RtJmaUpz7IHWR061sTSEJlgPQyh56j8oBe+sbWORBu5LUo1yyOVi+G3UBK3 Ji3oOtww3POA6hrCbSxaleCi+Bpp6TDVR2FMUqm8seoKPf6Pu5T+bBa+fgJ8k+OXZCxYJ6o0z 5DbcoUJRdhJn06KzI38Hvc8YnGBVjE2NFl8p6xuJCjh6AZVvsKIHZtE0WbYJHRGdbdBX23KP1 Tz2e9eZGoGgmuZbDwA/B9NpOWW0Y5/4P5Y6WAe1A7132GPpucLFjDS4ZCWotssc9nB7MjdmNM FYez5NdXCt8iKF5x11iBQwhyWtLVIirRP7JSr8T31N8+h0JW1uPv9Be+KE4s1FhqfhmLd7/bK dsMm6DtreSVVeHUjwR1gXE2DDmMuFPIiTRQOZGy707QHRMax0DGco+QtJGkHSgirRY1cRFopb 5TZ0Wsw0VYGePdP430n2OgqSAa5LUK9B5pvON6eHJvS4ZouOeyfggHh0QiFNSFCxk0qg= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20664 Cc: 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > With this patch, "RET" works as expected, while "" is giving an > error for a reason I don't understand. Bug#20398? martin From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 10:15:35 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 14:15:35 +0000 Received: from localhost ([127.0.0.1]:58472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxc7G-000113-U0 for submit@debbugs.gnu.org; Wed, 27 May 2015 10:15:35 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44959) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxc7A-00010l-4X for 20664@debbugs.gnu.org; Wed, 27 May 2015 10:15:28 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t4REFH9u001872 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 May 2015 14:15:18 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t4REFHcC022805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 27 May 2015 14:15:17 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t4REFG6e002321; Wed, 27 May 2015 14:15:16 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 27 May 2015 07:15:16 -0700 (PDT) From: Drew Adams To: Oleh Krehel Subject: RE: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> In-Reply-To: <877frup37r.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20664 Cc: 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Please check the patch. I get this:=20 widget-button-click: Wrong type argument: consp, # From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 10:35:14 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 14:35:14 +0000 Received: from localhost ([127.0.0.1]:58483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxcQH-0001Th-Lu for submit@debbugs.gnu.org; Wed, 27 May 2015 10:35:13 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38333) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxcQA-0001T3-Tq for 20664@debbugs.gnu.org; Wed, 27 May 2015 10:35:07 -0400 Received: by wizo1 with SMTP id o1so25076081wiz.1 for <20664@debbugs.gnu.org>; Wed, 27 May 2015 07:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=DX3FLcjP3ckOsdm4M3iD+W5e5yzVxkMIUV7sFuHoTsM=; b=RAtgbF343oMFBt7s4zoQQI76haj2pTdz2CQfcGWZrjdwMtBgQSTX406/xpScR42Pdy jPGfqU6TLHbzPEznZDpc3EgoJ1iRy93I/tEKCXsOo7FZnipPaivN3e3wN777qCwSD/sx I8iucuW9LJhRs6+hX3W5OI6J8NMN945v8NVwS5X24kVQ2IJaBRUHAIsforw+5IFRWoqG LeOrHu9Y7/lCTwcguSLDgHqOH6jkIXkB1EQMpTMDRSHHNdWpfsnMHw2mIHJaINhSgXUz 2K+BztM5qcibTVQJWZ1TJz/CMBCieJ1xa0AjAWrvy9vLrqulaepEKrbdUn36dyh/cWXU I6BA== X-Received: by 10.180.80.197 with SMTP id t5mr51388600wix.63.1432737297176; Wed, 27 May 2015 07:34:57 -0700 (PDT) Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id l6sm3962861wib.18.2015.05.27.07.34.56 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 May 2015 07:34:56 -0700 (PDT) From: Oleh Krehel To: martin rudalics Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> <5565D022.9020503@gmx.at> Date: Wed, 27 May 2015 16:28:33 +0200 In-Reply-To: <5565D022.9020503@gmx.at> (martin rudalics's message of "Wed, 27 May 2015 16:09:38 +0200") Message-ID: <871ti2p01a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20664 Cc: 20664@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) martin rudalics writes: >> With this patch, "RET" works as expected, while "" is giving an >> error for a reason I don't understand. > > Bug#20398? No, this is likely caused by the fact that `Custom-mode' binds "" to the incompatible (with buttons) `widget-button-click'. And even with 'follow-link t, "" supersedes "", which is actually bound to `push-button'. I think if `Custom-mode' didn't bind "", it would translate to "" and properly call `push-button'. From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 10:37:22 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 14:37:22 +0000 Received: from localhost ([127.0.0.1]:58487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxcSP-0001X4-6g for submit@debbugs.gnu.org; Wed, 27 May 2015 10:37:21 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:33696) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxcSJ-0001Wn-Av for 20664@debbugs.gnu.org; Wed, 27 May 2015 10:37:19 -0400 Received: by wgez8 with SMTP id z8so11519529wge.0 for <20664@debbugs.gnu.org>; Wed, 27 May 2015 07:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=1mKQGZB2QojO61JaUuJYDnzOT8WrgC9Ovx3gO2V152k=; b=VQEKphvh/YAlhPR0blm1s/u6C6ajGlRnKxieOMgkFeATS6yd19zkhd7jYINt9OH1DB r97evwnehcbwXXFpp5ctR973AsOjmJORPSZ/wODmKLo+h4g2UgJ6+XsPcW6x9iEQLc04 TsPIrFLJVh67xeh+8LVVTIdm+2LI+yecZVRfctdzij8t95U9HWHhXhAYnJcibfxsF2wb kVcdFKh3SjEuKAxP5Y+C0U415avjqelxT9qi4U30u0KCpS06pElEU/TywCKEt9WQCddv gGj82U+jL4kLVVspW/aGJYrY+zyMhxaJ0UR+dJYdS9rp4MVOS+6AAMEaMIWdTIUzQWxH BI6A== X-Received: by 10.180.101.138 with SMTP id fg10mr6701531wib.46.1432737429683; Wed, 27 May 2015 07:37:09 -0700 (PDT) Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id nb9sm3980137wic.10.2015.05.27.07.37.08 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 May 2015 07:37:08 -0700 (PDT) From: Oleh Krehel To: Drew Adams Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> Date: Wed, 27 May 2015 16:30:46 +0200 In-Reply-To: (Drew Adams's message of "Wed, 27 May 2015 07:15:16 -0700 (PDT)") Message-ID: <87vbfenld5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20664 Cc: 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Drew Adams writes: >> Please check the patch. > > I get this: > > widget-button-click: Wrong type argument: consp, # Yes, I get the same thing when clicking "". It works fine for "RET" and "" though. With the additional code from above, it also should work for "", but I wonder if there's a better way. From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 10:59:22 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 14:59:22 +0000 Received: from localhost ([127.0.0.1]:58498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxcne-00021T-6V for submit@debbugs.gnu.org; Wed, 27 May 2015 10:59:22 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44503) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxcnX-00021B-In for 20664@debbugs.gnu.org; Wed, 27 May 2015 10:59:16 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t4REx4io005327 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 May 2015 14:59:05 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t4REx4fS026269 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 27 May 2015 14:59:04 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t4REx331026632; Wed, 27 May 2015 14:59:03 GMT MIME-Version: 1.0 Message-ID: <5e5c076d-ca7b-401c-8c65-3e87f86b601b@default> Date: Wed, 27 May 2015 07:59:03 -0700 (PDT) From: Drew Adams To: Oleh Krehel , martin rudalics Subject: RE: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> <5565D022.9020503@gmx.at> <871ti2p01a.fsf@gmail.com> In-Reply-To: <871ti2p01a.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20664 Cc: 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > >> With this patch, "RET" works as expected, while "" is > >> giving an error for a reason I don't understand. > > Bug#20398? >=20 > No, this is likely caused by the fact that `Custom-mode' binds > "" to the incompatible (with buttons) `widget-button-click'= . > And even with 'follow-link t, "" supersedes "", > which is actually bound to `push-button'. >=20 > I think if `Custom-mode' didn't bind "", it would > translate to "" and properly call `push-button'. FWIW: With `emacs -Q', setting `mouse-1-click-follows-link' =3D nil, `mouse-2' gives the same error message, plus an additional error saying that `symbol' is an bound variable. widget-button-click: Wrong type argument: consp, # Symbol's value as variable is void: symbol From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 11:22:37 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 15:22:37 +0000 Received: from localhost ([127.0.0.1]:58508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxdAC-0002ZF-3n for submit@debbugs.gnu.org; Wed, 27 May 2015 11:22:37 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38849) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxdA6-0002Yy-9S for 20664@debbugs.gnu.org; Wed, 27 May 2015 11:22:34 -0400 Received: by wizo1 with SMTP id o1so26951434wiz.1 for <20664@debbugs.gnu.org>; Wed, 27 May 2015 08:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Z8IS+5apEAJTfepD54z5vf3vzaY4rKwMHtAzrknmbLw=; b=iRYf4TmIcYxqDfUaFRBnZH0dIRw8Q82YvKMhGFKd4F4h9bj1+bE/DAfTNSsAy+0POa QJ40tlY5jTNeTFBDX6b7nmwakjl2h8iFsCUNcFz2Cx22eM/AkR7lLpWDIlBMf16xCnRB YtYiY1nrwXGsbSB/HsbWkz1oH1ikx3d1APicbGgNUJTAeNL2T0QXyIAmeQiTyNSjOeqH V2H1KTKgFlWLjFDD6SeV56f+FvhN+5GLyJSkEI4MA8wf4Sq0KN8K4EDvucnwHZZIvvah kyrGWo066fs5lF7/dWgCKv2wYoxtiDJIPf28mBuJ0vnHtDqOoLtBrnsbX008oyIthZUc tztw== X-Received: by 10.180.218.195 with SMTP id pi3mr7080627wic.71.1432740144799; Wed, 27 May 2015 08:22:24 -0700 (PDT) Received: from firefly (dyn069045.nbw.tue.nl. [131.155.69.45]) by mx.google.com with ESMTPSA id l6sm4160193wib.18.2015.05.27.08.22.24 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 May 2015 08:22:24 -0700 (PDT) From: Oleh Krehel To: Drew Adams Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> <5565D022.9020503@gmx.at> <871ti2p01a.fsf@gmail.com> <5e5c076d-ca7b-401c-8c65-3e87f86b601b@default> Date: Wed, 27 May 2015 17:16:01 +0200 In-Reply-To: <5e5c076d-ca7b-401c-8c65-3e87f86b601b@default> (Drew Adams's message of "Wed, 27 May 2015 07:59:03 -0700 (PDT)") Message-ID: <87r3q2nj9q.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20664 Cc: martin rudalics , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Drew Adams writes: > FWIW: With `emacs -Q', setting `mouse-1-click-follows-link' = nil, > `mouse-2' gives the same error message, plus an additional error saying > that `symbol' is an bound variable. > > widget-button-click: Wrong type argument: consp, # > Symbol's value as variable is void: symbol Strange, cus-edit.el does have lexical-binding, it should work. From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 11:28:51 2015 Received: (at 20664) by debbugs.gnu.org; 27 May 2015 15:28:51 +0000 Received: from localhost ([127.0.0.1]:58519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxdGA-0002ie-FM for submit@debbugs.gnu.org; Wed, 27 May 2015 11:28:50 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:31838) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YxdG3-0002iK-MA for 20664@debbugs.gnu.org; Wed, 27 May 2015 11:28:44 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t4RFSWgU017919 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 May 2015 15:28:33 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t4RFSWo3018550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 27 May 2015 15:28:32 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t4RFSWDW030338; Wed, 27 May 2015 15:28:32 GMT MIME-Version: 1.0 Message-ID: <6906bf03-7753-49e2-816a-0f5c7287eb5f@default> Date: Wed, 27 May 2015 08:28:31 -0700 (PDT) From: Drew Adams To: Oleh Krehel Subject: RE: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> <5565D022.9020503@gmx.at> <871ti2p01a.fsf@gmail.com> <5e5c076d-ca7b-401c-8c65-3e87f86b601b@default> <87r3q2nj9q.fsf@gmail.com> In-Reply-To: <87r3q2nj9q.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20664 Cc: martin rudalics , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > FWIW: With `emacs -Q', setting `mouse-1-click-follows-link' =3D nil, > > `mouse-2' gives the same error message, plus an additional error > > saying that `symbol' is an bound variable. > > > > widget-button-click: Wrong type argument: consp, # > 259 to 272 in *Customize Face: Dired Header*> > > Symbol's value as variable is void: symbol >=20 > Strange, cus-edit.el does have lexical-binding, it should work. My bad. Sorry for the noise. Adding a -*- lexical-binding:t -*- declaration to the patch-test file I used makes it work - the link is followed OK, and there is no void-var error. (But I do still get the wrong-type-arg error.) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 14:47:07 2020 Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 18:47:07 +0000 Received: from localhost ([127.0.0.1]:39039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyvz-0007Qv-Iu for submit@debbugs.gnu.org; Thu, 17 Sep 2020 14:47:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyvx-0007Q9-7Y for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 14:47:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8gaRnKhJ4mqd9aU/cE0uFveh3zP7ak1FE01M8KVaEW8=; b=I+p033GT3Yv3g/Amgd8D2JI1SR ZQqJ3UR8CJPjX9C6yxb3y4R0TPRF0uoYsWYdR4YgPe498foYuAQMlcZJxFuFmYkY0gHPaiTFcebWi e9TwDFd/uYubAAPEjZtoWgQ5SpOqWH0kC0onswC5wshhg3NUBVcjGK4mVFnNzGbiQeME=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIyvn-0003kL-KJ; Thu, 17 Sep 2020 20:46:58 +0200 From: Lars Ingebrigtsen To: Oleh Krehel Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> X-Now-Playing: Neil Young's _Tonight's the Night_: "Speakin' Out" Date: Thu, 17 Sep 2020 20:46:54 +0200 In-Reply-To: <877frup37r.fsf@gmail.com> (Oleh Krehel's message of "Wed, 27 May 2015 15:19:52 +0200") Message-ID: <874knwmeap.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Oleh Krehel writes: > * lisp/cus-edit.el (custom-face-value-create): Make the face name into > a button that calls `find-face-definition'. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20664 Cc: 20664@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Oleh Krehel writes: > * lisp/cus-edit.el (custom-face-value-create): Make the face name into > a button that calls `find-face-definition'. [...] > + (setq opoint (point)) > + ;; Face name (tag). > + (insert " " tag) > + (make-button opoint (point) > + 'follow-link t > + 'action (lambda (&rest _x) (find-face-definition symbol)))) Makes sense to me. I tweaked it a bit before applying, though -- used insert-text-button for convenience. > With this patch, "RET" works as expected, while "" is giving an > error for a reason I don't understand. In order to make it work for the > mouse, I have to do something contorted instead of a plain > `make-button': I think that's just a bug in Customize -- I think I've now fixed that, but it involved some refactoring, so hopefully I didn't break anything. But a standard Customize buffer seems to have the same number of things that work before/after the rework, so I'm hopeful. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 14:47:13 2020 Received: (at control) by debbugs.gnu.org; 17 Sep 2020 18:47:13 +0000 Received: from localhost ([127.0.0.1]:39042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyw4-0007RC-Px for submit@debbugs.gnu.org; Thu, 17 Sep 2020 14:47:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyw3-0007Qo-4R for control@debbugs.gnu.org; Thu, 17 Sep 2020 14:47:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GX2W8z7bSNjPELaE25DyopKceAk0jMK+psSq+88/uu0=; b=r1JEx/+ce163DDq5ottz+PjLZN yZqt3McwR+uagsJkLg6aszcFMHhHcn1NJ4EFXuTHbZhfpajXGG5ZDWyha7lU6TEXsVALerURavMSr 5GlxPf6c0gBRWl3ZdbkBnmMlsbUFgbUwYW9jjqboEAroAcYY8i/JDQsNBLwb1/O6Uc2U=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIyvv-0003kV-Ah for control@debbugs.gnu.org; Thu, 17 Sep 2020 20:47:05 +0200 Date: Thu, 17 Sep 2020 20:47:02 +0200 Message-Id: <87363gmeah.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #20664 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 20664 fixed close 20664 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 20664 fixed close 20664 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 16:16:28 2020 Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 20:16:28 +0000 Received: from localhost ([127.0.0.1]:39205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0KS-0007dv-KB for submit@debbugs.gnu.org; Thu, 17 Sep 2020 16:16:28 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:52064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0KR-0007dk-Md for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 16:16:28 -0400 Received: by mail-wm1-f45.google.com with SMTP id w2so3171513wmi.1 for <20664@debbugs.gnu.org>; Thu, 17 Sep 2020 13:16:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=pHDWb7C5mVnh/1pVRUislQAcdwedCB2SyYaNW0WIFGw=; b=ubaFnvXSSjZr5LngdLzKJi7Xl0S/HH4ZBiav7NWofDfv8VRc8Yw5R5lDtTZLdXovc9 vvO5kjwAIGq1htP4Kqh3wRz08MeVlq9u7aH/gbnp/t6Jb+sTvnwFPT7FOnsLkdv6hjH/ VJ/mCWWwh3D+T9KTcdx+VFHIPrksu217ZbhEbz+Hm9RzthSpCPTaAQvheShoqXvHPbI5 ulhgKQw28JKm/5EtC4q7EJfQBb3q24j4VqXWowuNL5gfMP39MAjvHIhPiEFNxlOHKAOO JbQnVRT+32GR4KF9J9vnCP8KOYaOcyrP3xqLAHcMyBKPWTU41pYhzzCw7YhihDwpghvP Ny1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=pHDWb7C5mVnh/1pVRUislQAcdwedCB2SyYaNW0WIFGw=; b=AvoFybAstGomdyIDeLTLvU9F9U2A01vshqCLMe5elGRaNxtoK3dK8m949Hcyb/GeUM Z6Wyh8jHZRXuu6hrCDQB69RRJ/KClcFxhir7mjz1vgDS4Vp8HXzJ/EIOhGYNo1u38CmY d5Yj49aivjspCHfh6DgcyRKooo+GXNTlINWUcvUD9dr/sAreoM2T0aOwKz5Pxj+ORn8z FONRpRv7Ayl2H8DeydlGMn468bhwkeNYJCDjj/JUptm8alMA+E51pkc2qB2AVu1HJ6kK OCYEE1RjsdEsHjn3KJYcj9mRjV7TGTyMuxe1yrfYkNgk+HUaD6KyTnUGImSR6ue2kfig z7vA== X-Gm-Message-State: AOAM533j1+R39FASAi9MHAiIOju23X+AI34AWMX9ObsnQyETABrPDFsy QzrI1W5lrqcZ4k997K2tAcbfxOJamDbXZi922PQ= X-Google-Smtp-Source: ABdhPJznP9KJjz9TFd3hme7LNRdtLTn+A3D9pqc9xOHMwmzxiShUb2ROxjkRalvPIOHNnZBZoH7HBWbyCqXu+zG/Hv0= X-Received: by 2002:a1c:23c9:: with SMTP id j192mr12261261wmj.6.1600373781843; Thu, 17 Sep 2020 13:16:21 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Thu, 17 Sep 2020 17:16:09 -0300 Message-ID: Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000c6546c05af880e65" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20664 Cc: Oleh Krehel , Drew Adams , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c6546c05af880e65 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Oleh Krehel writes: > >> * lisp/cus-edit.el (custom-face-value-create): Make the face name into >> a button that calls `find-face-definition'. > > [...] > >> + (setq opoint (point)) >> + ;; Face name (tag). >> + (insert " " tag) >> + (make-button opoint (point) >> + 'follow-link t >> + 'action (lambda (&rest _x) (find-face-definition symbol)))) > > Makes sense to me. I tweaked it a bit before applying, though -- used > insert-text-button for convenience. > Why a button.el button, and not a link widget? Using a button.el button makes it look like TAB is inconsistent, because it skips the button, so you can't get to the button by just pressing TAB. And given there are links to which you can get to by pressing TAB, not being able to reach this one makes it feel like something is wrong. --000000000000c6546c05af880e65 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
>>= ; * lisp/cus-edit.el (custom-face-value-create): Make the face name into>> =C2=A0 a button that calls `find-face-definition'.
>> [...]
>
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq opoint (= point))
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Face name (tag).
>= ;> + =C2=A0 =C2=A0 =C2=A0 =C2=A0(insert " " tag)
>> += =C2=A0 =C2=A0 =C2=A0 =C2=A0(make-button opoint (point)
>> + =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 'fol= low-link t
>> + 'action (lambda (&rest _x) (find-face-defi= nition symbol))))
>
> Makes sense to me.=C2=A0 I tweaked it a b= it before applying, though -- used
> insert-text-button for convenien= ce.
>

Why a button.el button, and not a link widget? Using a b= utton.el button
makes it look like TAB is inconsistent, because it skips= the button, so
you can't get to the button by just pressing TA= B.

And given there are links to which you can get = to by pressing TAB, not
being able to reach this one makes it feel like = something is wrong.
--000000000000c6546c05af880e65-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 16:33:13 2020 Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 20:33:13 +0000 Received: from localhost ([127.0.0.1]:39219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0af-00082s-L4 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 16:33:13 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ0ad-00082d-7p for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 16:33:12 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HKOfVE029483; Thu, 17 Sep 2020 20:33:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=OvfOyatoKsUiWZXb50RCTZcRZ7UrSXqDHSs2GPEkxeA=; b=MBgtYtahop5yl+CZnRCoapjFJbE0P38JQgFpZIwHjkz82ZvLeoVz+xSPaA0MRTTF+7Vv 29SEWgIxv3dPFUQCUQWrZ2bTTZmiZ/g1hj+EME8ILoZPbOn3F/a2/5qovYQaV+Xpe9um FsSVcRwUjUX0/pQkLtiVdaPMJMU3TJgKZVgQYkjnSAUrtiCWS0RLIqLVdlb4ixjprLLH pB07yjHmmGAgHfBEayNgJZtJcedQYtk4Ak4PbWW+DUUPHEWMKEFvb2hlltb72xzwiwKx YHitbQUZN1snSxYctCMGK0jzFMDJRd1v1NvL71K111wtoFvzDC76bkVY9pRKijKvx0YK Lw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 33j91dwbbn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Sep 2020 20:33:05 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08HKU6LS005599; Thu, 17 Sep 2020 20:31:04 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33khpnm6ts-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Sep 2020 20:31:04 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08HKV1Q7012656; Thu, 17 Sep 2020 20:31:01 GMT MIME-Version: 1.0 Message-ID: Date: Thu, 17 Sep 2020 20:30:59 +0000 (UTC) From: Drew Adams To: Mauro Aranda , Lars Ingebrigtsen Subject: RE: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170151 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9747 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 mlxlogscore=999 clxscore=1011 adultscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009170150 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20664 Cc: Oleh Krehel , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Makes sense to me.=C2=A0 I tweaked it a bit before applying, though -- u= sed >> insert-text-button for convenience. > > Why a button.el button, and not a link widget? Using a > button.el button makes it look like TAB is inconsistent, > because it skips the button, so you can't get to the > button by just pressing TAB. > > And given there are links to which you can get to by > pressing TAB, not being able to reach this one makes > it feel like something is wrong. [Caveat: I haven't tried the updated code.] Yes, it's important that the fix fit well with Customize, both from a UI/user point of view and from a coding point of view. Please also do make sure that `mouse-1-click-follows-link' is effective, i.e., that it has its expected effect when either nil or non-nil. (I have it set to nil, BTW.) From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 17:42:13 2020 Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 21:42:13 +0000 Received: from localhost ([127.0.0.1]:39916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ1fQ-0001OK-PX for submit@debbugs.gnu.org; Thu, 17 Sep 2020 17:42:12 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:40902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ1fP-0001O7-1H for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 17:42:11 -0400 Received: by mail-wr1-f49.google.com with SMTP id j2so3559324wrx.7 for <20664@debbugs.gnu.org>; Thu, 17 Sep 2020 14:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=coz2KQMEuEd6oMX75ZR/5EiqojcKy5P7xxe/s+Oo3VE=; b=q12auuYWb66ZtP+BEdXa7UoQDUkZp2eHCvEDKsBMjX/Pro7m2FmRD+V7XgCSXsTa2R mPkT+sacOMlu8mn9ScLmOuoET2fTISaivhfe9o5cSf2BQ9lI81Lxido7xNbwiD5WkB0i R0dqpDGJLr1ac2NaVgSMG/V/Xkei+y5pFsVbOhaTH6UjuIxiw2fC7G1Z++nplrWF5AXr xduj51VDP+1j3pkWeMALLFzcHWaeoFpYBzPZmpPe3FHZ3j2HH0jFX0D3h3+ZEf9sA8zl d2xeNmbYpGOS0h5zHeZxMou6QSYxQwXXZnG/LlVTJ5/9UtI9H7qBQZRRqmFLb4LpTZAV d94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=coz2KQMEuEd6oMX75ZR/5EiqojcKy5P7xxe/s+Oo3VE=; b=EY+0nSSKWVQaJWPJeKtd5ru5wc78b8KA05f8wshxTRjEI6oKdGM13cLbvVT0BbU//E jUNliusDmYIcume6+WozZi3cLDlQ9rwGEIJBBmyP8wOy1FEbzzZhiTwMQ9WtD8cACvT1 fVJKLhsgp3EDrYWNj2nhdDt96tx1peL9cLn1lTwOnZRAHt11nZnMFvtnXKo7wiruTnaY xWB6dYqEvIKjNoEfpxbwbQObeQnwNMZN6eI3eptxrA/JC5vCVpefEr7wrAeeYBWsxY2Y yxNhTvd43e9QFfMB/64FTkO676LLWk8csTu/iK9n9njtUFNaKyKEfsXVSV0ukcnEBlgz 580g== X-Gm-Message-State: AOAM530Zu7+JNbeqUiCAZ5pHGfzlJHbU20lZEi/O/c3ryaxFg0X+e7ti VCCmi46fCSneNGxGWIEGS7cERCD06UdYFVWy4Ks= X-Google-Smtp-Source: ABdhPJzmxihCy0sLhXr8btDhT56yhzwUDgeH+lOet6jlgtOsUF38oJycG6tXCs9nUkPSSHZsuxVBjHpRT2y+MRKk5MU= X-Received: by 2002:adf:ec86:: with SMTP id z6mr35074360wrn.109.1600378925014; Thu, 17 Sep 2020 14:42:05 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Thu, 17 Sep 2020 18:41:53 -0300 Message-ID: Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="00000000000055032d05af89415e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20664 Cc: Oleh Krehel , Drew Adams , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000055032d05af89415e Content-Type: multipart/alternative; boundary="00000000000055032c05af89415c" --00000000000055032c05af89415c Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > I think that's just a bug in Customize -- I think I've now fixed that, > but it involved some refactoring, so hopefully I didn't break anything. > But a standard Customize buffer seems to have the same number of things > that work before/after the rework, so I'm hopeful. :-) After the change in wid-edit.el, clicking in the Value Menu button doesn't display a menu. I attach a patch to fix it. --00000000000055032c05af89415c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> I think that's just a bug in C= ustomize -- I think I've now fixed that,
> but it involved some r= efactoring, so hopefully I didn't break anything.
> But a standar= d Customize buffer seems to have the same number of things
> that wor= k before/after the rework, so I'm hopeful. =C2=A0:-)

After the c= hange in wid-edit.el, clicking in the Value Menu button
doesn't disp= lay a menu.

I attach a patch to fix it.
--00000000000055032c05af89415c-- --00000000000055032d05af89415e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-recent-change-in-wid-edit.patch" Content-Disposition: attachment; filename="0001-Fix-recent-change-in-wid-edit.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kf7c8y0u0 RnJvbSA1ZjkyZDA2YWYzNDNjM2FjMjhmMWZiMWJlNzJlYjY5NWQzOGZlNzcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFRodSwgMTcgU2VwIDIwMjAgMTg6MzE6NTcgLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aXggcmVjZW50IGNoYW5nZSBpbiB3aWQtZWRpdAoKKiBsaXNwL3dpZC1lZGl0LmVsICh3aWRnZXQt YnV0dG9uLS1jaGVjay1hbmQtY2FsbC1idXR0b24pOiBSZWNvcmQgdGhlCmVuZGluZyBwb3NpdGlv biBvZiBldmVudCwgYmVjYXVzZSB3ZSBtaWdodCBuZWVkIGl0IHdoZW4KdGhlIDptb3VzZS1kb3du LWFjdGlvbiBmdW5jdGlvbiByZXR1cm5zIG5vbi1uaWwuICAoQnVnIzIwNjY0KQotLS0KIGxpc3Av d2lkLWVkaXQuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3Avd2lkLWVkaXQuZWwgYi9saXNwL3dpZC1lZGl0 LmVsCmluZGV4IDhiZTQ4OWJmMDguLjVhYzUyNzc3ZjggMTAwNjQ0Ci0tLSBhL2xpc3Avd2lkLWVk aXQuZWwKKysrIGIvbGlzcC93aWQtZWRpdC5lbApAQCAtOTc4LDcgKzk3OCw4IEBAIHdpZGdldC1i dXR0b24tLWNoZWNrLWFuZC1jYWxsLWJ1dHRvbgogSWYgbm90aGluZyB3YXMgY2FsbGVkLCByZXR1 cm4gbm9uLW5pbC4iCiAgIChsZXQqICgob2V2ZW50IGV2ZW50KQogICAgICAgICAgKG1vdXNlLTEg KG1lbXEgKGV2ZW50LWJhc2ljLXR5cGUgZXZlbnQpICcobW91c2UtMSBkb3duLW1vdXNlLTEpKSkK LSAgICAgICAgIG5ld3BvaW50IHBvcykKKyAgICAgICAgIChwb3MgKHdpZGdldC1ldmVudC1wb2lu dCBldmVudCkpCisgICAgICAgICBuZXdwb2ludCkKICAgICAoY2F0Y2ggJ2J1dHRvbi1wcmVzcy1j YW5jZWxsZWQKICAgICAgIDs7IE1vdXNlIGNsaWNrIG9uIGEgd2lkZ2V0IGJ1dHRvbi4gIERvIHRo ZSBmb2xsb3dpbmcKICAgICAgIDs7IGluIGEgc2F2ZS1leGN1cnNpb24gc28gdGhhdCB0aGUgY2xp Y2sgb24gdGhlIGJ1dHRvbgotLSAKMi4yOC4wCgo= --00000000000055032d05af89415e-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 17 17:46:59 2020 Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 21:46:59 +0000 Received: from localhost ([127.0.0.1]:39921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ1k3-0001VE-CO for submit@debbugs.gnu.org; Thu, 17 Sep 2020 17:46:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ1k1-0001Uz-Eo for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 17:46:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ltbaG9YUiB8YI8pL+HWwvJEV3oUKqfSgHNrhU+yZdZ0=; b=H2JpyYCrKHG2fUHRoxR4QppLjm 65vylw1+eDZh4A6OYmgJg4VAelFGZzfFrxJSFITK8GUItFLJm/SAsSvQFnzXcMN/XEqskDAMzi1Iw 2JVVS5euPPh9z5V5P0Nic/bfkfJ7xO0i2QPCC94aSoFgpy7sf2v2uflvq1B7lrHWA5kw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJ1jr-0005Ux-6P; Thu, 17 Sep 2020 23:46:50 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: X-Now-Playing: Portishead's _Third_: "Machine Gun" Date: Thu, 17 Sep 2020 23:46:45 +0200 In-Reply-To: (Mauro Aranda's message of "Thu, 17 Sep 2020 18:41:53 -0300") Message-ID: <87d02kkrei.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > After the change in wid-edit.el, clicking in the Value Menu button > doesn't display a menu. > > I attach a patch to fix it. Thanks; applied to the trunk. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20664 Cc: Oleh Krehel , Drew Adams , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > After the change in wid-edit.el, clicking in the Value Menu button > doesn't display a menu. > > I attach a patch to fix it. Thanks; applied to the trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 07:29:12 2020 Received: (at 20664) by debbugs.gnu.org; 18 Sep 2020 11:29:12 +0000 Received: from localhost ([127.0.0.1]:41066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJEZk-00040d-1q for submit@debbugs.gnu.org; Fri, 18 Sep 2020 07:29:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJEZi-00040P-5J for 20664@debbugs.gnu.org; Fri, 18 Sep 2020 07:29:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qd/IflJkvSdTY3JBNyT6DDm+H9+pCwbsuHoiOmxuxUg=; b=DT4q2IHKxTcbImDVm3tw2FC9VU gNNNJwZKrB9cG3bAo55e3c6h8q9kfsAWYECL7/1spohPywvHiJzpb/7A/vY56LQMTppwL3CkgZlsi NFlLVly3hhD4rkeWSnGCERiXooSRQek9ocjzC33PrGEJ8Sz/vlBcw9ZpmcwyyxCVwlJ0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJEZY-0005BW-KV; Fri, 18 Sep 2020 13:29:03 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUPDBVJRlF5fIPJ ycn///+aolA5AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QJEgscFTH+WAYAAAGUSURBVDjLjVMN1uMg CERzAcELBHKBXbj/3XZE89Nu+72PvJrUARkYJPpqbf7KN7y0l7/8Gnl5FLsBhRvzCcQVU3zlyaX6 fVgbEa1lQC36kh8nwY+NusQHToClLfYs2p4Mr7JETcWuKLhsE7bww02ZZxYZgFL3IuER8fdwxFnr 0eigaIIqeWeJVjhZ9KDW75Q1/EpylwESR/ietYy2yNgTzajIiKKoD3CGsVLZaWRnFhu0SzYAVrgo gDBsm3lSCMPhFU/uw1BspoWPKEINJ70JftL1n6bizay1Jcdrd4u7pg5gSK3G8NpoMEdtxj3czXmf A7IRGtsBHKOMUJY1f/0BuD71JTGtlhrt9BuTb7UI+iUsqXiB9OgX1D12JI/b+vXloJvv/4H6OeLP CRxhDrkgxhgtG6qTZnle8lLMwhfBbR6aA8n24D0AuUSqNpuPpYOT+Xlpq87TCnly8dpugWaDF8nn zVlAJg962HTybeh3nAEQHkM/rpdmTbkwl7W2ikEzi8OmyXyxjbu5umPvRo/vFaC5/gOcpklCLuk+ uAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOS0xOFQxMToyODoyMCswMDowMG9taZgAAAAldEVY dGRhdGU6bW9kaWZ5ADIwMjAtMDktMThUMTE6Mjg6MjArMDA6MDAeMNEkAAAAAElFTkSuQmCC X-Now-Playing: Stina Nordenstam's _People Are Strange_: "I Dream of Jeannie" Date: Fri, 18 Sep 2020 13:28:58 +0200 In-Reply-To: (Mauro Aranda's message of "Thu, 17 Sep 2020 17:16:09 -0300") Message-ID: <87a6xnjpc5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > Why a button.el button, and not a link widget? Using a button.el button > makes it look like TAB is inconsistent, because it skips the button, so > you can't get to the button by just pressing TAB. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20664 Cc: Oleh Krehel , Drew Adams , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Why a button.el button, and not a link widget? Using a button.el button > makes it look like TAB is inconsistent, because it skips the button, so > you can't get to the button by just pressing TAB. I just hate the widget code... soooo much! But I've now rewritten it to use a widget. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 18 07:39:42 2020 Received: (at 20664) by debbugs.gnu.org; 18 Sep 2020 11:39:42 +0000 Received: from localhost ([127.0.0.1]:41081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJEjt-0006Pw-N2 for submit@debbugs.gnu.org; Fri, 18 Sep 2020 07:39:42 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:36497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJEjs-0006Pk-8H for 20664@debbugs.gnu.org; Fri, 18 Sep 2020 07:39:40 -0400 Received: by mail-wm1-f48.google.com with SMTP id z9so5226870wmk.1 for <20664@debbugs.gnu.org>; Fri, 18 Sep 2020 04:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lZXOAR5Pn+I1jnEV30zbBIN5RMtdfskTWlhrm9Q72Qs=; b=W5+8BnOtjbGfl9FNlGyWGbOUbJdEoFzjW7jcfhfmvFCiqoZazUacOL1Km+58VYIjIX h7KyfLgN0RQZHXA8r+Hjggeq4YQmmbEXDzo4V+4w7lL1IHYyUYpBgCneewDAa34SIwG7 VJEgxQl4JS39O+rulja4R6XhTLSRSIAZ6HPxuSwN6yCK7Ww8lzNkkAbzyHYE+GKsp5Dd xDghjHT0KFcHd5WGyqM10P3HYQWtjueVBYIwKBtBWvvFqYkKw2aZwuaQ4B+DrUUFTh4m Hc3tQn0U0v5p3eqpF881GluK0Lm25+KJjKXqi0hZv8dg0aNkxIb0fzyOUZy+GMBSyXB8 cgpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lZXOAR5Pn+I1jnEV30zbBIN5RMtdfskTWlhrm9Q72Qs=; b=qOkPPHM8yQ9BH3XK74G8XasiGdypTpSNjyvBWEgoOLEJp5otcJzUZDY4V4iDLbPG3V UTVH5NM9HKuCsU8aWkywDAxwvzMx2TdiPBNF2F7isoS/FP90e456a8TLr44t2WVwA+KI 2MEwX2mQBnPpl5g2VQL4CEB0roDjg9L/wgTcvaSb58nNG8/P+w/KwnnSBXKNuSUV+RGS 1+MRrS80tO8mHxHmXZbLXp7POv6EhUg9dFOxIExb7uel9m7gQ4BQBESi2US8OfESddmQ jcZZxxZeVQQR8hU00qDfJHcw37NFIb5aCZ1ecAApDPx2bZX5nU2L6tpl6RRHNHHq8rNE a+SA== X-Gm-Message-State: AOAM533jbs/oJwDNm8lLkU1EUhezc7se+EtedvNv0f6iB6Jrq9uNjwAh PQWOl7FHXROxo7LCQu75Zb0ii5Pi2rfS2E4MMXs= X-Google-Smtp-Source: ABdhPJwXEOyQb1mQYgjuaZ6vpCKopEy0+nMBRbVYQB8oL9fWoCYxQxnYu2LA004/AYy1aFuXrNUqey2GUC6+AE3DPDo= X-Received: by 2002:a1c:e40b:: with SMTP id b11mr14709514wmh.100.1600429174392; Fri, 18 Sep 2020 04:39:34 -0700 (PDT) MIME-Version: 1.0 References: <87a6xnjpc5.fsf@gnus.org> In-Reply-To: <87a6xnjpc5.fsf@gnus.org> From: Mauro Aranda Date: Fri, 18 Sep 2020 08:39:22 -0300 Message-ID: Subject: Re: bug#20664: 25.0.50; Customize: Link option or face name to the source definition To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="0000000000006d8b4905af94f4cf" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20664 Cc: Oleh Krehel , Drew Adams , 20664@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000006d8b4905af94f4cf Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> Why a button.el button, and not a link widget? Using a button.el button >> makes it look like TAB is inconsistent, because it skips the button, so >> you can't get to the button by just pressing TAB. > > I just hate the widget code... soooo much! > > But I've now rewritten it to use a widget. Thanks! --0000000000006d8b4905af94f4cf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> Why a button.el button, and not a link widget? Using a button.el b= utton
>> makes it look like TAB is inconsistent, because it skips = the button, so
>> you can't get to the button by just pressing= TAB.
>
> I just hate the widget code... =C2=A0soooo much!
&= gt;
> But I've now rewritten it to use a widget.

Thanks! --0000000000006d8b4905af94f4cf-- From unknown Tue Aug 19 05:10:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Oct 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator