GNU bug report logs - #20663
page.el (forward-page): Avoid skipping pages

Previous Next

Package: emacs;

Reported by: Pierre Neidhardt <ambrevar <at> gmail.com>

Date: Tue, 26 May 2015 17:23:02 UTC

Severity: minor

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 20663 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 20663 <at> debbugs.gnu.org, Marcin Borkowski <mbork <at> mbork.pl>
Subject: Re: bug#20663: page.el (forward-page): Avoid skipping pages
Date: Sun, 10 Apr 2016 08:29:24 +0700
I did not expect this patch to be so confusing, but let me clarify the above questions:

- `forward-page' is called by `narrow-to-page', which is bound to 'C-x n p' by
  default.

- All the patch does it make the code consistent with its comments, that is:

	;; In case the page-delimiter matches the null string,
	;; don't find a match without moving.

- If you try the recipe (I just did on Emacs 24.5.1, don't have time to check
now on upstream), you'll see that a page gets skipped, which is not the desired
behaviour.

- As for side effects, there might be some, althought I haven't noticed anything
in a year of use. If there is, then it is a bug in the caller.

-- 
Pierre Neidhardt




This bug report was last modified 3 years and 42 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.