GNU bug report logs - #20645
sxml xpath exports "filter"

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20645 in the body.
You can then email your comments to 20645 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matt Wette <mwette <at> alumni.caltech.edu>
To: bug-guile <at> gnu.org
Subject: sxml xpath exports "filter"
Date: Sun, 24 May 2015 08:34:21 -0700

sxml xpath exports "filter" which is incompatible with the common procedure of the same name.

I suggest renaming unless it breaks a lot of code.

I use

  #:use-module ((sxml xpath)
		#:renamer (lambda (s) (if (eq? s 'filter) 'xp-filter s)))

but would rather other agree that renaming in sxml/xpath.scm is better.

Matt

Message #8 received at 20645 <at> debbugs.gnu.org (full text, mbox):

From: Matt Wette <mwette <at> alumni.caltech.edu>
To: 20645 <at> debbugs.gnu.org
Subject: sxml xpath exports "filter"
Date: Mon, 8 Feb 2016 20:03:11 -0800

This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.

I believe the fix can be implemented with the following changes to (sxml xpath):
1) (define node-filter filter)
2) In the #:export list, replace “filter” with “node-filter”

Matt

Message #11 received at 20645 <at> debbugs.gnu.org (full text, mbox):

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: Matt Wette <mwette <at> alumni.caltech.edu>
Cc: 20645 <at> debbugs.gnu.org
Subject: Re: bug#20645: sxml xpath exports "filter"
Date: Tue, 9 Feb 2016 09:16:07 -0500

On Mon, Feb 8, 2016 at 11:03 PM, Matt Wette <mwette <at> alumni.caltech.edu> wrote:
> This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.
>
> I believe the fix can be implemented with the following changes to (sxml xpath):
> 1) (define node-filter filter)
> 2) In the #:export list, replace “filter” with “node-filter”

Is this really a bug?  The module system allows names to have
different meanings without conflicting in a global namespace.  When
importing a module, you can choose which symbols to import, or prefix
all of the symbols with something.

- Dave

Message #14 received at 20645 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Matt Wette <mwette <at> alumni.caltech.edu>
Cc: 20645 <at> debbugs.gnu.org
Subject: Re: bug#20645: sxml xpath exports "filter"
Date: Thu, 11 Feb 2016 01:57:17 -0500

Matt Wette <mwette <at> alumni.caltech.edu> writes:

> This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.
>
> I believe the fix can be implemented with the following changes to (sxml xpath):
> 1) (define node-filter filter)
> 2) In the #:export list, replace “filter” with “node-filter”

We can't do this because it would break existing code that uses 'filter'
from (sxml xpath), and also introduce a Guile-specific change to the API
of a portable library.

However, you can rename 'filter' at import time as follows:

  (use-modules ((sxml xpath) #:select ((filter . node-filter))))

Does this work for you?

    Mark

Message #19 received at 20645-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Matt Wette <mwette <at> alumni.caltech.edu>
Cc: 20645-done <at> debbugs.gnu.org
Subject: Re: bug#20645: sxml xpath exports "filter"
Date: Thu, 23 Jun 2016 12:42:55 -0400

Mark H Weaver <mhw <at> netris.org> writes:

> Matt Wette <mwette <at> alumni.caltech.edu> writes:
>
>> This is a very annoying "bug".  The (sxml xpath) “filter” procedure overrides the builtin guile “filter”.
>>
>> I believe the fix can be implemented with the following changes to (sxml xpath):
>> 1) (define node-filter filter)
>> 2) In the #:export list, replace “filter” with “node-filter”
>
> We can't do this because it would break existing code that uses 'filter'
> from (sxml xpath), and also introduce a Guile-specific change to the API
> of a portable library.
>
> However, you can rename 'filter' at import time as follows:
>
>   (use-modules ((sxml xpath) #:select ((filter . node-filter))))
>
> Does this work for you?

Having not heard back for 19 weeks, I'm closing this bug now.

      Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.