From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 19:49:57 2015 Received: (at submit) by debbugs.gnu.org; 23 May 2015 23:49:57 +0000 Received: from localhost ([127.0.0.1]:54158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwJAv-0000VH-H4 for submit@debbugs.gnu.org; Sat, 23 May 2015 19:49:57 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43242 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwJAp-0000V6-OF for submit@debbugs.gnu.org; Sat, 23 May 2015 19:49:51 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YwJAo-0003Oh-Jb; Sat, 23 May 2015 19:49:46 -0400 From: Glenn Morris To: submit@debbugs.gnu.org Subject: incompatible, undocumented change to vc-working-revision X-Spook: United Nations Watergate Noriega ASDIC credit card X-Ran: tW6bt;!$]*Z*W,14=GTfVDU2#HYJ@`UW_F)]06Jxb+rM+c#R:u&"Uz_L6],=:t=}@yH[4| X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 23 May 2015 19:49:46 -0400 Message-ID: <6ok2vyzwf9.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Package: emacs Version: 25.0.50 mkdir /tmp/git cd /tmp/git git init touch 1 emacs-24.5: (vc-working-revision "1") ; -> nil Current master: (vc-working-revision "1") ; "master" C-h f vc-working-revision: If FILE is not registered, this function always returns nil. This changes documented behaviour without updating the doc or making a NEWS entry. Example breakage: http://lists.gnu.org/archive/html/help-gnu-emacs/2015-05/msg00384.html From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 19:58:51 2015 Received: (at control) by debbugs.gnu.org; 23 May 2015 23:58:52 +0000 Received: from localhost ([127.0.0.1]:54162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwJJW-0000hi-LO for submit@debbugs.gnu.org; Sat, 23 May 2015 19:58:51 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43425 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwJJP-0000hU-Kg for control@debbugs.gnu.org; Sat, 23 May 2015 19:58:44 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1YwJJO-00085B-Vw for control@debbugs.gnu.org; Sat, 23 May 2015 19:58:39 -0400 Date: Sat, 23 May 2015 19:58:38 -0400 Message-Id: Subject: control message for bug 19759 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 19759 by 20637 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 08 07:28:15 2015 Received: (at control) by debbugs.gnu.org; 8 Nov 2015 12:28:15 +0000 Received: from localhost ([127.0.0.1]:57325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvP4x-00070b-B9 for submit@debbugs.gnu.org; Sun, 08 Nov 2015 07:28:15 -0500 Received: from mout.gmx.net ([212.227.15.18]:64002) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZvP4v-00070T-VQ for control@debbugs.gnu.org; Sun, 08 Nov 2015 07:28:14 -0500 Received: from detlef.gmx.de ([87.146.36.137]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MZTP3-1a9Twv3vZ7-00LFgG for ; Sun, 08 Nov 2015 13:28:13 +0100 From: Michael Albinus To: control@debbugs.gnu.org Subject: control message for bug #19548 #20637 Date: Sun, 08 Nov 2015 13:28:12 +0100 Message-ID: <87fv0giskj.fsf@gmx.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:L6FhFEMaLg724V7EE/Vle+e8SeWnNgcOJ5KCrjRjGZY1OJ3Z7bO ddcx1XIuyJpZ8qEr2ZrJQvmi+M4Ap/sKUYBrbD6kLLOGQf0JMgRErzV/6xuR6rMbMck+r3z LqJRSnigzJdaQVSJVulWD87emxDrcMm19wdriUpBsejVl5yE2tJmx+sb/cTAqNkPL2nViAq 2RyJE/hQwe399xFKLEvSg== X-UI-Out-Filterresults: notjunk:1;V01:K0:/XUEXxWva34=:nBazTiX5CLg/fbe1NEwoLB 7mahwB49fcvjI1bwa0CuRZWILFdgiesmEUjPf8f7EyHMjwmkCoQtJFGNYmCzrVpmK5ffb3PrN CZYUsx+hwndf9apc7k/h/z+XcorxaWSYpOAZWw+ny4v7xmarp/EWTFLkMMQuYmCnDQWqO7p4g YHNGSqNneD+dCsPVqhhwyZw51Pxs2yB2zcJHZy21pe87ZhwGp5X22PhUdgaibSxXIJ0ivJ8Ph 9LysSfpQMnSUuusGzzwUMPwVcpSIR/ps/SWxmj3koH9gcdQAJAPD5jb0x06FCo7vewzKAq/Ww wNWpqF3e7i9qSutVakT1fD67bPs99xc96FmiBmYeBLA9UxWtRHnJfMqJ9kJkjX+tcbqPTA2VV 6LsXKxRo9wM89QGraCz4Cd1fJTTg+ZfnYEQORMjZeTOTFMlYO6otYZug6xV6/1HKiTw84kyXS 4yF7pbpgZ4YF4paaKiP/GTPUxB4Xu3oWFhDBrN5M0M8Cc1lsNGsL1UpSj9mWh0wRYfJpT2sj1 X5PB+YydXO0pcJ/GmA39DgLoVUj+FxjG4AqClIfvh3nIOzsySAuWD7yDj2+1xhWAcxlT0YN3Z do+hfjVXmfWoxkgM6Aj4NUHFxH8U5ZERAjEceUoeGrkwA3vutAsik3TFVZzOK43ffmD4iQihs tKzrT4X858kmLJPWZk4/0O2aV5+G/QLvC+9vZ/VQKS4WfsUHLbaYsKatLdJVa94/q/E3l++m6 cUsyNvLlSCF5AL/abPkKKtnTJNJr3JdGykt12sAXvLoXJtPyX1J672vjuXpCsv4gRqvtUN9ia z6eILOG X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) owner 20637 Dmitry Gutov From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 19:28:32 2016 Received: (at 20637) by debbugs.gnu.org; 28 Mar 2016 23:28:33 +0000 Received: from localhost ([127.0.0.1]:42583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akgaG-0008NZ-Mx for submit@debbugs.gnu.org; Mon, 28 Mar 2016 19:28:32 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akgaE-0008NG-Qp for 20637@debbugs.gnu.org; Mon, 28 Mar 2016 19:28:31 -0400 Received: by mail-wm0-f50.google.com with SMTP id r72so34624525wmg.0 for <20637@debbugs.gnu.org>; Mon, 28 Mar 2016 16:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=+R3ST6L/4y4hEsRO7DfvgyfWuD7hZfkG9P9EYZmE9+o=; b=F8xwMOUvQmmu9qyvamCmR6Fu0Fwqx7rURVf+3sbC/dOrXwLX+ak8XVYSEY/XIP0WHo mYMaF76iUQ5E9hZz3aZAHBkvGVfgeCijEPEoXZsmtJCVtF+HUGNHJuxpSapSBmbqsFGu 1bNRxfnUUy/qli1e/xNXm98viyOkNhceiTDdyEp3e7lV/H8vBv4iyBVLkk/sZD6pXzKE W+Iw/iiWD+Leq7Tsbix7i6Epmix+kNeCmzC07Iuco9TLejY9pL+u/gFVnhM/YXDwH5DX OjP9DZMPYuzPLdJyqMuXED/3/y39Fwhj03v0huZnqeFuxKAuAFpT5BwTU+73RCmpt+8r MYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:cc:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=+R3ST6L/4y4hEsRO7DfvgyfWuD7hZfkG9P9EYZmE9+o=; b=HYaI/mR2ihhEB+pnBx5M56y1N9FjTxfYNuZ2z3WAQ1+WoYxOBVXqLj+vuCiREZgXQ5 cGtxWtux4HtfGioPGrDJal8MybpmGES65mSdNlLaJJ0oYM9zimdDQYw5vwpbrijZhRbb VEFNVG+anJ9cdpqlc9zR93AGT8gyuaoXpZr6tKkziE02fIyEDVAEXn7Yl2Z3CY7aTRNz 3v5TPfMj0Owsh3r+mk2Cz0gHDtpbvE2F1W029RgtOhFq7lDrQhgnlL1VghYWMfbVHVHR JP7lmJL8XvQhTfGlvDpzBPdzR0XkWRev5syD4JiC+7bM8vUITDO8n6kxlK5JEX8LYtNn zvBQ== X-Gm-Message-State: AD7BkJKTRPNMM3x9ZtRgbWIn6tKoVrnYHR3Hxd9BRa24iT9RUMMnivn1m3akM3gnFrBc9Q== X-Received: by 10.28.9.19 with SMTP id 19mr13577151wmj.87.1459207705247; Mon, 28 Mar 2016 16:28:25 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id hq2sm26688569wjb.3.2016.03.28.16.28.23 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Mar 2016 16:28:24 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Glenn Morris , 20637@debbugs.gnu.org References: <6ok2vyzwf9.fsf@fencepost.gnu.org> From: Dmitry Gutov Message-ID: <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> Date: Tue, 29 Mar 2016 02:28:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <6ok2vyzwf9.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 05/24/2015 02:49 AM, Glenn Morris wrote: > Current master: > (vc-working-revision "1") ; "master" This has been caused by the commit 7f9b037245ddb662ad98685e429a2498ae6b7c62, which made both vc-state and vc-working-revision use vc-responsible-backend instead of vc-backend. As a result, in some backends these functions started return non-nil values for unknown files or directories, as long as they lie inside a VC repository. This change is indeed backward-incompatible, and it breaks the previous assumption of some backend functions that if FILE has been passed to it, then it's surely registered with the current backend. That's why the commit included changes adding lines like (unless (memq (vc-state file) '(nil unregistered))...), but it didn't get all affected code. In particular, it breaks an assumption I made when fixing #11757, that vc-git-state never receives an unregistered file as input. So if you evaluate (vc-state "1") now, it'll return `up-to-date'. While reverting the change makes some tests fail, we should fix them in different ways. For some backends, maybe, we should accept that (vc-state default-directory) and (vc-working-revision default-directory) will return nil. Alternatively, fix that problem inside the respective backends, without changing the dispatching functions. Also, reverting this commit also seems to uncover tests that shouldn't pass anyway. Checks like (should (eq (vc-state default-directory) (vc-state default-directory backend))) don't verify much, and in this case they seem to verify the wrong thing. More on that in the respective threads in emacs-devel later. Michael, thoughts? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 29 14:13:20 2016 Received: (at 20637) by debbugs.gnu.org; 29 Mar 2016 18:13:20 +0000 Received: from localhost ([127.0.0.1]:44090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aky8m-0007B2-1Z for submit@debbugs.gnu.org; Tue, 29 Mar 2016 14:13:20 -0400 Received: from mout.gmx.net ([212.227.15.19]:60219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aky8j-0007Ao-W9 for 20637@debbugs.gnu.org; Tue, 29 Mar 2016 14:13:18 -0400 Received: from detlef.gmx.de ([87.146.53.26]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MaIPo-1aR6uE1m2K-00JsEo; Tue, 29 Mar 2016 20:13:10 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> Date: Tue, 29 Mar 2016 20:13:09 +0200 In-Reply-To: <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> (Dmitry Gutov's message of "Tue, 29 Mar 2016 02:28:22 +0300") Message-ID: <87mvphnoei.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:Gi3A8gM7QiUhvyCKTg8KDX19aVQG/5CxSnmtSfhdj62AwX4OMoq uorHEK7xTg3hM7f6Oq/G9gDm0cfP0rN/+QqIW4NiocfPl0rHV1ThVbw1bG+VuUgUcWnDHvL /olvWbJWR8mhOW5ZUKQWX/GXPvw2JRlkpTRJy+IDwaWS2dLnPIpVvR5ZSAcPAMP5l0Fi+m8 UGYzyO8nUoJcbfzmzVYSw== X-UI-Out-Filterresults: notjunk:1;V01:K0:zLxOKtpuN70=:iHlVm+DaGJDOojWrxveVwk S+JyBkblrMZ8Lp9OK3snj47WgbEoCJO3i4paGdODoUrJbEbP2oowftFLCjfQdCzlKgZqYkvM1 FcP9swOBUQAvCsy/Jy1ETmC+Y8eVBfYLlmizEks4Rc7Y2syvueiwUOdaL7hFnGMjKAXXUgyNA jAXXZLKnK2QCF7PiXyBksiwqUAYdzFuOUrldvfZWkqNhVCpYo5WT4RDOal9DK7yDbRi1VPSnd /LdLGiuA8Xpf9rnKISIkCEZKXUltQbncIfXk9pDmnOtsiUrO1t2ilCTu95pmEPUlyfL/c7jqj p937kuFfY++RhL3oCY6bg7S5dulTfdG5R6Inai0FCphCg92xKxACxdQw1vyrB0FnQRZEofwOi GNN4CVBjGjDzHJav6T59lJCOkAxBJ35vgy4OPwpaE1oQWGkdjNNz2VzJb4UZP/QZyNpCqC0ag njO9Lr3WDOsUz1412eit19oNAEKh2cji6VJzhpufiM/ZCkswdanU5eMEXZeIubjAgYZbXWeRh x6JdY1vdoi7Cf2uqNw/iH4YidOtQrE5ynN9nFC+BLpknOWnMiAMT1dcCCCdmabBHoC/5xsyNS dAQFcDnaizCqQ4B8Vba10+RZuTwEhLnQE9gg6h0TuoiSssiRVleR6HicpxAkrPwt45J1S64sN 4YK6afupVt8t/ZRnoitBk9oAv9Qxxp0DMlAI9MM3OdfSvunbw4r8B0COVrcf7ZbfPJMIJUppi MV6i6/aLo9PkIs/Ld2SzgZCny/Kj86BcSmpVWllR9JVY/2xXYbEDf8owjt4c8F3iMQoTd5/U5 Mx2K86W X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: Hi Dmitry > Also, reverting this commit also seems to uncover tests that shouldn't > pass anyway. Checks like > > (should (eq (vc-state default-directory) > (vc-state default-directory backend))) > > don't verify much, and in this case they seem to verify the wrong > thing. More on that in the respective threads in emacs-devel later. > > Michael, thoughts? Why is verifying such tests "the wrong thing"? It's a while ago that I wrote the tests, but IIRC I've added them exactly because I did expect that such tests should pass, and they didn't. I even fixed some trivial corner cases when writing the tests. as far as I understood the code. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 31 20:37:07 2016 Received: (at 20637) by debbugs.gnu.org; 1 Apr 2016 00:37:07 +0000 Received: from localhost ([127.0.0.1]:46604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aln5H-00022x-9c for submit@debbugs.gnu.org; Thu, 31 Mar 2016 20:37:07 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aln5F-00022T-IZ for 20637@debbugs.gnu.org; Thu, 31 Mar 2016 20:37:05 -0400 Received: by mail-wm0-f46.google.com with SMTP id 20so3212227wmh.1 for <20637@debbugs.gnu.org>; Thu, 31 Mar 2016 17:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=jUAbWTA/OJfBTM82k4bbZgXtnhc/kWTOZDZA8ZlrY7g=; b=AOdJKDoiAwSxxkilAn/vD8WtFbXjZHxIjoPpGf9+KEc/46d2TiO6UYqprv8pp8930r K2vnIicZTynWq8OhyYoGurgMrTjgy54vygKq/WEqkiaRfv7oO1sA9bLTbDDQC4OItAea ceztTF6SzOEk582pmJDY4I8wV/MFxaXgiHNMlcRlwjs0LfMGcJ1ewCv/GHHIHckXvJii 8dKCyPRgVvoGPAAE3KDvLxjBRDRyL0819AmHQ3SJI/0TAkqdskbvM+jqsxqXm4Pq0nHp yOJsXsrZd482eAQBcHC61rg78hPALRL+uP+3Yta9QXnqsg16eZ4m+yIR4tLPY+LFZ9ky 8vBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=jUAbWTA/OJfBTM82k4bbZgXtnhc/kWTOZDZA8ZlrY7g=; b=iqLbF9cjjp4dpjks5pe5P7ICgigZ+BX7OYa/yRDFdtzecyqtxyje5vbVH02grosAnU xKjMwJmTQoXanHmtlYeTjo/pz+2Do2wJ1xHJs66ujumzxlSjfTewk4OjM4UIkUCT1LJC uHq42DTAHbfo9GlNrD3X3NM2zebWckgc8th0HxTAnSYI5x4sKDm7TRtRPSlq4xors/b+ proFPyeEh/B52/5DN8so11UZnMqC1mh2kN3ZZ+5uQgVqbGU53DzmPq6MFQbsh0gqx/3G p2x/ENPPGD3+IyIE3pkuajipp5z5WkTvFldab5a/UCbUGkZQjCtEd+iHiVwjs5f7r6UJ lVdg== X-Gm-Message-State: AD7BkJILg79PnAeRRnMXSFb9kgq7hVVJ7899x349lr4QmmkDePFPULZT3hY9o8riKBQi3w== X-Received: by 10.194.8.38 with SMTP id o6mr5978359wja.31.1459471019749; Thu, 31 Mar 2016 17:36:59 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id m13sm11913774wma.3.2016.03.31.17.36.58 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2016 17:36:58 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Fri, 1 Apr 2016 03:36:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87mvphnoei.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 03/29/2016 09:13 PM, Michael Albinus wrote: > Why is verifying such tests "the wrong thing"? It's a while ago that I > wrote the tests, but IIRC I've added them exactly because I did expect > that such tests should pass, and they didn't. It's certainly not very meaningful to test this (it's better to compare to actual values; for all we know, the above method returns `fooled-ya' in both cases). As far as it being wrong: it is, if you consider that some existing implementations don't expect to be called with FILE that's not registered. So different return values in these two cases are to be expected. > I even fixed some trivial > corner cases when writing the tests. as far as I understood the code. Yes, you found some of those cases (but, like mentioned, not all), and that required double-checking that the file is indeed registered. You can argue that the new semantics are more straightforward, and I don't disagree (the docstring of vc-state seems to agree already; vc-working-revision's docstring disagrees). But the cost to that is extra process calls. I'm not sure if the changes in 7f9b037245ddb662ad98685e429a2498ae6b7c62 add any extra process calls, but they do add some interaction with the filesystem. Fixing the newly introduced problem with vc-git-state would require an extra process call, more or less reverting the fix for bug#11757. I don't know how much of a problem that is (I haven't used Windows in a while, and my current laptop is faster that what I had back then anyway), but it would certainly be nice not to introduce a regression in features, or performance. As far as vc-git-state, one way to do that is reimplementing some commands using 'git status --porcelain', introduced in Git 1.7.0. We should double-check if we're allowed to rely on this version being available (which Git does the the oldest relevant version of CentOS install now?), and it might be too late for Emacs 25.1 anyway. Calling vc-responsible-backend is also inherently slower than vc-backend, though not perceptibly so on this localhost (4e-5s vs 4e-6s). But it's likely more painful for remove hosts; how is it, in your experience? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 09 15:34:47 2016 Received: (at 20637) by debbugs.gnu.org; 9 Apr 2016 19:34:47 +0000 Received: from localhost ([127.0.0.1]:56381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoyed-0005uB-9G for submit@debbugs.gnu.org; Sat, 09 Apr 2016 15:34:47 -0400 Received: from mout.gmx.net ([212.227.17.20]:56753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoyeb-0005tz-SC for 20637@debbugs.gnu.org; Sat, 09 Apr 2016 15:34:46 -0400 Received: from detlef.gmx.de ([93.209.77.112]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MaV3V-1b41Sh2gRd-00KARQ; Sat, 09 Apr 2016 21:34:38 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> Date: Sat, 09 Apr 2016 21:34:35 +0200 In-Reply-To: (Dmitry Gutov's message of "Fri, 1 Apr 2016 03:36:57 +0300") Message-ID: <874mbawp84.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:DG8+2/exqFNcO/MtLuMNPX9m+M0v3p3mMA0GfDlHjs67TsKOytT 82Za6m/9gRsHK2q693QFOc5rIMZWzlKb1HaTsAZm5dyYSAIWcGDcHuOvyc9yLqi7VtpeMgP YG9Rgbod2Hs0eAhFU1f94pzwnaz7SIK9gigARDIaRWm91nQ1DDqsKWOFIrHBVvoHxgmXjhC VFdO13cF0uyM0jsQ+pwdg== X-UI-Out-Filterresults: notjunk:1;V01:K0:MEAqyGDBm0U=:04R7c8UKvIR62KZ/JSKDbU rJnOEHeenFZURYhxvt/l5ED4zurzfsSw7gcMgPbHuzauCWGTFM8NmqR5HYaRkpOyeGytzMnmP ZNsbtsV1jHi0DEITORIw1kr53lzhNX4V5wSDpSXtGYRb7pzah8pAJnfLmNYl/SFfamB+wXm+X MSnEmxofUGbqa8pJZ1m+r9kijOF6w+A7SvwCNCiVgdbrLOmX1QImKn79Rp4DZOcdl3c7iQ0ui mbKYloVpohB9yOFAj7tsVw714Duyre9zQQxE4r79mY2JVsQS1o2uehiXw5TldLngX0sbq+Siq ZxeO7Dc0/Nd+GhT5txuazwtzEsZY33F/p1Wi3VjAZfrZx8+aSj7Hpqj4n5ZEGrfGu6r6nx422 wHgHeBZKM5TM6vQWXJRmIq06GVjYQz+Xm9MLaj23BhgcCooTFfMxaU84FNf/JywPe8rsTwpP2 8G/BUnINMhwqeCqWOptlzFYZovM4Z5KsncjGTt0wdYNQbqS3Hd+ZPrkb4WdWZH1vuA/rtIqSA S1HgNGMRBIN1B4knPVmLhKhonPnojbHlv6wfxnBjEzHwJ35qa4ji8CSTMG84czRKXiLUXXh81 /aEhEPL3xlID/0NoEEzlptxkJXjTMYUvkrfoBT+ct5jrL3NbNBYtnOERxJtJjIv0jJ4u/MhXW UBSOZ26zi5HWOKOYskQTteZTonMj23Nv+FnN+oU9tSc72GEhzLEwH8aiC9155k2Q5VfRre/gw rPRA3r1LSdchwvVa73X6MGs/r1cdX+BwrmWhE6RDIZVuVjG4nOjuw+/hp0xZQRl8r3bPAeL1I JvC/tCs X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: Hi Dmitry, you have written several things I would like to move for later discussion. I believe, we shall start again from the basics. I have extended vc-test-*01-register tests by calls to vc-backend and vc-responsible-backend. Mainly in order to understand how they work, but also for covering these functions. One problem I've found is that vc-file-*prop functions do not work well for relative file names; I've fixed this. With this fix, vc-test-src02-state failed. I've masked the test for future investigations; first I would like to make all vc-test-*01-register tests run proper. Several problems I have marked with FIXME in the working horse of those tests, vc-test--register: - For some backends (CVS, RCS and SVN), vc-backend returns the backend name for the newly created repo directory, and the directory is registered already. For the other backends, vc-backend returns nil as expected. Shouldn't this be consistent for all backends? - vc-backend accepts also a list of files, vc-responsible-backend doesn't. Is this right? - There is no common function vc-unregister, just some backend specific vc--unregister. Shouldn't vc-unregister exist? It should call common code, like vc-file-clearprops. For the time being, I have emulated this. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 09 16:43:01 2016 Received: (at 20637) by debbugs.gnu.org; 9 Apr 2016 20:43:01 +0000 Received: from localhost ([127.0.0.1]:56418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aozie-0007W4-SJ for submit@debbugs.gnu.org; Sat, 09 Apr 2016 16:43:01 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aozid-0007Vs-VP for 20637@debbugs.gnu.org; Sat, 09 Apr 2016 16:43:00 -0400 Received: by mail-wm0-f45.google.com with SMTP id u206so59241672wme.1 for <20637@debbugs.gnu.org>; Sat, 09 Apr 2016 13:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=6k15NO3kapr1Wb4P3eD7lCHyK46GH8VKQ8vkEdlMgm8=; b=xQiyWdVv2fNQlnZc7ZW6d5yIj6I6Y0jLHTBxlNM4pDLesZSD+ZaqcxUhAAAHz+30Cg /qyLVSacGjPgC6FWhE3D+CCnYGzY2qwAT4Jem/RGpSKAGBXsWpL/UyZI5OI9iWaPE3wc Z6aVxja0M/FvY2OHlhLBjdgnZbNMZnLMzljGPjc8blCfFhCqzfW/T2/ouRKRMen2n+nm FJOZUbJOJkaAusn+BAlyC6Bmj/EWA6yuxl/h/6qngz8NzGz1ZbVpoO5aCPtSIM0XQ37U 5PGGCEQ/28mH9/+ob9W2dKxjbT305xqlt00ZfdPFQwuzSoVH12+Fq5ACUXvQnszlPHhU B43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=6k15NO3kapr1Wb4P3eD7lCHyK46GH8VKQ8vkEdlMgm8=; b=fmlw4UE+JKhFixPpryBVpE8t21D0xVpqaxMzAfW7A019h4xT6sP12xXY8qTBW1mmt8 Q2d4nFy027W+QNjAaaj/ZsMHQMAemWXVE2zWI3fHYeuph2JIle4WFnWkpnaQQ7iBQs4P hMCQy6otN0H5C5oRr2wK9ni+OQcCO9GdRdKXvr2yCyimg5jaipxJDI6zNd7A5XD9ynNj wb0mY145TZAZ+LIP18fxxWj+crWa3/0BbohLPfJu1ALQFXTxd7EuUL/TnUyPly/ovc8M e9IOBGA4J15qWlO264jehE+wsdRwlWWLNwRvGHYxRVA66+G6zmdA0JksIz8RwuUuCYLA q/vQ== X-Gm-Message-State: AD7BkJIoKYt/rODJELr14ikOo5SzB05QSgaM6F3ytIsOwcUFPp5y+fDaCqDHVH4Gn9ycpw== X-Received: by 10.28.135.204 with SMTP id j195mr9890285wmd.65.1460234574316; Sat, 09 Apr 2016 13:42:54 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id e190sm9251979wma.15.2016.04.09.13.42.52 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 09 Apr 2016 13:42:53 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Sat, 9 Apr 2016 23:42:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <874mbawp84.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Michael, On 04/09/2016 10:34 PM, Michael Albinus wrote: > you have written several things I would like to move for later > discussion. I believe, we shall start again from the basics. OK, but the questions seem tangential to this bug report, which is a blocker for 25.1 (whereas investigating how various commands should work, isn't). > I have extended vc-test-*01-register tests by calls to vc-backend and > vc-responsible-backend. Mainly in order to understand how they work, but > also for covering these functions. One problem I've found is that > vc-file-*prop functions do not work well for relative file names; I've > fixed this. The change looks good, but nevertheless seeing the commit 5e1c32e in master makes me worried about conflicts when merging the necessary future fix for this bug from emacs-25 to master. > Several problems I have marked with FIXME in the working horse of those > tests, vc-test--register: > > - For some backends (CVS, RCS and SVN), vc-backend returns the backend > name for the newly created repo directory, and the directory is > registered already. For the other backends, vc-backend returns nil as > expected. Shouldn't this be consistent for all backends? I'm not quite clear on what you are saying here. If you're calling vc-backend on a directory, I believe the result is undefined. As in, the function is allowed to return any value. Maybe we could check file-directory-p in vc-backend, and signal an error if it is. For directories, one has to call vc-responsible-backend. > - vc-backend accepts also a list of files, vc-responsible-backend > doesn't. Is this right? I suppose. The function signatures say so. But I don't see any callers of vc-backend that actually pass a list to it. > - There is no common function vc-unregister, just some backend specific > vc--unregister. Those are the implementations of the `unregister' backend command. It's only used in vc-transfer-file currently. > Shouldn't vc-unregister exist? Maybe it should. Would you ever use it interactively? > It should call > common code, like vc-file-clearprops. For the time being, I have > emulated this. Are you doing that just to test the `unregister' implementations? Because otherwise, to clean up after a test, you can simply delete the directory with the test repository. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 04:00:27 2016 Received: (at 20637) by debbugs.gnu.org; 10 Apr 2016 08:00:27 +0000 Received: from localhost ([127.0.0.1]:56536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apAIE-0000I1-Vc for submit@debbugs.gnu.org; Sun, 10 Apr 2016 04:00:27 -0400 Received: from mout.gmx.net ([212.227.17.20]:59876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apAID-0000Hp-PN for 20637@debbugs.gnu.org; Sun, 10 Apr 2016 04:00:26 -0400 Received: from detlef.gmx.de ([87.146.53.247]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LgI0W-1bcr7X23Vs-00nfpB; Sun, 10 Apr 2016 10:00:19 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> Date: Sun, 10 Apr 2016 10:00:17 +0200 In-Reply-To: (Dmitry Gutov's message of "Sat, 9 Apr 2016 23:42:50 +0300") Message-ID: <878u0llwq6.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:/fYOp/YuKx8s6bmohfs6/V5S0PWh/bN0L1pG0Tj5tZpevcOerLE XeXH/3iV86KwRMNO9Z5Pjz03lYBg3VmYHoft7F+Z31G6Nizk4nntQRQCrCaUt3NshPeAxFk Y4PeJF93YZP8vj2Tw5uuiVb1FqJ751Oia+CB7X5qjCwh3ZDtsU7jKkfIoQWuPqf4Nx7O+Uc vw3rSVC4xoAv3LPe0BRsw== X-UI-Out-Filterresults: notjunk:1;V01:K0:M/6lLay+CYc=:2SvIPE6LsSy39pOmH56USg b1POfkCxgy4h+qvfG9Av4hMf8petWRV4i9eNXPfgM/isxX+fhP/21jP/5CO31kcjaRyq1q3+2 hW9e/nEcusMfr9bXV5rX5ENHfGBLpYlK44rLmnz3sbDQrKVUnNrPeZRoPYfiJ7hMOGa43KE68 3Ck/ynlIdEFlNgpHGPrk9okso4fW1YACvbne3pKkKJo7XkECtyeC2rXRBozh4LxF6p0qo9d6x pRKJ+qCDTm3T0WaNebziekuN/4OscIMRAe8g4x9gJpi7dCIhaPHMCvlFWFfjYpZKjQ39ot/Sd DDsRZ6gpzEB3Y/W1sd04TRUnj6Dwl9F3eON14TBJZzSAzF7m/U57E6/XqD94JPT+RwXByTWRF AzdmGftV3BSKuDAww5UC2Kfc/bybWbafUZx2sU/amp0R1lMaZuZA13KvjjYgyt+qBvYPCpMMw Gg5L6OEliCDZaiCJjiYESaOH60e29eGuZNeUjPigMSObr6YjIEriMG2JR6I44IBIB2sH/Iptd g7l9+c1AfBNgWfnfrbbTUMnYQBZ/UxIUpu2HZcR773uObHW9mr3GuHztPmlSp6aBzUrVYAbk6 /+iBrLhBwvgNuM+rZvNuDsExvBo9SdRYlaTthr7S/0thRl5i8y51uMIvKybUeylRX9b4feMik mykFAR5GrjWQENMkrwmAsIxs2VBGjIDbUXzPTk+6iHe3VfbbWytDxvJXvpiNEvRdikVslbn/M bvJBz3yOY7fSJyD/pyoLmS3oTbbzJ8lbDGqGC+cqcvdShAL7m30cGCMrXOyj33Y4cfa0VW/dd 8TMM29G X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > Hi Michael, Hi Dmitry, >> you have written several things I would like to move for later >> discussion. I believe, we shall start again from the basics. > > OK, but the questions seem tangential to this bug report, which is a > blocker for 25.1 (whereas investigating how various commands should > work, isn't). If there is a simple and obvious fix for this problem, let apply it to the emacs-25 branch. Even if we must change it later in master. But I doubt that's possible. This bug report was written on 23 May 2015, it was marked as release blocker on the same day, and still no fix. I believe that there won't be a fix in emacs-25, and whatever we might find on our way to stabilize vc, it will be too late and too much to be applied to the emacs-25 branch. For all those problems in vc I have the impression, that we must stabilize vc first. Starting with the very basic functionality - that's why I've added tests for vc-backend and vc-responsible-backend. Often, there might be not an error, but missing or wrong documentation. As Glenn has said also in bug#19548, another release blocker for 25.1. I don't care whether we discuss it here, in bug#19548 or in the emacs-devel ML. But at least *I* am not able to handle those issues differently. And nobody but you and me seem to work on vc problems in general. >> I have extended vc-test-*01-register tests by calls to vc-backend and >> vc-responsible-backend. Mainly in order to understand how they work, but >> also for covering these functions. One problem I've found is that >> vc-file-*prop functions do not work well for relative file names; I've >> fixed this. > > The change looks good, but nevertheless seeing the commit 5e1c32e in > master makes me worried about conflicts when merging the necessary > future fix for this bug from emacs-25 to master. As said, I doubt that we will find something which could go into emacs-25. Of course I would be happy if I'm wrong :-) >> Several problems I have marked with FIXME in the working horse of those >> tests, vc-test--register: >> >> - For some backends (CVS, RCS and SVN), vc-backend returns the backend >> name for the newly created repo directory, and the directory is >> registered already. For the other backends, vc-backend returns nil as >> expected. Shouldn't this be consistent for all backends? > > I'm not quite clear on what you are saying here. If you're calling > vc-backend on a directory, I believe the result is undefined. As in, > the function is allowed to return any value. Maybe we could check > file-directory-p in vc-backend, and signal an error if it is. The docstring says nothing about directories, so the call I've applied is legal. If vc-backend is not intended for directories we should document it first. But ... > For directories, one has to call vc-responsible-backend. ... I even doubt that directories are out of scope of vc-backend. Directories can be registered for some VCS, for example for CVS, or for ClearCase which I use at work (I know, we have no official support for ClearCase in vc). Therefore we shall precise the docstring of vc-backend, that it returns the backend also for directories for VCSes which support rgistration of directories. A pointer to vc-responsible-backend might also be helpful in the docstring of vc-backend. >> - vc-backend accepts also a list of files, vc-responsible-backend >> doesn't. Is this right? > > I suppose. The function signatures say so. But I don't see any callers > of vc-backend that actually pass a list to it. I know what the docstring says :-) My question is, whether we shall offer the same argument list for both vc-backend and vc-responsible-backend. >> - There is no common function vc-unregister, just some backend specific >> vc--unregister. > > Those are the implementations of the `unregister' backend > command. It's only used in vc-transfer-file currently. > >> Shouldn't vc-unregister exist? > > Maybe it should. Would you ever use it interactively? Don't know. But I believe "interactively" is not the criterion whether a general vc function shall exist. I also don't call vc-registered interactively. >> It should call >> common code, like vc-file-clearprops. For the time being, I have >> emulated this. > > Are you doing that just to test the `unregister' implementations? Yes. And I'm still in favor of adding vc-unregister in vc.el. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 12:00:51 2016 Received: (at 20637) by debbugs.gnu.org; 10 Apr 2016 16:00:51 +0000 Received: from localhost ([127.0.0.1]:57387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apHn9-00050X-2z for submit@debbugs.gnu.org; Sun, 10 Apr 2016 12:00:51 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:32779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apHn7-00050K-Gx for 20637@debbugs.gnu.org; Sun, 10 Apr 2016 12:00:49 -0400 Received: by mail-wm0-f50.google.com with SMTP id f198so116854686wme.0 for <20637@debbugs.gnu.org>; Sun, 10 Apr 2016 09:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=LBFymFhCEuYLfvUmbE58gDshotQWf8fkOhTcNM9i52k=; b=hkjCAHsHzBG0lHW32IShGLp9DgT42oUEaSKwSHZqfpc68hSL386fwb8hnFbgccI+y4 saQ9uvvQF0DPeD7oL9JLapMhgj78KMP6IBa27yGgY2TczLVssMjWo0vtmAi/O9bvcATu t/B++R+B2PzjpzzxyWbmhCRxRvGlkS7KmRQNmQzoZWHE4j0Zl0rLMVqSWmXJnwiuZ8MU fu/v6xBHpDGP7EsepJNWgvMQ3ljQ3UdwyARWhDhcULnAlWwHp+4bjOUG6vjDVgurs1BA 6cjpYD0YKZwKGYw8j9ndkvCW2KUDMSfBpJ8s2JaOejByJdt2XIv93Qt0eWo6JOcy96Zu t4lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=LBFymFhCEuYLfvUmbE58gDshotQWf8fkOhTcNM9i52k=; b=THv93o05WqnoFhqsFyz/zHAX2e97GskM3ABsHSDlGpqcGVGhkbw79IVLHbhCfh17rH /PHFeliDiYq/zI4s0pN7DXIA/WPnMxeog8xi4Vwm8/0mC+g28ePx8T12PSFADSKKzVKB 90HA3htROETCdNU8ASirnlmy7c4k+zxFWN7cOw3pz/tZGZ3rgEfQm1wieN/z0H5RUGCJ SACz3qQsveMOZzhh+juV6obEVC9/R+T0knXohjUUGyZbg43cEuXrbb3RC+/rKBYAHpGk E0N06fj44z2KRSMykMSM9MmsLehzvd/jQ7ecy4f0SAHBM5bSxIOFy4NYGEqX/shm5D2P L1yg== X-Gm-Message-State: AD7BkJIUb3a/j/qcTeHR+9MV7UmftuHlgz9+aEQcTwHSTQptTr99X704/4bx8yuNCk/wgg== X-Received: by 10.194.172.99 with SMTP id bb3mr19842499wjc.46.1460304043786; Sun, 10 Apr 2016 09:00:43 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id a184sm12995752wma.3.2016.04.10.09.00.42 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 10 Apr 2016 09:00:42 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> From: Dmitry Gutov Message-ID: <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> Date: Sun, 10 Apr 2016 19:00:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <878u0llwq6.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/10/2016 11:00 AM, Michael Albinus wrote: > If there is a simple and obvious fix for this problem, let apply it to > the emacs-25 branch. Even if we must change it later in master. Why not revert 7f9b037245ddb662ad98685e429a2498ae6b7c62? I believe I've mentioned that suggestion before. The only difficulty here, as far as I'm concerned, is to update the corresponding tests so they don't break, but are not disabled, and still look somewhat reasonable. That's where the merge conflict concerns come into play. But "no disabled tests" is not a hard requirement for release anyway. > But I doubt that's possible. This bug report was written on 23 May 2015, > it was marked as release blocker on the same day, and still no fix. Not because it's too difficult to resolve. > For all those problems in vc I have the impression, that we must > stabilize vc first. Starting with the very basic functionality - that's > why I've added tests for vc-backend and vc-responsible-backend. I agree with the sentiment, but not with certain choices of the areas to "stabilize" it in. You've basically been discovering aspects of the current commands and functions that are poorly specified. But those aspects (with some exceptions, I suppose) are not regressions from Emacs 24. They have been there for a while. > I don't care whether we discuss it here, in bug#19548 or in the > emacs-devel ML. I don't mind too much any way, but 19548 is for the manual and such. A separate bug report (or several) or discussions on emacs-devel seem preferable. Unless I'm mistaken about these problems being orthogonal, of course. > The docstring says nothing about directories, so the call I've applied > is legal. Best wishes to whoever wrote that docstring. > ... I even doubt that directories are out of scope of vc-backend. > Directories can be registered for some VCS, for example for CVS, or for > ClearCase which I use at work (I know, we have no official support for > ClearCase in vc). In general, VC supports the lowest common denominator across the backends. Or at least, a feature should be supported in a few important ones. CVS is on its way out, and ClearCase is a relatively niche tool. Anyway, the point is VC is for people to be able to write code depending on the public API and see it work across many VCSes. And Git and Mercurial, at least, don't track directories. > Therefore we shall precise the docstring of > vc-backend, that it returns the backend also for directories for VCSes > which support rgistration of directories. Why? Just tell anyone who wants to know a directory's backend to use vc-responsible-backend instead. > I know what the docstring says :-) My question is, whether we shall > offer the same argument list for both vc-backend and vc-responsible-backend. We could, but honestly, that question doesn't sound particularly important right now. Yes, it's a wart, and if there are no users that pass a list to it, we can remove this possibility. Note that vc-backend and vc-responsible-backend have different performance characteristics (and, I imagine, different behavior in case of nested repositories), so simply replacing all uses of the former with the latter is not a good idea. > Don't know. But I believe "interactively" is not the criterion whether a > general vc function shall exist. I also don't call vc-registered interactively. Interactive use would be a strong justification. vc-register can be used interactively, and it's called from vc-next-action. How will we use vc-unregister? >>> It should call >>> common code, like vc-file-clearprops. For the time being, I have >>> emulated this. >> >> Are you doing that just to test the `unregister' implementations? > > Yes. That seems very low priority. I wonder how often vc-transfer-file gets used in practice these days. > And I'm still in favor of adding vc-unregister in vc.el. I don't really mind. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 14:10:02 2016 Received: (at 20637) by debbugs.gnu.org; 10 Apr 2016 18:10:02 +0000 Received: from localhost ([127.0.0.1]:57485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apJo9-00088x-U0 for submit@debbugs.gnu.org; Sun, 10 Apr 2016 14:10:02 -0400 Received: from mout.gmx.net ([212.227.17.20]:62170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apJo7-00088O-GE for 20637@debbugs.gnu.org; Sun, 10 Apr 2016 14:10:00 -0400 Received: from detlef.gmx.de ([87.146.53.247]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M4TgW-1bjKfc0L2C-00yiNt; Sun, 10 Apr 2016 20:09:52 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> Date: Sun, 10 Apr 2016 20:09:49 +0200 In-Reply-To: <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> (Dmitry Gutov's message of "Sun, 10 Apr 2016 19:00:41 +0300") Message-ID: <87potxwd1u.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:fe2BvjPbDgHB+YuhsE3uVJAesV8Zh/FtoH+p/RGXWGPy6exoTze JwIA1rmK+naX4zyO/4zbvz13pcDFHsrTuiYCAPEFNqh4UPkAvwodjAe+7PCkBTdPFFnufAw nDXLfhTD/dwUiOpnx4+LAUsp4/fqaRgmktixzZvDnybuzE5oNhZXWcz6EMkIP3++RulcVxW RTY82UHkZvR7jyas+v1fg== X-UI-Out-Filterresults: notjunk:1;V01:K0:UCdmfRjomRU=:qlkkSoAUyyGW3Re0k/kJp3 KTtf1RfzV9VVsFUbTmeiDCtYkK2ExQ4YCOrRMXokMXBMLs9xKX+z4MliYSeZFcxQplgBFJEcD y0Pb/EbCrBVBnJouRicdmck94mjAIOMP4i/Si/mIkQwcyNTst2jjkBeJNNvUa3Gdn/FJEJHw3 n/AMGIBdfGxoS0UlKiNPT4AA9H5tX56XKk6Xp92rIw9fNo/rWEAHI3YZ3/YGjuzDz7ociYT4N MDZMJ0ZzvJO/p26h1MuiC1QGm9UR9Gjp/r6oomPLuRtrBKL2vU9WVLM11U6Lnqf2HJPF9sVLg XGZFOE0uRYew8C1PCEsG+N1tdnjULJpyq3m/KHU/7mAYPbjUEsjhkQ6uUFNrCPtNu3nbmWGH7 nhlj723W+IdrMAj0RqpVh/iZpPQLToc21cIEnE1CYfKXnjx2af2s7KW5pBtgohqcKU2zvtOxx ikhPSzsJGbNK6gb6ft8CW2FhMq/hKDysBUrd7V7yVNl6nk/cIk7qNNsn4xI5QXsKzud7CjZgQ lbmY+QzQfCm6ahqoVd+gSaI/NSIzQuUHtdGTvgAjQB8kSDrWl323vFXxTrolcL1jrOsdtmsHL feYVnG7+s00ViE/KegEaJsEC6ZNaXAR9g++C361awx5c1A/cYH0pOR13yIhtiuc0jU+v5LwRH Y7WEpLq1K5XrkX1hx5B5lLhi3tkhypTZuaQhhkc8nct/HvyD2jJZxPB76490g1PYExV73t3I0 fmekaRs57FSf6dVI/zwY5fDYy/uBJfDfBfNqU5oKh6Ckq+h4KaXyyRZiGkMRfDs5Ne7dA4b47 7SOgDI8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > On 04/10/2016 11:00 AM, Michael Albinus wrote: > >> If there is a simple and obvious fix for this problem, let apply it to >> the emacs-25 branch. Even if we must change it later in master. > > Why not revert 7f9b037245ddb662ad98685e429a2498ae6b7c62? I believe > I've mentioned that suggestion before. Why that? That patch fixes problems. How would you solve them otherwise? And what problem has been introduced with that patch? This one we are speaking about, bug#20637? Maybe you have mentioned this already, and I've overseen this. > The only difficulty here, as far as I'm concerned, is to update the > corresponding tests so they don't break, but are not disabled, and > still look somewhat reasonable. That's where the merge conflict > concerns come into play. But "no disabled tests" is not a hard > requirement for release anyway. Could you show a patch which reverts 7f9b037245ddb662ad98685e429a2498ae6b7c62, and also updates the tests? Maybe it is simpler to speak about this concrete proposal. >> But I doubt that's possible. This bug report was written on 23 May 2015, >> it was marked as release blocker on the same day, and still no fix. > > Not because it's too difficult to resolve. But nobody has taken any action for more than 10 months :-( >> For all those problems in vc I have the impression, that we must >> stabilize vc first. Starting with the very basic functionality - that's >> why I've added tests for vc-backend and vc-responsible-backend. > > I agree with the sentiment, but not with certain choices of the areas > to "stabilize" it in. You've basically been discovering aspects of the > current commands and functions that are poorly specified. But those > aspects (with some exceptions, I suppose) are not regressions from > Emacs 24. They have been there for a while. Oh, there are regressions. ESR has undertaken his rewrite of vc*.el end of 2014. Emacs 25.1 is the first release which brings them to the public. See also vc.el, and compare the functions listed in the Commentary section between Emacs 24.5 and 25.1. Read also "Changes from the pre-25.1 API" at the same place in the 25.1 version of vc.el. Unfortunately, etc/NEWS of Emacs 25.1 is very silent about those changes. >> I don't care whether we discuss it here, in bug#19548 or in the >> emacs-devel ML. > > I don't mind too much any way, but 19548 is for the manual and such. A > separate bug report (or several) or discussions on emacs-devel seem > preferable. Unless I'm mistaken about these problems being orthogonal, > of course. I might be wrong, but Glenn didn't write this bug only because of some missing docs. I believe he was unhappy about the whole process, how those changes did arrive. But I'm not Glenn, and I shouldn't interpret too much ... >> ... I even doubt that directories are out of scope of vc-backend. >> Directories can be registered for some VCS, for example for CVS, or for >> ClearCase which I use at work (I know, we have no official support for >> ClearCase in vc). > > In general, VC supports the lowest common denominator across the > backends. Or at least, a feature should be supported in a few > important ones. CVS is on its way out, and ClearCase is a relatively > niche tool. You have read my comment in vc-tests.el? At least CVS, RCS and SVN seem to behave this way. So it is reasonable to handle the case, that directories are registered. > Anyway, the point is VC is for people to be able to write code > depending on the public API and see it work across many VCSes. And Git > and Mercurial, at least, don't track directories. So what? We could say in the doc that registering directories is not supported for all backends. People who write a backend know what they do. I hope. >> Therefore we shall precise the docstring of >> vc-backend, that it returns the backend also for directories for VCSes >> which support rgistration of directories. > > Why? Just tell anyone who wants to know a directory's backend to use > vc-responsible-backend instead. I have no problem to recommend vc-responsible-backend. But vc-backend does already TRT: when a directory is registered, it returns the backend name. When a directory is not registered, it returns nil. This is *not* a statement why a directory is not registered, and whether registering directories is possible at all for a backend. >> I know what the docstring says :-) My question is, whether we shall >> offer the same argument list for both vc-backend and vc-responsible-backend. > > We could, but honestly, that question doesn't sound particularly > important right now. Yes, it's a wart, and if there are no users that > pass a list to it, we can remove this possibility. > > Note that vc-backend and vc-responsible-backend have different > performance characteristics (and, I imagine, different behavior in > case of nested repositories), so simply replacing all uses of the > former with the latter is not a good idea. I haven't proposed this! I simply want to understand (and document) what both functions are doing. Which of them is taken by a backend is the decision of the maintainer of the backend. I'm pretty much in favor to also document the differences in performance. >> Don't know. But I believe "interactively" is not the criterion whether a >> general vc function shall exist. I also don't call vc-registered >> interactively. > > Interactive use would be a strong justification. vc-register can be > used interactively, and it's called from vc-next-action. I haven't spoken about vc-register. I have spoken about vc-registered. This one exist as general function, and it isn't interactive. > How will we use vc-unregister? Every backend can use it instead of its backend specific function, like vc-git-unregister. It runs common code then like removing properties, and calls the backend specific function then. >>>> It should call >>>> common code, like vc-file-clearprops. For the time being, I have >>>> emulated this. >>> >>> Are you doing that just to test the `unregister' implementations? >> >> Yes. > > That seems very low priority. I wonder how often vc-transfer-file gets > used in practice these days. I understand that's low priority for you, and I accept this. For me, while extending vc-tests.el, it isn't low priority. I need solid ground under my feed, and therefore I'm starting with the very basic functions. Understanding, testing, maybe fixing bugs, maybe improving documentation. Function by function. >> And I'm still in favor of adding vc-unregister in vc.el. > > I don't really mind. So I will do, unless somebody stops me :-) Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 14:58:14 2016 Received: (at 20637) by debbugs.gnu.org; 10 Apr 2016 18:58:14 +0000 Received: from localhost ([127.0.0.1]:57521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apKYo-0000qe-Gs for submit@debbugs.gnu.org; Sun, 10 Apr 2016 14:58:14 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apKYm-0000qP-OA for 20637@debbugs.gnu.org; Sun, 10 Apr 2016 14:58:13 -0400 Received: by mail-wm0-f46.google.com with SMTP id n3so78797494wmn.0 for <20637@debbugs.gnu.org>; Sun, 10 Apr 2016 11:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=YFOVxd1OlsJy/1Hq0XMcQ/SRPbOQE8XeGMX0oH2e2Ow=; b=PqDdZNrB5yfl8fzLeqtJTnm4aHHqjpepzTf2hJMnliEhun6FbL+kAUwUfy4RWlac7N pppVzzSLrTzDLyCu440er3zX7J7CDsfeBoqnhu0gvn/xfXedw/DwmK3Ny0z1dQ2gzvG5 Hmsd2QOk/GQr9LArZwk/DGaQdM/aXXXG0/YX6EHBX231i3QAs4yhmPE0qG5T8ebmiNnk O6bvWknBh+z3hzrer/yx5OyWQkXAw48ghjTPWUmp8Udb+npPZk5RHsfF4Sa1H0mWW0zf 2pAL4AqrtpMIKWEU5pILnRAf06AGsvqdcaFMmbSQCBm1XBFcJmt8X3f+0k9eX3LCnZYA dy5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=YFOVxd1OlsJy/1Hq0XMcQ/SRPbOQE8XeGMX0oH2e2Ow=; b=E6hSXOdZLaHWxckdZJC4MksI6giHvqajeAuZyutb6uqn/VloqRJdpZEGwp/QhjuSKg kw/YsIMFB7FosdGvF93XmJJf0ZXF5SBXBwqkcIGahtb+olz7ry1bQhZpSjyTibDyaCKJ ZQ0i6IjNOTzadWufMwgV+PVd/L0IKBouKANmKtqMMmuu5e+AVibqx1PzAOTxYyznwYpv l4rT5GBZF7UFyrj7NaUBjeYwYhNFLJDcqfO3lfg5n0Cu6lHcdrQ8Xv7Q0TLOfeH1qx1b UtJyCqKY2nu0PpQ7Zo7TBsYuvdfODrT6Urcqh1pyd3WMLtOR1Wp2qj/izpyaoN5uGzdp iCqg== X-Gm-Message-State: AD7BkJIXRtrQlRcQ3ar9dHgbHOHy5bFPjqtC+9oIeVBfChz/Nrldhl7CEM3HfLEkU3Jh3A== X-Received: by 10.28.145.196 with SMTP id t187mr13975317wmd.81.1460314686997; Sun, 10 Apr 2016 11:58:06 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id a73sm13552700wme.2.2016.04.10.11.58.04 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 10 Apr 2016 11:58:06 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Sun, 10 Apr 2016 21:58:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87potxwd1u.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/10/2016 09:09 PM, Michael Albinus wrote: >> Why not revert 7f9b037245ddb662ad98685e429a2498ae6b7c62? I believe >> I've mentioned that suggestion before. > > Why that? That patch fixes problems. How would you solve them otherwise? It just fixed the tests you've introduced a little while before that. I'm not aware of any related bug reports. The new tests assumed new semantics, so you fixed them by changing semantics, thereby causing the "incompatible, undocumented change". > And what problem has been introduced with that patch? This one we are > speaking about, bug#20637? Yes. > Maybe you have mentioned this already, and > I've overseen this. I wrote about that in the very first message to this thread: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20637#10 > Could you show a patch which reverts > 7f9b037245ddb662ad98685e429a2498ae6b7c62, and also updates the tests? > Maybe it is simpler to speak about this concrete proposal. Unless you have a different proposal, I'll write and simply commit that patch. >>> But I doubt that's possible. This bug report was written on 23 May 2015, >>> it was marked as release blocker on the same day, and still no fix. >> >> Not because it's too difficult to resolve. > > But nobody has taken any action for more than 10 months :-( I would expect that to be the responsibility of the person who caused the breakage. > Oh, there are regressions. ESR has undertaken his rewrite of vc*.el end > of 2014. Emacs 25.1 is the first release which brings them to the > public. There are regressions, but the questions you've been asking don't seem to number among them. > Unfortunately, etc/NEWS of Emacs 25.1 is very silent about those > changes. That's bug bug#19548. Could we keep that discussion out of this one? > I might be wrong, but Glenn didn't write this bug only because of some > missing docs. I believe he was unhappy about the whole process, how > those changes did arrive. But I'm not Glenn, and I shouldn't interpret > too much ... This bug is about vc-working-revision. It's in the title. >> In general, VC supports the lowest common denominator across the >> backends. Or at least, a feature should be supported in a few >> important ones. CVS is on its way out, and ClearCase is a relatively >> niche tool. > > You have read my comment in vc-tests.el? Which comment are you referring to? > At least CVS, RCS and SVN seem > to behave this way. You've mentioned that in the previous message. Out of these three, only SVN is in any way recommended for production use these days. In any case, they're aging and only decreasing in popularity. > So it is reasonable to handle the case, that > directories are registered. I do not understand this argument. >> Anyway, the point is VC is for people to be able to write code >> depending on the public API and see it work across many VCSes. And Git >> and Mercurial, at least, don't track directories. > > So what? "So what" doesn't seem like a meaningful response to the first sentence above. > We could say in the doc that registering directories is not > supported for all backends. People who write a backend know what they > do. I hope. We could say a lot of things. We could even say that every backend behaves in its own special way (and enumerate all those ways), but where will that get us? Again, what's the benefit of introducing this complication? > But vc-backend > does already TRT: when a directory is registered, it returns the backend > name. When a directory is not registered, it returns nil. It just does the thing that's more convenient for each backend. That doesn't make it TRT. > This is *not* > a statement why a directory is not registered, and whether registering > directories is possible at all for a backend. Indeed, and that's a problem: if the caller receives nil, it cannot know whether that's because the directory is not a part of a VCS checkout, or because the backend does not support tracking directories. This is a reason not to support calling vc-backend on directories: it leads to unportable code. >> Note that vc-backend and vc-responsible-backend have different >> performance characteristics (and, I imagine, different behavior in >> case of nested repositories), so simply replacing all uses of the >> former with the latter is not a good idea. > > I haven't proposed this! Good. I've just made a guess on why you've asked the question, and 7f9b037245ddb662ad98685e429a2498ae6b7c62 hinted at that conclusion. > I simply want to understand (and document) what > both functions are doing. OK. It's not like I'm a big hoard of knowledge about them. To answer the questions, I've just looked at their definitions and usages. > Which of them is taken by a backend is the > decision of the maintainer of the backend. I don't understand this. What kind of decisions would backend maintainers make about them? > I'm pretty much in favor to also document the differences in performance. OK. > I haven't spoken about vc-register. I have spoken about > vc-registered. This one exist as general function, and it isn't interactive. I see. But vc-registered is a relatively meaty function, and it has two callers outside of tests. That looks better justified to me. >> How will we use vc-unregister? > > Every backend can use it instead of its backend specific function, like > vc-git-unregister. It runs common code then like removing properties, > and calls the backend specific function then. vc-git-unregister has no internal callers. Anyway, please go ahead with `vc-unregister' is you feel so strongly about it. > I understand that's low priority for you, and I accept this. For me, > while extending vc-tests.el, it isn't low priority. I need solid ground > under my feed, and therefore I'm starting with the very basic > functions. My point was, the `unregister' command is a fringe one, not a basic one. > Understanding, testing, maybe fixing bugs, maybe improving > documentation. Function by function. Sure. But I think we should fix the current bug first. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 11 02:55:47 2016 Received: (at 20637) by debbugs.gnu.org; 11 Apr 2016 06:55:47 +0000 Received: from localhost ([127.0.0.1]:57930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apVlD-0001XQ-Lk for submit@debbugs.gnu.org; Mon, 11 Apr 2016 02:55:47 -0400 Received: from mout.gmx.net ([212.227.17.20]:58684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apVlC-0001XE-9z for 20637@debbugs.gnu.org; Mon, 11 Apr 2016 02:55:46 -0400 Received: from detlef.gmx.de ([87.146.60.13]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MH5Sw-1b2D4D1uUM-00DmiI; Mon, 11 Apr 2016 08:55:39 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> Date: Mon, 11 Apr 2016 08:55:38 +0200 In-Reply-To: (Dmitry Gutov's message of "Sun, 10 Apr 2016 21:58:02 +0300") Message-ID: <87egacws5x.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:Gb2im/F+CdGrQxzZW4Oaqvi4YxLbW+oXbQy4dsXVgxODqazPNxr 1K3jadSkAlDN6oo50nl34fs11bSAplsXUI6nvZK8Ytik5BvVDh/hG2X5fmG5SYuGQKwOikj 7c0gRSTBShOQVrDvafuvRmTR6pjRXF//KFX9z816SKCTzG7kxm5IFdL6Lro5eCD9nb4X0FO u6KcT3DT8w9nmCC/qVc3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:6vRBNN2OxpE=:3/WwvOX1SbvA2yxgoArhqz fhbNISCmkqnbIshogxT/WQKbj49x3Ds3jO2eh102wt/WptVcpkZMbQ5fMY2X88saZnWAr4wuI oWF3wSf5KDO81Gl5qdLhoIYXHKtzqWfMVpi0u4zKzLvOQhvRMD3DEwqVz3itJaRnPR6NXPCwr K9qKrn9AC/i7Xf05e/A3yxk4D/AZQ2HTbmfQToqDJNFPY0EGkRt+/qd3412xSuyYThvRBxUhx q9MPNL0tHbGprQvsi0g5Iq16jaWKl3gheX0CC/6lXh36dpgXqdAOUM9iy3c2RjrDx2YjvS6eH qzBu48E/JFbpdIcy9WQa9F5szs3xZl72oBpanjaQNwS6LwbNzAHHX7nbg9ijcaveXKs6ML/Go C8zsa4Txl7js1cxwPSLlMpLxjaK7iH0cWa1K8qWoUPFTA3j0EFLZhsnGsJYlrcnMKaEX2gd0v HegtAK7ujrpVaatIxvVNbzd/oPQcdJ7qEd6qz9tKugc84i7Hu/V9g4HOtuACvlQXL99ooP22m mMEvtWARi5hE5t+Wsl/QXx48LGUfxCWQjckTpS2Wu053i3qz/PmvkyvZJ0frXIhQHsDGCqhMU PytSMOyPjVs80+LZ9qQCvVZsA5m+NAkNM33I4ji0ZNKtEq7wu7WAPPFJuBlPZVdhB7qSjcgd7 jSUTIK+YnUZxSxu4KR/Fvq0js/pOTkyLfCSYq7vSaK+CH7UrX1y64vE/nT1TDHMKsrByU79F7 GW2bFEsarp/nZBMkJP+59oupjsUrjGxOXz/cke+6DnAl7iv725eFRnniSCBitrtwmHEoww7wz C60YWlp X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: Hi Dmitry, >> But nobody has taken any action for more than 10 months :-( > > I would expect that to be the responsibility of the person who caused > the breakage. Of course! Until now I even didn't realize this was broken by my patch. Sorry, but I have been in hospital last year, and when I recovered there were too many messages to scan. I'll check what could be done. I'll return later. Best regards, Michael. PS: the discussion about my other changes in vc-tests.el shall be moved to the emacs-devel ML. Let's restart it there, when this problem is solved. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 13 11:14:32 2016 Received: (at 20637) by debbugs.gnu.org; 13 Apr 2016 15:14:32 +0000 Received: from localhost ([127.0.0.1]:33832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqMUx-0003yW-SA for submit@debbugs.gnu.org; Wed, 13 Apr 2016 11:14:32 -0400 Received: from mout.gmx.net ([212.227.15.19]:55879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqMUv-0003yG-7X for 20637@debbugs.gnu.org; Wed, 13 Apr 2016 11:14:30 -0400 Received: from detlef.gmx.de ([87.146.56.228]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MC4VE-1az7wD1FSa-008qbF; Wed, 13 Apr 2016 17:14:21 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> Date: Wed, 13 Apr 2016 17:14:19 +0200 In-Reply-To: <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> (Dmitry Gutov's message of "Tue, 29 Mar 2016 02:28:22 +0300") Message-ID: <87oa9dzgl0.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:6MsITz5fvEVp3sl7N/DPB58SEg1E/nDbfjT19V/NQpXUfGK7mVH Oo32X7uqDzyI33gIGaNwmv9jnbtcIDQe6yUavImQ4DsCK++0SNaesSlJzAJrDTFA+xYIG5m D6irjRbUKomeF0CJKb8SQ601KJw9ztEkF/Yfizxa7v4QsLVFyFg4Q4oURFjNZD4Ue1xozJT mkazVzwn3xYEhq3AIa9lg== X-UI-Out-Filterresults: notjunk:1;V01:K0:czWP7Q8vm6k=:5S6J71tRvJawk1Ta48WLg4 deJKxUD5IRhdb0BWkSCMo6ss4shMINx7dT5a+K092xWtCtsVA9cTuVYd9ymwONpOQhOBvGuyX ps+ijoAvwFOqjfVJQPgJ1N9yq3iUVNGW7lFnRbf3LkqzQdD3OaqED0tGxqLYVzU4b2HDxyEA3 cMzdQBh452JpMQH8LUQPo0qJ4RKQ5JEaPOSZjw78QAns/6GVBY0SEWaRj8J7m56WGPahVjaM1 z7ZZTptRws4cXr78+z0PpJ+08gkyuZdBBpEz0l2IGeldU8vwjmpKQYqV7U6JXc/YfdhxAtk9J 0GNTGdUHZt06pFOcoYIabeJ79oSI7bxUtGejYL94Db2qhJgGIK7wJxfli12jVTfHuE4Qp2ED4 +0iWMWTINWM+B4udF+W0pYlnDFCIvA2ypUZ/9ZtWradKdFlkJ6251nbbzCJsaHKIcW9OjJJhF nL4rdBX4RsdkOFHwlvuwDBdwEAr7HjoW++7cObEB61gcTe/oTIBbXb47NEVlkA1H9z0Goxq3w uah7DusxUfHhwwpGxYKvUYGRiFKm15JivuvGRjBg5PMgr21PopQR9X//GvqhE2jG4QiUobsFp 5tKqA/iFx0dNInHn/bYxsdl2f9wExllYwKi+DNX0HciNO+yta/ft+iX33Ka+gdXjd3Ctk7Lh8 HJ/6O3rKroF3fV5a3D9CvWi69TaH6F4y3TCyk4Dav7EkHFDPDlWpHtFpkalLbrApke1pbGkoi Doix8XPviG+rwVcS6+zlbke2+Rxx+eJU9+S9a1extzEzUOVsBF8bnJBCHXw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Dmitry Gutov writes: > This has been caused by the commit > 7f9b037245ddb662ad98685e429a2498ae6b7c62, which made both vc-state and > vc-working-revision use vc-responsible-backend instead of vc-backend. Yes. > As a result, in some backends these functions started return non-nil > values for unknown files or directories, as long as they lie inside a > VC repository. vc-working-revision shall return nil for unregistered files. vc-state shall return a non-nil value, 'unregistered. > This change is indeed backward-incompatible, and it breaks the > previous assumption of some backend functions that if FILE has been > passed to it, then it's surely registered with the current > backend. You cannot guarantee this. Anybody is free to call the functions with unregistered files. And in the vc-state case, it is even documented that this could happen. > In particular, it breaks an assumption I made when fixing #11757, that > vc-git-state never receives an unregistered file as input. So if you > evaluate (vc-state "1") now, it'll return `up-to-date'. This assumption could be kept if vc-state filters such unregistered files out. > While reverting the change makes some tests fail, we should fix them > in different ways. > > For some backends, maybe, we should accept that (vc-state > default-directory) and (vc-working-revision default-directory) will > return nil. Alternatively, fix that problem inside the respective > backends, without changing the dispatching functions. > > Also, reverting this commit also seems to uncover tests that shouldn't > pass anyway. Checks like > > (should (eq (vc-state default-directory) > (vc-state default-directory backend))) > > don't verify much, and in this case they seem to verify the wrong > thing. More on that in the respective threads in emacs-devel later. > > Michael, thoughts? I've prepared a patch which just covers the case that a file is unregistered, in both vc-state and vc-working-revision. It is a very small change, that I believe it could still go into the emacs-25 branch. Patch towards emacs-25 branch is appended, including modification of vc-tests.el. Comments? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=diff diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 0826744..dc7cc61 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -475,10 +475,11 @@ vc-state ;; FIXME: New (sub)states needed (?): ;; - `copied' and `moved' (might be handled by `removed' and `added') (or (vc-file-getprop file 'vc-state) + (and (not (vc-registered file)) 'unregistered) (when (> (length file) 0) ;Why?? --Stef (setq backend (or backend (vc-responsible-backend file))) (when backend - (vc-state-refresh file backend))))) + (vc-state-refresh file backend))))) (defun vc-state-refresh (file backend) "Quickly recompute the `state' of FILE." @@ -494,11 +495,12 @@ vc-working-revision "Return the repository version from which FILE was checked out. If FILE is not registered, this function always returns nil." (or (vc-file-getprop file 'vc-working-revision) - (progn - (setq backend (or backend (vc-responsible-backend file))) - (when backend - (vc-file-setprop file 'vc-working-revision - (vc-call-backend backend 'working-revision file)))))) + (and (vc-registered file) + (progn + (setq backend (or backend (vc-responsible-backend file))) + (when backend + (vc-file-setprop file 'vc-working-revision + (vc-call-backend backend 'working-revision file))))))) ;; Backward compatibility. (define-obsolete-function-alias diff --git a/test/automated/vc-tests.el b/test/automated/vc-tests.el index 2faa143..7f6196b 100644 --- a/test/automated/vc-tests.el +++ b/test/automated/vc-tests.el @@ -285,10 +285,9 @@ vc-test--state (make-directory default-directory) (vc-test--create-repo-function backend) - ;; nil: Hg Mtn RCS - ;; added: Git - ;; unregistered: CVS SCCS SRC - ;; up-to-date: Bzr SVN + ;; nil: RCS + ;; unregistered: Bzr CVS Git Hg Mtn SCCS SRC + ;; up-to-date: SVN (message "vc-state1 %s" (vc-state default-directory)) (should (eq (vc-state default-directory) (vc-state default-directory backend))) @@ -298,51 +297,43 @@ vc-test--state (let ((tmp-name (expand-file-name "foo" default-directory))) ;; Check state of an empty file. - ;; nil: Hg Mtn SRC SVN - ;; added: Git - ;; unregistered: RCS SCCS - ;; up-to-date: Bzr CVS + ;; unregistered: Bzr CVS Git Hg Mtn RCS SCCS SRC SVN (message "vc-state2 %s" (vc-state tmp-name)) (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date))) + (should (eq (vc-state tmp-name) 'unregistered)) ;; Write a new file. Check state. (write-region "foo" nil tmp-name nil 'nomessage) - ;; nil: Mtn - ;; added: Git - ;; unregistered: Hg RCS SCCS SRC SVN - ;; up-to-date: Bzr CVS + ;; unregistered: Bzr CVS Git Hg Mtn RCS SCCS SRC SVN (message "vc-state3 %s" (vc-state tmp-name)) (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date))) + (should (eq (vc-state tmp-name) 'unregistered)) ;; Register a file. Check state. (vc-register (list backend (list (file-name-nondirectory tmp-name)))) - ;; added: Git Mtn - ;; unregistered: Hg RCS SCCS SRC SVN - ;; up-to-date: Bzr CVS + ;; nil: SRC + ;; added: Bzr CVS Git Hg Mtn + ;; unregistered: SVN + ;; up-to-date: RCS SCCS (message "vc-state4 %s" (vc-state tmp-name)) (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) '(added unregistered up-to-date))) + (should (memq (vc-state tmp-name) + '(nil added unregistered up-to-date))) ;; Unregister the file. Check state. (condition-case nil (progn (vc-test--unregister-function backend tmp-name) - ;; added: Git - ;; unregistered: Hg RCS + ;; added: Bzr Git Hg ;; unsupported: CVS Mtn SCCS SRC SVN - ;; up-to-date: Bzr + ;; up-to-date: RCS (message "vc-state5 %s" (vc-state tmp-name)) (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) - '(added unregistered up-to-date)))) + (should (memq (vc-state tmp-name) '(added up-to-date)))) (vc-not-supported (message "vc-state5 unsupported"))))) ;; Save exit. @@ -370,8 +361,8 @@ vc-test--working-revision (make-directory default-directory) (vc-test--create-repo-function backend) - ;; nil: CVS Git Mtn RCS SCCS - ;; "0": Bzr Hg SRC SVN + ;; nil: Bzr CVS Git Hg Mtn RCS SCCS SRC + ;; "0": SVN (message "vc-working-revision1 %s" (vc-working-revision default-directory)) (should (eq (vc-working-revision default-directory) @@ -382,33 +373,32 @@ vc-test--working-revision ;; Check initial working revision, should be nil until ;; it's registered. - ;; nil: CVS Git Mtn RCS SCCS SVN - ;; "0": Bzr Hg SRC + ;; nil: Bzr CVS Git Hg Mtn RCS SCCS SRC SVN (message "vc-working-revision2 %s" (vc-working-revision tmp-name)) (should (eq (vc-working-revision tmp-name) (vc-working-revision tmp-name backend))) - (should (member (vc-working-revision tmp-name) '(nil "0"))) + (should-not (vc-working-revision tmp-name)) ;; Write a new file. Check working revision. (write-region "foo" nil tmp-name nil 'nomessage) - ;; nil: CVS Git Mtn RCS SCCS SVN - ;; "0": Bzr Hg SRC + ;; nil: Bzr CVS Git Hg Mtn RCS SCCS SRC SVN (message "vc-working-revision3 %s" (vc-working-revision tmp-name)) (should (eq (vc-working-revision tmp-name) (vc-working-revision tmp-name backend))) - (should (member (vc-working-revision tmp-name) '(nil "0"))) + (should-not (vc-working-revision tmp-name)) ;; Register a file. Check working revision. (vc-register (list backend (list (file-name-nondirectory tmp-name)))) - ;; nil: Mtn Git RCS SCCS + ;; nil: Git Mtn ;; "0": Bzr CVS Hg SRC SVN + ;; "1.1": RCS SCCS (message "vc-working-revision4 %s" (vc-working-revision tmp-name)) (should (eq (vc-working-revision tmp-name) (vc-working-revision tmp-name backend))) - (should (member (vc-working-revision tmp-name) '(nil "0"))) + (should (member (vc-working-revision tmp-name) '(nil "0" "1.1"))) ;; Unregister the file. Check working revision. (condition-case nil @@ -417,12 +407,13 @@ vc-test--working-revision ;; nil: Git RCS ;; "0": Bzr Hg + ;; "1.1": RCS ;; unsupported: CVS Mtn SCCS SRC SVN (message "vc-working-revision5 %s" (vc-working-revision tmp-name)) (should (eq (vc-working-revision tmp-name) (vc-working-revision tmp-name backend))) - (should (member (vc-working-revision tmp-name) '(nil "0")))) + (should (member (vc-working-revision tmp-name) '(nil "0" "1.1")))) (vc-not-supported (message "vc-working-revision5 unsupported"))))) ;; Save exit. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 13 16:49:23 2016 Received: (at 20637) by debbugs.gnu.org; 13 Apr 2016 20:49:23 +0000 Received: from localhost ([127.0.0.1]:34038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqRj0-0005FP-S2 for submit@debbugs.gnu.org; Wed, 13 Apr 2016 16:49:23 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqRiz-0005FC-AJ for 20637@debbugs.gnu.org; Wed, 13 Apr 2016 16:49:21 -0400 Received: by mail-wm0-f53.google.com with SMTP id n3so97854313wmn.0 for <20637@debbugs.gnu.org>; Wed, 13 Apr 2016 13:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=NR1bFXgoDOyerqggjqur4dsgq3hiUlZfeIgwxnPcI1I=; b=brhwAP6+eYztCdJaC8OTrXeqPK7TOUP5hO5L9dRcbOp2I4b/u0FEv2PZ5W8zJoe70v 2xFuCiozNvtMfPBPoNNieV7wFh/XHhqyMYHPSfXNEAhoLM+/r4GgOI0qBfRPoCAUKEgl JceWuSw+T9eAzBPvUVHIO/qse5jxOhMz86GBHwOhaaEIKCS1fTfBPcstXe7eJdJVK4ow a28s+bUW8boReZEj0L4fdt1KTWhT536ZaDUAZHKmYccHLROUjO2iw9EKR+yPn50gmq+w 7t8U1fDuBiJa+J5f0X0MMMoLvjQl/W5eK8ZCceIIjnfZGqxwGcblFKjxFq8c1Kch1zcd MVkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NR1bFXgoDOyerqggjqur4dsgq3hiUlZfeIgwxnPcI1I=; b=lVedWgcWdH26/HWoH1KhY2ouCi8zkKrTRmPhDOcwmLE4xWjxzWnZ8YwyozW/F9Sqoc M/IgZJCwQLvFF8aRCMRGJEqkeoy4bqOcVKpmmDPMaKzCdl77H3ouAKwhvlphRC2x7DuY jHl4K5UclSu38L2pjziEYrF5w+Dm1u8tzOlAxexc4JBK2jEC+EsJsu7nHckXRg7scIis 2z4vQE9zC4NUle4iq4p+7/0U9U57gVquXi53DrGoqc7cmLMXzWaFNTN66k3Utr8PxfN9 myFlLwUH8gKUdFC1+Ow82ny/7GUItPzI/aHa5n+hrJKK1VoFrxAW4ulYcudy9cDeqwA1 V2Kw== X-Gm-Message-State: AD7BkJKiTO9jNUC1GJZuNF/+Q+Bu600zholXPn01YvJ2Xnxch1BkiT9J2U1qea61fH+R5g== X-Received: by 10.28.87.65 with SMTP id l62mr34475045wmb.102.1460580555592; Wed, 13 Apr 2016 13:49:15 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id ys9sm40248240wjc.35.2016.04.13.13.49.13 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 13 Apr 2016 13:49:14 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Wed, 13 Apr 2016 23:49:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87oa9dzgl0.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hey Michael, On 04/13/2016 06:14 PM, Michael Albinus wrote: > vc-working-revision shall return nil for unregistered files. vc-state > shall return a non-nil value, 'unregistered. That sounds fine to me in principle, but I don't think we can get there for Emacs 25.1, without paying with lower performance (*). The current code is slower than what's in 24.5 already, as a result of the aforementioned revision. > You cannot guarantee this. Anybody is free to call the functions with > unregistered files.And in the vc-state case, it is even documented that > this could happen. Both true. However, that vc-state's behavior has been different from its documentation in this regard, for many releases. >> In particular, it breaks an assumption I made when fixing #11757, that >> vc-git-state never receives an unregistered file as input. So if you >> evaluate (vc-state "1") now, it'll return `up-to-date'. > > This assumption could be kept if vc-state filters such unregistered > files out. Problem: vc-registered is slower than vc-backend. Like, orders of magnitude slower. vc-backend caches the result of the previous vc-registered invocation in vc-file-prop-obarray. But if we call vc-registered directly, we go the whole way each time, including calling vc-BACKEND-registered. Yes, both vc-state and vc-working-revision cache their results in a property, so we're only paying the added overhead when the file is opened, reverted, etc, but it's still a price. Don't you think it is a problem? > I've prepared a patch which just covers the case that a file is > unregistered, in both vc-state and vc-working-revision. It is a very > small change, that I believe it could still go into the emacs-25 branch. Aside from the above, is there a reason to keep using vc-responsible-backend instead of vc-backend, in vc-state and vc-working-revision? It's also slower than vc-backend. (*) If you _really_ think that vc-state should ever return `unregistered' (personally, I've never found that distinction useful; we could just as well update the docstring that it returns nil in that case), I think the way to get that is to make vc-git-registered return non-nil for all files inside Git-controlled repositories, and to make vc-git-state return `unregistered' for unregistered files (and same for other backends). But it would be a bigger change, better suitable for the next release. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 13 16:55:46 2016 Received: (at 20637) by debbugs.gnu.org; 13 Apr 2016 20:55:46 +0000 Received: from localhost ([127.0.0.1]:34062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqRpC-0005TL-EL for submit@debbugs.gnu.org; Wed, 13 Apr 2016 16:55:46 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:34998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqRpA-0005T6-VA for 20637@debbugs.gnu.org; Wed, 13 Apr 2016 16:55:45 -0400 Received: by mail-wm0-f53.google.com with SMTP id a140so120431354wma.0 for <20637@debbugs.gnu.org>; Wed, 13 Apr 2016 13:55:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=ymdQ0ubZcsn6VqzeaCOUpP9+TCBehdoQANXvN3TRvac=; b=yFF4CF6c9oIWTaE9cfb97gWFiwQAGZiuXI7D0IPQ6RCHnEuTsf3gX0lzxTb9sqt+26 aeNB71Fu5jFeQEwrUUuQyvE0kuxWzM4tMG+g8dRIqDI4tZ3L/WNoKKlKCKkMl4LizUiC 3vRc/4zwWzUq6tdknKDMYXwSJTRQgFoTMtIpIImurbUX8SVZkDu5RBsO3//ZOWK7MALA 61a8KD1ROonlMNXajiXat2u6Pd9BudAzhJCK8mrZng/ob0XNr8Fcve50l+tV+gC9yQ9C WohvMPhGJpSBawq5T5yZc722RozVmfTn81KykhWmz3A1bDjNhXoEEjXna5nb0b3wXUN3 1Swg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=ymdQ0ubZcsn6VqzeaCOUpP9+TCBehdoQANXvN3TRvac=; b=OPrYqMieo+XX1PuhK4hTOd8/Pyj8MPxWVcmgC2dlfdgaxixzBV1rkiRStvRUW6kIUH soXUv3hX3phPuGoRfBMF1Kt3vDIoIzgdVgOG6bbVB1oW31Ndd2vwZoVOI3690nas06Td MwEVU2nx7dLVcnwq7caDxpj07Em9L5ouslwTeNgrngiFqwIp1sYZTMss0fLhMjjtw+Qo IW3CdI17MyNzPUUIvzhoWJX2bHvIdToYseSwB8rlw37wa6J8N9tnFhokrV15Za5hjnni mOUrHUibh6FqGfZWf2VfvIUx1fCkMQCTzWUjrW0V4rRhhh8R9vpZD4WaQ9G5iIGgKgNB fkHQ== X-Gm-Message-State: AOPr4FX4Iw1lF/zvrUYG9sCb8knuAE/itL0JqNASOoYzBJ/yYbppMbTOMf9PeT52PpOasQ== X-Received: by 10.28.144.20 with SMTP id s20mr13072199wmd.12.1460580939407; Wed, 13 Apr 2016 13:55:39 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id x2sm40410364wjr.33.2016.04.13.13.55.38 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 13 Apr 2016 13:55:38 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> <87egacws5x.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Wed, 13 Apr 2016 23:55:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87egacws5x.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/11/2016 09:55 AM, Michael Albinus wrote: >>> But nobody has taken any action for more than 10 months :-( >> >> I would expect that to be the responsibility of the person who caused >> the breakage. > > Of course! > > Until now I even didn't realize this was broken by my patch. Sorry, but > I have been in hospital last year, and when I recovered there were too > many messages to scan. To be clear, I don't mean to blame you for the time that has passed. But you were probably the best person to notice this regression, and understand why it happened, early enough. Personally, I've looked at this bug report before, and could only tell that the documentation needed updating (but the changed behavior is fine). That's not my impression anymore. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 03:10:19 2016 Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 07:10:19 +0000 Received: from localhost ([127.0.0.1]:34409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqbPv-00079K-02 for submit@debbugs.gnu.org; Thu, 14 Apr 2016 03:10:19 -0400 Received: from mout.gmx.net ([212.227.15.18]:60837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqbPs-000792-V4 for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 03:10:17 -0400 Received: from detlef.gmx.de ([87.146.59.141]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MNIi1-1asYQ71PeD-006szN; Thu, 14 Apr 2016 09:10:10 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> <87egacws5x.fsf@gmx.de> Date: Thu, 14 Apr 2016 09:10:09 +0200 In-Reply-To: (Dmitry Gutov's message of "Wed, 13 Apr 2016 23:55:37 +0300") Message-ID: <87twj4hdim.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:pnRN8OFOx2yR5gJcpdAD/3pjL2K7AeXykr3c0hwLMovHshUDOBP Gjvkx7TCHWp+jaFbdOx3Ha1SI04wifBb+TtgLMJcdhwt6FV5ps9C4FmFsUSmlzdm3IdqfBG p2bxdW7CjshyaK6RnB96/EtXwZYAaPG+P1c00fk2CYF0Oc812lYMHU6pkUrKefOZ2catEDB jZZ5TzFMtRXa/Hkj+hCtg== X-UI-Out-Filterresults: notjunk:1;V01:K0:27kgcU2xeQY=:ijqtvQU9urzKTu2SwURSCg ugAHTBQT8eAXFm4GITd6iqvRQ5GdMTYGaTIRTotbMaWfqfZrieQM9a5ij7p0iUZ3tDMFGGjR5 uWvwcK0O/xrLyT77OLRVuXHHZqRWiv4Qy6eP29b24mQSBZEQDIrB+lX2oV9Ehs8xAU0C2Zrc8 Bn58GpC6+hlNal4HTnP2jx/frUrOcX/RaqT6mDdz8ZiC1pXxjFlX4koKMhCu+lQsKR+oYm0Nx 0dsiexihPdFzuqeBl09sIkUKXIj9cGIzmETPnxKLn4R2IVzRhIMPk1dyhYXajYG+uOkgBNlCL jNiZKh7TjBQBWpQ99KzHj+Quufs6I6rkmAPf8oKFneMq7bBQhuLbhGOlHXp0B48UY2L/fI+MW RZpOl0PmTyKAOy1smarmifla0VJcjMNbqjOSpjLocJFwfijbOxerQ3+L9YLgIOcgIdtLeYZqD plqRdtZKw4uBnXXh7Zwik7wCPHBSNsPiRRBs5lWC/wjs5r/71pI1DPC5qETq56r3e4VfldflL lozAKkUq/v2wo9xYgJlUnrRHlMMamkMDGIjQ7JQaSMJcWq19j4lmHLPcpN9roKhsXERHyLTHR Xy5VMVhhd8p98/PguAHfQ9tOlX6RxtTW+7FJ/L6LwMO9LOdfP5dPRAoO0pTprRfk9/4d8H9jw LeFo229SKfENJWQjKEVL67vr6Tqoeg6US+uIjje5FLA0Ic6BYITJRVcf7kQXwVcJBsEMQB0jk 1moCGDyCPSIrSMTi2vROh3koHlQ7VAuRWHmn49KcaZIStY3FA+LoFG/PY+PWHoWlE/p3rW+zm PLD5MuT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: Hi Dmitry, >> Until now I even didn't realize this was broken by my patch. Sorry, but >> I have been in hospital last year, and when I recovered there were too >> many messages to scan. > > To be clear, I don't mean to blame you for the time that has > passed. But you were probably the best person to notice this > regression, and understand why it happened, early enough. No problem, I didn't felt being blamed. It was just an unfortune coincidence, that this bug wasn't handled earlier. And I still feel unhappy that none of the active Emacs maintainers feels responsible for vc*.el. I'm trying to support fixing problems here, but most of the code, and the VCSes being used, are still terra incognita for me. > Thanks. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 03:21:49 2016 Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 07:21:49 +0000 Received: from localhost ([127.0.0.1]:34414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqbb3-0007QP-3b for submit@debbugs.gnu.org; Thu, 14 Apr 2016 03:21:49 -0400 Received: from mout.gmx.net ([212.227.15.15]:52683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqbb1-0007QD-Ml for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 03:21:48 -0400 Received: from detlef.gmx.de ([87.146.59.141]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M9K5G-1avb1039bi-00CiVj; Thu, 14 Apr 2016 09:21:40 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> Date: Thu, 14 Apr 2016 09:21:38 +0200 In-Reply-To: (Dmitry Gutov's message of "Wed, 13 Apr 2016 23:49:12 +0300") Message-ID: <87potshczh.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:hEiWU7g2sj0pLwgnLNRHUMjbZ8Xp9JMwGdpTR/e3aohZYcu/Via G7L1tnRg/WZhZq8XNSPlYaPF4mScquaGkmh58QWIw+vodtwL6f5HxEiDWiUYM9Mvqp4Hhxc Dll4RiqWghZ663R3OK5liuNefDuhnOYOf0C0M84HIeYVpNwgj1pl5QJJiHFp2sqrmtKiA3x jvZ9njR/AwKrZa4r+yZBA== X-UI-Out-Filterresults: notjunk:1;V01:K0:++3caKcwrMY=:zttECgt50DsthJ8fRGwBkD 7DZHKlmRGUPX2scfMdUuRVmJZ9KqwMTCfvmoc3wm9LViYvTBVmuNZxOWumDzJGbOzegGCep/n szLKMEM8GGtfdK6RjUfeDcXKHNWJqJ0dLALQuTWYqrolg3aggBppJ9LNMCnnmeuoc3PElavMU 05lbmH7QRnOVAFd+PJ5hFZOH88G30duHSYv0XldHzBr84qqDWffXtgy8av2/djqvlPswNd8j/ qm3IIXbCaklK0B6Qp/GDkawpQo9ioeUMuZ+4DKyFHfBPfuX4OWxaHsgwUyTDv1hEJv8fRE3y1 MmCiW5yk0yM3yUp2swZAy38Vp2UhCokYYhLU7c79DEgV8pj5SdMUP+nAvDzReoODOZF1gvNEk uSFnkWgk2NX2oKbXc4t5bYYyyx54LUTTgdHbodCBG0AEFy5Vh7f0j5PoSlaySBgfMgCw17LW9 7MbX4H6A1OJC+ch6ISyNPi7Jo6i3sGOP6Ucb5WG9KmqJ3094G2z9Ig01Bl1VLfgrZNyITa7y7 kQYTX71evugb4MsI7PhWAunBardAJ6wYnQ5DdFA7XRDCDYoQNyYDdgnsbiQyvltbWPljLCtuP Wb7jNPqHSwmx7c2IvIdh48TA6GJvWTpQoKY1kRKSO7JZR/Gkmlxyq0YshMsHkSeirqZESNbFx RCn0ojxpti/rhIZlbpi7twF9QtTdA0/RTzQxpRPXn18lAyoLY9/I3oZ+aClEMzPvLkdPp721w Cl2fpAeB2G2va4GdL1I5I37icADZEdsri74TRMBsA6kAW7pJxVLbhfmMOgRlQa1RxKMNMzwCY sabD6FN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > Hey Michael, Hi Dmitry, > Problem: vc-registered is slower than vc-backend. Like, orders of > magnitude slower. vc-backend caches the result of the previous > vc-registered invocation in vc-file-prop-obarray. But if we call > vc-registered directly, we go the whole way each time, including > calling vc-BACKEND-registered. I haven't thought too much about performance. But you are right, we shouldn't add serious performance penalties to the code. And improving performance for the 25.1 release is much too late. So we might revert the patch for vc-state and vc-working-revision indeed for the emacs-25 branch, going back to using vc-backend. In the master branch we might apply my proposed patch using vc-registered or something similar, and start to improve performance. In parallel, we shall start to write a VCS section for the elisp manual, describing vc-* functionality in more detail. We could start with vc-backend and vc-responsible-backend and their intended use. I'm missing such documentation for years. I'll come back later today with the patch for emacs-25, if you agree. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 09:53:36 2016 Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 13:53:36 +0000 Received: from localhost ([127.0.0.1]:34760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqhiC-0003J4-4D for submit@debbugs.gnu.org; Thu, 14 Apr 2016 09:53:36 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqhiB-0003Ir-Dj for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 09:53:35 -0400 Received: by mail-wm0-f68.google.com with SMTP id a140so23124205wma.2 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 06:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=mJYMttM0XTrqnMo3PRBAST1+86QPsA+1FGrAONRTZsY=; b=sXn27wUabjAFHB4hLGAsSXx1KvD5FJ6iOOyybE64FX6qjTzSYS+Ums96YEPrt1D/Wt q5nwfSzaYFmY5QdWz+r79B9Q6iVvWt25Hvc5IrFJOOGfXZEqp2VCurCWMNnfE0dmhssg WcMg7jdo06iMd7j9TX3ZwA/AwGRqyUEH7+0w3C6+rFQ5sS5+UpVBQE1M1b+dbilsSrfL v/c+PrR6AoC0NWaoQ2uONiJOuR1+hsC0X+hRbZR0yOYU3aZCB4nCl/puL0sN2iZBFbKd Pqx1INZEswdHofBxIeULdyU9RTh1lqBl2qcOFey+w4LreIKRV8A0WfVXLZ+sLGiT9Dah tvCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=mJYMttM0XTrqnMo3PRBAST1+86QPsA+1FGrAONRTZsY=; b=mfOc7rN6HArivJiEplQU/SPkjbXJPSZGf/4Clbk1BTekqH+IJBnxBzK9sgyaPl8cLx pHp+9KRAW5YqLSV+8144GWkzQoS6QCYh0COMRoZo7Yd9FcP8g/U8azTQIG0ZFVbBqMVm 2cLHnDu8QGf4OymzzJYd1nse9O4O/lY1YU82PNduZrfKDbauV4d7UKSeZnvRFTviYnLL xCiDg/XJwe1THjqefE8XDnhMTgeFFwrzfwv7Upqhc4Eh0KXi6M/pFwAVuQURNyeO65Kd /aIxv57llBl5iKJkmgc4kBe8LjxRcikI8YbrZSzuEOUaPsdDoXA166bwFELrnokM13nY l3eQ== X-Gm-Message-State: AOPr4FWWxbiMXlSWsbftzsd+KsDwycxc3JmqMmTZtEW2eS7av7SwfVACQ+sHtaewv5SBBg== X-Received: by 10.194.20.193 with SMTP id p1mr16929584wje.87.1460642009682; Thu, 14 Apr 2016 06:53:29 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id gr4sm8493483wjd.23.2016.04.14.06.53.28 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 06:53:28 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> <87egacws5x.fsf@gmx.de> <87twj4hdim.fsf@gmx.de> From: Dmitry Gutov Message-ID: <8a0a80ab-a299-814e-1e18-68ce6e74d9f9@yandex.ru> Date: Thu, 14 Apr 2016 16:53:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87twj4hdim.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/14/2016 10:10 AM, Michael Albinus wrote: > And I still feel unhappy that none of the active Emacs maintainers feels > responsible for vc*.el. I do feel responsible, and I try to take care of most bug reports in that area. > I'm trying to support fixing problems here, but > most of the code, and the VCSes being used, are still terra incognita for me. It would be great if the problems we're fixing were formulated like "VC behaves like this, and it causes that problem in practice (or could cause, at least)", rather than "here is a test case, and I feel it should pass". I think that would encourage more practical choices. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 10:20:52 2016 Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 14:20:52 +0000 Received: from localhost ([127.0.0.1]:35451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqi8a-00046i-DT for submit@debbugs.gnu.org; Thu, 14 Apr 2016 10:20:52 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqi8Y-00046U-O1 for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 10:20:51 -0400 Received: by mail-wm0-f65.google.com with SMTP id y144so23276034wmd.0 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 07:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=UILCPxipKxWEcFyb95JY/Zs6fGNB/azUw6MTpSEUN6A=; b=rWbT2Jt7nPf3mZrh4WyHhlJa2x4L/caTOP7DNIIiQRDmy1pV/o+AN1GbBLoiWohpez JwzN1/gC5ggHSQc+czYQNxKmi7EJsorwdmVjidY8YJs+QFEVrcx4keIwOUmMfRjMNk3i /StHZNKhTLxBVcpfEaNS433ng0DJrKZw+fV7VYdDf1PrY9vUAf4xv71u3d8HLwDocDKT DFHgk/XOoUxQXx61fpToVQozh1PRXS0S4aItYmHqjZbxz810NAxU7RKgLN+vjxCicrch KYVcQnhtU0LONfbCdDwhjJCcr/ilHxbeVsdfK2GbMRWaAmISE32ntqtRsEUuxD5aeTlY yCww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=UILCPxipKxWEcFyb95JY/Zs6fGNB/azUw6MTpSEUN6A=; b=TWoGvsGcLhDGIw4g9ht8bd2MI1o2N9mYJAx3p4HQTMQs1/BvDJBbvTr/GfStagvkDQ GNFZzevRNGoDYx5E2mS3t+CmvEbOGZ2WB6RItH3L79w8FAkCgjuYPREH4279uMNjSuIV 6JQaz4eDPNICY6jP2WALGsf2h3nc1UK1fJBGroqjayKK23L1qUfLp5d/cIvwO55Wx9ht BZ4q2nHGKtyW8SqGxx9QhMULl7mp4I080lAdgVOMJ9xYIX5hT62Wv+W/9I0X3zNGBCWs KXEBw+hBUasOIrERomJJ4PVEYzcZe9PtaQnMBL5juNED6cbT0iIT14bPWFzszzLW6Onz Dc3Q== X-Gm-Message-State: AOPr4FW7QSO9q55qB8xJprVlOzZCSzFLJpqxba03LHsLS6OH12yGmX5GxbUt0zpXZ9dFHw== X-Received: by 10.28.59.7 with SMTP id i7mr17555925wma.66.1460643644862; Thu, 14 Apr 2016 07:20:44 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id b135sm33813674wmb.10.2016.04.14.07.20.42 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 07:20:43 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Thu, 14 Apr 2016 17:20:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87potshczh.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/14/2016 10:21 AM, Michael Albinus wrote: > I haven't thought too much about performance. But you are right, we > shouldn't add serious performance penalties to the code. And improving > performance for the 25.1 release is much too late. It's hard for me to judge how serious those are, really (I only have a fast laptop with GNU/Linux these days), but being wary of extra process calls seems prudent. Ideally, we'd reduce their number, not increase it. > So we might revert the patch for vc-state and vc-working-revision indeed > for the emacs-25 branch, going back to using vc-backend. Thanks, I agree. > In the master branch we might apply my proposed patch using > vc-registered or something similar, and start to improve performance. Improve how? Would you like to comment on the last paragraph of my previous email in this subthread? I don't really see a point in returning `unregistered' from `vc-state'. When would the caller treat it differently from nil? And returning nil seems like an easier choice, implementation-wise, and well as a more conservative one from the backward compatibility perspective. The `dir-status-files' backend command would continue including the `unregistered' entries (we could make it skip the up-to-date ones, though, in the interest of improving performance). > In > parallel, we shall start to write a VCS section for the elisp manual, > describing vc-* functionality in more detail. We could start with > vc-backend and vc-responsible-backend and their intended use. I'm > missing such documentation for years. I'd rather put the missing information into the docstrings, really. It seems unlikely that we're missing more than a few sentences in these two functions' descriptions, and we could also rephrase the existing ones. But if you'd be more comfortable with having that information in the manual as well, don't let me stop you. > I'll come back later today with the patch for emacs-25, if you agree. In any case, I definitely agree with reverting vc-state and vc-working-revision to use vc-backend in Emacs 25.1. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 11:26:43 2016 Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 15:26:43 +0000 Received: from localhost ([127.0.0.1]:35477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjAJ-0005jm-3c for submit@debbugs.gnu.org; Thu, 14 Apr 2016 11:26:43 -0400 Received: from mout.gmx.net ([212.227.17.20]:52311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjAH-0005jY-1V for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 11:26:41 -0400 Received: from detlef.gmx.de ([87.146.59.141]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MAy40-1ayO7z09Ke-009xLD; Thu, 14 Apr 2016 17:26:35 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> <87egacws5x.fsf@gmx.de> <87twj4hdim.fsf@gmx.de> <8a0a80ab-a299-814e-1e18-68ce6e74d9f9@yandex.ru> Date: Thu, 14 Apr 2016 17:26:33 +0200 In-Reply-To: <8a0a80ab-a299-814e-1e18-68ce6e74d9f9@yandex.ru> (Dmitry Gutov's message of "Thu, 14 Apr 2016 16:53:27 +0300") Message-ID: <87oa9cyzx2.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:gnBSsAp2ufTtr11RPlgPiUGYxX7h0QJlcaJiOqJ+WgViFhYNbIG iQnEJOkGp+Pg09fCkdT+Xt8oB5ghugoaYQMDMZDwsoGlgUhYP4985XEsSyyzSUkhBxqDHFU e8/01gkdBUrkbnv+wntkervM4CNxm+MN0JCQHjI1Q1ziaMwGgrPpyMLxKvBhfbQYH9TapY/ l5oZeIzZ+6UPWZIO7wOog== X-UI-Out-Filterresults: notjunk:1;V01:K0:SHK3V/5M1RI=:XCCOcFbjtNjyxJy5Jvf9Fs 0yZyI5dKAAPHPl9MlA0QXJ/Vdf9KDn0gVeNf/Cg4Oh9lAm8s26FUTsjWTPG0dMIDx/85yKA2k FP5v4Lxe1/b+2VGOACkxK+XTNbGPkRBlWkeHzGr3g/U6qPi+dyCN2kWk8wwJKeKBCQFn2bvM3 qdTazB47F1J3kW3lKAb0LEXxdYYJ/CD3+u45EalivQAOc/PcRyNuuQDerLd+ZIrDImns2jLwU Tng54t1DB3yf+QiEhEsFmsi+WtKEorkoUPgFeiOANijy+iZGz40cXxMgu/bT5VvW7TAZncgG6 /3x5jZak0yEHY4ceBgk04YoJv/ZC5COcC7Z90X6c/xzJWyhwE9ZJIb2A57kOf9YXLEn1X7Xkr T2W5b+m7M7yQB4f3fR15e7kM+wLmZKpKcmOMumoMWisgjLTTy7NorCA2DS5w0/q3SwexlebvG tFc+/Cp5Vdr3wjPtBB5kdyOT7iXr5NP+repnEDch26bNPEp3F9BStL8rcg4WyG4Ryf/aG/Evl F4ixbBb7E8j3RxVBH07lUv3m3MVzRNMG0OuV8SOTTnw8jxz+SDBNB72r91XQHdpFYVX/b0XIH LsQQI3LhJgcuYl+PmrBMLda4LlqsPpVYF3OJBImmjqPaybiHERscXbQ0Qy82T0PCe7X6K4hU3 LxMkuzGg0YQXPQvKH8eJvGYncr+F4qz54LgzF4KxcRj24vJuJ4G8Dj+YAEw2qLaxp9iqswAtF yuc4i3kET2j77kau3Hmz9NpYmV87Td0VNAoQRZBOmyHAXBueFnBEKV29+7qYiaoQfmS4hRsRH mRl4f0f X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: >> And I still feel unhappy that none of the active Emacs maintainers feels >> responsible for vc*.el. > > I do feel responsible, and I try to take care of most bug reports in > that area. I know that you do and I really appreciate this! But since ESRs rewrite in fall 2014, there are still several inconsistencies. Eric confirmed that in an email to me. So it's not only bug hunting, a systematic review of the state is needed. I've started to write systematic tests (up to my limited knowledge), and I've asked several times in emacs-devel ML for support, but nearly no response. That's why I'm kinda frustrated. Well, forget my lamenting. I'm still willing to help to improve. But I cannot do this alone, as in the past. >> I'm trying to support fixing problems here, but >> most of the code, and the VCSes being used, are still terra incognita for me. > > It would be great if the problems we're fixing were formulated like > "VC behaves like this, and it causes that problem in practice (or > could cause, at least)", rather than "here is a test case, and I feel > it should pass". I think that would encourage more practical choices. I agree that the tests shall be much more commented. But I see also the lack of documentation and implicit design decisions (you spoke about somewhere), which must be improved I believe. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 11:40:15 2016 Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 15:40:15 +0000 Received: from localhost ([127.0.0.1]:35509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjNO-00067j-Pm for submit@debbugs.gnu.org; Thu, 14 Apr 2016 11:40:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjNK-00066V-US for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 11:40:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqj7m-0000yV-Eb for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 11:24:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqj7m-0000yP-BI; Thu, 14 Apr 2016 11:24:06 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1140 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aqj7l-0001Xt-LG; Thu, 14 Apr 2016 11:24:06 -0400 Date: Thu, 14 Apr 2016 18:23:42 +0300 Message-Id: <83vb3kdxj5.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-reply-to: <87twj4hdim.fsf@gmx.de> (message from Michael Albinus on Thu, 14 Apr 2016 09:10:09 +0200) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> <87egacws5x.fsf@gmx.de> <87twj4hdim.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Michael Albinus > Date: Thu, 14 Apr 2016 09:10:09 +0200 > Cc: 20637@debbugs.gnu.org > > And I still feel unhappy that none of the active Emacs maintainers feels > responsible for vc*.el. We have similar void with some other packages, unfortunately. Volunteers are welcome. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 14:31:25 2016 Received: (at 20637) by debbugs.gnu.org; 14 Apr 2016 18:31:25 +0000 Received: from localhost ([127.0.0.1]:35616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqm33-0003bf-BX for submit@debbugs.gnu.org; Thu, 14 Apr 2016 14:31:25 -0400 Received: from mout.gmx.net ([212.227.17.22]:50223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqm31-0003bR-Nc for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 14:31:24 -0400 Received: from detlef.gmx.de ([87.146.59.141]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MY4Ls-1bLUAO2C1I-00Uu2o; Thu, 14 Apr 2016 20:31:16 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> Date: Thu, 14 Apr 2016 20:31:15 +0200 In-Reply-To: (Dmitry Gutov's message of "Thu, 14 Apr 2016 17:20:41 +0300") Message-ID: <87h9f4ghzg.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:laJE8/Yt7QjzdSoDL3PEeGXRqVr7zaFb8hjvZMNPsIS3b2YxyUX uudKhRrZXAl2nq6s4bxpMkoDIfnCePE8BfswhrbZKUT9MxdWFMs0dK4sCwNTf08GB5DtFGp 5sa0MKoQT0z1P/XmKpKRkQWb6xmZnFy0JlMnNkFsJKZ/4WyNpWLMypYQVR4rYBB+tDWwmru 7A7Q4uDIUMh51x5KEoqtw== X-UI-Out-Filterresults: notjunk:1;V01:K0:auQmz5nfqMs=:90OMwdyZ+tt+mkR2EUbAw1 z2NCiNVZsKfdNaDvB0QHRJTr4Y68SPg8rXnEDfRP3UAizdGwGU00ajguXreyO2tSt3sfT9Jzw JRka3UqHTDH9VBqyIwUHFWTTaGgqb0yz1WmSYUmEl0Y74mK6HWDbNY9U4RO0TRYxiVjFZh3Oo 7XfM90Smbt44WDiCE1INLaLGlLytPjV6m3SacXpPpogDGbHca/2XAcKt0ulD+DpEccqjfNuQv eFGpptJn+Q6anzvJ8j2CSRwuUfWvYOmwOk4BZpt0jFWE/l7YXBIqYh4T1vfgzQ/A3NtVA/igU 5ARcxjat4EFP+cDVB+yb/giUCgn9SZRn9pHZIz1hIpDeg2WQ7YREsZy6WOa18XVP4udMrEie+ +jcEQA3ZZTbdBysLtF4mHQVWqPg3NaU9eEUE3kwOUgC2bzmWyAa6zg7PxMk638CrkwqVbqUlJ Nr956FSodImuilEjuHX19DUMP9DDRVcjH2mWQq/gCT5RWxYjgcN7hCBBGNSb7xK1Ajh8dZdbl xnMjEfNyoWsluHqT6dRUvpO8lHkR0obIseTjEF6xxa5jWGy/d4wLN3WAMx32CScwia5BhJnJO /mmHp6xNXrYzPCQDfUQCDjTkN6c8UUAvEV7nXL6umEcacuVKe0YgQakvKbT4r0dgZro4LYk3e Bt+aTzhg7GHNKFm+eSpLFQ85+iYE+v1xO1VKppGFa15cezMds4WYeG3Dk1xOnQYPuilrRP5x1 VNxi7XPurNBqdkApQchBPB0OTkFlAwxdfido2Ibeqvfgd8aCI/nlDTvoJMMDja7gYbB6bsY6G LeMSpJY X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: >> I haven't thought too much about performance. But you are right, we >> shouldn't add serious performance penalties to the code. And improving >> performance for the 25.1 release is much too late. > > It's hard for me to judge how serious those are, really (I only have a > fast laptop with GNU/Linux these days), but being wary of extra > process calls seems prudent. Ideally, we'd reduce their number, not > increase it. Yes. I hope we could use more file properties caches. To be investigated. >> So we might revert the patch for vc-state and vc-working-revision indeed >> for the emacs-25 branch, going back to using vc-backend. > > Thanks, I agree. I've committed this to emacs-25. Plus commenting the now failing checks in vc-tests.el. >> In the master branch we might apply my proposed patch using >> vc-registered or something similar, and start to improve performance. > > Improve how? Would you like to comment on the last paragraph of my > previous email in this subthread? You've proposed an interface change in vc-state, returning just nil instead of unregistered. Yes, this might be an option. Worth to be checked. Another possibility is to use cached properties more aggressively, as said above. > I don't really see a point in returning `unregistered' from > `vc-state'. When would the caller treat it differently from nil? And > returning nil seems like an easier choice, implementation-wise, and > well as a more conservative one from the backward compatibility > perspective. > > The `dir-status-files' backend command would continue including the > `unregistered' entries (we could make it skip the up-to-date ones, > though, in the interest of improving performance). I cannot comment about this today. And as said already several times, if we would document vc-* functions in the manual, it would allow us to have a more global view on proposed changes. I trust you that you have all involved interfaces in your mind. I haven't, and I would like to see how an interface change compares to the other interfaces. >> In >> parallel, we shall start to write a VCS section for the elisp manual, >> describing vc-* functionality in more detail. We could start with >> vc-backend and vc-responsible-backend and their intended use. I'm >> missing such documentation for years. > > I'd rather put the missing information into the docstrings, really. It > seems unlikely that we're missing more than a few sentences in these > two functions' descriptions, and we could also rephrase the existing > ones. > > But if you'd be more comfortable with having that information in the > manual as well, don't let me stop you. Maybe docstrings are already sufficient. But you have spoken about design decisions in the past (for example whether unregistered files could be an argument), which I believe is not documented. And at least for me the "global view" about vc-* functions is missing, and how they are related. >> I'll come back later today with the patch for emacs-25, if you agree. > > In any case, I definitely agree with reverting vc-state and > vc-working-revision to use vc-backend in Emacs 25.1. Yep. Pls test my patch, and confirm whether it is sufficient. Same for Glenn, if possible. I would like to close this bug then, removing a release blocker for Emacs 25.1. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 20:21:10 2016 Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 00:21:10 +0000 Received: from localhost ([127.0.0.1]:35809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqrVV-0006CA-P8 for submit@debbugs.gnu.org; Thu, 14 Apr 2016 20:21:09 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqrVT-0006BX-C0 for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 20:21:07 -0400 Received: by mail-wm0-f66.google.com with SMTP id a140so1950334wma.2 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 17:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=6h1BO+Ublm+bqDmO4u6xgTXYIXGvXDJxH2/Ewy5NlCI=; b=IB7Btu/NOrAzJrmBNSB3M2LdY4UyG9jq6U0KsHXwiZRQEOJPwE0nMb0FTEEzrZbqZ+ uvGIX0hpISMU1DkSJS/18tK6g2D7kQ46ZK2XUHO0Lr/5gIM4/IkIPBeHcLVqrPUUvTRj 89nBJR7Qx+1kje2Z5RQRMlpx5NbhajrZ37eImWQkVdphSrgGtDJsR9sV4dW+FBkutVDl 03ATMubIy53akBi78Qvu/5uq2cnAOlK+ksrmfI4NekJn+PBh83D0xD/J0/2sdzoUCoHE otR9pjH2rwZpU7BH+vB+lcI+qpBaIhSAV6ke+Sthq00fNd1YXnIVOXcTmK8NeU5NswRm Aq4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to; bh=6h1BO+Ublm+bqDmO4u6xgTXYIXGvXDJxH2/Ewy5NlCI=; b=OZALNI15q6rNO+NwgN+LehEY61On87c3SqytgwtD7vL+gi8kgBCzQYWxtz4KT7AjAQ HdMF5KbBfGWlu1+lOmQ8LUeabGr2S8ipKL0DR55BsjA0xBvk7P0DWCKegQA5X6WPldVk hJWpoIxiw7mwflJzQuxjJXRpRhVw48A49/vyI24h9v13YI37QLfD0EqJkKB3d5CpEZCr GYBoLo2lcoMEv74Wh7h8s23N55qWGqUTxZSBv7og63MX5xoOiU4ajDQAo6r4jZu5Dqy7 KA3O67tmoLcQaJpTdwhMUAwxKvt1V/ek8QtL2KfZ1YIyGPWLxgfwfpr+SJVleaAQ1K6j 6pVQ== X-Gm-Message-State: AOPr4FV8n9DMeXetRwp6YgKYQwIojZOJA+jLf6PuKQaUBoovne+UuJWD2BCOlBtqfgL5Vw== X-Received: by 10.194.103.198 with SMTP id fy6mr20933938wjb.48.1460679661775; Thu, 14 Apr 2016 17:21:01 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id j71sm8894218wmj.21.2016.04.14.17.20.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 17:21:00 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> From: Dmitry Gutov Message-ID: <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> Date: Fri, 15 Apr 2016 03:20:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87h9f4ghzg.fsf@gmx.de> Content-Type: multipart/mixed; boundary="------------225349C907F5DEDBA0E2C219" X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This is a multi-part message in MIME format. --------------225349C907F5DEDBA0E2C219 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 04/14/2016 09:31 PM, Michael Albinus wrote: > I've committed this to emacs-25. Plus commenting the now failing checks > in vc-tests.el. Thanks. Any objections to committing this follow-up patch? It makes the tests look a lot more meaningful, and it passes for all backends, AFAICT, but I don't have e.g. Monotone installed. --------------225349C907F5DEDBA0E2C219 Content-Type: text/x-patch; name="vc-tests.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="vc-tests.diff" diff --git a/test/automated/vc-tests.el b/test/automated/vc-tests.el index 5042196..f9c0ce1 100644 --- a/test/automated/vc-tests.el +++ b/test/automated/vc-tests.el @@ -205,12 +205,10 @@ vc-test--create-repo (defun vc-test--unregister-function (backend file) "Run the `vc-unregister' backend function. For backends which dont support it, `vc-not-supported' is signalled." - - (let ((symbol (intern (downcase (format "vc-%s-unregister" backend))))) - (if (functionp symbol) - (funcall symbol file) - ;; CVS, SVN, SCCS, SRC and Mtn are not supported. - (signal 'vc-not-supported (list 'unregister backend))))) + ;; CVS, SVN, SCCS, SRC and Mtn are not supported, and will signal + ;; `vc-not-supported'. + (vc-call-backend backend 'unregister file) + (vc-file-clearprops file)) (defun vc-test--register (backend) "Register and unregister a file." @@ -289,6 +287,9 @@ vc-test--state ;; added: Git ;; unregistered: CVS SCCS SRC ;; up-to-date: Bzr SVN + ;; FIXME: Delete this check. A directory does not have a + ;; state, only files inside of it have states, and there is no way + ;; to combine those states into a single value unambiguously. (message "vc-state1 %s" (vc-state default-directory)) ;;(should (eq (vc-state default-directory) ;;(vc-state default-directory backend))) @@ -305,7 +306,7 @@ vc-test--state (message "vc-state2 %s" (vc-state tmp-name)) ;;(should (eq (vc-state tmp-name) (vc-state tmp-name backend))) (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date))) + '(nil))) ;; Write a new file. Check state. (write-region "foo" nil tmp-name nil 'nomessage) @@ -317,19 +318,19 @@ vc-test--state (message "vc-state3 %s" (vc-state tmp-name)) ;;(should (eq (vc-state tmp-name) (vc-state tmp-name backend))) (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date))) + '(nil))) ;; Register a file. Check state. (vc-register - (list backend (list (file-name-nondirectory tmp-name)))) + (list backend (list tmp-name))) ;; added: Git Mtn ;; unregistered: Hg RCS SCCS SRC SVN ;; up-to-date: Bzr CVS (message "vc-state4 %s" (vc-state tmp-name)) - ;;(should (eq (vc-state tmp-name) (vc-state tmp-name backend))) + (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date))) + '(added up-to-date))) ;; Unregister the file. Check state. (condition-case nil @@ -343,7 +344,7 @@ vc-test--state (message "vc-state5 %s" (vc-state tmp-name)) ;;(should (eq (vc-state tmp-name) (vc-state tmp-name backend))) (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date)))) + '(nil unregistered)))) (vc-not-supported (message "vc-state5 unsupported"))))) ;; Save exit. --------------225349C907F5DEDBA0E2C219-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 20:33:45 2016 Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 00:33:45 +0000 Received: from localhost ([127.0.0.1]:35817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqrhh-0006VG-72 for submit@debbugs.gnu.org; Thu, 14 Apr 2016 20:33:45 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqrhf-0006V3-Dy for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 20:33:43 -0400 Received: by mail-wm0-f66.google.com with SMTP id n3so2004241wmn.1 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 17:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=9RATt6pxL+bi5Bsl/I2UzZgJQV5VzqKMM3fNUFt+/BA=; b=MrKUnPX5PyLAezaF2oxlkFunCcLdsLrwUEiFzBjb44WdPMTfGkci45Hw8gGyrWyvl+ twBzS2VwuIM/WTOPF+OpptT7pI/uaQA26ysN8mCtgAcOtDq+ub05muhrb0u+Z3XbWbCd IEKeEqce7Eswtu+no/xXz2TYfIDGHshI25IgCRpZnxWVvt2+j9GjajBYFv71lBoUO3YU StUcM4UfIsv2x62ZBR2REOXj3MZZDMYlGO7RFMTL7Io25Cmsuo9nqnRBUbrczs7P+/hR qDB9CxtV0/DV7wTos+BBY9VI/WOrOiZ4OCdmjZSXkd1NbuO60X+0DjmZl27t3DEIzVMh X8wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=9RATt6pxL+bi5Bsl/I2UzZgJQV5VzqKMM3fNUFt+/BA=; b=efJE+dupxScgPfmP4ggBHPqk/aageBLasJscVxoGD3ItR3EqanAxEUyNKUPnokKVLa eVPKSlsgLgFOjbYMMvbXxFXHxd7hZICZYtZpiKUxqjjBOpEDQErdYjJrIcAYP4yBl8D4 IuqSLMU0oWjS4VUmxO7Wg2xigZkAmp4RSfL8VoCjECGiaazebV6rDASFfb99xKTGS5Yz Wn99udYwFyQCM6YH39CqobJw4wGfXZRtZk23aHMapEEtmmbDrodNx4UF5Wy+jBEKnDr7 r/lqvEIMrfoRhms2Sg6oSOO0oGRw86zABpMpbdQ4kKEL1YSjgkj+tn8bzGJePzt7TWA8 TpqQ== X-Gm-Message-State: AOPr4FXiqozXECpGOs1hhNEBiGDtwzQ1EV6BajnoxhpdT9pc92oPOfJ3pf72qnZaFan2Kg== X-Received: by 10.194.90.229 with SMTP id bz5mr20073849wjb.143.1460680417929; Thu, 14 Apr 2016 17:33:37 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id dj8sm4925578wjc.28.2016.04.14.17.33.36 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 17:33:37 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> <87egacws5x.fsf@gmx.de> <87twj4hdim.fsf@gmx.de> <8a0a80ab-a299-814e-1e18-68ce6e74d9f9@yandex.ru> <87oa9cyzx2.fsf@gmx.de> From: Dmitry Gutov Message-ID: <24135d06-656d-3031-f782-1069ce279347@yandex.ru> Date: Fri, 15 Apr 2016 03:33:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87oa9cyzx2.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/14/2016 06:26 PM, Michael Albinus wrote: > But since ESRs rewrite in fall 2014, there are still several > inconsistencies. Do you mean any of the changes introduced in the rewrite? If so, which ones? > Eric confirmed that in an email to me. So it's not only > bug hunting, a systematic review of the state is needed. Sure, VC has problems, but (vc-state FILE) not always being equal to (vc-state FILE BACKEND) does not seem like the biggest one. It hasn't come up on my radar even once before. > I've started to write systematic tests (up to my limited knowledge), and > I've asked several times in emacs-devel ML for support, but nearly no > response. That's why I'm kinda frustrated. I remember. I'm here now, open to questions and dicussions. I'd like to avoid switching to master myself for the time being, though. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 21:01:12 2016 Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 01:01:12 +0000 Received: from localhost ([127.0.0.1]:35854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqs8G-00079w-8l for submit@debbugs.gnu.org; Thu, 14 Apr 2016 21:01:12 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqs8E-00079j-GR for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 21:01:10 -0400 Received: by mail-wm0-f65.google.com with SMTP id a140so2094738wma.2 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 18:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=05WwOc61BDv9/abL/1cDaZ3cFjxI38pUJS6o6/7BMik=; b=FSFgIrZ0av8Irt9xYIcjilvFGQUA94QgYyp5sfymtDLtcbSZAEvERBryTnQxoggzpo kWgrvxHNRKM6CmgYyVoOzpod8czW+nXph+IvvMdKILqTMXTMey20P37AVr0uoi19pSR8 8NUNJuZ3YENWBzMgAxm+ASjBj6+BTX65tH4t0lFmubRXMktslWETcl+u5hAUAsikGeJR pmPW8vxUD1DkrfoGf+USQDo2STM5nNciBzx8K6yO1jqQJgPWLS1SMpyWUvQPQ0qs6DPh RkPET/A8lGhC07eTdd8evqSqMjYzriLmdaUFctxFH4fr7BgAMFPsRpW2u/8NoWHQ5fA4 3QlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=05WwOc61BDv9/abL/1cDaZ3cFjxI38pUJS6o6/7BMik=; b=MeWYd3RXjk6dE/VKcGvu08HxZufRsDx1k1yHVM8axQBeDHHjI18/zAmvEHnqtX2lRW WGVly8BRpEYjN0X3kmxIgXVNQ3ihGaQvG8XKNgCkmxuE+xHpllg+iKr758gAZh5UFPfF fZROgg+7bJptcIoZpsQjh3C9A3RpAVMPouJ/uePxWhupTJWtBeJz3edPQFz8naewYEu0 49knJcrcP0BWgUHX71SZ6fsUeqZFGkkInRBUSaZCLKFsh9rpSFnhebt/DfsxBl70BM2K fd7giuB267N4V8IU3mkB9wFkeW5J9zS+E2w9aswAchs8KyxS3JSjo8z2khxbbMm1EMFR y1vg== X-Gm-Message-State: AOPr4FVHjuNSmCodtjaLOhRkemXREXX2qxct4RaNJHi/nNqTw58O/d/O7M6z5uRn7ch6Ag== X-Received: by 10.194.94.231 with SMTP id df7mr15460701wjb.10.1460682064808; Thu, 14 Apr 2016 18:01:04 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id lh1sm46425881wjb.20.2016.04.14.18.01.03 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 18:01:04 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Fri, 15 Apr 2016 04:01:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87h9f4ghzg.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/14/2016 09:31 PM, Michael Albinus wrote: > Yes. I hope we could use more file properties caches. To be investigated. OK, that could be a fine solution to the problem of vc-registered's slowness, but it adds complexity. So I'm still in favor of equating `unregistered' with nil, . > And as said already several times, if > we would document vc-* functions in the manual, it would allow us to > have a more global view on proposed changes. I disagree. The manual is the documentation for the users, to explain in depth, give examples, et cetera. The docstrings and VC's internal documentation have to stand on their own. It would be silly if the difference between `vc-backend' and `vc-responsible-backend' were to only be explained in the manual, but not in the docstrings. That would also be unfair to people such as myself who prefer to consult the latter. So, do you need anything from me in this area? E.g., feel free to give a list of docstrings that seem insufficient to you, together with what you feel they are missing. > I trust you that you have > all involved interfaces in your mind. I haven't, and I would like to see > how an interface change compares to the other interfaces. I don't really know everything about VC, I just have some recollections about dealing with it, as well as experience writing a third-party package depending on VC's API. To get an opinion about the current bug report, I still had to dig into the code and investigate, look at the commit history, search for call occurrences, etc. > But you have spoken about > design decisions in the past (for example whether unregistered files > could be an argument), which I believe is not documented. BTW, we've mentioned it before when fixing my old bug report about VC using too many process calls (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11757#77). It may not have even been a deliberate design decision, but it's the way `vc-state' is used. Which, in turn, allows backend implementations to be sloppy in the cases that are (almost?) never exercised. > And at least for me the "global view" about vc-* functions is missing, > and how they are related. I usually tease that kind of information out by reading the source code. Is there anything in particular I could help add to your understanding of the "global view"? > Yep. Pls test my patch, and confirm whether it is sufficient. Same for > Glenn, if possible. I would like to close this bug then, removing a > release blocker for Emacs 25.1. It must fix this bug, since it reverts to the old code, and testing Glenn's example from the description confirms as much. So I think it can be closed, and the discussion should move to emacs-devel. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 21:04:46 2016 Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 01:04:46 +0000 Received: from localhost ([127.0.0.1]:35871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqsBi-0007Fs-B6 for submit@debbugs.gnu.org; Thu, 14 Apr 2016 21:04:46 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqsBg-0007Fe-Sa for 20637@debbugs.gnu.org; Thu, 14 Apr 2016 21:04:45 -0400 Received: by mail-wm0-f66.google.com with SMTP id y144so2113716wmd.0 for <20637@debbugs.gnu.org>; Thu, 14 Apr 2016 18:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=JtNxmsE92f9iF7p5D8QkFH4ssXSNMSD3SwrVQO3Wyew=; b=rafpBVavS/Gc6VOvvwslUjROjAVrT0xmFLZlBQt2occzsO4ge3n3bQTOJCXoch2R7L RkqgL/5UZx8enZmbm/9RWdDNrfle1kjmwUBwuil0qp/BHLv7u2omwUfFrgVoptS0EVMN 07c4ncihH1vettoqqTH8eFGpmboCNuKiLRfHxlC9RiGJ/VKuOzoavZTIElLKkyUDAUo9 kxb6pXBnti9KEsg3qsMQSlIAl7MG1VtnGsb4x78Rnfo7QrcmqoBmvCJ2WzANseG/z6fi dYxRYPgb2kjQ30206Z8Q9JlEKBxUj0ieKi4D7o/Bq1Rt5PwVdT6DU/H5MedLkTKE+Uub /7MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=JtNxmsE92f9iF7p5D8QkFH4ssXSNMSD3SwrVQO3Wyew=; b=W8v0BbQpWpdf+x4vQlQz/VUcxv6hGrreYI0NMCzHO0d0gwpUiHE86PYcrXbWNDPTdp fIncoYqD0Q4lhmubuy+jlWITn70gdiYL0NkvZi6VIcHhgpKa9MBDLhNkmCXBXeRV/uLl 41E3pAqiNhhHdEGy7OJWnX0nGHe0lQD/AG/Xx6lI5hT8k7N3P3tzC5mre3W3xAx1nw2Q YlrUv3ERAxyj8h4Ms2tC/bREvDWVInob8rubqTbA65Q7Q39f5r4y0RAOMVWQlkl+ZivA ky7pdW2Av0J0rSBZdcXLiBKmcAP2X2URr2kyZj8XagiZiO5RGfjDqez/mnjLEW5jX9j7 60Eg== X-Gm-Message-State: AOPr4FWOxpBhC9+pO54fcPa6HZJZ6IDTpd/6jLPWYcW73R9gCtWnrZg9BEmwwHSkRnPieA== X-Received: by 10.194.90.3 with SMTP id bs3mr19023050wjb.105.1460682279520; Thu, 14 Apr 2016 18:04:39 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id w79sm34892521wme.19.2016.04.14.18.04.38 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Apr 2016 18:04:38 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> From: Dmitry Gutov Message-ID: <53c2b0f3-822a-8ed3-b852-6b6a7c35390d@yandex.ru> Date: Fri, 15 Apr 2016 04:04:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/15/2016 04:01 AM, Dmitry Gutov wrote: > So I'm still in favor of equating > `unregistered' with nil, . ...pending further arguments in favor of the other solution. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 15 09:11:24 2016 Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 13:11:24 +0000 Received: from localhost ([127.0.0.1]:36372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3Wu-0000iZ-Ii for submit@debbugs.gnu.org; Fri, 15 Apr 2016 09:11:24 -0400 Received: from mout.gmx.net ([212.227.15.18]:55629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3Ws-0000iL-EG for 20637@debbugs.gnu.org; Fri, 15 Apr 2016 09:11:23 -0400 Received: from detlef.gmx.de ([87.146.62.238]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MOfx8-1aoKV33i6A-0064lc; Fri, 15 Apr 2016 15:11:16 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> Date: Fri, 15 Apr 2016 15:11:14 +0200 In-Reply-To: <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> (Dmitry Gutov's message of "Fri, 15 Apr 2016 03:20:59 +0300") Message-ID: <87bn5bc8zx.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:WgK4RswIrb3VCGSQdgo0dQ0eqaFcfuiNtMN/nnpaNIwPgaDajbA nqqiiKnCrddICXXutzvs1j9ioSzHwbMsTGMD+lemEwP+fYL8tvcxvmOA4ro7Pi/qQialmqP wz5dnxTFqX3l6/vN+ltVyJ8/E1yDZHOdmqrQyrDon9DZh/+C4Zxg4LPa8kFyBtMM3l812Vk fhzTb1dTWa9wbEKX0cqww== X-UI-Out-Filterresults: notjunk:1;V01:K0:Q0L4ts7M/DA=:tI4RZKQAqw4sORV5z+Ek6f dbpdI3XJ99jN8whmnSZpgjv40ZWNp9OixNM4XbaSr1YOpbxn25eyJKoPn03suZJ4f8uS8YbzA i0Fjl4hLQ+vrUG/eO3K/1lxEnnR4CNkcvPSwcJJbT+4sNR8m63U4So71ue80LwqRKB6CS7v3c u5OtWzWOFLcrk3EX+G2Z1oqF8svJq09271fGYmcnF5alI+9h8fGC3AupnS83UKr48uX+rtLsW UoAlLDF9aETN1nTxNRqqoB/mjaLn1Dhj+btCXUpmD1FVFqNaiQks46zWeFeq7a/7g4b8b2JB7 hQvsrcEfjbmM/RBHYIesKZfs/P2G7T0agQYGMxr8ROUdYXLUYeWBfA2MAL6KF02/818+wnXmd BFnC7kSPFtxUpbu9JyJdKQui+X1W/CauVrJHRBsvhuxz5VzG9Fdm/K1RfGvgQ/oNZqbyu8jo/ bwUk0OQn0HLdq0ADkrZpzWIF6S7MY7HBBUV46fpMbcQT7Zq924sVzJuiTZeFFRU0PLfGi0FX3 QIuk4EhDyypD7sVPqAJyFVXIq9qyXOTWC7FSu4veMN1nkojCmeUxeZJPwjovRq3Q3e+EBayrS kxA0ziuydlRQlKtFSligo6yVx+nYH3dEaB8OjuYGrd/l/NUoO4/DrT0xNTsNU//q9nLeyZYsK Gjy254pfkWx7ELOM9A/YSQ2N3eychMTTecx49tx9JfDX5MWwBqKcOROtpgn+Wa9LAyjplouqW nKpVtBTMSLY/+Q1snxLMDCLOazmV0YpBE6UmjbpMLtZkupP/lOuw64xF4SvYvNgqyxT6WkDJY /Q9q/mt X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > Thanks. Any objections to committing this follow-up patch? > > It makes the tests look a lot more meaningful, and it passes for all > backends, AFAICT, but I don't have e.g. Monotone installed. I would prefer to apply further patches to the master branch only. Only patches absolutely necessary for fixing problems shall go to the emacs-25 branch, in order not to threaten the release. After applying your patch, vc-tests.el fails for me in vc-test-src02-state and vc-test-rcs03-working-revision. > @@ -205,12 +205,10 @@ vc-test--create-repo > (defun vc-test--unregister-function (backend file) > "Run the `vc-unregister' backend function. > For backends which dont support it, `vc-not-supported' is signalled." > - > - (let ((symbol (intern (downcase (format "vc-%s-unregister" backend))))) > - (if (functionp symbol) > - (funcall symbol file) > - ;; CVS, SVN, SCCS, SRC and Mtn are not supported. > - (signal 'vc-not-supported (list 'unregister backend))))) > + ;; CVS, SVN, SCCS, SRC and Mtn are not supported, and will signal > + ;; `vc-not-supported'. > + (vc-call-backend backend 'unregister file) > + (vc-file-clearprops file)) As said, in the master branch I would prefer to add a vc-unregister function. Then we won't need this anymore. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 15 09:13:10 2016 Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 13:13:10 +0000 Received: from localhost ([127.0.0.1]:36377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3Yb-0000lB-U1 for submit@debbugs.gnu.org; Fri, 15 Apr 2016 09:13:10 -0400 Received: from mout.gmx.net ([212.227.15.19]:49900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3Ya-0000kz-1r for 20637@debbugs.gnu.org; Fri, 15 Apr 2016 09:13:08 -0400 Received: from detlef.gmx.de ([87.146.62.238]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MUYnD-1bIBC91bed-00RLRr; Fri, 15 Apr 2016 15:13:02 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87mvphnoei.fsf@gmx.de> <874mbawp84.fsf@gmx.de> <878u0llwq6.fsf@gmx.de> <0455367c-8ece-3520-a79e-6b08110e8108@yandex.ru> <87potxwd1u.fsf@gmx.de> <87egacws5x.fsf@gmx.de> <87twj4hdim.fsf@gmx.de> <8a0a80ab-a299-814e-1e18-68ce6e74d9f9@yandex.ru> <87oa9cyzx2.fsf@gmx.de> <24135d06-656d-3031-f782-1069ce279347@yandex.ru> Date: Fri, 15 Apr 2016 15:13:01 +0200 In-Reply-To: <24135d06-656d-3031-f782-1069ce279347@yandex.ru> (Dmitry Gutov's message of "Fri, 15 Apr 2016 03:33:35 +0300") Message-ID: <877ffzc8wy.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:9eWWRRROr3tpH68UTr+C0Eh+7P8B8qT0ugj5g7JBmZ/cNHpVn+u DKzxUaG+Mhopiehex9zaQYy2rKOaB4Snmi02NplsuVcNwe9sx3H8p2Vfmmen524r9q2hHyx VGZxh8f4UOb1InhWt5rwpnsAL1s95RIelzbD7ZyvAO46W7nScArS0A+XWLohP8VsJAYjlD+ MZ3wKDRIjbf/kXZ+P+2dg== X-UI-Out-Filterresults: notjunk:1;V01:K0:/TEGCynkjQQ=:MuNkm0RZFo+pn/yepcMCKX 6hXmG8kD10tjpCwwtfJSlRTxZaatzpFXAtD9TE6yDAe4L4VapXkdNSNuVwMVH34+T5QSzEGcl uqaE0lPiQ+P6sjrn/b6tPPcu1SKjROFc6A3+Lrk4cLCEN5W9oABfings92NYNwIfWPCw/oY8U d4LHj6tmhaQv5EZgSjkXkKXeeZfLdzqR6b8F6q5LnhkGH07qaZsEv+D7gVIepWzSdRgTquQcm IttponIQaJVSHFEbkhLfEM2fyzl42lrJHGJtea6bV3wcNCYOU6wqOyd9QITTiJ4dOVY7dTyFJ 1GuyEV4KrBmAHhNHW2XgNMM2yMkNICp2QZdEjI4OhlVekXCKCPTSY3PPeDmxTjeW2xN7LrXpK p5eCRfsnlrjs4RWzqsmt5kz6Fnf5wTG7QrKJhfGyyVZToMdr41O5IUuXSD07bxcu8QR6R5mw8 FiKkZrCMGr0UokjlgTsf4Ap8HDHqJSMXaBanKWaaxr28FYvv5c3sc9omRH0jWXOycLdICYgOD F7FogiYGMMSxWD61nHNPtl8u3TgkccMMEmOOb1sVuJ/oZS1FNZEdNxClLqevcSwXGh0Uulghh BxhsqDZlF3Y6L6RSVFTJu1Zk2noAPtoMPaxV2agoQVfXCZEm0p4vo5XRz8R/LEX7U1X/y7bNj Y/vYLWsbE/Z0qY5E0sc4qyOEfKHFkxo623Iv/RYFGisvw0fAtG/DSgZu3o2WgH9bGHFpmQCHb OyT3m1xLF0XDyZKTSlfm7IAMnXlT5nwtEo9DDYnvlmfj1kLaruFt/4FmdkxzH9ZegSJiEsrLj xDuwURn X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: >> I've started to write systematic tests (up to my limited knowledge), and >> I've asked several times in emacs-devel ML for support, but nearly no >> response. That's why I'm kinda frustrated. > > I remember. I'm here now, open to questions and dicussions. I'd like > to avoid switching to master myself for the time being, though. I have installed both versions in parallel on my laptop. No need to switch, therefore :-) Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 15 09:24:09 2016 Received: (at 20637) by debbugs.gnu.org; 15 Apr 2016 13:24:09 +0000 Received: from localhost ([127.0.0.1]:36386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3jF-00011G-6A for submit@debbugs.gnu.org; Fri, 15 Apr 2016 09:24:09 -0400 Received: from mout.gmx.net ([212.227.17.21]:55085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ar3jD-000112-K1 for 20637@debbugs.gnu.org; Fri, 15 Apr 2016 09:24:08 -0400 Received: from detlef.gmx.de ([87.146.62.238]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Lyi0B-1bnxSh3ikx-016APw; Fri, 15 Apr 2016 15:24:01 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> Date: Fri, 15 Apr 2016 15:23:58 +0200 In-Reply-To: (Dmitry Gutov's message of "Fri, 15 Apr 2016 04:01:02 +0300") Message-ID: <8737qnc8ep.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:9QHMAT1qm2BmUcZWyumwZRSlggmDnslHMAsVLfwdg4RUgtwbfuZ PjsL823/tue5PzAmpMFaekJkP1XXErJPR/fPvUQCbSB0VPCQq3581OdyRNmq0OqP3bNfECr 816K2m5VJgl73SBDJINB2/W4ALcYHA69UsYQTf2kOSz2JTnFFoSsHEVEn5GPYRbO/eyHJm+ kTsJk4H70upmfaAHl3w3A== X-UI-Out-Filterresults: notjunk:1;V01:K0:FUglgUxaweg=:v1do8UNJOvFdZHoMAznWQe Jc6BfCIU6pWmlWs6l4s7SdkaVjPN2vTmdk4XUbFpz6Fx5fnx1LOBQO2JtsHdQiqR8FZZaDzFx FKgmMZL7sRQ8GdxOfYXdhKxnU5l/VU/l6RsYDjqnaz+MQ1uUCdSE52w61GzSwIrspwuOFW3uN 2QlduwBDvu3LNRYe804ueP4p7MqHeG+Puaeypq0+OQ/k78NzHowlIBHdJ3HZb+jLp/rcujLz4 ccAxqhB4mJPO/J+idth2m0KDs4jzhIllM3RFnGbji9YNkkIi4985zM7T4z3MORLCP8CT8xb0p 6VpvBJYuP19R39ypjZp99Kh6BlV3SWpGEJAAY0UKeyJRezs23aG94Z6p+NFaFnnS768T5KtXs 32+rWfMq4RNyqWTYOPj9EWLggo7C0ZbnrkC4GU8dstgxJi+p+TxBhTJ2qKxoRQfZYrkIrTEGI 7O13dHaaCHroAgkAgLd08oYqjn0V0RzjZR4HlPnXRXMTQuCmenyOnn2xFMO16NbOt4GkpaaPZ 5Njh9g+UXGuts48WvYs3thyjXSFy9sevtQzDqpg4KF8xpnkFkA/5DuMKw9Arcst6E8EyCxJM9 rHGE0b5G1K77LSzCeUK+wr2flc/QZuu3Yz8ZTLPHTTqrw7bMkggNEFVYizh0yOfzByuxXzL5F asqYeSfrzR/jvXRWc/onvOohmOkNnm1+OS5V8Pgf8KLg0En6Ek0TerN+ezD3mFLZzfyI/LLW8 +Y/vSq4K5Sbz4ZeD61lB8vg6IQTEw4gvpR05GdpbguK2ycSInbaxWa23dTO6I4kYDGTnY5aUg UZ1ZV4b X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > On 04/14/2016 09:31 PM, Michael Albinus wrote: > >> Yes. I hope we could use more file properties caches. To be investigated. > > OK, that could be a fine solution to the problem of vc-registered's > slowness, but it adds complexity. So I'm still in favor of equating > `unregistered' with nil, . I'm not against this. But I would like to see the whole picture first. Where else unregistered is used, and whether we run into conflicts when using nil instead of unregistered. >> And as said already several times, if >> we would document vc-* functions in the manual, it would allow us to >> have a more global view on proposed changes. > > I disagree. The manual is the documentation for the users, to explain > in depth, give examples, et cetera. The docstrings and VC's internal > documentation have to stand on their own. It would be silly if the > difference between `vc-backend' and `vc-responsible-backend' were to > only be explained in the manual, but not in the docstrings. Are we speaking about different manuals? I'm speaking about the =E2=80=98GNU Emacs Lisp Reference Manual=E2=80=99, and not the =E2=80=98GNU Emacs Manual= =E2=80=99 (the manual dedicated to users). > That would also be unfair to people such as myself who prefer to > consult the latter. With your argument, we could nuke the Emacs Lisp manual. Shall we? > So, do you need anything from me in this area? E.g., feel free to give > a list of docstrings that seem insufficient to you, together with what > you feel they are missing. I will start somehow, and show you for review. >> I trust you that you have all involved interfaces in your mind. I >> haven't, and I would like to see how an interface change compares to >> the other interfaces. > > I don't really know everything about VC, I just have some > recollections about dealing with it, as well as experience writing a > third-party package depending on VC's API. > > To get an opinion about the current bug report, I still had to dig > into the code and investigate, look at the commit history, search for > call occurrences, etc. My first sentence above is a rhetorical one, of course :-) >> But you have spoken about >> design decisions in the past (for example whether unregistered files >> could be an argument), which I believe is not documented. > > BTW, we've mentioned it before when fixing my old bug report about VC > using too many process calls > (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11757#77). Yes, but that's not the documentation! I'm pretty good in forgetting everything, and I don't remember what was said in message 77 of bug report 11757, months ago ... > It may not have even been a deliberate design decision, but it's the > way `vc-state' is used. Which, in turn, allows backend implementations > to be sloppy in the cases that are (almost?) never exercised. > >> And at least for me the "global view" about vc-* functions is missing, >> and how they are related. > > I usually tease that kind of information out by reading the source > code. Is there anything in particular I could help add to your > understanding of the "global view"? Even if I understand it, it won't help any other developer. Let's document it. >> Yep. Pls test my patch, and confirm whether it is sufficient. Same for >> Glenn, if possible. I would like to close this bug then, removing a >> release blocker for Emacs 25.1. > > It must fix this bug, since it reverts to the old code, and testing > Glenn's example from the description confirms as much. > > So I think it can be closed, and the discussion should move to emacs-deve= l. OK, I'm waiting for some few days (maybe Glenn want to say something about), and then I'll close this bug. Thanks for all your help this way! Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 16 20:27:48 2016 Received: (at 20637) by debbugs.gnu.org; 17 Apr 2016 00:27:48 +0000 Received: from localhost ([127.0.0.1]:37684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1araZ1-0002dJ-Sn for submit@debbugs.gnu.org; Sat, 16 Apr 2016 20:27:48 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1araZ0-0002d4-B6 for 20637@debbugs.gnu.org; Sat, 16 Apr 2016 20:27:46 -0400 Received: by mail-wm0-f65.google.com with SMTP id a140so15153295wma.2 for <20637@debbugs.gnu.org>; Sat, 16 Apr 2016 17:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=GzligXrMl1A+7+VMab6YxP2Oxdc1hKrqCrdg3H20uvA=; b=YLSL/ekPzpWonX2zrTyHpHSKRmQTus5oufmYJDFo0XDc5wF9LedNBObW/kgNTLRr6G A6McPnCERSG9pEYh+9n2J4/NCuEPh7L14yE3eZ6PouCUZ8emWoN0qsQjSXnn1Cx4guLk oIh0BfR4F0sJIwLs2GIP0y6509Z6Ehhit3WxLjD2Kiuku4fd+aMBBfHrLTuyKpKhD3I+ AXNMS7XJ/4NaQfvGNWpLYvEl80J2mNMooR98A1AXAKzvDkcomoCYfNc9CPqu+lJjDQJy 7dronsiq6Wr4HPrB/GvwR+0agoXYGfbKQcUWAQMBh0gbcqwsX42cI3dnpJfhydR5FKtr qusg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=GzligXrMl1A+7+VMab6YxP2Oxdc1hKrqCrdg3H20uvA=; b=RKXkZV1+E1tjpWWlBd4ALsw4kBQ6wQnYi4Hw/SLSB4WYW6tA7dSEg2b88IdHP/YdmO mS8iF+qOOu96FGuZjweawL4DViDhydFwyjE0hUjFZQMk10k4h3UJ6YfD5lzUYjZytgd9 lhjSj23SNDUj48CbWgi9s4ujYxJ9HqRLS4y8uq7RgPFSWx+wIM3UROmmuE10Z7EYw4+7 CYf+OsQdUuwGgobKpM235ZYT0mYph044qbT/dTPKM3nFNolDZx2YFY9wkntRSB+znh6P xUdtX/Il3UHzs4J6GlRLn9Qk3w4hZWJ4mw+lzFP7FwCY30/fAuXvAd+CrXuXLor1/0pd bZTA== X-Gm-Message-State: AOPr4FX4OtNhtkzprFAdlEq7QyNoq+iNX8/bftLHkE5BWaudLI8sgx3siavoNS/KTfrDSg== X-Received: by 10.194.92.237 with SMTP id cp13mr28995302wjb.168.1460852860765; Sat, 16 Apr 2016 17:27:40 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id j71sm18981817wmj.21.2016.04.16.17.27.39 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 16 Apr 2016 17:27:40 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <8737qnc8ep.fsf@gmx.de> From: Dmitry Gutov Message-ID: <2735212c-3852-ee0b-2080-d5ea33af49f9@yandex.ru> Date: Sun, 17 Apr 2016 03:27:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <8737qnc8ep.fsf@gmx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/15/2016 04:23 PM, Michael Albinus wrote: > I'm not against this. But I would like to see the whole picture > first. Where else unregistered is used, and whether we run into > conflicts when using nil instead of unregistered. Sure. I'm reasonably confident, but please take the time and do your own evaluation. >> I disagree. The manual is the documentation for the users, to explain >> in depth, give examples, et cetera. The docstrings and VC's internal >> documentation have to stand on their own. It would be silly if the >> difference between `vc-backend' and `vc-responsible-backend' were to >> only be explained in the manual, but not in the docstrings. > > Are we speaking about different manuals? I'm speaking about the ‘GNU > Emacs Lisp Reference Manual’, and not the ‘GNU Emacs Manual’ (the manual > dedicated to users). I've split off a tangent to emacs-devel. Emacs Lisp Reference is a counter-example, but I think the last sentence in my paragraph above is still correct. VC has been documented in the docstrings and the Commentary sections (especially the one at the begining of vc.el). The new important information should go there first. If then you'd like to create a manual based on that information, to present it in more digestible form, sure, but let's not put anything essential into the manual only. We might avoid publishing that manual, though, until we're sure that VC is rock-solid to build third-party code on. >> That would also be unfair to people such as myself who prefer to >> consult the latter. > > With your argument, we could nuke the Emacs Lisp manual. Shall we? Does your argument allow nuking all docstrings and comments? >> So, do you need anything from me in this area? E.g., feel free to give >> a list of docstrings that seem insufficient to you, together with what >> you feel they are missing. > > I will start somehow, and show you for review. Thanks. >> I usually tease that kind of information out by reading the source >> code. Is there anything in particular I could help add to your >> understanding of the "global view"? > > Even if I understand it, it won't help any other developer. Let's > document it. Sure. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 16 20:44:58 2016 Received: (at 20637) by debbugs.gnu.org; 17 Apr 2016 00:44:58 +0000 Received: from localhost ([127.0.0.1]:37688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arape-00031j-DV for submit@debbugs.gnu.org; Sat, 16 Apr 2016 20:44:58 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1arapc-00031V-Gb for 20637@debbugs.gnu.org; Sat, 16 Apr 2016 20:44:56 -0400 Received: by mail-wm0-f65.google.com with SMTP id l6so15180634wml.3 for <20637@debbugs.gnu.org>; Sat, 16 Apr 2016 17:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=jY9OKzR2rnnH05rvwF2bi1eeflQEsB1gFPfoxUeNhPc=; b=J1C2J34cI+15H7sWJca8TyiHGOiwIvtoz98T4xscU/NAqX5mtjimAle2ZBp2cfcOqJ BtePmvkL3W0Fae0AgqIxHTRRuVGfxKWPI0fTNoHYCOy/4r5WjB4hbFmiuInxEFzw59Ld qCpj2EdRK6zJMu32Wa2pTUkqkIlSro64UyPqQihh98IRXSQncbX1vC2gDQ95IMFfO1MD OQJM+N2nS/ASqn7IcNR2fCRXdMepZZJMyeQOKgwoUqr2Kd3P/+KSdtuVK0vnVlE/zjY4 J9hCWy1CIWV3Vgm5Q1k4QdcmcQXb64YItnN2VXOgeioQm+DLEQKv1gmkvHE0Uapn2goJ A+jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=jY9OKzR2rnnH05rvwF2bi1eeflQEsB1gFPfoxUeNhPc=; b=g9Vc/qjjr3qydg3t1j7ndPsWMd7FDA4HHqy2JV33b9jGvSjKkkfwaTUSg/ku/uUSpH rP2/869AdbF7o77l4tM7zoJTKPIfQBShQT2fwrvRfXUEzGS+sb6KKz5TRFNwCSAD4EC1 0F7ZJGcuGtz174Q+GsUaR+3kI3yhnown+p0D7jr3/ju7czs0rz1kmUgjt+9a4waTlVDs 899Q/gRGXt2V6Mh8oGngM0oHOJ78Kp86FE0YXRvhKqW5hthrPELZ66NzXOPYSkyMW19s ssWygYH3WxWwePels6KSS144rE8tk6bAG+LHDd1BoTn3LPYDV924QuDjoBVoHurZbKDj nCVQ== X-Gm-Message-State: AOPr4FWo/lNXw+k8Bcs/jChR5TLEpWmsHB1NtJYEzcxaRkJdnGaWGkRldZdrWjmqp9+Wrg== X-Received: by 10.28.1.85 with SMTP id 82mr11686080wmb.58.1460853890933; Sat, 16 Apr 2016 17:44:50 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id ux5sm56398706wjc.17.2016.04.16.17.44.49 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 16 Apr 2016 17:44:50 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> <87bn5bc8zx.fsf@gmx.de> From: Dmitry Gutov Message-ID: <379100ae-4aa7-5ecd-70a7-4dcc4878ccd2@yandex.ru> Date: Sun, 17 Apr 2016 03:44:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87bn5bc8zx.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/15/2016 04:11 PM, Michael Albinus wrote: > I would prefer to apply further patches to the master branch only. Only > patches absolutely necessary for fixing problems shall go to the > emacs-25 branch, in order not to threaten the release. I can do that. > After applying your patch, vc-tests.el fails for me in vc-test-src02-state How do you install src? Do you build it from source? > and vc-test-rcs03-working-revision. This one (failure in vc-checkout-model5) seems to be a real bug uncovered by using vc-file-clearprops. I suppose we should add a FIXME there and skip that check for RCS. >> - (let ((symbol (intern (downcase (format "vc-%s-unregister" backend))))) >> - (if (functionp symbol) >> - (funcall symbol file) >> - ;; CVS, SVN, SCCS, SRC and Mtn are not supported. >> - (signal 'vc-not-supported (list 'unregister backend))))) >> + ;; CVS, SVN, SCCS, SRC and Mtn are not supported, and will signal >> + ;; `vc-not-supported'. >> + (vc-call-backend backend 'unregister file) >> + (vc-file-clearprops file)) > > As said, in the master branch I would prefer to add a vc-unregister > function. Then we won't need this anymore. We'll need this code either way. Where the function resides and how it is called is less important to me. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 21:33:48 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 01:33:48 +0000 Received: from localhost ([127.0.0.1]:38748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ary4S-00013v-7X for submit@debbugs.gnu.org; Sun, 17 Apr 2016 21:33:48 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ary4Q-00013g-ST for 20637@debbugs.gnu.org; Sun, 17 Apr 2016 21:33:47 -0400 Received: by mail-wm0-f66.google.com with SMTP id n3so20706649wmn.1 for <20637@debbugs.gnu.org>; Sun, 17 Apr 2016 18:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=X1nTP3yKZS2sJJ/YvVzZO0P3Ly5GgH6VZGwkct6A9XY=; b=FhcazFAERS7arfXOFHy6Czk4yF+gVdP77ThaVMhZggEcY2bJhICSlDgcLixkbHO76K mTz+Yq7gkeGWSUObLOTOc98RkHKkdXl2pWkh0qmjD7dRvxlD7FQPS7A6XMn1CMXDiMJk FoVE6HE2o2XG2rwxm6XFyYvcfkIdDyhxkArQ8uYxoM+LbgF2UmyGTCFZlBuPJ2yHm59u Hmc1ItKtJQGg1HP9nZKKZnlprPqMXFV4Fz18ll/G15xug83CmU7Ko2bkqwJ4JMlJ/HCB CI1DGmLT9oBQfoCsMashWLkv9czDdwzZjVB7Nz05b05o4jHaW+K0EoBzSc1+F+fIRIb4 Ev5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=X1nTP3yKZS2sJJ/YvVzZO0P3Ly5GgH6VZGwkct6A9XY=; b=ZwPkYc3QCaI0mKfBZu+8ue3EZAT1a52jgcfsnljySJjvThNxAh1w9GXILOtVgyZoAK i6FLRRwQxXcHq1+rfgiiozkWUvjLjEF0UXIwOa7pJfI/9G++ONPp1R/K/1fGJvfTExg7 bu1+Mm9LJjBqcIe3jUjgAPJZwmPSyqtSPOrhLDgFNWmVaLazWKSDiCIzr8O3U+mdSwMT oG+HjdiUAA4D5O9+NZMZEnNCoA+Ysrb6RiVfMh2ylbxnoOBr9mu0JfMJvqnbj1bHzciE WIzO8W3LG4eOSe70m6/mBp1TIqmRQctoupOYhVDKfJ1MPInhhRMyeYGUf1Hr8g8K1dAL pZUQ== X-Gm-Message-State: AOPr4FXNWUBEaerRLFAZiCuWwqkAHUxq+ev8RQzeXZYo09ZcKpasWMXSRcQbYJ0Li4ZrtQ== X-Received: by 10.28.154.204 with SMTP id c195mr16036005wme.49.1460943221200; Sun, 17 Apr 2016 18:33:41 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id q77sm20482891wmd.12.2016.04.17.18.33.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 17 Apr 2016 18:33:40 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> From: Dmitry Gutov Message-ID: Date: Mon, 18 Apr 2016 04:33:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87h9f4ghzg.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/14/2016 09:31 PM, Michael Albinus wrote: > I've committed this to emacs-25. Plus commenting the now failing checks > in vc-tests.el. We should also consider reverting the changes to vc-rcs-unregister and vc-sccs-working-revision. They don't seem particularly necessary (the tests pass without them). From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 17 21:40:37 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 01:40:37 +0000 Received: from localhost ([127.0.0.1]:38753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aryB2-0001DV-VI for submit@debbugs.gnu.org; Sun, 17 Apr 2016 21:40:37 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aryB1-0001DI-8q for 20637@debbugs.gnu.org; Sun, 17 Apr 2016 21:40:35 -0400 Received: by mail-wm0-f67.google.com with SMTP id n3so20726609wmn.1 for <20637@debbugs.gnu.org>; Sun, 17 Apr 2016 18:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=elLPa/5s4RNA5UO0v+yWcM2RQWLhzmrArKiTzmKRHJQ=; b=SrnlCHaNbYpUbiq00ScYhijQkXStPsIHst2NmOLG+P2E1FU4GQ7YlxUVBZ5MCfwSRo Agjn6lZ8LBvtLc757L5Y+8giPsrJK967PmLdLxTA17Fqfd1UmbH5gJZrZnpNHZXMej8/ 8xZ5KIPDjFPXNiSmIujeszdiqW1M7H7akycDtND+jUDqOXK3Duvn0WfYZ65el3mEgz0e 9+r5eVC187CBixYvDdH0ce2k1WmDFxbDKYoy3JQajuJub+8OA6eItEWUoCrcyVT6kDCF XDErFdul5wDVDO4pvUvkHUgEinPS7MdMVtAbkw/vwj6/6PGwjfPjTthlD54B2wK7/Mkk FyWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to; bh=elLPa/5s4RNA5UO0v+yWcM2RQWLhzmrArKiTzmKRHJQ=; b=NYxFz14fCLOFqBWOXCC1lKspeJNwcdkzQbHrHfuQyVKi+vspNJgWuHwsSmMWhmbgUq zsxu45Gkh2zzYa64pxVbJQyXdya5fE0UIDsS2OAvLjFjkzhJ35azdUK0vvQHl3d4KtWb VS6a/x+s+knx5Fpmwa7zssOJiPRtt/vhZUUDjTtLMYVnA3fzSs05CygflJz8mzs+xJ6R /a7xL/FyDbXYwUBKcH6EJgvfN+xknrgd/UPKDaO4mNDKqfcmEf2etFDqSSrrObGuaFG2 jJlicFiGMApOVCzCi97MlIingXKI9fQiPZ/mwiCSv5JBUl9NdaJzqDNIqavMqInGYK8t zk7g== X-Gm-Message-State: AOPr4FVzgaIbNOktT35MAZKrUOX4ZeG548D8VKoQy0831k3xsDTDfDNjBVYk/L1rJw6+vA== X-Received: by 10.194.93.2 with SMTP id cq2mr7119833wjb.151.1460943629739; Sun, 17 Apr 2016 18:40:29 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id j10sm61504660wjb.46.2016.04.17.18.40.28 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 17 Apr 2016 18:40:29 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> <87bn5bc8zx.fsf@gmx.de> From: Dmitry Gutov Message-ID: <41a4e458-fa51-58ed-6b82-bb2a26742717@yandex.ru> Date: Mon, 18 Apr 2016 04:40:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87bn5bc8zx.fsf@gmx.de> Content-Type: multipart/mixed; boundary="------------DB0FE32629F9B3356DF597B5" X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This is a multi-part message in MIME format. --------------DB0FE32629F9B3356DF597B5 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 04/15/2016 04:11 PM, Michael Albinus wrote: > I would prefer to apply further patches to the master branch only. Only > patches absolutely necessary for fixing problems shall go to the > emacs-25 branch, in order not to threaten the release. > > After applying your patch, vc-tests.el fails for me in vc-test-src02-state > and vc-test-rcs03-working-revision. Here's the patch against master. The latter one doesn't fail there. Could you handle the SRC test failure yourself? Either by fixing the relevant code, or by simply exempting SRC from the relevant check. --------------DB0FE32629F9B3356DF597B5 Content-Type: text/x-patch; name="vc-backend-and-vc-tests.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="vc-backend-and-vc-tests.diff" diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 4c0161d..43cbb3f 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -476,7 +476,7 @@ vc-state ;; - `copied' and `moved' (might be handled by `removed' and `added') (or (vc-file-getprop file 'vc-state) (when (> (length file) 0) ;Why?? --Stef - (setq backend (or backend (vc-responsible-backend file))) + (setq backend (or backend (vc-backend file))) (when backend (vc-state-refresh file backend))))) @@ -495,7 +495,7 @@ vc-working-revision If FILE is not registered, this function always returns nil." (or (vc-file-getprop file 'vc-working-revision) (progn - (setq backend (or backend (vc-responsible-backend file))) + (setq backend (or backend (vc-backend file))) (when backend (vc-file-setprop file 'vc-working-revision (vc-call-backend backend 'working-revision file)))))) diff --git a/test/lisp/vc/vc-tests.el b/test/lisp/vc/vc-tests.el index 2b3445a..cabd560 100644 --- a/test/lisp/vc/vc-tests.el +++ b/test/lisp/vc/vc-tests.el @@ -205,16 +205,10 @@ vc-test--create-repo (defun vc-test--unregister-function (backend file) "Run the `vc-unregister' backend function. For backends which dont support it, `vc-not-supported' is signalled." - - (unwind-protect - (let ((symbol (intern (downcase (format "vc-%s-unregister" backend))))) - (if (functionp symbol) - (funcall symbol file) - ;; CVS, SVN, SCCS, SRC and Mtn are not supported. - (signal 'vc-not-supported (list 'unregister backend)))) - - ;; FIXME This shall be called in `vc-unregister'. - (vc-file-clearprops file))) + ;; CVS, SVN, SCCS, SRC and Mtn are not supported, and will signal + ;; `vc-not-supported'. + (vc-call-backend backend 'unregister file) + (vc-file-clearprops file)) (defun vc-test--register (backend) "Register and unregister a file. @@ -312,43 +306,30 @@ vc-test--state 'vc-test--cleanup-hook `(lambda () (delete-directory ,default-directory 'recursive))) - ;; Create empty repository. Check repository state. + ;; Create empty repository. (make-directory default-directory) (vc-test--create-repo-function backend) - ;; nil: Hg Mtn RCS - ;; added: Git - ;; unregistered: CVS SCCS SRC - ;; up-to-date: Bzr SVN - (message "vc-state1 %s" (vc-state default-directory)) - (should (eq (vc-state default-directory) - (vc-state default-directory backend))) - (should (memq (vc-state default-directory) - '(nil added unregistered up-to-date))) - (let ((tmp-name (expand-file-name "foo" default-directory))) - ;; Check state of an empty file. + ;; Check state of a nonexistent file. - ;; nil: Hg Mtn SRC SVN + (message "vc-state2 %s" (vc-state tmp-name)) + ;; FIXME: ;; added: Git ;; unregistered: RCS SCCS ;; up-to-date: Bzr CVS - (message "vc-state2 %s" (vc-state tmp-name)) - (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date))) + ;; (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) + (should (null (vc-state tmp-name))) ;; Write a new file. Check state. (write-region "foo" nil tmp-name nil 'nomessage) - ;; nil: Mtn - ;; added: Git - ;; unregistered: Hg RCS SCCS SRC SVN - ;; up-to-date: Bzr CVS (message "vc-state3 %s" (vc-state tmp-name)) - (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) - '(nil added unregistered up-to-date))) + ;; FIXME: + ;; added: Git + ;; unregistered: Bzr Hg RCS SCCS SRC SVN CVS + ;; (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) + (should (null (vc-state tmp-name))) ;; Register a file. Check state. (vc-register @@ -359,21 +340,20 @@ vc-test--state ;; up-to-date: Bzr CVS (message "vc-state4 %s" (vc-state tmp-name)) (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) '(added unregistered up-to-date))) + (should (memq (vc-state tmp-name) '(added up-to-date))) ;; Unregister the file. Check state. (condition-case err (progn (vc-test--unregister-function backend tmp-name) - ;; added: Git - ;; unregistered: Hg RCS ;; unsupported: CVS Mtn SCCS SRC SVN - ;; up-to-date: Bzr (message "vc-state5 %s" (vc-state tmp-name)) - (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) - (should (memq (vc-state tmp-name) - '(added unregistered up-to-date)))) + ;; FIXME: + ;; added: Git + ;; unregistered: Hg RCS Bzr + ;; (should (eq (vc-state tmp-name) (vc-state tmp-name backend))) + (should (null (vc-state tmp-name)))) (vc-not-supported (message "vc-state5 unsupported")) (t (signal (car err) (cdr err)))))) @@ -406,8 +386,8 @@ vc-test--working-revision ;; "0": Bzr Hg SRC SVN (message "vc-working-revision1 %s" (vc-working-revision default-directory)) - (should (eq (vc-working-revision default-directory) - (vc-working-revision default-directory backend))) + ;; (should (eq (vc-working-revision default-directory) + ;; (vc-working-revision default-directory backend))) (should (member (vc-working-revision default-directory) '(nil "0"))) (let ((tmp-name (expand-file-name "foo" default-directory))) @@ -417,8 +397,8 @@ vc-test--working-revision ;; nil: CVS Git Mtn RCS SCCS SVN ;; "0": Bzr Hg SRC (message "vc-working-revision2 %s" (vc-working-revision tmp-name)) - (should (eq (vc-working-revision tmp-name) - (vc-working-revision tmp-name backend))) + ;; (should (eq (vc-working-revision tmp-name) + ;; (vc-working-revision tmp-name backend))) (should (member (vc-working-revision tmp-name) '(nil "0"))) ;; Write a new file. Check working revision. @@ -427,8 +407,8 @@ vc-test--working-revision ;; nil: CVS Git Mtn RCS SCCS SVN ;; "0": Bzr Hg SRC (message "vc-working-revision3 %s" (vc-working-revision tmp-name)) - (should (eq (vc-working-revision tmp-name) - (vc-working-revision tmp-name backend))) + ;; (should (eq (vc-working-revision tmp-name) + ;; (vc-working-revision tmp-name backend))) (should (member (vc-working-revision tmp-name) '(nil "0"))) ;; Register a file. Check working revision. @@ -439,22 +419,22 @@ vc-test--working-revision ;; "0": Bzr CVS Hg SRC SVN ;; "1.1" RCS SCCS (message "vc-working-revision4 %s" (vc-working-revision tmp-name)) - (should (eq (vc-working-revision tmp-name) - (vc-working-revision tmp-name backend))) + ;; (should (eq (vc-working-revision tmp-name) + ;; (vc-working-revision tmp-name backend))) (should (member (vc-working-revision tmp-name) '(nil "0" "1.1"))) ;; Unregister the file. Check working revision. (condition-case err (progn - (vc-test--unregister-function backend tmp-name) + (vc-test--unregister-function backend tmp-name) ;; nil: Git RCS ;; "0": Bzr Hg ;; unsupported: CVS Mtn SCCS SRC SVN (message "vc-working-revision5 %s" (vc-working-revision tmp-name)) - (should (eq (vc-working-revision tmp-name) - (vc-working-revision tmp-name backend))) + ;; (should (eq (vc-working-revision tmp-name) + ;; (vc-working-revision tmp-name backend))) (should (member (vc-working-revision tmp-name) '(nil "0")))) (vc-not-supported (message "vc-working-revision5 unsupported")) (t (signal (car err) (cdr err)))))) --------------DB0FE32629F9B3356DF597B5-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 08:27:10 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 12:27:10 +0000 Received: from localhost ([127.0.0.1]:39004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8Gk-0001ju-6E for submit@debbugs.gnu.org; Mon, 18 Apr 2016 08:27:10 -0400 Received: from mout.gmx.net ([212.227.15.18]:51728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8Gh-0001jf-TT for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 08:27:08 -0400 Received: from detlef.gmx.de ([87.146.63.124]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MdKDb-1bAUEQ3cBP-00IVkn; Mon, 18 Apr 2016 14:27:02 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> <87bn5bc8zx.fsf@gmx.de> <379100ae-4aa7-5ecd-70a7-4dcc4878ccd2@yandex.ru> Date: Mon, 18 Apr 2016 14:27:00 +0200 In-Reply-To: <379100ae-4aa7-5ecd-70a7-4dcc4878ccd2@yandex.ru> (Dmitry Gutov's message of "Sun, 17 Apr 2016 03:44:48 +0300") Message-ID: <87shyjksq3.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:0xj3d4kHsmgUnx7mwUfFpSXUZlLYI5tChKEy0BAokenHS6blgW0 BAYm0WKhq4nJRjWw96u2mGS3w9iXnFLdx+HXzSon96ofvKrpWtXaS7sNJH0sOiIpeDDz66U 0gXPdHhbpVKbd6HB7kRnYvcoWj/GadExeMgcVdwGB/enn2tWvNis/vVeB3DrtBgqlKLqA1Q tMaAcpujGyWtcQaexGIoA== X-UI-Out-Filterresults: notjunk:1;V01:K0:sn6HEuNKCoA=:wlRxWD9LO/p2fYA0Nmjodc kdwlSrqj+PryKeECMuioSjd8C62RXkvF5HIE6feUBZVEefzrQChPY2NjA+iHe10n0wYX2nfsL I1qfnEfXMkVD7/yumW/navyTOvAn+v7OUktPUPO6zozPtGpp4v+1CjPrUVIFSwlK4M4oxE2+u NopQd3SmkXXrUJmqbrsbx7/v22sb5WfDxJs+MVXRPctB/Bilc5zGJcXs3WQtx4yHe497QpZGk /QUdBTJotlZCMF/SxjWN05uM4KTNOY6qCLonMKXdjMs3FOwPVWfyMAW6n7EUSPqhzjYWKhXHq JOddhxfGsmYHLRhk8wijqyRIlSQEThhYn//fD9pEFklfDtT/vLAJ6P6ulMzeDJSflvn9Ytt6k DPLjVG0iuzK/+Sj8EuQLmnPh69qZmooIsDetg8gOU5Cw9zFJAnR0H1UUczpDg9DPP5uR+QHVl oFhjU3i1t/G5+dXkEqZGLMdYqEPIeKmgdwGaAhe8LFPD5hjGFlGq7esfFRDTrDXNxtOU3QN4y PJ9dyv4tTH1IQK2OEYuitp6wj8V0BoB+qhVgIKAo16qLyWEygXWe+Mtpz75kVDUWUX9A511eq hH24FHgc1BYIQc2NV2ToHIZBK2s/5CB6IMr7cKOjk9eYBDMEsGmgnPXK8r1mBDkriod7Mf9U7 MVKr/cMWFhaJni35uFepWsrypeMoUr+ebUUWjw7G51iP5yDOgFnL5rjbdb/ChAFz6Gti2Q9tp 5ExuxT8kbUuzMIYtvOt4HIOtxSN3NfyjUuav6OLb48rqSNksjmfQbTU0kkWoA2PcSNpc+EXou HEE3hGk X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: >> After applying your patch, vc-tests.el fails for me in vc-test-src02-state > > How do you install src? Do you build it from source? I've checked it out from . See the README / INSTALL files. >> and vc-test-rcs03-working-revision. > > This one (failure in vc-checkout-model5) seems to be a real bug > uncovered by using vc-file-clearprops. I suppose we should add a FIXME > there and skip that check for RCS. I'm also thinking about how to solve it (in master). vc-checkout-model knows only three answers, implicit, locking and announce. I will ask on emacs-devel, what is appropriate for RCS, and fix it then. >> As said, in the master branch I would prefer to add a vc-unregister >> function. Then we won't need this anymore. > > We'll need this code either way. Where the function resides and how it > is called is less important to me. For the time being, I have applied this part of your patch locally (not pushed yet to savannah). Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 08:28:32 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 12:28:32 +0000 Received: from localhost ([127.0.0.1]:39009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8I4-0001ly-GA for submit@debbugs.gnu.org; Mon, 18 Apr 2016 08:28:32 -0400 Received: from mout.gmx.net ([212.227.15.19]:64526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8I3-0001ln-7A for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 08:28:31 -0400 Received: from detlef.gmx.de ([87.146.63.124]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MDQUP-1axwF214HN-00Gp0Y; Mon, 18 Apr 2016 14:28:25 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> Date: Mon, 18 Apr 2016 14:28:24 +0200 In-Reply-To: (Dmitry Gutov's message of "Mon, 18 Apr 2016 04:33:38 +0300") Message-ID: <87oa97ksnr.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:yJ4Xyo4G0EV6UQZP49NdIJn6q3n/HclG0IrQ7V8z2Phi5flt1EA 8eOmq0q1CubgzO6j5eYL/veFxHV3OYtGYZSaeEuMI4jIDqJwUgDWO0WPZn7lQO11wyTtxDE 99Txnk0Y70mndKFfivdoIv2e6vFb+X3POTNow+9QLem+vSrE23NzjVbVtPQpJFEiD/6Ncbh lt2/cGRDpnDpPX/UOTXuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:tKcszlwHvSQ=:CxX5Bq2+mHJQKKchilvmoM +iJ72BqvomQ9opOiJ88VfomkiI0bGJhvou80mm9p7UfHDZBG6sVPqjlxpjk5o5XXKMKR/KitC HNOgmbNlF9jVHET0Rg+FzO2f1aNez3Tn66AlFSgSbX9mWdlaDMkLtXJW/cQ50Y6at24dfdVyE +HTP2HEFU2TsWqXehzM2tPMJlalS4VmaccOrDlS1lu6rdI9Qen/AG38K+B2aUN1vYB4uw4HUD k9J2DXAW03nv/TyDhKc9Y8I6PedUDOvs8CpmUh0r/9yTXYQH2HCtpwfIcyhkJ4vkvxDt1+zDp eWpxBY9Dr1gBx21HQYu/5y66BnSO07bqd+EDiiKZZt0V/ocViLYdMYNB03X3Pd35wEtC0N4bc 0pLJLztETo7XC45h0BalTq5roxvErCjqhzM1LSzozzX+j0JtGSqpaD+mZj6fUC069pSJRvqrJ I03zTZPrA4kq0d13R0BWcLETvmz2tvdWlPOhLspFxf8WOBrif82E5dqGQndzPZtCleIExBVFT 0sQ7YW6FTxwH/6rYVX/M2cnt8riqPlxSjpyIRk3Bs4B+scf6ZSA1lR153ZYLP4lzOh+gmtPwj feceql4lp2O3ZYYcy9DrRZvSE99EG3GvQLMaAH8jg5BI8BYbiDEAuYf1ZRHAdLkoRMbR5MFiv I23hvg5AlFGIjk/osihHAyjGeWGfnbWYP7X/vibwnj1TYD0g96yX24D1r6aJC7VPIDOMd3Mqi oaYfUTlxNF1IEfDwMV2TLtsq7vETtTxE2PIhNYBiFOVez7yUdeOmUWUHk8IfcXs8vS3LREjNp TxAODi4 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: >> I've committed this to emacs-25. Plus commenting the now failing checks >> in vc-tests.el. > > We should also consider reverting the changes to vc-rcs-unregister and > vc-sccs-working-revision. They don't seem particularly necessary (the > tests pass without them). As you know I'm conservative with the emacs-25 branch. Is it absolutely necessary that we do this? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 08:33:39 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 12:33:39 +0000 Received: from localhost ([127.0.0.1]:39016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8N1-0001uh-2w for submit@debbugs.gnu.org; Mon, 18 Apr 2016 08:33:39 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8N0-0001uS-3n for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 08:33:38 -0400 Received: by mail-wm0-f68.google.com with SMTP id a140so24260273wma.2 for <20637@debbugs.gnu.org>; Mon, 18 Apr 2016 05:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=xfyJKcsfMCCJxJeDncFkKXJVXzh0ZYK8KGUBGdwftr0=; b=wPjLmkzn0AgsdBQo/s6H6MjLvquulabo2FEiIRTHqXEQcUzD84SF4v8vNrRsRfMIvc /jE5rUAmycsZp8BsKbhr4Hhjp789YOZKNaRzmx1Tfz7d8drLPhHwfxLpANtFJRXM46RW V30Tw+ZHWGMDyEMvuZbfocz2ftw8b1WAh0rEXWf3TqEfBjQQVC/QnN1h89hnLblAe2Kr xI6DJz6qn6CRwnVL2fdD6cefZNLSgw5zO9n2mqFRcHfCZkp8whmxPNZZExwCTAK76srS IGPaEqntFjmWX6iT1Zplt21Id2mB9Dl6gPucsnfBPcH8sKxwwpG5nniPUMw7fp+RzS0y 5ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xfyJKcsfMCCJxJeDncFkKXJVXzh0ZYK8KGUBGdwftr0=; b=k86JayO48JoNx7oghOUf9qd2TQ7qFEaYYKVZOuBPn9qsQqI4Y9x/NzOdKTvKOi4x0g LFER3ahyrpfBUE/nTE9XrDEfzs/gXNDd7F/1GcixH4WcmseL2nKvaKbUxfsqUQK4WD+E 1Tae8NVQR9QVuoZFLHK+Cgbxp2vhqRGWqbcnOngFSAuU62kzZiE6z4cSUG00dCy8xV3N Ot8WH9HyE0quklWsAEcL3vn6lQIMxoZ+XlyMj6G5Yk0ZdtOpD/CH4l+NSfi0eENfNeXK Wvb3yvSIQjTYIde88+RWgIJ9Iqw4rE9gYrQtk1gr0aGLUlHD/zCjhXWzwD11e98hlH29 VG5g== X-Gm-Message-State: AOPr4FVzlbT1GoS2I+Lkz14qbQLbCd1H3DAASq5F7HkHmSKwjKp8pGuZZ0Qiuk99lhmiUw== X-Received: by 10.194.185.144 with SMTP id fc16mr35534248wjc.123.1460982812558; Mon, 18 Apr 2016 05:33:32 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id k139sm26466052wmg.24.2016.04.18.05.33.31 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Apr 2016 05:33:31 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> <87bn5bc8zx.fsf@gmx.de> <379100ae-4aa7-5ecd-70a7-4dcc4878ccd2@yandex.ru> <87shyjksq3.fsf@gmx.de> From: Dmitry Gutov Message-ID: <06ae02b2-e71b-9bb1-dba3-d0976a163ddc@yandex.ru> Date: Mon, 18 Apr 2016 15:33:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87shyjksq3.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/18/2016 03:27 PM, Michael Albinus wrote: > I've checked it out from . > See the README / INSTALL files. OK, thanks. > I'm also thinking about how to solve it (in master). vc-checkout-model > knows only three answers, implicit, locking and announce. I will ask on > emacs-devel, what is appropriate for RCS, and fix it then. Sorry, the failure was in working-revision5, I think. So it's unrelated to checkout-model. Anyway, I don't see it with the latest patch. >>> As said, in the master branch I would prefer to add a vc-unregister >>> function. Then we won't need this anymore. >> >> We'll need this code either way. Where the function resides and how it >> is called is less important to me. > > For the time being, I have applied this part of your patch locally (not > pushed yet to savannah). Just the usage of vc-file-clearprops? Why? Anyway, I've sent a better patch yesterday. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 08:37:43 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 12:37:43 +0000 Received: from localhost ([127.0.0.1]:39023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8Qx-00021B-KH for submit@debbugs.gnu.org; Mon, 18 Apr 2016 08:37:43 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8Qw-00020z-KY for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 08:37:42 -0400 Received: by mail-wm0-f65.google.com with SMTP id n3so24336076wmn.1 for <20637@debbugs.gnu.org>; Mon, 18 Apr 2016 05:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=cTa+kNnBoblVV6/I9iFQDEu+zqdkresvBL1p23XLtpg=; b=09CXFCn7mydu5wPoREqLj51Ry1DT0Rora6jznGoedwtBwm9dwNHpCS5izdLYK9D6se PigS38bcSN4HoAJsXBaof8h1ZKB1jtIZXnXe09kZuxEtEb/Fav8NyMyIZDs409UJTKdt LbFfmz5ScEl+i++528jFj7dh0TX9Oye18EoxyQf2O5Pp4iXoZGQsZjDZk6wtIUo6teKd VCXsLSDwrH+dCBBfgbeQUErbPRO7//n8mf8J5cF2QV2ukWKKJpxNcP/O1XonEIerTT3K 1DMyhG+H3nBeOjUkbb549MSlcKHtQNG1Lo3J/eVCDcXCex8lko+gUxoc+8BaKhFyQQMk V2uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=cTa+kNnBoblVV6/I9iFQDEu+zqdkresvBL1p23XLtpg=; b=H4Qne+nwmKz6wBRfgz3V0zpK45e3a3iIwwWVm5PGUr7FSZxE9xfZflag6jlMIfBlsF P2B4N8hQXZyUzWy1wBaTYzslyr3YQgr5sHpWBh+drZiflnmfi8tRp7QUmA/g3HChsKsy /txsfq2qTVaZLOid4rAjZz2PmFIAFhc7zlx/ygXdjMm3bbDlFMLJE7XuOPlt7AuC/7GM Y9ilTxxy0oYgCynx0mZ32xix0oXslk/lS9HrpUTW2GRbRBA9Yf9qvvAgXG2FvN1zE8m0 s4gwp20H/pg18O7UEc/91l9B7+T7J/EUhItXmSTfSDW+KD8f7YalVcUjma89zRm8APV5 e02w== X-Gm-Message-State: AOPr4FWytIjaIoFdtIU/x421nOJ+BrG6ebFeT0dZc8oERPxsoDA4tnz7dISeiPaYfKPL+A== X-Received: by 10.194.34.39 with SMTP id w7mr6744780wji.19.1460983057139; Mon, 18 Apr 2016 05:37:37 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id u192sm5780374wmd.11.2016.04.18.05.37.35 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Apr 2016 05:37:36 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <87oa97ksnr.fsf@gmx.de> From: Dmitry Gutov Message-ID: <4df44cce-b7d5-a9cd-23a2-026de38588b2@yandex.ru> Date: Mon, 18 Apr 2016 15:37:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87oa97ksnr.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/18/2016 03:28 PM, Michael Albinus wrote: > As you know I'm conservative with the emacs-25 branch. Is it absolutely > necessary that we do this? It would be a revert to the code that has been in use for a while. Nothing absolutely necessary about that, but it might be prudent to revert the changes made without clear understanding why they should be made. Please correct me on this if I'm wrong, of course. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 08:47:07 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 12:47:07 +0000 Received: from localhost ([127.0.0.1]:39034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8a3-0002Fp-33 for submit@debbugs.gnu.org; Mon, 18 Apr 2016 08:47:07 -0400 Received: from mout.gmx.net ([212.227.15.18]:51815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8a1-0002FM-Af for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 08:47:05 -0400 Received: from detlef.gmx.de ([87.146.63.124]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LfSyv-1bY67H1HUv-00p3ID; Mon, 18 Apr 2016 14:46:58 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <9ac1dc55-94f9-2556-d520-96d47e43c4cf@yandex.ru> <87bn5bc8zx.fsf@gmx.de> <379100ae-4aa7-5ecd-70a7-4dcc4878ccd2@yandex.ru> <87shyjksq3.fsf@gmx.de> <06ae02b2-e71b-9bb1-dba3-d0976a163ddc@yandex.ru> Date: Mon, 18 Apr 2016 14:46:56 +0200 In-Reply-To: <06ae02b2-e71b-9bb1-dba3-d0976a163ddc@yandex.ru> (Dmitry Gutov's message of "Mon, 18 Apr 2016 15:33:29 +0300") Message-ID: <87vb3fm6db.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:OtYUuTpQ1gURHFpZ9lNC596U4fPZKhBJAW1mqOwv+09rCvUAHw3 V4UEf6VzR1LekOKh/ES41lPkrJtB3ot+DZzmqRuWCfYkFrCezt2HtyC0GXuWi5Ya3nJUrF7 RSGE8dXY5O3hRVInK7chX0LxYiHy67ntRO9UUxrUeb/ulcfRstGfmrADExxNwjnxcdaXi98 ishog0gd/XrHxxSm8Pk0w== X-UI-Out-Filterresults: notjunk:1;V01:K0:4P4C9tipG78=:FNk+Ba6P25QrktRAB1Jb46 kcrMcUzHrEbdHnaPiNiO4J7vWlxV6NLg31IiBgEn3opGSjaGm4thnpKZQ+MJdMSqTnWvhV/nz p1naA7NN8ryHJOCBPDkfvXKydikxxHLHY2HGJsAouOx8JPZfbFFwqPlXZnKBoR+p1NxifNY3K 2xAf2XB4AD1ulSIsiH0oyGNTkO4V+QHK/WfkZiLtgUxPNwBgkmEP6g1UclqRXyTIS6nbwnbd4 2C9ycfiqNtAVpAfNBJZmjJR2ZcvGMNfS5OA9Z7F9sylEHX3PWzEtCbvEgVuCjENLicbKT68JH eEAWI9ntOV1Qy4PXMT9dA2dug+PauFfRsu5GpQyqq35z/XiJzQQDq2nEuU/CTEBWlJ04Ov7lg QIqqyejmN2xy0b/3eykzntywJjdjcQV+DXDfXnnkgAhGOjvJSvLQSeclYrxb6LL0xLdfkLidZ Tr6hD7huqBKiRH1zXi0fUJZPmUcLvbxp0E4IjOEjgkpw8nAw2MMtXp7bayc9tiAxXw1F3+MOy L4CyRTd1hlaDHKV/UJG1k2YSwKM8OjQJLzWFndG1JR/oUKBBS03OfatK/82az5p5JzzHM5R09 vz9dXu9+Q+d1UicPnsxbVpS//Pi4RMXXfFP4F9zCeEXmIx8HuTrl2rIvCorLwZsOBNJEDQHX0 mzChTPIgBs1EZ65Wy08rOCITeXJb+thNyLvfYJm8xQy7Aw7js5soeCiMlBdGAaLVc7/W/GO2V 99J57KJAlbS5hFc7eh2BiWkh0SRsKJe+yJQDPeMS2BCOWSULHWdLRTFArao7sK6wXj4EEzWUa XFyhori X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: >> I'm also thinking about how to solve it (in master). vc-checkout-model >> knows only three answers, implicit, locking and announce. I will ask on >> emacs-devel, what is appropriate for RCS, and fix it then. > > Sorry, the failure was in working-revision5, I think. So it's > unrelated to checkout-model. Ah, sorry. But there is also an error with RCS and checkout-model. That's why Glenn has marked vc-test-rcs04-checkout-model as expected to fail a while ago. >> For the time being, I have applied this part of your patch locally (not >> pushed yet to savannah). > > Just the usage of vc-file-clearprops? Why? Also the use of vc-call-backend. I didn't know that. > Anyway, I've sent a better patch yesterday. Yes, it's on my todo. I'm handling easy-to-answer messages first :-) Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 08:53:29 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 12:53:30 +0000 Received: from localhost ([127.0.0.1]:39040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8gD-0002Ou-Oi for submit@debbugs.gnu.org; Mon, 18 Apr 2016 08:53:29 -0400 Received: from mout.gmx.net ([212.227.15.19]:59136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8gB-0002Og-R2 for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 08:53:28 -0400 Received: from detlef.gmx.de ([87.146.63.124]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MJjOu-1ar2kX0HW0-0017fk; Mon, 18 Apr 2016 14:53:21 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <87oa97ksnr.fsf@gmx.de> <4df44cce-b7d5-a9cd-23a2-026de38588b2@yandex.ru> Date: Mon, 18 Apr 2016 14:53:19 +0200 In-Reply-To: <4df44cce-b7d5-a9cd-23a2-026de38588b2@yandex.ru> (Dmitry Gutov's message of "Mon, 18 Apr 2016 15:37:34 +0300") Message-ID: <87r3e3m62o.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:zzLcRz/sHyTTP6xtblTcwqbLQCUO9h4YEDYN8iexCPV1YqCi13R nmNLckQ12iTmzPlC9Kv4pkqdWMbPhQCk5Ek5ivLdehGl77mb0pQo5CaOdx3/HhpUyLTZQgN 3AsXH0RyxlQmJ3tq+dG0ss7Ue3J7CgTc47dDt4i6V436gV1uS93Gr9a7EWETwl8FG1NAcfF uuCzKZxCQy0Pl2rSMWx0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:pBqPVdNGJt4=:QDo2bSKVgYyumMVDRmhpwt SmzgVzhWsdR2vGMZUsNsHN51eSvW1Y3TEK33LkGzG4ygGjzFeYbW3ckL4d5b2pcXutKZ9Wsqx erH6N4AQe+BHsp6WefFHBFUdEoUU/ABT6KzXbV6bQiVgX8LaUk1oifT/Kdx48oB8sI5zRoaQ1 sS/K8h//EG9LqoCF3iaqwad/VzWuPLxa7WKu4PjcBYtS07yaXDVfmxZ5bu59aQQSopsT47dPs BMBxnhUURmS8/h7x5qaWfcFGYBMartMFlyrx9VOB+U+elAf8fj/lpRcIh5pRg0LGqBLLV/eTK lTa3FtlYOBmu4uUewgXmgDS5QzN3uYjIRO3QlDN/mIZG0aVIEn+hNGqnsQg/YEJ/zLxNNGmEa j6qJAo9GR7fnGlz/krYV6j/tkXbIV+avvGVh9SdSlvDXG/v7cETI3s2C2TvLT6OAsqR4zRpMC Y1hJFTDHFuoWpaWIR2q+O6sMknLv75uGDvJwu7gg+MXf0oDPTtjpXfG2sUFq0RdubTNdtHFRM v4n0niemc3C7gRYHqTRPTSRRXGcaKNn77lmtol2SqImMcVFAqwGH33hAZemVJBSvRSzf24QQ2 BReBe5MlQZCuArSfNZjw130uoBiqma0S6WquIywTo6FIuyVhqegiF7wgU0uvY3H2dphoRHNnv qsdXoa1a+83t0TvQq+gxsQe2UCmZyBYocy9cLlpEIDl0WU2Cqc9ot7CFKHbiOjaAmHXBtnc/u aE5YA364L/oP/Mdogp1gJIqqP4jEPPLnjNZLlesWxQLXjYNNK4amIQCn3Bh96GfwBB+Rbk522 ssZ/reK X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > On 04/18/2016 03:28 PM, Michael Albinus wrote: > >> As you know I'm conservative with the emacs-25 branch. Is it absolutely >> necessary that we do this? > > It would be a revert to the code that has been in use for a while. The current code has been in use for 11 months. Beside this bug report, nobody has worried about that. And the problems this bug report speaks about are solved, I believe. > Nothing absolutely necessary about that, but it might be prudent to > revert the changes made without clear understanding why they should be > made. Please correct me on this if I'm wrong, of course. Again, it is a matter of not touching code so close to a release. 35+ years experience in software development tell me so. Often enough I've changed just one single line, because "it is obvious it cannot be wrong". Haha. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 08:58:47 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 12:58:47 +0000 Received: from localhost ([127.0.0.1]:39096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8lL-0002Yi-32 for submit@debbugs.gnu.org; Mon, 18 Apr 2016 08:58:47 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8lJ-0002YS-4J for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 08:58:45 -0400 Received: by mail-wm0-f66.google.com with SMTP id a140so24448925wma.2 for <20637@debbugs.gnu.org>; Mon, 18 Apr 2016 05:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=U03rrXe/aaShJ0QpDj7Z9/IdLE8LTRuJZ+W/gXhRRwc=; b=RtaGirT0jVQ0w16QGjyBz+THBIkanexp1qYsfLcAAdHUfL2aIwl7EGn42Xa4X8sKRd nrd3UzIG2VTSedo/RvCSpVyGIxM6vwyxLBLgVPGk97QJDsjHikpuNOBDHM4iI0u5Rtmy z0wYIsXaIu2RHSi0eY7EGm2ZIeFpROATnfYEO4GyT3ARamGKrGBxsF7gIZb61GoMM5Hz +qGYjSBHQkrMf4iGkXV6u9mBvzQowPoFCqUBSA+v2bp1YWA2vWVP96+2Vz2HR+0vChmB qIyanUXLchacghN5aq/hei9/fONx7K2lYGYHa4XJC2CH5UC7CYIVlIdlqgkv1jZK9bPK v32w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=U03rrXe/aaShJ0QpDj7Z9/IdLE8LTRuJZ+W/gXhRRwc=; b=UGQM+BH4tF5gGP1xg1NjYwyFTEgZS4l17pFzU+9KgWLOhQVoVRpICdz6SfNLdcuxVZ k2KNcSa24S+vBlTXZBMJxyLmSa3dV3aPyiF37Sr5vG7kKsw15b0Mh5zVmq7z+YiJHdGT uJz6346OAwdfuupdSHm9YkSGOe1/nl5nTb5QevjbwEmCRB3uR2Fa4vgFc2k6b2FI8ieU 91Qa7fh6RnNope1PsQHm3XPgBgmUIweewkVXBmIwSQI0ppKaCZ7rc/0DUU1+k43G84V2 ePGkKnh3XqdlNHPQUeNew95Xb6aLNiFnR7bEYc5wdwHIbj7IdWMvl7L1w7s+i9KbMVBk 0uiQ== X-Gm-Message-State: AOPr4FXJvl89MyMDYQb5J7OKp4Iw1iRUxia7QCx0of8gIQWj0IY27h/xF/aE6MzEXKejJg== X-Received: by 10.194.90.76 with SMTP id bu12mr35426523wjb.79.1460984319493; Mon, 18 Apr 2016 05:58:39 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id gl8sm64037167wjb.30.2016.04.18.05.58.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Apr 2016 05:58:38 -0700 (PDT) Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision To: Michael Albinus References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <87oa97ksnr.fsf@gmx.de> <4df44cce-b7d5-a9cd-23a2-026de38588b2@yandex.ru> <87r3e3m62o.fsf@gmx.de> From: Dmitry Gutov Message-ID: <5a36fdc0-7735-3b24-6c79-8feb0ee55c51@yandex.ru> Date: Mon, 18 Apr 2016 15:58:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87r3e3m62o.fsf@gmx.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 20637 Cc: Glenn Morris , 20637@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/18/2016 03:53 PM, Michael Albinus wrote: >> It would be a revert to the code that has been in use for a while. > > The current code has been in use for 11 months. Beside this bug report, > nobody has worried about that. And the problems this bug report speaks > about are solved, I believe. They are. >> Nothing absolutely necessary about that, but it might be prudent to >> revert the changes made without clear understanding why they should be >> made. Please correct me on this if I'm wrong, of course. > > Again, it is a matter of not touching code so close to a release. 35+ > years experience in software development tell me so. Often enough I've > changed just one single line, because "it is obvious it cannot be > wrong". Haha. Fair enough. We can revert them on master, though. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 09:06:37 2016 Received: (at 20637-done) by debbugs.gnu.org; 18 Apr 2016 13:06:37 +0000 Received: from localhost ([127.0.0.1]:39106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8sv-0002lh-3H for submit@debbugs.gnu.org; Mon, 18 Apr 2016 09:06:37 -0400 Received: from mout.gmx.net ([212.227.15.18]:59356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as8st-0002lU-Sa for 20637-done@debbugs.gnu.org; Mon, 18 Apr 2016 09:06:36 -0400 Received: from detlef.gmx.de ([87.146.63.124]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MYg42-1bEdYF27UY-00VSOd; Mon, 18 Apr 2016 15:06:29 +0200 From: Michael Albinus To: Dmitry Gutov Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <87oa97ksnr.fsf@gmx.de> <4df44cce-b7d5-a9cd-23a2-026de38588b2@yandex.ru> <87r3e3m62o.fsf@gmx.de> <5a36fdc0-7735-3b24-6c79-8feb0ee55c51@yandex.ru> Date: Mon, 18 Apr 2016 15:06:28 +0200 In-Reply-To: <5a36fdc0-7735-3b24-6c79-8feb0ee55c51@yandex.ru> (Dmitry Gutov's message of "Mon, 18 Apr 2016 15:58:37 +0300") Message-ID: <87lh4bm5gr.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:T304phIfLIkGwuwHGuGWTS2MuFRdD21dSc1tQkqQlgHrrZs9u1y e3fknbzVsDkWiDnvESamTNWZZr1vscN4grfQO05ivemTb08y2Bk87gUypWxAYt/61CXENMQ 6XrS39jVX2wFSBJS1F4OtIpnE7s3D7Gp+lqa4qw33ULQM0xmfraPNELjVr1Tr21mIFKH3Hd fa8iP7hNFfmJgKOiUWryg== X-UI-Out-Filterresults: notjunk:1;V01:K0:OgZQ33AbpOs=:W4x8nrnIreCG8wZEyveTZp CFZGnDEUx6Rretqw9CzfFeRmLNzIagP2YFzhuahti/SLlLMD4SGuAYybkwN+xrWbojBlT9XjN xxkGaBOCveYNLAFMAI2BTUQkEQPwqb2Mrhkku1y3YNEWV9CsuYSQS9FCsD3DteSxpWJsM2o3I S1MD3XXC9HVwIW26B1X3E8YrxUWxk8b5FR6P7aC5oc6KtyUQ/LFRyBbprbQIxnW8FS+KSY01x CmLVSA29yR9tKfcZ1YlPfldaxlS0aX/AUTz89qkFfJmyT0DhMdQOJlUjH7dRJt3VK6nm+Qmvv eEZwdgUXBJbpqmjxEl17PdVYbWBoLtSkJPe7KY6cuASOCSIJYj/35Y9A/NBAfphKUCpxhCmLM q4KOq4/0Xz+04FIPypDGWb95wNxjl+PhtGWI/QQEyFu2PLPxpEYvs5X3u4UZ5g9T0svze8ap3 1SJQurwfA1YT0I33IhiKdqvlOjEbJ4AjgPiklknLiV9qr6A07NQ5sEV63Hqob778YUeWZwJ7q dEiR0vXl4Qgj5JZecmf1SZA4Dz95tKQvXUp+cc9ITPTnZfHHceYQTkPnIHC5+fpNqhie706/x Iz6x+c7rRHn6uxr/1ZGngRl3uLfm/OmPwD4xSDnqtpDvPdhLu0xMCiHjT6ZGFfC6wkJPnxDrl qw0tt2Kl+MgRBmNnI+2UM4mAsWtTUkjFNBfKMltQXX3fTwIzpGyfgS/VxM5zWfM2i0Uq9DqE1 R2XbHZ5BUgOzM8tixAPUZgRj15bAimMUR5CVT0rv7oOPiE1tiv5soeVHGk8oCJYGhbp9Zxb6r sClj+db X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637-done Cc: Glenn Morris , 20637-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 25.1 Dmitry Gutov writes: >> The current code has been in use for 11 months. Beside this bug report, >> nobody has worried about that. And the problems this bug report speaks >> about are solved, I believe. > > They are. So I'm closing this bug. Further discussion shall start on emacs-devel in a *new* thread. This bug report has served its purpose. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 18 12:34:54 2016 Received: (at 20637) by debbugs.gnu.org; 18 Apr 2016 16:34:54 +0000 Received: from localhost ([127.0.0.1]:39602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1asC8T-00018L-Ud for submit@debbugs.gnu.org; Mon, 18 Apr 2016 12:34:54 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:35847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1asC8S-000189-Kz for 20637@debbugs.gnu.org; Mon, 18 Apr 2016 12:34:53 -0400 Received: by mail-pf0-f170.google.com with SMTP id e128so82230469pfe.3 for <20637@debbugs.gnu.org>; Mon, 18 Apr 2016 09:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version; bh=ZAn6PZ7VpZP/yVRFxxaBLJ/LN8ShEnj/x3sNSRxzVhM=; b=k3uZptWq5DvjTLTwf2H/svs+5+8pvUJI/YRFk73uktok1tHSQN2D4SrQidt0J3ZUnf ebhqPZQ8YBoH5oklQOgVaAUzkAhbvsiGqLWL569X8AOgV/SswTohtE3Gt7nnl6A54M1Q yhw/8p2/h6Mycz/fm6ivQzni4VFScIbKSqWiHn/9/svvUeT6Qv6DLbz7y2kXg9529PjR /FUl4fm5T9IrD2fIO9JeKMb0iIQGwenYY8C5lXZ33tLfqOfJbsibfGrpU0pfhaXHF99z OJ36IEgUZHn5VmQlddS59XM0BIf3Sa/koFWIKTB0JuqGdXFc8tE4aA64ZYGLkkY8tU11 I6EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mime-version; bh=ZAn6PZ7VpZP/yVRFxxaBLJ/LN8ShEnj/x3sNSRxzVhM=; b=PuzxP/Xc6xJFIGZoBGOny1ouzoYr14xo3qCAmTPNtVnKHDMAzSPwnitbGoYXPOZJcd SLKBGGvlefdg8WCdNmZ2MQSdXT615IVp09qmwgKausLtvDl5oVfX/eMqaa+IPHIAqhjr 0qhmbFV5i4bE14VZUQqyKN1+G8wFq1xBLylRlFFQwIc1GHxdeFGLCTaxl1YrBjrx+/AV czpijopGW1L3Vp0Wp7W99naofJtuLdYOGawkm5WIk1Z3DLMIEtnU5Gv+F2W9p1wbNJf/ K7UbyPuZhezQj3i+5OD7344ZAMOVSU4liVDd1sMi3YOYifkdk81ugvXSyn0mpAAuwnjd c/qQ== X-Gm-Message-State: AOPr4FXNglYlcqhqVSSz3noDJE2f5xx6JAj0o7NdStwn1HO824Zmg6R4JF1uiQQeMcItkQ== X-Received: by 10.98.80.10 with SMTP id e10mr50980578pfb.141.1460997286900; Mon, 18 Apr 2016 09:34:46 -0700 (PDT) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id bu17sm85141844pac.25.2016.04.18.09.34.45 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 18 Apr 2016 09:34:45 -0700 (PDT) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 1E5521436EB1D; Mon, 18 Apr 2016 09:34:45 -0700 (PDT) To: Michael Albinus Subject: Re: bug#20637: incompatible, undocumented change to vc-working-revision In-Reply-To: <87r3e3m62o.fsf@gmx.de> (Michael Albinus's message of "Mon, 18 Apr 2016 14:53:19 +0200") Date: Mon, 18 Apr 2016 09:34:31 -0700 Message-ID: References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87h9f4ghzg.fsf@gmx.de> <87oa97ksnr.fsf@gmx.de> <4df44cce-b7d5-a9cd-23a2-026de38588b2@yandex.ru> <87r3e3m62o.fsf@gmx.de> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.92 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20637 Cc: 20637@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> Michael Albinus writes: > Again, it is a matter of not touching code so close to a release. 35+ yea= rs > experience in software development tell me so. Often enough I've changed > just one single line, because "it is obvious it cannot be wrong". Haha. I simply couldn't agree with you more on this one, Michael. :) =2D-=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGcBAEBCgAGBQJXFQyXAAoJEMFE2PTxn+YwYU4MAM4K5IE6pHIUz5flIcLyqQT4 4DLKXnzTaR5WZDOyUjqztdp5eFyK1A6ASaqv9y7VBD8VcOFmOGx5XHVn7TczxP45 qwqOdKITqSXv217W9V3pRFntmPsQKPhbWjf/ES63eQwWoM4qosPQnuuADXSSMGEV TOC8UrNqUmBVLAgGtbXcDOLbli7AV67d5dXE43cuUvFyhOu2SsMIQouAHueqYyfr ZVT6xVDDMKnPrberHsr1lgqYN4HeC28WICExhD3TZRFBB2feQHU9RAJ7RSbRIm7M FkRt2hFg4RFzPThdNZJL/rCu3Y+0TrIFJQ6wcUwcNcP+sKw9mJIh3LPwQRov3LWF DTsfF8pHFUaaR5tTZvWQvGjbTsDj4oKkk+YaP9LWHaMgBhTulY76mGzzsB0AD9Iw eio++Xao2JUqduikZZqgMPkSZ7G1xKeS0WSyLbsm/6Le8y3OD8Ew/tUpnLvDte0I M0gDesi5XWC/2TqJvQW4FDXWFk0z+p9wIMrjaWGqVA== =pTUD -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 04:11:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 May 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator