GNU bug report logs - #20631
'df/df-output ' test fails due to extra space in header line on large disk

Previous Next

Package: coreutils;

Reported by: Assaf Gordon <assafgordon <at> gmail.com>

Date: Fri, 22 May 2015 18:17:02 UTC

Severity: normal

Done: Pádraig Brady <P <at> draigBrady.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20631: closed ('df/df-output ' test fails due to extra space
 in header line on large disk)
Date: Fri, 22 May 2015 19:48:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 22 May 2015 20:47:10 +0100
with message-id <555F87BE.8080306 <at> draigBrady.com>
and subject line Re: bug#20631: 'df/df-output ' test fails due to extra space in header line on large disk
has caused the debbugs.gnu.org bug report #20631,
regarding 'df/df-output ' test fails due to extra space in header line on large disk
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20631: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20631
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Assaf Gordon <assafgordon <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: 'df/df-output ' test fails due to extra space in header line on large
 disk
Date: Fri, 22 May 2015 14:15:46 -0400
[Message part 3 (text/plain, inline)]
Hello,

Using the latest coreutils from git, 'tests/df/df-output' fails due to one extra space in the header line, needed to accommodate a large disk.

Log attached, but the problem is likely this:

    # This is a large disk...
    $ ./src/df -hl .
    Filesystem      Size  Used Avail Use% Mounted on
    /dev/sdb1        33T  2.0T   31T   6% /data2

    # The test command results in two spaces before the header
    $ ./src/df -B1K --output=size .
      1K-blocks
    35139364864

possible fix attached.

-assaf


[df-output-extra-space.patch (text/x-patch, attachment)]
[df-output-test-suite.log (text/x-log, attachment)]
[Message part 6 (message/rfc822, inline)]
From: Pádraig Brady <P <at> draigBrady.com>
To: Assaf Gordon <assafgordon <at> gmail.com>, 20631-done <at> debbugs.gnu.org
Subject: Re: bug#20631: 'df/df-output ' test fails due to extra space in header
 line on large disk
Date: Fri, 22 May 2015 20:47:10 +0100
On 22/05/15 19:15, Assaf Gordon wrote:
> Hello,
> 
> Using the latest coreutils from git, 'tests/df/df-output' fails due to one extra space in the header line, needed to accommodate a large disk.
> 
> Log attached, but the problem is likely this:
> 
>      # This is a large disk...
>      $ ./src/df -hl .
>      Filesystem      Size  Used Avail Use% Mounted on
>      /dev/sdb1        33T  2.0T   31T   6% /data2
> 
>      # The test command results in two spaces before the header
>      $ ./src/df -B1K --output=size .
>        1K-blocks
>      35139364864

Pushed.

thanks!
Pádraig



This bug report was last modified 10 years and 56 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.