From debbugs-submit-bounces@debbugs.gnu.org Fri May 22 14:16:06 2015 Received: (at submit) by debbugs.gnu.org; 22 May 2015 18:16:06 +0000 Received: from localhost ([127.0.0.1]:53145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YvrUK-0000uU-P0 for submit@debbugs.gnu.org; Fri, 22 May 2015 14:16:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38791) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YvrUG-0000th-Pm for submit@debbugs.gnu.org; Fri, 22 May 2015 14:16:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvrU9-0003A5-V4 for submit@debbugs.gnu.org; Fri, 22 May 2015 14:15:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvrU9-0003A1-Rf for submit@debbugs.gnu.org; Fri, 22 May 2015 14:15:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvrU7-0000zO-Qe for bug-coreutils@gnu.org; Fri, 22 May 2015 14:15:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YvrU4-00039K-HU for bug-coreutils@gnu.org; Fri, 22 May 2015 14:15:51 -0400 Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:36786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YvrU4-00039E-C5 for bug-coreutils@gnu.org; Fri, 22 May 2015 14:15:48 -0400 Received: by qkx62 with SMTP id 62so18111954qkx.3 for ; Fri, 22 May 2015 11:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=7WSwKKJruVXFSp85+BZ4PuyVfey/vs32qsB3XohIrOA=; b=C7Rk3zqGhyUG9V/lpm9tw6JgTVzSBySg2J8LQM8G+PtO4iiD+YC/zTchQxx78EKELd klsZqrJWcPTsmgK/PFoEbK5BZJU5VVBwV0uCDCg1+YSABe0Yy/Djp6jh7T0NAW9eGSW8 FQkFYPK5eZu42QhKN/XfD10WE7k0T0rYhcMOAYG/BFHuCt0yG8Te4ozDt9DiD9Atap6w f8C/OY9FzXF/7ai6oqH9axq9mH54LIGNaJipAM9vNk/AErCPezOCc+T7sOvsNk9qRccr bNXKMT0FnW4Tgq3vX6L0jpU83rIQo/Xh1lzxAmbTi9XZyd0Y4j+0FnrFVw8wkIyOATDA U2qA== X-Received: by 10.229.59.132 with SMTP id l4mr13239151qch.9.1432318547371; Fri, 22 May 2015 11:15:47 -0700 (PDT) Received: from disco.erlich.nygenome.org ([162.212.111.2]) by mx.google.com with ESMTPSA id p73sm1767214qha.20.2015.05.22.11.15.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 May 2015 11:15:46 -0700 (PDT) Message-ID: <555F7252.80009@gmail.com> Date: Fri, 22 May 2015 14:15:46 -0400 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: bug-coreutils@gnu.org Subject: 'df/df-output ' test fails due to extra space in header line on large disk Content-Type: multipart/mixed; boundary="------------050806070701070505020600" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------050806070701070505020600 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, Using the latest coreutils from git, 'tests/df/df-output' fails due to one extra space in the header line, needed to accommodate a large disk. Log attached, but the problem is likely this: # This is a large disk... $ ./src/df -hl . Filesystem Size Used Avail Use% Mounted on /dev/sdb1 33T 2.0T 31T 6% /data2 # The test command results in two spaces before the header $ ./src/df -B1K --output=size . 1K-blocks 35139364864 possible fix attached. -assaf --------------050806070701070505020600 Content-Type: text/x-patch; name="df-output-extra-space.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="df-output-extra-space.patch" >From 027c96eb977241d9c795fee510b51dd7b3013bd1 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Fri, 22 May 2015 14:09:27 -0400 Subject: [PATCH] tests: df-output: accept multiple spaces in header * tests/df/df-output.sh: allow for multiple spaces in the header line of 'df', resulting from large disks. --- tests/df/df-output.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/df/df-output.sh b/tests/df/df-output.sh index f469d41..d81f0ee 100755 --- a/tests/df/df-output.sh +++ b/tests/df/df-output.sh @@ -93,7 +93,7 @@ EOF df -B1K --output=size '.' >out || fail=1 sed -e '1 { - s/ // + s/ *// q }' out > out2 compare exp out2 || fail=1 -- 1.9.1 --------------050806070701070505020600 Content-Type: text/x-log; name="df-output-test-suite.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="df-output-test-suite.log" ========================================================== GNU coreutils 8.23.197-edc5b: ./tests/test-suite.log ========================================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: tests/df/df-output ======================== ++ initial_cwd_=/data2/agordon/sources/coreutils ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /data2/agordon/sources/coreutils gt-df-output.sh.XXXX +++ case $# in +++ destdir_=/data2/agordon/sources/coreutils +++ template_=gt-df-output.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 +++ case $d in +++ test -d /data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 ++++ ls -dgo /data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 ++++ tr S - +++ perms='drwx------ 2 10 May 22 14:07 /data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9' +++ case $perms in +++ test 0 = 0 +++ echo /data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 +++ return ++ test_dir_=/data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 ++ cd /data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/data2/agordon/sources/coreutils/./src + case $abs_path_dir_ in + PATH=/data2/agordon/sources/coreutils/./src:/data2/agordon/sources/coreutils/src:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games + create_exe_shims_ /data2/agordon/sources/coreutils/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ df + test yes = yes + local i + for i in '$*' + env df --version df (GNU coreutils) 8.23.197-edc5b Copyright (C) 2015 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Torbjorn Granlund, David MacKenzie, and Paul Eggert. + cat + df -i --output . + sed 's/ -i / OPT /' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + df --output -i . + sed 's/ -i / OPT /' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + df -P --output . + sed 's/ -P / OPT /' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + df --output -P . + sed 's/ -P / OPT /' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + df -T --output . + sed 's/ -T / OPT /' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + df --output -T . + sed 's/ -T / OPT /' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + cat + df --output=target,source,target . + compare exp out + compare_dev_null_ exp out + test 2 = 2 + test xexp = x/dev/null + test xout = x/dev/null + return 2 + case $? in + compare_ exp out + diff -u exp out + df --out=target,source --out=target . + compare exp out + compare_dev_null_ exp out + test 2 = 2 + test xexp = x/dev/null + test xout = x/dev/null + return 2 + case $? in + compare_ exp out + diff -u exp out + cat + df -h --o=source,fstype,itotal,iused,iavail,ipcent --o=size,used,avail,pcent,file,target . + sed -e '1 { s/ [ ]*/ /g q }' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + df -h --output . + sed -e '1 { s/ [ ]*/ /g q }' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + cat + df -B1K --output=size . + sed -e '1 { s/ // q }' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 --- exp 2015-05-22 14:07:39.943646993 -0400 +++ out2 2015-05-22 14:07:39.951646993 -0400 @@ -1 +1 @@ -1K-blocks + 1K-blocks + fail=1 + cat + df --output=source,target --total . + sed -n -e '3 { s/^total[ ]*// p q }' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + cat + df --output=target --total . + sed -n -e '3 { p q }' out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + df --help + grep ' --output' out + cat + df --output=file . exp + sed 1d out + compare exp out2 + compare_dev_null_ exp out2 + test 2 = 2 + test xexp = x/dev/null + test xout2 = x/dev/null + return 2 + case $? in + compare_ exp out2 + diff -u exp out2 + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /data2/agordon/sources/coreutils + chmod -R u+rwx /data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 + rm -rf /data2/agordon/sources/coreutils/gt-df-output.sh.Jwz9 + exit 1 --------------050806070701070505020600-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 22 15:47:20 2015 Received: (at 20631-done) by debbugs.gnu.org; 22 May 2015 19:47:20 +0000 Received: from localhost ([127.0.0.1]:53219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yvsud-00037e-EC for submit@debbugs.gnu.org; Fri, 22 May 2015 15:47:19 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:55139) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yvsub-00037Q-0Z for 20631-done@debbugs.gnu.org; Fri, 22 May 2015 15:47:18 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao4KAE6HX1VtTHCI/2dsb2JhbABcgxCCboFjxQeCUwKBOkwBAQEBAQGBC0EFg10BAQQjDwFWCw0LAgIFFgsCAgkDAgECAUUGAQwIAQGILAGwG4Vrnh4BK4EhihmFDIJogUUFkEaVVI8aI4I7gT49gngBAQE Received: from unknown (HELO localhost.localdomain) ([109.76.112.136]) by mail2.vodafone.ie with ESMTP; 22 May 2015 20:47:10 +0100 Message-ID: <555F87BE.8080306@draigBrady.com> Date: Fri, 22 May 2015 20:47:10 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Assaf Gordon , 20631-done@debbugs.gnu.org Subject: Re: bug#20631: 'df/df-output ' test fails due to extra space in header line on large disk References: <555F7252.80009@gmail.com> In-Reply-To: <555F7252.80009@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20631-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 22/05/15 19:15, Assaf Gordon wrote: > Hello, > > Using the latest coreutils from git, 'tests/df/df-output' fails due to one extra space in the header line, needed to accommodate a large disk. > > Log attached, but the problem is likely this: > > # This is a large disk... > $ ./src/df -hl . > Filesystem Size Used Avail Use% Mounted on > /dev/sdb1 33T 2.0T 31T 6% /data2 > > # The test command results in two spaces before the header > $ ./src/df -B1K --output=size . > 1K-blocks > 35139364864 Pushed. thanks! Pádraig From unknown Sat Aug 09 13:17:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 Jun 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator