From debbugs-submit-bounces@debbugs.gnu.org Mon May 18 10:26:42 2015 Received: (at submit) by debbugs.gnu.org; 18 May 2015 14:26:42 +0000 Received: from localhost ([127.0.0.1]:49266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YuM09-0008NH-DU for submit@debbugs.gnu.org; Mon, 18 May 2015 10:26:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57025) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YuM08-0008Mt-2y for submit@debbugs.gnu.org; Mon, 18 May 2015 10:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuLzt-0006dJ-St for submit@debbugs.gnu.org; Mon, 18 May 2015 10:26:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuLzt-0006dF-Q8 for submit@debbugs.gnu.org; Mon, 18 May 2015 10:26:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuLzo-0000wK-Bb for bug-gnu-emacs@gnu.org; Mon, 18 May 2015 10:26:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuLzl-0006aU-Jc for bug-gnu-emacs@gnu.org; Mon, 18 May 2015 10:26:20 -0400 Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:35827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuLzl-0006ZW-DM for bug-gnu-emacs@gnu.org; Mon, 18 May 2015 10:26:17 -0400 Received: by wgfl8 with SMTP id l8so38714013wgf.2 for ; Mon, 18 May 2015 07:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=NiHdSF1kIYLVbp2lfG1TcMje0l4RbxnyYinx3ZiCkCw=; b=Wslt/zvXp0yCpihNiVE9a96e7z1aXVIl8JPkfHzPcZML2g2MkCfEXdw3Xl6wDxpg1F Dln3NX4xs8Wd3BcrZCNS+02EANHa0gwOybc1w26U/xAeEcWt7APwErNbEeOiVAm/hQjT PEdRLaDVvOSOGc4tN1BmY4xf1/2sQCk9aV5j7BOi1s5TtCDT1pb3zSn+hH1LeIXG0Av+ lqhs9TowQGqNsk8DB8uZPpT1a+DkKoQrlqtOqfgSFvoziA5JVt3qBCtz1vrxXAvsKp7K WGcsQU98Dwbhi+XKjOSnvUWdlF5XN2yqknQ7doKherAgA8bBf+JuBAarZnL6WBfYFlPW +Ugg== X-Received: by 10.194.109.229 with SMTP id hv5mr26654731wjb.119.1431959175595; Mon, 18 May 2015 07:26:15 -0700 (PDT) Received: from io (dslc-082-083-223-254.pools.arcor-ip.net. [82.83.223.254]) by mx.google.com with ESMTPSA id v3sm12738050wix.8.2015.05.18.07.26.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2015 07:26:14 -0700 (PDT) From: Christoph Ruegge To: bug-gnu-emacs@gnu.org Subject: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook) Date: Mon, 18 May 2015 16:26:56 +0200 Message-ID: <877fs6gdvz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Documentation of make-local-variable says that this should not be done, and it causes problems with other code that wants to add to that hook. From debbugs-submit-bounces@debbugs.gnu.org Mon May 18 11:44:14 2015 Received: (at 20601) by debbugs.gnu.org; 18 May 2015 15:44:14 +0000 Received: from localhost ([127.0.0.1]:49315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YuNDB-0001nC-B5 for submit@debbugs.gnu.org; Mon, 18 May 2015 11:44:13 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:35861) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YuND8-0001mv-7R for 20601@debbugs.gnu.org; Mon, 18 May 2015 11:44:10 -0400 Received: by wgbgq6 with SMTP id gq6so19316883wgb.3 for <20601@debbugs.gnu.org>; Mon, 18 May 2015 08:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=QyWkd5SgVlWHfwTJfTPTA/4gOWIQBSFvgPZBHQMznzg=; b=RCl4hXhtras7ips2AKDMejqVBE3vM/a/Sv4iDV/8vgHEmmuQyj8ZMEyfgwBh0lNobE N2jngKt3gUHY2+DMsERtDy3Ac+75noqZ8/PUub+HOnE9Us5grrazNdAXamWSkyAeM76+ 2z17R6QaSBLDYF1EwEXXtvVTJtFnzMOt9qwLtUf/L1TfriSFDKctE0kMP9jKHyqcaFtc FZt1vBv2DwCAZY/GvFjxPb/Tqo1Llo153JicqxuwtStAJO+mah9I073lI3Rv0V+OlvUT 7mhbg+zmsR5w7EaXkjLZN+21XC7YHRFnNijaN3AHNBzuA0cGfG2sivjO8owMMyvi8k6b IRuQ== X-Received: by 10.180.8.98 with SMTP id q2mr19090989wia.53.1431963844224; Mon, 18 May 2015 08:44:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.27.146.195 with HTTP; Mon, 18 May 2015 08:43:33 -0700 (PDT) In-Reply-To: References: <877fs6gdvz.fsf@gmail.com> From: Christoph Ruegge Date: Mon, 18 May 2015 17:43:33 +0200 Message-ID: Subject: Re: bug#20601: Acknowledgement (25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook)) To: 20601@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20601 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) To expand this a bit, the following steps highlight a problem, starting from emacs -Q: 1) Eval "(custom-set-variables '(global-auto-revert-mode t) '(save-place-mode t nil (saveplace)))" in the *scratch* buffer. Now kill-buffer-hook contains save-place-to-alist. 2) Open another file. Now save-place-alist is gone from the hook. When changing autorevert.el to use add-hook's "local" parameter, the problem does not occur. From debbugs-submit-bounces@debbugs.gnu.org Fri May 22 00:04:05 2015 Received: (at 20601-done) by debbugs.gnu.org; 22 May 2015 04:04:05 +0000 Received: from localhost ([127.0.0.1]:52484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YveBp-0000pV-99 for submit@debbugs.gnu.org; Fri, 22 May 2015 00:04:05 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64112) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YveBm-0000ox-Jt for 20601-done@debbugs.gnu.org; Fri, 22 May 2015 00:04:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AwEwA731xV/xaz+M5cgxCEAoVVuzcJhH6CTQQCAoE8ORQBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQEFAQEBAR6LOoUFB4QtBbM/gUUjgjuBWSKCeAEBAQ X-IPAS-Result: A0AwEwA731xV/xaz+M5cgxCEAoVVuzcJhH6CTQQCAoE8ORQBAQEBAQEBgQpBBYNdAQEDAVYjBQsLDiYSFBgNJIg3CM8jAQEBAQEFAQEBAR6LOoUFB4QtBbM/gUUjgjuBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="121623891" Received: from 206-248-179-22.dsl.teksavvy.com (HELO pastel.home) ([206.248.179.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 22 May 2015 00:03:56 -0400 Received: by pastel.home (Postfix, from userid 20848) id 96514A1FE; Fri, 22 May 2015 00:03:56 -0400 (EDT) From: Stefan Monnier To: Christoph Ruegge Subject: Re: bug#20601: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook) Message-ID: References: <877fs6gdvz.fsf@gmail.com> Date: Fri, 22 May 2015 00:03:56 -0400 In-Reply-To: <877fs6gdvz.fsf@gmail.com> (Christoph Ruegge's message of "Mon, 18 May 2015 16:26:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 20601-done Cc: 20601-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Documentation of make-local-variable says that this should not be done, Rightly so, yes. > and it causes problems with other code that wants to add to that hook. Indeed, thanks for spotting it! Should be fixed now in master. Stefan From unknown Tue Jun 24 22:40:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 19 Jun 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator