GNU bug report logs - #20601
25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook)

Previous Next

Package: emacs;

Reported by: Christoph Ruegge <chrueg <at> gmail.com>

Date: Mon, 18 May 2015 14:27:01 UTC

Severity: normal

Found in version 25.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20601 in the body.
You can then email your comments to 20601 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#20601; Package emacs. (Mon, 18 May 2015 14:27:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Christoph Ruegge <chrueg <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 18 May 2015 14:27:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph Ruegge <chrueg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; autorevert.el calls (make-local-variable 'kill-buffer-hook)
Date: Mon, 18 May 2015 16:26:56 +0200

Documentation of make-local-variable says that this should not be done,
and it causes problems with other code that wants to add to that hook.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20601; Package emacs. (Mon, 18 May 2015 15:45:11 GMT) Full text and rfc822 format available.

Message #8 received at 20601 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Ruegge <chrueg <at> gmail.com>
To: 20601 <at> debbugs.gnu.org
Subject: Re: bug#20601: Acknowledgement (25.0.50; autorevert.el calls
 (make-local-variable 'kill-buffer-hook))
Date: Mon, 18 May 2015 17:43:33 +0200

To expand this a bit, the following steps highlight a problem,
starting from emacs -Q:

1) Eval "(custom-set-variables '(global-auto-revert-mode t)
'(save-place-mode t nil (saveplace)))" in the *scratch* buffer. Now
kill-buffer-hook contains save-place-to-alist.

2) Open another file. Now save-place-alist is gone from the hook.

When changing autorevert.el to use add-hook's "local" parameter, the
problem does not occur.
Reply sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
You have taken responsibility. (Fri, 22 May 2015 04:05:02 GMT) Full text and rfc822 format available.
Notification sent to Christoph Ruegge <chrueg <at> gmail.com>:
bug acknowledged by developer. (Fri, 22 May 2015 04:05:03 GMT) Full text and rfc822 format available.

Message #13 received at 20601-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Christoph Ruegge <chrueg <at> gmail.com>
Cc: 20601-done <at> debbugs.gnu.org
Subject: Re: bug#20601: 25.0.50;
 autorevert.el calls (make-local-variable 'kill-buffer-hook)
Date: Fri, 22 May 2015 00:03:56 -0400

> Documentation of make-local-variable says that this should not be done,

Rightly so, yes.

> and it causes problems with other code that wants to add to that hook.

Indeed, thanks for spotting it!  Should be fixed now in master.


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 19 Jun 2015 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 10 years and 8 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.