From unknown Thu Aug 21 14:53:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20588: [PATCH] 24.5; delete-consecutive-dups may loop infinity Resent-From: Shigeru Fukaya Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 May 2015 05:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20588 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 20588@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.143175353424882 (code B ref -1); Sat, 16 May 2015 05:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 May 2015 05:18:54 +0000 Received: from localhost ([127.0.0.1]:46702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtUUv-0006TE-86 for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35420) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtUUs-0006T0-Ky for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtUUm-0007Bh-Ks for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FSL_HELO_FAKE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUm-0007Bb-HK for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUl-0005zY-JN for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtUUi-0007Ab-DT for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:43 -0400 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:34678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUi-0007A9-4q for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:40 -0400 Received: by pdeq5 with SMTP id q5so46432076pde.1 for ; Fri, 15 May 2015 22:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:mime-version:content-type:message-id; bh=1RSohDnH/7cTo1ZGsXqj8EMIxIz234JUh/waYVhtMVM=; b=yBbX65TN3DalUSCpRUvSDsxp/7O7+dILcEOaZoH1//D1lfG75X2OIOKTsk0Gg3RMzc tpJW47soUqquAU6Paqdf+Jnq67XRra00uA/JFge8ezzRHsqccNbZ/DPoR/bbqEPR9Eq/ 3NyyJTUcfja0FrbMTt4k93FQfz/3Cr1i0cPg9dNUBeNozrRWdF2xI/YPBjbK+3yHyQR0 EmmeYTP+fbu1DWG28HE+RUBFhHHD7lIwVY5WDz6uClq7SYh1bktVjScI6/hMDC/gLzvq mesuu6+o6l5qAT/CwABp2TUslhKec29w68GWjyA1S3upW0BVJinbTcEK0IcxcOcAKz3+ HwTw== X-Received: by 10.68.219.1 with SMTP id pk1mr24455657pbc.18.1431753518389; Fri, 15 May 2015 22:18:38 -0700 (PDT) Received: from gmail.com (115x125x38x32.ap115.ftth.ucom.ne.jp. [115.125.38.32]) by mx.google.com with ESMTPSA id p5sm3472616pdi.2.2015.05.15.22.18.36 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 22:18:37 -0700 (PDT) From: Shigeru Fukaya Date: Sat, 16 May 2015 14:18:35 +0900 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-n7A5Iqhq9hlcHHbQ193C0" X-Mailer: HidemaruMail 6.30 (WinNT,602) Message-Id: <70D08F97C21E77shigeru.fukaya@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello. delete-consecutive-dups falls into infinite loop if the last element is nil. The attached code will fix it, and besides, avoid re-scan (call of nbutlast) of a circular list in deletion of the last element. Regards, Shigeru --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: application/octet-stream; name="subr.diff" Content-Disposition: attachment; filename="subr.diff" Content-Transfer-Encoding: base64 KioqIHN1YnIuZWwJVGh1IE1heSAgNyAxMjoyNDoyMSAyMDE1Ci0tLSBzdWJyLm5ldy5lbAlT YXQgTWF5IDE2IDEzOjQwOjQ3IDIwMTUKKioqKioqKioqKioqKioqCioqKiA0NDAsNDU1ICoq KioKICBGaXJzdCBhbmQgbGFzdCBlbGVtZW50cyBhcmUgY29uc2lkZXJlZCBjb25zZWN1dGl2 ZSBpZiBDSVJDVUxBUiBpcwogIG5vbi1uaWwuIgogICAgKGxldCAoKHRhaWwgbGlzdCkgbGFz dCkKISAgICAgKHdoaWxlIChjb25zcCB0YWlsKQogICAgICAgIChpZiAoZXF1YWwgKGNhciB0 YWlsKSAoY2FkciB0YWlsKSkKICAJICAoc2V0Y2RyIHRhaWwgKGNkZHIgdGFpbCkpCiEgCShz ZXRxIGxhc3QgKGNhciB0YWlsKQogIAkgICAgICB0YWlsIChjZHIgdGFpbCkpKSkKICAgICAg KGlmIChhbmQgY2lyY3VsYXIKISAJICAgICAoY2RyIGxpc3QpCiEgCSAgICAgKGVxdWFsIGxh c3QgKGNhciBsaXN0KSkpCiEgCShuYnV0bGFzdCBsaXN0KQohICAgICAgIGxpc3QpKSkKICAK ICAoZGVmdW4gbnVtYmVyLXNlcXVlbmNlIChmcm9tICZvcHRpb25hbCB0byBpbmMpCiAgICAi UmV0dXJuIGEgc2VxdWVuY2Ugb2YgbnVtYmVycyBmcm9tIEZST00gdG8gVE8gKGJvdGggaW5j bHVzaXZlKSBhcyBhIGxpc3QuCi0tLSA0NDAsNDU1IC0tLS0KICBGaXJzdCBhbmQgbGFzdCBl bGVtZW50cyBhcmUgY29uc2lkZXJlZCBjb25zZWN1dGl2ZSBpZiBDSVJDVUxBUiBpcwogIG5v bi1uaWwuIgogICAgKGxldCAoKHRhaWwgbGlzdCkgbGFzdCkKISAgICAgKHdoaWxlIChjZHIg dGFpbCkKICAgICAgICAoaWYgKGVxdWFsIChjYXIgdGFpbCkgKGNhZHIgdGFpbCkpCiAgCSAg KHNldGNkciB0YWlsIChjZGRyIHRhaWwpKQohIAkoc2V0cSBsYXN0IHRhaWwKICAJICAgICAg dGFpbCAoY2RyIHRhaWwpKSkpCiAgICAgIChpZiAoYW5kIGNpcmN1bGFyCiEgCSAgICAgbGFz dAohIAkgICAgIChlcXVhbCAoY2FyIHRhaWwpIChjYXIgbGlzdCkpKQohIAkoc2V0Y2RyIGxh c3QgbmlsKSkpCiEgICBsaXN0KQogIAogIChkZWZ1biBudW1iZXItc2VxdWVuY2UgKGZyb20g Jm9wdGlvbmFsIHRvIGluYykKICAgICJSZXR1cm4gYSBzZXF1ZW5jZSBvZiBudW1iZXJzIGZy b20gRlJPTSB0byBUTyAoYm90aCBpbmNsdXNpdmUpIGFzIGEgbGlzdC4K --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: application/octet-stream; name="ChangeLog" Content-Disposition: attachment; filename="ChangeLog" Content-Transfer-Encoding: base64 CSogc3Vici5lbCAoZGVsZXRlLWNvbnNlY3V0aXZlLWR1cHMpOiBBdm9pZCBpbmZpbml0ZSBs b29wIGFuZAoJaW52b2NhdGlvbiBvZiBuYnV0bGFzdC4K --Boundary-n7A5Iqhq9hlcHHbQ193C0-- From unknown Thu Aug 21 14:53:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20588: [PATCH] 24.5; delete-consecutive-dups may loop infinity In-Reply-To: <70D08F97C21E77shigeru.fukaya@gmail.com> Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 May 2015 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20588 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 20588@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14317633358809 (code B ref -1); Sat, 16 May 2015 08:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 May 2015 08:02:15 +0000 Received: from localhost ([127.0.0.1]:46763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtX31-0002I1-9i for submit@debbugs.gnu.org; Sat, 16 May 2015 04:02:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55901) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtX2y-0002Hh-PO for submit@debbugs.gnu.org; Sat, 16 May 2015 04:02:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtX2t-0001NR-09 for submit@debbugs.gnu.org; Sat, 16 May 2015 04:02:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_20,FREEMAIL_FROM, FSL_HELO_BARE_IP_2,RCVD_NUMERIC_HELO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtX2s-0001NN-TV for submit@debbugs.gnu.org; Sat, 16 May 2015 04:02:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtX2s-00040R-3B for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 04:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtX2o-0001Mr-Tq for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 04:02:06 -0400 Received: from plane.gmane.org ([80.91.229.3]:55902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtX2o-0001Mm-OH for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 04:02:02 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YtX2m-0005TX-Ho for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 10:02:00 +0200 Received: from 221.222.156.172 ([221.222.156.172]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 May 2015 10:02:00 +0200 Received: from sdl.web by 221.222.156.172 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 May 2015 10:02:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Leo Liu Date: Sat, 16 May 2015 16:01:51 +0800 Lines: 8 Message-ID: References: <70D08F97C21E77shigeru.fukaya@gmail.com> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 221.222.156.172 Face: iVBORw0KGgoAAAANSUhEUgAAACkAAAApAQAAAACAGz1bAAABKElEQVQYlWNg3NIt5FDPUPt7 4+X79Qyucz5/ugik+L2PBgKpyphaIK921q23QDnG0NBQoMr/vaWl9f8ZLL78uPv5PwN7RETfzXoG jhmFz27XM0RXmpuY/WfY+fv0Mc56BvFybfXA/wwL5t/wF61n2PU59axXPcOVzbmSW/8zrNt1benC /ww70hqUU/4zKCtrT9jwn8FhwynbufUMendE2aLqGRpdX9al1zM8eh17lKeeQcTMrdD5P8P3j/YT Q/8zXHSb7p1Qz/C4OM2JuZ7hgtI7K6AjqsMnf8j4z8C6xG1tw3+GqpqvsVn/GTzmpD9j/8/wP/oZ S/l/Bka+QO/g/wy15ueeFQL9N1O8mPU/g+umV3t1gdT0/1bTgHLqYVeXAlWKpMWt+w8Az82C9nHf X0cAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (OS X 10.10.3) Cancel-Lock: sha1:0wlHRT2tMF0UjXV2BRtBg0QnTfc= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On 2015-05-16 13:18 +0800, Shigeru Fukaya wrote: > delete-consecutive-dups falls into infinite loop if the last element > is nil. The attached code will fix it, and besides, avoid re-scan > (call of nbutlast) of a circular list in deletion of the last element. Thanks for the fix. Could you commit it to master? Leo From unknown Thu Aug 21 14:53:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Shigeru Fukaya Subject: bug#20588: closed (Re: [PATCH] 24.5; delete-consecutive-dups may loop infinity) Message-ID: References: <55B51CAE.8030209@cs.ucla.edu> <70D08F97C21E77shigeru.fukaya@gmail.com> X-Gnu-PR-Message: they-closed 20588 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 20588@debbugs.gnu.org Date: Sun, 26 Jul 2015 17:46:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1437932762-21759-1" This is a multi-part message in MIME format... ------------=_1437932762-21759-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20588: [PATCH] 24.5; delete-consecutive-dups may loop infinity which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20588@debbugs.gnu.org. --=20 20588: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20588 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1437932762-21759-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20588-done) by debbugs.gnu.org; 26 Jul 2015 17:45:24 +0000 Received: from localhost ([127.0.0.1]:59368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJPzH-0005eA-Eu for submit@debbugs.gnu.org; Sun, 26 Jul 2015 13:45:23 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34282) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZJPzE-0005e1-LU for 20588-done@debbugs.gnu.org; Sun, 26 Jul 2015 13:45:21 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E4ECD16099B; Sun, 26 Jul 2015 10:45:19 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id K5vBrGcF3_KO; Sun, 26 Jul 2015 10:45:19 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 42847160CB6; Sun, 26 Jul 2015 10:45:19 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id icsfOj2sywGJ; Sun, 26 Jul 2015 10:45:19 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 267BC16099B; Sun, 26 Jul 2015 10:45:19 -0700 (PDT) Message-ID: <55B51CAE.8030209@cs.ucla.edu> Date: Sun, 26 Jul 2015 10:45:18 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Shigeru Fukaya Subject: Re: [PATCH] 24.5; delete-consecutive-dups may loop infinity Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20588-done Cc: 20588-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thanks for the patch. I installed it into the master. ------------=_1437932762-21759-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 May 2015 05:18:54 +0000 Received: from localhost ([127.0.0.1]:46702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtUUv-0006TE-86 for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35420) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YtUUs-0006T0-Ky for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtUUm-0007Bh-Ks for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.4 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FSL_HELO_FAKE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUm-0007Bb-HK for submit@debbugs.gnu.org; Sat, 16 May 2015 01:18:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUl-0005zY-JN for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YtUUi-0007Ab-DT for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:43 -0400 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]:34678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YtUUi-0007A9-4q for bug-gnu-emacs@gnu.org; Sat, 16 May 2015 01:18:40 -0400 Received: by pdeq5 with SMTP id q5so46432076pde.1 for ; Fri, 15 May 2015 22:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:mime-version:content-type:message-id; bh=1RSohDnH/7cTo1ZGsXqj8EMIxIz234JUh/waYVhtMVM=; b=yBbX65TN3DalUSCpRUvSDsxp/7O7+dILcEOaZoH1//D1lfG75X2OIOKTsk0Gg3RMzc tpJW47soUqquAU6Paqdf+Jnq67XRra00uA/JFge8ezzRHsqccNbZ/DPoR/bbqEPR9Eq/ 3NyyJTUcfja0FrbMTt4k93FQfz/3Cr1i0cPg9dNUBeNozrRWdF2xI/YPBjbK+3yHyQR0 EmmeYTP+fbu1DWG28HE+RUBFhHHD7lIwVY5WDz6uClq7SYh1bktVjScI6/hMDC/gLzvq mesuu6+o6l5qAT/CwABp2TUslhKec29w68GWjyA1S3upW0BVJinbTcEK0IcxcOcAKz3+ HwTw== X-Received: by 10.68.219.1 with SMTP id pk1mr24455657pbc.18.1431753518389; Fri, 15 May 2015 22:18:38 -0700 (PDT) Received: from gmail.com (115x125x38x32.ap115.ftth.ucom.ne.jp. [115.125.38.32]) by mx.google.com with ESMTPSA id p5sm3472616pdi.2.2015.05.15.22.18.36 for (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 22:18:37 -0700 (PDT) From: Shigeru Fukaya To: bug-gnu-emacs@gnu.org Subject: [PATCH] 24.5; delete-consecutive-dups may loop infinity Date: Sat, 16 May 2015 14:18:35 +0900 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-n7A5Iqhq9hlcHHbQ193C0" X-Mailer: HidemaruMail 6.30 (WinNT,602) Message-Id: <70D08F97C21E77shigeru.fukaya@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello. delete-consecutive-dups falls into infinite loop if the last element is nil. The attached code will fix it, and besides, avoid re-scan (call of nbutlast) of a circular list in deletion of the last element. Regards, Shigeru --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: application/octet-stream; name="subr.diff" Content-Disposition: attachment; filename="subr.diff" Content-Transfer-Encoding: base64 KioqIHN1YnIuZWwJVGh1IE1heSAgNyAxMjoyNDoyMSAyMDE1Ci0tLSBzdWJyLm5ldy5lbAlT YXQgTWF5IDE2IDEzOjQwOjQ3IDIwMTUKKioqKioqKioqKioqKioqCioqKiA0NDAsNDU1ICoq KioKICBGaXJzdCBhbmQgbGFzdCBlbGVtZW50cyBhcmUgY29uc2lkZXJlZCBjb25zZWN1dGl2 ZSBpZiBDSVJDVUxBUiBpcwogIG5vbi1uaWwuIgogICAgKGxldCAoKHRhaWwgbGlzdCkgbGFz dCkKISAgICAgKHdoaWxlIChjb25zcCB0YWlsKQogICAgICAgIChpZiAoZXF1YWwgKGNhciB0 YWlsKSAoY2FkciB0YWlsKSkKICAJICAoc2V0Y2RyIHRhaWwgKGNkZHIgdGFpbCkpCiEgCShz ZXRxIGxhc3QgKGNhciB0YWlsKQogIAkgICAgICB0YWlsIChjZHIgdGFpbCkpKSkKICAgICAg KGlmIChhbmQgY2lyY3VsYXIKISAJICAgICAoY2RyIGxpc3QpCiEgCSAgICAgKGVxdWFsIGxh c3QgKGNhciBsaXN0KSkpCiEgCShuYnV0bGFzdCBsaXN0KQohICAgICAgIGxpc3QpKSkKICAK ICAoZGVmdW4gbnVtYmVyLXNlcXVlbmNlIChmcm9tICZvcHRpb25hbCB0byBpbmMpCiAgICAi UmV0dXJuIGEgc2VxdWVuY2Ugb2YgbnVtYmVycyBmcm9tIEZST00gdG8gVE8gKGJvdGggaW5j bHVzaXZlKSBhcyBhIGxpc3QuCi0tLSA0NDAsNDU1IC0tLS0KICBGaXJzdCBhbmQgbGFzdCBl bGVtZW50cyBhcmUgY29uc2lkZXJlZCBjb25zZWN1dGl2ZSBpZiBDSVJDVUxBUiBpcwogIG5v bi1uaWwuIgogICAgKGxldCAoKHRhaWwgbGlzdCkgbGFzdCkKISAgICAgKHdoaWxlIChjZHIg dGFpbCkKICAgICAgICAoaWYgKGVxdWFsIChjYXIgdGFpbCkgKGNhZHIgdGFpbCkpCiAgCSAg KHNldGNkciB0YWlsIChjZGRyIHRhaWwpKQohIAkoc2V0cSBsYXN0IHRhaWwKICAJICAgICAg dGFpbCAoY2RyIHRhaWwpKSkpCiAgICAgIChpZiAoYW5kIGNpcmN1bGFyCiEgCSAgICAgbGFz dAohIAkgICAgIChlcXVhbCAoY2FyIHRhaWwpIChjYXIgbGlzdCkpKQohIAkoc2V0Y2RyIGxh c3QgbmlsKSkpCiEgICBsaXN0KQogIAogIChkZWZ1biBudW1iZXItc2VxdWVuY2UgKGZyb20g Jm9wdGlvbmFsIHRvIGluYykKICAgICJSZXR1cm4gYSBzZXF1ZW5jZSBvZiBudW1iZXJzIGZy b20gRlJPTSB0byBUTyAoYm90aCBpbmNsdXNpdmUpIGFzIGEgbGlzdC4K --Boundary-n7A5Iqhq9hlcHHbQ193C0 Content-Type: application/octet-stream; name="ChangeLog" Content-Disposition: attachment; filename="ChangeLog" Content-Transfer-Encoding: base64 CSogc3Vici5lbCAoZGVsZXRlLWNvbnNlY3V0aXZlLWR1cHMpOiBBdm9pZCBpbmZpbml0ZSBs b29wIGFuZAoJaW52b2NhdGlvbiBvZiBuYnV0bGFzdC4K --Boundary-n7A5Iqhq9hlcHHbQ193C0-- ------------=_1437932762-21759-1--