GNU bug report logs - #20588
[PATCH] 24.5; delete-consecutive-dups may loop infinity

Previous Next

Package: emacs;

Reported by: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>

Date: Sat, 16 May 2015 05:19:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20588 in the body.
You can then email your comments to 20588 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#20588; Package emacs. (Sat, 16 May 2015 05:19:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Shigeru Fukaya <shigeru.fukaya <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 16 May 2015 05:19:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 24.5; delete-consecutive-dups may loop infinity
Date: Sat, 16 May 2015 14:18:35 +0900

[Message part 1 (text/plain, inline)]
Hello.

delete-consecutive-dups falls into infinite loop if the last element
is nil.  The attached code will fix it, and besides, avoid re-scan
(call of nbutlast) of a circular list in deletion of the last element.

Regards,
Shigeru

[subr.diff (application/octet-stream, attachment)]
[ChangeLog (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#20588; Package emacs. (Sat, 16 May 2015 08:03:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#20588: [PATCH] 24.5; delete-consecutive-dups may loop infinity
Date: Sat, 16 May 2015 16:01:51 +0800

On 2015-05-16 13:18 +0800, Shigeru Fukaya wrote:
> delete-consecutive-dups falls into infinite loop if the last element
> is nil.  The attached code will fix it, and besides, avoid re-scan
> (call of nbutlast) of a circular list in deletion of the last element.

Thanks for the fix. Could you commit it to master?

Leo
Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Sun, 26 Jul 2015 17:46:01 GMT) Full text and rfc822 format available.
Notification sent to Shigeru Fukaya <shigeru.fukaya <at> gmail.com>:
bug acknowledged by developer. (Sun, 26 Jul 2015 17:46:02 GMT) Full text and rfc822 format available.

Message #13 received at 20588-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
Cc: 20588-done <at> debbugs.gnu.org
Subject: Re:  [PATCH] 24.5; delete-consecutive-dups may loop infinity
Date: Sun, 26 Jul 2015 10:45:18 -0700

Thanks for the patch.  I installed it into the master.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 24 Aug 2015 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 9 years and 364 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.