From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 01:25:06 2015 Received: (at submit) by debbugs.gnu.org; 14 May 2015 05:25:07 +0000 Received: from localhost ([127.0.0.1]:44263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ysldp-0007Q0-HI for submit@debbugs.gnu.org; Thu, 14 May 2015 01:25:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42047) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YsjHs-0007go-Ms for submit@debbugs.gnu.org; Wed, 13 May 2015 22:54:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsjHm-0003DR-7I for submit@debbugs.gnu.org; Wed, 13 May 2015 22:54:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsjHm-0003DH-41 for submit@debbugs.gnu.org; Wed, 13 May 2015 22:54:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsjHl-00055v-1L for bug-coreutils@gnu.org; Wed, 13 May 2015 22:54:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsjHh-0003AE-RN for bug-coreutils@gnu.org; Wed, 13 May 2015 22:54:08 -0400 Received: from achille.seblu.net ([62.210.204.83]:41204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsjHh-00037S-LO for bug-coreutils@gnu.org; Wed, 13 May 2015 22:54:05 -0400 Received: from murphy (slice.seblu.net [81.57.151.16]) by achille.seblu.net (Postfix) with ESMTPSA id B78F950C0772 for ; Thu, 14 May 2015 04:53:57 +0200 (CEST) Message-ID: <1431572037.5455.76.camel@seblu.net> Subject: Test dd/sparse.sh fail with btrfs From: =?ISO-8859-1?Q?S=E9bastien?= Luttringer To: bug-coreutils@gnu.org Date: Thu, 14 May 2015 04:53:57 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.1 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 14 May 2015 01:25:04 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hello, I experience one test suite failure when I tried to rebuild the coreutils v8.23 package. My system is an archlinux host with a btrfs filesystem. The test doesn't fail when I run it in a tmpfs. I'm pretty sure it used to works over btrfs in july 2014[1] when I built the previous package for archlinux. The failing section is the following: # Ensure NUL blocks smaller than the block size are not made sparse. # Here, with a 2MiB block size, dd's conv=3Dsparse must *not* introduce a hole.=20 dd if=3Dfile.in of=3Dfile.out bs=3D2M conv=3Dsparse test 2500 -lt $(kb_alloc file.out) || fail=3D1 You can see the full shell output here: http://pastebin.com/XADb1BKj Regards, [1] https://www.archlinux.org/packages/core/x86_64/coreutils/ --=20 S=C3=A9bastien "Seblu" Luttringer https://seblu.net | Twitter: @seblu42 GPG: 0x2072D77A From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 06:48:43 2015 Received: (at 20570) by debbugs.gnu.org; 14 May 2015 10:48:43 +0000 Received: from localhost ([127.0.0.1]:44472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ysqgz-00048z-TS for submit@debbugs.gnu.org; Thu, 14 May 2015 06:48:42 -0400 Received: from mail1.vodafone.ie ([213.233.128.43]:29621) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ysqgv-00048j-Og for 20570@debbugs.gnu.org; Thu, 14 May 2015 06:48:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqMPAH98VFVtTLyB/2dsb2JhbABcgw9UWQWDHsMzhXMBAgKBOkwBAQEBAQGBC0EBBINcAQEBBCNmCw0EAwECAQkWCwICCQMCAQIBPQgGAQwGAgEBiCwBAwWxD4VqnkoBAQEBAQEBAwEBAQEBAQEBGos6hHQYgmiBRQWUaoFAXogvhheHfwkHhm4jg3g9MYJGAQEB Received: from unknown (HELO localhost.localdomain) ([109.76.188.129]) by mail1.vodafone.ie with ESMTP; 14 May 2015 11:48:30 +0100 Message-ID: <55547D7E.1080708@draigBrady.com> Date: Thu, 14 May 2015 11:48:30 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: =?UTF-8?B?U8OpYmFzdGllbiBMdXR0cmluZ2Vy?= , 20570@debbugs.gnu.org Subject: Re: bug#20570: Test dd/sparse.sh fail with btrfs References: <1431572037.5455.76.camel@seblu.net> In-Reply-To: <1431572037.5455.76.camel@seblu.net> Content-Type: multipart/mixed; boundary="------------080901090908070200070503" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20570 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------080901090908070200070503 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 14/05/15 03:53, Sébastien Luttringer wrote: > Hello, > > I experience one test suite failure when I tried to rebuild the > coreutils v8.23 package. My system is an archlinux host with a btrfs > filesystem. > > The test doesn't fail when I run it in a tmpfs. I'm pretty sure it used > to works over btrfs in july 2014[1] when I built the previous package > for archlinux. > > The failing section is the following: > > # Ensure NUL blocks smaller than the block size are not made sparse. > # Here, with a 2MiB block size, dd's conv=sparse must *not* > introduce a hole. > dd if=file.in of=file.out bs=2M conv=sparse > test 2500 -lt $(kb_alloc file.out) || fail=1 > > You can see the full shell output here: http://pastebin.com/XADb1BKj > > Regards, > > [1] https://www.archlinux.org/packages/core/x86_64/coreutils/ It seems the allocation is async. I also see this intermittently with BTRFS on 4.0.0-0.rc5.git4.1.fc22.x86_64 I've been unable to reproduce with the attached which syncs the file before checking the allocation. thanks! Pádraig. --------------080901090908070200070503 Content-Type: text/x-patch; name="dd-sparse-btrfs.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="dd-sparse-btrfs.patch" =46rom 77e092c85ed9ae2221042323cf87f4fc8c847e75 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?P=3DC3=3DA1draig=3D20Brady?=3D Date: Thu, 14 May 2015 11:43:54 +0100 Subject: [PATCH] tests: fix async allocation race on BTRFS * tests/dd/sparse.sh: Sync files before checking allocations, which may be done asynchronously on NFS and BTRFS at least. Also mark this test as very expensive on remote file systems. * tests/tail-2/inotify-rotate-resources.sh: Use the more standard is_local_dir_() to check remoteness. * tests/cp/fiemap-empty.sh: Comment on the sync issue for this currerntly unused test. Fixes http://bugs.gnu.org/20570 --- tests/cp/fiemap-empty.sh | 1 + tests/dd/sparse.sh | 9 ++++++++- tests/tail-2/inotify-rotate-resources.sh | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/tests/cp/fiemap-empty.sh b/tests/cp/fiemap-empty.sh index a5eaac5..b3b2cd7 100755 --- a/tests/cp/fiemap-empty.sh +++ b/tests/cp/fiemap-empty.sh @@ -22,6 +22,7 @@ print_ver_ cp # FIXME: enable any part of this test that is still relevant, # or, if none are relevant (now that cp does not handle unwritten # extents), just remove the test altogether. +# Note also if checking allocations may need to sync first on BTRFS at l= east skip_ 'disabled for now' =20 touch fiemap_chk diff --git a/tests/dd/sparse.sh b/tests/dd/sparse.sh index 4fdabad..fde5b32 100755 --- a/tests/dd/sparse.sh +++ b/tests/dd/sparse.sh @@ -17,6 +17,7 @@ =20 . "${srcdir=3D.}/tests/init.sh"; path_prepend_ ./src print_ver_ dd +is_local_dir_ . || very_expensive_ require_sparse_support_ =20 # Ensure basic sparse generation works @@ -50,6 +51,9 @@ dd if=3D/dev/zero of=3Dfile.in bs=3D1M count=3D1 see= k=3D1 conv=3Dnotrunc || fail=3D1 =20 kb_alloc() { du -k "$1"|cut -f1; } =20 +# sync out data for async allocators like NFS/BTRFS +# sync file.in || fail=3D1 + # If our just-created input file appears to be too small, # skip the remaining tests. On at least Solaris 10 with NFS, # file.in is reported to occupy <=3D 1KiB for about 50 seconds @@ -58,7 +62,10 @@ if test $(kb_alloc file.in) -gt 3000; then =20 # Ensure NUL blocks smaller than the block size are not made sparse. # Here, with a 2MiB block size, dd's conv=3Dsparse must *not* introduc= e a hole. - dd if=3Dfile.in of=3Dfile.out bs=3D2M conv=3Dsparse + dd if=3Dfile.in of=3Dfile.out bs=3D2M conv=3Dsparse || fail=3D1 + + # Intermittently BTRFS returns 0 allocation for file.out unless synced= + sync file.out || fail=3D1 test 2500 -lt $(kb_alloc file.out) || fail=3D1 =20 # Note we recreate a sparse file first to avoid diff --git a/tests/tail-2/inotify-rotate-resources.sh b/tests/tail-2/inot= ify-rotate-resources.sh index c13959e..d6629a8 100755 --- a/tests/tail-2/inotify-rotate-resources.sh +++ b/tests/tail-2/inotify-rotate-resources.sh @@ -25,7 +25,7 @@ grep '^#define HAVE_INOTIFY 1' "$CONFIG_HEADER" >/dev/n= ull \ require_strace_ 'inotify_add_watch,inotify_rm_watch' =20 # Quickly skip on remote file systems -df --local . >/dev/null 2>&1 || +is_local_dir . >/dev/null 2>&1 || skip_ 'inotify not used on remote file system' =20 check_tail_output() --=20 2.3.4 --------------080901090908070200070503-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 06:50:39 2015 Received: (at control) by debbugs.gnu.org; 14 May 2015 10:50:39 +0000 Received: from localhost ([127.0.0.1]:44480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ysqir-0004CS-Up for submit@debbugs.gnu.org; Thu, 14 May 2015 06:50:38 -0400 Received: from mail1.vodafone.ie ([213.233.128.43]:20652) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ysqiq-0004CC-8K for control@debbugs.gnu.org; Thu, 14 May 2015 06:50:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuoLAKx9VFVtTLyB/2dsb2JhbABcgw+BEoFbgWOJNKoxlTc1gQ9MAQEBAQEBgQtBBYN8CipUDQIFFgsCCwMCAQIBOQYCAggNCAEBiCwBoUaPV4VqnnaBIZINgUUFpU6OfSOBRwEBCAIBgiQ9gncCAQI Received: from unknown (HELO localhost.localdomain) ([109.76.188.129]) by mail1.vodafone.ie with ESMTP; 14 May 2015 11:50:09 +0100 Message-ID: <55547DE1.8070700@draigBrady.com> Date: Thu, 14 May 2015 11:50:09 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: GNU bug tracker automated control server Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 20570 stop [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [213.233.128.43 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 20570 stop [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [213.233.128.43 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject close 20570 stop From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 09:15:13 2015 Received: (at 20570) by debbugs.gnu.org; 14 May 2015 13:15:13 +0000 Received: from localhost ([127.0.0.1]:44595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yssyl-0002I2-RO for submit@debbugs.gnu.org; Thu, 14 May 2015 09:15:13 -0400 Received: from mail1.vodafone.ie ([213.233.128.43]:58118) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yssyg-0002H5-EA; Thu, 14 May 2015 09:15:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap0KALaeVFVtTLyB/2dsb2JhbABcgw9UWQWDHrkyiX2FdgKBPEwBAQEBAQGBC0EFg1wBAQEEI2YLDQQDAQIBCSECAg8CPggGAQwGAgEBiCwBAwWwHYVqnkwBAQEBAQEBAwEBAQEBAQEBARmLOoR0GIJogUUFhmOOB4FAXogvhheHfwkHhm4jggYfgVM9MQGCRQEBAQ Received: from unknown (HELO localhost.localdomain) ([109.76.188.129]) by mail1.vodafone.ie with ESMTP; 14 May 2015 14:14:59 +0100 Message-ID: <55549FD2.60704@draigBrady.com> Date: Thu, 14 May 2015 14:14:58 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: =?UTF-8?B?U8OpYmFzdGllbiBMdXR0cmluZ2Vy?= , 20570@debbugs.gnu.org Subject: Re: bug#20574: Test du/2g.sh fails with btrfs References: <1431605994.5455.81.camel@seblu.net> In-Reply-To: <1431605994.5455.81.camel@seblu.net> Content-Type: multipart/mixed; boundary="------------050504060408070507010805" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20570 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------050504060408070507010805 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit forcemerge 20570 20574 stop On 14/05/15 13:19, Sébastien Luttringer wrote: > Hello, > > In the same spirit than my yesterday report[1], the following test > fail on btrfs when it works on tmpfs. > > $ RUN_VERY_EXPENSIVE_TESTS=yes ./tests/du/2g.sh > creating a 2GB file: 100% complete--- exp 2015-05-14 14:03:36.124772165 +0200+++ out 2015-05-14 14:03:36.123772158 +0200@@ -1 +1 @@-~2M+1572864 big > You can find the full output of the test suite here [2]. > Regards, > [1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20570 > [2] http://pastebin.com/akytxtts Drats I only tested on a 1G BTRFS loopback partition and so missed that. Updated patch is attached. cheers, Pádraig. --------------050504060408070507010805 Content-Type: text/x-patch; name="btrfs-alloc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="btrfs-alloc.patch" >From 7f0f58fdd68e7ca86dd5db7effb2c7f94adc4a08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Thu, 14 May 2015 11:43:54 +0100 Subject: [PATCH] tests: fix async allocation race on BTRFS * tests/dd/sparse.sh: Sync files before checking allocations, which may be done asynchronously on NFS and BTRFS at least. Also mark this test as very expensive on remote file systems. * tests/du/2g.sh: Likewise, also use fallocate if available to efficiently allocate the large file, otherwise skip on remote file systems. * tests/tail-2/inotify-rotate-resources.sh: Use the more standard is_local_dir_() to check remoteness. * tests/cp/fiemap-empty.sh: Comment on the sync issue for this currerntly unused test. Fixes http://bugs.gnu.org/20570 --- tests/cp/fiemap-empty.sh | 1 + tests/dd/sparse.sh | 9 ++++++++- tests/du/2g.sh | 26 ++++++++++++++++---------- tests/tail-2/inotify-rotate-resources.sh | 2 +- 4 files changed, 26 insertions(+), 12 deletions(-) diff --git a/tests/cp/fiemap-empty.sh b/tests/cp/fiemap-empty.sh index a5eaac5..b3b2cd7 100755 --- a/tests/cp/fiemap-empty.sh +++ b/tests/cp/fiemap-empty.sh @@ -22,6 +22,7 @@ print_ver_ cp # FIXME: enable any part of this test that is still relevant, # or, if none are relevant (now that cp does not handle unwritten # extents), just remove the test altogether. +# Note also if checking allocations may need to sync first on BTRFS at least skip_ 'disabled for now' touch fiemap_chk diff --git a/tests/dd/sparse.sh b/tests/dd/sparse.sh index 4fdabad..626b405 100755 --- a/tests/dd/sparse.sh +++ b/tests/dd/sparse.sh @@ -17,6 +17,7 @@ . "${srcdir=.}/tests/init.sh"; path_prepend_ ./src print_ver_ dd +is_local_dir_ . || very_expensive_ require_sparse_support_ # Ensure basic sparse generation works @@ -50,6 +51,9 @@ dd if=/dev/zero of=file.in bs=1M count=1 seek=1 conv=notrunc || fail=1 kb_alloc() { du -k "$1"|cut -f1; } +# sync out data for async allocators like NFS/BTRFS +# sync file.in || fail=1 + # If our just-created input file appears to be too small, # skip the remaining tests. On at least Solaris 10 with NFS, # file.in is reported to occupy <= 1KiB for about 50 seconds @@ -58,7 +62,10 @@ if test $(kb_alloc file.in) -gt 3000; then # Ensure NUL blocks smaller than the block size are not made sparse. # Here, with a 2MiB block size, dd's conv=sparse must *not* introduce a hole. - dd if=file.in of=file.out bs=2M conv=sparse + dd if=file.in of=file.out bs=2M conv=sparse || fail=1 + + # Intermittently BTRFS returns 0 allocation for file.out unless synced + sync file.out || framework_failure_ test 2500 -lt $(kb_alloc file.out) || fail=1 # Note we recreate a sparse file first to avoid diff --git a/tests/du/2g.sh b/tests/du/2g.sh index 5f04488..12c2eed 100755 --- a/tests/du/2g.sh +++ b/tests/du/2g.sh @@ -24,7 +24,6 @@ print_ver_ du # Creating a 2GB file counts as 'very expensive'. very_expensive_ - # Get number of free kilobytes on current partition, so we can # skip this test if there is insufficient free space. free_kb=$(df -k --output=avail . | tail -n1) @@ -42,15 +41,22 @@ test $min_kb -lt $free_kb || } big=big -rm -f $big -{ - for i in $(seq 100); do - # Note: 2147483648 == 2^31. Print floor(2^31/100) per iteration. - printf %21474836s x || fail=1 - done - # After the final iteration, append the remaining 48 bytes. - printf %48s x || fail=1 -} > $big || fail=1 + +if ! fallocate -l2G $big; then + rm -f $big + { + is_local_dir_ . || skip 'Not writing 2GB data to remote' + for i in $(seq 100); do + # Note: 2147483648 == 2^31. Print floor(2^31/100) per iteration. + printf %21474836s x || fail=1 + done + # After the final iteration, append the remaining 48 bytes. + printf %48s x || fail=1 + } > $big || fail=1 +fi + +# The allocation may be done asynchronously (BTRFS for example) +sync $big || framework_failure_ du -k $big > out1 || fail=1 rm -f $big diff --git a/tests/tail-2/inotify-rotate-resources.sh b/tests/tail-2/inotify-rotate-resources.sh index c13959e..d6629a8 100755 --- a/tests/tail-2/inotify-rotate-resources.sh +++ b/tests/tail-2/inotify-rotate-resources.sh @@ -25,7 +25,7 @@ grep '^#define HAVE_INOTIFY 1' "$CONFIG_HEADER" >/dev/null \ require_strace_ 'inotify_add_watch,inotify_rm_watch' # Quickly skip on remote file systems -df --local . >/dev/null 2>&1 || +is_local_dir . >/dev/null 2>&1 || skip_ 'inotify not used on remote file system' check_tail_output() -- 2.3.4 --------------050504060408070507010805-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 11:13:30 2015 Received: (at 20570) by debbugs.gnu.org; 14 May 2015 15:13:30 +0000 Received: from localhost ([127.0.0.1]:45175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YsupF-0007TT-U9 for submit@debbugs.gnu.org; Thu, 14 May 2015 11:13:30 -0400 Received: from achille.seblu.net ([62.210.204.83]:42678) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YsupD-0007T7-Ok for 20570@debbugs.gnu.org; Thu, 14 May 2015 11:13:28 -0400 Received: from murphy (slice.seblu.net [81.57.151.16]) by achille.seblu.net (Postfix) with ESMTPSA id DFFD950C0772; Thu, 14 May 2015 17:13:18 +0200 (CEST) Message-ID: <1431616397.5455.82.camel@seblu.net> Subject: Re: bug#20574: Test du/2g.sh fails with btrfs From: =?ISO-8859-1?Q?S=E9bastien?= Luttringer To: =?ISO-8859-1?Q?P=E1draig?= Brady Date: Thu, 14 May 2015 17:13:17 +0200 In-Reply-To: <55549FD2.60704@draigBrady.com> References: <1431605994.5455.81.camel@seblu.net> <55549FD2.60704@draigBrady.com> Content-Type: multipart/signed; micalg="pgp-sha384"; protocol="application/pgp-signature"; boundary="=-PlqG9seYe0qpy+ooNgd8" X-Mailer: Evolution 3.16.1 Mime-Version: 1.0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20570 Cc: 20570@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-PlqG9seYe0qpy+ooNgd8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, I made few adjustments to get the patch compile with released version; but = no more error. Thanks! On Thu, 2015-05-14 at 14:14 +0100, P=C3=A1draig Brady wrote: > forcemerge 20570 20574 > stop >=20 > On 14/05/15 13:19, S=C3=A9bastien Luttringer wrote: > > Hello, > >=20 > > In the same spirit than my yesterday report[1], the following test > > fail on btrfs when it works on tmpfs. > >=20 > > $ RUN_VERY_EXPENSIVE_TESTS=3Dyes ./tests/du/2g.sh > > creating a 2GB file: 100% complete--- exp 2015-05-14=20 > > 14:03:36.124772165 +0200+++ out 2015-05-14 14:03:36.123772158=20 > > +0200@@ -1 +1 @@-~2M+1572864 big > > You can find the full output of the test suite here [2]. > > Regards, > > [1] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20570 > > [2] http://pastebin.com/akytxtts >=20 > Drats I only tested on a 1G BTRFS loopback partition and so missed=20 > that. > Updated patch is attached. >=20 > cheers, > P=C3=A1draig. >=20 --=20 S=C3=A9bastien "Seblu" Luttringer https://seblu.net | Twitter: @seblu42 GPG: 0x2072D77A --=-PlqG9seYe0qpy+ooNgd8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCQAGBQJVVLuNAAoJEF9wJCj3DgkDpWQP/1/Xxz7OYBZMdsDRt2YawAxX Cg1aKrAhX80un3upyiEkV8urBuLvCK29SA1O5qB9FqxBBpCTRUhWZDKUZkM7eX4f A6hLZzgNLzxq/t5mc5GOSyZdAbqrjSM1V1FBvjkJa0wSzIpTm3JRdHSP7jtVXVXu L1gcUWlYb1/BuuyBeNwgHVgcknS1tbccKwCiKnoKDwMyX2jn/N6hvOSMopW0rkw/ kKIdd9XuGjjgG/ZjqrERBxlopRvoH6SI+nelW4L39NYA93Zx4lSh9DMB2YHZ0Esq FLE0oZyl/2+QJGhxuBaxqsHS/T0TKcArpd7knrU7p2CWtxqCemLPOuy9dTDE0RFw pxFrujn6iLtbiJAItqmGZNfo6pUboYsI17VHNIr6/4FkbhCGs+XlyP6ILFNoUsKY yFiH4TdKPVB+fXzSmjYZ0/lQGH66vVa9g7g9BnthrL7WwN3IEBBCzHAuq+zQ+Rtd 5Td/AG4vXwllJ0L+h3QbYnn8Wby1dczIQXB5OghoH0pahoaos6rMlAqyIwmTWSqd 0hEjCcYxcYnNW5BMvi1qILpCy9yY5ZKJBjB60x8gMLNqgNFLXjorkv4f/bu4QXzN Y+LIZCohAyF36Bp5knBewj3utNXvwL+yIh8x1CNPt4agEy/fasIF0s+J1BUw05NX +ccrQcPeLVaqwkhDhIzs =fQUW -----END PGP SIGNATURE----- --=-PlqG9seYe0qpy+ooNgd8-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 15:32:52 2015 Received: (at 20570) by debbugs.gnu.org; 14 May 2015 19:32:52 +0000 Received: from localhost ([127.0.0.1]:45395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YsysF-00031N-W1 for submit@debbugs.gnu.org; Thu, 14 May 2015 15:32:52 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:49685) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YsysC-000315-Dt for 20570@debbugs.gnu.org; Thu, 14 May 2015 15:32:49 -0400 Received: from [192.168.101.10] ([217.87.213.182]) by mrelayeu.kundenserver.de (mreue005) with ESMTPSA (Nemesis) id 0LpAm0-1ZMWrO06EO-00es8N; Thu, 14 May 2015 21:32:42 +0200 Message-ID: <5554F858.4060402@bernhard-voelker.de> Date: Thu, 14 May 2015 21:32:40 +0200 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= , =?UTF-8?B?U8OpYmE=?= =?UTF-8?B?c3RpZW4gTHV0dHJpbmdlcg==?= , 20570@debbugs.gnu.org Subject: Re: bug#20570: bug#20574: Test du/2g.sh fails with btrfs References: <1431605994.5455.81.camel@seblu.net> <55549FD2.60704@draigBrady.com> In-Reply-To: <55549FD2.60704@draigBrady.com> Content-Type: multipart/mixed; boundary="------------030100010606020100050401" X-Provags-ID: V03:K0:fR6Pfh4jBpItrOjGjbyT8qKNzVojw2VSvzg/MAc3KU+mU6rY+E1 v+f8bq2UpQaWYBDHxnpeQl8rKCxsUXRqmW/4pryEqq4DSm+YRwqjoQbF1tlA9b7cu6UZAmy RbpGcpb60HnUSJyS2idbmx0Iz1W9obX9vlyc/6NDpv0YpSgmMLrLPYtDTCZVA0Fdri5DDp+ na8tD7vd+Y3+3n2KHUfBQ== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20570 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------030100010606020100050401 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 05/14/2015 03:14 PM, Pádraig Brady wrote: > --- a/tests/tail-2/inotify-rotate-resources.sh > +++ b/tests/tail-2/inotify-rotate-resources.sh > @@ -25,7 +25,7 @@ grep '^#define HAVE_INOTIFY 1' "$CONFIG_HEADER" >/dev/null \ > require_strace_ 'inotify_add_watch,inotify_rm_watch' > > # Quickly skip on remote file systems > -df --local . >/dev/null 2>&1 || > +is_local_dir . >/dev/null 2>&1 || > skip_ 'inotify not used on remote file system' > > check_tail_output() That test is now skipped on a local ext4 file system: + is_local_dir . ./tests/tail-2/inotify-rotate-resources.sh: line 28: is_local_dir: command not found + skip_ 'inotify not used on remote file system' The attached fixes this: s/(is_local_dir)/\1_/ Have a nice day, Berny --------------030100010606020100050401 Content-Type: text/x-patch; name="0001-tests-fix-check-for-local-file-system-in-inotify-rot.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-tests-fix-check-for-local-file-system-in-inotify-rot.pa"; filename*1="tch" >From 99dfd5a6616cbda93d1c8c917aa3158d8b82c25b Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Thu, 14 May 2015 21:31:10 +0200 Subject: [PATCH] tests: fix check for local file system in inotify-rotate-resources.sh * tests/tail-2/inotify-rotate-resources.sh: s/(is_local_dir)/\1_/ --- tests/tail-2/inotify-rotate-resources.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/tail-2/inotify-rotate-resources.sh b/tests/tail-2/inotify-rotate-resources.sh index d6629a8..fe5d912 100755 --- a/tests/tail-2/inotify-rotate-resources.sh +++ b/tests/tail-2/inotify-rotate-resources.sh @@ -25,8 +25,7 @@ grep '^#define HAVE_INOTIFY 1' "$CONFIG_HEADER" >/dev/null \ require_strace_ 'inotify_add_watch,inotify_rm_watch' # Quickly skip on remote file systems -is_local_dir . >/dev/null 2>&1 || - skip_ 'inotify not used on remote file system' +is_local_dir_ . || skip_ 'inotify not used on remote file system' check_tail_output() { -- 2.1.4 --------------030100010606020100050401-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 14 18:21:01 2015 Received: (at 20570) by debbugs.gnu.org; 14 May 2015 22:21:02 +0000 Received: from localhost ([127.0.0.1]:45501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yt1Uy-00074D-HL for submit@debbugs.gnu.org; Thu, 14 May 2015 18:21:01 -0400 Received: from mail1.vodafone.ie ([213.233.128.43]:7229) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yt1Uv-00073z-6h for 20570@debbugs.gnu.org; Thu, 14 May 2015 18:20:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjEdAMUeVVVtTLyB/2dsb2JhbABcgw8fNV6BO4EVTsMvhXoCgUVMAQEBAQEBgQtBAQICg10BAQQjDwFWCw0BCgICBRYLAgIJAwIBAgFFBgEMCAEBiCwBCLEChWqeYQEBCAIggSGKGYUMgmiBRQWXCI5Gjn0jg3g9MYJGAQEB Received: from unknown (HELO localhost.localdomain) ([109.76.188.129]) by mail1.vodafone.ie with ESMTP; 14 May 2015 23:20:51 +0100 Message-ID: <55551FC2.9070800@draigBrady.com> Date: Thu, 14 May 2015 23:20:50 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Bernhard Voelker , =?UTF-8?B?U8OpYmFzdGllbiA=?= =?UTF-8?B?THV0dHJpbmdlcg==?= , 20570@debbugs.gnu.org Subject: Re: bug#20570: bug#20574: Test du/2g.sh fails with btrfs References: <1431605994.5455.81.camel@seblu.net> <55549FD2.60704@draigBrady.com> <5554F858.4060402@bernhard-voelker.de> In-Reply-To: <5554F858.4060402@bernhard-voelker.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20570 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 14/05/15 20:32, Bernhard Voelker wrote: > On 05/14/2015 03:14 PM, Pádraig Brady wrote: >> --- a/tests/tail-2/inotify-rotate-resources.sh >> +++ b/tests/tail-2/inotify-rotate-resources.sh >> @@ -25,7 +25,7 @@ grep '^#define HAVE_INOTIFY 1' "$CONFIG_HEADER" >/dev/null \ >> require_strace_ 'inotify_add_watch,inotify_rm_watch' >> >> # Quickly skip on remote file systems >> -df --local . >/dev/null 2>&1 || >> +is_local_dir . >/dev/null 2>&1 || >> skip_ 'inotify not used on remote file system' >> >> check_tail_output() > > That test is now skipped on a local ext4 file system: > > + is_local_dir . > ./tests/tail-2/inotify-rotate-resources.sh: line 28: is_local_dir: command not found > + skip_ 'inotify not used on remote file system' > > The attached fixes this: s/(is_local_dir)/\1_/ Drats. Thanks for catching that. Pádraig From unknown Tue Sep 09 00:44:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Jun 2015 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator