GNU bug report logs - #20560
24.5; I am not happy with the new Python mode indentation behaviour

Previous Next

Full log

Message #14 received at control <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: 20742 <at> debbugs.gnu.org
Cc: Tommi Komulainen <tommi.komulainen <at> iki.fi>
Subject: Re: bug#20742: 24.5;
 [PATCH] python.el: fix close paren indentation to match pep8
Date: Sat, 20 Apr 2019 16:51:23 -0400

[Message part 1 (text/plain, inline)]

tags 20742 + patch
quit

>> When opening paren is followed by newline the closing paren should follow
>> the current indentation. Otherwise the closing paren should be aligned
>> with the opening paren. This fixes the latter case. #20742
>
> I'm having trouble applying this.
>
>     error: corrupt patch at line 11
>     Applying: python.el: fix close paren indentation to match pep8
>     Patch failed at 0001 python.el: fix close paren indentation to match pep8

I managed to get this applied; I've replaced the python-test.el
modifications, partly because they're written as updates to the existing
tests which makes them a bit harder to follow, and partly to make more
clear that the patch is below the 15 line copyright limit.

I'll push to master in a week or so if there are no further comments.

[0001-python.el-Fix-close-paren-indentation-to-match-pep8-.patch (text/plain, attachment)]

[0002-Add-test-for-previous-change.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.