GNU bug report logs - #20541
ERC password fetching using Secret Service API is broken

Previous Next

Package: emacs;

Reported by: Krzysztof Jurewicz <krzysztof.jurewicz <at> gmail.com>

Date: Sun, 10 May 2015 14:15:03 UTC

Severity: normal

Fixed in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 20541 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Krzysztof Jurewicz <krzysztof.jurewicz <at> gmail.com>
Cc: 20541 <at> debbugs.gnu.org
Subject: Re: bug#20541: ERC password fetching using Secret Service API is
 broken
Date: Sun, 27 Dec 2015 09:05:02 +0100
Krzysztof Jurewicz <krzysztof.jurewicz <at> gmail.com> writes:

>  lisp/erc/erc.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> index cf422f1..a8f1478 100644
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -2010,7 +2010,8 @@ Returns the buffer for the given server or channel."
>                             (auth-source-search :host server
>                                                 :max 1
>                                                 :user nick
> -                                               :port port
> +                                               ;; secrets.el wouldn.t accept a number
> +                                               :port (if (numberp port) (number-to-string port) port)
>                                                 :require '(:secret)))
>                        :secret)))

Thanks; applied to Emacs 25.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 9 years and 153 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.