GNU bug report logs - #20541
ERC password fetching using Secret Service API is broken

Previous Next

Full log

View this message in rfc822 format

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Krzysztof Jurewicz <krzysztof.jurewicz <at> gmail.com>, 20541 <at> debbugs.gnu.org
Subject: bug#20541: ERC password fetching using Secret Service API is broken
Date: Mon, 29 Jun 2015 22:28:45 -0400

On Mon, 01 Jun 2015 11:20:58 +0200 Michael Albinus <michael.albinus <at> gmx.de> wrote: 

MA> Krzysztof Jurewicz <krzysztof.jurewicz <at> gmail.com> writes:
>> One possible patch is attached below. This is the simplest solution; I
>> have not thought much about whether it may be more desirable to convert
>> numbers to strings inside the secrets.el package.

MA> Well, secrets.el expects only strings as attributes. No conversion
MA> foreseen. I don't know what auth-source.el does. If auth-source-search
MA> also allows only strings (and symbol names) as attributes, then your
MA> patch is right. Otherwise, if a :port attribute could also be an
MA> integer, it shall be transformed to a string.

Sorry for the late reply.

The docs of `auth-source-search' say:

    A string value is always matched literally.  A symbol is matched
    as its string value, literally.  All the SPEC values can be
    single values (symbol or string) or lists thereof (in which case
    any of the search terms matches).

...so numbers are not allowed. By design, that means that "80" and
"http" can be used for :port, for instance. IIRC there was no gain from
making any of the search criteria take numbers in the case of
auth-source.el specifically.

So I think the patch is OK :)

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.