GNU bug report logs - #20536
avoid new gcc warning: ENOTSUP vs EOPNOTSUPP

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#20536: closed (avoid new gcc warning: ENOTSUP vs EOPNOTSUPP)
Date: Sat, 09 May 2015 22:20:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 09 May 2015 23:19:41 +0100
with message-id <554E87FD.5000703 <at> draigBrady.com>
and subject line Re: bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP
has caused the debbugs.gnu.org bug report #20536,
regarding avoid new gcc warning: ENOTSUP vs EOPNOTSUPP
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
20536: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20536
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: bug-coreutils <at> gnu.org
Subject: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP
Date: Sat, 9 May 2015 11:15:07 -0700

[Message part 3 (text/plain, inline)]

Building with very new gcc-from-git, I encountered 3 new warnings.
Here's a patch to address them:

Without this change, very recent gcc (e.g., version 6.0.0 20150509)
would print the following when configured with --enable-gcc-warnings:

  src/copy.c:165:30: error: logical 'or' of equal expressions \
    [-Werror=logical-op]
    && (errno == EOPNOTSUPP || errno == ENOTSUP || errno == ENOSYS))
                           ^
* src/system.h (is_ENOTSUP): New function.
* src/copy.c (punch_hole): Use it.
* src/ls.c (errno_unsupported, gobble_file): Use it.

[0001-build-avoid-a-warning-form-gcc-s-new-Wlogical-op.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Jim Meyering <jim <at> meyering.net>, 20536-done <at> debbugs.gnu.org
Subject: Re: bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP
Date: Sat, 09 May 2015 23:19:41 +0100

On 09/05/15 19:15, Jim Meyering wrote:
> Building with very new gcc-from-git, I encountered 3 new warnings.
> Here's a patch to address them:
> 
> Without this change, very recent gcc (e.g., version 6.0.0 20150509)
> would print the following when configured with --enable-gcc-warnings:
> 
>   src/copy.c:165:30: error: logical 'or' of equal expressions \
>     [-Werror=logical-op]
>     && (errno == EOPNOTSUPP || errno == ENOTSUP || errno == ENOSYS))
>                            ^
> * src/system.h (is_ENOTSUP): New function.
> * src/copy.c (punch_hole): Use it.
> * src/ls.c (errno_unsupported, gobble_file): Use it.

Not sure I agree with GCC's warning here,
but the fix looks good.

Marking this as done.

thanks!
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.