From debbugs-submit-bounces@debbugs.gnu.org Sat May 09 14:15:42 2015 Received: (at submit) by debbugs.gnu.org; 9 May 2015 18:15:42 +0000 Received: from localhost ([127.0.0.1]:39673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yr9Hp-0003S0-8e for submit@debbugs.gnu.org; Sat, 09 May 2015 14:15:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55917) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yr9Hm-0003Rl-5Y for submit@debbugs.gnu.org; Sat, 09 May 2015 14:15:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yr9Hf-0001lZ-PD for submit@debbugs.gnu.org; Sat, 09 May 2015 14:15:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yr9Hf-0001lP-MO for submit@debbugs.gnu.org; Sat, 09 May 2015 14:15:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yr9He-0002qU-4V for bug-coreutils@gnu.org; Sat, 09 May 2015 14:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yr9Hd-0001kz-36 for bug-coreutils@gnu.org; Sat, 09 May 2015 14:15:29 -0400 Received: from mail-ie0-x236.google.com ([2607:f8b0:4001:c03::236]:36142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yr9Hc-0001kb-RF for bug-coreutils@gnu.org; Sat, 09 May 2015 14:15:28 -0400 Received: by iecmd7 with SMTP id md7so6598332iec.3 for ; Sat, 09 May 2015 11:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=m9lJKQcPc78+m5fzMHfH6ANVOMJ1VJuUppy4AQLVyek=; b=ahBMI/ujtWBP+eQxxxHR0DwPbCgCdjf05ntxpNeWj00jzSK3vYcEAI8SlAOSe1DQ5A thOhq2tqNQhsDyQGtedcDJOjuL7BKCp9rWrBDE8UkOYqhSULM0b4DI6uFMHc1/Xc/AVh KNfbR2raxjzBY9fmCietcay4lEvHHojO5rbuXYs15JzwTvs3B7yISeu2WqxV3VN4Au12 vcV2GMlVn47Fw4+tMZZr5TLOS9AKCl1PdUqsrxQCKeTv7W+feJqNXiNpPHtjWS1amlw2 hxHMcyOmsMNVxiRlLFKYaxHOOtMaKmUKEFiRBFfGQigP7EOcdfXFHTe0xWLedAKsfcr4 QGyg== X-Received: by 10.50.73.198 with SMTP id n6mr5834039igv.32.1431195327878; Sat, 09 May 2015 11:15:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.62.229 with HTTP; Sat, 9 May 2015 11:15:07 -0700 (PDT) From: Jim Meyering Date: Sat, 9 May 2015 11:15:07 -0700 X-Google-Sender-Auth: fSTCiQl-utO6QWFWBh3BGjDpXfk Message-ID: Subject: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP To: bug-coreutils@gnu.org Content-Type: multipart/mixed; boundary=089e011839a61fc3e50515aa2193 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e011839a61fc3e50515aa2193 Content-Type: text/plain; charset=UTF-8 Building with very new gcc-from-git, I encountered 3 new warnings. Here's a patch to address them: Without this change, very recent gcc (e.g., version 6.0.0 20150509) would print the following when configured with --enable-gcc-warnings: src/copy.c:165:30: error: logical 'or' of equal expressions \ [-Werror=logical-op] && (errno == EOPNOTSUPP || errno == ENOTSUP || errno == ENOSYS)) ^ * src/system.h (is_ENOTSUP): New function. * src/copy.c (punch_hole): Use it. * src/ls.c (errno_unsupported, gobble_file): Use it. --089e011839a61fc3e50515aa2193 Content-Type: application/octet-stream; name="0001-build-avoid-a-warning-form-gcc-s-new-Wlogical-op.patch" Content-Disposition: attachment; filename="0001-build-avoid-a-warning-form-gcc-s-new-Wlogical-op.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i9hcol7z0 RnJvbSA3NWY4NTNhYWFkYjA5OGIwZWU4NzdkOTJhYTRlNjEzZTQ3ODk2MGIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCA5IE1heSAyMDE1IDEwOjU3OjU0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gYnVpbGQ6IGF2 b2lkIGEgd2FybmluZyBmb3JtIGdjYydzIG5ldyAtV2xvZ2ljYWwtb3AKCldpdGhvdXQgdGhpcyBj aGFuZ2UsIHZlcnkgcmVjZW50IGdjYyAoZS5nLiwgdmVyc2lvbiA2LjAuMCAyMDE1MDUwOSkKd291 bGQgcHJpbnQgdGhlIGZvbGxvd2luZyB3aGVuIGNvbmZpZ3VyZWQgd2l0aCAtLWVuYWJsZS1nY2Mt d2FybmluZ3M6CgogIHNyYy9jb3B5LmM6MTY1OjMwOiBlcnJvcjogbG9naWNhbCAnb3InIG9mIGVx dWFsIGV4cHJlc3Npb25zIFwKICAgIFstV2Vycm9yPWxvZ2ljYWwtb3BdCiAgICAmJiAoZXJybm8g PT0gRU9QTk9UU1VQUCB8fCBlcnJubyA9PSBFTk9UU1VQIHx8IGVycm5vID09IEVOT1NZUykpCiAg ICAgICAgICAgICAgICAgICAgICAgICAgIF4KKiBzcmMvc3lzdGVtLmggKGlzX0VOT1RTVVApOiBO ZXcgZnVuY3Rpb24uCiogc3JjL2NvcHkuYyAocHVuY2hfaG9sZSk6IFVzZSBpdC4KKiBzcmMvbHMu YyAoZXJybm9fdW5zdXBwb3J0ZWQsIGdvYmJsZV9maWxlKTogVXNlIGl0LgotLS0KIHNyYy9jb3B5 LmMgICB8ICAzICstLQogc3JjL2xzLmMgICAgIHwgIDcgKystLS0tLQogc3JjL3N5c3RlbS5oIHwg MTQgKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvY29weS5jIGIvc3JjL2NvcHkuYwppbmRleCBi OTNjNTMzLi4zYWY0Mjk1IDEwMDY0NAotLS0gYS9zcmMvY29weS5jCisrKyBiL3NyYy9jb3B5LmMK QEAgLTE2MSw4ICsxNjEsNyBAQCBwdW5jaF9ob2xlIChpbnQgZmQsIG9mZl90IG9mZnNldCwgb2Zm X3QgbGVuZ3RoKQogIyBpZiBkZWZpbmVkIEZBTExPQ19GTF9QVU5DSF9IT0xFICYmIGRlZmluZWQg RkFMTE9DX0ZMX0tFRVBfU0laRQogICByZXQgPSBmYWxsb2NhdGUgKGZkLCBGQUxMT0NfRkxfUFVO Q0hfSE9MRSB8IEZBTExPQ19GTF9LRUVQX1NJWkUsCiAgICAgICAgICAgICAgICAgICAgb2Zmc2V0 LCBsZW5ndGgpOwotICBpZiAocmV0IDwgMAotICAgICAgJiYgKGVycm5vID09IEVPUE5PVFNVUFAg fHwgZXJybm8gPT0gRU5PVFNVUCB8fCBlcnJubyA9PSBFTk9TWVMpKQorICBpZiAocmV0IDwgMCAm JiAoaXNfRU5PVFNVUCAoZXJybm8pIHx8IGVycm5vID09IEVOT1NZUykpCiAgICAgcmV0ID0gMDsK ICMgZW5kaWYKICNlbmRpZgpkaWZmIC0tZ2l0IGEvc3JjL2xzLmMgYi9zcmMvbHMuYwppbmRleCBi MzA4ZGQzLi4wMTQwNGUyIDEwMDY0NAotLS0gYS9zcmMvbHMuYworKysgYi9zcmMvbHMuYwpAQCAt MjgyOCwxMCArMjgyOCw3IEBAIGNsZWFyX2ZpbGVzICh2b2lkKQogc3RhdGljIGJvb2wKIGVycm5v X3Vuc3VwcG9ydGVkIChpbnQgZXJyKQogewotICByZXR1cm4gKGVyciA9PSBFSU5WQUwKLSAgICAg ICAgICB8fCBlcnIgPT0gRU5PU1lTCi0gICAgICAgICAgfHwgZXJyID09IEVOT1RTVVAKLSAgICAg ICAgICB8fCBlcnIgPT0gRU9QTk9UU1VQUCk7CisgIHJldHVybiAoZXJyID09IEVJTlZBTCB8fCBl cnIgPT0gRU5PU1lTIHx8IGlzX0VOT1RTVVAgKGVycikpOwogfQoKIC8qIENhY2hlICpnZXRmaWxl Y29uIGZhaWx1cmUsIHdoZW4gaXQncyB0cml2aWFsIHRvIGRvIHNvLgpAQCAtMzA2OSw3ICszMDY2 LDcgQEAgZ29iYmxlX2ZpbGUgKGNoYXIgY29uc3QgKm5hbWUsIGVudW0gZmlsZXR5cGUgdHlwZSwg aW5vX3QgaW5vZGUsCiAgICAgICAgICAgICAgICAgIGxzIGZhaWwganVzdCBiZWNhdXNlIHRoZSBm aWxlIChldmVuIGEgY29tbWFuZCBsaW5lIGFyZ3VtZW50KQogICAgICAgICAgICAgICAgICBpc24n dCBvbiB0aGUgcmlnaHQgdHlwZSBvZiBmaWxlIHN5c3RlbS4gIEkuZS4sIGEgZ2V0ZmlsZWNvbgog ICAgICAgICAgICAgICAgICBmYWlsdXJlIGlzbid0IGluIHRoZSBzYW1lIGNsYXNzIGFzIGEgc3Rh dCBmYWlsdXJlLiAgKi8KLSAgICAgICAgICAgICAgaWYgKGVycm5vID09IEVOT1RTVVAgfHwgZXJy bm8gPT0gRU9QTk9UU1VQUCB8fCBlcnJubyA9PSBFTk9EQVRBKQorICAgICAgICAgICAgICBpZiAo aXNfRU5PVFNVUCAoZXJybm8pIHx8IGVycm5vID09IEVOT0RBVEEpCiAgICAgICAgICAgICAgICAg ZXJyID0gMDsKICAgICAgICAgICAgIH0KCmRpZmYgLS1naXQgYS9zcmMvc3lzdGVtLmggYi9zcmMv c3lzdGVtLmgKaW5kZXggYzU1ZjZkOC4uMGUyNWJjNCAxMDA2NDQKLS0tIGEvc3JjL3N5c3RlbS5o CisrKyBiL3NyYy9zeXN0ZW0uaApAQCAtNjk1LDMgKzY5NSwxNyBAQCBzdHpuY3B5IChjaGFyICpy ZXN0cmljdCBkZXN0LCBjaGFyIGNvbnN0ICpyZXN0cmljdCBzcmMsIHNpemVfdCBsZW4pCiAgICBp biBzZWxpbnV4LmggYmVmb3JlIGxpYnNlbGludXgtMi4zIChNYXkgMjAxNCkuCiAgICBXaGVuIHZl cnNpb24gPj0gMi4zIGlzIHViaXF1aXRvdXMgcmVtb3ZlIHRoaXMgZnVuY3Rpb24uICAqLwogc3Rh dGljIGlubGluZSBjaGFyICogc2VfY29uc3QgKGNoYXIgY29uc3QgKiBzY3R4KSB7IHJldHVybiAo Y2hhciAqKSBzY3R4OyB9CisKKy8qIFJldHVybiB0cnVlIGlmIEVSUiBpcyBFTk9UU1VQIG9yIEVP UE5PVFNVUFAsIG90aGVyd2lzZSBmYWxzZS4KKyAgIFRoaXMgd3JhcHBlciBmdW5jdGlvbiBhdm9p ZHMgdGhlIHJlZHVuZGFudCAnb3InZCBjb21wYXJpc29uIG9uCisgICBzeXN0ZW1zIGxpa2UgTGlu dXggZm9yIHdoaWNoIHRoZXkgaGF2ZSB0aGUgc2FtZSB2YWx1ZS4gIEl0IGFsc28KKyAgIGF2b2lk cyB0aGUgZ2NjIHdhcm5pbmcgdG8gdGhhdCBlZmZlY3QuICAqLworc3RhdGljIGlubGluZSBib29s Citpc19FTk9UU1VQIChpbnQgZXJyKQoreworICByZXR1cm4gZXJyID09IEVPUE5PVFNVUFAKKyNp ZiBFTk9UU1VQICE9IEVPUE5PVFNVUFAKKyAgICB8fCBlcnIgPT0gRU5PVFNVUAorI2VuZGlmCisg ICAgOworfQotLSAKMi40LjAKCg== --089e011839a61fc3e50515aa2193-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 09 18:19:51 2015 Received: (at 20536-done) by debbugs.gnu.org; 9 May 2015 22:19:51 +0000 Received: from localhost ([127.0.0.1]:39749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrD66-0000mD-DE for submit@debbugs.gnu.org; Sat, 09 May 2015 18:19:50 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:6491) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrD64-0000ly-4g for 20536-done@debbugs.gnu.org; Sat, 09 May 2015 18:19:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjYdAB2HTlVtT1kN/2dsb2JhbABcgw+CbYFjxweCXgKBJUwBAQEBAQGBC0EBAgKDWwEBBCMPAVYLDQsCAgUWCwICCQMCAQIBRQYBDAgBAYgsAbQAhWmNIgEBCAIggSGKGIUMgmiBRQWQCpUFjmgjYYMXPYJ3AQEB Received: from unknown (HELO localhost.localdomain) ([109.79.89.13]) by mail2.vodafone.ie with ESMTP; 09 May 2015 23:19:41 +0100 Message-ID: <554E87FD.5000703@draigBrady.com> Date: Sat, 09 May 2015 23:19:41 +0100 From: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jim Meyering , 20536-done@debbugs.gnu.org Subject: Re: bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20536-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 09/05/15 19:15, Jim Meyering wrote: > Building with very new gcc-from-git, I encountered 3 new warnings. > Here's a patch to address them: > > Without this change, very recent gcc (e.g., version 6.0.0 20150509) > would print the following when configured with --enable-gcc-warnings: > > src/copy.c:165:30: error: logical 'or' of equal expressions \ > [-Werror=logical-op] > && (errno == EOPNOTSUPP || errno == ENOTSUP || errno == ENOSYS)) > ^ > * src/system.h (is_ENOTSUP): New function. > * src/copy.c (punch_hole): Use it. > * src/ls.c (errno_unsupported, gobble_file): Use it. Not sure I agree with GCC's warning here, but the fix looks good. Marking this as done. thanks! Pádraig From debbugs-submit-bounces@debbugs.gnu.org Sun May 10 10:17:30 2015 Received: (at 20536) by debbugs.gnu.org; 10 May 2015 14:17:30 +0000 Received: from localhost ([127.0.0.1]:40138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrS2r-0001df-Mb for submit@debbugs.gnu.org; Sun, 10 May 2015 10:17:29 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:46238) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrS2p-0001dR-8V for 20536@debbugs.gnu.org; Sun, 10 May 2015 10:17:27 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 0BC4639E8020; Sun, 10 May 2015 07:17:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7NdA+NnCGu3X; Sun, 10 May 2015 07:17:20 -0700 (PDT) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6A06B39E801D; Sun, 10 May 2015 07:17:20 -0700 (PDT) Message-ID: <554F686B.3090205@cs.ucla.edu> Date: Sun, 10 May 2015 07:17:15 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jim Meyering , 20536@debbugs.gnu.org Subject: Re: bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP References: In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20536 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Jim Meyering wrote: > + return err == EOPNOTSUPP > +#if ENOTSUP != EOPNOTSUPP > + || err == ENOTSUP > +#endif > + ; Would the following work instead? It's a bit cleaner to avoid #if: return err == EOPNOTSUPP || (ENOTSUP != EOPNOTSUPP && err == ENOTSUP); From debbugs-submit-bounces@debbugs.gnu.org Sun May 10 11:35:21 2015 Received: (at 20536) by debbugs.gnu.org; 10 May 2015 15:35:21 +0000 Received: from localhost ([127.0.0.1]:40161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrTGC-0003Xt-HT for submit@debbugs.gnu.org; Sun, 10 May 2015 11:35:20 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:36221) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrTG9-0003Xe-Mm for 20536@debbugs.gnu.org; Sun, 10 May 2015 11:35:18 -0400 Received: by iecmd7 with SMTP id md7so15225997iec.3 for <20536@debbugs.gnu.org>; Sun, 10 May 2015 08:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=sQahKq1PETrceB+EyC2FW3cJeZbweV3uBDIub0cI83U=; b=PwA4gAEYCT/io2ARaxblx9e+lQJYfg2sw1l7Ae/11EJI6GQ/Hgi/qHSO3e4kZfIRiq TKSFGeQTWrkaCshG8gYo2mnDfHQtjGr2EqT+osv/rdlLxLd0Lb1d+YnUel3CDA4SCGmv pnaCOgmLFIXeXC2PJAVawKVZBFwUg1AceRidQccII48BbQQURRt9wsR37Lz2WKzRY2dE lSK/gp4ZJVy3nCgNJ21YcmaUacbsxcp5FzPqQD8SixtLBQVK4ayeHhV+5xJz+Tzj/0QV L2WQVH8sIK5eqEOlal4N9Lqf30iLVgBgvRoTic6t5Fjf8xuYdO54DJvUuyPtZi4rWogS h56w== X-Received: by 10.42.23.17 with SMTP id q17mr7038852icb.4.1431272111986; Sun, 10 May 2015 08:35:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.62.229 with HTTP; Sun, 10 May 2015 08:34:51 -0700 (PDT) In-Reply-To: <554F686B.3090205@cs.ucla.edu> References: <554F686B.3090205@cs.ucla.edu> From: Jim Meyering Date: Sun, 10 May 2015 08:34:51 -0700 X-Google-Sender-Auth: -gp5RPE1r3EZRUB0Yon7jig6Y_0 Message-ID: Subject: Re: bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP To: Paul Eggert Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20536 Cc: 20536@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, May 10, 2015 at 7:17 AM, Paul Eggert wrote: > Jim Meyering wrote: >> >> + return err == EOPNOTSUPP >> +#if ENOTSUP != EOPNOTSUPP >> + || err == ENOTSUP >> +#endif >> + ; > > Would the following work instead? It's a bit cleaner to avoid #if: > > return err == EOPNOTSUPP || (ENOTSUP != EOPNOTSUPP && err == ENOTSUP); I confirmed that too avoids the warning, so I've pushed it in your name. From unknown Mon Jun 23 07:52:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 08 Jun 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator