GNU bug report logs - #20522
25.0.50; `C-u C-x =' output, `to input' field

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Thu, 7 May 2015 00:04:01 UTC

Severity: wishlist

Tags: patch

Found in version 25.0.50

Fixed in version 25.1

Done: Ivan Shmakov <ivan <at> siamics.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 20522 <at> debbugs.gnu.org
Subject: bug#20522: 25.0.50; ‘C-u C-x =’ output,	‘to input’ field
Date: Thu, 07 May 2015 17:45:18 +0300
> From: Ivan Shmakov <ivan <at> siamics.net>
> Date: Thu, 07 May 2015 07:10:23 +0000
> 
> --- a/lisp/descr-text.el
> +++ b/lisp/descr-text.el
> @@ -618,7 +618,9 @@ defun describe-char (pos &optional buffer)
>                                     'help-args '(,current-input-method))
>                                  "input method")
>                          (list
> -                         "type \"C-x 8 RET HEX-CODEPOINT\" or \"C-x 8 RET 
> NAME\"")))))
> +                          (format
> +                           "type \"C-x 8 RET %04x\" or \"C-x 8 RET %s\""
                                                ^^^^
I see no need to tell users to type at least 4 hex digits: "C-x 8 RET"
accepts even one digit.  So I think we should use %x here.

> +                           char (get-char-code-property char 'name)))))))

Not every Unicode codepoint has a name, so get-char-code-property
could return nil.  E.g., try with any codepoint between zero and #x1f,
inclusive.  When that happens, we should try 'old-name' instead, and
if that returns nil as well (try #x99, for example), I think the "by
name" part should be omitted from the output of describe-char.

Thanks.




This bug report was last modified 9 years and 364 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.