From unknown Mon Jun 23 02:25:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#20519: face-at-point: do not compute the final list if a sole value is wanted Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 May 2015 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20519 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 20519@debbugs.gnu.org X-Debbugs-Original-To: submit@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1430947555411 (code B ref -1); Wed, 06 May 2015 21:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 May 2015 21:25:55 +0000 Received: from localhost ([127.0.0.1]:36598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yq6pG-00006Z-VS for submit@debbugs.gnu.org; Wed, 06 May 2015 17:25:55 -0400 Received: from fely.am-1.org ([78.47.74.50]:42014) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yq6pE-00006O-D6 for submit@debbugs.gnu.org; Wed, 06 May 2015 17:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=i3P+B9iQK1nB4KidaLJIuhlBe9XtnOqXdU2jiFznbOM=; b=jQ6ZUILfRT+PjLd2Tmxv7MZ0yRZjCAYjbYZlptf3y5LsAcBeyRK+8Yb7U3iAd7l9bDbDJXkjA75vW8wU1auIkUw/spdyOg/WmZCH3cCYx07MIZitgCfMFQKpOylp+jHcJeV+o+rZSdFowJ54jJ8TCLVfQAMJCbtWjpl3DwBK/28=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Yq6pC-0005Yj-Bm for submit@debbugs.gnu.org; Wed, 06 May 2015 21:25:50 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Yq6p3-0006yl-Tk for submit@debbugs.gnu.org; Thu, 07 May 2015 04:25:42 +0700 From: Ivan Shmakov Date: Wed, 06 May 2015 21:25:40 +0000 Message-ID: <87pp6djt4b.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: wishlist The face-at-point function currently (1c7f0cdc4c1f, 2015-04-27 16:59:11 +00:00) uses delete-dups to compute a duplicate-free version of the list=E2=80=A6 just before taking a single value of it and discarding the rest in the (not multiple) case. Please thus consider the following patch. * lisp/faces.el (face-at-point): Do not compute the properly ordered, duplicate-free list if only a single value is requested. --=20 FSF associate member #7257 http://am-1.org/~ivan/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1937,8 +1937,9 @@ defun face-at-point (&optional thing multiple) (dolist (face faceprop) (if (facep face) (push face faces)))))) - (setq faces (delete-dups (nreverse faces))) - (if multiple faces (car faces)))) + (if multiple + (delete-dups (nreverse faces)) + (car (last faces))))) (defun foreground-color-at-point () "Return the foreground color of the character after point." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 07 03:10:38 2015 Received: (at control) by debbugs.gnu.org; 7 May 2015 07:10:38 +0000 Received: from localhost ([127.0.0.1]:36795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqFx7-0006Cq-RE for submit@debbugs.gnu.org; Thu, 07 May 2015 03:10:38 -0400 Received: from fely.am-1.org ([78.47.74.50]:42058) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqFx4-0006Cb-S0; Thu, 07 May 2015 03:10:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=IcKx0ECOOg46puupwqVlMsbebKuN75PpvBu8m+KrA8w=; b=gi+kJRSMKVdZpd4+Y+TJpZYyAkyZsMa9HdziAqcBccmZUSJrgI0Hxsa6Y6rqu0YMMpHp+oqLWaKNsr7kkjr55ioJJTyphPeu00Cr7qlqb3blBRhvBP1TX8qkidOI/KnC+Yi73JI3AMINB/V+Dru9rBaCRzKnm6PhI6YB3YxAl3M=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YqFx1-0007SU-5s; Thu, 07 May 2015 07:10:31 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YqFwu-00082O-3f; Thu, 07 May 2015 14:10:24 +0700 From: Ivan Shmakov To: 20522@debbugs.gnu.org, control@debbugs.gnu.org Subject: Re: bug#20522: 25.0.50; =?utf-8?Q?=E2=80=98C-u?= C-x =?utf-8?Q?=3D=E2=80=99?= output, =?utf-8?B?4oCYdG8gaW5wdXTigJk=?= field References: <988c8ea5-e184-4d53-99d6-cd354006f45b@default> Mail-Followup-To: 20522@debbugs.gnu.org Date: Thu, 07 May 2015 07:10:23 +0000 In-Reply-To: <988c8ea5-e184-4d53-99d6-cd354006f45b@default> (Drew Adams's message of "Wed, 6 May 2015 17:03:02 -0700 (PDT)") Message-ID: <87h9rokgm8.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tag 20522 + patch tag 20519 + patch thanks >>>>> Drew Adams writes: > C-u C-x 8 RET GREEK CAPITAL LETTER PSI RET C-b C-u C-x = [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tag 20522 + patch tag 20519 + patch thanks >>>>> Drew Adams writes: > C-u C-x 8 RET GREEK CAPITAL LETTER PSI RET C-b C-u C-x = [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) 1.3 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable tag 20522 + patch tag 20519 + patch thanks >>>>> Drew Adams writes: > C-u C-x 8 RET GREEK CAPITAL LETTER PSI RET C-b C-u C-x =3D > Buffer *Help* says this, for field `to input': > type "C-x 8 RET HEX-CODEPOINT" or "C-x 8 RET NAME" > It should instead be able to say something like this: > type "C-x 8 RET 0x03A8" or "C-x 8 RET GREEK CAPITAL LETTER PSI" > Both of these pieces of information are shown in the same buffer > *Help*. It seems a bit silly to tell a user to type HEX-CODEPOINT or > NAME, when these are known when *Help* is created. Please consider the patch MIMEd. * lisp/descr-text.el (describe-char): Show the exact C-x 8 RET invocation instead of a template. (Bug#20522) [=E2=80=A6] --=20 FSF associate member #7257 np. Danger Zone =E2=80=94 Rainbow =E2=80=A6 3= 013 B6A0 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/descr-text.el +++ b/lisp/descr-text.el @@ -618,7 +618,9 @@ defun describe-char (pos &optional buffer) 'help-args '(,current-input-method)) "input method") (list - "type \"C-x 8 RET HEX-CODEPOINT\" or \"C-x 8 RET NAME\""))))) + (format + "type \"C-x 8 RET %04x\" or \"C-x 8 RET %s\"" + char (get-char-code-property char 'name))))))) ("buffer code" ,(if multibyte-p (encoded-string-description --=-=-=-- From unknown Mon Jun 23 02:25:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ivan Shmakov Subject: bug#20519: closed (Re: bug#20519: face-at-point: do not compute the final list if a sole value is wanted ) Message-ID: References: <87y4k9fyav.fsf@violet.siamics.net> <87pp6djt4b.fsf@violet.siamics.net> X-Gnu-PR-Message: they-closed 20519 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 20519@debbugs.gnu.org Date: Wed, 27 May 2015 22:31:05 +0000 Content-Type: multipart/mixed; boundary="----------=_1432765865-16931-1" This is a multi-part message in MIME format... ------------=_1432765865-16931-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #20519: face-at-point: do not compute the final list if a sole value is wan= ted=20 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 20519@debbugs.gnu.org. --=20 20519: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20519 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1432765865-16931-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 20519-done) by debbugs.gnu.org; 27 May 2015 22:30:59 +0000 Received: from localhost ([127.0.0.1]:58714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxjqk-0004Or-Jm for submit@debbugs.gnu.org; Wed, 27 May 2015 18:30:59 -0400 Received: from fely.am-1.org ([78.47.74.50]:46046) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yxjqi-0004Oj-KP for 20519-done@debbugs.gnu.org; Wed, 27 May 2015 18:30:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=Z/3JahDVegGhoKNBel3qUqbv2EVMdUzzqUecf8t4SXA=; b=j6pNqIymQh7nzLBp8ZDa4BZAWHKrO5QpYHSU+IfX0DKGIsrbqyh61tH8yQTLz5nT8G1Aa4JLl5bVGp699OLLoppCpWUSvf09KFOwO+hXB0t9qHMgRb3Uah5fpRI5ifOE20kPpzpXp8dpOcHUCeWNqMt3Ncm2qK30yY+ScXSK1k0=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Yxjqi-00032n-0Z for 20519-done@debbugs.gnu.org; Wed, 27 May 2015 22:30:56 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Yxjqb-00066T-AA for 20519-done@debbugs.gnu.org; Thu, 28 May 2015 05:30:49 +0700 From: Ivan Shmakov To: 20519-done@debbugs.gnu.org Subject: Re: bug#20519: face-at-point: do not compute the final list if a sole value is wanted References: <87pp6djt4b.fsf@violet.siamics.net> Mail-Followup-To: 20519@debbugs.gnu.org Date: Wed, 27 May 2015 22:30:48 +0000 In-Reply-To: <87pp6djt4b.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 06 May 2015 21:25:40 +0000") Message-ID: <87y4k9fyav.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 20519-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 25.1 >>>>> Ivan Shmakov writes: > The face-at-point function currently (1c7f0cdc4c1f, 2015-04-27 > 16:59:11 +00:00) uses delete-dups to compute a duplicate-free version > of the list=E2=80=A6 just before taking a single value of it and discard= ing > the rest in the (not multiple) case. > Please thus consider the following patch. > * lisp/faces.el (face-at-point): Do not compute the properly ordered, > duplicate-free list if only a single value is requested. Pushed, as there were no objections; closing. commit 550c65011c7394e8ebcf91fc29af2984908279d1 Date: 2015-05-27 22:15:27 +0000 Avoid gratuitous delete-dups in face-at-point. * lisp/faces.el (face-at-point): Do not compute the properly ordered, duplicate-free list if only a single value is requested anyway. (Bug#20519) --=20 FSF associate member #7257 http://am-1.org/~ivan/ =E2=80=A6 3013 B6A0= 230E 334A ------------=_1432765865-16931-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 May 2015 21:25:55 +0000 Received: from localhost ([127.0.0.1]:36598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yq6pG-00006Z-VS for submit@debbugs.gnu.org; Wed, 06 May 2015 17:25:55 -0400 Received: from fely.am-1.org ([78.47.74.50]:42014) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yq6pE-00006O-D6 for submit@debbugs.gnu.org; Wed, 06 May 2015 17:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=i3P+B9iQK1nB4KidaLJIuhlBe9XtnOqXdU2jiFznbOM=; b=jQ6ZUILfRT+PjLd2Tmxv7MZ0yRZjCAYjbYZlptf3y5LsAcBeyRK+8Yb7U3iAd7l9bDbDJXkjA75vW8wU1auIkUw/spdyOg/WmZCH3cCYx07MIZitgCfMFQKpOylp+jHcJeV+o+rZSdFowJ54jJ8TCLVfQAMJCbtWjpl3DwBK/28=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Yq6pC-0005Yj-Bm for submit@debbugs.gnu.org; Wed, 06 May 2015 21:25:50 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Yq6p3-0006yl-Tk for submit@debbugs.gnu.org; Thu, 07 May 2015 04:25:42 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: face-at-point: do not compute the final list if a sole value is wanted Date: Wed, 06 May 2015 21:25:40 +0000 Message-ID: <87pp6djt4b.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: wishlist The face-at-point function currently (1c7f0cdc4c1f, 2015-04-27 16:59:11 +00:00) uses delete-dups to compute a duplicate-free version of the list=E2=80=A6 just before taking a single value of it and discarding the rest in the (not multiple) case. Please thus consider the following patch. * lisp/faces.el (face-at-point): Do not compute the properly ordered, duplicate-free list if only a single value is requested. --=20 FSF associate member #7257 http://am-1.org/~ivan/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1937,8 +1937,9 @@ defun face-at-point (&optional thing multiple) (dolist (face faceprop) (if (facep face) (push face faces)))))) - (setq faces (delete-dups (nreverse faces))) - (if multiple faces (car faces)))) + (if multiple + (delete-dups (nreverse faces)) + (car (last faces))))) (defun foreground-color-at-point () "Return the foreground color of the character after point." --=-=-=-- ------------=_1432765865-16931-1--