GNU bug report logs - #20490
[PATCH] fixup: reference to uninitialized variable with invalid sequence

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Subject: bug#20490: closed (Re: [PATCH] fixup: reference to uninitialized
 variable with invalid sequence)
Date: Sun, 03 May 2015 17:07:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#20490: [PATCH] fixup: reference to uninitialized variable with invalid sequence

which was filed against the sed package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 20490 <at> debbugs.gnu.org.

-- 
20490: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20490
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 20490-done <at> debbugs.gnu.org
Subject: Re: [PATCH] fixup: reference to uninitialized variable with invalid
 sequence
Date: Sun, 3 May 2015 10:06:00 -0700

On Sat, May 2, 2015 at 7:09 PM, Jim Meyering <jim <at> meyering.net> wrote:
> On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>> Uninitialized variable are referred with invalid sequence in
>> str_append_modified().
>>
>> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is
>> uninitialized.  below may return unexpected result in order that the
>> value is referred at a following position in source code.
>>
>>   $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/'
>
> Thank you for the patch and reproducer.
> I've made some small improvements to the actual patch and
> wrote a valgrind-using test that I'm adding to the test suite.
> I've included your patch with an adjusted log, followed by
> the changes I made to it in a separate commit. That commit
> is separate solely to show what I've done; I will squash into your
> commit before I push, followed by the test-adding commit.

I've updated the commit log to reference this just-closed issue,
with this line:

  This addresses http://debbugs.gnu.org/20490

Then pushed.

[Message part 3 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: bug-sed <at> gnu.org
Subject: Re: [PATCH] fixup: reference to uninitialized variable with invalid
 sequence
Date: Sat, 2 May 2015 19:09:16 -0700

[Message part 4 (text/plain, inline)]

On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> Uninitialized variable are referred with invalid sequence in
> str_append_modified().
>
> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is
> uninitialized.  below may return unexpected result in order that the
> value is referred at a following position in source code.
>
>   $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/'

Thank you for the patch and reproducer.
I've made some small improvements to the actual patch and
wrote a valgrind-using test that I'm adding to the test suite.
I've included your patch with an adjusted log, followed by
the changes I made to it in a separate commit. That commit
is separate solely to show what I've done; I will squash into your
commit before I push, followed by the test-adding commit.

[0001-sed-avoid-a-UMR-bug-when-processing-an-invalid-multi.patch (application/octet-stream, attachment)]

[0002-fixup-for-bug-fix-to-be-squashed.patch (application/octet-stream, attachment)]

[0003-tests-test-for-just-fixed-UMR-bug.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.