From unknown Fri Jun 20 20:00:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#20490 <20490@debbugs.gnu.org> To: bug#20490 <20490@debbugs.gnu.org> Subject: Status: [PATCH] fixup: reference to uninitialized variable with invalid sequence Reply-To: bug#20490 <20490@debbugs.gnu.org> Date: Sat, 21 Jun 2025 03:00:08 +0000 retitle 20490 [PATCH] fixup: reference to uninitialized variable with inval= id sequence reassign 20490 sed submitter 20490 Jim Meyering severity 20490 normal tag 20490 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 22:09:52 2015 Received: (at submit) by debbugs.gnu.org; 3 May 2015 02:09:52 +0000 Received: from localhost ([127.0.0.1]:60075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YojLr-000666-Bw for submit@debbugs.gnu.org; Sat, 02 May 2015 22:09:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36376) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YojLn-00065n-SW for submit@debbugs.gnu.org; Sat, 02 May 2015 22:09:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YojLh-0004Ti-5A for submit@debbugs.gnu.org; Sat, 02 May 2015 22:09:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YojLh-0004TY-2f for submit@debbugs.gnu.org; Sat, 02 May 2015 22:09:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YojLf-0005jK-Rf for bug-sed@gnu.org; Sat, 02 May 2015 22:09:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YojLe-0004Si-J7 for bug-sed@gnu.org; Sat, 02 May 2015 22:09:39 -0400 Received: from mail-ie0-x233.google.com ([2607:f8b0:4001:c03::233]:35581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YojLe-0004Se-A4 for bug-sed@gnu.org; Sat, 02 May 2015 22:09:38 -0400 Received: by iejt8 with SMTP id t8so110712249iej.2 for ; Sat, 02 May 2015 19:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=F8Egix68gstSdzCylyQNE0qhbKMGr2+R7Y/09X1sPIk=; b=GaDVMWYZ/Sy2LmYaGUFzHrr/UkaT1KrHAEVXQAuLcN1EOTXUQmh9fH1kuXGrIQL53I sTAmi8OxVNfsBHXvikiH77PAJodwcDHio8M16qbFXK3wBy0dlI4WWu59gwraXwknkNk+ wes7fi9CMyLQ0zCckJJCNZHKvFE7NS6gC/K3o4mIa5kpAM7YkjbFC9h6uUCEF+bEJC79 Y3Pw9CPSlStYs25Rhi/CmujmEdH4EUURRXPNrJso0GC8/kkMpLD9sfaXGfVUplSDvghh g9Kxbc/NhuwJNLLnfyn3EfJWXrjmuUgkGCBYu/NuOE0tfRnuLgFSmbXYElGoTHRvYkrN Y3QQ== X-Received: by 10.107.164.6 with SMTP id n6mr14564196ioe.54.1430618977768; Sat, 02 May 2015 19:09:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.62.229 with HTTP; Sat, 2 May 2015 19:09:16 -0700 (PDT) In-Reply-To: <20141106003653.C721.27F6AC2D@kcn.ne.jp> References: <20141106003653.C721.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Sat, 2 May 2015 19:09:16 -0700 X-Google-Sender-Auth: Jw4bI6Ih4yNDb4UsPVF7FmlH9NQ Message-ID: Subject: Re: [PATCH] fixup: reference to uninitialized variable with invalid sequence To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=001a1141f5f6fb56fe051523ef79 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: bug-sed@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a1141f5f6fb56fe051523ef79 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka wrote: > Uninitialized variable are referred with invalid sequence in > str_append_modified(). > > When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is > uninitialized. below may return unexpected result in order that the > value is referred at a following position in source code. > > $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/' Thank you for the patch and reproducer. I've made some small improvements to the actual patch and wrote a valgrind-using test that I'm adding to the test suite. I've included your patch with an adjusted log, followed by the changes I made to it in a separate commit. That commit is separate solely to show what I've done; I will squash into your commit before I push, followed by the test-adding commit. --001a1141f5f6fb56fe051523ef79 Content-Type: application/octet-stream; name="0001-sed-avoid-a-UMR-bug-when-processing-an-invalid-multi.patch" Content-Disposition: attachment; filename="0001-sed-avoid-a-UMR-bug-when-processing-an-invalid-multi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i97tjmce1 RnJvbSA4NWQ5OWJjN2VmMmM3ZTA3ZmI3YjhkYjI5N2RjNjE2NTQ3MDNiNTUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb3JpaGlybyBUYW5ha2EgPG5vcml0bmtAa2NuLm5lLmpwPgpE YXRlOiBUaHUsIDYgTm92IDIwMTQgMTY6MzU6NDIgLTA2MDAKU3ViamVjdDogW1BBVENIIDEvM10g c2VkOiBhdm9pZCBhIFVNUiBidWcgd2hlbiBwcm9jZXNzaW5nIGFuIGludmFsaWQgbXVsdGlieXRl CiBzZXF1ZW5jZQoKKiBzZWQvZXhlY3V0ZS5jIChzdHJfYXBwZW5kX21vZGlmaWVkKTogV2hlbiBh dHRlbXB0aW5nIHRvIGFwcGVuZCBhbgppbnZhbGlkIG11bHRpYnl0ZSBzZXF1ZW5jZSwgZS5nLiwg ZnJvbSB0aGUgUkhTIG9mIGEgc3Vic3RpdHV0aW9uCmV4cHJlc3Npb24sIHdlIHdvdWxkIHJlYWQg dW5pbml0aWFsaXplZCBtZW1vcnkuCi0tLQogc2VkL2V4ZWN1dGUuYyB8IDE5ICsrKysrKysrKysr KysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL3NlZC9leGVjdXRlLmMgYi9zZWQvZXhlY3V0ZS5jCmluZGV4IDJlOTE5 ZjMuLmUyNDEwY2IgMTAwNjQ0Ci0tLSBhL3NlZC9leGVjdXRlLmMKKysrIGIvc2VkL2V4ZWN1dGUu YwpAQCAtMjE1LDEzICsyMTUsMjMgQEAgc3RyX2FwcGVuZF9tb2RpZmllZChzdHJ1Y3QgbGluZSAq dG8sIGNvbnN0IGNoYXIgKnN0cmluZywgc2l6ZV90IGxlbmd0aCwKICAgd2hpbGUgKGxlbmd0aCkK ICAgICB7CiAgICAgICB3Y2hhcl90IHdjOwotICAgICAgaW50IG4gPSBNQlJUT1dDICgmd2MsIHN0 cmluZywgbGVuZ3RoLCAmZnJvbV9zdGF0KTsKKyAgICAgIHNpemVfdCBuID0gTUJSVE9XQyAoJndj LCBzdHJpbmcsIGxlbmd0aCwgJmZyb21fc3RhdCk7CgogICAgICAgLyogQW4gaW52YWxpZCBzZXF1 ZW5jZSBpcyB0cmVhdGVkIGxpa2UgYSBzaW5nbGVieXRlIGNoYXJhY3Rlci4gKi8KICAgICAgIGlm IChuID09IC0xKQogICAgICAgICB7CiAgICAgICAgICAgbWVtc2V0ICgmdG8tPm1ic3RhdGUsIDAs IHNpemVvZiAoZnJvbV9zdGF0KSk7CisKKyAgICAgICAgICB0eXBlICY9IH4oUkVQTF9MT1dFUkNB U0VfRklSU1QgfCBSRVBMX1VQUEVSQ0FTRV9GSVJTVCk7CisgICAgICAgICAgaWYgKHR5cGUgPT0g UkVQTF9BU0lTKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICBzdHJfYXBwZW5kKHRvLCBz dHJpbmcsIGxlbmd0aCk7CisgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKwog ICAgICAgICAgIG4gPSAxOworICAgICAgICAgIHN0cmluZyArPSBuLCBsZW5ndGggLT0gbjsKKyAg ICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQoKICAgICAgIGlmIChuID4gMCkKQEAgLTI0NCwx MyArMjU0LDE4IEBAIHN0cl9hcHBlbmRfbW9kaWZpZWQoc3RydWN0IGxpbmUgKnRvLCBjb25zdCBj aGFyICpzdHJpbmcsIHNpemVfdCBsZW5ndGgsCiAgICAgICAgICAgdHlwZSAmPSB+KFJFUExfTE9X RVJDQVNFX0ZJUlNUIHwgUkVQTF9VUFBFUkNBU0VfRklSU1QpOwogICAgICAgICAgIGlmICh0eXBl ID09IFJFUExfQVNJUykKICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgLyogQ29weSB0aGUg bmV3IHdpZGUgY2hhcmFjdGVyIHRvIHRoZSBlbmQgb2YgdGhlIHN0cmluZy4gKi8KICAgICAgICAg ICAgICAgbiA9IFdDUlRPTUIgKHRvLT5hY3RpdmUgKyB0by0+bGVuZ3RoLCB3YywgJnRvLT5tYnN0 YXRlKTsKICAgICAgICAgICAgICAgdG8tPmxlbmd0aCArPSBuOworICAgICAgICAgICAgICBpZiAo biA9PSAtMSB8fCBuID09IC0yKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAg IGZwcmludGYgKHN0ZGVyciwgIkNhc2UgY29udmVyc2lvbiBwcm9kdWNlZCBhbiBpbnZhbGlkIGNo YXJhY3RlciEiKTsKKyAgICAgICAgICAgICAgICAgIGFib3J0ICgpOworICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgc3RyX2FwcGVuZCh0bywgc3RyaW5nLCBsZW5ndGgpOwogICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KLQogICAgICAgZWxzZSBp ZiAodHlwZSAmIFJFUExfVVBQRVJDQVNFKQogICAgICAgICB3YyA9IHRvd3VwcGVyKHdjKTsKICAg ICAgIGVsc2UKLS0gCjIuMy43Cgo= --001a1141f5f6fb56fe051523ef79 Content-Type: application/octet-stream; name="0002-fixup-for-bug-fix-to-be-squashed.patch" Content-Disposition: attachment; filename="0002-fixup-for-bug-fix-to-be-squashed.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i97tjmcm2 RnJvbSA4YTdiMWI0MGI1MzVmM2RlYWNjNTg1MjIwOThlNWE1NTMxN2Q1OTQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCAyIE1heSAyMDE1IDE2OjQyOjEzIC0wNzAwClN1YmplY3Q6IFtQQVRDSCAyLzNdIGZpeHVw IGZvciBidWcgZml4LCB0byBiZSBzcXVhc2hlZDoKCi0gYWRkIGEgTkVXUyBlbnRyeQotIGRvIG5v dCBjYWxsIG1lbXNldCBpZiB3ZSdyZSBhYm91dCB0byByZXR1cm4KLSBub3cgdGhhdCB3ZSdyZSB1 c2luZyBhIHZhcmlhYmxlIG9mIHR5cGUgc2l6ZV90LCBjYXN0CnRoZSBuZWdhdGl2ZSBSSFMgdmFs dWVzIHRvIChzaXplX3QpLgotIGRvbid0IGNhcGl0YWxpemUgZGlhZ25vc3RpYzsgcmVtb3ZlIGV4 Y2xhbWF0aW9uIHBvaW50Ci0gd3JhcCBuZXcgdHJhbnNsYXRhYmxlIHN0cmluZ3MgaW4gXyguLi4p Ci0tLQogTkVXUyAgICAgICAgICB8ICA1ICsrKysrCiBzZWQvZXhlY3V0ZS5jIHwgMTIgKysrKysr LS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvTkVXUyBiL05FV1MKaW5kZXggYjcxM2IxZC4uNDNmMDIwOSAxMDA2NDQK LS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC00LDYgKzQsMTEgQEAgR05VIHNlZCBORVdTICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLSotIG91dGxpbmUgLSotCgogKiogQnVnIGZp eGVzCgorICBzZWQgbm8gbG9uZ2VyIGFjY2Vzc2VzIHVuaW5pdGlhbGl6ZWQgbWVtb3J5IHdoZW4g cHJvY2Vzc2luZyBjZXJ0YWluCisgIGludmFsaWQgbXVsdGlieXRlIHNlcXVlbmNlcy4gRGVtb25z dHJhdGUgd2l0aCB0aGlzOgorICAgIGVjaG8gYSB8IExDX0FMTD1qYV9KUC5ldWNKUCB2YWxncmlu ZCBzZWQvc2VkICdzL2EvYlxVXHhiMmMvJworICBUaGUgZXJyb3IgYXBwZWFycyB0byBoYXZlIGJl ZW4gaW50cm9kdWNlZCB3aXRoIHRoZSBzZWQtNC4wYSByZWxlYXNlLgorCiAgIFRoZSAneScgKHRy YW5zbGl0ZXJhdGUpIG9wZXJhdG9yIG9uY2UgYWdhaW4gd29ya3Mgd2l0aCBhIE5VTCBieXRlCiAg IG9uIHRoZSBSSFMuICBFLmcuLCBzZWQgJ3kvYi9ceDAwLycgbm93IHdvcmtzIGxpa2UgdHIgYiAn XDAnLiAgR05VIHNlZAogICBoYXMgbmV2ZXIgYmVmb3JlIHJlY29nbml6ZWQgXHgwMCBpbiB0aGlz IGNvbnRleHQuICBIb3dldmVyLCBzZWQtMy4wMgpkaWZmIC0tZ2l0IGEvc2VkL2V4ZWN1dGUuYyBi L3NlZC9leGVjdXRlLmMKaW5kZXggZTI0MTBjYi4uNjMwZDY4ZiAxMDA2NDQKLS0tIGEvc2VkL2V4 ZWN1dGUuYworKysgYi9zZWQvZXhlY3V0ZS5jCkBAIC0yMTgsMTAgKzIxOCw4IEBAIHN0cl9hcHBl bmRfbW9kaWZpZWQoc3RydWN0IGxpbmUgKnRvLCBjb25zdCBjaGFyICpzdHJpbmcsIHNpemVfdCBs ZW5ndGgsCiAgICAgICBzaXplX3QgbiA9IE1CUlRPV0MgKCZ3Yywgc3RyaW5nLCBsZW5ndGgsICZm cm9tX3N0YXQpOwoKICAgICAgIC8qIEFuIGludmFsaWQgc2VxdWVuY2UgaXMgdHJlYXRlZCBsaWtl IGEgc2luZ2xlYnl0ZSBjaGFyYWN0ZXIuICovCi0gICAgICBpZiAobiA9PSAtMSkKKyAgICAgIGlm IChuID09IChzaXplX3QpIC0xKQogICAgICAgICB7Ci0gICAgICAgICAgbWVtc2V0ICgmdG8tPm1i c3RhdGUsIDAsIHNpemVvZiAoZnJvbV9zdGF0KSk7Ci0KICAgICAgICAgICB0eXBlICY9IH4oUkVQ TF9MT1dFUkNBU0VfRklSU1QgfCBSRVBMX1VQUEVSQ0FTRV9GSVJTVCk7CiAgICAgICAgICAgaWYg KHR5cGUgPT0gUkVQTF9BU0lTKQogICAgICAgICAgICAgewpAQCAtMjI5LDYgKzIyNyw3IEBAIHN0 cl9hcHBlbmRfbW9kaWZpZWQoc3RydWN0IGxpbmUgKnRvLCBjb25zdCBjaGFyICpzdHJpbmcsIHNp emVfdCBsZW5ndGgsCiAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KCisgICAg ICAgICAgbWVtc2V0ICgmdG8tPm1ic3RhdGUsIDAsIHNpemVvZiAoZnJvbV9zdGF0KSk7CiAgICAg ICAgICAgbiA9IDE7CiAgICAgICAgICAgc3RyaW5nICs9IG4sIGxlbmd0aCAtPSBuOwogICAgICAg ICAgIGNvbnRpbnVlOwpAQCAtMjU3LDkgKzI1NiwxMCBAQCBzdHJfYXBwZW5kX21vZGlmaWVkKHN0 cnVjdCBsaW5lICp0bywgY29uc3QgY2hhciAqc3RyaW5nLCBzaXplX3QgbGVuZ3RoLAogICAgICAg ICAgICAgICAvKiBDb3B5IHRoZSBuZXcgd2lkZSBjaGFyYWN0ZXIgdG8gdGhlIGVuZCBvZiB0aGUg c3RyaW5nLiAqLwogICAgICAgICAgICAgICBuID0gV0NSVE9NQiAodG8tPmFjdGl2ZSArIHRvLT5s ZW5ndGgsIHdjLCAmdG8tPm1ic3RhdGUpOwogICAgICAgICAgICAgICB0by0+bGVuZ3RoICs9IG47 Ci0gICAgICAgICAgICAgIGlmIChuID09IC0xIHx8IG4gPT0gLTIpCisgICAgICAgICAgICAgIGlm IChuID09IChzaXplX3QpIC0xIHx8IG4gPT0gKHNpemVfdCkgLTIpCiAgICAgICAgICAgICAgICAg ewotICAgICAgICAgICAgICAgICAgZnByaW50ZiAoc3RkZXJyLCAiQ2FzZSBjb252ZXJzaW9uIHBy b2R1Y2VkIGFuIGludmFsaWQgY2hhcmFjdGVyISIpOworICAgICAgICAgICAgICAgICAgZnByaW50 ZiAoc3RkZXJyLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiY2FzZSBjb252ZXJzaW9u IHByb2R1Y2VkIGFuIGludmFsaWQgY2hhcmFjdGVyIikpOwogICAgICAgICAgICAgICAgICAgYWJv cnQgKCk7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICBzdHJfYXBwZW5kKHRvLCBz dHJpbmcsIGxlbmd0aCk7CkBAIC0yNzYsNyArMjc2LDcgQEAgc3RyX2FwcGVuZF9tb2RpZmllZChz dHJ1Y3QgbGluZSAqdG8sIGNvbnN0IGNoYXIgKnN0cmluZywgc2l6ZV90IGxlbmd0aCwKICAgICAg IHRvLT5sZW5ndGggKz0gbjsKICAgICAgIGlmIChuID09IC0xIHx8IG4gPT0gLTIpCiAgICAgICAg IHsKLSAgICAgICAgICBmcHJpbnRmIChzdGRlcnIsICJDYXNlIGNvbnZlcnNpb24gcHJvZHVjZWQg YW4gaW52YWxpZCBjaGFyYWN0ZXIhIik7CisgICAgICAgICAgZnByaW50ZiAoc3RkZXJyLCBfKCJj YXNlIGNvbnZlcnNpb24gcHJvZHVjZWQgYW4gaW52YWxpZCBjaGFyYWN0ZXIiKSk7CiAgICAgICAg ICAgYWJvcnQgKCk7CiAgICAgICAgIH0KICAgICB9Ci0tIAoyLjMuNwoK --001a1141f5f6fb56fe051523ef79 Content-Type: application/octet-stream; name="0003-tests-test-for-just-fixed-UMR-bug.patch" Content-Disposition: attachment; filename="0003-tests-test-for-just-fixed-UMR-bug.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i97tjmcr3 RnJvbSA5ODM1NDljOGE1YTYxNTJmOWVkZDY5MTRjN2E4OTExZjUwNTkwNGRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCAyIE1heSAyMDE1IDE4OjIyOjQxIC0wNzAwClN1YmplY3Q6IFtQQVRDSCAzLzNdIHRlc3Rz OiB0ZXN0IGZvciBqdXN0LWZpeGVkIFVNUiBidWcKCiogdGVzdHN1aXRlL2ludmFsaWQtbWItc2Vx LVVNUi5zaDogTmV3IGZpbGUuIFRlc3QgZm9yIGp1c3QtZml4ZWQgYnVnLgoqIHRlc3RzdWl0ZS9N YWtlZmlsZS5hbSAoVCk6IE5ldyB2YXJpYWJsZS4KQWRkIHRoZSB0d28gaW5pdC5zaC11c2luZyB0 ZXN0IG5hbWVzIGhlcmUsIHJhdGhlciB0aGFuIGluCnR3byBzZXBhcmF0ZSBsaXN0cy4KKFNFRFRF U1RTLCBFWFRSQV9ESVNUKTogVXNlICQoVCkuCihFWFRSQV9ESVNUKTogQWRkIGluaXQuY2ZnLgoq IHRlc3RzdWl0ZS9pbml0LmNmZzogTmV3IGZpbGUsIHRvIGFkZCBmdW5jdGlvbnMgZnJvbSBjb3Jl dXRpbHMuCihyZXF1aXJlX3ZhbGdyaW5kXywgcHJpbnRfdmVyXyk6IE5ldyBmdW5jdGlvbnMuCi0t LQogdGVzdHN1aXRlL01ha2VmaWxlLmFtICAgICAgICAgICB8IDE5ICsrKysrKysrKysrKysrKyst LS0KIHRlc3RzdWl0ZS9pbml0LmNmZyAgICAgICAgICAgICAgfCA0MiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwogdGVzdHN1aXRlL2ludmFsaWQtbWItc2VxLVVNUi5z aCB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwg OTAgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0 c3VpdGUvaW5pdC5jZmcKIGNyZWF0ZSBtb2RlIDEwMDc1NSB0ZXN0c3VpdGUvaW52YWxpZC1tYi1z ZXEtVU1SLnNoCgpkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL01ha2VmaWxlLmFtIGIvdGVzdHN1aXRl L01ha2VmaWxlLmFtCmluZGV4IGIxMGQ3MmMuLmU5MTVhNmYgMTAwNjQ0Ci0tLSBhL3Rlc3RzdWl0 ZS9NYWtlZmlsZS5hbQorKysgYi90ZXN0c3VpdGUvTWFrZWZpbGUuYW0KQEAgLTMsNyArMywxNCBA QCBDTEVBTkZJTEVTID0gdG1wKiBjb3JlICouY29yZSAkKEVYVFJBX1BST0dSQU1TKSAqLipvdXQg Ki5sb2cgZXZhbC5pbjIKIFRFU1RfRVhURU5TSU9OUyA9IC5zaAogU0hfTE9HX0NPTVBJTEVSID0g JChTSEVMTCkKCi1URVNUUyA9ICQoY2hlY2tfUFJPR1JBTVMpICQoU0VEVEVTVFMpIGhlbHAtdmVy c2lvbi5zaAorIyBQdXQgbmV3LCBpbml0LnNoLXVzaW5nIHRlc3RzIGhlcmUsIHNvIHRoYXQgZWFj aCBuYW1lCisjIGlzIGxpc3RlZCBpbiBvbmx5IG9uZSBwbGFjZS4KK1QgPQkJCVwKKyAgaGVscC12 ZXJzaW9uLnNoCVwKKyAgaW52YWxpZC1tYi1zZXEtVU1SLnNoCisKK1RFU1RTID0gJChjaGVja19Q Uk9HUkFNUykgJChTRURURVNUUykgJChUKQorCiBTRURURVNUUyA9CgogTERBREQgPSAuLi9saWIv bGlic2VkLmEgJChJTlRMTElCUykKQEAgLTMxLDE3ICszOCwyMyBAQCBTRURURVNUUyArPSBcCiAJ aGVscCBmaWxlIHF1aWV0IFwKIAlmYWN0b3IgYmluYXJ5MyBiaW5hcnkyIGJpbmFyeSBkYwoKKyMg Tm90ZSB0aGF0IHRoZSBmaXJzdCBsaW5lcyBhcmUgc3RhdGVtZW50cy4gIFRoZXkgZW5zdXJlIHRo YXQgZW52aXJvbm1lbnQKKyMgdmFyaWFibGVzIHRoYXQgY2FuIHBlcnR1cmIgdGVzdHMgYXJlIHVu c2V0IG9yIHNldCB0byBleHBlY3RlZCB2YWx1ZXMuCisjIFRoZSByZXN0IGFyZSBlbnZ2YXIgc2V0 dGluZ3MgdGhhdCBwcm9wYWdhdGUgYnVpbGQtcmVsYXRlZCBNYWtlZmlsZQorIyB2YXJpYWJsZXMg dG8gdGVzdCBzY3JpcHRzLgogVEVTVFNfRU5WSVJPTk1FTlQgPQkJCQlcCisgIGV4cG9ydAkJCQkJ XAogICBWRVJTSU9OPSckKFZFUlNJT04pJwkJCQlcCiAgIE1BS0U9IiQoTUFLRSkiCQkJCVwKICAg VkVSU0lPTj0iJChWRVJTSU9OKSIJCQkJXAogICBidWlsdF9wcm9ncmFtcz1zZWQJCQkJXAotICAk KExPQ0FMQ0hBUlNFVF9URVNUU19FTlZJUk9OTUVOVCkKKyAgJChMT0NBTENIQVJTRVRfVEVTVFNf RU5WSVJPTk1FTlQpCQlcCisgIDsgOT4mMgoKIExPR19DT01QSUxFUiA9ICQoc3JjZGlyKS9ydW50 ZXN0CgogRVhUUkFfRElTVCA9IFwKLQloZWxwLXZlcnNpb24uc2ggaW5pdC5zaCBcCisJJChUKSBp bml0LnNoIGluaXQuY2ZnIFwKIAlQQ1JFLnRlc3RzIEJPT1NULnRlc3RzIFNQRU5DRVIudGVzdHMg XAogCXJ1bnRlc3QgTWFrZWZpbGUudGVzdHMgXAogCTByYW5nZS5nb29kIDByYW5nZS5pbnAgMHJh bmdlLnNlZCBcCmRpZmYgLS1naXQgYS90ZXN0c3VpdGUvaW5pdC5jZmcgYi90ZXN0c3VpdGUvaW5p dC5jZmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTVlYWY1MgotLS0gL2Rl di9udWxsCisrKyBiL3Rlc3RzdWl0ZS9pbml0LmNmZwpAQCAtMCwwICsxLDQyIEBACisjIFRoaXMg ZmlsZSBpcyBzb3VyY2VkIGJ5IGluaXQuc2gsICpiZWZvcmUqIGl0cyBpbml0aWFsaXphdGlvbi4K KworIyBDb3B5cmlnaHQgKEMpIDIwMTAtMjAxNSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIElu Yy4KKworIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3RyaWJ1 dGUgaXQgYW5kL29yIG1vZGlmeQorIyBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5l cmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQorIyB0aGUgRnJlZSBTb2Z0d2FyZSBG b3VuZGF0aW9uLCBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorIyAoYXQgeW91 ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCisjIFRoaXMgcHJvZ3JhbSBpcyBkaXN0cmli dXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorIyBidXQgV0lUSE9VVCBB TlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJD SEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhl CisjIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisKKyMgWW91 IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UKKyMgYWxvbmcgd2l0aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3 dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKyMgVGhpcyBnb2VzIGhhbmQgaW4gaGFuZCB3aXRoIHRo ZSAiZXhlYyA5PiYyOyIgaW4gdGVzdHMvTWFrZWZpbGUuYW0ncworIyBURVNUU19FTlZJUk9OTUVO VCBkZWZpbml0aW9uLgorc3RkZXJyX2ZpbGVub189OQorCisjIFNraXAgdGhlIGN1cnJlbnQgdGVz dCBpZiB2YWxncmluZCBkb2Vzbid0IHdvcmssCisjIHdoaWNoIGNvdWxkIGhhcHBlbiBpZiBub3Qg aW5zdGFsbGVkLAorIyBvciBoYXNuJ3Qgc3VwcG9ydCBmb3IgdGhlIGJ1aWx0IGFyY2hpdGVjdHVy ZSwKKyMgb3IgaGFzbid0IGFwcHJvcHJpYXRlIGVycm9yIHN1cHByZXNzaW9ucyBpbnN0YWxsZWQg ZXRjLgorcmVxdWlyZV92YWxncmluZF8oKQoreworICB2YWxncmluZCAtLWVycm9yLWV4aXRjb2Rl PTEgdHJ1ZSAyPi9kZXYvbnVsbCB8fAorICAgIHNraXBfICJyZXF1aXJlcyBhIHdvcmtpbmcgdmFs Z3JpbmQiCit9CisKKyMgQ2FsbCB0aGlzIHdpdGggYSBsaXN0IG9mIHByb2dyYW1zIHVuZGVyIHRl c3QgaW1tZWRpYXRlbHkgYWZ0ZXIKKyMgc291cmNpbmcgaW5pdC5zaC4KK3ByaW50X3Zlcl8oKQor eworICBpZiB0ZXN0ICIkVkVSQk9TRSIgPSB5ZXM7IHRoZW4KKyAgICBsb2NhbCBpCisgICAgZm9y IGkgaW4gJCo7IGRvCisgICAgICBlbnYgJGkgLS12ZXJzaW9uCisgICAgZG9uZQorICBmaQorfQpk aWZmIC0tZ2l0IGEvdGVzdHN1aXRlL2ludmFsaWQtbWItc2VxLVVNUi5zaCBiL3Rlc3RzdWl0ZS9p bnZhbGlkLW1iLXNlcS1VTVIuc2gKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMC4u MzNiNThmYwotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3RzdWl0ZS9pbnZhbGlkLW1iLXNlcS1VTVIu c2gKQEAgLTAsMCArMSwzMiBAQAorIyEvYmluL3NoCisjIEluc2VydGluZyBhbiBpbnZhbGlkIG11 bHRpYnl0ZSBzZXF1ZW5jZSBjb3VsZCBsZWFkIHRvCisjIHJlYWRpbmcgdW5pbml0aWFsaXplZCBt ZW1vcnkuCisKKyMgQ29weXJpZ2h0IChDKSAyMDE1IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwg SW5jLgorCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlzdHJp YnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdl bmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNvZnR3YXJl IEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCisjIChhdCB5 b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyMgVGhpcyBwcm9ncmFtIGlzIGRpc3Ry aWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisjIGJ1dCBXSVRIT1VU IEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisjIE1F UkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0 aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworIyBZ b3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMg TGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2VlIDxodHRwOi8v d3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKy4gIiR7c3JjZGlyPS59L2luaXQuc2giOyBwYXRoX3By ZXBlbmRfIC4uL3NlZAorcHJpbnRfdmVyXyBzZWQKKworcmVxdWlyZV92YWxncmluZF8KKworZWNo byBhID4gaW4gfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCitlY2hvIGJDID4gZXhwIHx8IGZyYW1ld29y a19mYWlsdXJlXworTENfQUxMPWphX0pQLmV1Y0pQIHZhbGdyaW5kIC0tcXVpZXQgLS1lcnJvci1l eGl0Y29kZT0xIFwKKyAgc2VkIC1lICdzL2EvYlxVXHhiMmMvJyBpbiA+IG91dCAyPiBlcnIgfHwg ZmFpbD0xCisKK2NvbXBhcmUgZXhwIG91dCB8fCBmYWlsPTEKK2NvbXBhcmUgL2Rldi9udWxsIGVy ciB8fCBmYWlsPTEKKworRXhpdCAkZmFpbAotLSAKMi4zLjcKCg== --001a1141f5f6fb56fe051523ef79-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 13:06:29 2015 Received: (at 20490-done) by debbugs.gnu.org; 3 May 2015 17:06:29 +0000 Received: from localhost ([127.0.0.1]:60875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoxLZ-0006nD-8w for submit@debbugs.gnu.org; Sun, 03 May 2015 13:06:29 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:36495) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoxLX-0006n0-7V for 20490-done@debbugs.gnu.org; Sun, 03 May 2015 13:06:27 -0400 Received: by iebrs15 with SMTP id rs15so116711467ieb.3 for <20490-done@debbugs.gnu.org>; Sun, 03 May 2015 10:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=YxuFEZij18MTccBxXhL+xc4VuKPxvppRogpRQi0+oXw=; b=gTfm9+YdGyXJIUitWigI4Hv5Ne0lu0Kc5WC2UcwDS8Lbpy0EDTag7CVoYYALq2Rubb Dz+ZFT08yO1omVkpND5NaAPYJ7FBebRwfbgVdGCAYllBcjLJyl6wtqvioih7tvYaSoS2 OBNPi333ckbXYj5J/TLdNhXrLxDnCAhD7k2DTOygrZ6xsY3dYmlMrhe4S3LZTZuEDQtF GgTWd7UlEo548d4dj5tJON/xg2s4JQuO3PyPU2VrA1zrMvAMp86hHrKQFA+xN5XKuDvq LPVjpb49yJicZKQpmCBrNWI7AsAOslDqJwk+8i42Gv5YYO8D1v+0se9NLkYp2VkgRxiw 2L3g== X-Received: by 10.50.78.170 with SMTP id c10mr8796366igx.0.1430672780710; Sun, 03 May 2015 10:06:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.62.229 with HTTP; Sun, 3 May 2015 10:06:00 -0700 (PDT) In-Reply-To: References: <20141106003653.C721.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Sun, 3 May 2015 10:06:00 -0700 X-Google-Sender-Auth: L4-4RUq5aS3qfHW8IMNk2nmfvL8 Message-ID: Subject: Re: [PATCH] fixup: reference to uninitialized variable with invalid sequence To: Norihiro Tanaka Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20490-done Cc: 20490-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, May 2, 2015 at 7:09 PM, Jim Meyering wrote: > On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka wrote: >> Uninitialized variable are referred with invalid sequence in >> str_append_modified(). >> >> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is >> uninitialized. below may return unexpected result in order that the >> value is referred at a following position in source code. >> >> $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/' > > Thank you for the patch and reproducer. > I've made some small improvements to the actual patch and > wrote a valgrind-using test that I'm adding to the test suite. > I've included your patch with an adjusted log, followed by > the changes I made to it in a separate commit. That commit > is separate solely to show what I've done; I will squash into your > commit before I push, followed by the test-adding commit. I've updated the commit log to reference this just-closed issue, with this line: This addresses http://debbugs.gnu.org/20490 Then pushed. From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 05:42:06 2015 Received: (at 20490) by debbugs.gnu.org; 5 May 2015 09:42:06 +0000 Received: from localhost ([127.0.0.1]:34360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpZMb-0002cD-Nn for submit@debbugs.gnu.org; Tue, 05 May 2015 05:42:05 -0400 Received: from mailgw06.kcn.ne.jp ([61.86.7.213]:47251) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpZMZ-0002bg-2i for 20490@debbugs.gnu.org; Tue, 05 May 2015 05:42:04 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw06.kcn.ne.jp (Postfix) with ESMTP id 98212E806B9 for <20490@debbugs.gnu.org>; Tue, 5 May 2015 18:41:55 +0900 (JST) X-matriXscan-loop-detect: bfe22c35a3475374a5f2131f377f4754c754853d Received: from mail07.kcn.ne.jp ([61.86.6.186]) by mxs01-s with ESMTP; Tue, 05 May 2015 18:41:54 +0900 (JST) Received: from [10.120.1.57] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail07.kcn.ne.jp (Postfix) with ESMTPA id 19190D5009B; Tue, 5 May 2015 18:41:54 +0900 (JST) Date: Tue, 05 May 2015 18:41:52 +0900 From: Norihiro Tanaka To: 20490@debbugs.gnu.org, jim@meyering.net, jim@meyering.net Subject: Re: bug#20490: [PATCH] fixup: reference to uninitialized variable with invalid sequence In-Reply-To: References: Message-Id: <20150505184151.199A.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20490 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sun, 3 May 2015 10:06:00 -0700 Jim Meyering wrote: > > Thank you for the patch and reproducer. > > I've made some small improvements to the actual patch and > > wrote a valgrind-using test that I'm adding to the test suite. > > I've included your patch with an adjusted log, followed by > > the changes I made to it in a separate commit. That commit > > is separate solely to show what I've done; I will squash into your > > commit before I push, followed by the test-adding commit. > > I've updated the commit log to reference this just-closed issue, > with this line: > > This addresses http://debbugs.gnu.org/20490 > > Then pushed. Thanks for review and ajustment. I confirmed them. From debbugs-submit-bounces@debbugs.gnu.org Tue May 05 19:59:00 2015 Received: (at 20490) by debbugs.gnu.org; 5 May 2015 23:59:00 +0000 Received: from localhost ([127.0.0.1]:35742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ypmjr-0008HH-GV for submit@debbugs.gnu.org; Tue, 05 May 2015 19:59:00 -0400 Received: from mailgw05.kcn.ne.jp ([61.86.7.212]:42158) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ypmjn-0008H5-Cz for 20490@debbugs.gnu.org; Tue, 05 May 2015 19:58:57 -0400 Received: from mxs02-s (mailgw2.kcn.ne.jp [61.86.15.234]) by mailgw05.kcn.ne.jp (Postfix) with ESMTP id 5F59D880415 for <20490@debbugs.gnu.org>; Wed, 6 May 2015 08:58:53 +0900 (JST) X-matriXscan-loop-detect: 0f16fc2f9b25e1f87b10037327fcee3330d32b04 Received: from mail05.kcn.ne.jp ([61.86.6.184]) by mxs02-s with ESMTP; Wed, 06 May 2015 08:58:51 +0900 (JST) Received: from [10.120.1.69] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail05.kcn.ne.jp (Postfix) with ESMTPA id BD7CD7D0099; Wed, 6 May 2015 08:58:51 +0900 (JST) Date: Wed, 06 May 2015 08:58:47 +0900 From: Norihiro Tanaka To: jim@meyering.net Subject: Re: bug#20490: [PATCH] fixup: reference to uninitialized variable with invalid sequence In-Reply-To: References: Message-Id: <20150506085810.647C.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------_55495890000000006482_MULTIPART_MIXED_" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20490 Cc: 20490@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --------_55495890000000006482_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Sun, 3 May 2015 10:06:00 -0700 Jim Meyering wrote: > On Sat, May 2, 2015 at 7:09 PM, Jim Meyering wrote: > > On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka wrote: > >> Uninitialized variable are referred with invalid sequence in > >> str_append_modified(). > >> > >> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is > >> uninitialized. below may return unexpected result in order that the > >> value is referred at a following position in source code. > >> > >> $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/' > > > > Thank you for the patch and reproducer. > > I've made some small improvements to the actual patch and > > wrote a valgrind-using test that I'm adding to the test suite. > > I've included your patch with an adjusted log, followed by > > the changes I made to it in a separate commit. That commit > > is separate solely to show what I've done; I will squash into your > > commit before I push, followed by the test-adding commit. > > I've updated the commit log to reference this just-closed issue, > with this line: > > This addresses http://debbugs.gnu.org/20490 > > Then pushed. I see that this bug itself is correctly fixed by the patch. I ran new test on CentOS 5.10 (x86), and ran accross an error in attachment even after applying the patch. --------_55495890000000006482_MULTIPART_MIXED_ Content-Type: text/plain; charset="US-ASCII"; name="test-suite.log" Content-Disposition: attachment; filename="test-suite.log" Content-Transfer-Encoding: base64 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KICAgR05VIHNlZCA0LjIuMi44MS1hZWIzLWRpcnR5OiB0ZXN0c3VpdGUvdGVzdC1zdWl0ZS5s b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KCiMgVE9UQUw6IDY5CiMgUEFTUzogIDY4CiMgU0tJUDogIDAKIyBYRkFJTDogMAojIEZB SUw6ICAxCiMgWFBBU1M6IDAKIyBFUlJPUjogMAoKLi4gY29udGVudHM6OiA6ZGVwdGg6IDIKCkZB SUw6IGludmFsaWQtbWItc2VxLVVNUgo9PT09PT09PT09PT09PT09PT09PT09PT0KCisrIGluaXRp YWxfY3dkXz0vaG9tZS9zdGFmZi9zZWQvdGVzdHN1aXRlCisrIGZhaWw9MAorKysgdGVzdGRpcl9w cmVmaXhfCisrKyBwcmludGYgZ3QKKysgcGZ4Xz1ndAorKysgbWt0ZW1wZF8gL2hvbWUvc3RhZmYv c2VkL3Rlc3RzdWl0ZSBndC1pbnZhbGlkLW1iLXNlcS1VTVIuc2guWFhYWAorKysgY2FzZSAkIyBp bgorKysgZGVzdGRpcl89L2hvbWUvc3RhZmYvc2VkL3Rlc3RzdWl0ZQorKysgdGVtcGxhdGVfPWd0 LWludmFsaWQtbWItc2VxLVVNUi5zaC5YWFhYCisrKyBNQVhfVFJJRVNfPTQKKysrIGNhc2UgJGRl c3RkaXJfIGluCisrKyBjYXNlICR0ZW1wbGF0ZV8gaW4KKysrKyB1bnNldCBUTVBESVIKKysrIGQ9 L2hvbWUvc3RhZmYvc2VkL3Rlc3RzdWl0ZS9ndC1pbnZhbGlkLW1iLXNlcS1VTVIuc2guNTAwMAor KysgY2FzZSAkZCBpbgorKysgdGVzdCAtZCAvaG9tZS9zdGFmZi9zZWQvdGVzdHN1aXRlL2d0LWlu dmFsaWQtbWItc2VxLVVNUi5zaC41MDAwCisrKysgbHMgLWRnbyAvaG9tZS9zdGFmZi9zZWQvdGVz dHN1aXRlL2d0LWludmFsaWQtbWItc2VxLVVNUi5zaC41MDAwCisrKysgdHIgUyAtCisrKyBwZXJt cz0nZHJ3eC0tLS0tLSAyIDQwOTYgTWF5ICA2IDA4OjQ3IC9ob21lL3N0YWZmL3NlZC90ZXN0c3Vp dGUvZ3QtaW52YWxpZC1tYi1zZXEtVU1SLnNoLjUwMDAnCisrKyBjYXNlICRwZXJtcyBpbgorKysg dGVzdCAwID0gMAorKysgZWNobyAvaG9tZS9zdGFmZi9zZWQvdGVzdHN1aXRlL2d0LWludmFsaWQt bWItc2VxLVVNUi5zaC41MDAwCisrKyByZXR1cm4KKysgdGVzdF9kaXJfPS9ob21lL3N0YWZmL3Nl ZC90ZXN0c3VpdGUvZ3QtaW52YWxpZC1tYi1zZXEtVU1SLnNoLjUwMDAKKysgY2QgL2hvbWUvc3Rh ZmYvc2VkL3Rlc3RzdWl0ZS9ndC1pbnZhbGlkLW1iLXNlcS1VTVIuc2guNTAwMAorKyBnbF9pbml0 X3NoX25sXz0nCicKKysgSUZTPScgCQonCisrIGZvciBzaWdfIGluIDEgMiAzIDEzIDE1CisrKyBl eHByIDEgKyAxMjgKKysgZXZhbCAndHJhcCAnXCcnRXhpdCAxMjknXCcnIDEnCisrKyB0cmFwICdF eGl0IDEyOScgMQorKyBmb3Igc2lnXyBpbiAxIDIgMyAxMyAxNQorKysgZXhwciAyICsgMTI4Cisr IGV2YWwgJ3RyYXAgJ1wnJ0V4aXQgMTMwJ1wnJyAyJworKysgdHJhcCAnRXhpdCAxMzAnIDIKKysg Zm9yIHNpZ18gaW4gMSAyIDMgMTMgMTUKKysrIGV4cHIgMyArIDEyOAorKyBldmFsICd0cmFwICdc JydFeGl0IDEzMSdcJycgMycKKysrIHRyYXAgJ0V4aXQgMTMxJyAzCisrIGZvciBzaWdfIGluIDEg MiAzIDEzIDE1CisrKyBleHByIDEzICsgMTI4CisrIGV2YWwgJ3RyYXAgJ1wnJ0V4aXQgMTQxJ1wn JyAxMycKKysrIHRyYXAgJ0V4aXQgMTQxJyAxMworKyBmb3Igc2lnXyBpbiAxIDIgMyAxMyAxNQor KysgZXhwciAxNSArIDEyOAorKyBldmFsICd0cmFwICdcJydFeGl0IDE0MydcJycgMTUnCisrKyB0 cmFwICdFeGl0IDE0MycgMTUKKysgdHJhcCByZW1vdmVfdG1wXyAwCisgcGF0aF9wcmVwZW5kXyAu Li9zZWQKKyB0ZXN0IDEgJyE9JyAwCisgcGF0aF9kaXJfPS4uL3NlZAorIGNhc2UgJHBhdGhfZGly XyBpbgorIGFic19wYXRoX2Rpcl89L2hvbWUvc3RhZmYvc2VkL3Rlc3RzdWl0ZS8uLi9zZWQKKyBj YXNlICRhYnNfcGF0aF9kaXJfIGluCisgUEFUSD0vaG9tZS9zdGFmZi9zZWQvdGVzdHN1aXRlLy4u L3NlZDovaG9tZS9zdGFmZi9iaW46L29wdC9naXQvYmluOi9vcHQvamF2YS9iaW46L29wdC9weXRo b24vYmluOi9vcHQvcGVybC9iaW46L3Vzci9sb2NhbC9iaW46L3NiaW46L2JpbjovdXNyL3NiaW46 L3Vzci9iaW4KKyBjcmVhdGVfZXhlX3NoaW1zXyAvaG9tZS9zdGFmZi9zZWQvdGVzdHN1aXRlLy4u L3NlZAorIGNhc2UgJEVYRUVYVCBpbgorIHJldHVybiAwCisgc2hpZnQKKyB0ZXN0IDAgJyE9JyAw CisgZXhwb3J0IFBBVEgKKyBwcmludF92ZXJfIHNlZAorIHRlc3QgeWVzID0geWVzCisgbG9jYWwg aQorIGZvciBpIGluICckKicKKyBlbnYgc2VkIC0tdmVyc2lvbgpzZWQgKEdOVSBzZWQpIDQuMi4y LjgxLWFlYjMtZGlydHkKQ29weXJpZ2h0IChDKSAyMDE1IEZyZWUgU29mdHdhcmUgRm91bmRhdGlv biwgSW5jLgpMaWNlbnNlIEdQTHYzKzogR05VIEdQTCB2ZXJzaW9uIDMgb3IgbGF0ZXIgPGh0dHA6 Ly9nbnUub3JnL2xpY2Vuc2VzL2dwbC5odG1sPi4KVGhpcyBpcyBmcmVlIHNvZnR3YXJlOiB5b3Ug YXJlIGZyZWUgdG8gY2hhbmdlIGFuZCByZWRpc3RyaWJ1dGUgaXQuClRoZXJlIGlzIE5PIFdBUlJB TlRZLCB0byB0aGUgZXh0ZW50IHBlcm1pdHRlZCBieSBsYXcuCgpXcml0dGVuIGJ5IEpheSBGZW5s YXNvbiwgVG9tIExvcmQsIEtlbiBQaXp6aW5pLAphbmQgUGFvbG8gQm9uemluaS4KR05VIHNlZCBo b21lIHBhZ2U6IDxodHRwOi8vd3d3LmdudS5vcmcvc29mdHdhcmUvc2VkLz4uCkdlbmVyYWwgaGVs cCB1c2luZyBHTlUgc29mdHdhcmU6IDxodHRwOi8vd3d3LmdudS5vcmcvZ2V0aGVscC8+LgpFLW1h aWwgYnVnIHJlcG9ydHMgdG86IDxidWctc2VkQGdudS5vcmc+LgpCZSBzdXJlIHRvIGluY2x1ZGUg dGhlIHdvcmQgYGBzZWQnJyBzb21ld2hlcmUgaW4gdGhlIGBgU3ViamVjdDonJyBmaWVsZC4KKyBy ZXF1aXJlX3ZhbGdyaW5kXworIHZhbGdyaW5kIC0tZXJyb3ItZXhpdGNvZGU9MSB0cnVlCisgZWNo byBhCisgZWNobyBiQworIExDX0FMTD1qYV9KUC5ldWNKUAorIHZhbGdyaW5kIC0tcXVpZXQgLS1l cnJvci1leGl0Y29kZT0xIHNlZCAtZSAncy9hL2JcVVx4YjJjLycgaW4KKyBmYWlsPTEKKyBjb21w YXJlIGV4cCBvdXQKKyBjb21wYXJlX2Rldl9udWxsXyBleHAgb3V0CisgdGVzdCAyID0gMgorIHRl c3QgeGV4cCA9IHgvZGV2L251bGwKKyB0ZXN0IHhvdXQgPSB4L2Rldi9udWxsCisgcmV0dXJuIDIK KyBjYXNlICQ/IGluCisgY29tcGFyZV8gZXhwIG91dAorIGRpZmYgLXUgZXhwIG91dAotLS0gZXhw CTIwMTUtMDUtMDYgMDg6NDc6MzcuMDAwMDAwMDAwICswOTAwCisrKyBvdXQJMjAxNS0wNS0wNiAw ODo0NzozNy4wMDAwMDAwMDAgKzA5MDAKQEAgLTEgKzAsMCBAQAotYkMKKyBmYWlsPTEKKyBjb21w YXJlIC9kZXYvbnVsbCBlcnIKKyBjb21wYXJlX2Rldl9udWxsXyAvZGV2L251bGwgZXJyCisgdGVz dCAyID0gMgorIHRlc3QgeC9kZXYvbnVsbCA9IHgvZGV2L251bGwKKyB0ZXN0IC1zIGVycgorIGVt aXRfZGlmZl91X2hlYWRlcl8gL2Rldi9udWxsIGVycgorIHByaW50ZiAnJXNcbicgJ2RpZmYgLXUg L2Rldi9udWxsIGVycicgJy0tLSAvZGV2L251bGwJMTk3MC0wMS0wMScgJysrKyBlcnIJMTk3MC0w MS0wMScKZGlmZiAtdSAvZGV2L251bGwgZXJyCi0tLSAvZGV2L251bGwJMTk3MC0wMS0wMQorKysg ZXJyCTE5NzAtMDEtMDEKKyBzZWQgJ3MvXi8rLycgZXJyCistLTUwMTYtLSBXYXJuaW5nOiBEV0FS RjIgQ0ZJIHJlYWRlcjogdW5oYW5kbGVkIERXX09QXyBvcGNvZGUgMHgyYQorCit2YWxncmluZDog bV9kZWJ1Z2luZm8vcmVhZGR3YXJmLmM6MjI2MiAoY29weV9jb252ZXJ0X0NmaUV4cHJfdHJlZSk6 IEFzc2VydGlvbiAnc3JjaXggPj0gMCAmJiBzcmNpeCA8IFZHXyhzaXplWEEpKHNyY3hhKScgZmFp bGVkLgorPT01MDE2PT0gICAgYXQgMHgzODAyNzgwRDogPz8/IChpbiAvdXNyL2xpYi92YWxncmlu ZC9tZW1jaGVjay14ODYtbGludXgpCisKK3NjaGVkIHN0YXR1czoKKyAgcnVubmluZ190aWQ9MAor CisKK05vdGU6IHNlZSBhbHNvIHRoZSBGQVEgaW4gdGhlIHNvdXJjZSBkaXN0cmlidXRpb24uCitJ dCBjb250YWlucyB3b3JrYXJvdW5kcyB0byBzZXZlcmFsIGNvbW1vbiBwcm9ibGVtcy4KK0luIHBh cnRpY3VsYXIsIGlmIFZhbGdyaW5kIGFib3J0ZWQgb3IgY3Jhc2hlZCBhZnRlcgoraWRlbnRpZnlp bmcgcHJvYmxlbXMgaW4geW91ciBwcm9ncmFtLCB0aGVyZSdzIGEgZ29vZCBjaGFuY2UKK3RoYXQg Zml4aW5nIHRob3NlIHByb2JsZW1zIHdpbGwgcHJldmVudCBWYWxncmluZCBhYm9ydGluZyBvcgor Y3Jhc2hpbmcsIGVzcGVjaWFsbHkgaWYgaXQgaGFwcGVuZWQgaW4gbV9tYWxsb2NmcmVlLmMuCisK K0lmIHRoYXQgZG9lc24ndCBoZWxwLCBwbGVhc2UgcmVwb3J0IHRoaXMgYnVnIHRvOiB3d3cudmFs Z3JpbmQub3JnCisKK0luIHRoZSBidWcgcmVwb3J0LCBzZW5kIGFsbCB0aGUgYWJvdmUgdGV4dCwg dGhlIHZhbGdyaW5kCit2ZXJzaW9uLCBhbmQgd2hhdCBPUyBhbmQgdmVyc2lvbiB5b3UgYXJlIHVz aW5nLiAgVGhhbmtzLgorCisgcmV0dXJuIDEKKyBjYXNlICQ/IGluCisgcmV0dXJuIDEKKyBmYWls PTEKKyBFeGl0IDEKKyBzZXQgK2UKKyBleGl0IDEKKyBleGl0IDEKKyByZW1vdmVfdG1wXworIF9f c3Q9MQorIGNsZWFudXBfCisgOgorIGNkIC9ob21lL3N0YWZmL3NlZC90ZXN0c3VpdGUKKyBjaG1v ZCAtUiB1K3J3eCAvaG9tZS9zdGFmZi9zZWQvdGVzdHN1aXRlL2d0LWludmFsaWQtbWItc2VxLVVN Ui5zaC41MDAwCisgcm0gLXJmIC9ob21lL3N0YWZmL3NlZC90ZXN0c3VpdGUvZ3QtaW52YWxpZC1t Yi1zZXEtVU1SLnNoLjUwMDAKKyBleGl0IDEKRkFJTCBpbnZhbGlkLW1iLXNlcS1VTVIuc2ggKGV4 aXQgc3RhdHVzOiAxKQoK --------_55495890000000006482_MULTIPART_MIXED_-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 06 22:18:31 2015 Received: (at 20490) by debbugs.gnu.org; 7 May 2015 02:18:31 +0000 Received: from localhost ([127.0.0.1]:36698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqBOQ-0007C7-6r for submit@debbugs.gnu.org; Wed, 06 May 2015 22:18:30 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:35262) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqBON-0007Bs-80 for 20490@debbugs.gnu.org; Wed, 06 May 2015 22:18:28 -0400 Received: by ieczm2 with SMTP id zm2so29070669iec.2 for <20490@debbugs.gnu.org>; Wed, 06 May 2015 19:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=YmD31Mny/cwrZBGDnYRRi0L690UuegT4uivPX5tLKng=; b=Fty9z8H2NMeEijShZdztNT6ETvgBxM5reCKck86YAWCBPDFCTGRCVbKWhMqTGZuRAY +u2vlJHJvXmITHRbQd9lpVny1bbUBhkv9g4FVcZseaicyy67oJgIHTs053Nj6076Oqbv vcP0FNWEyTMk9wboDWyGsimXMm/IFmN1J2Z/Hyk0HsQRcpGRaT52kZZ0cHcrmKEwiT5E yNQaHkpZVYqQnMwzygGH2VnIIr9wSLlpb759JhGGNsObfylqCKHcsQFBDSCpl7Vi0INa oqaYDG1/z6VkLeHuON/Sc9igL6wMC93mpCltricfQPRSwsJTySmzWMrQVd1hmu9PB2vs GNbg== X-Received: by 10.50.73.198 with SMTP id n6mr11736252igv.32.1430965101665; Wed, 06 May 2015 19:18:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.62.229 with HTTP; Wed, 6 May 2015 19:18:01 -0700 (PDT) In-Reply-To: <20150506085810.647C.27F6AC2D@kcn.ne.jp> References: <20150506085810.647C.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Wed, 6 May 2015 19:18:01 -0700 X-Google-Sender-Auth: rTAbeyIpbKTvbb_Pp8BS-rHOnYI Message-ID: Subject: Re: bug#20490: [PATCH] fixup: reference to uninitialized variable with invalid sequence To: Norihiro Tanaka Content-Type: multipart/mixed; boundary=089e011839a6923d1405157486f0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20490 Cc: 20490@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e011839a6923d1405157486f0 Content-Type: text/plain; charset=UTF-8 On Tue, May 5, 2015 at 4:58 PM, Norihiro Tanaka wrote: > > On Sun, 3 May 2015 10:06:00 -0700 > Jim Meyering wrote: > >> On Sat, May 2, 2015 at 7:09 PM, Jim Meyering wrote: >> > On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka wrote: >> >> Uninitialized variable are referred with invalid sequence in >> >> str_append_modified(). >> >> >> >> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc is >> >> uninitialized. below may return unexpected result in order that the >> >> value is referred at a following position in source code. >> >> >> >> $ echo a | LC_ALL=ja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/' >> > >> > Thank you for the patch and reproducer. >> > I've made some small improvements to the actual patch and >> > wrote a valgrind-using test that I'm adding to the test suite. >> > I've included your patch with an adjusted log, followed by >> > the changes I made to it in a separate commit. That commit >> > is separate solely to show what I've done; I will squash into your >> > commit before I push, followed by the test-adding commit. >> >> I've updated the commit log to reference this just-closed issue, >> with this line: >> >> This addresses http://debbugs.gnu.org/20490 >> >> Then pushed. > > I see that this bug itself is correctly fixed by the patch. > > I ran new test on CentOS 5.10 (x86), and ran accross an error in > attachment even after applying the patch. Thank you for the report and for testing. That is seems to be due to a bug in that old version of valgrind: +valgrind: m_debuginfo/readdwarf.c:2262 (copy_convert_CfiExpr_tree): Assertion 'srcix >= 0 && srcix < VG_(sizeXA)(srcxa)' failed. that is not exposed when the require_valgrind_ shell function tests valgrind against "true". We can easily accommodate that, so I wrote the attached patch. Can you verify that it causes the test to be skipped on your system? --089e011839a6923d1405157486f0 Content-Type: application/octet-stream; name="0001-tests-skip-the-new-test-in-presence-of-buggy-valgrin.patch" Content-Disposition: attachment; filename="0001-tests-skip-the-new-test-in-presence-of-buggy-valgrin.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i9djn9pt1 RnJvbSBjMzU0YzUyMDllYjMwNTZkZWYwY2Y3ZmEyMGM3MmFkOTM0ODgxZmZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog V2VkLCA2IE1heSAyMDE1IDE5OjE1OjM4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gdGVzdHM6IHNr aXAgdGhlIG5ldyB0ZXN0IGluIHByZXNlbmNlIG9mIGJ1Z2d5IHZhbGdyaW5kCgoqIHRlc3RzdWl0 ZS9pbnZhbGlkLW1iLXNlcS1VTVIuc2g6IFVwb24gZmFpbHVyZSBkdWUgdG8gYQp2YWxncmluZC1p bnRlcm5hbCBhc3NlcnRpb24sIHNraXAgdGhpcyB0ZXN0LgpSZXBvcnRlZCBieSBOb3JpaGlybyBU YW5ha2EgaW4gaHR0cDovL2RlYmJ1Z3MuZ251Lm9yZy8yMDQ5MAotLS0KIHRlc3RzdWl0ZS9pbnZh bGlkLW1iLXNlcS1VTVIuc2ggfCA1ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspCgpkaWZmIC0tZ2l0IGEvdGVzdHN1aXRlL2ludmFsaWQtbWItc2VxLVVNUi5zaCBiL3Rlc3Rz dWl0ZS9pbnZhbGlkLW1iLXNlcS1VTVIuc2gKaW5kZXggMzNiNThmYy4uZDc0YjViZSAxMDA3NTUK LS0tIGEvdGVzdHN1aXRlL2ludmFsaWQtbWItc2VxLVVNUi5zaAorKysgYi90ZXN0c3VpdGUvaW52 YWxpZC1tYi1zZXEtVU1SLnNoCkBAIC0yNiw2ICsyNiwxMSBAQCBlY2hvIGJDID4gZXhwIHx8IGZy YW1ld29ya19mYWlsdXJlXwogTENfQUxMPWphX0pQLmV1Y0pQIHZhbGdyaW5kIC0tcXVpZXQgLS1l cnJvci1leGl0Y29kZT0xIFwKICAgc2VkIC1lICdzL2EvYlxVXHhiMmMvJyBpbiA+IG91dCAyPiBl cnIgfHwgZmFpbD0xCgorIyBXb3JrIGFyb3VuZCBhIGJ1ZyBpbiBDZW50T1MgNS4xMCdzIHZhbGdy aW5kCisjIEZJWE1FOiByZW1vdmUgaW4gMjAxOCBvciB3aGVuIENlbnRPUyA1IGlzIG5vIGxvbmdl ciBvZmZpY2lhbGx5IHN1cHBvcnRlZAorZ3JlcCAndmFsZ3JpbmQ6IC4qQXNzZXJ0aW9uLipmYWls ZWQnIGVyciA+IC9kZXYvbnVsbCBcCisgICYmIHNraXBfICd5b3Ugc2VlbSB0byBoYXZlIGEgYnVn Z3kgdmVyc2lvbiBvZiB2YWxncmluZCcKKwogY29tcGFyZSBleHAgb3V0IHx8IGZhaWw9MQogY29t cGFyZSAvZGV2L251bGwgZXJyIHx8IGZhaWw9MQoKLS0gCjIuMy43Cgo= --089e011839a6923d1405157486f0-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 07 09:54:08 2015 Received: (at 20490) by debbugs.gnu.org; 7 May 2015 13:54:08 +0000 Received: from localhost ([127.0.0.1]:37176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqMFb-0003j1-Gc for submit@debbugs.gnu.org; Thu, 07 May 2015 09:54:07 -0400 Received: from mailgw04.kcn.ne.jp ([61.86.7.211]:50139) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqMFX-0003iT-9y for 20490@debbugs.gnu.org; Thu, 07 May 2015 09:54:05 -0400 Received: from mxs01-s (mailgw1.kcn.ne.jp [61.86.15.233]) by mailgw04.kcn.ne.jp (Postfix) with ESMTP id 0D7556C162D for <20490@debbugs.gnu.org>; Thu, 7 May 2015 22:53:56 +0900 (JST) X-matriXscan-loop-detect: 020abe6b5c6c8983f212219a38787e5fd9076da0 Received: from mail09.kcn.ne.jp ([61.86.6.188]) by mxs01-s with ESMTP; Thu, 07 May 2015 22:53:55 +0900 (JST) Received: from [10.120.1.69] (i118-21-128-66.s30.a048.ap.plala.or.jp [118.21.128.66]) by mail09.kcn.ne.jp (Postfix) with ESMTPA id 8300D1BD0096; Thu, 7 May 2015 22:53:55 +0900 (JST) Date: Thu, 07 May 2015 22:53:51 +0900 From: Norihiro Tanaka To: Jim Meyering Subject: Re: bug#20490: [PATCH] fixup: reference to uninitialized variable with invalid sequence In-Reply-To: References: <20150506085810.647C.27F6AC2D@kcn.ne.jp> Message-Id: <20150507225350.2574.27F6AC2D@kcn.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable X-Mailer: Becky! ver. 2.65.07 [ja] X-matriXscan-Sophos-AV: Clean X-matriXscan-Action: Approve X-matriXscan: Uncategorized X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 20490 Cc: 20490@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Wed, 6 May 2015 19:18:01 -0700 Jim Meyering wrote: > On Tue, May 5, 2015 at 4:58 PM, Norihiro Tanaka wrote= : > > > > On Sun, 3 May 2015 10:06:00 -0700 > > Jim Meyering wrote: > > > >> On Sat, May 2, 2015 at 7:09 PM, Jim Meyering wrote: > >> > On Wed, Nov 5, 2014 at 7:36 AM, Norihiro Tanaka = wrote: > >> >> Uninitialized variable are referred with invalid sequence in > >> >> str_append_modified(). > >> >> > >> >> When mbrtowc() returns (size_t) -1, wc is not changed, even if wc i= s > >> >> uninitialized. below may return unexpected result in order that th= e > >> >> value is referred at a following position in source code. > >> >> > >> >> $ echo a | LC_ALL=3Dja_JP.eucJP ./sed/sed -e 's/a/b\U\xb2c/' > >> > > >> > Thank you for the patch and reproducer. > >> > I've made some small improvements to the actual patch and > >> > wrote a valgrind-using test that I'm adding to the test suite. > >> > I've included your patch with an adjusted log, followed by > >> > the changes I made to it in a separate commit. That commit > >> > is separate solely to show what I've done; I will squash into your > >> > commit before I push, followed by the test-adding commit. > >> > >> I've updated the commit log to reference this just-closed issue, > >> with this line: > >> > >> This addresses http://debbugs.gnu.org/20490 > >> > >> Then pushed. > > > > I see that this bug itself is correctly fixed by the patch. > > > > I ran new test on CentOS 5.10 (x86), and ran accross an error in > > attachment even after applying the patch. >=20 > Thank you for the report and for testing. > That is seems to be due to a bug in that old version of valgrind: >=20 > +valgrind: m_debuginfo/readdwarf.c:2262 (copy_convert_CfiExpr_tree): > Assertion 'srcix >=3D 0 && srcix < VG_(sizeXA)(srcxa)' failed. >=20 > that is not exposed when the require_valgrind_ > shell function tests valgrind against "true". >=20 > We can easily accommodate that, so I wrote the attached patch. > Can you verify that it causes the test to be skipped on your > system? Thanks for fixing the bug. I re-try with new version of valgrind, and succeed for the test. I also confirmed that the test is skipped with old version. =2E..... PASS: help-version.sh invalid-mb-seq-UMR.sh: skipped test: requires a working valgrind SKIP: invalid-mb-seq-UMR.sh PASS: range-overlap.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D Testsuite summary for GNU sed 4.2.2.81-aeb3-dirty =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D # TOTAL: 69 # PASS: 68 # SKIP: 1 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D =2E..... From debbugs-submit-bounces@debbugs.gnu.org Thu May 07 11:20:31 2015 Received: (at 20490) by debbugs.gnu.org; 7 May 2015 15:20:31 +0000 Received: from localhost ([127.0.0.1]:37946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqNbD-00063m-0A for submit@debbugs.gnu.org; Thu, 07 May 2015 11:20:31 -0400 Received: from mail-ig0-f182.google.com ([209.85.213.182]:33210) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YqNbA-00063Y-JB for 20490@debbugs.gnu.org; Thu, 07 May 2015 11:20:29 -0400 Received: by igbpi8 with SMTP id pi8so13433175igb.0 for <20490@debbugs.gnu.org>; Thu, 07 May 2015 08:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=t1wjXgNNKGTacHV5BQAYW2v3CQ8dJDE3gP8hQiz3sKI=; b=TxMeAU2YMzySOcyeKfqZ6uf8dGOWq6PlcknmydXt8JmoFmUQtNel+aBwBvynqNjqSd 6Ao0hL4OhtSoJrEBRj/xb9ZTdrNED3uOW/Qk13otvQo2UxFsvEev45apDvTnYja6w+7w WaPSNjm9Ty+l31znv1m03RTqwbDBwbGbILEw/GoXtbAGAdQuL8ODS0Dr1WqI+3acYyr4 SGo4VNyCI6uFuNf2W3XIi1R6JzWsrkgCFF94YIaGkLvjbKJ7CDSFLLDY2Pde0xPDjYKo xPZ9KbRKj//l1TJWOu09Iyti+fVLOsu9jkjdJQWom9CYYrfjIpImji6AnIqyrZDcCzLT gjyw== X-Received: by 10.42.79.147 with SMTP id r19mr4248497ick.5.1431012023009; Thu, 07 May 2015 08:20:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.62.229 with HTTP; Thu, 7 May 2015 08:20:02 -0700 (PDT) In-Reply-To: <20150507225350.2574.27F6AC2D@kcn.ne.jp> References: <20150506085810.647C.27F6AC2D@kcn.ne.jp> <20150507225350.2574.27F6AC2D@kcn.ne.jp> From: Jim Meyering Date: Thu, 7 May 2015 08:20:02 -0700 X-Google-Sender-Auth: 9POUmW66shF31J-VPqvU6rTKOiE Message-ID: Subject: Re: bug#20490: [PATCH] fixup: reference to uninitialized variable with invalid sequence To: Norihiro Tanaka Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 20490 Cc: 20490 <20490@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, May 7, 2015 at 6:53 AM, Norihiro Tanaka wrote: > On Wed, 6 May 2015 19:18:01 -0700 > Jim Meyering wrote: > >> On Tue, May 5, 2015 at 4:58 PM, Norihiro Tanaka wrote: ... >> We can easily accommodate that, so I wrote the attached patch. >> Can you verify that it causes the test to be skipped on your >> system? > > Thanks for fixing the bug. I re-try with new version of valgrind, and > succeed for the test. I also confirmed that the test is skipped with > old version. Thanks. Pushed. From unknown Fri Jun 20 20:00:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Jun 2015 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator