From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 02:48:24 2015 Received: (at submit) by debbugs.gnu.org; 2 May 2015 06:48:24 +0000 Received: from localhost ([127.0.0.1]:59077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoRDr-0001Og-7Y for submit@debbugs.gnu.org; Sat, 02 May 2015 02:48:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41799) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoRDp-0001OR-2V for submit@debbugs.gnu.org; Sat, 02 May 2015 02:48:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YoRDi-0006CU-LO for submit@debbugs.gnu.org; Sat, 02 May 2015 02:48:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37335) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YoRDi-0006CQ-IT for submit@debbugs.gnu.org; Sat, 02 May 2015 02:48:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YoRDh-000883-6J for bug-gnu-emacs@gnu.org; Sat, 02 May 2015 02:48:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YoRDd-0006Bw-U5 for bug-gnu-emacs@gnu.org; Sat, 02 May 2015 02:48:13 -0400 Received: from nm2-vm1.bullet.mail.bf1.yahoo.com ([98.139.213.158]:38678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YoRDd-0006Bi-OS for bug-gnu-emacs@gnu.org; Sat, 02 May 2015 02:48:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1430549288; bh=Vil9ImUlrkUsOBY+PCC/kCnvsfEcG/7gi3obWJvq87o=; h=From:To:Subject:Date:From:Subject; b=hYkJ400QpXVxzfNmva0Z16Z6PgKBLNYmZdUidNtt7G4kMDxPg5AjYik5ZLXYrR7fjwo2q2hT6nvE+5gRKOFxA5mZe2HFNK4/QCFioszcfTGkltYtno6mX3zm5nK9yCdcO6o3yoxwFGz1fJ/E2dmdsXMMnh3lXAdfQp/nK4dPKvUbMgKDZHl4kB/063hIQT/DPMN6hETDkgdymooDKbkFxfqR//A2dTUK7xAJwy2OPJRHnUwjm04VIMLwUZ+ocaqkcNrogS6XD6xCKyt8r22yUUKZKeBBXinMH3ImTegFg2q+2oOJng9B86QE3Y7hiN+FBLJEvAUdRk/8v34B+BB6Sg== Received: from [66.196.81.170] by nm2.bullet.mail.bf1.yahoo.com with NNFMP; 02 May 2015 06:48:08 -0000 Received: from [68.142.230.75] by tm16.bullet.mail.bf1.yahoo.com with NNFMP; 02 May 2015 06:48:08 -0000 Received: from [127.0.0.1] by smtp232.mail.bf1.yahoo.com with NNFMP; 02 May 2015 06:48:08 -0000 X-Yahoo-Newman-Id: 481850.78389.bm@smtp232.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: QdNt05MVM1klQ7KmVGTD2Nnw9C5Um.vG7hmTvc5o2ck3OiZ AWi6nMO89uVufOtmviPRL5ECbEEMOHevul6ZOMh5Kpm53JIsNeguG0f7.TDn Ff8VHvlf8_.j_v7vzmujQiEFkuR.KmOTSO0AYVXHRbbgdQREsLvSc5YXCFYn q9mF7ILD3tMYAgFWA0zMcmex5JZS.qOLzudeGWntC9iHy.djc7QuLk7WY8DT NDOkSQIlQgwBT8yFsilDdIkWKbrslrLsyONJ9SANApABsh6PEsumQ8203Bty TGnNwrcKxSCoyf0u_2Aju00hHgEKZVIhHKHcG2ElsuiZyok8SIPvru_PnZ5H oT5z7apx00IOlVEtkiQBmNK9YNi00No.fqW1kl2ielLQdrBPyIZAEsw41R2E f2xGAMarxfAQh91MGOpfzMJkjSsxl96FIHx8qWkGsHza878cNskEOe7awAXu LpwDtx8BD7vPcYj4s4m3txuHQjYEn6JVcKcdLh56FtIxCE.ElGv9rSOFIihB LG20Uf9F0KGAnNddjrEvL.xdBjLN4D9G0s7SJSYTM X-Yahoo-SMTP: U8NKAo6swBAxDIMUovTitGGHebxdYQBZ5A-- From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 24.4; ispell.el new LocalWords together with existing Date: Sat, 02 May 2015 16:46:43 +1000 Message-ID: <878ud7zdbg.fsf@blah.blah> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain When ispell.el "A" adds a new LocalWords line it always puts it at the end of the file. It'd be good to put it with existing such lines if there are some. This helps if LocalWords are deliberately not at the very end of file, eg. before a special footer. foo.el below shows this in an elisp file M-x find-file foo.el M-x eval-buffer => alas new LocalWords line after the ";;; foo.el ends here" footer I hoped LocalWords with the existing ones would avoid upsetting the footer bit. I get some joy from the diff below. The existing (open-line) and (newline) are unchanged for the case no existing LocalWords so add at end of file. I'm fairly confident of my (insert "\n") when adding after an existing LocalWords line, since since don't want `newline' to auto-fill or otherwise mangle that line. (But I'm ready to be persuaded if there's some left indent or similar to apply which I don't know.) 2015-05-02 Kevin Ryde * textmodes/ispell.el (ispell-add-per-file-word-list): Add new LocalWords line just after existing such lines. Good to keep words together or if deliberately placed somewhere special. --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=foo.el Content-Transfer-Encoding: quoted-printable ;;; foo.el --- blah ;;; Code: (require 'ispell) (ispell-add-per-file-word-list "abc") ;; LocalWords: this is some local words lines which are full so must inse= rt a new ;; LocalWords: such line but would like it added here together with exist= ing lines ;; Local variables: ;; fill-column: 60 ;; tab-width: 8 ;; End: (provide 'foo) ;;; foo.el ends here --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=ispell.el.diff --- ispell.el.orig 2015-05-02 11:24:32.000000000 +1000 +++ ispell.el 2015-05-02 14:34:42.573950776 +1000 @@ -4320,7 +4320,7 @@ (let (line-okay search done found) (while (not done) (let ((case-fold-search nil)) - (setq search (search-forward ispell-words-keyword nil 'move) + (setq search (search-forward ispell-words-keyword nil t) found (or found search) line-okay (< (+ (length word) 1 ; 1 for space after word.. (progn (end-of-line) (current-column))) @@ -4331,8 +4331,10 @@ (setq done t) (if (null search) (progn - (open-line 1) - (unless found (newline)) + (if found (insert "\n") ;; after an existing LocalWords + (goto-char (point-max)) ;; no LocalWords, go to end of file + (open-line 1) + (newline)) (insert (if comment-start (concat (if (fboundp 'comment-padright) --=-=-= Content-Type: text/plain In GNU Emacs 24.4.1 (i586-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2015-03-08 on binet, modified by Debian Configured using: `configure --build i586-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp --build i586-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp --with-x=yes --with-x-toolkit=lucid --with-toolkit-scroll-bars --without-gconf --without-gsettings 'CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-z,relro' --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 08:19:10 2020 Received: (at 20486) by debbugs.gnu.org; 21 Aug 2020 12:19:10 +0000 Received: from localhost ([127.0.0.1]:45294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k960j-0005AQ-4K for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:19:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k960T-00059M-OB for 20486@debbugs.gnu.org; Fri, 21 Aug 2020 08:19:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4ImxQxSiTR7aNMMDeAfNI+6r+Ck7ItQ4Q7eFWiqQTu8=; b=rI84vL1+vALglOn+XwgXrmnLYu byqABuC6YkyxJJqtymTj+r1kFBDCDYE5ToCN0Q8FLnHZmDDAeRmWL9ddce/myoeJHni4Q0O04WqcU iCeW7R6WI+2Wb1PcNtuWKKdiMGmzOdMw6tFPcETs6EUHXwM4UW1v94lro1mf9YYcWIoo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k960I-0003TQ-CB; Fri, 21 Aug 2020 14:18:47 +0200 From: Lars Ingebrigtsen To: Kevin Ryde Subject: Re: bug#20486: 24.4; ispell.el new LocalWords together with existing References: <878ud7zdbg.fsf@blah.blah> X-Now-Playing: Peter Zummo's _Deep Drive_: "Actual Serpentine" Date: Fri, 21 Aug 2020 14:18:40 +0200 In-Reply-To: <878ud7zdbg.fsf@blah.blah> (Kevin Ryde's message of "Sat, 02 May 2015 16:46:43 +1000") Message-ID: <871rk06vkv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kevin Ryde writes: > * textmodes/ispell.el (ispell-add-per-file-word-list): Add new > LocalWords line just after existing such lines. Good to keep words > together or if deliberately placed somewhere special. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20486 Cc: 20486@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kevin Ryde writes: > * textmodes/ispell.el (ispell-add-per-file-word-list): Add new > LocalWords line just after existing such lines. Good to keep words > together or if deliberately placed somewhere special. Looks good to me. I tested with the test file, and without any localwords, and it seems to work for me, so I've applied your patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 21 08:19:04 2020 Received: (at control) by debbugs.gnu.org; 21 Aug 2020 12:19:04 +0000 Received: from localhost ([127.0.0.1]:45292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k960d-0005A8-Vv for submit@debbugs.gnu.org; Fri, 21 Aug 2020 08:19:04 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k960b-00059Z-CL for control@debbugs.gnu.org; Fri, 21 Aug 2020 08:19:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wysq7fYJ8GqThl2jAz2VldSvLOIQaIyOUraR0tXZesg=; b=jKm4RYYLI3LE0bm8vI6skQr/Nl 6LnhvI/ADCjTOcy9NEmQJSiYjxL1MU7s9OCyqFQUlekD5Y92oLpnqNYXnZjiCujz6m9/8Q8nIfyOk epFqsAQCRPKiRqvShxoLrQJ4PUG9UUCTqSh83roDAESoZQb1+GwXbmL/PIlDXO70ZZho=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k960T-0003Tb-Kg for control@debbugs.gnu.org; Fri, 21 Aug 2020 14:18:55 +0200 Date: Fri, 21 Aug 2020 14:18:52 +0200 Message-Id: <87zh6o5h03.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #20486 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 20486 + patch tags 20486 fixed close 20486 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 20486 + patch tags 20486 fixed close 20486 28.1 quit From unknown Mon Jun 23 07:49:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Sep 2020 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator