GNU bug report logs - #20455
elisp-completion-at-point not compatible replacement for lisp-completion-at-point

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 20455 in the body.
You can then email your comments to 20455 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: elisp-completion-at-point not compatible replacement for
 lisp-completion-at-point
Date: Wed, 29 Apr 2015 02:57:39 -0400

Package: emacs
Version: 25.0.50


In Emacs 24.5:
(lisp-completion-at-point &optional PREDICATE)
   ; PREDICATE is unused, but I don't see that this affects the following


In current master:
lisp-completion-at-point is an alias for `elisp-completion-at-point'.


But elisp-completion-at-point takes no arguments.
Therefore this is an incompatible change.

This is presumably why attempting to use lisp-complete-symbol throws a
wrong-number-of-arguments error.

(Why doesn't the byte-compiler warn about this arglist mismatch?)

Message #8 received at 20455 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Glenn Morris <rgm <at> gnu.org>, 20455 <at> debbugs.gnu.org
Subject: Re: bug#20455: elisp-completion-at-point not compatible replacement
 for lisp-completion-at-point
Date: Wed, 29 Apr 2015 14:11:23 +0300

On 04/29/2015 09:57 AM, Glenn Morris wrote:

> This is presumably why attempting to use lisp-complete-symbol throws a
> wrong-number-of-arguments error.

Can we remove it? It has already been declared obsolete in a previous 
version.

> (Why doesn't the byte-compiler warn about this arglist mismatch?)

It does here:

In lisp-complete-symbol:
lisp.el:754:17:Warning: lisp-completion-at-point called with 1 argument, but
    accepts only 0
lisp.el:754:17:Warning: `lisp-completion-at-point' is an obsolete 
function (as
    of 25.1); use `elisp-completion-at-point' instead.

Message #11 received at 20455 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 20455 <at> debbugs.gnu.org
Subject: Re: bug#20455: elisp-completion-at-point not compatible replacement
 for lisp-completion-at-point
Date: Wed, 29 Apr 2015 11:50:08 -0400

Dmitry Gutov wrote:

> Can we remove it? It has already been declared obsolete in a previous
> version.

Too soon IMO.
The trivial solution: make elisp-completion-at-point take an optional
arg that does nothing. Or don't make lisp-completion-at-point an alias
to it.

>> (Why doesn't the byte-compiler warn about this arglist mismatch?)
>
> It does here:
>
> In lisp-complete-symbol:
> lisp.el:754:17:Warning: lisp-completion-at-point called with 1 argument, but
>     accepts only 0
> lisp.el:754:17:Warning: `lisp-completion-at-point' is an obsolete
> function (as
>     of 25.1); use `elisp-completion-at-point' instead.

I filed a separate bug about that; but for the record, no such warning
when bootstrapping for me nor, for eg
http://hydra.nixos.org/build/21790217/log/raw

Message #14 received at 20455 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 20455 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#20455: elisp-completion-at-point not compatible replacement
 for lisp-completion-at-point
Date: Wed, 29 Apr 2015 17:17:17 -0400

> arg that does nothing. Or don't make lisp-completion-at-point an alias
> to it.

Exactly, make it into a wrapper,


        Stefan

Message #19 received at 20455-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Glenn Morris <rgm <at> gnu.org>
Cc: 20455-done <at> debbugs.gnu.org
Subject: Re: bug#20455: elisp-completion-at-point not compatible replacement
 for lisp-completion-at-point
Date: Mon, 30 Nov 2015 05:29:29 +0200

Version: 25.1

On 04/30/2015 12:17 AM, Stefan Monnier wrote:

> Exactly, make it into a wrapper,

Done, in 50b8c55.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.