GNU bug report logs - #20452
25.0.50; [PATCH] Invalid compilation warning about GTK+ when using GTK+ 3

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Aku Kotkavuo <aku.kotkavuo <at> gmail.com>
Subject: bug#20452: closed (Re: bug#20452: 25.0.50; [PATCH] Invalid
 compilation warning about GTK+ when using GTK+ 3)
Date: Thu, 07 May 2015 18:11:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#20452: 25.0.50; [PATCH] Invalid compilation warning about GTK+ when using GTK+ 3

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 20452 <at> debbugs.gnu.org.

-- 
20452: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20452
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Jan D." <jan.h.d <at> swipnet.se>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 20452-done <at> debbugs.gnu.org, Glenn Morris <rgm <at> gnu.org>,
 Aku Kotkavuo <aku.kotkavuo <at> gmail.com>
Subject: Re: bug#20452: 25.0.50;
 [PATCH] Invalid compilation warning about GTK+ when using GTK+ 3
Date: Thu, 7 May 2015 20:09:54 +0200

Fixed in trunk.

	Jan D.

> 29 apr 2015 kl. 15:30 skrev Stefan Monnier <monnier <at> iro.umontreal.ca>:
> 
>> Is there an open bug filed in GTK+ bugzilla for this?
> 
> Of course: http://bugzilla.gnome.org/show_bug.cgi?id=85715
> 
>> I tried to search for something that matches the description but
>> I came up empty.
> 
> Indeed, we emit the above URL from emacs.c when we're about to crash,
> but we could/should also include this URL in the configure.ac message,
> I think.
> 
> 
>        Stefan

[Message part 3 (message/rfc822, inline)]

From: Aku Kotkavuo <aku.kotkavuo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50;
 [PATCH] Invalid compilation warning about GTK+ when using GTK+ 3
Date: Wed, 29 Apr 2015 02:57:04 +0300

When compiling the latest version of Emacs, I encountered a warning
about my GTK+ version during the configuration phase:

> configure: WARNING: Your version of Gtk+ will have problems with
>        closing open displays.  This is no problem if you just use
>        one display, but if you use more than one and close one of them
>        Emacs may crash.

This seemed curious to me, so I dug in a little deeper and noticed that
this part of the configure script was written in 2008 and was supposed
to warn users of GTK+ 2.8 and earlier, released in 2005. I'm using GTK+
3.14.

I wrote a tiny patch to fix the check.

(Maybe the whole warning should be removed? Is there someone still using
GTK+ 2.8 or older?)


From 25ada920247cda3ed9d074c7e3eab6313548370d Mon Sep 17 00:00:00 2001
From: Aku Kotkavuo <aku.kotkavuo <at> gmail.com>
Date: Wed, 29 Apr 2015 00:32:19 +0300
Subject: [PATCH] Don't warn about too old GTK+ when using GTK+ 3

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index d2f21ee..2d2fefa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2496,7 +2496,7 @@ if test x"$pkg_check_gtk" = xyes; then
     GTK_OBJ="gtkutil.o $GTK_OBJ"
     term_header=$gtk_term_header
     USE_X_TOOLKIT=none
-    if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then
+    if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0 || "$PKG_CONFIG" gtk+-3.0; then
       :
     else
       AC_MSG_WARN([[Your version of Gtk+ will have problems with
-- 
2.1.4

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.