GNU bug report logs - #20419
25.0.50; doc string of `recenter-last-op`

Previous Next

Full log

Message #22 received at 20419 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 20419 <at> debbugs.gnu.org
Subject: Re: bug#20419: 25.0.50; doc string of `recenter-last-op`
Date: Sat, 25 Apr 2015 19:14:29 +0300

> Date: Sat, 25 Apr 2015 09:12:07 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> Cc: 20419-done <at> debbugs.gnu.org
> 
> > Yuck!  Why not set it to the first member of recenter-positions to
> > begin with?
> > 
> > FWIW, I consider this, including the exposure of this variable as
> > some kind of knob for other Lisp packages, bad style.  You should be
> > demanding cleaning this up instead of documenting it.
> > 
> > Fixed under protest.
> 
> Point taken.  A better design (for its use in `perform-replace')
> might bind `recenter-last-op' to the car of `recenter-positions'.

I'd rather suggest to have a simple function, recenter-reset-cycle,
say, and then hide its internals inside window.el.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.