GNU bug report logs - #20419
25.0.50; doc string of `recenter-last-op`

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Drew Adams <drew.adams <at> oracle.com>
Subject: bug#20419: closed (Re: bug#20419: 25.0.50; doc string of
 `recenter-last-op`)
Date: Sat, 25 Apr 2015 14:56:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#20419: 25.0.50; doc string of `recenter-last-op`

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 20419 <at> debbugs.gnu.org.

-- 
20419: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20419
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 20419-done <at> debbugs.gnu.org
Subject: Re: bug#20419: 25.0.50; doc string of `recenter-last-op`
Date: Sat, 25 Apr 2015 17:55:27 +0300

> Date: Sat, 25 Apr 2015 07:29:20 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> Cc: 20419 <at> debbugs.gnu.org
> 
> > > The doc string says that these are the possible values:
> > > "`top', `middle', `bottom', integer or float numbers."
> > > It should also mention `nil', say what `nil' means, and
> > > perhaps even say that `nil' is the default value.
> > 
> > How do you see that nil has any meaning whatsoever?
> 
> `nil' means that the next `recenter-top-bottom' starts with
> the first element of `recenter-positions'.

Yuck!  Why not set it to the first member of recenter-positions to
begin with?

FWIW, I consider this, including the exposure of this variable as some
kind of knob for other Lisp packages, bad style.  You should be
demanding cleaning this up instead of documenting it.

Fixed under protest.

[Message part 3 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.50; doc string of `recenter-last-op`
Date: Fri, 24 Apr 2015 10:16:11 -0700 (PDT)

The doc string says that these are the possible values:

"`top', `middle', `bottom', integer or float numbers."

It should also mention `nil', say what `nil' means, and perhaps even say
that `nil' is the default value.

A user reading things like the binding of this variable to nil in
`perform-replace' is not helped by consulting the variable's doc.



In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2014-10-20 on LEG570
Bzr revision: 118168 rgm <at> gnu.org-20141020195941-icp42t8ttcnud09g
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking=yes,glyphs CPPFLAGS=-DGLYPH_DEBUG=1'

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.