From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 24 13:16:28 2015 Received: (at submit) by debbugs.gnu.org; 24 Apr 2015 17:16:28 +0000 Received: from localhost ([127.0.0.1]:38904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlhDH-00057h-8Y for submit@debbugs.gnu.org; Fri, 24 Apr 2015 13:16:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51990) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YlhDF-00057V-0v for submit@debbugs.gnu.org; Fri, 24 Apr 2015 13:16:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlhD8-0003b9-Qj for submit@debbugs.gnu.org; Fri, 24 Apr 2015 13:16:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlhD8-0003b5-Ou for submit@debbugs.gnu.org; Fri, 24 Apr 2015 13:16:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlhD7-0004O1-Uq for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2015 13:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlhD3-0003Yy-7c for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2015 13:16:17 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlhD2-0003Yu-Vl for bug-gnu-emacs@gnu.org; Fri, 24 Apr 2015 13:16:13 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3OHGBZn002100 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 24 Apr 2015 17:16:12 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t3OHGBZG002759 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Fri, 24 Apr 2015 17:16:11 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3OHGBoM015273 for ; Fri, 24 Apr 2015 17:16:11 GMT MIME-Version: 1.0 Message-ID: <3c528679-060f-45ce-994c-fdbaada6de9d@default> Date: Fri, 24 Apr 2015 10:16:11 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.50; doc string of `recenter-last-op` X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The doc string says that these are the possible values: "`top', `middle', `bottom', integer or float numbers." It should also mention `nil', say what `nil' means, and perhaps even say that `nil' is the default value. A user reading things like the binding of this variable to nil in `perform-replace' is not helped by consulting the variable's doc. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1' From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 03:36:00 2015 Received: (at 20419) by debbugs.gnu.org; 25 Apr 2015 07:36:00 +0000 Received: from localhost ([127.0.0.1]:39235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ylud6-0008Jo-7v for submit@debbugs.gnu.org; Sat, 25 Apr 2015 03:36:00 -0400 Received: from mtaout27.012.net.il ([80.179.55.183]:54674) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ylud3-0008JY-0W for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 03:35:58 -0400 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NNC00L00Q6DSG00@mtaout27.012.net.il> for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 10:30:54 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNC00G7NQ7HME40@mtaout27.012.net.il>; Sat, 25 Apr 2015 10:30:54 +0300 (IDT) Date: Sat, 25 Apr 2015 10:35:34 +0300 From: Eli Zaretskii Subject: Re: bug#20419: 25.0.50; doc string of `recenter-last-op` In-reply-to: <3c528679-060f-45ce-994c-fdbaada6de9d@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83tww4y81l.fsf@gnu.org> References: <3c528679-060f-45ce-994c-fdbaada6de9d@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20419 Cc: 20419@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 24 Apr 2015 10:16:11 -0700 (PDT) > From: Drew Adams > > The doc string says that these are the possible values: > > "`top', `middle', `bottom', integer or float numbers." > > It should also mention `nil', say what `nil' means, and perhaps even say > that `nil' is the default value. How do you see that nil has any meaning whatsoever? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 10:29:30 2015 Received: (at 20419) by debbugs.gnu.org; 25 Apr 2015 14:29:30 +0000 Received: from localhost ([127.0.0.1]:39885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym15F-0002sh-QF for submit@debbugs.gnu.org; Sat, 25 Apr 2015 10:29:30 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:40554) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym15D-0002sT-3H for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 10:29:27 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3PETKYW018197 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 25 Apr 2015 14:29:21 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t3PETKL4008929 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 25 Apr 2015 14:29:20 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t3PETJ36015049; Sat, 25 Apr 2015 14:29:19 GMT MIME-Version: 1.0 Message-ID: <162fcb99-b1ac-4afa-8c95-e8d171f07153@default> Date: Sat, 25 Apr 2015 07:29:20 -0700 (PDT) From: Drew Adams To: Eli Zaretskii Subject: RE: bug#20419: 25.0.50; doc string of `recenter-last-op` References: <<3c528679-060f-45ce-994c-fdbaada6de9d@default>> <<83tww4y81l.fsf@gnu.org>> In-Reply-To: <<83tww4y81l.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20419 Cc: 20419@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > The doc string says that these are the possible values: > > "`top', `middle', `bottom', integer or float numbers." > > It should also mention `nil', say what `nil' means, and > > perhaps even say that `nil' is the default value. >=20 > How do you see that nil has any meaning whatsoever? `nil' means that the next `recenter-top-bottom' starts with the first element of `recenter-positions'. It has the effect (meaning) that, as the two comments in that replace.el code take the trouble to say, it "resets recenter cycling order to initial position". With that info added to the doc string, those comments can be removed, and Lisp users will understand immediately that they can do the same thing: bind it to nil to get that effect. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 10:55:51 2015 Received: (at 20419-done) by debbugs.gnu.org; 25 Apr 2015 14:55:52 +0000 Received: from localhost ([127.0.0.1]:39915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym1Ul-0003ZF-5o for submit@debbugs.gnu.org; Sat, 25 Apr 2015 10:55:51 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:60365) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym1Ui-0003Z0-KX for 20419-done@debbugs.gnu.org; Sat, 25 Apr 2015 10:55:50 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NND00G00ADY0L00@a-mtaout22.012.net.il> for 20419-done@debbugs.gnu.org; Sat, 25 Apr 2015 17:55:42 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NND00FKZASTN570@a-mtaout22.012.net.il>; Sat, 25 Apr 2015 17:55:42 +0300 (IDT) Date: Sat, 25 Apr 2015 17:55:27 +0300 From: Eli Zaretskii Subject: Re: bug#20419: 25.0.50; doc string of `recenter-last-op` In-reply-to: <162fcb99-b1ac-4afa-8c95-e8d171f07153@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83iockxnog.fsf@gnu.org> References: <162fcb99-b1ac-4afa-8c95-e8d171f07153@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20419-done Cc: 20419-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 25 Apr 2015 07:29:20 -0700 (PDT) > From: Drew Adams > Cc: 20419@debbugs.gnu.org > > > > The doc string says that these are the possible values: > > > "`top', `middle', `bottom', integer or float numbers." > > > It should also mention `nil', say what `nil' means, and > > > perhaps even say that `nil' is the default value. > > > > How do you see that nil has any meaning whatsoever? > > `nil' means that the next `recenter-top-bottom' starts with > the first element of `recenter-positions'. Yuck! Why not set it to the first member of recenter-positions to begin with? FWIW, I consider this, including the exposure of this variable as some kind of knob for other Lisp packages, bad style. You should be demanding cleaning this up instead of documenting it. Fixed under protest. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 12:12:17 2015 Received: (at 20419-done) by debbugs.gnu.org; 25 Apr 2015 16:12:17 +0000 Received: from localhost ([127.0.0.1]:39932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2gj-0005P1-8v for submit@debbugs.gnu.org; Sat, 25 Apr 2015 12:12:17 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:18900) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2gg-0005Oo-Vt for 20419-done@debbugs.gnu.org; Sat, 25 Apr 2015 12:12:15 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3PGC7di017100 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 25 Apr 2015 16:12:08 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t3PGC79A018836 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 25 Apr 2015 16:12:07 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3PGC6sK028626; Sat, 25 Apr 2015 16:12:07 GMT MIME-Version: 1.0 Message-ID: <45b241f3-fe0d-4147-8726-0c06361f2199@default> Date: Sat, 25 Apr 2015 09:12:07 -0700 (PDT) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#20419: 25.0.50; doc string of `recenter-last-op` References: <<162fcb99-b1ac-4afa-8c95-e8d171f07153@default>> <<83iockxnog.fsf@gnu.org>> In-Reply-To: <<83iockxnog.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20419-done Cc: 20419-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > > > The doc string says that these are the possible values: > > > > "`top', `middle', `bottom', integer or float numbers." > > > > It should also mention `nil', say what `nil' means, and > > > > perhaps even say that `nil' is the default value. > > > > > > How do you see that nil has any meaning whatsoever? > > > > `nil' means that the next `recenter-top-bottom' starts with > > the first element of `recenter-positions'. >=20 > Yuck! Why not set it to the first member of recenter-positions to > begin with? >=20 > FWIW, I consider this, including the exposure of this variable as > some kind of knob for other Lisp packages, bad style. You should be > demanding cleaning this up instead of documenting it. >=20 > Fixed under protest. Point taken. A better design (for its use in `perform-replace') might bind `recenter-last-op' to the car of `recenter-positions'. (The code also resets it later in `perform-replace'. That setq would also need to be changed, the same way.) Or get rid of `recenter-last-op' and just have code bind and set option `recenter-positions'... But Emacs dev generally doesn't like to do that, even locally. As long as we have something like `recenter-last-op', it is like `kill-ring-yank-pointer': it will be used by other code and needs to be documented. Please consider filing that bug report/enhancement request (or consider fixing it in the context of this one), if you like. But the behavior of nil remains unchanged. It still needs to be mentioned in the doc string, as long as it has the effect it has. Thanks for having fixed that. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 12:14:54 2015 Received: (at 20419) by debbugs.gnu.org; 25 Apr 2015 16:14:54 +0000 Received: from localhost ([127.0.0.1]:39936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2jF-0005Su-UR for submit@debbugs.gnu.org; Sat, 25 Apr 2015 12:14:54 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:42404) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2jD-0005Sf-6G for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 12:14:52 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NND00G00E2VIF00@a-mtaout22.012.net.il> for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 19:14:44 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NND00GB4EGJCU40@a-mtaout22.012.net.il>; Sat, 25 Apr 2015 19:14:44 +0300 (IDT) Date: Sat, 25 Apr 2015 19:14:29 +0300 From: Eli Zaretskii Subject: Re: bug#20419: 25.0.50; doc string of `recenter-last-op` In-reply-to: <45b241f3-fe0d-4147-8726-0c06361f2199@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83fv7oxk0q.fsf@gnu.org> References: <45b241f3-fe0d-4147-8726-0c06361f2199@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 20419 Cc: 20419@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 25 Apr 2015 09:12:07 -0700 (PDT) > From: Drew Adams > Cc: 20419-done@debbugs.gnu.org > > > Yuck! Why not set it to the first member of recenter-positions to > > begin with? > > > > FWIW, I consider this, including the exposure of this variable as > > some kind of knob for other Lisp packages, bad style. You should be > > demanding cleaning this up instead of documenting it. > > > > Fixed under protest. > > Point taken. A better design (for its use in `perform-replace') > might bind `recenter-last-op' to the car of `recenter-positions'. I'd rather suggest to have a simple function, recenter-reset-cycle, say, and then hide its internals inside window.el. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 25 12:33:28 2015 Received: (at 20419) by debbugs.gnu.org; 25 Apr 2015 16:33:28 +0000 Received: from localhost ([127.0.0.1]:39941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym31D-0005uc-Pk for submit@debbugs.gnu.org; Sat, 25 Apr 2015 12:33:28 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21895) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym31C-0005uO-3C for 20419@debbugs.gnu.org; Sat, 25 Apr 2015 12:33:26 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3PGXJQc030032 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 25 Apr 2015 16:33:19 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t3PGXI4i008909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 25 Apr 2015 16:33:18 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3PGXIcA031373; Sat, 25 Apr 2015 16:33:18 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 25 Apr 2015 09:33:19 -0700 (PDT) From: Drew Adams To: Eli Zaretskii Subject: RE: bug#20419: 25.0.50; doc string of `recenter-last-op` References: <<45b241f3-fe0d-4147-8726-0c06361f2199@default>> <<83fv7oxk0q.fsf@gnu.org>> In-Reply-To: <<83fv7oxk0q.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 20419 Cc: 20419@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > I'd rather suggest to have a simple function, recenter-reset-cycle, > say, and then hide its internals inside window.el. Do you really think that is better than the kind of thing we do with/for `kill-ring-yank-pointer' and `search-ring-yank-pointer'? That code intentionally exposes the pointer variable. If you are sure, go for it. You might want to change the existing=20 code for that uses `*-ring-yank-pointer' similarly. I assume you would introduce another (internal) variable, which would get modified in place of the user option, or which would be a pointer (like `recenter-last-op' is now) to its current (last-used) index. Anyway, whether you do something like you propose or not, as long as we have the current design, the doc bug fix you made is helpful. From unknown Fri Jun 20 07:24:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 May 2015 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator