Subject: bug#20412: 25.0.50; Port not respected by ffap

From: Stefan Kangas <[email-masked]>
Date: Wed, 15 Jan 2020 06:01:45 +0100

Lars Ingebrigtsen <[email-masked]> writes:

> Marco Wahl <[email-masked]> writes:
>
>> - Have the text '/ssh:[email-masked]#2222:/root/' in buffer *scratch*.
>> - Put the cursor on the first slash.
>> - M-x find-file-at-point
>>
>> Result: the filespec with the port is not recognised.
>>
>> Patch proposal:
>
> [...]
>
>> -    (file "--:\\\\$\\{\\}+<>@-Z_[:alpha:]~*?" "<@" "@>;.,!:")
>> +    (file "--:\\\\$\\{\\}+<>@-Z_[:alpha:]~*?#" "<@" "@>;.,!:")
>
> I wonder whether this will lead to more false positives than the number
> of times it'll help with this syntax here.
>
> But since it does test whether the file exists, perhaps it's not a
> problem anyway.
>
> Anybody got an opinion here?

I don't have a strong opinion either way.  If we feel unsure about the
change, perhaps someone should try using this for a while to see how
well it works in practice.

Best regards,
Stefan Kangas